[koha-commits] main Koha release repository branch master updated. v18.11.00-922-gb879e68
Git repo owner
gitmaster at git.koha-community.org
Fri Mar 22 21:51:26 CET 2019
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via b879e68326fcebc549d8c5688973b824c31fd761 (commit)
via 52bceacd82cdf4e45b2e76bb7353bb84af1ee1b3 (commit)
via 441c64d63072d9cd6fd0a97d987dc99a9e0a73ab (commit)
via e95733da3c46bb9160bd1105a648d693ac4a7acf (commit)
via aab6564c8c74a94ebedf4fe7590f825cece9bb6d (commit)
via 58a07a2e6b18a9135b0f6dcf0b6c01616e768edb (commit)
via 8378c74c90009df0476f1832d67b859075654bee (commit)
via 352d46464ce1dac3d0c8b92f0c43ef583684fc42 (commit)
via 17e72b2b1c55d79a5c7cc3cbaa278552ab936c1c (commit)
via daac852c04eb0e9c866aef970f8a79e6db9261d3 (commit)
via e9fa69ca64e78cc9ea540e3fed1e9ffb1b3488fe (commit)
via ee73d577ed564d98e77cf25fcdadcbc594f7217c (commit)
via b794643bb075c0aa5de81f2481ae1df56f674309 (commit)
via f8c20ac4c91f22017093a2d8ed0dbb8b0a3738bc (commit)
via ee1f262f1466e96e9676b3650fe2300b55565d53 (commit)
via 7f3dd675b7f20bb011c2fb0659526c6fdf9195e4 (commit)
via 4e067c83e427e7d76227c11fd8d84780dca2cefb (commit)
via ce49552e6d46e098385a9d70f848793b7218f194 (commit)
via 2851d66254fe9dbb0edb2b8991e90de665063fd1 (commit)
via e7e27a934a1b1d968ea8d00116c0bf17bb196ec1 (commit)
via e18626b6f142128064317e95ef4a7fb089f4f48d (commit)
via 5b97398a3a88ab808121c958ddac5d1cd87ee63b (commit)
via 48484173e26bf9859984860a17089f09de5c8b6a (commit)
via 6e98cc4503cedba411371d4005be41b5822569c8 (commit)
via b6be4024196c9e62363eabf0d2ad0b9f9141d15c (commit)
via 717975abebe938a5e79ffc07055ed6190b43f206 (commit)
via 7a9a8f2f08e4b74af712d59e1f1f9f0a7b3205a0 (commit)
via 32020105e8494ba82a8a505711c5047560c9d304 (commit)
via 0ad8984eb51a39beb9c1774d907ef19c7d01396e (commit)
via 027f01e0c8ef05c23151085da33137be77faa05b (commit)
via 7236422768aa22d8e9157d23d2a2608e6c3e8b5a (commit)
via 374dbe02480ba8aafae7583e9ba8378b33186287 (commit)
via 0429aadc217f05a98bbaa51f955b835ac552fd7a (commit)
via 5334e0f32a8b93c407c2bfc931397a0ae70b8d64 (commit)
via e64fb90311a9f2b37b49fc670962089cbb3d32de (commit)
via 478f2392ce7b7cedd4f1c93ed3c64800a16a425b (commit)
via a0b81b906d26312aeb5ef6cab035954ad676790c (commit)
from c194d0e1478b494a1b60416891e589f2ae318e78 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit b879e68326fcebc549d8c5688973b824c31fd761
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Mar 22 20:29:19 2019 +0000
Bug 22032: Compiled CSS
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 52bceacd82cdf4e45b2e76bb7353bb84af1ee1b3
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Dec 20 16:32:34 2018 +0000
Bug 22032: Improve local cover image tab on detail page
This patch makes a variety of improvements to the images tab of the
staff client's bibliographic detail page.
To test, apply the patch and regenerate the staff client CSS.
- Enable the LocalCoverImages system preference.
- Locate a bibliographic record which has no images attached.
- There should be a "no images" message and an upload button.
- Upload an image and return to the detail page.
- The "Images" tab should have a nicely-styled thumbnail of the
image you uploaded.
- Test the "Delete image" link: It should ask for a
confirmation. If you confirm, the image should disappear and
a "loading" spinner should appear.
- When the image has been deleted the thumbnail container
should disappear and the "no images" message should
reappear.
- Test this process with AllowMultipleCovers enabled and disabled.
Extra credit: Modify the AJAX url in the removeLocalImage
function in detail.tt. After misspelling a parameter name or the URL
path, clicking the "Delete image" link should trigger an alert and
re-show the image thumbnail.
Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 441c64d63072d9cd6fd0a97d987dc99a9e0a73ab
Author: Josef Moravec <josef.moravec at gmail.com>
Date: Mon Mar 18 14:33:24 2019 +0000
Bug 18589: (QA follow-up) Remove dateFormat from javascript on ill requests pages.
This is not needed, the right formatting is done in calendar.inc
Test plan:
Use datepickers on ILL requests list page and ensure they work as
expected and the list is right filterred
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit e95733da3c46bb9160bd1105a648d693ac4a7acf
Author: Josef Moravec <josef.moravec at gmail.com>
Date: Mon Mar 18 13:40:54 2019 +0000
Bug 18589: (QA follow-up) Move template to bootstrap grid
Test plan:
Go to patrons Ill request history page and ensure the layout is not
broken and is consistant with other patron pages (except Circulation and
Details pages)
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit aab6564c8c74a94ebedf4fe7590f825cece9bb6d
Author: Josef Moravec <josef.moravec at gmail.com>
Date: Mon Mar 18 09:32:11 2019 +0000
Bug 18589: (QA follow-up) Rename page to "ILL requests history" for consistancy
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 58a07a2e6b18a9135b0f6dcf0b6c01616e768edb
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date: Tue Mar 12 09:41:56 2019 +0000
Bug 18589: (follow-up) Fix merge problem
Bug in passing row to getStatusName
As per item 3) in comment #20:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589#c20
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 8378c74c90009df0476f1832d67b859075654bee
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date: Tue Mar 12 09:19:56 2019 +0000
Bug 18589: (follow-up) Add borrowernumber test
As per comment #21:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589#c21
We now test borrowernumber filter works. This test has come from
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83184&action=diff
and will be removed from that bug
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 352d46464ce1dac3d0c8b92f0c43ef583684fc42
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date: Mon Mar 11 15:58:42 2019 +0000
Bug 18589: (follow-up) Fix QA tool failures
As per comment #17:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589#c17
Sorry Josef, I honestly have no idea where those tabs came from :( Every
once in a while my copy of Vim decides to embarass me and stick in tabs
instead of spaces... <shakes fist at screen>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 17e72b2b1c55d79a5c7cc3cbaa278552ab936c1c
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date: Mon Mar 11 14:19:36 2019 +0000
Bug 18589: (follow-up) Remove redundant-ness
Following feedback from Josef via IRC, removing redundant code
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit daac852c04eb0e9c866aef970f8a79e6db9261d3
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date: Mon Mar 11 11:56:28 2019 +0000
Bug 18589: Show ILLs as part of patron profile
This patch moves the display of a patron's ILL requests to be inline in
the Patron Profile page, as per all other patron information.
It includes a substantial refactor of
koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt in that it
moves the display of the illlist table (which is populated by an API
request) into it's own separate include file. It also moves the
datatable related Javascript for this table into it's own JS file. Doing
this allows us to reuse both in both the new members/ill-requests.tt
template and the pre-existing ill/ill-requests.tt template.
To test:
1) Ensure ILL is enabled and your user has sufficient permissions
2) Ensure your user has some ILL requests
3) Navigate to the user's patron profile page
4) Click on the "Interlibrary loans" tab
5) Observe that the requests table is displayed inline
6) Observe that only your user's requests are displayed
Signed-off-by: Niamh.Walker-Headon at it-tallaght.ie
This is essentially a reimplementation of attachment 84796 to take into
account all changes that had happened beneath this bug and also to
ensure JS strings are translatable.
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit e9fa69ca64e78cc9ea540e3fed1e9ffb1b3488fe
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Feb 27 14:49:35 2019 -0300
Bug 21998: Silent tests
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit ee73d577ed564d98e77cf25fcdadcbc594f7217c
Author: Josef Moravec <josef.moravec at gmail.com>
Date: Tue Dec 18 11:53:21 2018 +0000
Bug 21998: Throw exception on bad pattern
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit b794643bb075c0aa5de81f2481ae1df56f674309
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Wed Sep 19 15:36:36 2018 +0200
Bug 21998: Add pattern parameter in Koha::Token
Allow a pattern too in Koha::Token->generate. Only supported length.
Does not affect CSRF calls. So tiny change without further impact.
Test plan:
Run t/Token.t
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit f8c20ac4c91f22017093a2d8ed0dbb8b0a3738bc
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Mar 22 20:04:33 2019 +0000
Bug 22008: DBRev 18.12.00.031
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit ee1f262f1466e96e9676b3650fe2300b55565d53
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Wed Mar 6 08:08:19 2019 -0500
Bug 22008: Fixes to make unit tests pass
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 7f3dd675b7f20bb011c2fb0659526c6fdf9195e4
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Wed Feb 27 12:04:46 2019 +0000
Bug 22008: Add missing constraints
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 4e067c83e427e7d76227c11fd8d84780dca2cefb
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Wed Feb 27 12:02:36 2019 +0000
Bug 22008: Add tests for new constraints
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit ce49552e6d46e098385a9d70f848793b7218f194
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Mar 22 19:56:18 2019 +0000
Bug 20478: Fix qa complaints
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 2851d66254fe9dbb0edb2b8991e90de665063fd1
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Fri Mar 8 10:35:49 2019 +0000
Bug 20478: (QA follow-up) Make test more standard
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit e7e27a934a1b1d968ea8d00116c0bf17bb196ec1
Author: Andreas Jonsson <andreas.jonsson at kreablo.se>
Date: Mon Jan 22 10:37:14 2018 +0000
Bug 20478: Have the cronjob script advance_notices.pl send digest messages per branch.
Desired behavior of the script advance_notices.pl is that the sender
address on the notice message is that of the branch of the issues in
question. Thus, the solution is to generate digest messages per
branch.
To test:
1) Inspect unit test in t/db_dependent/cronjobs/advance_notices_digest.t and note that:
- There are three libraries
- There is a borrower
- The borrower is registered at library1
- The borrower has message preference wants_digest set to 1
- The borrower has message preference days_in_advance set to 1
- The content of the letter PREDUEDGST is '<<count>> <<branches.branchname>>'
- There are three items
- There is one issue per item
- There is one issues at library2
- There are two issues at library3
- The date_due of the issues are set to tomorrow
- For the default case (no -digest-per-message)
- It is asserted that there is one message in the message queue after running the script
- It is asserted that there are three items in the message.
- It is asserted that the branchname is that of the borrower's home library.
- For the case where -digest-per-message is enabled
- It is asserted that there are two messages in the message queue after running the script
- It is asserted that the item count of the message corresponding to library2 is 1
- It is asserted that the item count of the message corresponding to library3 is 2
- It is asserted that the branchnames are correct.
2) Run unit test: prove t/db_dependent/cronjobs/advance_notices_digest.t
Sponsored-By: Bibliotek Mellansjö, which is a cooperation between
Sponsored-By: Gullspångs kommunbibliotek
Sponsored-By: Hjo stadsbibliotek
Sponsored-By: Karlsborgs bibliotek
Sponsored-By: Mariestads stadsbibliotek
Sponsored-By: Skövde stadsbibliotek
Sponsored-By: Tibro bibliotek
Sponsored-By: Tidaholms stadsbibliotek
Sponsored-By: Töreboda kommunbibliotek
Signed-off-by: Andreas Jonsson <andreas.jonsson at kreablo.se>
Signed-off-by: Magnus Enger <magnus at libriotech.no>
Adding the --digest-per-branch switch turns the digest into one digest per
library. I think it makes perfect sense to keep the default behaviour
and hide this new functionality behind a command line switch.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit e18626b6f142128064317e95ef4a7fb089f4f48d
Author: Andreas Jonsson <andreas.jonsson at kreablo.se>
Date: Tue Mar 27 11:22:45 2018 +0200
Bug 20478: Refactor to remove code duplication.
Signed-off-by: Magnus Enger <magnus at libriotech.no>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 5b97398a3a88ab808121c958ddac5d1cd87ee63b
Author: Andreas Jonsson <andreas.jonsson at kreablo.se>
Date: Mon Jan 22 08:50:10 2018 +0000
Bug 20478: Add unit test for advance_notices.pl cronjob.
Signed-off-by: Magnus Enger <magnus at libriotech.no>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 48484173e26bf9859984860a17089f09de5c8b6a
Author: Josef Moravec <josef.moravec at gmail.com>
Date: Tue Feb 26 09:16:05 2019 +0000
Bug 19661: (follow-up) Use Basic auth in tests
Test plan:
prove t/db_dependent/api/v1/acquisitions_funds.t
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 6e98cc4503cedba411371d4005be41b5822569c8
Author: Matthias Meusburger <matthias.meusburger at biblibre.com>
Date: Tue Jan 15 10:46:04 2019 +0100
Bug 19661: Add and change properties and parameters to conform to the funds RFC.
Also, perform an exact search when searching on the fund owner id.
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit b6be4024196c9e62363eabf0d2ad0b9f9141d15c
Author: Matthias Meusburger <matthias.meusburger at biblibre.com>
Date: Wed Jan 17 11:49:14 2018 +0100
Bug 19661: Use Koha::Acquisition::Funds instead of C4::Budgets
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 717975abebe938a5e79ffc07055ed6190b43f206
Author: Matthias Meusburger <matthias.meusburger at biblibre.com>
Date: Thu Oct 12 07:55:12 2017 +0000
Bug 19661: REST API - Funds Endpoint
This patch adds a new route to the REST api:
/api/v1/acquisitions/funds/
Signed-off-by: David Bourgault <david.bourgault at inlibro.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 7a9a8f2f08e4b74af712d59e1f1f9f0a7b3205a0
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Mar 22 19:20:55 2019 +0000
Bug 21948: Compiled CSS
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 32020105e8494ba82a8a505711c5047560c9d304
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue Dec 4 19:53:29 2018 +0000
Bug 21948: Clean up style of item detail page
This patch removes some page-specific style from the item detail page in
the staff client and adds some markup in order to trigger a more
generally-used style.
This patch also adds a font-awesome icon to the "Edit item" link on the
page.
To test, apply the patch and regenerate the staff client CSS. Open a
bibliographic record and view the "Items tab."
Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 0ad8984eb51a39beb9c1774d907ef19c7d01396e
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Mar 22 19:16:46 2019 +0000
Bug 21304: Compiled CSS
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 027f01e0c8ef05c23151085da33137be77faa05b
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue Mar 19 15:46:42 2019 +0000
Bug 21304: (follow-up) Correct hc-sticky configuration
This patch corrects the element passed to the hc-sticky plugin to define
which element the floating toolbar sticks to.
To test, apply the patch and perform a search in the staff client which
will return multiple results. Confirm that scrolling down the page
triggers the floating toolbar.
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 7236422768aa22d8e9157d23d2a2608e6c3e8b5a
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed Sep 5 12:38:33 2018 +0000
Bug 21304: (follow-up) Fix style of search results browser
This follow-up revises the style of the search result browser in the
staff client, making it behave better at smaller browser widths.
The patch also makes a couple of ESLint-prompted changes to browser.js
To test, apply the patch and regenerate CSS.
- Perform a catalog search in the staff client.
- Click on one of the search results.
- On the bibliographic detail page there should be results browsing
controls in the left-hand sidebar.
- Resize the browser window and confirm that the controls work well
at various sizes.
- Test with both the first and last search result.
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 374dbe02480ba8aafae7583e9ba8378b33186287
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed May 2 14:06:23 2018 +0000
Bug 21304: Update two-column templates with Bootstrap grid: Catalog
This patch modifies several catalog templates to use the Bootstrap grid
instead of YUI.
This patch also removes obsolete "text/javascript" attributes from
<script> tags and "text/css" attributes from <style> tags in the
modified templates.
To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:
- Catalog -> Search
- Search results
- Bibliographic details
- MARC details (viewMARC preference enabled)
- Labeled MARC details (viewLabeledMARC preference enabled)
- ISBD (viewISBD preference enabled)
- Items
- Checkout history
- Rota (stock rotation)
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 0429aadc217f05a98bbaa51f955b835ac552fd7a
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Wed Feb 6 02:02:11 2019 +0000
Bug 13735: Update PrepareItemrecordDisplay to use maxlength
The PrepareItemrecordDisplay method used to generate the item
display on receiving serials was using a hardcoded maxlength
of 255 on input fields. This patch updates it to use the
maxlength defined in the frameworks instead as the normal
item form does.
To test:
- Create or reuse an existing subscription
- Make note of the framework the record uses
- Add an item on receive
- Check the maxlength on the various fields is set to 255
(check source code or use developer tools)
- You can also verify that by adding a long note to
one of the note fields
- Apply patch
- Repeat tests, the maxlength should now be 9999
- In your framework settings, change the length of one
of the subfields to another value
- Verify that the item form reflects the change
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 5334e0f32a8b93c407c2bfc931397a0ae70b8d64
Author: Blou <philippe.blouin at inlibro.com>
Date: Tue Sep 11 14:42:03 2018 -0400
Bug 21130: (Follow up OPAC Results) Prevent HTML class from being translated
This fixes the same issue where "title" is being translated (in fr-CA at least) and thus
break the javascript impacting the result display in the OPAC
Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit e64fb90311a9f2b37b49fc670962089cbb3d32de
Author: David Bourgault <dav.bour at gmail.com>
Date: Fri Jul 27 17:13:42 2018 -0400
Bug 21130: Prevent HTML class from being translated
Adds a xsl:value-of tag to prevent the value from being translated.
TEST PLAN
0) Apply patch
1) Translate
2) In the opac, div.record has not changed
NOTE:
I don't know if this bug affects all translations, I noticed it when translating to fr-CA.
The fix will work for all languages.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 478f2392ce7b7cedd4f1c93ed3c64800a16a425b
Author: Liz Rea <wizzyrea at gmail.com>
Date: Tue Mar 19 17:52:46 2019 +0000
Bug 22533: Fix manual invoices from patron accounting
To test:
Attempt to create a manual fine from the patron accounting page, it
should fail.
Apply this patch, restart the things
Attempt to create a manual fine from the patron accounting page, it
should succeed.
Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit a0b81b906d26312aeb5ef6cab035954ad676790c
Author: Liz Rea <wizzyrea at gmail.com>
Date: Thu Mar 21 01:53:54 2019 +0000
Bug 22559: Restore OPAC forgotten password functionality
To test:
Enable OpacResetPassword
Create a borrower with a username and password
Go to the OPAC, try to reset the password (I always get the reset link
token out of the message_queue in the database rather than worry about
receiving the actual email. You do you.)
Go to the link provided.
Attempt to set a password, this should fail.
Apply this patch
Go through the process again, password should be reset.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Items.pm | 14 +-
Koha.pm | 2 +-
Koha/{Subscriptions.pm => Exceptions/Token.pm} | 44 +-
Koha/REST/V1/Acquisitions/Funds.pm | 134 +++++
Koha/REST/V1/Illrequests.pm | 10 +-
Koha/Schema/Result/Accountline.pm | 29 +-
Koha/Schema/Result/Borrower.pm | 19 +-
Koha/Token.pm | 22 +-
api/v1/swagger/definitions.json | 3 +
api/v1/swagger/definitions/fund.json | 101 ++++
api/v1/swagger/parameters.json | 5 +-
api/v1/swagger/parameters/fund.json | 9 +
api/v1/swagger/paths.json | 3 +
api/v1/swagger/paths/acquisitions_funds.json | 73 +++
api/v1/swagger/x-primitives.json | 6 +
ill/ill-requests.pl | 5 +-
installer/data/mysql/kohastructure.sql | 6 +-
installer/data/mysql/updatedatabase.pl | 20 +
koha-tmpl/intranet-tmpl/js/browser.js | 6 +-
.../intranet-tmpl/prog/css/src/staff-global.scss | 114 ++--
koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 2 +-
.../intranet-tmpl/prog/en/includes/circ-menu.inc | 2 +-
.../prog/en/includes/ill-list-table-strings.inc | 19 +
.../prog/en/includes/ill-list-table.inc | 42 ++
.../prog/en/modules/catalogue/ISBDdetail.tt | 29 +-
.../prog/en/modules/catalogue/MARCdetail.tt | 30 +-
.../prog/en/modules/catalogue/detail.tt | 91 +--
.../prog/en/modules/catalogue/imageviewer.tt | 35 +-
.../prog/en/modules/catalogue/issuehistory.tt | 26 +-
.../prog/en/modules/catalogue/labeledMARCdetail.tt | 34 +-
.../prog/en/modules/catalogue/moredetail.tt | 38 +-
.../prog/en/modules/catalogue/results.tt | 33 +-
.../prog/en/modules/catalogue/stockrotation.tt | 9 +-
.../prog/en/modules/ill/ill-requests.tt | 582 +-------------------
.../prog/en/modules/members/ill-requests.tt | 56 ++
.../intranet-tmpl/prog/en/modules/tools/letter.tt | 2 -
koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js | 534 ++++++++++++++++++
.../bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 2 +-
.../bootstrap/en/xslt/MARC21slim2OPACResults.xsl | 2 +-
.../{purchase-suggestions.pl => ill-requests.pl} | 27 +-
members/maninvoice.pl | 2 +-
misc/cronjobs/advance_notices.pl | 313 +++++++----
opac/opac-password-recovery.pl | 1 +
t/Token.t | 14 +-
t/db_dependent/Koha/Account/Lines.t | 17 +-
t/db_dependent/api/v1/acquisitions_funds.t | 84 +++
t/db_dependent/api/v1/illrequests.t | 18 +-
t/db_dependent/cronjobs/advance_notices_digest.t | 270 +++++++++
48 files changed, 1986 insertions(+), 953 deletions(-)
copy Koha/{Subscriptions.pm => Exceptions/Token.pm} (57%)
create mode 100644 Koha/REST/V1/Acquisitions/Funds.pm
create mode 100644 api/v1/swagger/definitions/fund.json
create mode 100644 api/v1/swagger/parameters/fund.json
create mode 100644 api/v1/swagger/paths/acquisitions_funds.json
create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/ill-list-table-strings.inc
create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/ill-list-table.inc
create mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/members/ill-requests.tt
create mode 100644 koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js
copy members/{purchase-suggestions.pl => ill-requests.pl} (67%)
create mode 100644 t/db_dependent/api/v1/acquisitions_funds.t
create mode 100644 t/db_dependent/cronjobs/advance_notices_digest.t
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list