[koha-commits] main Koha release repository branch 17.11.x updated. v17.11.16-12-g6e7dee0

Git repo owner gitmaster at git.koha-community.org
Tue Mar 26 07:51:52 CET 2019


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 17.11.x has been updated
       via  6e7dee0f1d371989c5928c3ca11527021ced67f0 (commit)
       via  55e9c05a66760e0183f7c975a48eea48e4f9b947 (commit)
       via  37aa8461272cc70a3cf53f788f245402ab28556b (commit)
       via  e14da89d104ed1fd62136baafba60d42de9380b7 (commit)
       via  04a9bf6b7f7ba3618a0e50ae9c589b0026bef5d1 (commit)
       via  1fe15f1b9232109b9ce09a424f94f474637b4077 (commit)
       via  9ba061ada622b92f4708531e5edd24eccd868cb4 (commit)
      from  73891afe8da686ecdbf5c06a9eece21d9e1c7d2e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 6e7dee0f1d371989c5928c3ca11527021ced67f0
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Tue Mar 5 15:51:15 2019 +0100

    Bug 21560: (follow-up) move use at the top
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 639ad97d844f2774f49881174b559293edd6baa4)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 30c9167dd48d1631f2554fa7897638ae4f4f5186)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    (cherry picked from commit 9918ef23a39ff5f69ba60c4fcacc5b830a00773c)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 55e9c05a66760e0183f7c975a48eea48e4f9b947
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Tue Feb 19 12:01:16 2019 +0100

    Bug 21560: Unit test for Koha::Util::OpenDocument
    
    Run prove t/Koha/Util/OpenDocument.t
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 99ea714345a6278d68e2abb0d182d8b495cf2950)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 31ebb5abd003f41576febe7a53c27046236e9653)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    (cherry picked from commit 13cdadbe8f13f81e4774403b09c4abd1d27a6c6a)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 37aa8461272cc70a3cf53f788f245402ab28556b
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Mon Feb 18 17:33:37 2019 +0100

    Bug 21560: create Koha::Util::OpenDocument with subroutine for ODS generation
    
    There is nearly the same code in misc/cronjobs/gather_print_notices.pl and reports/guided_reports.pl.
    This patch creates a new module with subroutine called by both scripts.
    
    If file path or content is undefined, subroutine will just return undef.
    If content is an empty arrayref, empty ods file is still generated.
    
    Unicode encoding is kept outisde because it may not be necessary.
    
    Note that for print notices the first line of message is always the column names so it is extracted only from first message.
    
    Test plan :
    Run previous patches test plans and check ODS files are the same.
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit ffb40290f88380418635a951dbb0788bf7b7e3ce)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit c2531f6fef7f741f6557add3f8981148c55c15ce)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    (cherry picked from commit 3f68db17b9e2b5e6ece289a312f1a53f8d9a3d53)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit e14da89d104ed1fd62136baafba60d42de9380b7
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Fri Dec 7 10:30:30 2018 +0100

    Bug 21560: Optimize ODS export of gather_print_notices.pl
    
    Like previous patch, the call on OpenOffice-OODoc lib can be optimized.
    Based on https://grep.metacpan.org/search?qci=&q=expandTable&qft=&qd=OpenOffice-OODoc&f=examples%2Ftext2table
    
    Test plan inspired from Bug 11679.
    
    Test plan:
    - define your ODUE notice for the print template as:
    cardnumber:patron:email:item
    <<borrowers.cardnumber>>:<<borrowers.firstname>> <<borrowers.surname>>:<<borrowers.email>>:<item><<items.barcode>></item>
    - define overdues rules for a patron category
    - check-out 2 items using a due date in order to generate the overdue notices
    - check-in these 2 items
    - launch the script /misc/cronjobs/overdue_notices.pl
    - the 'message_queue' table should now contain 2 new entries
    - launch the gather_print_notices cronjob :
      perl misc/cronjobs/gather_print_notices.pl /tmp/test --ods --letter_code=OVERDUE -d=:
    - A ods file should be generated in your /tmp/test directory
    - Compare times with and without patch
    
    Signed-off-by: David Nind <david at davidnind.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 5d4f80feac811a9d6e177975b50c57ba85e3434d)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 4bc7751e4abe80973e991fbd80506c23f39910d8)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    (cherry picked from commit ef6d4aef4b34fa22a8850146615adf70411065ea)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 04a9bf6b7f7ba3618a0e50ae9c589b0026bef5d1
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Fri Oct 12 14:09:54 2018 +0200

    Bug 21560: report ODS export optimization
    
    SQL reports can be exported with CSV, TSV of ODS format.
    When report has thousands of rows, using ODS format is around 10 times longer than other formats.
    It also loads CPU and RAM a lot.
    
    The longest call is expandTable().
    I found that the call on OpenOffice-OODoc lib can be optimized.
    Based on https://grep.metacpan.org/search?qci=&q=expandTable&qft=&qd=OpenOffice-OODoc&f=examples%2Ftext2table
    
    Test plan :
    1) Don't apply patch yet
    2) Create a new SQL report : Home > Reports > Create from SQL
    3) Enter a SQL that will return thousands of results
    4) Run report
    5) Click Download > Semicolon separated text (.csv), look execution time
    6) Click Download > Open Document Spreadsheet, look execution time
    7) Apply patch
    8) Redo 5) and 6) and compare times, CSV export should be the same but ODS export should be better
    
    My tests shows 1,5 seconds for CSV export.
    And for ODS export : 18 seconds without patch and 8 seconds with patch.
    
    Signed-off-by: David Nind <david at davidnind.com>
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
    
    Signed-off-by: David Nind <david at davidnind.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 28edd8848320fd0f0f284245f2f0567a5907619a)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 0014f64348ea171300afce604cd7ec4f9a0444a7)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    (cherry picked from commit ba64a98d076f46e9355818efc278ed3c531d0e00)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 1fe15f1b9232109b9ce09a424f94f474637b4077
Author: David Cook <dcook at prosentient.com.au>
Date:   Mon Mar 4 17:43:29 2019 +1100

    Bug 22429: Infinite loop in patron card printing
    
    Text fields in Patron Card Text Layouts can contain regular
    expression metacharacters, which - instead of being treated as
    literal values - are interpreted and prevent line wrapping. This
    causes the process to get stuck in an infinite loop, which keeps
    running even after the web server has timed out (at least when
    using CGI).
    
    This patch escapes the relevant input from the text field so the
    regular expression substitution treats characters as literals
    instead of as metacharacters.
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 3bd900496690375b2b711743ffaa57371388f687)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 296f6756ab51103d0e104e16cff312d28a8fd165)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    (cherry picked from commit d272137c4f764f8a21f02f56c4dba0ad315ec4aa)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 9ba061ada622b92f4708531e5edd24eccd868cb4
Author: Julian Maurice <julian.maurice at biblibre.com>
Date:   Wed Mar 6 08:58:03 2019 +0100

    Bug 16251: Fix value of material select for Rancor 008 widget
    
    The material type is selected in accordance with the leader (06-07)
    
    Test plan:
    1. Create a new record using the advanced editor
    2. Set the leader 6th position to 'c'
    3. Save the record and reload the page
    4. 'Music' should be automatically selected for 008
    5. Try other values for the leader 6th and 7th positions
    
    See comment 0 of this bug for the complete mapping
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 926d7c4ba11ad6cd768c884ec4b2dc71d864b64c)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit d7988f672f68e0cc875eedce6bad0b634df8941c)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    (cherry picked from commit 5f858a9746c3210dacc7a3546409ef619379e854)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Patroncards/Patroncard.pm                       |    3 +-
 Koha/Util/OpenDocument.pm                          |   95 ++++++++++++++++++++
 .../intranet-tmpl/lib/koha/cateditor/widget.js     |    7 ++
 .../prog/en/includes/cateditor-widgets-marc21.inc  |   26 +++++-
 misc/cronjobs/gather_print_notices.pl              |   66 +++++---------
 reports/guided_reports.pl                          |   51 ++++-------
 .../Koha/Util/OpenDocument.t                       |   53 +++++------
 7 files changed, 195 insertions(+), 106 deletions(-)
 create mode 100644 Koha/Util/OpenDocument.pm
 copy cataloguing/value_builder/marc21_orgcode.pl => t/Koha/Util/OpenDocument.t (50%)
 mode change 100755 => 100644


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list