From gitmaster at git.koha-community.org Thu May 2 15:47:03 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 02 May 2019 13:47:03 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.04-171-g8fab429 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via 8fab429baa5d4e9f2f96ae34945205d9e09610b0 (commit) via a056ad12d1deae5f13ae5f80237515f816d90cc6 (commit) via 021500533e56dd732ff7e0c98256743ef3f009bc (commit) via 5482591c5c1746713808a7bdb00ff240cb9dcd10 (commit) via f73713417980453e6c2cc98781ccbcaa087a2c49 (commit) via 1bab883c29c9b876c71036a7d7069c868cb7c4d7 (commit) via 5977db6738a50f398e9049db39d8a8e622546f2e (commit) via 3d06afa4cdd9131fb9784a9d76b14a669e35ffc7 (commit) via ab5a04e885b6a759e62d5fd78608302e89a14166 (commit) via b398ba9f3e1a042ec0784100a32a48ba9c0fe2de (commit) via d4d1107afa873614ace241557e424de0dcbad20a (commit) via ebc15764ff3371a9327cfe60c22c1186e5a200ae (commit) via bc066fea9f855c0fc4e1fbc43736121783d3b77b (commit) via bb22c319d35e94ef63a8a05ee3b348858771a90f (commit) from b61c41f0efebac66d561070d5a3e4533354d90d0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8fab429baa5d4e9f2f96ae34945205d9e09610b0 Author: Martin Renvoize Date: Mon Apr 29 12:33:38 2019 +0100 Update release notes for 18.11.05 release Signed-off-by: Martin Renvoize commit a056ad12d1deae5f13ae5f80237515f816d90cc6 Author: Martin Renvoize Date: Mon Apr 29 12:07:23 2019 +0100 Increment version for 18.11.05 release Signed-off-by: Martin Renvoize commit 021500533e56dd732ff7e0c98256743ef3f009bc Author: Koha translators <> Date: Mon Apr 29 06:48:15 2019 -0300 Translation updates for Koha 18.11.05 (cherry picked from commit d20e811b71fa536aaf5b9e34c4804dd899875a81) Signed-off-by: Martin Renvoize commit 5482591c5c1746713808a7bdb00ff240cb9dcd10 Author: Jonathan Druart Date: Thu Mar 21 14:45:37 2019 -0300 Bug 22542: Force back button to display personal data This is a follow-up of bug 5371 The following command must not return anything: grep ^output_html_with_http_headers `git grep -l -P "authnotrequired\s*=>\s*0" opac`|grep -v force_no_caching This must be a test somehwere to prevent further regressions. Signed-off-by: Katrin Fischer Signed-off-by: Chris Cormack Signed-off-by: Martin Renvoize commit f73713417980453e6c2cc98781ccbcaa087a2c49 Author: Martin Renvoize Date: Fri Apr 26 17:24:06 2019 +0100 Bug 22478: (RMaint follow-up) source t::lib::Mocks In 18.11.x the t::lib::Mocks module is not yet sourced for the relevant test Signed-off-by: Martin Renvoize commit 1bab883c29c9b876c71036a7d7069c868cb7c4d7 Author: Martin Renvoize Date: Mon Apr 29 13:30:09 2019 +0100 Bug 22478: (QA follow-up) Update tests to check for any script tags Signed-off-by: Martin Renvoize commit 5977db6738a50f398e9049db39d8a8e622546f2e Author: Martin Renvoize Date: Fri Apr 26 19:56:43 2019 +0100 Bug 22478: (QA follow-up) Make test consistent with variable name We were adding data to category 1 (private lists) and testing against that, but we named the variable 'publist_lists'. Signed-off-by: Martin Renvoize commit 3d06afa4cdd9131fb9784a9d76b14a669e35ffc7 Author: Marcel de Rooy Date: Fri Apr 12 07:02:06 2019 +0000 Bug 22478: (QA follow-up) Handle category in opac-shelves like a boolean The category parameter should be restricted to 1 or 2 (private/public). In order to keep same behavior, no parameter means 1 (private). Note: Adding the same line in intranet counterpart. Test plan [1] Check for category empty, '1a', '11' etc. And with script ;) Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit ab5a04e885b6a759e62d5fd78608302e89a14166 Author: Katrin Fischer Date: Wed Apr 10 02:06:37 2019 +0000 Bug 22478: Fix POD Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit b398ba9f3e1a042ec0784100a32a48ba9c0fe2de Author: Jonathan Druart Date: Fri Mar 15 13:41:27 2019 -0300 Bug 22478: Add tests Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit d4d1107afa873614ace241557e424de0dcbad20a Author: Jonathan Druart Date: Thu Mar 14 19:42:50 2019 -0300 Bug 22478: Prevent XSS vulnerabilities when pagination appears This is a bad one as we thought we were XSS safe since bug 13618. The html code generated in C4::Output::pagination_bar must escape the variables and values correctly. This patch needs to be widely tested, everywhere the pagination appears, to make sure we will not introduce regressions. Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit ebc15764ff3371a9327cfe60c22c1186e5a200ae Author: Nick Clemens Date: Fri Apr 12 01:23:34 2019 +0000 Bug 22692: Check for patron using cardnumber and userid TO test: 1 - Set failed login attempts to 1 2 - Attempt a login with a userid and bad password, no success 3 - Attempt a login with userid and correct password, prevented because locked 4 - Attempt a login with cardnumber and right password, you are logged in 5 - Log out, try again with userid and correct password, prevented because locked? 6 - Apply patch 7 - Repeat 1-3 to lock account 8 - Attempt logging in with cardnumber, you are prevented Signed-off-by: Martin Renvoize Signed-off-by: Chris Cormack Signed-off-by: Martin Renvoize commit bc066fea9f855c0fc4e1fbc43736121783d3b77b Author: Nick Clemens Date: Fri Apr 12 01:11:19 2019 +0000 Bug 22692: Unit tests 1 - Apply just this patch 2 - prove -v t/db_dependent/Auth.t 3 - Failure 4 - Apply second patch 5 - prove -v t/db_dependent/Auth.t 6 - Success Signed-off-by: Martin Renvoize Signed-off-by: Chris Cormack Signed-off-by: Martin Renvoize commit bb22c319d35e94ef63a8a05ee3b348858771a90f Author: Andrew Isherwood Date: Wed Mar 6 14:07:50 2019 +0000 Bug 22464: Pass forward parameters This patch ensures that parameters that are present are passed forward when accepting the copyright notice. Test plan: - Clone the latest version of the FreeForm backend from: https://github.com/PTFS-Europe/koha-ill-freeform - Ensure the ILLModuleCopyrightClearance syspref is populated - Create an OpenURL in order to pre-populate the FreeForm form, a suitable URL would be: /cgi-bin/koha/opac-illrequests.pl?openurl=true&backend=FreeForm&method=create&opac=1&atitle=Theater%20careers.%20%5Belectronic%20resource%5D%20%3A%20a%20realistic%20guide.&aulast=Donahue%2C%20Tim&date=2012&genre=article&isbn=978123123123&issn=1234-5678&issue=34&pages=12-34&sid=EBSCO%3AAthlone%20Institute%20of%20Technology%3Aait.101326&title=article%20title%20here&volume=12 - Log in - Accept the copyright notice => TEST: Observe that the FreeForm form is pre-filled with the metadata supplied in the OpenURL Signed-off-by: Liz Rea Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens (cherry picked from commit 5e20e438e80465fcd6f1c2af5e6138a639dec5f3) Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Auth.pm | 1 + C4/Output.pm | 6 +- Koha.pm | 2 +- Koha/Illrequest.pm | 1 + installer/data/mysql/updatedatabase.pl | 6 + .../bootstrap/en/modules/opac-illrequests.tt | 3 +- misc/release_notes/release_notes_18_11_05.html | 726 +++++++++ misc/release_notes/release_notes_18_11_05.md | 561 +++++++ misc/translator/po/am-Ethi-marc-MARC21.po | 8 +- misc/translator/po/am-Ethi-marc-NORMARC.po | 2 +- misc/translator/po/am-Ethi-marc-UNIMARC.po | 2 +- misc/translator/po/am-Ethi-opac-bootstrap.po | 258 +-- misc/translator/po/am-Ethi-pref.po | 24 + misc/translator/po/am-Ethi-staff-prog.po | 849 +++++----- misc/translator/po/ar-Arab-marc-MARC21.po | 8 +- misc/translator/po/ar-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ar-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/ar-Arab-messages.po | 8 +- misc/translator/po/ar-Arab-opac-bootstrap.po | 263 +-- misc/translator/po/ar-Arab-pref.po | 24 + misc/translator/po/ar-Arab-staff-prog.po | 853 +++++----- misc/translator/po/as-IN-marc-MARC21.po | 8 +- misc/translator/po/as-IN-marc-NORMARC.po | 2 +- misc/translator/po/as-IN-marc-UNIMARC.po | 2 +- misc/translator/po/as-IN-opac-bootstrap.po | 258 +-- misc/translator/po/as-IN-pref.po | 24 + misc/translator/po/as-IN-staff-prog.po | 845 +++++----- misc/translator/po/az-AZ-marc-MARC21.po | 8 +- misc/translator/po/az-AZ-marc-NORMARC.po | 2 +- misc/translator/po/az-AZ-marc-UNIMARC.po | 2 +- misc/translator/po/az-AZ-opac-bootstrap.po | 258 +-- misc/translator/po/az-AZ-pref.po | 24 + misc/translator/po/az-AZ-staff-prog.po | 846 +++++----- misc/translator/po/be-BY-marc-MARC21.po | 8 +- misc/translator/po/be-BY-marc-NORMARC.po | 2 +- misc/translator/po/be-BY-marc-UNIMARC.po | 2 +- misc/translator/po/be-BY-opac-bootstrap.po | 260 +-- misc/translator/po/be-BY-pref.po | 24 + misc/translator/po/be-BY-staff-prog.po | 846 +++++----- misc/translator/po/bg-Cyrl-marc-MARC21.po | 8 +- misc/translator/po/bg-Cyrl-marc-NORMARC.po | 2 +- misc/translator/po/bg-Cyrl-marc-UNIMARC.po | 2 +- misc/translator/po/bg-Cyrl-opac-bootstrap.po | 258 +-- misc/translator/po/bg-Cyrl-pref.po | 24 + misc/translator/po/bg-Cyrl-staff-prog.po | 849 +++++----- misc/translator/po/bn-IN-marc-MARC21.po | 8 +- misc/translator/po/bn-IN-marc-NORMARC.po | 2 +- misc/translator/po/bn-IN-marc-UNIMARC.po | 2 +- misc/translator/po/bn-IN-opac-bootstrap.po | 277 ++-- misc/translator/po/bn-IN-pref.po | 24 + misc/translator/po/bn-IN-staff-prog.po | 849 +++++----- misc/translator/po/ca-ES-marc-MARC21.po | 8 +- misc/translator/po/ca-ES-marc-NORMARC.po | 2 +- misc/translator/po/ca-ES-marc-UNIMARC.po | 2 +- misc/translator/po/ca-ES-opac-bootstrap.po | 260 +-- misc/translator/po/ca-ES-pref.po | 24 + misc/translator/po/ca-ES-staff-prog.po | 848 +++++----- misc/translator/po/cs-CZ-marc-MARC21.po | 8 +- misc/translator/po/cs-CZ-marc-NORMARC.po | 2 +- misc/translator/po/cs-CZ-marc-UNIMARC.po | 14 +- misc/translator/po/cs-CZ-opac-bootstrap.po | 413 +++-- misc/translator/po/cs-CZ-pref.po | 94 +- misc/translator/po/cs-CZ-staff-prog.po | 908 ++++++----- misc/translator/po/cy-GB-marc-MARC21.po | 8 +- misc/translator/po/cy-GB-marc-NORMARC.po | 2 +- misc/translator/po/cy-GB-marc-UNIMARC.po | 2 +- misc/translator/po/cy-GB-opac-bootstrap.po | 258 +-- misc/translator/po/cy-GB-pref.po | 24 + misc/translator/po/cy-GB-staff-prog.po | 845 +++++----- misc/translator/po/da-DK-marc-MARC21.po | 8 +- misc/translator/po/da-DK-marc-NORMARC.po | 2 +- misc/translator/po/da-DK-marc-UNIMARC.po | 2 +- misc/translator/po/da-DK-opac-bootstrap.po | 258 +-- misc/translator/po/da-DK-pref.po | 24 + misc/translator/po/da-DK-staff-prog.po | 848 +++++----- misc/translator/po/de-CH-marc-MARC21.po | 8 +- misc/translator/po/de-CH-marc-NORMARC.po | 2 +- misc/translator/po/de-CH-marc-UNIMARC.po | 2 +- misc/translator/po/de-CH-opac-bootstrap.po | 262 +-- misc/translator/po/de-CH-pref.po | 24 + misc/translator/po/de-CH-staff-prog.po | 852 +++++----- misc/translator/po/de-DE-marc-MARC21.po | 8 +- misc/translator/po/de-DE-marc-NORMARC.po | 2 +- misc/translator/po/de-DE-marc-UNIMARC.po | 8 +- misc/translator/po/de-DE-opac-bootstrap.po | 411 +++-- misc/translator/po/de-DE-pref.po | 33 +- misc/translator/po/de-DE-staff-prog.po | 916 +++++------ misc/translator/po/el-GR-marc-MARC21.po | 8 +- misc/translator/po/el-GR-marc-NORMARC.po | 2 +- misc/translator/po/el-GR-marc-UNIMARC.po | 12 +- misc/translator/po/el-GR-messages.po | 24 +- misc/translator/po/el-GR-opac-bootstrap.po | 273 ++-- misc/translator/po/el-GR-pref.po | 62 +- misc/translator/po/el-GR-staff-prog.po | 869 +++++----- misc/translator/po/en-GB-marc-MARC21.po | 8 +- misc/translator/po/en-GB-marc-NORMARC.po | 2 +- misc/translator/po/en-GB-marc-UNIMARC.po | 2 +- misc/translator/po/en-GB-opac-bootstrap.po | 260 +-- misc/translator/po/en-GB-pref.po | 24 + misc/translator/po/en-GB-staff-prog.po | 851 +++++----- misc/translator/po/en-NZ-marc-MARC21.po | 8 +- misc/translator/po/en-NZ-marc-NORMARC.po | 2 +- misc/translator/po/en-NZ-marc-UNIMARC.po | 2 +- misc/translator/po/en-NZ-opac-bootstrap.po | 262 +-- misc/translator/po/en-NZ-pref.po | 24 + misc/translator/po/en-NZ-staff-prog.po | 852 +++++----- misc/translator/po/eo-marc-MARC21.po | 8 +- misc/translator/po/eo-marc-NORMARC.po | 2 +- misc/translator/po/eo-marc-UNIMARC.po | 2 +- misc/translator/po/eo-opac-bootstrap.po | 262 +-- misc/translator/po/eo-pref.po | 24 + misc/translator/po/eo-staff-prog.po | 847 +++++----- misc/translator/po/es-ES-marc-MARC21.po | 8 +- misc/translator/po/es-ES-marc-NORMARC.po | 2 +- misc/translator/po/es-ES-marc-UNIMARC.po | 6 +- misc/translator/po/es-ES-opac-bootstrap.po | 414 ++--- misc/translator/po/es-ES-pref.po | 421 +++-- misc/translator/po/es-ES-staff-prog.po | 900 +++++------ misc/translator/po/eu-marc-MARC21.po | 8 +- misc/translator/po/eu-marc-NORMARC.po | 2 +- misc/translator/po/eu-marc-UNIMARC.po | 2 +- misc/translator/po/eu-opac-bootstrap.po | 262 +-- misc/translator/po/eu-pref.po | 24 + misc/translator/po/eu-staff-prog.po | 848 +++++----- misc/translator/po/fa-Arab-marc-MARC21.po | 8 +- misc/translator/po/fa-Arab-marc-NORMARC.po | 2 +- misc/translator/po/fa-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/fa-Arab-opac-bootstrap.po | 385 +++-- misc/translator/po/fa-Arab-pref.po | 24 + misc/translator/po/fa-Arab-staff-prog.po | 846 +++++----- misc/translator/po/fi-FI-marc-MARC21.po | 8 +- misc/translator/po/fi-FI-marc-NORMARC.po | 2 +- misc/translator/po/fi-FI-marc-UNIMARC.po | 2 +- misc/translator/po/fi-FI-messages.po | 30 +- misc/translator/po/fi-FI-opac-bootstrap.po | 260 +-- misc/translator/po/fi-FI-pref.po | 24 + misc/translator/po/fi-FI-staff-prog.po | 1112 ++++++------- misc/translator/po/fo-FO-marc-MARC21.po | 8 +- misc/translator/po/fo-FO-marc-NORMARC.po | 2 +- misc/translator/po/fo-FO-marc-UNIMARC.po | 2 +- misc/translator/po/fo-FO-opac-bootstrap.po | 258 +-- misc/translator/po/fo-FO-pref.po | 24 + misc/translator/po/fo-FO-staff-prog.po | 845 +++++----- misc/translator/po/fr-CA-marc-MARC21.po | 8 +- misc/translator/po/fr-CA-marc-NORMARC.po | 10 +- misc/translator/po/fr-CA-marc-UNIMARC.po | 2 +- misc/translator/po/fr-CA-opac-bootstrap.po | 415 +++-- misc/translator/po/fr-CA-pref.po | 213 +-- misc/translator/po/fr-CA-staff-prog.po | 967 +++++------ misc/translator/po/fr-FR-marc-MARC21.po | 8 +- misc/translator/po/fr-FR-marc-NORMARC.po | 2 +- misc/translator/po/fr-FR-marc-UNIMARC.po | 6 +- misc/translator/po/fr-FR-messages.po | 22 +- misc/translator/po/fr-FR-opac-bootstrap.po | 312 ++-- misc/translator/po/fr-FR-pref.po | 295 ++-- misc/translator/po/fr-FR-staff-prog.po | 1186 +++++++------- misc/translator/po/ga-marc-MARC21.po | 8 +- misc/translator/po/ga-marc-NORMARC.po | 2 +- misc/translator/po/ga-marc-UNIMARC.po | 2 +- misc/translator/po/ga-opac-bootstrap.po | 258 +-- misc/translator/po/ga-pref.po | 24 + misc/translator/po/ga-staff-prog.po | 845 +++++----- misc/translator/po/gd-marc-MARC21.po | 8 +- misc/translator/po/gd-marc-NORMARC.po | 2 +- misc/translator/po/gd-marc-UNIMARC.po | 2 +- misc/translator/po/gd-opac-bootstrap.po | 258 +-- misc/translator/po/gd-pref.po | 24 + misc/translator/po/gd-staff-prog.po | 845 +++++----- misc/translator/po/gl-marc-MARC21.po | 8 +- misc/translator/po/gl-marc-NORMARC.po | 2 +- misc/translator/po/gl-marc-UNIMARC.po | 2 +- misc/translator/po/gl-opac-bootstrap.po | 258 +-- misc/translator/po/gl-pref.po | 24 + misc/translator/po/gl-staff-prog.po | 846 +++++----- misc/translator/po/he-Hebr-marc-MARC21.po | 8 +- misc/translator/po/he-Hebr-marc-NORMARC.po | 2 +- misc/translator/po/he-Hebr-marc-UNIMARC.po | 2 +- misc/translator/po/he-Hebr-opac-bootstrap.po | 258 +-- misc/translator/po/he-Hebr-pref.po | 24 + misc/translator/po/he-Hebr-staff-prog.po | 846 +++++----- misc/translator/po/hi-marc-MARC21.po | 8 +- misc/translator/po/hi-marc-NORMARC.po | 2 +- misc/translator/po/hi-marc-UNIMARC.po | 2 +- misc/translator/po/hi-opac-bootstrap.po | 408 ++--- misc/translator/po/hi-pref.po | 28 +- misc/translator/po/hi-staff-prog.po | 853 +++++----- misc/translator/po/hr-HR-marc-MARC21.po | 8 +- misc/translator/po/hr-HR-marc-NORMARC.po | 2 +- misc/translator/po/hr-HR-marc-UNIMARC.po | 2 +- misc/translator/po/hr-HR-opac-bootstrap.po | 260 +-- misc/translator/po/hr-HR-pref.po | 24 + misc/translator/po/hr-HR-staff-prog.po | 852 +++++----- misc/translator/po/hu-HU-marc-MARC21.po | 8 +- misc/translator/po/hu-HU-marc-NORMARC.po | 2 +- misc/translator/po/hu-HU-marc-UNIMARC.po | 2 +- misc/translator/po/hu-HU-opac-bootstrap.po | 261 +-- misc/translator/po/hu-HU-pref.po | 24 + misc/translator/po/hu-HU-staff-prog.po | 848 +++++----- misc/translator/po/hy-Armn-marc-MARC21.po | 8 +- misc/translator/po/hy-Armn-marc-NORMARC.po | 2 +- misc/translator/po/hy-Armn-marc-UNIMARC.po | 14 +- misc/translator/po/hy-Armn-opac-bootstrap.po | 293 ++-- misc/translator/po/hy-Armn-pref.po | 34 +- misc/translator/po/hy-Armn-staff-prog.po | 857 +++++----- misc/translator/po/ia-marc-MARC21.po | 8 +- misc/translator/po/ia-marc-NORMARC.po | 2 +- misc/translator/po/ia-marc-UNIMARC.po | 2 +- misc/translator/po/ia-opac-bootstrap.po | 258 +-- misc/translator/po/ia-pref.po | 24 + misc/translator/po/ia-staff-prog.po | 845 +++++----- misc/translator/po/id-ID-marc-MARC21.po | 8 +- misc/translator/po/id-ID-marc-NORMARC.po | 2 +- misc/translator/po/id-ID-marc-UNIMARC.po | 2 +- misc/translator/po/id-ID-opac-bootstrap.po | 258 +-- misc/translator/po/id-ID-pref.po | 24 + misc/translator/po/id-ID-staff-prog.po | 855 +++++----- misc/translator/po/iq-CA-marc-MARC21.po | 8 +- misc/translator/po/iq-CA-marc-NORMARC.po | 2 +- misc/translator/po/iq-CA-marc-UNIMARC.po | 2 +- misc/translator/po/iq-CA-opac-bootstrap.po | 258 +-- misc/translator/po/iq-CA-pref.po | 24 + misc/translator/po/iq-CA-staff-prog.po | 845 +++++----- misc/translator/po/is-IS-marc-MARC21.po | 8 +- misc/translator/po/is-IS-marc-NORMARC.po | 2 +- misc/translator/po/is-IS-marc-UNIMARC.po | 2 +- misc/translator/po/is-IS-opac-bootstrap.po | 258 +-- misc/translator/po/is-IS-pref.po | 24 + misc/translator/po/is-IS-staff-prog.po | 846 +++++----- misc/translator/po/it-IT-marc-MARC21.po | 8 +- misc/translator/po/it-IT-marc-NORMARC.po | 2 +- misc/translator/po/it-IT-marc-UNIMARC.po | 2 +- misc/translator/po/it-IT-opac-bootstrap.po | 262 +-- misc/translator/po/it-IT-pref.po | 24 + misc/translator/po/it-IT-staff-prog.po | 851 +++++----- misc/translator/po/iu-CA-marc-MARC21.po | 8 +- misc/translator/po/iu-CA-marc-NORMARC.po | 2 +- misc/translator/po/iu-CA-marc-UNIMARC.po | 2 +- misc/translator/po/iu-CA-opac-bootstrap.po | 258 +-- misc/translator/po/iu-CA-pref.po | 24 + misc/translator/po/iu-CA-staff-prog.po | 845 +++++----- misc/translator/po/ja-Jpan-JP-marc-MARC21.po | 8 +- misc/translator/po/ja-Jpan-JP-marc-NORMARC.po | 2 +- misc/translator/po/ja-Jpan-JP-marc-UNIMARC.po | 2 +- misc/translator/po/ja-Jpan-JP-opac-bootstrap.po | 258 +-- misc/translator/po/ja-Jpan-JP-pref.po | 24 + misc/translator/po/ja-Jpan-JP-staff-prog.po | 846 +++++----- misc/translator/po/ka-marc-MARC21.po | 8 +- misc/translator/po/ka-marc-NORMARC.po | 2 +- misc/translator/po/ka-marc-UNIMARC.po | 2 +- misc/translator/po/ka-opac-bootstrap.po | 258 +-- misc/translator/po/ka-pref.po | 24 + misc/translator/po/ka-staff-prog.po | 845 +++++----- misc/translator/po/km-KH-marc-MARC21.po | 8 +- misc/translator/po/km-KH-marc-NORMARC.po | 2 +- misc/translator/po/km-KH-marc-UNIMARC.po | 2 +- misc/translator/po/km-KH-opac-bootstrap.po | 258 +-- misc/translator/po/km-KH-pref.po | 24 + misc/translator/po/km-KH-staff-prog.po | 845 +++++----- misc/translator/po/kn-Knda-marc-MARC21.po | 8 +- misc/translator/po/kn-Knda-marc-NORMARC.po | 2 +- misc/translator/po/kn-Knda-marc-UNIMARC.po | 2 +- misc/translator/po/kn-Knda-opac-bootstrap.po | 258 +-- misc/translator/po/kn-Knda-pref.po | 24 + misc/translator/po/kn-Knda-staff-prog.po | 849 +++++----- misc/translator/po/ko-Kore-KP-marc-MARC21.po | 8 +- misc/translator/po/ko-Kore-KP-marc-NORMARC.po | 2 +- misc/translator/po/ko-Kore-KP-marc-UNIMARC.po | 2 +- misc/translator/po/ko-Kore-KP-opac-bootstrap.po | 258 +-- misc/translator/po/ko-Kore-KP-pref.po | 24 + misc/translator/po/ko-Kore-KP-staff-prog.po | 850 +++++----- misc/translator/po/ku-Arab-marc-MARC21.po | 8 +- misc/translator/po/ku-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ku-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/ku-Arab-opac-bootstrap.po | 259 +-- misc/translator/po/ku-Arab-pref.po | 24 + misc/translator/po/ku-Arab-staff-prog.po | 846 +++++----- misc/translator/po/lo-Laoo-marc-MARC21.po | 8 +- misc/translator/po/lo-Laoo-marc-NORMARC.po | 2 +- misc/translator/po/lo-Laoo-marc-UNIMARC.po | 2 +- misc/translator/po/lo-Laoo-opac-bootstrap.po | 258 +-- misc/translator/po/lo-Laoo-pref.po | 24 + misc/translator/po/lo-Laoo-staff-prog.po | 853 +++++----- misc/translator/po/lv-marc-MARC21.po | 8 +- misc/translator/po/lv-marc-NORMARC.po | 2 +- misc/translator/po/lv-marc-UNIMARC.po | 2 +- misc/translator/po/lv-opac-bootstrap.po | 258 +-- misc/translator/po/lv-pref.po | 24 + misc/translator/po/lv-staff-prog.po | 845 +++++----- misc/translator/po/mi-NZ-marc-MARC21.po | 8 +- misc/translator/po/mi-NZ-marc-NORMARC.po | 2 +- misc/translator/po/mi-NZ-marc-UNIMARC.po | 2 +- misc/translator/po/mi-NZ-opac-bootstrap.po | 260 +-- misc/translator/po/mi-NZ-pref.po | 24 + misc/translator/po/mi-NZ-staff-prog.po | 846 +++++----- misc/translator/po/ml-marc-MARC21.po | 8 +- misc/translator/po/ml-marc-NORMARC.po | 2 +- misc/translator/po/ml-marc-UNIMARC.po | 2 +- misc/translator/po/ml-opac-bootstrap.po | 258 +-- misc/translator/po/ml-pref.po | 24 + misc/translator/po/ml-staff-prog.po | 845 +++++----- misc/translator/po/mon-marc-MARC21.po | 8 +- misc/translator/po/mon-marc-NORMARC.po | 2 +- misc/translator/po/mon-marc-UNIMARC.po | 2 +- misc/translator/po/mon-opac-bootstrap.po | 258 +-- misc/translator/po/mon-pref.po | 24 + misc/translator/po/mon-staff-prog.po | 846 +++++----- misc/translator/po/mr-marc-MARC21.po | 8 +- misc/translator/po/mr-marc-NORMARC.po | 2 +- misc/translator/po/mr-marc-UNIMARC.po | 2 +- misc/translator/po/mr-opac-bootstrap.po | 258 +-- misc/translator/po/mr-pref.po | 24 + misc/translator/po/mr-staff-prog.po | 849 +++++----- misc/translator/po/ms-MY-marc-MARC21.po | 8 +- misc/translator/po/ms-MY-marc-NORMARC.po | 2 +- misc/translator/po/ms-MY-marc-UNIMARC.po | 2 +- misc/translator/po/ms-MY-opac-bootstrap.po | 258 +-- misc/translator/po/ms-MY-pref.po | 24 + misc/translator/po/ms-MY-staff-prog.po | 854 +++++----- misc/translator/po/my-marc-MARC21.po | 8 +- misc/translator/po/my-marc-NORMARC.po | 2 +- misc/translator/po/my-marc-UNIMARC.po | 2 +- misc/translator/po/my-opac-bootstrap.po | 258 +-- misc/translator/po/my-pref.po | 24 + misc/translator/po/my-staff-prog.po | 845 +++++----- misc/translator/po/nb-NO-marc-MARC21.po | 8 +- misc/translator/po/nb-NO-marc-NORMARC.po | 2 +- misc/translator/po/nb-NO-marc-UNIMARC.po | 2 +- misc/translator/po/nb-NO-opac-bootstrap.po | 262 +-- misc/translator/po/nb-NO-pref.po | 24 + misc/translator/po/nb-NO-staff-prog.po | 854 +++++----- misc/translator/po/ne-NE-marc-MARC21.po | 8 +- misc/translator/po/ne-NE-marc-NORMARC.po | 2 +- misc/translator/po/ne-NE-marc-UNIMARC.po | 2 +- misc/translator/po/ne-NE-opac-bootstrap.po | 258 +-- misc/translator/po/ne-NE-pref.po | 24 + misc/translator/po/ne-NE-staff-prog.po | 849 +++++----- misc/translator/po/nl-BE-marc-MARC21.po | 8 +- misc/translator/po/nl-BE-marc-NORMARC.po | 2 +- misc/translator/po/nl-BE-marc-UNIMARC.po | 2 +- misc/translator/po/nl-BE-messages.po | 20 +- misc/translator/po/nl-BE-opac-bootstrap.po | 299 ++-- misc/translator/po/nl-BE-pref.po | 24 + misc/translator/po/nl-BE-staff-prog.po | 1007 ++++++------ misc/translator/po/nl-NL-marc-MARC21.po | 8 +- misc/translator/po/nl-NL-marc-NORMARC.po | 2 +- misc/translator/po/nl-NL-marc-UNIMARC.po | 2 +- misc/translator/po/nl-NL-opac-bootstrap.po | 258 +-- misc/translator/po/nl-NL-pref.po | 24 + misc/translator/po/nl-NL-staff-prog.po | 849 +++++----- misc/translator/po/nn-NO-marc-MARC21.po | 8 +- misc/translator/po/nn-NO-marc-NORMARC.po | 2 +- misc/translator/po/nn-NO-marc-UNIMARC.po | 2 +- misc/translator/po/nn-NO-opac-bootstrap.po | 258 +-- misc/translator/po/nn-NO-pref.po | 24 + misc/translator/po/nn-NO-staff-prog.po | 846 +++++----- misc/translator/po/oc-marc-MARC21.po | 8 +- misc/translator/po/oc-marc-NORMARC.po | 2 +- misc/translator/po/oc-marc-UNIMARC.po | 2 +- misc/translator/po/oc-opac-bootstrap.po | 258 +-- misc/translator/po/oc-pref.po | 24 + misc/translator/po/oc-staff-prog.po | 852 +++++----- misc/translator/po/pbr-marc-MARC21.po | 8 +- misc/translator/po/pbr-marc-NORMARC.po | 2 +- misc/translator/po/pbr-marc-UNIMARC.po | 2 +- misc/translator/po/pbr-opac-bootstrap.po | 258 +-- misc/translator/po/pbr-pref.po | 24 + misc/translator/po/pbr-staff-prog.po | 845 +++++----- misc/translator/po/pl-PL-marc-MARC21.po | 8 +- misc/translator/po/pl-PL-marc-NORMARC.po | 2 +- misc/translator/po/pl-PL-marc-UNIMARC.po | 2 +- misc/translator/po/pl-PL-opac-bootstrap.po | 275 ++-- misc/translator/po/pl-PL-pref.po | 24 + misc/translator/po/pl-PL-staff-prog.po | 1174 +++++++------- misc/translator/po/prs-marc-MARC21.po | 8 +- misc/translator/po/prs-marc-NORMARC.po | 2 +- misc/translator/po/prs-marc-UNIMARC.po | 2 +- misc/translator/po/prs-opac-bootstrap.po | 258 +-- misc/translator/po/prs-pref.po | 24 + misc/translator/po/prs-staff-prog.po | 850 +++++----- misc/translator/po/pt-BR-marc-MARC21.po | 8 +- misc/translator/po/pt-BR-marc-NORMARC.po | 2 +- misc/translator/po/pt-BR-marc-UNIMARC.po | 14 +- misc/translator/po/pt-BR-messages.po | 21 +- misc/translator/po/pt-BR-opac-bootstrap.po | 300 ++-- misc/translator/po/pt-BR-pref.po | 59 +- misc/translator/po/pt-BR-staff-prog.po | 1674 ++++++++++---------- misc/translator/po/pt-PT-marc-MARC21.po | 8 +- misc/translator/po/pt-PT-marc-NORMARC.po | 2 +- misc/translator/po/pt-PT-marc-UNIMARC.po | 2 +- misc/translator/po/pt-PT-opac-bootstrap.po | 412 ++--- misc/translator/po/pt-PT-pref.po | 28 +- misc/translator/po/pt-PT-staff-prog.po | 862 +++++----- misc/translator/po/ro-RO-marc-MARC21.po | 8 +- misc/translator/po/ro-RO-marc-NORMARC.po | 2 +- misc/translator/po/ro-RO-marc-UNIMARC.po | 2 +- misc/translator/po/ro-RO-opac-bootstrap.po | 258 +-- misc/translator/po/ro-RO-pref.po | 24 + misc/translator/po/ro-RO-staff-prog.po | 850 +++++----- misc/translator/po/ru-RU-marc-MARC21.po | 88 +- misc/translator/po/ru-RU-marc-NORMARC.po | 6 +- misc/translator/po/ru-RU-marc-UNIMARC.po | 6 +- misc/translator/po/ru-RU-opac-bootstrap.po | 272 ++-- misc/translator/po/ru-RU-pref.po | 24 + misc/translator/po/ru-RU-staff-prog.po | 848 +++++----- misc/translator/po/rw-RW-marc-MARC21.po | 8 +- misc/translator/po/rw-RW-marc-NORMARC.po | 2 +- misc/translator/po/rw-RW-marc-UNIMARC.po | 2 +- misc/translator/po/rw-RW-opac-bootstrap.po | 258 +-- misc/translator/po/rw-RW-pref.po | 24 + misc/translator/po/rw-RW-staff-prog.po | 845 +++++----- misc/translator/po/sd-PK-marc-MARC21.po | 8 +- misc/translator/po/sd-PK-marc-NORMARC.po | 2 +- misc/translator/po/sd-PK-marc-UNIMARC.po | 2 +- misc/translator/po/sd-PK-opac-bootstrap.po | 258 +-- misc/translator/po/sd-PK-pref.po | 24 + misc/translator/po/sd-PK-staff-prog.po | 849 +++++----- misc/translator/po/sk-SK-marc-MARC21.po | 8 +- misc/translator/po/sk-SK-marc-NORMARC.po | 2 +- misc/translator/po/sk-SK-marc-UNIMARC.po | 2 +- misc/translator/po/sk-SK-opac-bootstrap.po | 276 ++-- misc/translator/po/sk-SK-pref.po | 24 + misc/translator/po/sk-SK-staff-prog.po | 870 +++++----- misc/translator/po/sl-SI-marc-MARC21.po | 8 +- misc/translator/po/sl-SI-marc-NORMARC.po | 2 +- misc/translator/po/sl-SI-marc-UNIMARC.po | 2 +- misc/translator/po/sl-SI-opac-bootstrap.po | 258 +-- misc/translator/po/sl-SI-pref.po | 24 + misc/translator/po/sl-SI-staff-prog.po | 845 +++++----- misc/translator/po/sq-AL-marc-MARC21.po | 8 +- misc/translator/po/sq-AL-marc-NORMARC.po | 2 +- misc/translator/po/sq-AL-marc-UNIMARC.po | 2 +- misc/translator/po/sq-AL-opac-bootstrap.po | 260 +-- misc/translator/po/sq-AL-pref.po | 24 + misc/translator/po/sq-AL-staff-prog.po | 849 +++++----- misc/translator/po/sr-Cyrl-marc-MARC21.po | 8 +- misc/translator/po/sr-Cyrl-marc-NORMARC.po | 2 +- misc/translator/po/sr-Cyrl-marc-UNIMARC.po | 2 +- misc/translator/po/sr-Cyrl-opac-bootstrap.po | 258 +-- misc/translator/po/sr-Cyrl-pref.po | 24 + misc/translator/po/sr-Cyrl-staff-prog.po | 849 +++++----- misc/translator/po/sv-SE-marc-MARC21.po | 429 +++-- misc/translator/po/sv-SE-marc-NORMARC.po | 2 +- misc/translator/po/sv-SE-marc-UNIMARC.po | 2 +- misc/translator/po/sv-SE-opac-bootstrap.po | 310 ++-- misc/translator/po/sv-SE-pref.po | 32 +- misc/translator/po/sv-SE-staff-prog.po | 915 +++++------ misc/translator/po/sw-KE-marc-MARC21.po | 8 +- misc/translator/po/sw-KE-marc-NORMARC.po | 2 +- misc/translator/po/sw-KE-marc-UNIMARC.po | 2 +- misc/translator/po/sw-KE-opac-bootstrap.po | 258 +-- misc/translator/po/sw-KE-pref.po | 24 + misc/translator/po/sw-KE-staff-prog.po | 845 +++++----- misc/translator/po/ta-LK-marc-MARC21.po | 8 +- misc/translator/po/ta-LK-marc-NORMARC.po | 2 +- misc/translator/po/ta-LK-marc-UNIMARC.po | 2 +- misc/translator/po/ta-LK-opac-bootstrap.po | 258 +-- misc/translator/po/ta-LK-pref.po | 24 + misc/translator/po/ta-LK-staff-prog.po | 845 +++++----- misc/translator/po/ta-marc-MARC21.po | 8 +- misc/translator/po/ta-marc-NORMARC.po | 2 +- misc/translator/po/ta-marc-UNIMARC.po | 2 +- misc/translator/po/ta-opac-bootstrap.po | 258 +-- misc/translator/po/ta-pref.po | 24 + misc/translator/po/ta-staff-prog.po | 845 +++++----- misc/translator/po/tet-marc-MARC21.po | 8 +- misc/translator/po/tet-marc-NORMARC.po | 2 +- misc/translator/po/tet-marc-UNIMARC.po | 2 +- misc/translator/po/tet-opac-bootstrap.po | 260 +-- misc/translator/po/tet-pref.po | 24 + misc/translator/po/tet-staff-prog.po | 852 +++++----- misc/translator/po/th-TH-marc-MARC21.po | 8 +- misc/translator/po/th-TH-marc-NORMARC.po | 2 +- misc/translator/po/th-TH-marc-UNIMARC.po | 2 +- misc/translator/po/th-TH-opac-bootstrap.po | 259 +-- misc/translator/po/th-TH-pref.po | 24 + misc/translator/po/th-TH-staff-prog.po | 849 +++++----- misc/translator/po/tl-PH-marc-MARC21.po | 8 +- misc/translator/po/tl-PH-marc-NORMARC.po | 2 +- misc/translator/po/tl-PH-marc-UNIMARC.po | 2 +- misc/translator/po/tl-PH-opac-bootstrap.po | 258 +-- misc/translator/po/tl-PH-pref.po | 24 + misc/translator/po/tl-PH-staff-prog.po | 850 +++++----- misc/translator/po/tr-TR-marc-MARC21.po | 8 +- misc/translator/po/tr-TR-marc-NORMARC.po | 2 +- misc/translator/po/tr-TR-marc-UNIMARC.po | 2 +- misc/translator/po/tr-TR-opac-bootstrap.po | 262 +-- misc/translator/po/tr-TR-pref.po | 24 + misc/translator/po/tr-TR-staff-prog.po | 853 +++++----- misc/translator/po/tvl-marc-MARC21.po | 8 +- misc/translator/po/tvl-marc-NORMARC.po | 2 +- misc/translator/po/tvl-marc-UNIMARC.po | 2 +- misc/translator/po/tvl-opac-bootstrap.po | 258 +-- misc/translator/po/tvl-pref.po | 24 + misc/translator/po/tvl-staff-prog.po | 845 +++++----- misc/translator/po/uk-UA-marc-MARC21.po | 9 +- misc/translator/po/uk-UA-marc-NORMARC.po | 2 +- misc/translator/po/uk-UA-marc-UNIMARC.po | 6 +- misc/translator/po/uk-UA-opac-bootstrap.po | 268 ++-- misc/translator/po/uk-UA-pref.po | 24 + misc/translator/po/uk-UA-staff-prog.po | 1072 +++++++------ misc/translator/po/ur-Arab-marc-MARC21.po | 8 +- misc/translator/po/ur-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ur-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/ur-Arab-opac-bootstrap.po | 258 +-- misc/translator/po/ur-Arab-pref.po | 24 + misc/translator/po/ur-Arab-staff-prog.po | 845 +++++----- misc/translator/po/vi-VN-marc-MARC21.po | 22 +- misc/translator/po/vi-VN-marc-NORMARC.po | 2 +- misc/translator/po/vi-VN-marc-UNIMARC.po | 2 +- misc/translator/po/vi-VN-opac-bootstrap.po | 258 +-- misc/translator/po/vi-VN-pref.po | 24 + misc/translator/po/vi-VN-staff-prog.po | 852 +++++----- misc/translator/po/zh-Hans-CN-marc-MARC21.po | 8 +- misc/translator/po/zh-Hans-CN-marc-NORMARC.po | 2 +- misc/translator/po/zh-Hans-CN-marc-UNIMARC.po | 2 +- misc/translator/po/zh-Hans-CN-opac-bootstrap.po | 268 ++-- misc/translator/po/zh-Hans-CN-pref.po | 24 + misc/translator/po/zh-Hans-CN-staff-prog.po | 852 +++++----- misc/translator/po/zh-Hant-TW-marc-MARC21.po | 8 +- misc/translator/po/zh-Hant-TW-marc-NORMARC.po | 2 +- misc/translator/po/zh-Hant-TW-marc-UNIMARC.po | 2 +- misc/translator/po/zh-Hant-TW-opac-bootstrap.po | 407 +++-- misc/translator/po/zh-Hant-TW-pref.po | 28 +- misc/translator/po/zh-Hant-TW-staff-prog.po | 913 +++++------ opac/clubs/clubs-tab.pl | 2 +- opac/clubs/enroll.pl | 2 +- opac/opac-account-pay.pl | 2 +- opac/opac-addbybiblionumber.pl | 2 +- opac/opac-alert-subscribe.pl | 2 +- opac/opac-illrequests.pl | 2 +- opac/opac-request-article.pl | 2 +- opac/opac-reserve.pl | 15 +- opac/opac-sendbasket.pl | 4 +- opac/opac-sendshelf.pl | 6 +- opac/opac-shareshelf.pl | 3 +- opac/opac-shelves.pl | 1 + opac/opac-suggestions.pl | 2 +- opac/svc/auth/googleopenidconnect | 2 +- t/db_dependent/Auth.t | 26 +- t/db_dependent/selenium/regressions.t | 50 +- t/lib/Selenium.pm | 35 +- virtualshelves/shelves.pl | 1 + 542 files changed, 54461 insertions(+), 50056 deletions(-) create mode 100644 misc/release_notes/release_notes_18_11_05.html create mode 100644 misc/release_notes/release_notes_18_11_05.md hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 2 15:48:09 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 02 May 2019 13:48:09 +0000 Subject: [koha-commits] main Koha release repository annotated tag v18.11.05 created. v18.11.05 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The annotated tag, v18.11.05 has been created at de28070aa3fd5c29f81454b69ad146f7b49c5330 (tag) tagging 8fab429baa5d4e9f2f96ae34945205d9e09610b0 (commit) replaces v18.11.04 tagged by Martin Renvoize on Thu May 2 14:29:20 2019 +0100 - Log ----------------------------------------------------------------- Koha release 18.11.05 -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE8g0J8pGJSlfC6TBmQitGkTBEGg8FAlzK8LAACgkQQitGkTBE Gg9e+Q//QmPCxXeLs3pzf4v7cOsPSWMBbX30YMfG2EMdhBzUoG008LTZnH69m49m KUqTXVmUjpcrKtv2/mYJu5yIr/qtG2x5kDW60Oh2pD6q1geiAuy2lbcviHEVynKS YbOYRb1b+n0nDvfVMNR3rkDwzowJ33P1EEm18YEOFU26KX119mCl4WG+hPKf+qy/ n1aFcfZxRWBQkc/FEptn2VmVoQ/VEGf3d1E55bWkNq9syCsUqczGylxSjpd4mjKs cOTNwNyqHtwk79iEO0ay0kSZDC0qeVCheK8MDjkY+MSAOuM046f0Y5ceu29CoVKH BB0m4pi4WErORX7FY7LNcWqpaLtEZrE5nJKkDSpbLApFDwrEEXuv0Iuf5AJ73dPy bKZy/7ayCYQfcXJcFcfi4lHYN7CHBzIFlhkImM6uNtXraVoxXjX8NCfa3+FMVfQm jaeRORiJxTep8HnYA5hkUH0MBvWxBmlRoP9sA8yjYjp3k794DBZCOb22LeZPqphK fssF6tA7I0gCABGWpWinz9lJdWMSSmAh78uRARTV5hmUTHTnmCJMHOYuXJYxlXFK 0aX4IhXhEdU+aS/eq0PjMZPLnbqhGwWCQQPz6+DLu1/O88FiRUlCPXRHjvAeN6/Y 7bKjNr3jh/E2Lh07UErbKMq+A7r7RtIEfb/2kGr4DXALsOdplqs= =t+Pd -----END PGP SIGNATURE----- Agustin Moyano (1): Bug 16232: Fix edit as new in Rancor Aleisha Amohia (1): Bug 22365: Removing warn when accessing Log Viewer Andrew Isherwood (1): Bug 22464: Pass forward parameters Arthur Suzuki (1): Bug 22597: Remove "more_subfields_xml" from GetPatronInfo response Bernardo Gonzalez Kriegel (1): Bug 21899: Update MARC21 frameworks to Update 27 (November 2018) Bj?rn Nyl?n (1): Bug 10345: Increment copy number when adding multiple copies. Christopher Brannon (4): Bug 21346: Streamline logic in holds and transfers Bug 21346: Remove double dialog Bug 21346: Convert dialogs to modals. Bug 21346: Remove inline onclicks per comment 42 Colin Campbell (1): Bug 22611: Correction for call to get create_item in EDI.pm Ere Maijala (7): Bug 21974: Make Elasticsearch connection settings configurable Bug 22495: Restore Elasticsearch mapping for su-geo Bug 22295: Make Elasticsearch query builder group multi-term queries Bug 19670: Change Collation of marc_field to allow mixed case mappings Bug 22474: Clone field config before adding fields to it Bug 22339: Fix search field mappings of MARC fixed fields Bug 22413: Improve query string and desc creation for Elasticsearch Fridolin Somers (7): Bug 22596: use raw TT filter in items search with custom field Bug 22620: OPAC description for CCODE in opac-reserve.tt Bug 22595: Items search is mixing inputs Bug 21975: get item field in substitutions Bug 21975: add Unit Test Bug 21975: Avoid unnecessary substitutions in automatic item modification by age Bug 22723: Correct syntax error on confess call in Koha/MetadataRecord/Authority.pm Fr?d?ric Demians (2): Bug 21937: Add test to show autoBarcode annual increment bug Bug 21937: Syspref autoBarcode annual doesn't increment properly barcode Hayley Mapley (4): Bug 12441: Search.pl conditional checks and displays using same syspref Bug 21003: Removed warning and changed wording on add_items-step2.tt Bug 21003: Made Edit keywords more consistent in add_items-step2.tt Bug 19497: Removed title (tooltip) from Edit button in items_search_fields.tt Jonathan Druart (16): Bug 21998: Silent tests Bug 22068: Prevent patrons to cancel article request they did not create Bug 22390: (bug 15184 follow-up) Use aqorders.subscriptionid instead of biblio.serial Bug 22390: Never copy items if original order has been created from a subscription Bug 22472: Add tests Bug 22472: Make column_exists early return if the table does not exist Bug 21172: Remove warning from addbiblio.pl Bug 22461: Fix LDAP user replication Bug 22461: Filter ldap mapping before inserting patron's info Bug 22762: Fix items.collection display on receiving Bug 20891: Escape list's names in JSON Bug 20891: Escape html then JSON Bug 22621: Fix filters on subscription search results Bug 22478: Prevent XSS vulnerabilities when pagination appears Bug 22478: Add tests Bug 22542: Force back button to display personal data Josef Moravec (14): Bug 19661: (follow-up) Use Basic auth in tests Bug 21998: Throw exception on bad pattern Bug 13895: (follow-up) Adapt checkout endpoint to openapi, update terminology Bug 13895: Remove the opac checks in privileged endpoint Bug 13895: Remove create_item and create_biblio subs from test Bug 13895: Refactor test using REST Basic auth Bug 13895: Change renewal endpoint Bug 13895: (follow-up) Fix POST response Bug 13895: Adapt naming according to voted RFC Bug 13895: Fix test Bug 22607: Change default value in issues.renewals to '0'. Bug 22451: Make Asset plugin use Koha::version instead of version from db Bug 22451: Update test Bug 22451: Use Asset everywhere Julian Maurice (3): Bug 21049: Fix value of material select for Rancor 007 widget Bug 21049: Set 007/00 when selecting material type (Rancor) Bug 13895: Add API routes for checkouts retrieval and renewal Katrin Fischer (18): Bug 22648: Fix typo in SQL in smart-rules.pl Bug 19747: Add link to article requests help page Bug 22075: Fix encoding problem with RIS export in OPAC Bug 22624: Show OPAC description for authorised values in OPAC Bug 22634: Standardize table creation for stockrotation* tables in kohastructure.sql Bug 21659: Fix links to basket groups from order receive page Bug 21659: Change link to basket group edit page Bug 22501: Add raw filter to course reserves summary page Bug 19648: Revise marc21_field_007.xml Bug 22090: Add missing information to cash register CSV file Bug 22154: Fix search for Braille from Advanced search page Bug 22044: Fix sysprefs.sql description to use circ column description Bug 21172: Remove obsolete framework parameter from GetMarcFromKohaField Bug 21545: Translate 'Stock rotation slip' Bug 21545: Translate new ACCOUNT_PAYMENT and ACCOUNT_WRITEOFF notices to German Bug 22174: Add link to help page for API key management Bug 22753: Fix tabs pointed out by QA script Bug 22478: Fix POD Koha translators (1): Translation updates for Koha 18.11.05 Kris Sinnaeve (1): Bug 22139: Fields of ACCTDETAILS email not populating Kyle M Hall (5): Bug 17978: Circ rules will not limit holds Bug 22688: Unit tests Bug 22688: TT plugin for pickup locations code wrong Bug 22715: Searching for patrons with "" in the circulation note hangs patron search Bug 21589: Series link formed from 830 field is incorrect Liz Rea (2): Bug 22501: (QA follow-up) use $raw for the note in the intranet Bug 18387: (QA Follow up) adding specificity to error template. Lucas Gass (3): Bug 22586: IntranetReportsHomeHTML no longer renders as HTML on reports-home.pl Bug 22501: OPAC course reserves notes should allow html links Bug 22702: circulation note on patron page should allow for HTML tags Lyon3 Team (1): Bug 22652: Editing Course reserves is broken Magnus Enger (1): Bug 22646: Fix use of PrivacyPolicyURL Marcel de Rooy (3): Bug 21998: Add pattern parameter in Koha::Token Bug 22735: Resolve internal server error on missing item type Bug 22478: (QA follow-up) Handle category in opac-shelves like a boolean Mark Tompsett (1): Bug 20692: Extreme toggle checking for plack Martin Renvoize (12): Bug 22618: (RMaint follow-up) Backport fix Bug 22121: Display 'Price paid' on ILL requests according to CurrencyFormat pref Bug 22642: Corrections to updatedatebase for bug 12395 Bug 22069: Make log viewer find item renewals Bug 22461: Clarify and correct the hash reduction Bug 22461: (follow-up) Use `exists` not `defined` Bug 22687: Typo correction for Portuguese manual link Bug 22478: (QA follow-up) Make test consistent with variable name Bug 22478: (QA follow-up) Update tests to check for any script tags Bug 22478: (RMaint follow-up) source t::lib::Mocks Increment version for 18.11.05 release Update release notes for 18.11.05 release Maryse Simard (1): Bug 21263: Pickup library not set correctly when using Default holds policy Matthias Meusburger (3): Bug 19661: REST API - Funds Endpoint Bug 19661: Use Koha::Acquisition::Funds instead of C4::Budgets Bug 19661: Add and change properties and parameters to conform to the funds RFC. Nick Clemens (28): Bug 21948: Compiled CSS Bug 21622: (RM follow-up) adjust for changes from bug 21282 Bug 13895: (follow-up) Add Modern::Perl Bug 22607: DBRev 18.11.04.001 Bug 17978: Check if hold can be placed before placing on placerequest.pl Bug 17978: Unit tests for changes Bug 22641: Use raw filter on html slip Bug 22618: Move tests to t/db_dependent/Acquisition.t Bug 22288: Correct item search in batchMod by barcode file Bug 22541: Invoice adjustments should show invoice number and include link on ordered.pl and spent.pl Bug 20937: Truncate items for print notices when user has an email Bug 22680: Compiled CSS Bug 19670: DBRev 18.11.05.002 Bug 18387: Allow sco-user to access errors templates Bug 22044: Set default and add NoRenewalBeforePrecision preference for new/affected installs Bug 22044: Correct syspref name Bug 22044: DBRev 18.11.04.003 Bug 21957: Add a flag to ModBiblio to avoid linking auths if called from linker Bug 15505: Mark Hold Items 'On hold' instead of 'Available' Bug 22501: (follow-up) Use raw filter for course note on details page Bug 22753: Fix hold priority adjustment, move to top Bug 22743: Add password modal to overdrive results page Bug 19241: Waiting items show as available in the cart Bug 22650: Prevent multiple holds on individual items Bug 22339: DBRev 18.11.04.004 Bug 22715: Remove extraneous html filter Bug 22692: Unit tests Bug 22692: Check for patron using cardnumber and userid Olivier Crouzet (1): Bug 20830: Make sure a fund is selected when ordering from a stage file Owen Leonard (15): Bug 21948: Clean up style of item detail page Bug 22550: OPAC suggestion form doesn't require mandatory fields Bug 22561: Forgotten password requirements hint doesn't list all rules for new passwords Bug 22560: Forgotten password "token expired" page still shows boxes to reset password Bug 22536: Display problem in Holds to Pull report Bug 22575: Item type administration uses invalid error class for dialog Bug 22475: Shelving location doesn't appear on tags list view Bug 21013: Missing itemtype for checkut makes patron summary print explode Bug 22626: 'Filter paid transactions' broken on Transactions tab in staff Bug 22680: OPAC language footer not positioned correctly Bug 14358: Changing the module refreshes the page and resets library choice Bug 13629: SingleBranchMode removes both library and availability search from advanced search Bug 22444: currencies_manage permission doesn't provide link to manage currencies when selected alone Bug 18011: Enrollment period date on patron category can be set in the past without any error/warning messages Bug 22716: Use gender-neutral pronouns in system preference descriptions Thatcher Leonard (1): Bug 18584: Our legacy code contains trailing-spaces Tomas Cohen Arazi (9): Bug 17746: Make koha-reset-passwd user set_password.pl Bug 17746: Add misc/admin/set_password.pl script Bug 17746: (QA follow-up) Make set_password.pl generate a password if required Bug 13895: (QA follow-up) Adjust OpenAPI definitions for checkouts Bug 13895: (QA follow-up) Make the class plural Bug 22068: (QA follow-up) Return meaningful error codes Bug 22688: (follow-up) Unit tests Bug 22688: (QA follow-up) Use search_params as all() does Bug 22739: Test SelfCheckInTimeout <> 0, not just defined phette23 (1): Bug 22551: Stray "//" appears at bottom of opac-detail.tt ----------------------------------------------------------------------- hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 2 16:06:41 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 02 May 2019 14:06:41 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v18.11.00-1419-g6a0246e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 6a0246e24838cfba672baf4aef080588b7d091bf (commit) via d9b3b90849fd95d296b73b330c4e32ff018c81a5 (commit) via d5e7dd15fc9c064f99739b27e5b40456b359f420 (commit) via 375dd35d5354d46c4c16f534494b123ce370c3f4 (commit) via 401e8e791e32008e93e959dd9ed1b4491cb0796a (commit) via 3b12416dc8d8f833bc745402ae835cc56c897fef (commit) via f021ca30a5d3944a43b4f6e089b21cfd9dc02997 (commit) via 0fb9b9fdb080dfe8c7bccd7f83a9c63bb3c9b104 (commit) via 05f22c2159f3edf597d82ff76ea266760a7498cd (commit) via 456a7ae6d452a4a805b521f0123c666bb8e84085 (commit) via 30de51fa0c707322ce95a318df72ec5d7b5d3eb0 (commit) from 76871516050103f986e50034bccadd4b82fcd2d7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6a0246e24838cfba672baf4aef080588b7d091bf Author: Jonathan Druart Date: Thu Mar 21 14:45:37 2019 -0300 Bug 22542: Force back button to display personal data This is a follow-up of bug 5371 The following command must not return anything: grep ^output_html_with_http_headers `git grep -l -P "authnotrequired\s*=>\s*0" opac`|grep -v force_no_caching This must be a test somehwere to prevent further regressions. Signed-off-by: Katrin Fischer Signed-off-by: Chris Cormack Signed-off-by: Nick Clemens commit d9b3b90849fd95d296b73b330c4e32ff018c81a5 Author: Martin Renvoize Date: Mon Apr 29 13:30:09 2019 +0100 Bug 22478: (QA follow-up) Update tests to check for any script tags Signed-off-by: Nick Clemens commit d5e7dd15fc9c064f99739b27e5b40456b359f420 Author: Martin Renvoize Date: Fri Apr 26 19:56:43 2019 +0100 Bug 22478: (QA follow-up) Make test consistent with variable name We were adding data to category 1 (private lists) and testing against that, but we named the variable 'publist_lists'. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens commit 375dd35d5354d46c4c16f534494b123ce370c3f4 Author: Marcel de Rooy Date: Fri Apr 12 07:02:06 2019 +0000 Bug 22478: (QA follow-up) Handle category in opac-shelves like a boolean The category parameter should be restricted to 1 or 2 (private/public). In order to keep same behavior, no parameter means 1 (private). Note: Adding the same line in intranet counterpart. Test plan [1] Check for category empty, '1a', '11' etc. And with script ;) Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens commit 401e8e791e32008e93e959dd9ed1b4491cb0796a Author: Katrin Fischer Date: Wed Apr 10 02:06:37 2019 +0000 Bug 22478: Fix POD Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens commit 3b12416dc8d8f833bc745402ae835cc56c897fef Author: Jonathan Druart Date: Fri Mar 15 13:41:27 2019 -0300 Bug 22478: Add tests Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens commit f021ca30a5d3944a43b4f6e089b21cfd9dc02997 Author: Jonathan Druart Date: Thu Mar 14 19:42:50 2019 -0300 Bug 22478: Prevent XSS vulnerabilities when pagination appears This is a bad one as we thought we were XSS safe since bug 13618. The html code generated in C4::Output::pagination_bar must escape the variables and values correctly. This patch needs to be widely tested, everywhere the pagination appears, to make sure we will not introduce regressions. Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens commit 0fb9b9fdb080dfe8c7bccd7f83a9c63bb3c9b104 Author: Martin Renvoize Date: Fri Apr 26 17:24:06 2019 +0100 Bug 22478: (RMaint follow-up) source t::lib::Mocks In 18.11.x the t::lib::Mocks module is not yet sourced for the relevant test Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens commit 05f22c2159f3edf597d82ff76ea266760a7498cd Author: Nick Clemens Date: Thu May 2 13:40:07 2019 +0000 Bug 22692: (RM follow-up) Adjust test count Signed-off-by: Nick Clemens commit 456a7ae6d452a4a805b521f0123c666bb8e84085 Author: Nick Clemens Date: Fri Apr 12 01:23:34 2019 +0000 Bug 22692: Check for patron using cardnumber and userid TO test: 1 - Set failed login attempts to 1 2 - Attempt a login with a userid and bad password, no success 3 - Attempt a login with userid and correct password, prevented because locked 4 - Attempt a login with cardnumber and right password, you are logged in 5 - Log out, try again with userid and correct password, prevented because locked? 6 - Apply patch 7 - Repeat 1-3 to lock account 8 - Attempt logging in with cardnumber, you are prevented Signed-off-by: Martin Renvoize Signed-off-by: Chris Cormack Signed-off-by: Nick Clemens commit 30de51fa0c707322ce95a318df72ec5d7b5d3eb0 Author: Nick Clemens Date: Fri Apr 12 01:11:19 2019 +0000 Bug 22692: Unit tests 1 - Apply just this patch 2 - prove -v t/db_dependent/Auth.t 3 - Failure 4 - Apply second patch 5 - prove -v t/db_dependent/Auth.t 6 - Success Signed-off-by: Martin Renvoize Signed-off-by: Chris Cormack Signed-off-by: Nick Clemens ----------------------------------------------------------------------- Summary of changes: C4/Auth.pm | 1 + C4/Output.pm | 6 +++- opac/clubs/clubs-tab.pl | 2 +- opac/clubs/enroll.pl | 2 +- opac/opac-account-pay.pl | 2 +- opac/opac-addbybiblionumber.pl | 2 +- opac/opac-alert-subscribe.pl | 2 +- opac/opac-illrequests.pl | 2 +- opac/opac-request-article.pl | 2 +- opac/opac-reserve.pl | 15 ++++------ opac/opac-sendbasket.pl | 4 +-- opac/opac-sendshelf.pl | 6 ++-- opac/opac-shareshelf.pl | 3 +- opac/opac-shelves.pl | 1 + opac/opac-suggestions.pl | 2 +- opac/svc/auth/googleopenidconnect | 2 +- t/db_dependent/Auth.t | 26 ++++++++++++++++- t/db_dependent/selenium/regressions.t | 50 ++++++++++++++++++++++++++++++++- t/lib/Selenium.pm | 35 +++++++++++++++++++++-- virtualshelves/shelves.pl | 1 + 20 files changed, 134 insertions(+), 32 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue May 7 14:01:58 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 07 May 2019 12:01:58 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v18.11.00-1433-g604c7b8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 604c7b818b63b93c66bb751ceb9d99bc1c109be9 (commit) via 88b37330abaee6372ec999c1a81fd216d66a1379 (commit) via 295e9b1054386cf188c5fc1eb4fd590e5c451513 (commit) via 4560d9623663e9fd0b60f9a39ec53082cdd90f24 (commit) via b9bff787ca863a45128cbd3a05a109e8f66d4fdf (commit) via 100b1e3eecb4de27f6a85095196019f6b36251c0 (commit) via abd4445cd2b86fe601de20b403bb621115b27c83 (commit) via d57239ca78e7719f4c04865e8c493919c6362c15 (commit) via 914f23970de536df3972ebd75b280ee8eec98955 (commit) via 45b1ff8dfa1054590544caff200b307144bd02cf (commit) via 10efe4e3f239c47b847c53f06f82245e07d54759 (commit) via c1513a10c35f721e3c519d5ab3c38c7154b7fa1c (commit) via 6509d73d7925fe5d317d6f2baa1d1565d8d36220 (commit) via 28bcc5aa68733e41d50a6a801088b06857968f42 (commit) from 6a0246e24838cfba672baf4aef080588b7d091bf (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 604c7b818b63b93c66bb751ceb9d99bc1c109be9 Author: Liz Rea Date: Wed May 1 00:31:15 2019 +0000 Bug 22816: OPAC detail holdings table should now look a bit better This patch sets the "autowidth" option to "false" for the OPAC holdings DataTable on opac-detail.pl. This gives the table a fluid width rather than having the width be "hard-coded" by DataTables upon first page render. To test, apply the patch and view the detail page for a bibliographic record with some items. Under the "Holdings" tab, the table of holdings should fill the width of the tab container. Resize the browser window and confirm that the table width adjusts accordingly. Signed-off-by: Bin Wen Signed-off-by: arthur Signed-off-by: Chris Cormack Signed-off-by: Nick Clemens commit 88b37330abaee6372ec999c1a81fd216d66a1379 Author: Marcel de Rooy Date: Thu Jul 5 12:10:26 2018 +0200 Bug 21036: Remove odd number of elements warnings from AuthoritiesMarc.pm Like this one (16.11 line number): Odd number of elements in anonymous hash at C4/AuthoritiesMarc.pm line 1070. We need to add a scalar to some MARC::Field::subfield calls. In list context an empty list returned affects the hash built around it. Test plan: Could reproduce this warning easily from OPAC authority search. opac-authorities-home.pl calling BuildSummary. Signed-off-by: Bouzid Fergani Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens commit 295e9b1054386cf188c5fc1eb4fd590e5c451513 Author: Marcel de Rooy Date: Thu Jul 5 09:53:57 2018 +0200 Bug 21036: Fix warnings from C4/Biblio Use of uninitialized value $isbn in string ne at /usr/share/koha/prodclone/C4/Biblio.pm line 1794. (16.11 line number) Trivial edit. And these warnings from TransformHtmlToXml (with 16.11 line numbers): Use of uninitialized value in substr at /usr/share/koha/prodclone/C4/Biblio.pm line 2527. Use of uninitialized value in substr at /usr/share/koha/prodclone/C4/Biblio.pm line 2528. substr outside of string at /usr/share/koha/prodclone/C4/Biblio.pm line 2528. Indicator in 952 is empty at /usr/share/koha/prodclone/C4/Biblio.pm line 2534. The last warning is not needed and can be removed. Note that the code used the construct @$indicator[$j] for $$indicator[$j]. The first is an array slice. This worked in list context. But apparently the second was meant to be used. And can be rewritten as $indicator->[$j] which generally is considered more readable. The code around indicator1/2 and ind1/2 is simplified. This change is applied twice in the same sub. Test plan: Read the changes. Run t/Biblio/TransformHtmlToXml.t Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens commit 4560d9623663e9fd0b60f9a39ec53082cdd90f24 Author: Marcel de Rooy Date: Wed Jul 4 16:49:38 2018 +0200 Bug 21036: Fix uninitialized value within @itemnumber in string ne Line from 16.11 log: Use of uninitialized value within @itemnumber in string ne at /usr/share/koha/prodclone/reserve/modrequest.pl line 70. Test plan: Read the change. Not 100% identical (numeric zero) but should be enough. This line is probably not needed at all. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens commit b9bff787ca863a45128cbd3a05a109e8f66d4fdf Author: Jonathan Druart Date: Sun Apr 28 22:09:39 2019 -0400 Bug 22800: (bug 22550 follow-up) Do not raw filter when not necessary (OPAC suggestions) This is a follow-up for bug 22550, we do not need to use the $raw filter. Test plan: Same as bug 22550: Test plan: Test plan: 1. OPAC->login->your purchase suggestions->New purchase suggestion 2. Click button "Submit your suggestion" directly without filling in any field. Empty suggestion record was added succeffully. 3. Apply the patch. 4. Click button "Submit your suggestion" directly without filling in any field. The required fields should be labeled in red. (you can change the mandatory fields by preference 'OPACSuggestionMandatoryFields') Signed-off-by: Bin Wen Signed-off-by: Chris Cormack Signed-off-by: Nick Clemens commit 100b1e3eecb4de27f6a85095196019f6b36251c0 Author: Nick Clemens Date: Fri Apr 26 19:58:05 2019 +0000 Bug 22791: Unify calculation between aqui-home and ordered.pl To test: 1 - Enable order price rounding 2 - Order an example with 8 * 16,99 and 42% discount, 19.45% tax. 3 - Check ordered page - 94.17 is total 4 - Check aqui-home - 94.16 is total 5 - Apply patch 6 - Verify numbers now match Signed-off-by: Maryse Simard Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit abd4445cd2b86fe601de20b403bb621115b27c83 Author: Liz Rea Date: Tue Apr 16 06:55:36 2019 +0000 Bug 22527: web installer links to outdated DB manual To reproduce: 1. Use MySQL or MariaDB for your Koha installation 2. Create an empty database and point $KOHA_CONF to this database name. 3. Grant SELECT privilege to your database user, e.g. grant select on koha3.* to 'koha'@'%' identified by 'koha'; 4. Go to step 2 of web installer where it checks database connection 5. Observe the following message User koha doesn't have enough privilege on database koha. Ask for or make a change in the user's privileges. User koha must have USAGE, INSERT, UPDATE, DELETE, DROP and CREATE privileges on database koha2. Need help? See manual for PostgreSQL 6. Note "See manual for PostgreSQL" is wrong. Should now read Need help? For help with granting permissions, please search online for "[% dbms %] manual grant permissions" of course the dbms should be the dbms you are using. 7. Apply patch, restart all 8. Refresh page and observe it now displays correct link Test plan and original patchset by Lari Taskula Sponsored-by: Hypernova Oy Signed-off-by: Hayley Mapley Signed-off-by: Jonathan Druart Bug 22527: Remove extra space after '?' Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens commit d57239ca78e7719f4c04865e8c493919c6362c15 Author: Josef Moravec Date: Mon Apr 29 14:18:43 2019 +0200 Bug 22787: Add mapping of letters "?" and "?" to zebra definitions Test plan: 0) Do not apply the patch 1) Add some word with character "?" into metadata, for example author "Martin?, Bohuslav" 2) Try to search it with "Martinu" and you'll see you can't find it 3) Apply the patch 4) Copy file etc/zebradb/etc/word-phrase-utf.chr to your /etc/koha directory sudo cp etc/zebradb/etc/word-phrase-utf.chr /etc/koha/zebradb/etc/ 5) koha-zebra --restart kohadev 6) koha-rebuild-zebra -f kohadev 6) try to search "Martinu" again - you should be able to find your record Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Signed-off-by: Chris Cormack Signed-off-by: Nick Clemens commit 914f23970de536df3972ebd75b280ee8eec98955 Author: Jonathan Druart Date: Mon Nov 12 15:20:33 2018 -0300 Bug 21671: Prevent Modifications.t to fail randomly If repeatable is set to 0 by TestBuilder, the tests will fail with: t/db_dependent/Koha/Patron/Modifications.t .. 1/6 # Looks like you planned 20 tests but ran 9. # Failed test 'approve tests' # at t/db_dependent/Koha/Patron/Modifications.t line 259. [repeatable not set for attribute type and tried to add a new attribute for the same code]# Looks like your test exited with 255 just after 5. Signed-off-by: Liz Rea Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens commit 45b1ff8dfa1054590544caff200b307144bd02cf Author: Tomas Cohen Arazi Date: Tue Apr 30 15:48:14 2019 -0300 Bug 22813: (follow-up) Add missing condition This patch restores a missing condition. $patron gets renamed to make it obvious that it related to the logged in user. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens commit 10efe4e3f239c47b847c53f06f82245e07d54759 Author: Tomas Cohen Arazi Date: Tue Apr 30 12:30:25 2019 -0300 Bug 22813: remove repetitive queries inside two nested loops in searchResults This patch moves a query on Koha::Patrons and then the related Koha::Patron::Category that needlessly happens inside two nested loops (all items of all MARC records in the resultset). The Koha::Patron and Koha::Patron::Category are always the same as it is fetched from C4::Context->userenv each time. To test: - Run: $ kshell k$ prove t/db_dependent/Search.t => SUCCESS: Tests pass - Apply this patch - Run: k$ prove t/db_dependent/Search.t => SUCCESS: Tests still pass! - Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Liz Rea Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens commit c1513a10c35f721e3c519d5ab3c38c7154b7fa1c Author: Jonathan Druart Date: Mon Mar 4 18:12:56 2019 -0300 Bug 22453: Make TestBuilder generates dates taking into account the timezone I have no idea why this only appears today but TestBuilder generates dates using DateTime->now, which does not take into account the timezone. It has been highlights by a failing test today on U18. Why today whereas this patch was pushed few weeks ago? Why U18 and not D9? The output of the test is: koha_1 | # Failed test 'With BorrowerLogs and TrackLastPatronActivity we should not spam the logs' koha_1 | # at t/db_dependent/Koha/Patrons.t line 1421. koha_1 | # got: '2' koha_1 | # expected: '1' koha_1 | # Looks like you failed 1 test of 4. koha_1 | koha_1 | # Failed test 'BorrowersLog tests' koha_1 | # at t/db_dependent/Koha/Patrons.t line 1422. koha_1 | # Looks like you failed 1 test of 33. koha_1 | [19:51:44] t/db_dependent/Koha/Patrons.t Actually there are 2 logs, one for the cardnumber that is expected, and on for updated_on: "updated_on" : { "after" : "2019-03-04 21:10:00", "before" : "2019-03-04 18:10:00" } Apart from the fact that we may want to remove this updated_on field from MODIFY, the before/after dates differ from 3 hours. Here it's currently 18:10 and in UTC-3 To prevent such behaviors in tests (create stuffs in the future...), we should use our Koha::DateUtils::dt_from_string method that takes care of the timezone used in other places of Koha. Test plan: prove t/db_dependent/Koha/Patrons.t May fail without this patch. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy This patch is fine in itself, but there may still be an issue around the failing test for TrackLastPatronActivity. Reopened bug 22741. Signed-off-by: Nick Clemens commit 6509d73d7925fe5d317d6f2baa1d1565d8d36220 Author: Mirko Tietgen Date: Tue Apr 30 10:56:20 2019 +0200 Bug 22808: Move Cache.t to db_dependent Cache.t fails during package build. Moving it to db_dependent fixes the problem. Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit 28bcc5aa68733e41d50a6a801088b06857968f42 Author: Tomas Cohen Arazi Date: Wed Feb 27 07:09:12 2019 -0300 Bug 22420: Remove wrong calculation on approved tags Before the patch from bug 14385, the passed structure (that is returned by get_approval_rows() looks like: \ [ [0] { approved 1, approved_by 51, approved_by_name undef, date_approved "2019-02-26 15:36:42", term "another", weight_total 3 }, [1] { ... After the introduced 'filtering', we loose the information about the term weight!: \ [ [0] { approved 1, author "Heylin, Clinton.", biblionumber 1, borrowernumber 51, date_created "2019-02-26 15:36:37", language undef, subtitle [], tag_id 1, term "word", time_created_display "15:36:37", title "E Street shuffle :", visible 1, XSLTBloc " <<>> ... The code even calls GetMarcBiblio. This needs to be reverted as it is plain wrong. If it was worth removing *some* biblios from the weight_total value, then this calculation should be done somewhere else, without fetching the MARC data again. Signed-off-by: Claudio Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens ----------------------------------------------------------------------- Summary of changes: C4/AuthoritiesMarc.pm | 10 +++---- C4/Biblio.pm | 28 +++++--------------- C4/Search.pm | 13 ++++++--- acqui/ordered.pl | 2 +- etc/zebradb/etc/word-phrase-utf.chr | 2 ++ .../prog/en/modules/installer/step2.tt | 6 +---- .../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 6 +++-- .../bootstrap/en/modules/opac-suggestions.tt | 4 +-- opac/opac-suggestions.pl | 6 ++--- opac/opac-tags.pl | 18 ------------- reserve/modrequest.pl | 2 +- t/{ => db_dependent}/Cache.t | 0 t/db_dependent/Koha/Patron/Modifications.t | 2 +- t/lib/TestBuilder.pm | 5 ++-- 14 files changed, 39 insertions(+), 65 deletions(-) rename t/{ => db_dependent}/Cache.t (100%) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue May 7 18:16:57 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 07 May 2019 16:16:57 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v18.11.00-1434-gd38d78b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via d38d78bcf4cc62d34aa953864cf6da87bef93c80 (commit) from 604c7b818b63b93c66bb751ceb9d99bc1c109be9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d38d78bcf4cc62d34aa953864cf6da87bef93c80 Author: Nick Clemens Date: Tue May 7 15:57:35 2019 +0000 Bug 22527: (RM follow-up) Add filter Signed-off-by: Nick Clemens ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/installer/step2.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue May 7 18:54:23 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 07 May 2019 16:54:23 +0000 Subject: [koha-commits] main Koha release repository branch 18.05.x updated. v18.05.11-64-gf3f99eb Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.05.x has been updated via f3f99eb4988ffefcef9ebd71ebb1b255a05113d0 (commit) via c57d349e46859a52be87b325b02d3e9db9871ecf (commit) via f40fd9a918c12406a59f00a3d44aeab8fa075aa8 (commit) via 0c9e2bcf8791857f082f5abb83666169cf790057 (commit) via e732f496a49ee49c9b988b83bb937d95afed3f7e (commit) via 0ae32fd8e983b520ffe4742ca9192afff3064b80 (commit) via 1bff8d19299040f669ad8c3a03e19c6e4ccc36d8 (commit) via a217d1e826e972413caf36fa5c91b0fd376a7644 (commit) via fd18249965235586deb2e3cc3f4653acd59ecc37 (commit) via 86c1f2d4238e10ccb7f6c5a16c62820dee756cc9 (commit) via 40b00b9875f3f0cdcfb11aa179b97945529d8895 (commit) via f7b12a1cf3da62d8ed884692b4161dca1d456bfe (commit) via 63691c6f248e769ecf3165f5363f4bb1a96e4c3a (commit) via a2a9596c22bb94486483ba182bee4900dde42964 (commit) via ae26ee183bea7d2073e53beda1b4fd71e5b56e39 (commit) from 8fbf85efd2179495cc50e8ec3609c382fc010094 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f3f99eb4988ffefcef9ebd71ebb1b255a05113d0 Author: Lucas Gass Date: Tue Apr 30 23:29:15 2019 +0000 Bug 22478: (RMaint follow-up) Fix blank line before =head1 Signed-off-by: Lucas Gass commit c57d349e46859a52be87b325b02d3e9db9871ecf Author: Martin Renvoize Date: Thu May 2 13:49:07 2019 +0100 Update release notes with security bugs Signed-off-by: Martin Renvoize Signed-off-by: Lucas Gass commit f40fd9a918c12406a59f00a3d44aeab8fa075aa8 Author: Lucas Gass Date: Mon Apr 29 05:15:04 2019 +0000 Update release notes for 18.05.12 release Signed-off-by: Lucas Gass commit 0c9e2bcf8791857f082f5abb83666169cf790057 Author: Nick Clemens Date: Fri Apr 12 01:23:34 2019 +0000 Bug 22692: Check for patron using cardnumber and userid TO test: 1 - Set failed login attempts to 1 2 - Attempt a login with a userid and bad password, no success 3 - Attempt a login with userid and correct password, prevented because locked 4 - Attempt a login with cardnumber and right password, you are logged in 5 - Log out, try again with userid and correct password, prevented because locked? 6 - Apply patch 7 - Repeat 1-3 to lock account 8 - Attempt logging in with cardnumber, you are prevented Signed-off-by: Martin Renvoize Signed-off-by: Chris Cormack Signed-off-by: Martin Renvoize (cherry picked from commit ebc15764ff3371a9327cfe60c22c1186e5a200ae) Signed-off-by: Lucas Gass commit e732f496a49ee49c9b988b83bb937d95afed3f7e Author: Nick Clemens Date: Fri Apr 12 01:11:19 2019 +0000 Bug 22692: Unit tests 1 - Apply just this patch 2 - prove -v t/db_dependent/Auth.t 3 - Failure 4 - Apply second patch 5 - prove -v t/db_dependent/Auth.t 6 - Success Signed-off-by: Martin Renvoize Signed-off-by: Chris Cormack Signed-off-by: Martin Renvoize (cherry picked from commit bc066fea9f855c0fc4e1fbc43736121783d3b77b) Signed-off-by: Lucas Gass commit 0ae32fd8e983b520ffe4742ca9192afff3064b80 Author: Martin Renvoize Date: Fri Apr 26 17:24:06 2019 +0100 Bug 22478: (RMaint follow-up) source t::lib::Mocks In 18.11.x the t::lib::Mocks module is not yet sourced for the relevant test Signed-off-by: Martin Renvoize (cherry picked from commit 0f69e4ae485b6c7f94231ea34ad057b1d4cefff7) Signed-off-by: Lucas Gass commit 1bff8d19299040f669ad8c3a03e19c6e4ccc36d8 Author: Martin Renvoize Date: Mon Apr 29 13:30:09 2019 +0100 Bug 22478: (QA follow-up) Update tests to check for any script tags (cherry picked from commit 01dc3a2a8b079b80a5aeb09b6a4c14ca667226a2) Signed-off-by: Lucas Gass commit a217d1e826e972413caf36fa5c91b0fd376a7644 Author: Martin Renvoize Date: Fri Apr 26 19:56:43 2019 +0100 Bug 22478: (QA follow-up) Make test consistent with variable name We were adding data to category 1 (private lists) and testing against that, but we named the variable 'publist_lists'. Signed-off-by: Martin Renvoize (cherry picked from commit 5977db6738a50f398e9049db39d8a8e622546f2e) Signed-off-by: Lucas Gass commit fd18249965235586deb2e3cc3f4653acd59ecc37 Author: Marcel de Rooy Date: Fri Apr 12 07:02:06 2019 +0000 Bug 22478: (QA follow-up) Handle category in opac-shelves like a boolean The category parameter should be restricted to 1 or 2 (private/public). In order to keep same behavior, no parameter means 1 (private). Note: Adding the same line in intranet counterpart. Test plan [1] Check for category empty, '1a', '11' etc. And with script ;) Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize (cherry picked from commit 3d06afa4cdd9131fb9784a9d76b14a669e35ffc7) Signed-off-by: Lucas Gass commit 86c1f2d4238e10ccb7f6c5a16c62820dee756cc9 Author: Katrin Fischer Date: Wed Apr 10 02:06:37 2019 +0000 Bug 22478: Fix POD Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize (cherry picked from commit ab5a04e885b6a759e62d5fd78608302e89a14166) Signed-off-by: Lucas Gass commit 40b00b9875f3f0cdcfb11aa179b97945529d8895 Author: Jonathan Druart Date: Fri Mar 15 13:41:27 2019 -0300 Bug 22478: Add tests Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize (cherry picked from commit b398ba9f3e1a042ec0784100a32a48ba9c0fe2de) Signed-off-by: Lucas Gass commit f7b12a1cf3da62d8ed884692b4161dca1d456bfe Author: Jonathan Druart Date: Thu Mar 14 19:42:50 2019 -0300 Bug 22478: Prevent XSS vulnerabilities when pagination appears This is a bad one as we thought we were XSS safe since bug 13618. The html code generated in C4::Output::pagination_bar must escape the variables and values correctly. This patch needs to be widely tested, everywhere the pagination appears, to make sure we will not introduce regressions. Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize (cherry picked from commit d4d1107afa873614ace241557e424de0dcbad20a) Signed-off-by: Lucas Gass commit 63691c6f248e769ecf3165f5363f4bb1a96e4c3a Author: Jonathan Druart Date: Thu Mar 21 14:45:37 2019 -0300 Bug 22542: Force back button to display personal data This is a follow-up of bug 5371 The following command must not return anything: grep ^output_html_with_http_headers `git grep -l -P "authnotrequired\s*=>\s*0" opac`|grep -v force_no_caching This must be a test somehwere to prevent further regressions. Signed-off-by: Katrin Fischer Signed-off-by: Chris Cormack Signed-off-by: Martin Renvoize (cherry picked from commit 20d3d6788ec814e721d97f348be3749fffe662b6) Signed-off-by: Lucas Gass commit a2a9596c22bb94486483ba182bee4900dde42964 Author: Lucas Gass Date: Mon Apr 29 00:42:01 2019 +0000 Increment version for 18.05.12 release Signed-off-by: Lucas Gass Signed-off-by: Lucas Gass commit ae26ee183bea7d2073e53beda1b4fd71e5b56e39 Author: Koha translators <> Date: Mon Apr 29 11:26:22 2019 -0300 Translation updates for Koha 18.05.12 Signed-off-by: Lucas Gass Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/Auth.pm | 1 + C4/Output.pm | 6 +- Koha.pm | 2 +- installer/data/mysql/updatedatabase.pl | 6 + ...s_18_05_11.html => release_notes_18_05_12.html} | 336 ++++---- misc/release_notes/release_notes_18_05_12.md | 374 +++++++++ misc/translator/po/am-Ethi-marc-MARC21.po | 8 +- misc/translator/po/am-Ethi-marc-NORMARC.po | 2 +- misc/translator/po/am-Ethi-marc-UNIMARC.po | 8 +- misc/translator/po/am-Ethi-opac-bootstrap.po | 549 ++++++------- misc/translator/po/am-Ethi-staff-help.po | 2 +- misc/translator/po/am-Ethi-staff-prog.po | 402 +++++----- misc/translator/po/ar-Arab-marc-MARC21.po | 8 +- misc/translator/po/ar-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ar-Arab-marc-UNIMARC.po | 10 +- misc/translator/po/ar-Arab-opac-bootstrap.po | 556 ++++++------- misc/translator/po/ar-Arab-staff-help.po | 2 +- misc/translator/po/ar-Arab-staff-prog.po | 404 +++++----- misc/translator/po/as-IN-marc-MARC21.po | 8 +- misc/translator/po/as-IN-marc-NORMARC.po | 2 +- misc/translator/po/as-IN-marc-UNIMARC.po | 8 +- misc/translator/po/as-IN-opac-bootstrap.po | 549 ++++++------- misc/translator/po/as-IN-staff-help.po | 2 +- misc/translator/po/as-IN-staff-prog.po | 402 +++++----- misc/translator/po/az-AZ-marc-MARC21.po | 8 +- misc/translator/po/az-AZ-marc-NORMARC.po | 2 +- misc/translator/po/az-AZ-marc-UNIMARC.po | 8 +- misc/translator/po/az-AZ-opac-bootstrap.po | 549 ++++++------- misc/translator/po/az-AZ-staff-help.po | 2 +- misc/translator/po/az-AZ-staff-prog.po | 402 +++++----- misc/translator/po/be-BY-marc-MARC21.po | 8 +- misc/translator/po/be-BY-marc-NORMARC.po | 2 +- misc/translator/po/be-BY-marc-UNIMARC.po | 10 +- misc/translator/po/be-BY-opac-bootstrap.po | 551 ++++++------- misc/translator/po/be-BY-staff-help.po | 2 +- misc/translator/po/be-BY-staff-prog.po | 402 +++++----- misc/translator/po/bg-Cyrl-marc-MARC21.po | 8 +- misc/translator/po/bg-Cyrl-marc-NORMARC.po | 2 +- misc/translator/po/bg-Cyrl-marc-UNIMARC.po | 8 +- misc/translator/po/bg-Cyrl-opac-bootstrap.po | 549 ++++++------- misc/translator/po/bg-Cyrl-staff-help.po | 2 +- misc/translator/po/bg-Cyrl-staff-prog.po | 402 +++++----- misc/translator/po/bn-IN-marc-MARC21.po | 8 +- misc/translator/po/bn-IN-marc-NORMARC.po | 2 +- misc/translator/po/bn-IN-marc-UNIMARC.po | 8 +- misc/translator/po/bn-IN-opac-bootstrap.po | 553 ++++++------- misc/translator/po/bn-IN-staff-help.po | 2 +- misc/translator/po/bn-IN-staff-prog.po | 406 +++++----- misc/translator/po/ca-ES-marc-MARC21.po | 8 +- misc/translator/po/ca-ES-marc-NORMARC.po | 2 +- misc/translator/po/ca-ES-marc-UNIMARC.po | 10 +- misc/translator/po/ca-ES-opac-bootstrap.po | 553 ++++++------- misc/translator/po/ca-ES-staff-help.po | 2 +- misc/translator/po/ca-ES-staff-prog.po | 402 +++++----- misc/translator/po/cs-CZ-marc-MARC21.po | 8 +- misc/translator/po/cs-CZ-marc-NORMARC.po | 2 +- misc/translator/po/cs-CZ-marc-UNIMARC.po | 10 +- misc/translator/po/cs-CZ-opac-bootstrap.po | 555 ++++++------- misc/translator/po/cs-CZ-pref.po | 18 +- misc/translator/po/cs-CZ-staff-help.po | 2 +- misc/translator/po/cs-CZ-staff-prog.po | 412 +++++----- misc/translator/po/cy-GB-marc-MARC21.po | 8 +- misc/translator/po/cy-GB-marc-NORMARC.po | 2 +- misc/translator/po/cy-GB-marc-UNIMARC.po | 8 +- misc/translator/po/cy-GB-opac-bootstrap.po | 549 ++++++------- misc/translator/po/cy-GB-staff-help.po | 2 +- misc/translator/po/cy-GB-staff-prog.po | 402 +++++----- misc/translator/po/da-DK-marc-MARC21.po | 8 +- misc/translator/po/da-DK-marc-NORMARC.po | 2 +- misc/translator/po/da-DK-marc-UNIMARC.po | 10 +- misc/translator/po/da-DK-opac-bootstrap.po | 551 ++++++------- misc/translator/po/da-DK-staff-help.po | 2 +- misc/translator/po/da-DK-staff-prog.po | 402 +++++----- misc/translator/po/de-CH-marc-MARC21.po | 8 +- misc/translator/po/de-CH-marc-NORMARC.po | 2 +- misc/translator/po/de-CH-marc-UNIMARC.po | 10 +- misc/translator/po/de-CH-opac-bootstrap.po | 555 ++++++------- misc/translator/po/de-CH-staff-help.po | 2 +- misc/translator/po/de-CH-staff-prog.po | 404 +++++----- misc/translator/po/de-DE-marc-MARC21.po | 8 +- misc/translator/po/de-DE-marc-NORMARC.po | 2 +- misc/translator/po/de-DE-marc-UNIMARC.po | 14 +- misc/translator/po/de-DE-opac-bootstrap.po | 582 +++++++------- misc/translator/po/de-DE-staff-help.po | 2 +- misc/translator/po/de-DE-staff-prog.po | 470 ++++++----- misc/translator/po/el-GR-marc-MARC21.po | 8 +- misc/translator/po/el-GR-marc-NORMARC.po | 2 +- misc/translator/po/el-GR-marc-UNIMARC.po | 10 +- misc/translator/po/el-GR-opac-bootstrap.po | 554 ++++++------- misc/translator/po/el-GR-staff-help.po | 2 +- misc/translator/po/el-GR-staff-prog.po | 412 +++++----- misc/translator/po/en-GB-marc-MARC21.po | 8 +- misc/translator/po/en-GB-marc-NORMARC.po | 2 +- misc/translator/po/en-GB-marc-UNIMARC.po | 8 +- misc/translator/po/en-GB-opac-bootstrap.po | 551 ++++++------- misc/translator/po/en-GB-staff-help.po | 2 +- misc/translator/po/en-GB-staff-prog.po | 406 +++++----- misc/translator/po/en-NZ-marc-MARC21.po | 8 +- misc/translator/po/en-NZ-marc-NORMARC.po | 2 +- misc/translator/po/en-NZ-marc-UNIMARC.po | 10 +- misc/translator/po/en-NZ-opac-bootstrap.po | 555 ++++++------- misc/translator/po/en-NZ-staff-help.po | 2 +- misc/translator/po/en-NZ-staff-prog.po | 404 +++++----- misc/translator/po/eo-marc-MARC21.po | 8 +- misc/translator/po/eo-marc-NORMARC.po | 2 +- misc/translator/po/eo-marc-UNIMARC.po | 8 +- misc/translator/po/eo-opac-bootstrap.po | 555 ++++++------- misc/translator/po/eo-staff-help.po | 2 +- misc/translator/po/eo-staff-prog.po | 402 +++++----- misc/translator/po/es-ES-marc-MARC21.po | 8 +- misc/translator/po/es-ES-marc-NORMARC.po | 2 +- misc/translator/po/es-ES-marc-UNIMARC.po | 18 +- misc/translator/po/es-ES-opac-bootstrap.po | 708 ++++++++-------- misc/translator/po/es-ES-pref.po | 203 ++++- misc/translator/po/es-ES-staff-help.po | 20 +- misc/translator/po/es-ES-staff-prog.po | 842 +++++++++++--------- misc/translator/po/eu-marc-MARC21.po | 8 +- misc/translator/po/eu-marc-NORMARC.po | 2 +- misc/translator/po/eu-marc-UNIMARC.po | 10 +- misc/translator/po/eu-opac-bootstrap.po | 555 ++++++------- misc/translator/po/eu-staff-help.po | 2 +- misc/translator/po/eu-staff-prog.po | 402 +++++----- misc/translator/po/fa-Arab-marc-MARC21.po | 8 +- misc/translator/po/fa-Arab-marc-NORMARC.po | 2 +- misc/translator/po/fa-Arab-marc-UNIMARC.po | 10 +- misc/translator/po/fa-Arab-opac-bootstrap.po | 549 ++++++------- misc/translator/po/fa-Arab-staff-help.po | 2 +- misc/translator/po/fa-Arab-staff-prog.po | 402 +++++----- misc/translator/po/fi-FI-marc-MARC21.po | 8 +- misc/translator/po/fi-FI-marc-NORMARC.po | 2 +- misc/translator/po/fi-FI-marc-UNIMARC.po | 10 +- misc/translator/po/fi-FI-opac-bootstrap.po | 553 ++++++------- misc/translator/po/fi-FI-staff-help.po | 2 +- misc/translator/po/fi-FI-staff-prog.po | 404 +++++----- misc/translator/po/fo-FO-marc-MARC21.po | 8 +- misc/translator/po/fo-FO-marc-NORMARC.po | 2 +- misc/translator/po/fo-FO-marc-UNIMARC.po | 8 +- misc/translator/po/fo-FO-opac-bootstrap.po | 549 ++++++------- misc/translator/po/fo-FO-staff-help.po | 2 +- misc/translator/po/fo-FO-staff-prog.po | 402 +++++----- misc/translator/po/fr-CA-marc-MARC21.po | 8 +- misc/translator/po/fr-CA-marc-NORMARC.po | 2 +- misc/translator/po/fr-CA-marc-UNIMARC.po | 10 +- misc/translator/po/fr-CA-opac-bootstrap.po | 555 ++++++------- misc/translator/po/fr-CA-staff-help.po | 2 +- misc/translator/po/fr-CA-staff-prog.po | 493 ++++++------ misc/translator/po/fr-FR-marc-MARC21.po | 8 +- misc/translator/po/fr-FR-marc-NORMARC.po | 2 +- misc/translator/po/fr-FR-marc-UNIMARC.po | 10 +- misc/translator/po/fr-FR-opac-bootstrap.po | 555 ++++++------- misc/translator/po/fr-FR-pref.po | 25 +- misc/translator/po/fr-FR-staff-help.po | 2 +- misc/translator/po/fr-FR-staff-prog.po | 419 +++++----- misc/translator/po/ga-marc-MARC21.po | 8 +- misc/translator/po/ga-marc-NORMARC.po | 2 +- misc/translator/po/ga-marc-UNIMARC.po | 8 +- misc/translator/po/ga-opac-bootstrap.po | 549 ++++++------- misc/translator/po/ga-staff-help.po | 2 +- misc/translator/po/ga-staff-prog.po | 402 +++++----- misc/translator/po/gd-marc-MARC21.po | 8 +- misc/translator/po/gd-marc-NORMARC.po | 2 +- misc/translator/po/gd-marc-UNIMARC.po | 8 +- misc/translator/po/gd-opac-bootstrap.po | 549 ++++++------- misc/translator/po/gd-staff-help.po | 2 +- misc/translator/po/gd-staff-prog.po | 402 +++++----- misc/translator/po/gl-marc-MARC21.po | 8 +- misc/translator/po/gl-marc-NORMARC.po | 2 +- misc/translator/po/gl-marc-UNIMARC.po | 8 +- misc/translator/po/gl-opac-bootstrap.po | 549 ++++++------- misc/translator/po/gl-staff-help.po | 2 +- misc/translator/po/gl-staff-prog.po | 402 +++++----- misc/translator/po/he-Hebr-marc-MARC21.po | 8 +- misc/translator/po/he-Hebr-marc-NORMARC.po | 2 +- misc/translator/po/he-Hebr-marc-UNIMARC.po | 8 +- misc/translator/po/he-Hebr-opac-bootstrap.po | 549 ++++++------- misc/translator/po/he-Hebr-staff-help.po | 2 +- misc/translator/po/he-Hebr-staff-prog.po | 402 +++++----- misc/translator/po/hi-marc-MARC21.po | 8 +- misc/translator/po/hi-marc-NORMARC.po | 2 +- misc/translator/po/hi-marc-UNIMARC.po | 14 +- misc/translator/po/hi-opac-bootstrap.po | 579 +++++++------- misc/translator/po/hi-staff-help.po | 2 +- misc/translator/po/hi-staff-prog.po | 404 +++++----- misc/translator/po/hr-HR-marc-MARC21.po | 8 +- misc/translator/po/hr-HR-marc-NORMARC.po | 2 +- misc/translator/po/hr-HR-marc-UNIMARC.po | 8 +- misc/translator/po/hr-HR-opac-bootstrap.po | 553 ++++++------- misc/translator/po/hr-HR-staff-help.po | 2 +- misc/translator/po/hr-HR-staff-prog.po | 404 +++++----- misc/translator/po/hu-HU-marc-MARC21.po | 8 +- misc/translator/po/hu-HU-marc-NORMARC.po | 2 +- misc/translator/po/hu-HU-marc-UNIMARC.po | 8 +- misc/translator/po/hu-HU-opac-bootstrap.po | 554 ++++++------- misc/translator/po/hu-HU-staff-help.po | 2 +- misc/translator/po/hu-HU-staff-prog.po | 402 +++++----- misc/translator/po/hy-Armn-marc-MARC21.po | 8 +- misc/translator/po/hy-Armn-marc-NORMARC.po | 2 +- misc/translator/po/hy-Armn-marc-UNIMARC.po | 14 +- misc/translator/po/hy-Armn-opac-bootstrap.po | 582 +++++++------- misc/translator/po/hy-Armn-staff-help.po | 2 +- misc/translator/po/hy-Armn-staff-prog.po | 408 +++++----- misc/translator/po/ia-marc-MARC21.po | 8 +- misc/translator/po/ia-marc-NORMARC.po | 2 +- misc/translator/po/ia-marc-UNIMARC.po | 8 +- misc/translator/po/ia-opac-bootstrap.po | 549 ++++++------- misc/translator/po/ia-staff-help.po | 2 +- misc/translator/po/ia-staff-prog.po | 402 +++++----- misc/translator/po/id-ID-marc-MARC21.po | 8 +- misc/translator/po/id-ID-marc-NORMARC.po | 2 +- misc/translator/po/id-ID-marc-UNIMARC.po | 10 +- misc/translator/po/id-ID-opac-bootstrap.po | 549 ++++++------- misc/translator/po/id-ID-staff-help.po | 2 +- misc/translator/po/id-ID-staff-prog.po | 406 +++++----- misc/translator/po/iq-CA-marc-MARC21.po | 8 +- misc/translator/po/iq-CA-marc-NORMARC.po | 2 +- misc/translator/po/iq-CA-marc-UNIMARC.po | 8 +- misc/translator/po/iq-CA-opac-bootstrap.po | 549 ++++++------- misc/translator/po/iq-CA-staff-help.po | 2 +- misc/translator/po/iq-CA-staff-prog.po | 402 +++++----- misc/translator/po/is-IS-marc-MARC21.po | 8 +- misc/translator/po/is-IS-marc-NORMARC.po | 2 +- misc/translator/po/is-IS-marc-UNIMARC.po | 8 +- misc/translator/po/is-IS-opac-bootstrap.po | 549 ++++++------- misc/translator/po/is-IS-staff-help.po | 2 +- misc/translator/po/is-IS-staff-prog.po | 402 +++++----- misc/translator/po/it-IT-marc-MARC21.po | 8 +- misc/translator/po/it-IT-marc-NORMARC.po | 2 +- misc/translator/po/it-IT-marc-UNIMARC.po | 10 +- misc/translator/po/it-IT-opac-bootstrap.po | 555 ++++++------- misc/translator/po/it-IT-staff-help.po | 2 +- misc/translator/po/it-IT-staff-prog.po | 404 +++++----- misc/translator/po/iu-CA-marc-MARC21.po | 8 +- misc/translator/po/iu-CA-marc-NORMARC.po | 2 +- misc/translator/po/iu-CA-marc-UNIMARC.po | 8 +- misc/translator/po/iu-CA-opac-bootstrap.po | 549 ++++++------- misc/translator/po/iu-CA-staff-help.po | 2 +- misc/translator/po/iu-CA-staff-prog.po | 402 +++++----- misc/translator/po/ja-Jpan-JP-marc-MARC21.po | 8 +- misc/translator/po/ja-Jpan-JP-marc-NORMARC.po | 2 +- misc/translator/po/ja-Jpan-JP-marc-UNIMARC.po | 8 +- misc/translator/po/ja-Jpan-JP-opac-bootstrap.po | 549 ++++++------- misc/translator/po/ja-Jpan-JP-staff-help.po | 2 +- misc/translator/po/ja-Jpan-JP-staff-prog.po | 402 +++++----- misc/translator/po/ka-marc-MARC21.po | 8 +- misc/translator/po/ka-marc-NORMARC.po | 2 +- misc/translator/po/ka-marc-UNIMARC.po | 8 +- misc/translator/po/ka-opac-bootstrap.po | 549 ++++++------- misc/translator/po/ka-staff-help.po | 2 +- misc/translator/po/ka-staff-prog.po | 402 +++++----- misc/translator/po/km-KH-marc-MARC21.po | 8 +- misc/translator/po/km-KH-marc-NORMARC.po | 2 +- misc/translator/po/km-KH-marc-UNIMARC.po | 8 +- misc/translator/po/km-KH-opac-bootstrap.po | 549 ++++++------- misc/translator/po/km-KH-staff-help.po | 2 +- misc/translator/po/km-KH-staff-prog.po | 402 +++++----- misc/translator/po/kn-Knda-marc-MARC21.po | 8 +- misc/translator/po/kn-Knda-marc-NORMARC.po | 2 +- misc/translator/po/kn-Knda-marc-UNIMARC.po | 8 +- misc/translator/po/kn-Knda-opac-bootstrap.po | 549 ++++++------- misc/translator/po/kn-Knda-staff-help.po | 2 +- misc/translator/po/kn-Knda-staff-prog.po | 402 +++++----- misc/translator/po/ko-Kore-KP-marc-MARC21.po | 8 +- misc/translator/po/ko-Kore-KP-marc-NORMARC.po | 2 +- misc/translator/po/ko-Kore-KP-marc-UNIMARC.po | 8 +- misc/translator/po/ko-Kore-KP-opac-bootstrap.po | 551 ++++++------- misc/translator/po/ko-Kore-KP-staff-help.po | 2 +- misc/translator/po/ko-Kore-KP-staff-prog.po | 404 +++++----- misc/translator/po/ku-Arab-marc-MARC21.po | 8 +- misc/translator/po/ku-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ku-Arab-marc-UNIMARC.po | 10 +- misc/translator/po/ku-Arab-opac-bootstrap.po | 550 ++++++------- misc/translator/po/ku-Arab-staff-help.po | 2 +- misc/translator/po/ku-Arab-staff-prog.po | 402 +++++----- misc/translator/po/lo-Laoo-marc-MARC21.po | 8 +- misc/translator/po/lo-Laoo-marc-NORMARC.po | 2 +- misc/translator/po/lo-Laoo-marc-UNIMARC.po | 8 +- misc/translator/po/lo-Laoo-opac-bootstrap.po | 549 ++++++------- misc/translator/po/lo-Laoo-staff-help.po | 2 +- misc/translator/po/lo-Laoo-staff-prog.po | 402 +++++----- misc/translator/po/lv-marc-MARC21.po | 8 +- misc/translator/po/lv-marc-NORMARC.po | 2 +- misc/translator/po/lv-marc-UNIMARC.po | 8 +- misc/translator/po/lv-opac-bootstrap.po | 549 ++++++------- misc/translator/po/lv-staff-help.po | 2 +- misc/translator/po/lv-staff-prog.po | 402 +++++----- misc/translator/po/mi-NZ-marc-MARC21.po | 8 +- misc/translator/po/mi-NZ-marc-NORMARC.po | 2 +- misc/translator/po/mi-NZ-marc-UNIMARC.po | 8 +- misc/translator/po/mi-NZ-opac-bootstrap.po | 553 ++++++------- misc/translator/po/mi-NZ-staff-help.po | 2 +- misc/translator/po/mi-NZ-staff-prog.po | 402 +++++----- misc/translator/po/ml-marc-MARC21.po | 8 +- misc/translator/po/ml-marc-NORMARC.po | 2 +- misc/translator/po/ml-marc-UNIMARC.po | 8 +- misc/translator/po/ml-opac-bootstrap.po | 549 ++++++------- misc/translator/po/ml-staff-help.po | 2 +- misc/translator/po/ml-staff-prog.po | 402 +++++----- misc/translator/po/mon-marc-MARC21.po | 8 +- misc/translator/po/mon-marc-NORMARC.po | 2 +- misc/translator/po/mon-marc-UNIMARC.po | 8 +- misc/translator/po/mon-opac-bootstrap.po | 549 ++++++------- misc/translator/po/mon-staff-help.po | 2 +- misc/translator/po/mon-staff-prog.po | 402 +++++----- misc/translator/po/mr-marc-MARC21.po | 8 +- misc/translator/po/mr-marc-NORMARC.po | 2 +- misc/translator/po/mr-marc-UNIMARC.po | 8 +- misc/translator/po/mr-opac-bootstrap.po | 549 ++++++------- misc/translator/po/mr-staff-help.po | 2 +- misc/translator/po/mr-staff-prog.po | 402 +++++----- misc/translator/po/ms-MY-marc-MARC21.po | 8 +- misc/translator/po/ms-MY-marc-NORMARC.po | 2 +- misc/translator/po/ms-MY-marc-UNIMARC.po | 10 +- misc/translator/po/ms-MY-opac-bootstrap.po | 549 ++++++------- misc/translator/po/ms-MY-staff-help.po | 2 +- misc/translator/po/ms-MY-staff-prog.po | 410 +++++----- misc/translator/po/my-marc-MARC21.po | 8 +- misc/translator/po/my-marc-NORMARC.po | 2 +- misc/translator/po/my-marc-UNIMARC.po | 8 +- misc/translator/po/my-opac-bootstrap.po | 549 ++++++------- misc/translator/po/my-staff-help.po | 2 +- misc/translator/po/my-staff-prog.po | 402 +++++----- misc/translator/po/nb-NO-marc-MARC21.po | 18 +- misc/translator/po/nb-NO-marc-NORMARC.po | 2 +- misc/translator/po/nb-NO-marc-UNIMARC.po | 10 +- misc/translator/po/nb-NO-opac-bootstrap.po | 564 ++++++------- misc/translator/po/nb-NO-staff-help.po | 2 +- misc/translator/po/nb-NO-staff-prog.po | 404 +++++----- misc/translator/po/ne-NE-marc-MARC21.po | 8 +- misc/translator/po/ne-NE-marc-NORMARC.po | 2 +- misc/translator/po/ne-NE-marc-UNIMARC.po | 8 +- misc/translator/po/ne-NE-opac-bootstrap.po | 549 ++++++------- misc/translator/po/ne-NE-staff-help.po | 2 +- misc/translator/po/ne-NE-staff-prog.po | 402 +++++----- misc/translator/po/nl-BE-marc-MARC21.po | 8 +- misc/translator/po/nl-BE-marc-NORMARC.po | 2 +- misc/translator/po/nl-BE-marc-UNIMARC.po | 10 +- misc/translator/po/nl-BE-opac-bootstrap.po | 552 ++++++------- misc/translator/po/nl-BE-staff-help.po | 2 +- misc/translator/po/nl-BE-staff-prog.po | 402 +++++----- misc/translator/po/nl-NL-marc-MARC21.po | 8 +- misc/translator/po/nl-NL-marc-NORMARC.po | 2 +- misc/translator/po/nl-NL-marc-UNIMARC.po | 10 +- misc/translator/po/nl-NL-opac-bootstrap.po | 555 ++++++------- misc/translator/po/nl-NL-staff-help.po | 2 +- misc/translator/po/nl-NL-staff-prog.po | 406 +++++----- misc/translator/po/nn-NO-marc-MARC21.po | 8 +- misc/translator/po/nn-NO-marc-NORMARC.po | 2 +- misc/translator/po/nn-NO-marc-UNIMARC.po | 8 +- misc/translator/po/nn-NO-opac-bootstrap.po | 549 ++++++------- misc/translator/po/nn-NO-staff-help.po | 2 +- misc/translator/po/nn-NO-staff-prog.po | 402 +++++----- misc/translator/po/oc-marc-MARC21.po | 8 +- misc/translator/po/oc-marc-NORMARC.po | 2 +- misc/translator/po/oc-marc-UNIMARC.po | 10 +- misc/translator/po/oc-opac-bootstrap.po | 549 ++++++------- misc/translator/po/oc-staff-help.po | 2 +- misc/translator/po/oc-staff-prog.po | 404 +++++----- misc/translator/po/pbr-marc-MARC21.po | 8 +- misc/translator/po/pbr-marc-NORMARC.po | 2 +- misc/translator/po/pbr-marc-UNIMARC.po | 8 +- misc/translator/po/pbr-opac-bootstrap.po | 549 ++++++------- misc/translator/po/pbr-staff-help.po | 2 +- misc/translator/po/pbr-staff-prog.po | 402 +++++----- misc/translator/po/pl-PL-marc-MARC21.po | 8 +- misc/translator/po/pl-PL-marc-NORMARC.po | 2 +- misc/translator/po/pl-PL-marc-UNIMARC.po | 10 +- misc/translator/po/pl-PL-opac-bootstrap.po | 553 ++++++------- misc/translator/po/pl-PL-staff-help.po | 2 +- misc/translator/po/pl-PL-staff-prog.po | 414 +++++----- misc/translator/po/prs-marc-MARC21.po | 8 +- misc/translator/po/prs-marc-NORMARC.po | 2 +- misc/translator/po/prs-marc-UNIMARC.po | 8 +- misc/translator/po/prs-opac-bootstrap.po | 549 ++++++------- misc/translator/po/prs-staff-help.po | 2 +- misc/translator/po/prs-staff-prog.po | 402 +++++----- misc/translator/po/pt-BR-marc-MARC21.po | 46 +- misc/translator/po/pt-BR-marc-NORMARC.po | 2 +- misc/translator/po/pt-BR-marc-UNIMARC.po | 10 +- misc/translator/po/pt-BR-opac-bootstrap.po | 558 ++++++------- misc/translator/po/pt-BR-pref.po | 11 +- misc/translator/po/pt-BR-staff-help.po | 14 +- misc/translator/po/pt-BR-staff-prog.po | 413 +++++----- misc/translator/po/pt-PT-marc-MARC21.po | 8 +- misc/translator/po/pt-PT-marc-NORMARC.po | 2 +- misc/translator/po/pt-PT-marc-UNIMARC.po | 14 +- misc/translator/po/pt-PT-opac-bootstrap.po | 583 +++++++------- misc/translator/po/pt-PT-staff-help.po | 2 +- misc/translator/po/pt-PT-staff-prog.po | 404 +++++----- misc/translator/po/ro-RO-marc-MARC21.po | 8 +- misc/translator/po/ro-RO-marc-NORMARC.po | 2 +- misc/translator/po/ro-RO-marc-UNIMARC.po | 8 +- misc/translator/po/ro-RO-opac-bootstrap.po | 549 ++++++------- misc/translator/po/ro-RO-staff-help.po | 2 +- misc/translator/po/ro-RO-staff-prog.po | 402 +++++----- misc/translator/po/ru-RU-marc-MARC21.po | 8 +- misc/translator/po/ru-RU-marc-NORMARC.po | 2 +- misc/translator/po/ru-RU-marc-UNIMARC.po | 10 +- misc/translator/po/ru-RU-opac-bootstrap.po | 553 ++++++------- misc/translator/po/ru-RU-staff-help.po | 2 +- misc/translator/po/ru-RU-staff-prog.po | 402 +++++----- misc/translator/po/rw-RW-marc-MARC21.po | 8 +- misc/translator/po/rw-RW-marc-NORMARC.po | 2 +- misc/translator/po/rw-RW-marc-UNIMARC.po | 8 +- misc/translator/po/rw-RW-opac-bootstrap.po | 549 ++++++------- misc/translator/po/rw-RW-staff-help.po | 2 +- misc/translator/po/rw-RW-staff-prog.po | 402 +++++----- misc/translator/po/sd-PK-marc-MARC21.po | 8 +- misc/translator/po/sd-PK-marc-NORMARC.po | 2 +- misc/translator/po/sd-PK-marc-UNIMARC.po | 8 +- misc/translator/po/sd-PK-opac-bootstrap.po | 549 ++++++------- misc/translator/po/sd-PK-staff-help.po | 2 +- misc/translator/po/sd-PK-staff-prog.po | 402 +++++----- misc/translator/po/sk-SK-marc-MARC21.po | 8 +- misc/translator/po/sk-SK-marc-NORMARC.po | 2 +- misc/translator/po/sk-SK-marc-UNIMARC.po | 14 +- misc/translator/po/sk-SK-opac-bootstrap.po | 612 +++++++------- misc/translator/po/sk-SK-staff-help.po | 2 +- misc/translator/po/sk-SK-staff-prog.po | 478 ++++++----- misc/translator/po/sl-SI-marc-MARC21.po | 8 +- misc/translator/po/sl-SI-marc-NORMARC.po | 2 +- misc/translator/po/sl-SI-marc-UNIMARC.po | 8 +- misc/translator/po/sl-SI-opac-bootstrap.po | 549 ++++++------- misc/translator/po/sl-SI-staff-help.po | 2 +- misc/translator/po/sl-SI-staff-prog.po | 402 +++++----- misc/translator/po/sq-AL-marc-MARC21.po | 8 +- misc/translator/po/sq-AL-marc-NORMARC.po | 2 +- misc/translator/po/sq-AL-marc-UNIMARC.po | 8 +- misc/translator/po/sq-AL-opac-bootstrap.po | 553 ++++++------- misc/translator/po/sq-AL-staff-help.po | 2 +- misc/translator/po/sq-AL-staff-prog.po | 402 +++++----- misc/translator/po/sr-Cyrl-marc-MARC21.po | 8 +- misc/translator/po/sr-Cyrl-marc-NORMARC.po | 2 +- misc/translator/po/sr-Cyrl-marc-UNIMARC.po | 8 +- misc/translator/po/sr-Cyrl-opac-bootstrap.po | 549 ++++++------- misc/translator/po/sr-Cyrl-staff-help.po | 2 +- misc/translator/po/sr-Cyrl-staff-prog.po | 402 +++++----- misc/translator/po/sv-SE-marc-MARC21.po | 8 +- misc/translator/po/sv-SE-marc-NORMARC.po | 2 +- misc/translator/po/sv-SE-marc-UNIMARC.po | 10 +- misc/translator/po/sv-SE-opac-bootstrap.po | 603 +++++++------- misc/translator/po/sv-SE-staff-help.po | 2 +- misc/translator/po/sv-SE-staff-prog.po | 477 +++++------ misc/translator/po/sw-KE-marc-MARC21.po | 8 +- misc/translator/po/sw-KE-marc-NORMARC.po | 2 +- misc/translator/po/sw-KE-marc-UNIMARC.po | 8 +- misc/translator/po/sw-KE-opac-bootstrap.po | 549 ++++++------- misc/translator/po/sw-KE-staff-help.po | 2 +- misc/translator/po/sw-KE-staff-prog.po | 402 +++++----- misc/translator/po/ta-LK-marc-MARC21.po | 8 +- misc/translator/po/ta-LK-marc-NORMARC.po | 2 +- misc/translator/po/ta-LK-marc-UNIMARC.po | 8 +- misc/translator/po/ta-LK-opac-bootstrap.po | 549 ++++++------- misc/translator/po/ta-LK-staff-help.po | 2 +- misc/translator/po/ta-LK-staff-prog.po | 402 +++++----- misc/translator/po/ta-marc-MARC21.po | 8 +- misc/translator/po/ta-marc-NORMARC.po | 2 +- misc/translator/po/ta-marc-UNIMARC.po | 8 +- misc/translator/po/ta-opac-bootstrap.po | 549 ++++++------- misc/translator/po/ta-staff-help.po | 2 +- misc/translator/po/ta-staff-prog.po | 402 +++++----- misc/translator/po/tet-marc-MARC21.po | 8 +- misc/translator/po/tet-marc-NORMARC.po | 2 +- misc/translator/po/tet-marc-UNIMARC.po | 8 +- misc/translator/po/tet-opac-bootstrap.po | 553 ++++++------- misc/translator/po/tet-staff-help.po | 2 +- misc/translator/po/tet-staff-prog.po | 404 +++++----- misc/translator/po/th-TH-marc-MARC21.po | 8 +- misc/translator/po/th-TH-marc-NORMARC.po | 2 +- misc/translator/po/th-TH-marc-UNIMARC.po | 8 +- misc/translator/po/th-TH-opac-bootstrap.po | 550 ++++++------- misc/translator/po/th-TH-staff-help.po | 2 +- misc/translator/po/th-TH-staff-prog.po | 406 +++++----- misc/translator/po/tl-PH-marc-MARC21.po | 8 +- misc/translator/po/tl-PH-marc-NORMARC.po | 2 +- misc/translator/po/tl-PH-marc-UNIMARC.po | 8 +- misc/translator/po/tl-PH-opac-bootstrap.po | 549 ++++++------- misc/translator/po/tl-PH-staff-help.po | 2 +- misc/translator/po/tl-PH-staff-prog.po | 402 +++++----- misc/translator/po/tr-TR-marc-MARC21.po | 8 +- misc/translator/po/tr-TR-marc-NORMARC.po | 2 +- misc/translator/po/tr-TR-marc-UNIMARC.po | 10 +- misc/translator/po/tr-TR-opac-bootstrap.po | 555 ++++++------- misc/translator/po/tr-TR-staff-help.po | 2 +- misc/translator/po/tr-TR-staff-prog.po | 404 +++++----- misc/translator/po/tvl-marc-MARC21.po | 8 +- misc/translator/po/tvl-marc-NORMARC.po | 2 +- misc/translator/po/tvl-marc-UNIMARC.po | 8 +- misc/translator/po/tvl-opac-bootstrap.po | 549 ++++++------- misc/translator/po/tvl-staff-help.po | 2 +- misc/translator/po/tvl-staff-prog.po | 402 +++++----- misc/translator/po/uk-UA-marc-MARC21.po | 9 +- misc/translator/po/uk-UA-marc-NORMARC.po | 2 +- misc/translator/po/uk-UA-marc-UNIMARC.po | 10 +- misc/translator/po/uk-UA-opac-bootstrap.po | 556 ++++++------- misc/translator/po/uk-UA-staff-help.po | 2 +- misc/translator/po/uk-UA-staff-prog.po | 404 +++++----- misc/translator/po/ur-Arab-marc-MARC21.po | 8 +- misc/translator/po/ur-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ur-Arab-marc-UNIMARC.po | 8 +- misc/translator/po/ur-Arab-opac-bootstrap.po | 549 ++++++------- misc/translator/po/ur-Arab-staff-help.po | 2 +- misc/translator/po/ur-Arab-staff-prog.po | 402 +++++----- misc/translator/po/vi-VN-marc-MARC21.po | 8 +- misc/translator/po/vi-VN-marc-NORMARC.po | 2 +- misc/translator/po/vi-VN-marc-UNIMARC.po | 10 +- misc/translator/po/vi-VN-opac-bootstrap.po | 551 ++++++------- misc/translator/po/vi-VN-staff-help.po | 2 +- misc/translator/po/vi-VN-staff-prog.po | 404 +++++----- misc/translator/po/zh-Hans-CN-marc-MARC21.po | 8 +- misc/translator/po/zh-Hans-CN-marc-NORMARC.po | 2 +- misc/translator/po/zh-Hans-CN-marc-UNIMARC.po | 10 +- misc/translator/po/zh-Hans-CN-opac-bootstrap.po | 549 ++++++------- misc/translator/po/zh-Hans-CN-staff-help.po | 2 +- misc/translator/po/zh-Hans-CN-staff-prog.po | 404 +++++----- misc/translator/po/zh-Hant-TW-marc-MARC21.po | 8 +- misc/translator/po/zh-Hant-TW-marc-NORMARC.po | 2 +- misc/translator/po/zh-Hant-TW-marc-UNIMARC.po | 10 +- misc/translator/po/zh-Hant-TW-opac-bootstrap.po | 551 ++++++------- misc/translator/po/zh-Hant-TW-staff-help.po | 2 +- misc/translator/po/zh-Hant-TW-staff-prog.po | 408 +++++----- opac/clubs/clubs-tab.pl | 2 +- opac/clubs/enroll.pl | 2 +- opac/opac-account-pay.pl | 2 +- opac/opac-addbybiblionumber.pl | 2 +- opac/opac-alert-subscribe.pl | 2 +- opac/opac-illrequests.pl | 2 +- opac/opac-request-article.pl | 2 +- opac/opac-reserve.pl | 15 +- opac/opac-sendbasket.pl | 4 +- opac/opac-sendshelf.pl | 6 +- opac/opac-shareshelf.pl | 3 +- opac/opac-shelves.pl | 1 + opac/opac-suggestions.pl | 2 +- opac/svc/auth/googleopenidconnect | 2 +- t/db_dependent/Auth.t | 26 +- t/db_dependent/selenium/regressions.t | 51 +- t/lib/Selenium.pm | 36 +- virtualshelves/shelves.pl | 1 + 538 files changed, 44160 insertions(+), 41146 deletions(-) copy misc/release_notes/{release_notes_18_05_11.html => release_notes_18_05_12.html} (54%) create mode 100644 misc/release_notes/release_notes_18_05_12.md hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 8 10:14:30 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 08 May 2019 08:14:30 +0000 Subject: [koha-commits] main Koha release repository annotated tag v17.11.18 created. v17.11.18 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The annotated tag, v17.11.18 has been created at a376f7069414442af75f1ca092026d0af321f991 (tag) tagging 7993fa60eb1eabc9f8b3cfacea2ff96b1edba9b3 (commit) replaces v17.11.17 tagged by Fridolin Somers on Tue Apr 30 16:23:43 2019 +0200 - Log ----------------------------------------------------------------- Koha release 17.11.18 -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEuXlk3O256QfzYP0rK8k2QoBkBm4FAlzIWm8ACgkQK8k2QoBk Bm4qswf/RAr3EAk1xTpNztYrvZo+c7rQwcwPynhgnjlQv6NvIJcvOPpUcP20PcoY TIYIqY2yVC+Ju2WCKw3vTBVa3mRghHsCO/YzQta/5V6GfqxfpDsytNdKTyr+3HHL HnDxziPYbSqtZtuqXQHZc8dFN+cYgSWxZOu5YzZGaugiv1RuD5ow4vns3uV2vBmQ maMpSmzChKCR4+RHLSeOLFbCJ0I07CSdUePkGVJrFZzG4Py1ncaa0H8gBqdLWkXp sX54cYK/O3DzAxgpyaUaS0X7xAFsGRGPmhA9Z1bUyOm68gE0AZ0sZwcAeI5BNXpI WCygm46LbkX0t8A62vQWRcFgGyN4Ww== =iBsY -----END PGP SIGNATURE----- Fridolin Somers (6): Bug 21832: Restore is_expired in ILS-DI GetPatronInfo service Bug 21832: add unit test Bug 21832: add is_expired to ILS-DI example Merge remote-tracking branch 'translate/17.11.18-translate-20190430' into 17.11.x Increment version for 17.11.18 release Update release notes for 17.11.18 release Hayley Mapley (1): Bug 19497: Removed title (tooltip) from Edit button in items_search_fields.tt Jonathan Druart (3): Bug 22542: Force back button to display personal data Bug 22478: Prevent XSS vulnerabilities when pagination appears Bug 22068: Prevent patrons to cancel article request they did not create Julian Maurice (2): Bug 21049: Fix value of material select for Rancor 007 widget Bug 21049: Set 007/00 when selecting material type (Rancor) Koha translators (1): Translation updates for Koha 17.11.18 Lyon3 Team (1): Bug 22652: Editing Course reserves is broken Marcel de Rooy (1): Bug 22478: (QA follow-up) Handle category in opac-shelves like a boolean Tomas Cohen Arazi (1): Bug 22068: (QA follow-up) Return meaningful error codes ----------------------------------------------------------------------- hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 8 10:18:40 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 08 May 2019 08:18:40 +0000 Subject: [koha-commits] main Koha release repository annotated tag v18.05.12 created. v18.05.12 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The annotated tag, v18.05.12 has been created at 8e0fd212916b906c9efcc1debc4c0b779630f14c (tag) tagging bb30e8ee83b468cd82831b29a09d335efff4ad80 (commit) replaces v18.05.11 tagged by Martin Renvoize on Wed May 8 08:59:26 2019 +0100 - Log ----------------------------------------------------------------- Koha release 18.05.12 -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE8g0J8pGJSlfC6TBmQitGkTBEGg8FAlzSjF4ACgkQQitGkTBE Gg+nIw//WV+iyPwXs3P1V1g1HBMTThhl6Znd4AdA5FWqOv4LXPNjUUtd3IlJIAFi ALHUS7FMMpZWfBd+xo/YZNWmlOQH0PsVUG2U8V5VUxKEDQ5VwERwu1eC54c3G7m/ 1ME9qDK1WOxBxLOnpJaEQc+vhgt4Rf1ZnC7xqoQLS0xSNJGd2WQYjY+mEaYKX1++ lgN+3f8zB8Fkw2PhyD/N09FPv3q5YL0z8pgZPyMkaFrOML9NeIFuxCLnpQ0AeQWw qG6d8+1fGfViXmzkr6cDwuAVCGV9Lsydq4Ih4SWiOO/c6AseZY6gpn4AISnWHtJc ZmsjQX27g1FqrytsfCUO39+11yUN8G5gvf2a6VcbwThUgV3aKqs3uQgVuDjkNM+8 m+jd+83qhwE9CDt4kE9wXV041MkPRA6QUKoyf/YumaxXpshA8Ivz9d/cTKVNVrmS i4iHVe5ceodZoDfuYUuW1Inar6MuN2kxtKFeWfkRc/D6MaCwa+cr6Gj3R7y30iRa mTM2EnATLKlCBfx3DYob4VHuzO65cjvAX+MEq6e6vT/NBzXdNknN1j7gyqVlRZj2 XXJa1ynhLaZuTRzHJwlhVYIcsvzYkajYXk4MLJPti0NU60pM2PFqGi2Qbhsdqqg2 gKXuvMXLWuW53a1BzStxUwwCV58D6uuU8K+RW3RsDv5f8RstUf4= =NXnf -----END PGP SIGNATURE----- Bj?rn Nyl?n (1): Bug 10345: Increment copy number when adding multiple copies. Blou (1): Bug 21130: (Follow up OPAC Results) Prevent HTML class from being translated Christopher Brannon (4): Bug 21346: Streamline logic in holds and transfers Bug 21346: Remove double dialog Bug 21346: Convert dialogs to modals. Bug 21346: Remove inline onclicks per comment 42 Colin Campbell (1): Bug 22611: Correction for call to get create_item in EDI.pm David Bourgault (1): Bug 21130: Prevent HTML class from being translated Ere Maijala (1): Bug 19670: Change Collation of marc_field to allow mixed case mappings Fridolin Somers (5): Bug 20823: UNIMARC XSLT add subfield t for subjects Bug 21832: Restore is_expired in ILS-DI GetPatronInfo service Bug 21832: add unit test Bug 21832: add is_expired to ILS-DI example Bug 22620: OPAC description for CCODE in opac-reserve.tt Hayley Mapley (5): Bug 13763: Added check for filter syspref in renew.pl Bug 12441: Search.pl conditional checks and displays using same syspref Bug 21003: Removed warning and changed wording on add_items-step2.tt Bug 21003: Made Edit keywords more consistent in add_items-step2.tt Bug 19497: Removed title (tooltip) from Edit button in items_search_fields.tt Jonathan Druart (4): Bug 22068: Prevent patrons to cancel article request they did not create Bug 22542: Force back button to display personal data Bug 22478: Prevent XSS vulnerabilities when pagination appears Bug 22478: Add tests Josef Moravec (2): Bug 13763: (follow-up) Strip leading whitespace characters from input barcode Bug 22607: Change default value in issues.renewals to '0'. Julian Maurice (2): Bug 21049: Fix value of material select for Rancor 007 widget Bug 21049: Set 007/00 when selecting material type (Rancor) Katrin Fischer (6): Bug 13735: Update PrepareItemrecordDisplay to use maxlength Bug 22075: Fix encoding problem with RIS export in OPAC Bug 22624: Show OPAC description for authorised values in OPAC Bug 21659: Fix links to basket groups from order receive page Bug 21659: Change link to basket group edit page Bug 22478: Fix POD Koha translators (1): Translation updates for Koha 18.05.12 Lucas Gass (6): Bug 22620: RMaint Follow-up reverting bad commit Bug 22607: DBRev 18.05.11.001 Bug 19670: DBRev 18.05.11.002 Bug 19670: (RMaint follow-up) Increment version for 18.05.12 release Update release notes for 18.05.12 release Lyon3 Team (1): Bug 22652: Editing Course reserves is broken Marcel de Rooy (1): Bug 22478: (QA follow-up) Handle category in opac-shelves like a boolean Martin Renvoize (5): Bug 20782: Fix link from edifactmessages to invoices Bug 22478: (QA follow-up) Make test consistent with variable name Bug 22478: (QA follow-up) Update tests to check for any script tags Bug 22478: (RMaint follow-up) source t::lib::Mocks Update release notes with security bugs Maryse Simard (1): Bug 21263: Pickup library not set correctly when using Default holds policy Nick Clemens (3): Bug 20937: Truncate items for print notices when user has an email Bug 22692: Unit tests Bug 22692: Check for patron using cardnumber and userid Owen Leonard (8): Bug 22561: Forgotten password requirements hint doesn't list all rules for new passwords Bug 22560: Forgotten password "token expired" page still shows boxes to reset password Bug 22536: Display problem in Holds to Pull report Bug 22575: Item type administration uses invalid error class for dialog Bug 21013: Missing itemtype for checkut makes patron summary print explode Bug 14358: Changing the module refreshes the page and resets library choice Bug 13629: SingleBranchMode removes both library and availability search from advanced search Bug 22444: currencies_manage permission doesn't provide link to manage currencies when selected alone Tomas Cohen Arazi (4): Bug 17746: Make koha-reset-passwd user set_password.pl Bug 17746: Add misc/admin/set_password.pl script Bug 17746: (QA follow-up) Make set_password.pl generate a password if required Bug 22068: (QA follow-up) Return meaningful error codes ----------------------------------------------------------------------- hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 8 16:34:40 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 08 May 2019 14:34:40 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.05-4-gab351fd Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via ab351fdb42bcae228aa82e8f0655e4be3a231551 (commit) via 3477fc785fef1ca60051709509f05e296d320061 (commit) via 5b9f4cd775bfafbd6989c30b0435bd47c0014434 (commit) via 0a848d49012d2beef5627a89f9ad8544615fa35c (commit) from 8fab429baa5d4e9f2f96ae34945205d9e09610b0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ab351fdb42bcae228aa82e8f0655e4be3a231551 Author: Tomas Cohen Arazi Date: Wed Feb 27 07:09:12 2019 -0300 Bug 22420: Remove wrong calculation on approved tags Before the patch from bug 14385, the passed structure (that is returned by get_approval_rows() looks like: \ [ [0] { approved 1, approved_by 51, approved_by_name undef, date_approved "2019-02-26 15:36:42", term "another", weight_total 3 }, [1] { ... After the introduced 'filtering', we loose the information about the term weight!: \ [ [0] { approved 1, author "Heylin, Clinton.", biblionumber 1, borrowernumber 51, date_created "2019-02-26 15:36:37", language undef, subtitle [], tag_id 1, term "word", time_created_display "15:36:37", title "E Street shuffle :", visible 1, XSLTBloc " <<>> ... The code even calls GetMarcBiblio. This needs to be reverted as it is plain wrong. If it was worth removing *some* biblios from the weight_total value, then this calculation should be done somewhere else, without fetching the MARC data again. Signed-off-by: Claudio Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens (cherry picked from commit 28bcc5aa68733e41d50a6a801088b06857968f42) Signed-off-by: Martin Renvoize commit 3477fc785fef1ca60051709509f05e296d320061 Author: Nick Clemens Date: Mon Dec 17 13:35:09 2018 +0000 Bug 22010: Check preferences for ebook integration To test: 1 - Enable OverDrive and RecordedBooks (you can put anything in the prefs) 2 - Search on the opac - verify you get results (or search error) on first page of results' 3 - Go to second page of results - OD and RB are not searched 4 - Apply patch 5 - Verify nothing has changed If you have valid credentials: 1 - Enable RB prefs 2 - Sign in with an account that has an email matching your registered account for recordedbooks 3 - Confirm you RB account loads on opac-user.pl Otherwise: Read the patches, verify it all makes sense Signed-off-by: Owen Leonard Signed-off-by: Chris Cormack Signed-off-by: Nick Clemens (cherry picked from commit 7a44c9edb969cd92db4de0223a2c9db06d576451) Signed-off-by: Martin Renvoize commit 5b9f4cd775bfafbd6989c30b0435bd47c0014434 Author: Jonathan Druart Date: Sun Apr 28 21:40:21 2019 -0400 Bug 22357: Do not duplicate report rows if several reports exist At the moment every time you run runreport.pl with the --store-results option another line will appear for your report in the saved reports table. This is not a data, but a display problem as the report is still only stored once. 1) Create a report and note the report number 2) Run from command line (replace X by report number) : misc/cronjobs/runreport.pl X --format=csv --csv-header --store-results 3) Go to saved reports table 4) Look at the table, each run of the cronjob will create a new row in the table instead of just updating the saved results column. 5) Apply patch 6) Veriy the table displays correctly again and there are no regressions QA: Run t/db_dependent/Reports/Guided.t Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens (cherry picked from commit 4ca1d8e3b3f60722321f9f4b5f1f0caa461beecb) Signed-off-by: Martin Renvoize commit 0a848d49012d2beef5627a89f9ad8544615fa35c Author: Jonathan Druart Date: Fri Apr 26 20:49:14 2019 -0400 Bug 22717: (bug 20287 follow-up) Fix Google OpenId auto registration Silly bug caused by: commit ef410fd62f279a10687636a4f26babb2c91ecadc Bug 20287: Replace occurrences of AddMember with Koha::Patron->new->store->borrowernumber Constructors take a hashref! Signed-off-by: Chris Cormack Signed-off-by: Nick Clemens (cherry picked from commit 59b740613e7a72bf6e5283c2876bad9444a7ef6a) Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/External/OverDrive.pm | 18 ------- C4/Reports/Guided.pm | 3 +- .../bootstrap/en/includes/opac-bottom.inc | 5 +- .../bootstrap/en/modules/opac-overdrive-search.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-results.tt | 7 ++- opac/opac-search.pl | 6 +-- opac/opac-tags.pl | 18 ------- opac/svc/auth/googleopenidconnect | 4 +- opac/svc/overdrive_proxy | 2 +- t/External/OverDrive.t | 55 -------------------- 10 files changed, 17 insertions(+), 103 deletions(-) delete mode 100755 t/External/OverDrive.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 8 18:08:49 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 08 May 2019 16:08:49 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.05-18-g3276130 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via 32761305d3064cea7da31447e045c4989fdf3c26 (commit) via b3af8f93637a7d54dac3426f54057f8034b24eee (commit) via 6413f40738185f5319c66b763cb5bedc6fba8745 (commit) via ffae11293afb3f80e434e7c84b75e240f7512350 (commit) via c3cedab96a2fc451aaf7cb4ec3e67a00d83f93e0 (commit) via 2f489e78bb06fc86c7246b96215c22ce9aaae87f (commit) via 5f46508f811ae7be0b777bacda4576119259aee2 (commit) via e98714dc8777d890e51fa015dff701f4b1b8169e (commit) via 006fa1a49789763892b9fcd286b7e3d875472e10 (commit) via 3f99fb0c4c8b85285cd7b22d77d8d15cadda5098 (commit) via c016c41ed25942042cf370e580835573b866aa4c (commit) via 738aafb92dcfb73f51f9302fa9506040a8cc2930 (commit) via 540542ebc4befc9150be287c48be2d9c11129f72 (commit) via 3653df7715744f583bd33c62775d2ec8f7753b0a (commit) from ab351fdb42bcae228aa82e8f0655e4be3a231551 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 32761305d3064cea7da31447e045c4989fdf3c26 Author: Liz Rea Date: Wed May 1 00:31:15 2019 +0000 Bug 22816: OPAC detail holdings table should now look a bit better This patch sets the "autowidth" option to "false" for the OPAC holdings DataTable on opac-detail.pl. This gives the table a fluid width rather than having the width be "hard-coded" by DataTables upon first page render. To test, apply the patch and view the detail page for a bibliographic record with some items. Under the "Holdings" tab, the table of holdings should fill the width of the tab container. Resize the browser window and confirm that the table width adjusts accordingly. Signed-off-by: Bin Wen Signed-off-by: arthur Signed-off-by: Chris Cormack Signed-off-by: Nick Clemens (cherry picked from commit 604c7b818b63b93c66bb751ceb9d99bc1c109be9) Signed-off-by: Martin Renvoize commit b3af8f93637a7d54dac3426f54057f8034b24eee Author: Marcel de Rooy Date: Thu Jul 5 12:10:26 2018 +0200 Bug 21036: Remove odd number of elements warnings from AuthoritiesMarc.pm Like this one (16.11 line number): Odd number of elements in anonymous hash at C4/AuthoritiesMarc.pm line 1070. We need to add a scalar to some MARC::Field::subfield calls. In list context an empty list returned affects the hash built around it. Test plan: Could reproduce this warning easily from OPAC authority search. opac-authorities-home.pl calling BuildSummary. Signed-off-by: Bouzid Fergani Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens (cherry picked from commit 88b37330abaee6372ec999c1a81fd216d66a1379) Signed-off-by: Martin Renvoize commit 6413f40738185f5319c66b763cb5bedc6fba8745 Author: Marcel de Rooy Date: Thu Jul 5 09:53:57 2018 +0200 Bug 21036: Fix warnings from C4/Biblio Use of uninitialized value $isbn in string ne at /usr/share/koha/prodclone/C4/Biblio.pm line 1794. (16.11 line number) Trivial edit. And these warnings from TransformHtmlToXml (with 16.11 line numbers): Use of uninitialized value in substr at /usr/share/koha/prodclone/C4/Biblio.pm line 2527. Use of uninitialized value in substr at /usr/share/koha/prodclone/C4/Biblio.pm line 2528. substr outside of string at /usr/share/koha/prodclone/C4/Biblio.pm line 2528. Indicator in 952 is empty at /usr/share/koha/prodclone/C4/Biblio.pm line 2534. The last warning is not needed and can be removed. Note that the code used the construct @$indicator[$j] for $$indicator[$j]. The first is an array slice. This worked in list context. But apparently the second was meant to be used. And can be rewritten as $indicator->[$j] which generally is considered more readable. The code around indicator1/2 and ind1/2 is simplified. This change is applied twice in the same sub. Test plan: Read the changes. Run t/Biblio/TransformHtmlToXml.t Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens (cherry picked from commit 295e9b1054386cf188c5fc1eb4fd590e5c451513) Signed-off-by: Martin Renvoize commit ffae11293afb3f80e434e7c84b75e240f7512350 Author: Marcel de Rooy Date: Wed Jul 4 16:49:38 2018 +0200 Bug 21036: Fix uninitialized value within @itemnumber in string ne Line from 16.11 log: Use of uninitialized value within @itemnumber in string ne at /usr/share/koha/prodclone/reserve/modrequest.pl line 70. Test plan: Read the change. Not 100% identical (numeric zero) but should be enough. This line is probably not needed at all. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens (cherry picked from commit 4560d9623663e9fd0b60f9a39ec53082cdd90f24) Signed-off-by: Martin Renvoize commit c3cedab96a2fc451aaf7cb4ec3e67a00d83f93e0 Author: Jonathan Druart Date: Sun Apr 28 22:09:39 2019 -0400 Bug 22800: (bug 22550 follow-up) Do not raw filter when not necessary (OPAC suggestions) This is a follow-up for bug 22550, we do not need to use the $raw filter. Test plan: Same as bug 22550: Test plan: Test plan: 1. OPAC->login->your purchase suggestions->New purchase suggestion 2. Click button "Submit your suggestion" directly without filling in any field. Empty suggestion record was added succeffully. 3. Apply the patch. 4. Click button "Submit your suggestion" directly without filling in any field. The required fields should be labeled in red. (you can change the mandatory fields by preference 'OPACSuggestionMandatoryFields') Signed-off-by: Bin Wen Signed-off-by: Chris Cormack Signed-off-by: Nick Clemens (cherry picked from commit b9bff787ca863a45128cbd3a05a109e8f66d4fdf) Signed-off-by: Martin Renvoize commit 2f489e78bb06fc86c7246b96215c22ce9aaae87f Author: Nick Clemens Date: Fri Apr 26 19:58:05 2019 +0000 Bug 22791: Unify calculation between aqui-home and ordered.pl To test: 1 - Enable order price rounding 2 - Order an example with 8 * 16,99 and 42% discount, 19.45% tax. 3 - Check ordered page - 94.17 is total 4 - Check aqui-home - 94.16 is total 5 - Apply patch 6 - Verify numbers now match Signed-off-by: Maryse Simard Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens (cherry picked from commit 100b1e3eecb4de27f6a85095196019f6b36251c0) Signed-off-by: Martin Renvoize commit 5f46508f811ae7be0b777bacda4576119259aee2 Author: Nick Clemens Date: Tue May 7 15:57:35 2019 +0000 Bug 22527: (RM follow-up) Add filter Signed-off-by: Nick Clemens (cherry picked from commit d38d78bcf4cc62d34aa953864cf6da87bef93c80) Signed-off-by: Martin Renvoize commit e98714dc8777d890e51fa015dff701f4b1b8169e Author: Liz Rea Date: Tue Apr 16 06:55:36 2019 +0000 Bug 22527: web installer links to outdated DB manual To reproduce: 1. Use MySQL or MariaDB for your Koha installation 2. Create an empty database and point $KOHA_CONF to this database name. 3. Grant SELECT privilege to your database user, e.g. grant select on koha3.* to 'koha'@'%' identified by 'koha'; 4. Go to step 2 of web installer where it checks database connection 5. Observe the following message User koha doesn't have enough privilege on database koha. Ask for or make a change in the user's privileges. User koha must have USAGE, INSERT, UPDATE, DELETE, DROP and CREATE privileges on database koha2. Need help? See manual for PostgreSQL 6. Note "See manual for PostgreSQL" is wrong. Should now read Need help? For help with granting permissions, please search online for "[% dbms %] manual grant permissions" of course the dbms should be the dbms you are using. 7. Apply patch, restart all 8. Refresh page and observe it now displays correct link Test plan and original patchset by Lari Taskula Sponsored-by: Hypernova Oy Signed-off-by: Hayley Mapley Signed-off-by: Jonathan Druart Bug 22527: Remove extra space after '?' Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens (cherry picked from commit abd4445cd2b86fe601de20b403bb621115b27c83) Signed-off-by: Martin Renvoize commit 006fa1a49789763892b9fcd286b7e3d875472e10 Author: Josef Moravec Date: Mon Apr 29 14:18:43 2019 +0200 Bug 22787: Add mapping of letters "?" and "?" to zebra definitions Test plan: 0) Do not apply the patch 1) Add some word with character "?" into metadata, for example author "Martin?, Bohuslav" 2) Try to search it with "Martinu" and you'll see you can't find it 3) Apply the patch 4) Copy file etc/zebradb/etc/word-phrase-utf.chr to your /etc/koha directory sudo cp etc/zebradb/etc/word-phrase-utf.chr /etc/koha/zebradb/etc/ 5) koha-zebra --restart kohadev 6) koha-rebuild-zebra -f kohadev 6) try to search "Martinu" again - you should be able to find your record Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Signed-off-by: Chris Cormack Signed-off-by: Nick Clemens (cherry picked from commit d57239ca78e7719f4c04865e8c493919c6362c15) Signed-off-by: Martin Renvoize commit 3f99fb0c4c8b85285cd7b22d77d8d15cadda5098 Author: Jonathan Druart Date: Mon Nov 12 15:20:33 2018 -0300 Bug 21671: Prevent Modifications.t to fail randomly If repeatable is set to 0 by TestBuilder, the tests will fail with: t/db_dependent/Koha/Patron/Modifications.t .. 1/6 # Looks like you planned 20 tests but ran 9. # Failed test 'approve tests' # at t/db_dependent/Koha/Patron/Modifications.t line 259. [repeatable not set for attribute type and tried to add a new attribute for the same code]# Looks like your test exited with 255 just after 5. Signed-off-by: Liz Rea Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens (cherry picked from commit 914f23970de536df3972ebd75b280ee8eec98955) Signed-off-by: Martin Renvoize commit c016c41ed25942042cf370e580835573b866aa4c Author: Tomas Cohen Arazi Date: Tue Apr 30 15:48:14 2019 -0300 Bug 22813: (follow-up) Add missing condition This patch restores a missing condition. $patron gets renamed to make it obvious that it related to the logged in user. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens (cherry picked from commit 45b1ff8dfa1054590544caff200b307144bd02cf) Signed-off-by: Martin Renvoize commit 738aafb92dcfb73f51f9302fa9506040a8cc2930 Author: Tomas Cohen Arazi Date: Tue Apr 30 12:30:25 2019 -0300 Bug 22813: remove repetitive queries inside two nested loops in searchResults This patch moves a query on Koha::Patrons and then the related Koha::Patron::Category that needlessly happens inside two nested loops (all items of all MARC records in the resultset). The Koha::Patron and Koha::Patron::Category are always the same as it is fetched from C4::Context->userenv each time. To test: - Run: $ kshell k$ prove t/db_dependent/Search.t => SUCCESS: Tests pass - Apply this patch - Run: k$ prove t/db_dependent/Search.t => SUCCESS: Tests still pass! - Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Liz Rea Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens (cherry picked from commit 10efe4e3f239c47b847c53f06f82245e07d54759) Signed-off-by: Martin Renvoize commit 540542ebc4befc9150be287c48be2d9c11129f72 Author: Jonathan Druart Date: Mon Mar 4 18:12:56 2019 -0300 Bug 22453: Make TestBuilder generates dates taking into account the timezone I have no idea why this only appears today but TestBuilder generates dates using DateTime->now, which does not take into account the timezone. It has been highlights by a failing test today on U18. Why today whereas this patch was pushed few weeks ago? Why U18 and not D9? The output of the test is: koha_1 | # Failed test 'With BorrowerLogs and TrackLastPatronActivity we should not spam the logs' koha_1 | # at t/db_dependent/Koha/Patrons.t line 1421. koha_1 | # got: '2' koha_1 | # expected: '1' koha_1 | # Looks like you failed 1 test of 4. koha_1 | koha_1 | # Failed test 'BorrowersLog tests' koha_1 | # at t/db_dependent/Koha/Patrons.t line 1422. koha_1 | # Looks like you failed 1 test of 33. koha_1 | [19:51:44] t/db_dependent/Koha/Patrons.t Actually there are 2 logs, one for the cardnumber that is expected, and on for updated_on: "updated_on" : { "after" : "2019-03-04 21:10:00", "before" : "2019-03-04 18:10:00" } Apart from the fact that we may want to remove this updated_on field from MODIFY, the before/after dates differ from 3 hours. Here it's currently 18:10 and in UTC-3 To prevent such behaviors in tests (create stuffs in the future...), we should use our Koha::DateUtils::dt_from_string method that takes care of the timezone used in other places of Koha. Test plan: prove t/db_dependent/Koha/Patrons.t May fail without this patch. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy This patch is fine in itself, but there may still be an issue around the failing test for TrackLastPatronActivity. Reopened bug 22741. Signed-off-by: Nick Clemens (cherry picked from commit c1513a10c35f721e3c519d5ab3c38c7154b7fa1c) Signed-off-by: Martin Renvoize commit 3653df7715744f583bd33c62775d2ec8f7753b0a Author: Mirko Tietgen Date: Tue Apr 30 10:56:20 2019 +0200 Bug 22808: Move Cache.t to db_dependent Cache.t fails during package build. Moving it to db_dependent fixes the problem. Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens (cherry picked from commit 6509d73d7925fe5d317d6f2baa1d1565d8d36220) Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/AuthoritiesMarc.pm | 10 +++---- C4/Biblio.pm | 28 +++++--------------- C4/Search.pm | 13 ++++++--- acqui/ordered.pl | 2 +- etc/zebradb/etc/word-phrase-utf.chr | 2 ++ .../prog/en/modules/installer/step2.tt | 6 +---- .../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 6 +++-- .../bootstrap/en/modules/opac-suggestions.tt | 4 +-- opac/opac-suggestions.pl | 6 ++--- reserve/modrequest.pl | 2 +- t/{ => db_dependent}/Cache.t | 0 t/db_dependent/Koha/Patron/Modifications.t | 2 +- t/lib/TestBuilder.pm | 5 ++-- 13 files changed, 39 insertions(+), 47 deletions(-) rename t/{ => db_dependent}/Cache.t (100%) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 8 18:17:12 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 08 May 2019 16:17:12 +0000 Subject: [koha-commits] main Koha release repository branch 18.05.x updated. v18.05.11-65-gb82656e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.05.x has been updated via b82656ed06b22f55c3a1d3be7e96d2d9c0499dec (commit) from f3f99eb4988ffefcef9ebd71ebb1b255a05113d0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b82656ed06b22f55c3a1d3be7e96d2d9c0499dec Author: root Date: Tue May 7 18:01:45 2019 +0000 Bug 22478: (follow-up) [18.05.X ONLY] Fix rebase and fix selenium opac_auth We missed a case or two in the backport, also picked changes from https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76414&action=diff in order to fix opac auth in selenium Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: t/db_dependent/selenium/regressions.t | 7 +++++-- t/lib/Selenium.pm | 5 ++--- 2 files changed, 7 insertions(+), 5 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 8 20:33:15 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 08 May 2019 18:33:15 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.05-19-gc9516a6 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via c9516a6c191cfe408e56411c78e3e311d326ce12 (commit) from 32761305d3064cea7da31447e045c4989fdf3c26 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c9516a6c191cfe408e56411c78e3e311d326ce12 Author: Martin Renvoize Date: Wed May 8 19:13:46 2019 +0100 Bug 22357: (RMaint follow-up) Mana does not exist in 18.11.x Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Reports/Guided.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 8 22:30:54 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 08 May 2019 20:30:54 +0000 Subject: [koha-commits] main Koha release repository branch 18.05.x updated. v18.05.11-66-g81bb1b5 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.05.x has been updated via 81bb1b55c27c3dfcab5a04af3257d5e93bcc6177 (commit) from b82656ed06b22f55c3a1d3be7e96d2d9c0499dec (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 81bb1b55c27c3dfcab5a04af3257d5e93bcc6177 Author: Lucas Gass Date: Thu May 2 01:39:50 2019 +0000 Bug 22692: (RMaint Follow-up) fix tests Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: t/db_dependent/Auth.t | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 9 14:07:09 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 09 May 2019 12:07:09 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.05-20-g41f9ad2 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via 41f9ad2fd548d2f204c946b33a0cb56110f42c2f (commit) from c9516a6c191cfe408e56411c78e3e311d326ce12 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 41f9ad2fd548d2f204c946b33a0cb56110f42c2f Author: Martin Renvoize Date: Thu May 9 12:44:49 2019 +0100 Bug 15524: (RMaint followup) Missing Sponsor Attribution Sponsored-by: Northeast Kansas Library System, NEKLS (http://nekls.org/) Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 9 20:39:49 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 09 May 2019 18:39:49 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v18.11.00-1448-ge17500f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via e17500f621ec9de63f4cedb2905885b494c81edf (commit) via a0bb818b0bc5acb54a48bf84772d795b2eea53fc (commit) via 5f3c849014adad66deae505ff1ef8a7ddb8ea999 (commit) via 70c6c5dd93f9981a685d811c9e6adfc88508ffed (commit) via 1c61e60a17f06f6eb532fff9b7026fe99b818ded (commit) via 770212d134e780cef4ad5f0da20fb40a036c5978 (commit) via 89d764352f43004ebc33bea09c8557fd733a1b61 (commit) via 3b50efb7d5b8fd366d140be83a000d9afbdf4c02 (commit) via cda1f7a65682573ad6ff7a219e518d508fcc18c6 (commit) via c48af49ded481f498087eaf8e4cb530c4cc0a8e9 (commit) via 3e9550019a16d3944816788342eb808f3524d81e (commit) via b40dd03ed54b6b08ad5b338d9d2d2de94de9cdf1 (commit) via d3f4b50bdd476160d026012154c9f3463b94d37e (commit) via 503842ac6c37cdbab2a8868604bd6f1294c829b1 (commit) from d38d78bcf4cc62d34aa953864cf6da87bef93c80 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e17500f621ec9de63f4cedb2905885b494c81edf Author: Nick Clemens Date: Thu May 9 18:20:34 2019 +0000 Bug 7088: DBRev 18.12.00.068 Signed-off-by: Nick Clemens commit a0bb818b0bc5acb54a48bf84772d795b2eea53fc Author: Nick Clemens Date: Thu May 9 17:22:25 2019 +0000 Bug 7088: Compiled CSS Signed-off-by: Nick Clemens commit 5f3c849014adad66deae505ff1ef8a7ddb8ea999 Author: Andrew Isherwood Date: Fri Apr 26 10:58:31 2019 +0100 Bug 7088: (follow-up) Modify checkbox enabling As described in comment #50, we need to only enable renewal on items that are disabled in line with which sysprefs are enabled. So we now only enable renewal of on hold items if the AllowRenewalOnHoldOverride syspref is on and we only enable renewal of all other limited items when the AllowRenewalLimitOverride syspref is on. NOTE: The test plan below has changed substantially from previous iterations Test plan (you might want to make a coffee first...): - Apply patch - Rebuild CSS - Go to the Patron Details page for a patron who has an item on loan that would fulfil an outstanding loan request. - The patron also needs to have an item on loan that cannot be renewed for some other reason, say renewal limit has been reached => TEST: Observe that it is NOT possible to select either item for renewal - Enable the "AllowRenewalLimitOverride" syspref - Return to the Patron Details page - Check the "Override renewal restrictions" checkbox => TEST: Observe that it IS possible to select the the item that has reached the renewal limit, but not the item that is on hold - Disable the "AllowRenewalLimitOverride" syspref - Enable the "AllowRenewalOnHoldOverride" syspref - Return to the Patron Details page - Check the "Override renewal restrictions" checkbox => TEST: Observe that it is NOT possible to select the the item that has reached the renewal limit, but it IS possible to select the item on hold - Enable the "AllowRenewalLimitOverride" syspref - Enable the "AllowRenewalOnHoldOverride" syspref - Return to the Patron Details page - Check the "Override renewal restrictions" checkbox => TEST: Observe that it IS possible to select the the item that has reached the renewal limit, AND it IS possible to select the item on hold - Select the item that is on hold => TEST: Observe that an additional "On hold due date" input box is displayed - De-select the item => TEST: Observe that an additional "On hold due date" input box is hidden - Select the item - In the "On hold due date" input box, select a due date for the item - Click "Renew or check in selected items" => TEST: Observe that the item is renewed as usual - In the "Renewal due date" input box, select a due date - Remove the contents of the "On hold due date" input box - Click "Renew or check in selected items" => TEST: Observe that the item is renewed by falling back to the "Renewal due date" value if a value is not specified in the "On hold due date" input box - Remove the contents of the "Renewal due date" input box - Click "Renew or check in selected items" => TEST: Observe that the standard loan period is used for the renewal period if no due date is specified in either box - In the "On hold due date" input box, select a due date for the item - In the "Renewal due date" input box, select a different due date - Click "Renew all" => TEST: Observe that all non on hold items are renewed using the value in "Renewal due date" and on hold items are renewed using the value in "On hold due date" - From the main staff client from page, choose "Circulation", then choose "Renew" - Enter the barcode of an item that you know to be on hold and submit => TEST: In the alert box that appears, observe that a date picker is displayed - Choose a due date for this item, then click "Override and renew" => TEST: In the "Item renewed" box, observe that the item has been renewed to the date specified Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit 70c6c5dd93f9981a685d811c9e6adfc88508ffed Author: Andrew Isherwood Date: Tue Apr 23 10:44:08 2019 +0100 Bug 7088: (follow-up) AllowRenewalLimitOverride fix This patch causes the click event listener on the #override_limit to be created if EITHER the AllowRenewalOnHoldOverride OR AllowRenewalLimitOverride sysprefs are enabled. Previously, it would only be created if the AllowRenewalLimitOverride syspref was enabled, which would cause the checkbox to be displayed but do nothing. Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit 1c61e60a17f06f6eb532fff9b7026fe99b818ded Author: Andrew Isherwood Date: Thu Feb 21 12:21:23 2019 +0000 Bug 7088: (follow-up) Add pref to checkbox As per commit #29 here: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088#c29 Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit 770212d134e780cef4ad5f0da20fb40a036c5978 Author: Andrew Isherwood Date: Thu Feb 7 14:43:55 2019 +0000 Bug 7088: (follow-up) Default hold checkbox display As per item 4 here: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088#c24 Now, the checkbox for renewing on hold items behaves the same way as the checkbox for renewing items that have reached their renew limit. It is necessary to check the re-labelled "Override renewal restrictions" checkbox before it is possible to select on-hold items for renewal. Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit 89d764352f43004ebc33bea09c8557fd733a1b61 Author: Andrew Isherwood Date: Wed Jan 30 11:05:17 2019 +0000 Bug 7088: (follow-up) Set syspref default to off As per item 2 here: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088#c24 Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit 3b50efb7d5b8fd366d140be83a000d9afbdf4c02 Author: Andrew Isherwood Date: Wed Jan 30 11:03:10 2019 +0000 Bug 7088: (follow-up) Remove script "type" attribute As per item 1 here: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088#c24 Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit cda1f7a65682573ad6ff7a219e518d508fcc18c6 Author: Andrew Isherwood Date: Tue Nov 13 13:57:57 2018 +0000 Bug 7088: (follow-up) Fix renewal limit bug There was a bug in that altering the state of the "Override renewal limit" checkbox was altering the appearance of the per-item "On hold" checkbox. This is incorrect, the "Override renewal limit" checkbox is unconnected with this bug. Sponsored-by: Cheshire Libraries Shared Services Sponsored-by: Halton Borough Council Sponsored-by: Sefton Council Signed-off-by: Andrew Farthing Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit c48af49ded481f498087eaf8e4cb530c4cc0a8e9 Author: Andrew Isherwood Date: Fri Sep 21 11:09:13 2018 +0100 Bug 7088: Allow renew on hold items with due date This patch adds the ability for items that are on hold to be renewed with a due date specfied by the user. It is enabled by the new "AllowRenewalOnHoldOverride" syspref. It is manifested in two locations: 1. In the "Checkouts" table on the Patron Details screen. It is now possible to select on loan items that would otherwise fulfil a hold request to be renewed. When such an item is selected, an additional date selection box is displayed to allow the user to specify the due date for all on hold items that are to be renewed. 2. In the Circulation > Renew alert screen. When a barcode of an on loan item that would ordinarily fulfil a hold request is entered, the usual alert is displayed indicating that the item is on hold, it is still possible to override this, and renew, however it is now also possible to specify a due date. Test plan: - Go to the Patron Details page for a patron who has an item on loan that would fulfil an outstanding loan request. - TEST: Observe that it is NOT possible to select this item - Enable the "AllowRenewalOnHoldOverride" syspref - Return to the Patron Details page for a patron who has an item on loan that would fulfil an outstanding loan request. - TEST: Observe that it IS possible to select this item - Select the item - TEST: Observe that an additional "On hold due date" input box is displayed - De-select the item - TEST: Observe that an additional "On hold due date" input box is hidden - Select the item - In the "On hold due date" input box, select a due date for the item - Click "Renew or check in selected items" - TEST: Observe that the item is renewed as usual - In the "Renewal due date" input box, select a due date - Remove the contents of the "On hold due date" input box - Click "Renew or check in selected items" - TEST: Observe that the item is renewed by falling back to the "Renewal due date" value if a value is not specified in the "On hold due date" input box - Remove the contents of the "Renewal due date" input box - Click "Renew or check in selected items" - TEST: Observe that the standard loan period is used for the renewal period if no due date is specified in either box - In the "On hold due date" input box, select a due date for the item - In the "Renewal due date" input box, select a different due date - Click "Renew all" - TEST: Observe that all non on hold items are renewed using the value in "Renewal due date" and on hold items are renewed using the value in "On hold due date" - From the main staff client from page, choose "Circulation", then choose "Renew" - Enter the barcode of an item that you know to be on hold and submit - TEST: In the alert box that appears, observe that a date picker is displayed - Choose a due date for this item, then click "Override and renew" - TEST: In the "Item renewed" box, observe that the item has been renewed to the date specified Sponsored-by: Cheshire Libraries Shared Services Sponsored-by: Halton Borough Council Sponsored-by: Sefton Council Signed-off-by: Andrew Farthing Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit 3e9550019a16d3944816788342eb808f3524d81e Author: Andrew Isherwood Date: Wed Sep 19 16:29:19 2018 +0100 Bug 7088: Add AllowRenewalOnHoldOverride syspref Enables the renewal of on hold items with specified due dates to be turned on/off Sponsored-by: Cheshire Libraries Shared Services Sponsored-by: Halton Borough Council Sponsored-by: Sefton Council Signed-off-by: Andrew Farthing Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit b40dd03ed54b6b08ad5b338d9d2d2de94de9cdf1 Author: Jonathan Druart Date: Wed May 8 10:28:22 2019 -0500 Bug 22790: Add a test Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens commit d3f4b50bdd476160d026012154c9f3463b94d37e Author: Andreas Jonsson Date: Fri Apr 26 19:44:59 2019 +0000 Bug 22790: The system preference itemBarcodeInputFilter is not applied for barcodes inputed via SIP2 Signed-off-by: Liz Rea Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens commit 503842ac6c37cdbab2a8868604bd6f1294c829b1 Author: Jonathan Druart Date: Fri May 3 17:34:22 2019 -0400 Bug 22847: Correctly displayed circ rule values for max_holds and maxissue* There are several things going wrong on the circulation rules screen. The global rule is displayed for specific libraries (even if the rule does not exist for the library), and max_holds is always blank. I have trouble finding the root of the issue, but I will propose a patch to fix both problem. Certainly a mismatch between bug 18887 and bug 18925. Test plan: 0. Do not apply the patch 1. Notice the issue on the circulation rules screen 2. Apply the patch 3. Confirm that the value you set are correctly displayed (and not the propagated ones!) Signed-off-by: Liz Rea Signed-off-by: Agustin Moyano Signed-off-by: Kyle M Hall Signed-off-by: Nick Clemens ----------------------------------------------------------------------- Summary of changes: C4/SIP/ILS/Item.pm | 2 +- Koha.pm | 2 +- Koha/Template/Plugin/CirculationRules.pm | 12 +- circ/renew.pl | 2 +- installer/data/mysql/sysprefs.sql | 1 + installer/data/mysql/updatedatabase.pl | 10 ++ .../intranet-tmpl/prog/css/src/staff-global.scss | 19 ++++ koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 2 +- .../prog/en/includes/checkouts-table-footer.inc | 10 +- .../prog/en/includes/checkouts-table.inc | 4 +- .../en/modules/admin/preferences/circulation.pref | 6 + .../prog/en/modules/admin/smart-rules.tt | 6 +- .../prog/en/modules/circ/circulation.tt | 1 + .../intranet-tmpl/prog/en/modules/circ/renew.tt | 22 ++++ .../prog/en/modules/members/moremember.tt | 1 + koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 115 +++++++++++++++----- .../intranet-tmpl/prog/js/pages/circulation.js | 2 +- svc/renew | 6 + t/db_dependent/SIP/Transaction.t | 8 +- 19 files changed, 184 insertions(+), 47 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 9 21:50:43 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 09 May 2019 19:50:43 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v18.11.00-1456-g2330a15 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 2330a155f6d13c37a81632c3088030c89a877401 (commit) via 94c4a268ac098705c2db703512fc0065fed6a42b (commit) via 629b2723cb3c654c57e1db2ab206ea163128ccbb (commit) via 1cd1fcc9d72fc031f1aba42eee7e79040f758569 (commit) via 4aa2e16ec18f50dfe7c00f1eafc87a7546b24f04 (commit) via d0e053e24d05ddc679a56d46ac121c3f4c89a21f (commit) via 7394028b27a36b55fd85285a87c8d2f00649e6e9 (commit) via 0a262a214f2c2ff6e836d7283cae413ee354cdce (commit) from e17500f621ec9de63f4cedb2905885b494c81edf (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2330a155f6d13c37a81632c3088030c89a877401 Author: Marcel de Rooy Date: Wed Oct 10 15:34:22 2018 +0200 Bug 21535: Anonymize function in Patron should not scramble email addresses Scrambled email addresses will only generate warnings etc. Clear them although they might be in BorrowerMandatoryField. Test plan: Run t/db_dependent/Koha/Patrons.t Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard t/db_depepended/Koha/Patrons.t runs with no warnings. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens commit 94c4a268ac098705c2db703512fc0065fed6a42b Author: Owen Leonard Date: Tue Apr 30 14:57:59 2019 +0000 Bug 22811: Add button to clear DataTables filtering This patch adds a "clear filter" button to the global DataTables configuration. The button will appear if: - There is no custom DOM configuration applied to the DataTable instance. - The DataTable has the search form enabled. The new button should be disabled by default. Entering a search term in the form should enable it. To test, apply the patch and clear your browser cache if necessary. View various pages with various DataTables configurations and confirm that everything looks correct and the new "Clear filter" button doesn't appear when there is no DataTable search field. For example: - Administration -> Libraries - Administration -> Currencies - Reports -> Saved reports - Circulation -> Check out - Tools -> News Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit 629b2723cb3c654c57e1db2ab206ea163128ccbb Author: Nick Clemens Date: Thu May 9 19:29:44 2019 +0000 Bug 22053: DBRev 18.12.00.069 Signed-off-by: Nick Clemens commit 1cd1fcc9d72fc031f1aba42eee7e79040f758569 Author: Tomas Cohen Arazi Date: Tue Apr 30 10:54:01 2019 -0300 Bug 22053: (QA follow-up) Override enable_plugins configuration This patch makes the update script override the configured enable_plugins setting in koha-conf.xml. on testing the failure I wrote trivial tests on how Koha::Plugins->new({ enable_plugins => 1 }) should work. Adding them to this patch as well. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens commit 4aa2e16ec18f50dfe7c00f1eafc87a7546b24f04 Author: Tomas Cohen Arazi Date: Mon Apr 29 15:21:32 2019 -0300 Bug 22053: (QA follow-up) More tests This patch adds tests for: - $plugin->enable and $plugin->disable are chainable (i.e. return $self) - Disabled plugins don't inject routes To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Koha/REST/Plugin/PluginRoutes.t \ t/db_dependent/Plugins.t => SUCCESS: Tests pass Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens commit d0e053e24d05ddc679a56d46ac121c3f4c89a21f Author: Alex Arnaud Date: Fri Dec 28 17:52:18 2018 +0100 Bug 22053: update database Rebased-on: 2019-03-25 Alex Arnaud Signed-off-by: Claire Gravely Signed-off-by: Agustin Moyano Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens commit 7394028b27a36b55fd85285a87c8d2f00649e6e9 Author: Alex Arnaud Date: Fri Dec 28 17:50:14 2018 +0100 Bug 22053: ability to enable/disable some plugins Test plan: - apply this patch(es), - launch an updatedabase, - go to plugins/plugins-home.pl and deal with enable/disable method - install a plugin like KitchenSink https://github.com/bywatersolutions/koha-plugin-kitchen-sink - once installed, the plugin change the background color of the staff client to orange. - disable the plugin, - background color should be set back to the original one Rebased-on: 2019-03-25 Alex Arnaud Signed-off-by: Claire Gravely Signed-off-by: Agustin Moyano Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens commit 0a262a214f2c2ff6e836d7283cae413ee354cdce Author: Alex Arnaud Date: Fri Dec 28 17:48:43 2018 +0100 Bug 22053: create unit tests Rebased-on: 2019-03-25 Alex Arnaud Signed-off-by: Claire Gravely Signed-off-by: Agustin Moyano Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- Koha/Patron.pm | 4 +- Koha/Plugins.pm | 10 ++++ Koha/Plugins/Base.pm | 34 +++++++++++- installer/data/mysql/updatedatabase.pl | 15 ++++++ .../intranet-tmpl/prog/css/src/staff-global.scss | 2 +- .../prog/en/includes/columns_settings.inc | 13 ++++- .../prog/en/modules/plugins/plugins-home.tt | 14 ++++- koha-tmpl/intranet-tmpl/prog/js/datatables.js | 41 ++++++++++++++- .../{plugins-uninstall.pl => plugins-enable.pl} | 25 +++------ plugins/plugins-home.pl | 1 + t/db_dependent/Koha/Patrons.t | 3 +- t/db_dependent/Koha/REST/Plugin/PluginRoutes.t | 54 ++++++++++++++++++-- t/db_dependent/Plugins.t | 32 +++++++++++- 14 files changed, 220 insertions(+), 30 deletions(-) copy plugins/{plugins-uninstall.pl => plugins-enable.pl} (66%) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 10 14:42:47 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 May 2019 12:42:47 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v18.11.00-1464-gd35cc83 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via d35cc83379fae8998b1b9828c8fdb05746b44287 (commit) via 5ecbe281aff13e53d4fbc5064714de9209410358 (commit) via d80e5a2bb633419f9ca52b7d289829543341f7bd (commit) via 9388401f88788172c888e47d33739f2682750097 (commit) via a4f5cc4d66d5374dcbc32b402417ac770e8a695d (commit) via 9f25d1d003d099dcdca803c3385ecfb0f7fdbb49 (commit) via 88e0fa19dfe3c83dd9f713fb81b2b00e23c21546 (commit) via 30f0e7fec988393531024bcd9bfa0e4f4effb254 (commit) from 2330a155f6d13c37a81632c3088030c89a877401 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d35cc83379fae8998b1b9828c8fdb05746b44287 Author: Marcel de Rooy Date: Wed Oct 10 14:49:02 2018 +0200 Bug 21533: Do not allow password recovery for administrative locked patrons Depends on bug 21336 for the ADMINISTRATIVE_LOCKOUT constant. This is a bit lazy solution (but good enough): The account will not be found when recovering the password. The user should contact the library. Since the library chose to lock the account, that seems appropriate. Test plan: Select a borrower and set login_attempts to -1. Via mysql command line or with Koha::Patrons->find(borrowernumber)->lock. Enable password recovery. Try to recover password from OPAC. You should fail with 'Not found, contact the library'. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Bouzid Fergani Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens commit 5ecbe281aff13e53d4fbc5064714de9209410358 Author: Nick Clemens Date: Fri May 10 12:10:42 2019 +0000 Bug 22782: DBIC update for SocialData Signed-off-by: Nick Clemens commit d80e5a2bb633419f9ca52b7d289829543341f7bd Author: Nick Clemens Date: Fri May 10 12:09:59 2019 +0000 Bug 14407: DBRev 18.12.00.070 Signed-off-by: Nick Clemens commit 9388401f88788172c888e47d33739f2682750097 Author: Nick Clemens Date: Fri May 10 11:44:45 2019 +0000 Bug 14407: (RM follow-up) bump version number Signed-off-by: Nick Clemens commit a4f5cc4d66d5374dcbc32b402417ac770e8a695d Author: Mark Tompsett Date: Tue Mar 27 14:28:06 2018 +0000 Bug 14407: Follow up to add test case and clean noise Comment #28 has a /36 which is invalid CIDR. This triggers a crash and noise. This cleans up the crash and noise, and adds test cases to check for them. prove t/Auth.t -- before missing null case, and /36 case. -- after null case, and /36 with/without warnings. Signed-off-by: Mark Tompsett Signed-off-by: Hayley Mapley Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens commit 9f25d1d003d099dcdca803c3385ecfb0f7fdbb49 Author: Mark Tompsett Date: Tue Mar 27 14:43:46 2018 +0000 Bug 14407: Follow up add missing atomic update The patch only added the system preference for fresh installs. Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens commit 88e0fa19dfe3c83dd9f713fb81b2b00e23c21546 Author: Nicholas can Oudtshoorn Date: Fri Jan 12 18:14:59 2018 +0000 Bug 14407: Unit tests for in_ipset TEST PLAN --------- 1) apply all pathches 2) sudo koha-shell -c bash kohadev prove t/Auth.t -- should run. 3) run koha qa test tools Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens commit 30f0e7fec988393531024bcd9bfa0e4f4effb254 Author: Nicholas can Oudtshoorn Date: Fri Jan 12 17:28:41 2018 +0000 Bug 14407: Allow restricting SCO to IP or IP range Converted this to actual applicable patches. I think the test plan is comment #28. -- Mark Tompsett Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens ----------------------------------------------------------------------- Summary of changes: C4/Auth.pm | 25 +++++++++++- C4/Installer/PerlDependencies.pm | 5 +++ Koha.pm | 2 +- Koha/Schema/Result/SocialData.pm | 7 ++-- installer/data/mysql/kohastructure.sql | 2 +- installer/data/mysql/sysprefs.sql | 1 + installer/data/mysql/updatedatabase.pl | 12 ++++++ .../en/modules/admin/preferences/circulation.pref | 4 ++ opac/opac-password-recovery.pl | 4 +- opac/sco/help.pl | 7 +++- opac/sco/printslip.pl | 7 +++- opac/sco/sco-main.pl | 10 ++++- opac/sco/sco-patron-image.pl | 6 +++ t/Auth.t | 42 ++++++++++++++++++++ 14 files changed, 122 insertions(+), 12 deletions(-) create mode 100644 t/Auth.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 10 17:10:02 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 May 2019 15:10:02 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v18.11.00-1483-g70dcc17 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 70dcc175c69446f51c4dab0be1b66f1f857a07c5 (commit) via 9fa97774ae6b3c84028b15f8c768460a012320ea (commit) via ae6f5a347767135c3b707b638e5e496ae402752a (commit) via 0aae53df1d4f284afc88f9e14d88c934ae3529d7 (commit) via 90d261364404cc7f6bdd8ec3df94b839526e68b8 (commit) via 806d87d0c6cb1a05e921b1c7f2cb43903f75f881 (commit) via a308dbcffd16aaee3db54b3d4eecbe5c17987110 (commit) via ca2309ef1bb89f6ad8d26aabcbd3501115d1ba9a (commit) via 96382b6fd761269bbe18bc2cbe2bcc6c10a91ba8 (commit) via 5317ccc5b82727eaac2bfb6e1d58ae6dedfe8db3 (commit) via 645fab36103ee47e6826a704ee5065ca545b6cac (commit) via 86079b58238e8c243ac4ec0847ceb4d2b27bd393 (commit) via d1a22a42be03ccc801d2cae960c7eaac389ffaa6 (commit) via 74bc51523a711d3526eb60ba5170e28ef0ac365a (commit) via 45c1cd1b666f9b890494c3f0396272d308b8dd2c (commit) via 5f1660321f94d31127eaf2612ca464bf08da8dcc (commit) via 0f73c9176890675ba0630ebb51657d16a865c8ad (commit) via f7e47847e4ff7bd61311fbfde5cc80a0cf91d214 (commit) via abe70811098da409af6cb9e97a4a3d00b4f0d3ef (commit) from d35cc83379fae8998b1b9828c8fdb05746b44287 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 70dcc175c69446f51c4dab0be1b66f1f857a07c5 Author: Owen Leonard Date: Mon Apr 29 15:48:14 2019 +0000 Bug 22803: (alternate) Set dataTable width issue This patch sets the "autowidth" option to "false" for the OPAC subscriptions DataTable on opac-detail.pl. This gives the table a fluid width rather than having the width be "hard-coded" by DataTables upon first page render. To test, apply the patch and view the detail page for a bibliographic record with a subscription. Under the "Subscriptions" tab, the table of latest issues should fill the width of the tab container. Resize the browser window and confirm that the table width adjusts accordingly. Signed-off-by: Liz Rea Signed-off-by: Nick Clemens commit 9fa97774ae6b3c84028b15f8c768460a012320ea Author: Jonathan Druart Date: Thu Nov 1 13:31:31 2018 -0300 Bug 21709: Replace 'no popup' plugin links with a span Test plan: Edit a bibliographic record Notice that the icons next to fields linked with a plugin can be a link or not. The browser displays a pointer or not. It will remove the ambiguity to display an icon that is clickable but does nothing when clicked. We could also have another icon to disociate both behaviors. Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens commit ae6f5a347767135c3b707b638e5e496ae402752a Author: Nick Clemens Date: Fri May 10 14:44:47 2019 +0000 Bug 22809: DBRev 18.12.00.072 Signed-off-by: Nick Clemens commit 0aae53df1d4f284afc88f9e14d88c934ae3529d7 Author: Nick Clemens Date: Fri May 10 14:43:11 2019 +0000 Bug 22809: (RM follow-up) fix missing filter and update description Signed-off-by: Nick Clemens commit 90d261364404cc7f6bdd8ec3df94b839526e68b8 Author: Martin Renvoize Date: Thu May 2 12:44:05 2019 +0100 Bug 22809: (QA follow-up) Add notice translations Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens commit 806d87d0c6cb1a05e921b1c7f2cb43903f75f881 Author: Liz Rea Date: Tue Apr 30 19:41:06 2019 +0000 Bug 22809: (QA follow-up) add bug description to atomicupdate Signed-off-by: Liz Rea Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens commit a308dbcffd16aaee3db54b3d4eecbe5c17987110 Author: Kyle M Hall Date: Tue Apr 30 07:53:50 2019 -0400 Bug 22809: Move "INVOICE" from template to a slip Just as bug 22761 moves the "Fee receipt" to the ACCOUNT_CREDIT slip, we need to move the "INVOICE" to an ACCOUNT_DEBIT slip. Test Plan: 1) Apply this patch set 2) Restart all the things 3) Use the "print" button beside a *fee* 4) You should not see any difference from before the patches were applied Signed-off-by: Liz Rea Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens commit ca2309ef1bb89f6ad8d26aabcbd3501115d1ba9a Author: Nick Clemens Date: Fri May 10 14:31:21 2019 +0000 Bug 22761: DBRev 18.12.00.071 Signed-off-by: Nick Clemens commit 96382b6fd761269bbe18bc2cbe2bcc6c10a91ba8 Author: Nick Clemens Date: Fri May 10 14:21:45 2019 +0000 Bug 22716: (RM follow-up) missing filter and update description Signed-off-by: Nick Clemens commit 5317ccc5b82727eaac2bfb6e1d58ae6dedfe8db3 Author: Martin Renvoize Date: Thu May 2 12:33:15 2019 +0100 Bug 22761: (QA follow-up) Add description to DB update Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens commit 645fab36103ee47e6826a704ee5065ca545b6cac Author: Martin Renvoize Date: Thu May 2 12:27:44 2019 +0100 Bug 22761: (QA follow-up) Add notice translations Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens commit 86079b58238e8c243ac4ec0847ceb4d2b27bd393 Author: Kyle M Hall Date: Tue Apr 23 14:40:08 2019 -0400 Bug 22761: Remove hard coded version from template Signed-off-by: Michal Denar Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens commit d1a22a42be03ccc801d2cae960c7eaac389ffaa6 Author: Kyle M Hall Date: Tue Apr 23 14:39:44 2019 -0400 Bug 22761: Add notice based on existing template Signed-off-by: Michal Denar Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens commit 74bc51523a711d3526eb60ba5170e28ef0ac365a Author: Kyle M Hall Date: Tue Apr 23 14:12:55 2019 -0400 Bug 22761: Add ability to use print version of ACCOUNT_CREDIT slip Signed-off-by: Michal Denar Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens commit 45c1cd1b666f9b890494c3f0396272d308b8dd2c Author: Ere Maijala Date: Mon Mar 4 14:30:13 2019 +0200 Bug 21872: Fix name of rebuild_elasticsearch.pl Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens commit 5f1660321f94d31127eaf2612ca464bf08da8dcc Author: Ere Maijala Date: Mon Mar 4 14:18:00 2019 +0200 Bug 21872: Add support for -p parameter to koha-elasticsearch Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens commit 0f73c9176890675ba0630ebb51657d16a865c8ad Author: David Gustafsson Date: Thu Feb 14 15:59:27 2019 +0100 Bug 21872: Remove duplicate modulo condition in authorities iterator Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens commit f7e47847e4ff7bd61311fbfde5cc80a0cf91d214 Author: David Gustafsson Date: Thu Feb 14 15:06:35 2019 +0100 Bug 21872: Simplify conditions and exit on invalid combination of arguments Change to zero based indexing for slice index to simplify some conditions. Exit with error message if trying to combine processes and biblio numbers arguments. Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens commit abe70811098da409af6cb9e97a4a3d00b4f0d3ef Author: Ere Maijala Date: Fri Nov 23 10:43:34 2018 +0200 Bug 21872: Add multiprocess support to Elasticsearch indexing utility Test plan: 1. Time execution without -p parameter 2. Time execution with -p 2 or -p3 or -p 4 depending on CPU core count Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- Koha/BiblioUtils.pm | 28 +++- Koha/MetadataRecord/Authority.pm | 35 ++++- debian/scripts/koha-elasticsearch | 13 +- .../data/mysql/de-DE/mandatory/sample_notices.sql | 116 ++++++++++++++- .../data/mysql/en/mandatory/sample_notices.sql | 116 ++++++++++++++- .../data/mysql/es-ES/mandatory/sample_notices.sql | 115 ++++++++++++++- .../mysql/fr-CA/obligatoire/sample_notices.sql | 114 ++++++++++++++- .../mysql/fr-FR/1-Obligatoire/sample_notices.sql | 115 ++++++++++++++- installer/data/mysql/it-IT/necessari/notices.sql | 115 ++++++++++++++- .../mysql/nb-NO/1-Obligatorisk/sample_notices.sql | 115 ++++++++++++++- .../data/mysql/pl-PL/mandatory/sample_notices.sql | 115 ++++++++++++++- .../data/mysql/ru-RU/mandatory/sample_notices.sql | 115 ++++++++++++++- .../data/mysql/uk-UA/mandatory/sample_notices.sql | 115 ++++++++++++++- installer/data/mysql/updatedatabase.pl | 121 ++++++++++++++++ .../prog/en/modules/cataloguing/addbiblio.tt | 2 +- .../prog/en/modules/members/printfeercpt.tt | 52 +------ .../prog/en/modules/members/printinvoice.tt | 54 +------ .../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 1 + members/printfeercpt.pl | 31 ++-- members/printinvoice.pl | 22 ++- ..._elastic_search.pl => rebuild_elasticsearch.pl} | 148 +++++++++++++++----- 22 files changed, 1453 insertions(+), 207 deletions(-) rename misc/search_tools/{rebuild_elastic_search.pl => rebuild_elasticsearch.pl} (60%) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 10 19:17:10 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 May 2019 17:17:10 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v18.11.00-1485-gb5a031b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via b5a031b45dc8c43088074685af4cb14ac582869c (commit) via 4806b0ff4f4e351b860833f7c7b471927d3a73d4 (commit) from 70dcc175c69446f51c4dab0be1b66f1f857a07c5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b5a031b45dc8c43088074685af4cb14ac582869c Author: Tomas Cohen Arazi Date: Fri May 10 11:52:34 2019 -0300 Bug 22053: (QA follow-up) Fix tests This patch makes the tests enable the plugins that are required for them. Otherwise unexpected failures can happen Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens commit 4806b0ff4f4e351b860833f7c7b471927d3a73d4 Author: Nick Clemens Date: Fri May 10 16:56:50 2019 +0000 Bug 22053: Compiled CSS Signed-off-by: Nick Clemens ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 2 +- t/db_dependent/ImportBatch.t | 3 ++- t/db_dependent/Koha/Template/Plugin/KohaPlugins.t | 14 ++++++++++++-- 3 files changed, 15 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 10 20:00:57 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 May 2019 18:00:57 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v18.11.00-1507-gb5b64e7 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via b5b64e7900fd61bd525409ee869deafde7b8c50a (commit) via 63a8e27f2e087b698e986e026dc9fa511b2afbfe (commit) via 3ef397125f92dde918a0745f44f047ccf6a98d84 (commit) via 0b6537f5b842b258d91a63ba5e7d57a3c47c7974 (commit) via 48a5c0b20249c17210df4ec1e9f146094aebc5e8 (commit) via fa643aa253f179933f07c05250d52ab47d37d667 (commit) via a404b314b2787f223348158bcbab4a295d383396 (commit) via f792bf5c93c2d30970f338c1bc8c845aa4d79e49 (commit) via a59003bea1310a1126b59272d9abe687e1258e30 (commit) via 85b2bc8cd0737ba583e5e6f3585d69ac99d0671f (commit) via c892642d9f6ac3f342966e5ce71b6c8ed7937018 (commit) via 88eb0c5904462bb6cd1b38932b93470f7032f27d (commit) via 0d0d19ea7ed9c8d158b5b49a39891682c676c50c (commit) via cf80509386ccf3452c7fbb7c1741c115654ec4ea (commit) via 8f3d5fc3dc7da6d2733f2e9944835757736cc474 (commit) via b922579eca5a0af2a610cc42646bc20eb2ace9d3 (commit) via 73fd7e96986f6969bd6fbcb35eea9b40ee3073a5 (commit) via c91dbddaf568ee66bb66051a324bde5cadc7a33f (commit) via 594f7d64d0ee5610e73a34b3274f874e1f023509 (commit) via cf2cb32fecc4f5c7d5084074fa29049d33885cad (commit) via 795a95824dc85360b485b595e173f0fef9ac4d84 (commit) via 73def70232b8281d7f960a2a743d799432286f53 (commit) from b5a031b45dc8c43088074685af4cb14ac582869c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b5b64e7900fd61bd525409ee869deafde7b8c50a Author: Jonathan Druart Date: Fri May 10 12:32:23 2019 -0500 Bug 22433: Use Data::Dumper instead of Data::Printer Data::Printer is not in our deps Signed-off-by: Nick Clemens commit 63a8e27f2e087b698e986e026dc9fa511b2afbfe Author: Jonathan Druart Date: Thu May 9 13:04:38 2019 -0500 Bug 22433: Add debug statement to Transaction.t Hard to know what's going on here without more info. Adding this output may help to investigate more. Test plan: Make sure the tests still pass If it fails, please paste the output!! Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens commit 3ef397125f92dde918a0745f44f047ccf6a98d84 Author: Nick Clemens Date: Fri May 10 17:41:41 2019 +0000 Bug 5770: DBRev 18.12.00.073 Signed-off-by: Nick Clemens commit 0b6537f5b842b258d91a63ba5e7d57a3c47c7974 Author: Martin Renvoize Date: Wed May 1 18:58:23 2019 +0100 Bug 5770: (QA follow-up) Adapt for replyto handling The ReplyTo preferences allwo for libraries to setup various combinations of addresses for email headers to ensure correct mail delivery. This patch accounts for their configuration and use in the suggestions notifications Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens commit 48a5c0b20249c17210df4ec1e9f146094aebc5e8 Author: Martin Renvoize Date: Wed May 1 14:29:16 2019 +0100 Bug 5770: (QA follow-up) Move system preference to appropriate section The new sysprefs wher in the general admin section. I believe they are better placed within the acquisitions area. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens commit fa643aa253f179933f07c05250d52ab47d37d667 Author: Martin Renvoize Date: Wed May 1 12:56:05 2019 +0100 Bug 5770: (QA follow-up) Revert change to GetQueuedMessages Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens commit a404b314b2787f223348158bcbab4a295d383396 Author: Martin Renvoize Date: Wed May 1 14:14:38 2019 +0100 Bug 5770: (QA follow-up) Allow feature to be disable This patch adds 'None' to the available options for the feature so it may be disabled entirely (and sets that as default) Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens commit f792bf5c93c2d30970f338c1bc8c845aa4d79e49 Author: Nazl? ?etin Date: Tue Apr 30 16:17:54 2019 +0000 Bug 5770: Notify for new suggestion - sample notices Signed-off-by: Liz Rea Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens commit a59003bea1310a1126b59272d9abe687e1258e30 Author: Nazl? ?etin Date: Tue Apr 30 15:56:26 2019 +0000 Bug 5770: Unit test Signed-off-by: Liz Rea Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens commit 85b2bc8cd0737ba583e5e6f3585d69ac99d0671f Author: Nazl? ?etin Date: Tue Apr 30 15:53:20 2019 +0000 Bug 5770: New system pref for new suggestion email Signed-off-by: Liz Rea Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens commit c892642d9f6ac3f342966e5ce71b6c8ed7937018 Author: Nazl? ?etin Date: Tue Apr 30 15:50:43 2019 +0000 Bug 5770: Email librarian when purchase suggestion made Signed-off-by: Liz Rea Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens commit 88eb0c5904462bb6cd1b38932b93470f7032f27d Author: David Gustafsson Date: Fri Mar 23 17:32:30 2018 +0100 Bug 20485: Don't account for items timestamps when items not included If combining "--dont_export_items" and "--date" options in export_records.pl, don't include items modification/deletion timestamp in biblio query conditions. How to test: 1) Delete or modify a biblio item. 2) Run export_records.pl with "--dont_export_items" and "--date" options with a date value before item was deleted or modified, but after the biblio was modified. 3) The biblio for which an item was changed should not be included in the export. Sponsored-by: Gothenburg University Library Signed-off-by: Maryse Simard Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens commit 0d0d19ea7ed9c8d158b5b49a39891682c676c50c Author: Martin Renvoize Date: Fri May 3 10:51:02 2019 +0100 Bug 21662: (QA follow-up) Be consistent between history and contributors Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens commit cf80509386ccf3452c7fbb7c1741c115654ec4ea Author: Marcel de Rooy Date: Fri May 3 08:27:53 2019 +0000 Bug 21662: (QA follow-up) Minor corrections [1] Move doXulting and Universidad ORT Uruguay to Institutions. We do not mention the institution for each developer. [2] Removing Anonymous. [3] Adding the Bugzilla alias shantanoo as additional transliterated text. [4] Resolve typo Continious. [5] Removing three plural unused roles in about.tt. Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens commit 8f3d5fc3dc7da6d2733f2e9944835757736cc474 Author: Martin Renvoize Date: Thu May 2 10:42:57 2019 +0100 Bug 21662: (follow-up) Corrections to YAMP for incompatible format YAML::XS and YAML output incompatible (but both valid) YAML files Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens commit b922579eca5a0af2a610cc42646bc20eb2ace9d3 Author: Martin Renvoize Date: Thu May 2 08:44:09 2019 +0100 Bug 21662: (follow-up) Embelish contributor details Add details to the 'non-commiters' in the contributors list. Information gratefully recieved from Chris Cormack Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens commit 73fd7e96986f6969bd6fbcb35eea9b40ee3073a5 Author: Martin Renvoize Date: Thu May 2 08:03:23 2019 +0100 Bug 21662: (follow-up) Drop YAML::XS, use YAML I mistakenly left us using YAML::XS when we don't already depend upon it. YAML is a sufficent alternative that we do already require. Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens commit c91dbddaf568ee66bb66051a324bde5cadc7a33f Author: Martin Renvoize Date: Fri Apr 26 09:24:58 2019 +0100 Bug 21662: Other history correction Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens commit 594f7d64d0ee5610e73a34b3274f874e1f023509 Author: Martin Renvoize Date: Thu Apr 11 13:35:22 2019 +0100 Bug 21662: Use contributors.yaml for contributors list Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens commit cf2cb32fecc4f5c7d5084074fa29049d33885cad Author: Martin Renvoize Date: Fri Oct 26 11:27:23 2018 +0100 Bug 21662: Add Contributors.yaml file Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens commit 795a95824dc85360b485b595e173f0fef9ac4d84 Author: Martin Renvoize Date: Fri Oct 26 10:13:39 2018 +0100 Bug 21662: Update history.txt Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens commit 73def70232b8281d7f960a2a743d799432286f53 Author: Martin Renvoize Date: Fri Oct 26 08:20:49 2018 +0100 Bug 21662: Make history.txt whitespace consistent Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens ----------------------------------------------------------------------- Summary of changes: C4/Letters.pm | 6 +- C4/Suggestions.pm | 52 +- Koha.pm | 2 +- about.pl | 41 +- docs/contributors.yaml | 1882 ++++++++++++++++++++ docs/history.txt | 1296 +++++++------- .../data/mysql/de-DE/mandatory/sample_notices.sql | 26 + .../data/mysql/en/mandatory/sample_notices.sql | 26 + .../data/mysql/es-ES/mandatory/sample_notices.sql | 26 + .../mysql/fr-CA/obligatoire/sample_notices.sql | 26 + .../mysql/fr-FR/1-Obligatoire/sample_notices.sql | 26 + installer/data/mysql/it-IT/necessari/notices.sql | 26 + .../mysql/nb-NO/1-Obligatorisk/sample_notices.sql | 26 + .../data/mysql/pl-PL/mandatory/sample_notices.sql | 26 + .../data/mysql/ru-RU/mandatory/sample_notices.sql | 26 + installer/data/mysql/sysprefs.sql | 2 + .../data/mysql/uk-UA/mandatory/sample_notices.sql | 27 +- installer/data/mysql/updatedatabase.pl | 41 + koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 418 +---- .../en/modules/admin/preferences/acquisitions.pref | 13 +- misc/export_records.pl | 40 +- t/db_dependent/SIP/Transaction.t | 5 +- t/db_dependent/Suggestions.t | 133 +- 23 files changed, 3149 insertions(+), 1043 deletions(-) create mode 100644 docs/contributors.yaml hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 10 21:29:58 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 May 2019 19:29:58 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v18.11.00-1520-g31684a4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 31684a426be4dcdf75a06f1f15fcfc73726fa6ae (commit) via 814dedb537ee0c569c7b8b7a1faa6c0ff44c4520 (commit) via b60230dccba64f7b6d5519bf735899953fbe2255 (commit) via 775701a15a737705ae3cf063cefd96b47165ed9f (commit) via 581d2edd449e125de97e6950e857086742a4ab84 (commit) via 164caa7eeb7b4475e7832ecdca9eb561bd4e5aee (commit) via 8b7342a823582462798bf2115d2f2e9897485184 (commit) via ca605455c24c032a389cbe0d3388f90620501c3b (commit) via 917a506ffc983f63d9541c862180916bb2adc0a0 (commit) via f550977f73997371bdbac3d6e68b66294b4eb677 (commit) via 0c02332600d430e77c4cc3dc62f9996c4375d55f (commit) via 6270a0150fb331a3e6a3a0ba23af0d3a1915d5f9 (commit) via ef44634a8d980bef8c77b6cd5724493e23513458 (commit) from b5b64e7900fd61bd525409ee869deafde7b8c50a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 31684a426be4dcdf75a06f1f15fcfc73726fa6ae Author: Nick Clemens Date: Fri May 10 19:05:38 2019 +0000 Bug 21411: DBRev 18.12.00.074 Signed-off-by: Nick Clemens commit 814dedb537ee0c569c7b8b7a1faa6c0ff44c4520 Author: Katrin Fischer Date: Tue May 7 08:11:56 2019 +0000 Bug 21411: (QA follow-up) Fix permission checks on admin page and menu Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit b60230dccba64f7b6d5519bf735899953fbe2255 Author: Nick Clemens Date: Wed May 1 11:27:05 2019 +0000 Bug 21411: (follow-up) Clean up for QA Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit 775701a15a737705ae3cf063cefd96b47165ed9f Author: Liz Rea Date: Tue Apr 30 14:21:31 2019 +0000 Bug 21411: (QA follow-up) fix tests Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit 581d2edd449e125de97e6950e857086742a4ab84 Author: Nick Clemens Date: Tue Apr 23 11:17:27 2019 +0000 Bug 21411: Address QA concerns Move to admin Add a permission Remove descriptions from table Clean up template Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit 164caa7eeb7b4475e7832ecdca9eb561bd4e5aee Author: Nick Clemens Date: Mon Mar 4 11:40:17 2019 -0500 Bug 21411: (follow-up) Missing filters and unused variable POD warnings from QA tool are false positives (basic functionsn POD not needed) Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit 8b7342a823582462798bf2115d2f2e9897485184 Author: Nick Clemens Date: Mon Mar 4 11:23:31 2019 -0500 Bug 21411: Advanced cataloging editor - rancor - Allow configuration of Keyboard This patch allows for redfining the keyboard shortcuts used in rancor. For now these are set globally (per instance) Ctrl-S is a codemirror setting and cannot be altered To test: 1 - Apply patches 2 - update database 3 - Load the advanced cataloging editor 4 - Click the "Keyboard shortcuts" button 5 - Ensure the list looks correct 6 - Note that 'Ctrl-S' note sit cannot be remapped 7 - Note the 'Redefine shortcuts' link at the top of the menu 8 - Confirm all the listed shortcuts work as expected 9 - Click the 'Redefine' link 10 - Ensure current mappings load correctly 11 - Read explanation and verify it makes sense 12 - Remap some functions 13 - Return to the cataloging editor 14 - Confirm your mappings work Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit ca605455c24c032a389cbe0d3388f90620501c3b Author: Owen Leonard Date: Mon May 6 13:07:17 2019 +0000 Bug 22856: Show SQL code button should trigger CodeMirror view This patch adds CodeMirror syntax highlighting to the SQL view which can be shown on the report results page by clicking the "Show SQL code" button. To test, apply the patch and run any SQL report. On the report results page, click the "Show SQL button." The SQL should be displayed with CodeMirror syntax highlighting. Test toggling the SQL code view on and off to confirm that the CodeMirror highlighting continues to work correctly. Signed-off-by: Barton Chittenden Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit 917a506ffc983f63d9541c862180916bb2adc0a0 Author: Jonathan Druart Date: Tue Sep 12 15:26:27 2017 -0300 Bug 19302: Send koha::objects to C4::Reserves::IsAvailableForItemLevelRequest Almost everywhere we call IsAvailableForItemLevelRequest we already have a Koha::Patron and Koha::Item object. It makes sense to use them to avoid a refetch Test plan: It would be good to test this patch on top of 19300 and 19301 and make sure everything works as expected Signed-off-by: Hayley Mapley Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens commit f550977f73997371bdbac3d6e68b66294b4eb677 Author: Liz Rea Date: Thu Mar 21 16:16:19 2019 +0000 Bug 20436: (QA follow up) - reference and typo fixes Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens commit 0c02332600d430e77c4cc3dc62f9996c4375d55f Author: Kyle M Hall Date: Fri Mar 16 11:15:12 2018 +0000 Bug 20436: Add ability to specify itemtypes for longoverdue.pl It would be nice if we could filter long overdues based on itemtype the same way we can already filter based on borrower category code. Test Plan: 1) Set up a number of overdues of various itemtypes 2) Run longoverdue.pl with --list-itemtypes to show itemtypes 3) Run longoverdue.pl with --itemtype to verify it only operates on that itemtype 4) Run longoverdue.pl with multiple --itemtype switches, verify it only operates on those itemtypes 5) Run longoverdue.pl with --skip-itemtype to verify it does not operate on that itemtype 6) Run longoverdue.pl with multiple --skip-itemtype switches, verify that it does not operate on those itemtypes Signed-off-by: Jesse Maseto Signed-off-by: Liz Rea Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens commit 6270a0150fb331a3e6a3a0ba23af0d3a1915d5f9 Author: Katrin Fischer Date: Sun Jan 20 01:35:34 2019 +0000 Bug 21312: (QA follow-up) Ease translation I've changed the language a bit from "account locked out" to "account locked" and split it up to ease translation. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens commit ef44634a8d980bef8c77b6cd5724493e23513458 Author: Marcel de Rooy Date: Wed Oct 10 16:53:30 2018 +0200 Bug 21312: Show lockout on Patrons form Just what the title says :) Specifically: moremember.pl Test plan: Check if you see the locked message on the patron form for an account that has been locked. (Either login_attempts<0 or >FailedLoginAttempts) Signed-off-by: Marcel de Rooy Signed-off-by: Jose-Mario Monteiro-Santos Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 20 ++--- C4/ILSDI/Services.pm | 2 +- C4/Reserves.pm | 28 +++---- Koha.pm | 2 +- Koha/{City.pm => KeyboardShortcut.pm} | 6 +- .../OverDriveInfos.pm => KeyboardShortcuts.pm} | 20 ++--- Koha/Schema/Result/KeyboardShortcut.pm | 65 ++++++++++++++++ admin/adveditorshortcuts.pl | 78 +++++++++++++++++++ cataloguing/editor.pl | 8 ++ installer/data/mysql/kohastructure.sql | 11 +++ .../keyboard_shortcuts.sql} | 30 +++++--- installer/data/mysql/updatedatabase.pl | 36 +++++++++ installer/data/mysql/userpermissions.sql | 1 + .../lib/koha/cateditor/marc-editor.js | 48 ++++++------ koha-tmpl/intranet-tmpl/prog/css/reports.css | 6 ++ .../intranet-tmpl/prog/en/includes/admin-menu.inc | 5 +- .../prog/en/includes/cateditor-ui.inc | 3 + .../prog/en/includes/keyboard_shortcuts.inc | 15 ++++ .../intranet-tmpl/prog/en/includes/permissions.inc | 5 ++ .../prog/en/modules/admin/admin-home.tt | 6 +- .../prog/en/modules/admin/adveditorshortcuts.tt | 75 ++++++++++++++++++ .../prog/en/modules/cataloguing/editor.tt | 56 +++----------- .../prog/en/modules/members/moremember.tt | 8 ++ .../en/modules/reports/guided_reports_start.tt | 16 +++- members/moremember.pl | 1 + misc/cronjobs/longoverdue.pl | 80 ++++++++++++++++++-- opac/opac-reserve.pl | 2 +- reserve/request.pl | 2 +- .../Holds/DisallowHoldIfItemsAvailable.t | 62 +++++++-------- .../{Acquisition/Funds.t => KeyboardShortcuts.t} | 32 ++++---- t/db_dependent/Reserves.t | 20 ++--- 31 files changed, 555 insertions(+), 194 deletions(-) copy Koha/{City.pm => KeyboardShortcut.pm} (87%) copy Koha/{Library/OverDriveInfos.pm => KeyboardShortcuts.pm} (80%) create mode 100644 Koha/Schema/Result/KeyboardShortcut.pm create mode 100755 admin/adveditorshortcuts.pl copy installer/data/mysql/{nb-NO/1-Obligatorisk/message_transport_types.sql => mandatory/keyboard_shortcuts.sql} (57%) create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/keyboard_shortcuts.inc create mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/admin/adveditorshortcuts.tt copy t/db_dependent/Koha/{Acquisition/Funds.t => KeyboardShortcuts.t} (53%) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 10 22:26:05 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 May 2019 20:26:05 +0000 Subject: [koha-commits] main Koha release repository branch 18.05.x updated. v18.05.11-67-gf9001c9 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.05.x has been updated via f9001c9bdb4f58352e2b5fffbad720a50f2abd68 (commit) from 81bb1b55c27c3dfcab5a04af3257d5e93bcc6177 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f9001c9bdb4f58352e2b5fffbad720a50f2abd68 Author: Katrin Fischer Date: Sun Apr 7 18:23:32 2019 +0000 Bug 22090: Add missing information to cash register CSV file Some information was missing from the CSV export file of the Cash register report: manager surname, patron surname and payment notes. Also pretties up the column headers a bit and makes the sequence between GUI and CSV export match. To test: - Make sure you have some fines and fees and payments in your system - Make a search with the Cash register report - Export results as CSV - Proof read hader line and make sure contents match headings - Verify first name and surname are shown for manager and patron - Verify notes show up Signed-off-by: Michal Denar Signed-off-by: Chris Cormack Signed-off-by: Nick Clemens (cherry picked from commit 1a2572915b4bf4a11b3a65c3a65e506610263a03) Signed-off-by: Martin Renvoize (cherry picked from commit 5469ae4eea46416410bddaef4934aa1db6e767f9) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: .../prog/en/includes/csv_headers/reports/cash_register_stats.tt | 2 +- .../intranet-tmpl/prog/en/modules/reports/cash_register_stats.tt | 2 +- reports/cash_register_stats.pl | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 10 22:35:00 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 May 2019 20:35:00 +0000 Subject: [koha-commits] main Koha release repository branch 18.05.x updated. v18.05.11-68-g1e8c73b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.05.x has been updated via 1e8c73b93319132581c16e0a48abc37144e13fee (commit) from f9001c9bdb4f58352e2b5fffbad720a50f2abd68 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1e8c73b93319132581c16e0a48abc37144e13fee Author: Owen Leonard Date: Fri Apr 12 11:04:06 2019 +0000 Bug 18011: Enrollment period date on patron category can be set in the past without any error/warning messages This patch modifies the patron category edit form so that the enrollment period datepicker widget cannot be used to select a date in the past. The element had a "datepicker" class, which triggers a default datepicker configuration. This was overriding the configuration in the page-specific JavaScript file. To test, apply the patch and go to Administration -> Patron categories. Click the "Enrollment period -> Until date" field and verify that dates before today are disabled. Signed-off-by: Pierre-Marc Thibault Signed-off-by: Chris Cormack Signed-off-by: Nick Clemens (cherry picked from commit 34c835ed141a3b4758ad77e5b72f30e83d57024f) Signed-off-by: Martin Renvoize (cherry picked from commit 89f0c3a9da9d009e7fea0c76f706676078dc9860) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 10 23:09:20 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 May 2019 21:09:20 +0000 Subject: [koha-commits] main Koha release repository branch 18.05.x updated. v18.05.11-69-g9e4ac56 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.05.x has been updated via 9e4ac5634a09011b35e1cedc8f5e832a53e95263 (commit) from 1e8c73b93319132581c16e0a48abc37144e13fee (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9e4ac5634a09011b35e1cedc8f5e832a53e95263 Author: Katrin Fischer Date: Thu Apr 4 01:36:47 2019 +0000 Bug 22154: Fix search for Braille from Advanced search page When you do an advanced search and choose the Format subtype Braille, it looks for l-format:fk, but that is not the right code for Braille. fk does not exist. It should be fb for Tactile material/Braille OR tc for Text/Braille To test: 0) Catalog 2 records, one with 007 tc and another with fb Use value builder to verify both are for Braille. 1) In Administration > System preferences, make sure 'Subtypes' is checked in either OpacAdvSearchMoreOptions or OpacAdvSearchOptions 2) Go to Advanced search 3) If necessary, click on 'More options' 4) In the 'Subtype limits' section, choose 'Braille' from the 'Format' drop-down menu 5) Click on 'Search' 6) Verify both records were found Signed-off-by: Michal Denar Signed-off-by: Chris Cormack Signed-off-by: Nick Clemens (cherry picked from commit 44a39929afc60ddda3182a93197ced098044a12d) Signed-off-by: Martin Renvoize (cherry picked from commit f53fe14580549266b098a303c4be389fee505b60) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 10 23:18:11 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 May 2019 21:18:11 +0000 Subject: [koha-commits] main Koha release repository branch 18.05.x updated. v18.05.11-71-g370168d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.05.x has been updated via 370168d2095b6dbff2c69a94974315a1b9faf7c6 (commit) via 76fb88431031c9e86d88978663189f2af27ba1d7 (commit) from 9e4ac5634a09011b35e1cedc8f5e832a53e95263 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 370168d2095b6dbff2c69a94974315a1b9faf7c6 Author: Katrin Fischer Date: Sun Apr 14 03:13:01 2019 +0000 Bug 21172: Remove obsolete framework parameter from GetMarcFromKohaField Signed-off-by: Nick Clemens (cherry picked from commit 2a9b9a526bb3e1c73e09cbee499a2debcab74ee5) Signed-off-by: Martin Renvoize (cherry picked from commit b1d1d5ab915b8b664e0ac321876a414655762ee4) Signed-off-by: Lucas Gass commit 76fb88431031c9e86d88978663189f2af27ba1d7 Author: Jonathan Druart Date: Tue Aug 7 17:06:41 2018 -0300 Bug 21172: Remove warning from addbiblio.pl Argument "01e" isn't numeric in numeric ne (!=) at /home/vagrant/kohaclone/cataloguing/addbiblio.pl line 507. A tagfield can be 01e and so raise a warning is compared with == or != This patch also fixes few inconsistencies: - tagfield for items.itemnumber must be retrieved with GetMarcFromKohaField (to support other marcflavours) - do not use $_ - loop only once on $usedTagsLib Test plan: For devs only, read the code and confirm the changes make sense. Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens (cherry picked from commit f3afec0587f4baeff580e153ea592020d4d36be3) Signed-off-by: Martin Renvoize (cherry picked from commit 1ed01089db28deb6f9689bbb64c30ee805559dbf) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: cataloguing/addbiblio.pl | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 10 23:24:01 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 May 2019 21:24:01 +0000 Subject: [koha-commits] main Koha release repository branch 18.05.x updated. v18.05.11-72-g34a3077 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.05.x has been updated via 34a3077a14f2a19cc69391ba84a137dd79b2ce94 (commit) from 370168d2095b6dbff2c69a94974315a1b9faf7c6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 34a3077a14f2a19cc69391ba84a137dd79b2ce94 Author: Owen Leonard Date: Tue Apr 16 16:34:13 2019 +0000 Bug 22716: Use gender-neutral pronouns in system preference descriptions This patch makes a few corrections to the .pref files which provide descriptions for system preferences. Language like "him or her" is replaced with "they/them" pronouns. To test, apply the patch and check the following preferences: - OPACFineNoRenewalsBlockAutoRenew - ExpireReservesMaxPickUpDelayCharge - PatronSelfRegistrationVerifyByEmail Signed-off-by: Lisette Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens (cherry picked from commit 4b3eb99ad6cd9fc8e9bac6627c38bd16600aa38a) Signed-off-by: Martin Renvoize (cherry picked from commit 4c44dfd8fe2ee4e64acb283ef25f6cd21c969927) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/admin/preferences/circulation.pref | 15 +++++++++++++-- .../prog/en/modules/admin/preferences/opac.pref | 2 +- 2 files changed, 14 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue May 14 00:05:56 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 13 May 2019 22:05:56 +0000 Subject: [koha-commits] main Koha release repository branch 18.05.x updated. v18.05.11-73-g3662049 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.05.x has been updated via 3662049d146d7e584f9afa43accbbea38fbca92b (commit) from 34a3077a14f2a19cc69391ba84a137dd79b2ce94 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3662049d146d7e584f9afa43accbbea38fbca92b Author: Aleisha Amohia Date: Tue Feb 19 01:36:14 2019 +0000 Bug 22365: Removing warn when accessing Log Viewer To test: Go to Tools -> Log Viewer and confirm the warn no longer shows after applying the patch. Sponsored-by: Catalyst IT Signed-off-by: Michal Denar Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens (cherry picked from commit 8adb2f8003e25f6fe8cc78506a823a618a837fa1) Signed-off-by: Martin Renvoize (cherry picked from commit 8bd263601499ae1aa13587b37c62dfa27b4c7def) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: tools/viewlog.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue May 14 14:25:46 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 14 May 2019 12:25:46 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.05-21-gd617065 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via d617065162df47ffaf35fc192f260c702fd62602 (commit) from 41f9ad2fd548d2f204c946b33a0cb56110f42c2f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d617065162df47ffaf35fc192f260c702fd62602 Author: Nick Clemens Date: Mon May 13 15:07:41 2019 +0000 Bug 22895: (bug 22650 follow-up) Correct itemnumber call in placerequest.pl Backport of 22650 makes an object call to an item hashref retrieved by get item: 94 if ( CanItemBeReserved($borrower->{'borrowernumber'}, $item->itemnumber, $branch)->{status} eq 'OK' ) { Should be $item->{itemnumber} To test: 1 - Try to place an item level hold 2 - It fails 3 - Aply patch 4 - Try again 5 - It works! Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: reserve/placerequest.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue May 14 20:40:13 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 14 May 2019 18:40:13 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v18.11.00-1531-g735d23c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 735d23c299669b40d3e3e2a4fe21b88fc6cca00f (commit) via 6692800794cbf403e8be8c8062608b60148c0d56 (commit) via 6d1b7ff27eb2d53d637c169c7132a66d546c0124 (commit) via a7419482c1e08b4de2dd707e4a7c4b3185ebb771 (commit) via d4b503aa14b9297889c2a5b6f18fd2132c7bb304 (commit) via b90bbc125969dc0048dde2ec37531a6ef6cd2b36 (commit) via 5c81d986212b480d9b491e46b3fb4498c0eb2c2c (commit) via 49a6aac8b6d8fd13999638f5a6ae4d4481dbf304 (commit) via f21ebad7d298f25e44771e5833d1d1d4d6d8f777 (commit) via af1067f3d466cf3bd32c4747c4a00dd7542c1fe0 (commit) via f45fe692b14f45300456327bc74fd0a0872dff75 (commit) from 31684a426be4dcdf75a06f1f15fcfc73726fa6ae (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 735d23c299669b40d3e3e2a4fe21b88fc6cca00f Author: Jonathan Druart Date: Wed May 8 16:37:40 2019 -0500 Bug 11853: Add tests Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit 6692800794cbf403e8be8c8062608b60148c0d56 Author: Jonathan Druart Date: Wed May 8 16:37:50 2019 -0500 Bug 11853: Allow to clear the date of birth at the OPAC A patron is not able to clear their date of birth. When cleared tt is set to NULL in DB which means, for the patron's modifications feature, that nothing has been changed. Test plan: 0/ Do not apply the patch 1/ Edit your personal details at the OPAC 2/ Add a date of birth 3/ On the staff interface, approve the modification request => OK it is updated 4/ Edit your personal details and clear the date of birth 5/ On the staff interface => KO the table display is wrong, nothing is marked has changed 6/ Approve the modification requiest => KO it has not been cleared 7/ Apply the patch and repeat 1 to 6 and confirm that the behaviors are now correct. Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit 6d1b7ff27eb2d53d637c169c7132a66d546c0124 Author: Owen Leonard Date: Fri May 10 13:24:39 2019 +0000 Bug 22881: Trying to clear search history via the navbar X doesn't clear any searches This patch undoes a mistake introduced in my patch for Bug 21479. A "preventDefault()" was added to the search history clear button by mistake. The "confirmDelete" function only works if the default action of the link is allowed to complete. To test you must have the EnableOpacSearchHistory system preference enabled. Apply the patch and log into the OPAC as a patron who has a search history. Click the "X" link in the header next to the "Search history" link. Confirm that you want to clear your search history. The page should refresh. Navigate to your account -> Your search history to confirm that your search history has been cleared. Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit a7419482c1e08b4de2dd707e4a7c4b3185ebb771 Author: Jonathan Druart Date: Sun May 12 19:26:41 2019 -0500 Bug 22893: Embed contributors.yaml for debian packages Like history.txt we need to tell some debian/ files to copy contributors.yaml Also pick it for the `make install` process (Makefile.PL) Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens commit d4b503aa14b9297889c2a5b6f18fd2132c7bb304 Author: Jonathan Druart Date: Sun May 12 19:22:54 2019 -0500 Bug 22893: Do not crash if contributors.yaml does not exist Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens commit b90bbc125969dc0048dde2ec37531a6ef6cd2b36 Author: Nick Clemens Date: Tue May 14 18:15:54 2019 +0000 Bug 22899: DBRev 18.12.00.075 Signed-off-by: Nick Clemens commit 5c81d986212b480d9b491e46b3fb4498c0eb2c2c Author: Martin Renvoize Date: Tue May 14 13:21:55 2019 +0100 Bug 22899: (QA follow-up) Change accessor name This patch changes pending_hold to has_pending_hold to signify that we're returning a boolean and not a Koha::Hold object. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens commit 49a6aac8b6d8fd13999638f5a6ae4d4481dbf304 Author: Martin Renvoize Date: Tue May 14 13:17:01 2019 +0100 Bug 22899: (QA follow-up) Ensure constraint is created Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens commit f21ebad7d298f25e44771e5833d1d1d4d6d8f777 Author: Nick Clemens Date: Mon May 13 20:09:05 2019 +0000 Bug 22899: Add pending_hold method to Koha::Item To test: 1 - Enable course reserves 2 - Create a course 3 - Add an item to the course 4 - Attempt to view the course on the OPAC 5 - Internal Server Error 6 - Apply patch 7 - Add an item to the holds queue by placing a hold and running holds queue builder or: INSERT INTO tmp_holdsqueue (itemnumber) VALUES (###); 8 - View the course page, note item appears 'Pending hold' 9 - Remove the holdsqueue line 10 - View the course page, note item appears 'Available' 11 - prove -v t/db_dependent/Koha/Item.t Signed-off-by: Hayley Mapley I see Jonathan's comments about small improvements, but will sign off as everything works as expected here. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens commit af1067f3d466cf3bd32c4747c4a00dd7542c1fe0 Author: Nick Clemens Date: Mon May 13 20:08:06 2019 +0000 Bug 22899: Database update Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens commit f45fe692b14f45300456327bc74fd0a0872dff75 Author: Jonathan Druart Date: Sat May 4 12:33:34 2019 -0400 Bug 22849: Do not share data (Mana) without agreement A couple of things wrong in serials/subscription-add.pl 1. 447 if ( defined( $query->param('mana_id') ) ) { It's always defined, you wanted to test with "" 2. 375 if ( (C4::Context->preference('Mana')) and ( grep { $_ eq "subscription" } split(/,/, C4::Context->preference('AutoShareWithMana'))) ){ Mana == 2 == let me think about it => I am not expecting to reach Koha::SharedContent in that case So we are sharing data whereas the library did not decide yet! Test plan: You need to be familiar you Mana to test this patch. JD: I did not test this patch Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens ----------------------------------------------------------------------- Summary of changes: C4/Items.pm | 2 +- C4/XSLT.pm | 4 +- Koha.pm | 2 +- Koha/Item.pm | 14 +++++++ Koha/Patron/Modification.pm | 14 ++++--- Koha/Patron/Modifications.pm | 6 ++- Koha/Schema/Result/Item.pm | 19 ++++++++- Koha/Schema/Result/TmpHoldsqueue.pm | 29 ++++++++++++-- Makefile.PL | 1 + about.pl | 5 ++- debian/koha-common.docs | 1 + debian/rules | 2 +- installer/data/mysql/kohastructure.sql | 4 +- installer/data/mysql/updatedatabase.pl | 19 +++++++++ koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 16 +++++--- .../bootstrap/en/includes/item-status.inc | 2 +- .../bootstrap/en/includes/opac-bottom.inc | 3 +- serials/subscription-add.pl | 4 +- t/db_dependent/Items.t | 4 +- t/db_dependent/Koha/Item.t | 23 ++++++++++- t/db_dependent/Koha/Patron/Modifications.t | 41 +++++++++++++++++++- 21 files changed, 183 insertions(+), 32 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue May 14 23:56:11 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 14 May 2019 21:56:11 +0000 Subject: [koha-commits] main Koha release repository branch 18.05.x updated. v18.05.11-75-gce7cb18 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.05.x has been updated via ce7cb18847d5273409dfd30317070338e100a954 (commit) via e4a7a7f05d20b122b70174ecfe2fa90b4745c3b8 (commit) from 3662049d146d7e584f9afa43accbbea38fbca92b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ce7cb18847d5273409dfd30317070338e100a954 Author: Fr?d?ric Demians Date: Mon Dec 3 18:02:03 2018 +0100 Bug 21937: Syspref autoBarcode annual doesn't increment properly barcode This patch fix the barcode annual builder. The test should pass. Signed-off-by: Michal Denar Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens (cherry picked from commit 31ace6a9347a8260532f6cc50d55fc36f87f1b44) Signed-off-by: Martin Renvoize (cherry picked from commit 9109d862a08a53dd6328eed902dd4ed45de7f673) Signed-off-by: Lucas Gass commit e4a7a7f05d20b122b70174ecfe2fa90b4745c3b8 Author: Fr?d?ric Demians Date: Mon Dec 3 18:27:08 2018 +0100 Bug 21937: Add test to show autoBarcode annual increment bug This patch show the issue. If the DB contains a barcode (not auto attributed by Koha) which begin with the year used to generate automatically a new one, there may be a 'collision'. prove -v t/db_dependent/Barcodes_ValueBuilder.t Signed-off-by: Michal Denar Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens (cherry picked from commit 7262bc066784247b12ce7f25c390498086e1d72b) Signed-off-by: Martin Renvoize (cherry picked from commit a85edfb2be449cf65691d1e4b32080310ac7aad2) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/Barcodes/ValueBuilder.pm | 2 +- .../prog/en/modules/admin/preferences/cataloguing.pref | 4 ++-- t/db_dependent/Barcodes_ValueBuilder.t | 6 ++++++ 3 files changed, 9 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 15 00:44:15 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 14 May 2019 22:44:15 +0000 Subject: [koha-commits] main Koha release repository branch 18.05.x updated. v18.05.11-76-ga2d45b1 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.05.x has been updated via a2d45b1cb4a65ba29f3047fa34ae75fad3a4144b (commit) from ce7cb18847d5273409dfd30317070338e100a954 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a2d45b1cb4a65ba29f3047fa34ae75fad3a4144b Author: Marcel de Rooy Date: Fri Apr 19 06:49:48 2019 +0000 Bug 22735: Resolve internal server error on missing item type Trivial fix, similar to opac-detail, applied to ISBD and MARC detail. Test plan: Enable ArticleRequests pref. Make sure you have a biblio with no item type in 942c. (Perhaps you need to make 942c not mandatory temporarily and save a biblio record without this field being filled.) If you are logged in, log out. Go to MARC or ISBD detail page. No crash anymore? Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens (cherry picked from commit b78bd2faec703bb7d7c750dbc1070ba2449f29a9) Signed-off-by: Martin Renvoize (cherry picked from commit b99fbdd8fc85beb989a51142bb531673748bc344) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: opac/opac-ISBDdetail.pl | 10 ++++++++++ opac/opac-MARCdetail.pl | 10 ++++++++++ 2 files changed, 20 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 15 14:31:36 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 15 May 2019 12:31:36 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v18.11.00-1559-g5cc8fb5 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 5cc8fb5e07eab457f998c42e1b7cd22c387e647b (commit) via 3b037a77362c5a425fd2b551ddf0280eda38e733 (commit) via d9248c8802c4009ca99209da549447d13d6f686f (commit) via 9bc386a98fa51617ef927d4133ae310e17676dd5 (commit) via f00d909220ebde5162335e255e4ba938a9563bff (commit) via 97ec0a2e4bf76cf2e67a7ddbd463d9942a4fe383 (commit) via 5410186f6829fc4b74a845e8954bd7eea3f19862 (commit) via ecb12104ffc7284089a1c8134ca8811e99e7419c (commit) via 35d00030ceb572822979300a5291356a32427a16 (commit) via 3a3057545c56f4f1a41fcd7643265204844cd2d3 (commit) via 6e8ecb8c6c8cf5d5188d2ad138e4fdbd8f395b3e (commit) via 43047ee734e2b6b650e43710a712390433cbb2bd (commit) via 3f817f056bb7373abbd08882132c230f41057717 (commit) via 8d53fae9494b50c0cf2dcc98b18982b0d8fc416f (commit) via 9f18afa7b34574cd872c94ee366a8d3e75085413 (commit) via 700b7dfa09e38c074cebbbb5caac64e031d5c0d5 (commit) via 92ab7f66eb5371596d8c46e56f4fdb503ed5d81c (commit) via 7799f4ddd1f1fe111081dc3695c9038fa500e961 (commit) via 7bed2a3fe61ff605b636e292e73b96947de23b29 (commit) via c265fcc476bc4d4fc74d5a23c0d5ef8ef21650b2 (commit) via 0bf785018d18c3c9a548c87ce2769032e181d348 (commit) via bc0d3e1a34e78fcf00f512e2bdff73c9de0bea8c (commit) via b41f215bfedbae0898a9291d2f14e2a3dd560049 (commit) via 256b134a94e83b7072b5891a2d60f0e08e813583 (commit) via 0759811ab629e8215ee270b4ec920f71d9bc0d25 (commit) via e8e7ea352ef237555ee4d47c98feb879f3eb9e31 (commit) via 3b877cc240eb44acafaef1ed5f287eae3dfb7baa (commit) via 57b027734e3c1a315cd11fedbf94771fa8381a30 (commit) from 735d23c299669b40d3e3e2a4fe21b88fc6cca00f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5cc8fb5e07eab457f998c42e1b7cd22c387e647b Author: Arthur Suzuki Date: Fri Apr 19 11:48:31 2019 +0200 Bug 22742: ILS-DI - Fix datetime format returned by RenewLoan Test plan : Call RenewLoan a few times and check the date returned is correct (minute wise). Signed-off-by: Arthur Bousquet Signed-off-by: Bin Wen https://bugs.koha-community.org/show_bug.cgi?id=22472 Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit 3b037a77362c5a425fd2b551ddf0280eda38e733 Author: Katrin Fischer Date: Sat May 11 21:33:32 2019 +0000 Bug 22889: Fix typos librairies and libaries Fixes 2 typos. Test: - Review patch Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens commit d9248c8802c4009ca99209da549447d13d6f686f Author: Colin Campbell Date: Thu May 9 11:32:25 2019 +0100 Bug 22875: Document verbose option in import_patrons Docs did not state that verbose can be repeated or that you need more than 1 repetition to see lines that have failed To test: - Run ./import_patrons.pl -h - Verify the additional documentation for -v is shown. Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit 9bc386a98fa51617ef927d4133ae310e17676dd5 Author: Jonathan Druart Date: Sun May 12 19:46:58 2019 -0500 Bug 22892: Remove warning from rebuild_es if --processes not passed Use of uninitialized value $processes in numeric lt (<) at misc/search_tools/rebuild_elasticsearch.pl line 199. We want the number of processes to be set to 1 by default, and then assign it to $slice_count Test plan: Run the script with and without --processes and confirm that the warning went away. Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit f00d909220ebde5162335e255e4ba938a9563bff Author: Katrin Fischer Date: Sun May 12 00:34:03 2019 +0200 Bug 22886: Missing space between fields from Keyword to MARC mapping in cataloguing search If you have multiple subfields mapped to the 'subtitle' keyword, those fields will show up without separating space. To test: - Add 3 subtitle entries in Keyword to MARC mapping for a framework - 245 b - 245 c - 245 h - Edit a record, make sure the framework matches, add: - 245 b, c, h - Search for it in cataloguing search (not catalog!) - Verify the subtitle fields show, but are all concatenated - Apply patch - Search again and verify the display is improved with a separating space Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens commit 97ec0a2e4bf76cf2e67a7ddbd463d9942a4fe383 Author: Jonathan Druart Date: Sat May 11 10:23:28 2019 -0500 Bug 20514: Use streetnumber when searching for patrons by address The streetnumber field was ignored from the search. Test plan: Create a patron with streetnumber="12", address="rue des cerisiers" Search for patrons using the search field "street address" using: 12 rue des cerisiers => Without this patch the patron will not be returned => With this patch applied it will! Signed-off-by: Hayley Mapley Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit 5410186f6829fc4b74a845e8954bd7eea3f19862 Author: Jonathan Druart Date: Wed May 1 21:05:30 2019 -0400 Bug 22781: Correctly filter the emails Ho, another bug! The email was not correctly filtered. Test plan: Use the evil string for an email, do a search. => Notice that without this patch the results never show up Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit ecb12104ffc7284089a1c8134ca8811e99e7419c Author: Jonathan Druart Date: Wed May 1 20:54:02 2019 -0400 Bug 22781: Does not double filter address Ho, a bug! Some fields in the address where double filtered. Test plan: Use the evil strings in the address field and do a search, you will see double html encoded characters without this patch. Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit 35d00030ceb572822979300a5291356a32427a16 Author: Jonathan Druart Date: Wed May 1 20:29:05 2019 -0400 Bug 22781: Test patron's info filtering The patron's data was not correctly escaped actually. Test plan: This is a good value for the whole patchset: fir's"tname \123 ? use it for a patron's firstname, then do a search Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit 3a3057545c56f4f1a41fcd7643265204844cd2d3 Author: Jonathan Druart Date: Wed May 1 20:28:04 2019 -0400 Bug 22781: Escape cardnumber, category's description, library's name and dateexpiry This will fix the previous failure. Note that other fields like borrowernumber, Price escaped values, integers, etc. could be escaped the same way but will be useless (save polar bears). Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit 6e8ecb8c6c8cf5d5188d2ad138e4fdbd8f395b3e Author: Jonathan Druart Date: Wed May 1 20:28:55 2019 -0400 Bug 22781: Add tests Test plan: Apply only this patch => The tests will fail, the library's name is not correctly escaped. Note: This applies for the whole patchset, when the tests fail you will need to remove the patrons added by the tests with the following SQL query: delete from borrowers where surname like "test_patron_%"; We are expecting END to be called even if something goes wrong, but DESTROY must be used instead. This will be fixed separately, on its own bug report. Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit 43047ee734e2b6b650e43710a712390433cbb2bd Author: Martin Renvoize Date: Mon Feb 11 14:04:01 2019 +0000 Bug 22225: Correctly use invoiceincgst over listincgst Mistakenly, we were looking at listincgst in the templates but using invoiceincgst in the scripts. This patch rectifies that by switching to use invoiceincgst in the templates too. Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit 3f817f056bb7373abbd08882132c230f41057717 Author: Jonathan Druart Date: Sat May 4 12:31:05 2019 -0400 Bug 22850: Do no longer use set_userenv in tests (SharedContent.t) Since bug 21817 we should use the mock_userenv subroutine instead. Test plan: The tests must pass after this patch Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit 8d53fae9494b50c0cf2dcc98b18982b0d8fc416f Author: Jonathan Druart Date: Fri May 10 12:27:40 2019 -0500 Bug 22878: Do not pass layout_id on creating a layout Attempting to create a patron card layout with mysql strict mode on gives the following error: DBD::mysql::st execute failed: Incorrect integer value: '' for column 'layout_id' at row 1 Test plan: - Turn on sql_strict_modes - Create a new patron card => Must success with this patch applied Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit 9f18afa7b34574cd872c94ee366a8d3e75085413 Author: Jonathan Druart Date: Fri May 10 12:27:34 2019 -0500 Bug 22878: Add tests Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit 700b7dfa09e38c074cebbbb5caac64e031d5c0d5 Author: Aleisha Amohia Date: Mon Apr 29 03:14:35 2019 +0000 Bug 7862: Preventing warns when creating a notice To reproduce warns: 1) Go to Tools -> Notices & slips 2) Create a new notice of any module Notice these warns: Use of uninitialized value $code in regexp compilation at /home/vagrant/kohaclone/tools/letter.pl line 265. Use of uninitialized value $code in regexp compilation at /home/vagrant/kohaclone/tools/letter.pl line 265. Use of uninitialized value $code in regexp compilation at /home/vagrant/kohaclone/tools/letter.pl line 265. CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_svc_letters_get line 50, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_svc_letters_get line 50, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. 3) Create a new notice of the Circulation module Notice this additional warn: Use of uninitialized value $code in pattern match (m//) at /home/vagrant/kohaclone/tools/letter.pl line 258. To test: 4) Apply patch and refresh page 5) Run steps 1-3 again and confirm no warns show Sponsored-by: Catalyst IT Signed-off-by: Maryse Simard Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens commit 92ab7f66eb5371596d8c46e56f4fdb503ed5d81c Author: Nick Clemens Date: Wed May 15 12:10:15 2019 +0000 Bug 22836: (follow-up) improve test message Signed-off-by: Nick Clemens commit 7799f4ddd1f1fe111081dc3695c9038fa500e961 Author: Jonathan Druart Date: Thu May 2 21:04:54 2019 -0400 Bug 22836: (follow-up) Bug 22478: (QA follow-up) Make test consistent with variable name One occurrence was missing. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit 7bed2a3fe61ff605b636e292e73b96947de23b29 Author: Jonathan Druart Date: Thu May 2 20:49:45 2019 -0400 Revert "Bug 22478: (QA follow-up) Handle category in opac-shelves like a boolean" This reverts commit 375dd35d5354d46c4c16f534494b123ce370c3f4. https://bugs.koha-community.org/show_bug.cgi?id=22836 Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit c265fcc476bc4d4fc74d5a23c0d5ef8ef21650b2 Author: Jonathan Druart Date: Thu May 2 20:49:37 2019 -0400 Revert "Bug 22478: (QA follow-up) Update tests to check for any script tags" This reverts commit d9b3b90849fd95d296b73b330c4e32ff018c81a5. https://bugs.koha-community.org/show_bug.cgi?id=22836 Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit 0bf785018d18c3c9a548c87ce2769032e181d348 Author: Jonathan Druart Date: Sun May 12 11:51:28 2019 -0500 Bug 22891: (bug 21206 follow-up) Fix RenewHold (ILS-DI) From commit 31c29fd31f557306233e6a2936148a5bb10b89a1 Bug 21206: Replace C4::Items::GetItem A missing 'unless' test made RenewHold return prematurely: return $issue; should have been return unless $issue; Test plan: Hit /cgi-bin/koha/ilsdi.pl?service=RenewLoan&patron_id=51&item_id=756 With different situations: 1. Item is checked out to the patron 2. Item is not checked out to the patron 3. Item does not exist 4. Patron does not exist Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens commit bc0d3e1a34e78fcf00f512e2bdff73c9de0bea8c Author: Jonathan Druart Date: Sun May 12 11:48:11 2019 -0500 Bug 22891: Add tests Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens commit b41f215bfedbae0898a9291d2f14e2a3dd560049 Author: Jonathan Druart Date: Fri May 10 11:11:14 2019 -0500 Bug 22812: Use Koha::Subscription in NewSubscription Starting to write tests I realize that we are going to add too much specific logic which is already handled in Koha::Object->store. The easiest and safe way is to use it :) Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit 256b134a94e83b7072b5891a2d60f0e08e813583 Author: Jonathan Druart Date: Mon May 6 13:50:54 2019 -0500 Bug 22812: Fix GROUP BY in checkrouting On the way, let fix this error DBD::mysql::st execute failed: Mixing of GROUP columns (MIN(),MAX(),COUNT(),...) with no GROUP columns is illegal if there is no GROUP BY clause [for Statement "SELECT count(routingid) routingids FROM subscription LEFT JOIN subscriptionroutinglist Test plan: Create a routing list, search for subscriptions In the action list you should see "Edit routing list (1)" or "New routing list" Signed-off-by: Liz Rea Signed-off-by: Marcel de Rooy Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit 0759811ab629e8215ee270b4ec920f71d9bc0d25 Author: Jonathan Druart Date: Mon May 6 13:50:26 2019 -0500 Bug 22812: Add tests for checkrouting Signed-off-by: Liz Rea Signed-off-by: Marcel de Rooy Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit e8e7ea352ef237555ee4d47c98feb879f3eb9e31 Author: Jonathan Druart Date: Mon May 6 13:34:19 2019 -0500 Bug 22812: Fix new subscription with strict sql modes With sql_strict_modes turned on, if you try to create a new subscription you will get: Incorrect integer value: '' for column '$INT_COLUMN' at row 1 Signed-off-by: Liz Rea Signed-off-by: Marcel de Rooy Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit 3b877cc240eb44acafaef1ed5f287eae3dfb7baa Author: Jonathan Druart Date: Mon May 6 11:55:32 2019 -0500 Bug 22713: Remove unecessary $replacementprice var Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit 57b027734e3c1a315cd11fedbf94771fa8381a30 Author: Nick Clemens Date: Thu Apr 25 16:23:22 2019 +0000 Bug 22713: Pass replacement price in to order if defined by MarcItemFieldsToOrder To test: 1 - Have AcqCreateItems set to 'On ordering' (or set in a basket) 2 - Define MARCItemFieldsToOrder homebranch: 975$a holdingbranch: 975$b itype: 975$y nonpublic_note: 975$x public_note: 975$z loc: 975$c ccode: 970$c notforloan: 975$7 uri: 975$u copyno: 975$n quantity: 975$q budget_code: 975$h price: 975$g replacementprice: 975$p 3 - Have a marc record with some order info defined as above, including a replacementprice 4 - Add to basket - > from a new file 5 - Don't check for duplicates, add the order 6 - Note the order has no replacementprice, but the item does 7 - Close basket, receive order, do not enter a new replacement price 8 - Note the items replacement price is clear 9 - Apply patch 10 - Repeat 11 - Note when order added to basket it has a replacement price 12 - Note when order is received the replacement price is populated and passed into item correctly Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens ----------------------------------------------------------------------- Summary of changes: C4/Creators/Layout.pm | 1 + C4/ILSDI/Services.pm | 6 +- C4/Serials.pm | 74 ++++++++----- C4/Utils/DataTables/Members.pm | 2 +- acqui/addorderiso2709.pl | 4 +- acqui/orderreceive.pl | 1 - .../prog/en/includes/serials-toolbar.inc | 2 +- .../prog/en/modules/acqui/orderreceive.tt | 4 +- .../prog/en/modules/admin/admin-home.tt | 2 +- .../prog/en/modules/cataloguing/addbooks.tt | 2 +- .../en/modules/members/tables/members_results.tt | 18 +-- misc/import_patrons.pl | 6 + misc/search_tools/rebuild_elasticsearch.pl | 2 +- opac/opac-shelves.pl | 1 - svc/letters/get | 4 +- t/Patroncards_Layout.t | 14 --- t/db_dependent/ILSDI_Services.t | 37 ++++++- t/db_dependent/Koha/SharedContent.t | 29 ++--- t/db_dependent/Patroncards.t | 34 ++++++ t/db_dependent/Serials.t | 17 ++- t/db_dependent/selenium/patrons_search.t | 117 ++++++++++++++++++++ t/db_dependent/selenium/regressions.t | 5 +- tools/letter.pl | 11 +- virtualshelves/shelves.pl | 1 - 24 files changed, 300 insertions(+), 94 deletions(-) delete mode 100755 t/Patroncards_Layout.t create mode 100755 t/db_dependent/Patroncards.t create mode 100644 t/db_dependent/selenium/patrons_search.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 15 19:21:40 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 15 May 2019 17:21:40 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v18.11.00-1566-g9515ee6 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 9515ee6bf05236d189f5318bc33a5469e45acc5b (commit) via 3bcde5d91fb19e30ee14c8ecc82c8f3985a22c2c (commit) via f2d886c3b3513ace62f428d4e42d4d144a689172 (commit) via 3d3944cba3ce11af8ecc7feeee4ad0fef737f069 (commit) via 71018d4cca41c9e9eeab1d8980af4f7253a728a8 (commit) via 990cc79ef085b74764cd68875fc0fd6dc6da8ffe (commit) via 1114ba929f0aa634d6f9c10d8931c2ca25871c7d (commit) from 5cc8fb5e07eab457f998c42e1b7cd22c387e647b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9515ee6bf05236d189f5318bc33a5469e45acc5b Author: Owen Leonard Date: Thu May 9 17:52:26 2019 +0000 Bug 22657: (QA follow-up) Restore previous version of regex This patch restores the previous version of the regular expression which parses the OPACSuggestionMandatoryFields system preference value. Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens commit 3bcde5d91fb19e30ee14c8ecc82c8f3985a22c2c Author: Owen Leonard Date: Wed Mar 20 18:58:02 2019 +0000 Bug 22657: Remove JavaScript from OPAC suggestion validation of required fields This patch modifies the OPAC suggestion form so that it doesn't require JavaScript for form validation. This change doesn't alter the behavior of the form for users but does fit with the general goal of progressive enhancement for the OPAC. The patch adds "required" labels to required fields to better identify required fields. To test, apply the patch and make sure there are required fields specified in the OPACSuggestionMandatoryFields system preference. - Log in to the OPAC and go to Your purchase suggestions -> New purchase suggestion. - Verify that the fields specified in OPACSuggestionMandatoryFields are highlighted and marked "required." - Verify that you can't submit the form without filling out these fields. Signed-off-by: Bin Wen Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens commit f2d886c3b3513ace62f428d4e42d4d144a689172 Author: Katrin Fischer Date: Sat May 11 21:01:51 2019 +0000 Bug 4833: (QA follow-up) Add budgetname to SearchSuggestion This patch adds the budgetname to the return of SearchSuggestion to improve performance. To test: - Same test plan as for the first patch - Verify fund names show in the table - Run t/db_dependent/Suggestions.t Signed-off-by: Nick Clemens commit 3d3944cba3ce11af8ecc7feeee4ad0fef737f069 Author: Katrin Fischer Date: Mon Mar 11 07:47:43 2019 +0000 Bug 4833: Show acq information when selecting suggestion for order When adding an order line to a basket using the 'from a suggestion' feature, the list of accepted suggestions doesn't show any information from the acquisition are of the suggestions. This patch adds new columns to the list for: - library - fund - price - quantity - total To test: - Create several suggestions with - Empty acq values - A specific library, any library - Set acq values (fund, price, quantity) - Accept your suggestions - Create a new basket/order - Add an order line from accepted suggestions - Verify the list displays nicely with the new columns - Verify filters etc. still work ok Signed-off-by: S?verine QUEUNE Signed-off-by: S?verine QUEUNE Signed-off-by: Chris Cormack Signed-off-by: Nick Clemens commit 71018d4cca41c9e9eeab1d8980af4f7253a728a8 Author: Katrin Fischer Date: Sat May 11 12:59:33 2019 +0000 Bug 21651: (QA follow-up) Remove remaining obsolete file from German web installer Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit 990cc79ef085b74764cd68875fc0fd6dc6da8ffe Author: Jonathan Druart Date: Wed Oct 24 17:02:39 2018 -0300 Bug 21651: Always insert notice templates related tables The 3 following files must be mandatory and insert during the install process: - message_transport_types.sql - sample_notices_message_attributes.sql - sample_notices_message_transports.sql They insert data for - message_transport_types - message_attributes - message_transport_type Otherwise the notice templates (table letter) will fail. Moreover these 3 files are identical and are put in several places (1 per language) to make the description translatable (using the related .txt file) Test plan: - Install Koha in English and in another language - Select all the sample data => They all should be inserted correctly Signed-off-by: Hayley Mapley Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit 1114ba929f0aa634d6f9c10d8931c2ca25871c7d Author: Jonathan Druart Date: Wed Oct 24 16:34:46 2018 -0300 Bug 21651: Remove language specific sql file for notice templates related tables This patch removes the 3 following files for the different languages - message_transport_types.sql - sample_notices_message_attributes.sql - sample_notices_message_transports.sql They were all identical, only one version is kept in installer/data/mysql/mandatory .txt files are removed as well They inserted data for - message_transport_types - message_attributes - message_transport_type Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens ----------------------------------------------------------------------- Summary of changes: C4/Installer.pm | 22 +-- C4/Suggestions.pm | 4 +- acqui/newordersuggestion.pl | 2 + .../de-DE/mandatory/message_transport_types.txt | 2 - .../sample_notices_message_attributes.sql | 8 - .../sample_notices_message_attributes.txt | 2 - .../sample_notices_message_transports.txt | 2 - .../mysql/en/mandatory/message_transport_types.sql | 7 - .../mysql/en/mandatory/message_transport_types.txt | 2 - .../sample_notices_message_attributes.txt | 1 - .../sample_notices_message_transports.sql | 20 --- .../sample_notices_message_transports.txt | 2 - .../es-ES/mandatory/message_transport_types.sql | 7 - .../es-ES/mandatory/message_transport_types.txt | 1 - .../sample_notices_message_attributes.sql | 9 -- .../sample_notices_message_attributes.txt | 1 - .../sample_notices_message_transports.sql | 20 --- .../sample_notices_message_transports.txt | 2 - .../fr-CA/obligatoire/message_transport_types.sql | 8 - .../fr-CA/obligatoire/message_transport_types.txt | 1 - .../sample_notices_message_attributes.sql | 8 - .../sample_notices_message_attributes.txt | 1 - .../sample_notices_message_transports.sql | 20 --- .../sample_notices_message_transports.txt | 1 - .../1-Obligatoire/message_transport_types.sql | 7 - .../1-Obligatoire/message_transport_types.txt | 2 - .../sample_notices_message_attributes.sql | 9 -- .../sample_notices_message_attributes.txt | 3 - .../sample_notices_message_transports.sql | 20 --- .../sample_notices_message_transports.txt | 1 - .../it-IT/necessari/message_transport_types.sql | 11 -- .../it-IT/necessari/message_transport_types.txt | 2 - .../sample_notices_message_attributes.sql | 11 -- .../sample_notices_message_attributes.txt | 2 - .../sample_notices_message_transports.sql | 24 --- .../sample_notices_message_transports.txt | 1 - .../mandatory/message_transport_types.sql | 0 .../sample_notices_message_attributes.sql | 0 .../sample_notices_message_transports.sql | 0 .../1-Obligatorisk/message_transport_types.sql | 28 ---- .../1-Obligatorisk/message_transport_types.txt | 1 - .../sample_notices_message_attributes.sql | 9 -- .../sample_notices_message_attributes.txt | 1 - .../sample_notices_message_transports.sql | 20 --- .../sample_notices_message_transports.txt | 1 - .../pl-PL/mandatory/message_transport_types.sql | 7 - .../pl-PL/mandatory/message_transport_types.txt | 1 - .../sample_notices_message_attributes.sql | 9 -- .../sample_notices_message_attributes.txt | 1 - .../sample_notices_message_transports.sql | 20 --- .../sample_notices_message_transports.txt | 1 - .../ru-RU/mandatory/message_transport_types.sql | 9 -- .../ru-RU/mandatory/message_transport_types.txt | 2 - .../sample_notices_message_attributes.sql | 11 -- .../sample_notices_message_attributes.txt | 1 - .../sample_notices_message_transports.sql | 20 --- .../sample_notices_message_transports.txt | 1 - .../uk-UA/mandatory/message_transport_types.sql | 9 -- .../uk-UA/mandatory/message_transport_types.txt | 1 - .../sample_notices_message_attributes.sql | 15 -- .../sample_notices_message_attributes.txt | 1 - .../sample_notices_message_transports.sql | 20 --- .../sample_notices_message_transports.txt | 1 - .../prog/en/modules/acqui/newordersuggestion.tt | 24 +++ .../bootstrap/en/modules/opac-suggestions.tt | 162 +++++++++++++++----- opac/opac-suggestions.pl | 4 +- t/db_dependent/Suggestions.t | 10 +- 67 files changed, 179 insertions(+), 457 deletions(-) delete mode 100644 installer/data/mysql/de-DE/mandatory/message_transport_types.txt delete mode 100644 installer/data/mysql/de-DE/mandatory/sample_notices_message_attributes.sql delete mode 100644 installer/data/mysql/de-DE/mandatory/sample_notices_message_attributes.txt delete mode 100644 installer/data/mysql/de-DE/mandatory/sample_notices_message_transports.txt delete mode 100644 installer/data/mysql/en/mandatory/message_transport_types.sql delete mode 100644 installer/data/mysql/en/mandatory/message_transport_types.txt delete mode 100644 installer/data/mysql/en/mandatory/sample_notices_message_attributes.txt delete mode 100644 installer/data/mysql/en/mandatory/sample_notices_message_transports.sql delete mode 100644 installer/data/mysql/en/mandatory/sample_notices_message_transports.txt delete mode 100644 installer/data/mysql/es-ES/mandatory/message_transport_types.sql delete mode 100644 installer/data/mysql/es-ES/mandatory/message_transport_types.txt delete mode 100644 installer/data/mysql/es-ES/mandatory/sample_notices_message_attributes.sql delete mode 100644 installer/data/mysql/es-ES/mandatory/sample_notices_message_attributes.txt delete mode 100644 installer/data/mysql/es-ES/mandatory/sample_notices_message_transports.sql delete mode 100644 installer/data/mysql/es-ES/mandatory/sample_notices_message_transports.txt delete mode 100644 installer/data/mysql/fr-CA/obligatoire/message_transport_types.sql delete mode 100644 installer/data/mysql/fr-CA/obligatoire/message_transport_types.txt delete mode 100644 installer/data/mysql/fr-CA/obligatoire/sample_notices_message_attributes.sql delete mode 100644 installer/data/mysql/fr-CA/obligatoire/sample_notices_message_attributes.txt delete mode 100644 installer/data/mysql/fr-CA/obligatoire/sample_notices_message_transports.sql delete mode 100644 installer/data/mysql/fr-CA/obligatoire/sample_notices_message_transports.txt delete mode 100644 installer/data/mysql/fr-FR/1-Obligatoire/message_transport_types.sql delete mode 100644 installer/data/mysql/fr-FR/1-Obligatoire/message_transport_types.txt delete mode 100644 installer/data/mysql/fr-FR/1-Obligatoire/sample_notices_message_attributes.sql delete mode 100644 installer/data/mysql/fr-FR/1-Obligatoire/sample_notices_message_attributes.txt delete mode 100644 installer/data/mysql/fr-FR/1-Obligatoire/sample_notices_message_transports.sql delete mode 100644 installer/data/mysql/fr-FR/1-Obligatoire/sample_notices_message_transports.txt delete mode 100644 installer/data/mysql/it-IT/necessari/message_transport_types.sql delete mode 100644 installer/data/mysql/it-IT/necessari/message_transport_types.txt delete mode 100644 installer/data/mysql/it-IT/necessari/sample_notices_message_attributes.sql delete mode 100644 installer/data/mysql/it-IT/necessari/sample_notices_message_attributes.txt delete mode 100644 installer/data/mysql/it-IT/necessari/sample_notices_message_transports.sql delete mode 100644 installer/data/mysql/it-IT/necessari/sample_notices_message_transports.txt rename installer/data/mysql/{de-DE => }/mandatory/message_transport_types.sql (100%) rename installer/data/mysql/{en => }/mandatory/sample_notices_message_attributes.sql (100%) rename installer/data/mysql/{de-DE => }/mandatory/sample_notices_message_transports.sql (100%) delete mode 100644 installer/data/mysql/nb-NO/1-Obligatorisk/message_transport_types.sql delete mode 100644 installer/data/mysql/nb-NO/1-Obligatorisk/message_transport_types.txt delete mode 100644 installer/data/mysql/nb-NO/1-Obligatorisk/sample_notices_message_attributes.sql delete mode 100644 installer/data/mysql/nb-NO/1-Obligatorisk/sample_notices_message_attributes.txt delete mode 100644 installer/data/mysql/nb-NO/1-Obligatorisk/sample_notices_message_transports.sql delete mode 100644 installer/data/mysql/nb-NO/1-Obligatorisk/sample_notices_message_transports.txt delete mode 100644 installer/data/mysql/pl-PL/mandatory/message_transport_types.sql delete mode 100644 installer/data/mysql/pl-PL/mandatory/message_transport_types.txt delete mode 100644 installer/data/mysql/pl-PL/mandatory/sample_notices_message_attributes.sql delete mode 100644 installer/data/mysql/pl-PL/mandatory/sample_notices_message_attributes.txt delete mode 100644 installer/data/mysql/pl-PL/mandatory/sample_notices_message_transports.sql delete mode 100644 installer/data/mysql/pl-PL/mandatory/sample_notices_message_transports.txt delete mode 100644 installer/data/mysql/ru-RU/mandatory/message_transport_types.sql delete mode 100644 installer/data/mysql/ru-RU/mandatory/message_transport_types.txt delete mode 100644 installer/data/mysql/ru-RU/mandatory/sample_notices_message_attributes.sql delete mode 100644 installer/data/mysql/ru-RU/mandatory/sample_notices_message_attributes.txt delete mode 100644 installer/data/mysql/ru-RU/mandatory/sample_notices_message_transports.sql delete mode 100644 installer/data/mysql/ru-RU/mandatory/sample_notices_message_transports.txt delete mode 100644 installer/data/mysql/uk-UA/mandatory/message_transport_types.sql delete mode 100644 installer/data/mysql/uk-UA/mandatory/message_transport_types.txt delete mode 100644 installer/data/mysql/uk-UA/mandatory/sample_notices_message_attributes.sql delete mode 100644 installer/data/mysql/uk-UA/mandatory/sample_notices_message_attributes.txt delete mode 100644 installer/data/mysql/uk-UA/mandatory/sample_notices_message_transports.sql delete mode 100644 installer/data/mysql/uk-UA/mandatory/sample_notices_message_transports.txt hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 16 03:31:30 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 May 2019 01:31:30 +0000 Subject: [koha-commits] main Koha release repository branch 18.05.x updated. v18.05.11-77-gc0c0303 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.05.x has been updated via c0c0303fcc76788fd55d2fc5319dde9ccda008f1 (commit) from a2d45b1cb4a65ba29f3047fa34ae75fad3a4144b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c0c0303fcc76788fd55d2fc5319dde9ccda008f1 Author: Jonathan Druart Date: Wed Apr 24 00:09:44 2019 -0400 Bug 22762: Fix items.collection display on receiving Caused by commit 31c29fd31f557306233e6a2936148a5bb10b89a1 Bug 21206: Replace C4::Items::GetItem The log says: The method Koha::Item->collection is not covered by tests! It has highlighted an older problem: Since commit bb1e9c500c810402c64436c53bcc00ffb9a0b857 Bug 17248 - Koha::AuthorisedValues - Remove GetKohaAuthorisedValueLib the "Collection code" is not filled correctly (items.collection vs items.ccode). Test plan: - Set acqcreateitem to "when placing an order" - Receive an order with items => The "Collection code" column must be filled with the items.ccode value - Edit an item - Change the collection code value => The "Collection code" column must be filled with the new value Signed-off-by: Martin Renvoize (cherry picked from commit 49c99ced88af8d9d17d433c69322b862d30aee8a) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: acqui/orderreceive.pl | 2 +- catalogue/getitem-ajax.pl | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 16 03:36:13 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 May 2019 01:36:13 +0000 Subject: [koha-commits] main Koha release repository branch 18.05.x updated. v18.05.11-78-g377af59 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.05.x has been updated via 377af593c44b3c903c493fbe6dca62149ddf70ce (commit) from c0c0303fcc76788fd55d2fc5319dde9ccda008f1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 377af593c44b3c903c493fbe6dca62149ddf70ce Author: Fridolin Somers Date: Wed Apr 17 13:58:57 2019 +0200 Bug 22723: Correct syntax error on confess call in Koha/MetadataRecord/Authority.pm In Koha/MetadataRecord/Authority.pm the call to confess is missing string quotes. It may generates this error : Can't locate object method "confess" via package "Empty String at /usr/share/perl5/MARC/File/XML.pm line 448. " (perhaps you forgot to load "Empty String at /usr/share/perl5/MARC/File/XML.pm line 448. "?) at /home/koha/src/Koha/MetadataRecord/Authority.pm line 186. Simply missing double quotes. Also missing use Carp to call confess. Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens (cherry picked from commit 4e2c74fced685db861a78fc1aa151dd35ad0d5f2) Signed-off-by: Martin Renvoize (cherry picked from commit 4863e59c5798fda6883c354eeb5096d4609e42bd) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: Koha/MetadataRecord/Authority.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 16 03:41:10 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 May 2019 01:41:10 +0000 Subject: [koha-commits] main Koha release repository branch 18.05.x updated. v18.05.11-79-gaacb4e6 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.05.x has been updated via aacb4e6bb9e6cc0539134a0389e1babe540eb142 (commit) from 377af593c44b3c903c493fbe6dca62149ddf70ce (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit aacb4e6bb9e6cc0539134a0389e1babe540eb142 Author: Tomas Cohen Arazi Date: Fri Apr 19 09:28:35 2019 -0300 Bug 22739: Test SelfCheckInTimeout <> 0, not just defined On sci-main.pl the preference value is tested for 'defined'. This patch tests it is different than empty string too. This was causing a JavaScript syntax error, that made it display a wrong message. To test: 1 - Blank the syspref SelfCheckInTimeout 2 - Attempt to checkin something via sci => FAIL: The 'Your request included no check-ins.' message is printed. 3 - Apply this patch, reload the sci-main.pl page 4 - Attempt to checkin something via sci => SUCCESS: The UI correctly stacks the scanned barcodes 5 - Sign off :-D Signed-off-by: Liz Rea Signed-off-by: Kyle M Hall Signed-off-by: Nick Clemens (cherry picked from commit c1949cda9b2847bc6ecf7e1dbc07990c4055b69a) Signed-off-by: Martin Renvoize (cherry picked from commit 1269f7d6c7712b3c9115824660d5f12933ba6462) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: opac/sci/sci-main.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 17 17:12:57 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 17 May 2019 15:12:57 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v18.11.00-1580-g0ed7cc0 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 0ed7cc0c577720f262110427ebe4d0922aa6ca99 (commit) via fc3f34afbe05442d82237abca7c8999945186791 (commit) via ec08e5af1202eb01cb70b0f922767f02eaeaedc3 (commit) via 1edd15129c965fc85772484b1cd011817ffaa764 (commit) via 6c7cf0111a2c231b5888bb0884fd217432539f1f (commit) via 06ccce11c1a9071b08973e2ab6930c39492f4d42 (commit) via 5578771047e7ddb072bcd6025933591bebd53e6d (commit) via 77e91f34fc782f2492a0d2315daeca145acfd5be (commit) via c07aaf8aca9d850a92727b0158680bccd15be505 (commit) via 5849613649010f182d2ec2a90e8ff51ad4d0b640 (commit) via 3690ee6513241bd855422ab7450866e246eff2d3 (commit) via 583fba977e18cbe4d1fad7a6609d6345095e9920 (commit) via 2ccc5dcdf124ff8275f58826c837fc55cfd8a9a1 (commit) via 52325a771a02b603e807c29d586fe44fabebb792 (commit) from 9515ee6bf05236d189f5318bc33a5469e45acc5b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0ed7cc0c577720f262110427ebe4d0922aa6ca99 Author: Martin Renvoize Date: Tue May 14 15:52:29 2019 +0100 Bug 21626: (QA follow-up) Remove duplicate roles The teams file contains all roles so we don't need to also list them in the contributors file. This patch removes them from contributors.yaml and relies only on the merging of teams. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens commit fc3f34afbe05442d82237abca7c8999945186791 Author: Martin Renvoize Date: Tue May 14 15:39:01 2019 +0100 Bug 21626: (QA follow-up) Embed teams.yaml for debian packages Like history.txt we need to tell some debian/ files to copy teams.yaml Also pick it for the `make install` process (Makefile.PL) Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens commit ec08e5af1202eb01cb70b0f922767f02eaeaedc3 Author: Martin Renvoize Date: Tue May 14 15:34:44 2019 +0100 Bug 21626: (QA follow-up) Don't crash on missing teams file Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens commit 1edd15129c965fc85772484b1cd011817ffaa764 Author: Martin Renvoize Date: Mon May 13 20:53:05 2019 +0100 Bug 21626: (follow-up) Template corrections for arrayref Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit 6c7cf0111a2c231b5888bb0884fd217432539f1f Author: Martin Renvoize Date: Mon May 13 20:11:45 2019 +0100 Bug 21626: Corrections to typos Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit 06ccce11c1a9071b08973e2ab6930c39492f4d42 Author: Martin Renvoize Date: Fri May 3 11:56:48 2019 +0100 Bug 21626: Add release dates to team Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit 5578771047e7ddb072bcd6025933591bebd53e6d Author: Martin Renvoize Date: Fri May 3 10:10:04 2019 +0100 Bug 21626: (follow-up) Performance Improvement Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit 77e91f34fc782f2492a0d2315daeca145acfd5be Author: Martin Renvoize Date: Fri May 3 06:41:44 2019 +0100 Bug 21626: (follow-up) Changes based on feedback Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit c07aaf8aca9d850a92727b0158680bccd15be505 Author: Martin Renvoize Date: Thu Apr 11 14:33:30 2019 +0100 Bug 21626: Use teams.yaml for teams section Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit 5849613649010f182d2ec2a90e8ff51ad4d0b640 Author: Martin Renvoize Date: Thu Apr 11 14:17:54 2019 +0100 Bug 21626: Add teams.yaml to /docs Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit 3690ee6513241bd855422ab7450866e246eff2d3 Author: Jonathan Druart Date: Thu May 16 12:22:13 2019 -0500 Bug 22928: Add selenium tests Signed-off-by: Liz Rea Signed-off-by: Kyle M Hall Signed-off-by: Nick Clemens commit 583fba977e18cbe4d1fad7a6609d6345095e9920 Author: Jonathan Druart Date: Thu May 16 09:42:32 2019 -0500 Bug 22928: (bug 20226 follow-up) Fix display of 'Update child to adult' link Looks like it is caused by bug 20226, however I am pretty sure it works when I wrote the patch. [% IF Categories.scalar.all(category_type => 'A').count > 0 %] is always wrong. It must be, either: [% IF Categories.all(category_type => 'A').size > 0 %] or [% SET adult_categories = Categories.scalar.all(category_type => 'A') %] [% IF adult_categories.count > 0 %] In the first case we are getting an array whereas in the later, a Koha::Patrons which is preferable. Test plan (from 20226): - Remove all your adult categories (categories.category_type='A') - Create a patron with a child category - Try to update to adult category => The entry does no longer appears! (This is a change in the behaviour) - Create one adult category - Update to adult category => There is a JS confirmation message, if you accept the patron will be updated to the adult category - Create (at least) another adult category - Create another child - Update to adult category => No more confirmation message but a popup to select the adult category - Pick one => The patron has been updated to the adult category Signed-off-by: Liz Rea Signed-off-by: Kyle M Hall Signed-off-by: Nick Clemens commit 2ccc5dcdf124ff8275f58826c837fc55cfd8a9a1 Author: Marcel de Rooy Date: Fri May 17 08:35:20 2019 +0000 Bug 22930: (QA follow-up) Add two test descriptions No more than that ;) Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens commit 52325a771a02b603e807c29d586fe44fabebb792 Author: Jonathan Druart Date: Thu May 16 12:56:07 2019 -0500 Bug 22930: Make TestBuilder->build_object explodes if parameters are wrong This patch implements bug 15339 for build_object. We want it to warn if the call is wrong. Test plan: Make sure the tests are still returning green Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens ----------------------------------------------------------------------- Summary of changes: Makefile.PL | 1 + about.pl | 76 ++- debian/koha-common.docs | 1 + debian/rules | 2 +- docs/contributors.yaml | 573 ----------------- docs/teams.yaml | 660 ++++++++++++++++++++ .../intranet-tmpl/prog/en/includes/about-team.inc | 182 ++++++ .../prog/en/includes/members-toolbar.inc | 3 +- koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 125 +--- t/db_dependent/TestBuilder.t | 30 +- t/db_dependent/selenium/update_child_to_adult.t | 152 +++++ t/lib/TestBuilder.pm | 3 + 12 files changed, 1098 insertions(+), 710 deletions(-) create mode 100644 docs/teams.yaml create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/about-team.inc create mode 100644 t/db_dependent/selenium/update_child_to_adult.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 23 17:18:37 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 23 May 2019 15:18:37 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v18.11.00-1594-gb67462d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via b67462d471a54bf342295cbc5e46373d065bab7e (commit) via bb2459f12ed7c8151ae0690850ca5351d64c4aac (commit) via 6586762ff3a52da3316aec4f55ce3ecbdbd133b6 (commit) via d963a3854c962bda3361213f2ad8e7626311d20b (commit) via 189bde4a1d043a25a0eddcc07401b7946653c3b1 (commit) via 6ae2edb033ed7ebc2683026f42cf9400babd604b (commit) via 04d990c71d34d0c44999cfdf80e8379959d14de8 (commit) via 6cf717e6c9e377850674ad6462480884a047145b (commit) via 085cb4de51c528b6a50b60f591f6b5ac426efd6a (commit) via 53545ba739e1706da7f3e52c145f0f6c8bbfb18c (commit) via cbacf68d7fb554bd949e2f498c1eda86b34ef97f (commit) via 9532a3edeacd8fb3df67e8a01ed4e89069ffc017 (commit) via ae2f21e74dc68c305d88ba26f60282550e3c448b (commit) via fe053f0ee06508d1c6e2675dcadc535075900b6e (commit) from 0ed7cc0c577720f262110427ebe4d0922aa6ca99 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b67462d471a54bf342295cbc5e46373d065bab7e Author: Henry Bolshaw Date: Wed May 22 15:02:40 2019 +0000 Bug 22965: fixes typo on classification sources description on admin homepage Removed comma from description. Test plan: 1. Go to Admin homepage 2. Check Classification Sources description 3. Verify that comma after i.e. has gone removed Signed-off-by: Liz Rea Signed-off-by: Chris Cormack Signed-off-by: Nick Clemens commit bb2459f12ed7c8151ae0690850ca5351d64c4aac Author: Chris Cormack Date: Wed May 22 13:32:14 2019 +0000 Bug 22962: Punctuation error in RisExportAdditionalFields To test 1/ Go to systempreferences search for RisExportAdditionalFields 2/ See the extra , on the first line 3/ Apply the patch 4/ See it is fixed Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens commit 6586762ff3a52da3316aec4f55ce3ecbdbd133b6 Author: Josef Moravec Date: Tue Apr 23 10:37:10 2019 +0000 Bug 22746: Fix typos in add mana comment modals again Test plan: 1) Create subscription from Mana 2) On subscription detail page: report mistake > other a modal is shown it should be exactly 'Please enter a new commment (max 35 characters)' 3) The same in mana search results and in reports Signed-off-by: Owen Leonard Signed-off-by: Chris Cormack Signed-off-by: Nick Clemens commit d963a3854c962bda3361213f2ad8e7626311d20b Author: David Cook Date: Tue May 21 11:12:44 2019 +1000 Bug 15221: SIP server always sets the alert flag when item not returned The checked in response from the ACS always has the alert bit set to true, even when using the checked_in_ok option. This patch sets the alert bit to 0 when checked_in_ok is used and the item is checked in without a preceding checkout. To test: 0) Create patron in web interface with a cardnumber and userid of "staff" with a password that matches the account in SIPconfig.xml. Also set their branch to CPL (also matching SIPconfig.xml). 1) Create an item with a barcode of 'test' 2) Choose a patron to check out to and record their borrowernumber In one terminal: 3) cd to your git directory (e.g. /home/koha/koha) 4) perl ./C4/SIP/SIPServer.pm ~/koha-dev/etc/SIPconfig.xml In another terminal: 5) cd to your git directory (e.g. /home/koha/koha) 6) perl ./misc/sip_cli_emulator.pl -l CPL -su staff -sp --port=6001 --address=localhost --item test -m checkin --patron NOTE: You need to replace with the borrowernumber from Step 2, and with the password from Step 0. Before patch: koha at 9ec653ab82ce:~/koha$ perl ./misc/sip_cli_emulator.pl -l CPL -su staff -sp --port=6001 --address=localhost --item test -m checkin --patron Attempting socket connection to localhost:6001...connected! SEND: 9300CNstaff|COStaff1|CPCPL| READ: 941 Trying 'checkin' SEND: 09N20190521 00310320190521 003103APCPL|AOCPL|ABtest|AC|BIN| READ: 101YNY20190521 003106AOCPL|ABtest|AQCPL|AJTest| After patch: koha at 9ec653ab82ce:~/koha$ perl ./misc/sip_cli_emulator.pl -l CPL -su staff -sp --port=6001 --address=localhost --item test -m checkin --patron Attempting socket connection to localhost:6001...connected! SEND: 9300CNstaff|CO|CPCPL| READ: 941 Trying 'checkin' SEND: 09N20190521 01000020190521 010000APCPL|AOCPL|ABtest|AC|BIN| READ: 101YNN20190521 010004AOCPL|ABtest|AQCPL|AJTest| Signed-off-by: Liz Rea Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens commit 189bde4a1d043a25a0eddcc07401b7946653c3b1 Author: Jonathan Druart Date: Fri Dec 7 14:43:18 2018 -0300 Bug 21831: Allow move all fields even if destination field is different Tests exist in t/SimpleMARC.t to prove that it works and it is possible. I do not remember what I wrote this limitation. Signed-off-by: Jon Knight Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens commit 6ae2edb033ed7ebc2683026f42cf9400babd604b Author: Jonathan Druart Date: Thu May 16 14:07:25 2019 -0500 Bug 22917: Fix typo in another test file It looks safe to do it here and now. Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens commit 04d990c71d34d0c44999cfdf80e8379959d14de8 Author: Martin Renvoize Date: Thu May 16 16:55:16 2019 +0100 Bug 22917: Fix a typo in an output_pref call Due to a type in a call to output_pref (datenonly vs dateonly) we were comparing logactions within a minutes accuracy. Counting the logs for the day would be sufficient for the test ;) Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens commit 6cf717e6c9e377850674ad6462480884a047145b Author: Jonathan Druart Date: Wed May 15 19:46:48 2019 -0500 Bug 22917: Prevent Circulation.t if tests ran too slowly After bug 21213 we wanted to know why Circulation.t was failing randomly on a given test. Since it is pushed, it failed (at least) twice, with the same error: # Failed test 'AddReturn must have debarred the patron' # at t/db_dependent/Circulation.t line 3112. # got: '' # expected: '1' # AddReturn returned message $VAR1 = { # 'WasReturned' => 1 # }; # Failed test 'Test at line 1918' # at t/db_dependent/Circulation.t line 3116. # got: '0' # expected: '1' # Failed test 'Test at line 1918' # at t/db_dependent/Circulation.t line 3119. # got: undef # expected: '2019-05-30' # Looks like you failed 3 tests of 21. The test at line 3113 expects the flags 'WasReturned' and 'Debarred' to be set, but only WasReturned is. Which means the patron has not been debarred. It is not because the checkout has not been detected as overdue. If you apply only the first patch you will see that the tests are failing with the exact same failures. Indeed, if due_date is not passed to test_debarment_on_checkout, it is set to now (dt_from_string). However, if the call and the test of the parameters inside the subroutine takes more than 1 second, then due_date will be after what we really expect. To reproduce that, we add 1 minute to due_date and we observe the tests failing. The trick here (and we should have in all our tests) is to mock DateTime->now to make sure dt_from_string will always return the same value, it is what we expect from our tests (in 99.9% of the cases at least). Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens commit 085cb4de51c528b6a50b60f591f6b5ac426efd6a Author: Jonathan Druart Date: Wed May 15 19:45:06 2019 -0500 Bug 22917: Recreate the failure Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens commit 53545ba739e1706da7f3e52c145f0f6c8bbfb18c Author: Nick Clemens Date: Mon Dec 24 12:52:53 2018 +0000 Bug 22046: Simplify and unify the code for get_matches To test: 1 - Stage some records for import 2 - Manage the records 3 - Use several different matching rules and note the results 4 - Apply patch 5 - Try several matching rules again and note the results have not changed 6 - Try under both search engines (Zebra and ES) Signed-off-by: Liz Rea Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens commit cbacf68d7fb554bd949e2f498c1eda86b34ef97f Author: root Date: Fri May 17 12:30:47 2019 +0000 Bug 22934: Add missing use statement Also fixes a typo To test: 1 - Add a subscription to a record 2 - Add an additional field in the admin section 3 - Edit the subscription and define the additional field 4 - Ensure you can view the record in the staff client and opac 5 - Without patch ,in the subscription detail page,click the link of the record title. => software error. 6 - Apply the patch. => no error anymore. Signed-off-by: Owen Leonard Signed-off-by: Bin Wen Signed-off-by: Marcel de Rooy Fixed another typo on L21 Signed-off-by: Nick Clemens commit 9532a3edeacd8fb3df67e8a01ed4e89069ffc017 Author: Julian Maurice Date: Wed May 15 08:41:01 2019 +0200 Bug 22705: Change default value of cxn_pool to 'Static' 'Static' is the default value of Search::Elasticsearch and for a good reason : it works in most cases, unlike the 'Sniff' option To test: 1 - Apply patch 2 - Edit koha-conf.xml 3 - Add 'Static' to the elasticsearch stanza 4 - Restart all the things! 5 - Reindex ES, it works 6 - Set SearchEngine to ES, try searching 7 - It works! Signed-off-by: Nick Clemens Signed-off-by: Chris Cormack Signed-off-by: Nick Clemens commit ae2f21e74dc68c305d88ba26f60282550e3c448b Author: Liz Rea Date: Thu May 16 18:38:23 2019 +0000 Bug 22905: (QA follow-up) remove bad warn Signed-off-by: Liz Rea Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens commit fe053f0ee06508d1c6e2675dcadc535075900b6e Author: Jonathan Druart Date: Thu May 16 13:20:53 2019 -0500 Bug 22905: Fix update of suggestion's status if branchcode filter is 'all' Because of the "Library" filter on the left of the "Suggestions management" screen, there is something wrong happening: 1. Create a suggestion from library A, login from library B 2. Go to Home ? Acquisitions ? Suggestions management => The suggestion does not appear - OK 3. In the filter on the left, select "all library" => The suggestion appears on the pending tab - KO 4. Select the suggestion and mark is as 'Accepted' => The suggestion still appears on the pending tab - Failure The log says: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`suggestions`, CONSTRAINT `suggestions_ibfk_branchcode` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`) ON DELETE SET NULL ON UPDATE CASCADE) [for Statement "UPDATE `suggestions` SET `accepteddate` = ?, `branchcode` = ?, `currency` = ?, `manageddate` = ?, `price` = ?, `reason` = ?, `suggesteddate` = ?, `total` = ? WHERE ( `suggestionid` = ? )" with ParamValues: 0='2019-05-14T15:48:18', 1="", 2="CAD", 3='2019-05-14T15:48:18', 4="0.00", 5="", 6='2019-05-14T00:00:00', 7="0.00", 8=3] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. Let forget what could have happened earlier in the script and do it the regular way, from $input. Then call ModSuggestion with only what we need. Test plan: Confirm that the steps described before work as expected once this patch is applied Signed-off-by: Liz Rea https://bugs.koha-community.org/show_bug.cgi?id=22907 Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens ----------------------------------------------------------------------- Summary of changes: C4/MarcModificationTemplates.pm | 3 -- C4/Matcher.pm | 27 +++++-------- C4/SIP/ILS.pm | 1 + Koha/AdditionalFieldValue.pm | 3 +- Koha/SearchEngine/Elasticsearch.pm | 2 +- etc/koha-conf.xml | 3 ++ .../mana/mana-subscription-search-result.inc | 2 +- .../prog/en/includes/reports-toolbar.inc | 2 +- .../prog/en/modules/admin/admin-home.tt | 2 +- .../en/modules/admin/preferences/cataloguing.pref | 2 +- suggestion/suggestion.pl | 40 +++++++++++++------- t/db_dependent/Circulation.t | 9 ++++- t/db_dependent/Log.t | 2 +- 13 files changed, 54 insertions(+), 44 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 23 18:05:02 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 23 May 2019 16:05:02 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v18.11.00-1599-ge9aa9b8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via e9aa9b84fcc1b18a7988b380760374c8c9a6848d (commit) via d7e3b483714436772c47ba0f8d33e5ace74c1427 (commit) via 78b866fcd9f792f1195b90d7a49566f0055e658c (commit) via edb9f498f7148a0d6b2c232a8c22412e113c422b (commit) via a6840d14d27c669b09e0dbd4e6469e0b3196cd4b (commit) from b67462d471a54bf342295cbc5e46373d065bab7e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e9aa9b84fcc1b18a7988b380760374c8c9a6848d Author: Nick Clemens Date: Wed May 22 14:26:41 2019 +0000 Bug 20436: (RM follow-up) Use Koha objects instead of mysql Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens commit d7e3b483714436772c47ba0f8d33e5ace74c1427 Author: Nick Clemens Date: Wed May 22 14:37:53 2019 +0000 Bug 17698: (RM follow-up) Pass lang variable so letter can be translated Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens commit 78b866fcd9f792f1195b90d7a49566f0055e658c Author: Nick Clemens Date: Wed May 22 14:32:26 2019 +0000 Bug 14385: (RM follow-up) Remove line from bad rebase Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens commit edb9f498f7148a0d6b2c232a8c22412e113c422b Author: Nick Clemens Date: Mon May 13 15:34:47 2019 +0000 Bug 22896: Missing inputs in transfer modal This patch restores hidden inputs to save overridden checkin date and other data Currently we lose the list of checkouts and several settings when items with transfers are checked in To test: 1 - Find an item from another branch 2 - Set a checkin date and click the box for the date to be remembered 3 - Check in the item 4 - Click ok or print, note the checkin date is lost 5 - Apply patch 6 - Repeat 7 - Checkin date remains Signed-off-by: Liz Rea Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens commit a6840d14d27c669b09e0dbd4e6469e0b3196cd4b Author: Nick Clemens Date: Tue May 14 13:17:34 2019 +0000 Bug 22802: Check item funds, order funds, and default funds when ordering from a file This patch tries to centralise the logic of order funds requirements into a single routine. If propogates defaults down into items/order as necessary, it also prevents unsetting lower values if a default is set. To test: 1 - Populate 'MarcItemFieldsToOrder' 2 - Add to a basket from a file 3 - Use a file containing some item records with funds defined or not 4 - Confirm if all items have funds defined, you can order 5 - Confirm that setting the default for an order populates items and you can order 6 - Confirm that setting the default for all orders populates items if present/ order if not 7 - Confirm that if defaults are set the lower levels cannot be unset 8 - Try various settings and confirm all work as expected Signed-off-by: Liz Rea Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens ----------------------------------------------------------------------- Summary of changes: C4/Search.pm | 1 - .../prog/en/modules/acqui/addorderiso2709.tt | 9 +- .../intranet-tmpl/prog/en/modules/circ/returns.tt | 22 ++--- koha-tmpl/intranet-tmpl/prog/js/addorderiso2709.js | 94 +++++++++++++------- misc/cronjobs/longoverdue.pl | 11 ++- opac/opac-issue-note.pl | 1 + 6 files changed, 88 insertions(+), 50 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 24 16:07:04 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 24 May 2019 14:07:04 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.05-35-g4c5ae7f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via 4c5ae7ffc69443c5f3b956a1dc596743afb6c8d6 (commit) via b0ab8904a81ae2ae590193932d015dcc7006e13d (commit) via 12cb120742ecffac30f73b7b300c33dcac99762d (commit) via c6ca2dfcd344796ca01185776118b73820ca79a9 (commit) via b95682f73549cd9ddda73c61a54a4b45b0443cbe (commit) via 41971fd6dafaab903f8b23a89321d82114dac93d (commit) via d32f1296795a4f2bae9c1ff5504c2b7133fa3c87 (commit) via 07738ea63b0386095f97111b6aaf41805b2af7ca (commit) via 8e4ea14f93075a10a4ed995d6533e425e70b4039 (commit) via 551fc90f2e5234f5d076f73570809f7266ebc623 (commit) via 9200fd44b2b0f237860e5e309e769e2e035f0464 (commit) via 27f7b2b5059cd92b2583ced1a1fec072c5fb06f4 (commit) via 3c0718c7a78104c1ff2eb359c04341bf1ee10888 (commit) via cd147f78d7e5ce8b48afa021ffc4f2ede3ebb38f (commit) from d617065162df47ffaf35fc192f260c702fd62602 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4c5ae7ffc69443c5f3b956a1dc596743afb6c8d6 Author: Jonathan Druart Date: Mon May 6 11:55:32 2019 -0500 Bug 22713: Remove unecessary $replacementprice var Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens (cherry picked from commit 3b877cc240eb44acafaef1ed5f287eae3dfb7baa) Signed-off-by: Martin Renvoize commit b0ab8904a81ae2ae590193932d015dcc7006e13d Author: Nick Clemens Date: Thu Apr 25 16:23:22 2019 +0000 Bug 22713: Pass replacement price in to order if defined by MarcItemFieldsToOrder To test: 1 - Have AcqCreateItems set to 'On ordering' (or set in a basket) 2 - Define MARCItemFieldsToOrder homebranch: 975$a holdingbranch: 975$b itype: 975$y nonpublic_note: 975$x public_note: 975$z loc: 975$c ccode: 970$c notforloan: 975$7 uri: 975$u copyno: 975$n quantity: 975$q budget_code: 975$h price: 975$g replacementprice: 975$p 3 - Have a marc record with some order info defined as above, including a replacementprice 4 - Add to basket - > from a new file 5 - Don't check for duplicates, add the order 6 - Note the order has no replacementprice, but the item does 7 - Close basket, receive order, do not enter a new replacement price 8 - Note the items replacement price is clear 9 - Apply patch 10 - Repeat 11 - Note when order added to basket it has a replacement price 12 - Note when order is received the replacement price is populated and passed into item correctly Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens (cherry picked from commit 57b027734e3c1a315cd11fedbf94771fa8381a30) Signed-off-by: Martin Renvoize commit 12cb120742ecffac30f73b7b300c33dcac99762d Author: Jonathan Druart Date: Wed May 8 16:37:40 2019 -0500 Bug 11853: Add tests Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens (cherry picked from commit 735d23c299669b40d3e3e2a4fe21b88fc6cca00f) Signed-off-by: Martin Renvoize commit c6ca2dfcd344796ca01185776118b73820ca79a9 Author: Jonathan Druart Date: Wed May 8 16:37:50 2019 -0500 Bug 11853: Allow to clear the date of birth at the OPAC A patron is not able to clear their date of birth. When cleared tt is set to NULL in DB which means, for the patron's modifications feature, that nothing has been changed. Test plan: 0/ Do not apply the patch 1/ Edit your personal details at the OPAC 2/ Add a date of birth 3/ On the staff interface, approve the modification request => OK it is updated 4/ Edit your personal details and clear the date of birth 5/ On the staff interface => KO the table display is wrong, nothing is marked has changed 6/ Approve the modification requiest => KO it has not been cleared 7/ Apply the patch and repeat 1 to 6 and confirm that the behaviors are now correct. Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens (cherry picked from commit 6692800794cbf403e8be8c8062608b60148c0d56) Signed-off-by: Martin Renvoize commit b95682f73549cd9ddda73c61a54a4b45b0443cbe Author: Owen Leonard Date: Fri May 10 13:24:39 2019 +0000 Bug 22881: Trying to clear search history via the navbar X doesn't clear any searches This patch undoes a mistake introduced in my patch for Bug 21479. A "preventDefault()" was added to the search history clear button by mistake. The "confirmDelete" function only works if the default action of the link is allowed to complete. To test you must have the EnableOpacSearchHistory system preference enabled. Apply the patch and log into the OPAC as a patron who has a search history. Click the "X" link in the header next to the "Search history" link. Confirm that you want to clear your search history. The page should refresh. Navigate to your account -> Your search history to confirm that your search history has been cleared. Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens (cherry picked from commit 6d1b7ff27eb2d53d637c169c7132a66d546c0124) Signed-off-by: Martin Renvoize commit 41971fd6dafaab903f8b23a89321d82114dac93d Author: Nick Clemens Date: Tue May 14 18:15:54 2019 +0000 Bug 22899: DBRev 18.11.05.001 Signed-off-by: Nick Clemens (cherry picked from commit b90bbc125969dc0048dde2ec37531a6ef6cd2b36) Signed-off-by: Martin Renvoize commit d32f1296795a4f2bae9c1ff5504c2b7133fa3c87 Author: Martin Renvoize Date: Tue May 14 13:21:55 2019 +0100 Bug 22899: (QA follow-up) Change accessor name This patch changes pending_hold to has_pending_hold to signify that we're returning a boolean and not a Koha::Hold object. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens (cherry picked from commit 5c81d986212b480d9b491e46b3fb4498c0eb2c2c) Signed-off-by: Martin Renvoize commit 07738ea63b0386095f97111b6aaf41805b2af7ca Author: Martin Renvoize Date: Tue May 14 13:17:01 2019 +0100 Bug 22899: (QA follow-up) Ensure constraint is created Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens (cherry picked from commit 49a6aac8b6d8fd13999638f5a6ae4d4481dbf304) Signed-off-by: Martin Renvoize commit 8e4ea14f93075a10a4ed995d6533e425e70b4039 Author: Nick Clemens Date: Mon May 13 20:09:05 2019 +0000 Bug 22899: Add pending_hold method to Koha::Item To test: 1 - Enable course reserves 2 - Create a course 3 - Add an item to the course 4 - Attempt to view the course on the OPAC 5 - Internal Server Error 6 - Apply patch 7 - Add an item to the holds queue by placing a hold and running holds queue builder or: INSERT INTO tmp_holdsqueue (itemnumber) VALUES (###); 8 - View the course page, note item appears 'Pending hold' 9 - Remove the holdsqueue line 10 - View the course page, note item appears 'Available' 11 - prove -v t/db_dependent/Koha/Item.t Signed-off-by: Hayley Mapley I see Jonathan's comments about small improvements, but will sign off as everything works as expected here. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens (cherry picked from commit f21ebad7d298f25e44771e5833d1d1d4d6d8f777) Signed-off-by: Martin Renvoize commit 551fc90f2e5234f5d076f73570809f7266ebc623 Author: Nick Clemens Date: Mon May 13 20:08:06 2019 +0000 Bug 22899: Database update Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens (cherry picked from commit af1067f3d466cf3bd32c4747c4a00dd7542c1fe0) Signed-off-by: Martin Renvoize commit 9200fd44b2b0f237860e5e309e769e2e035f0464 Author: Jonathan Druart Date: Fri May 10 12:32:23 2019 -0500 Bug 22433: Use Data::Dumper instead of Data::Printer Data::Printer is not in our deps Signed-off-by: Nick Clemens (cherry picked from commit b5b64e7900fd61bd525409ee869deafde7b8c50a) Signed-off-by: Martin Renvoize commit 27f7b2b5059cd92b2583ced1a1fec072c5fb06f4 Author: Jonathan Druart Date: Thu May 9 13:04:38 2019 -0500 Bug 22433: Add debug statement to Transaction.t Hard to know what's going on here without more info. Adding this output may help to investigate more. Test plan: Make sure the tests still pass If it fails, please paste the output!! Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens (cherry picked from commit 63a8e27f2e087b698e986e026dc9fa511b2afbfe) Signed-off-by: Martin Renvoize commit 3c0718c7a78104c1ff2eb359c04341bf1ee10888 Author: Jonathan Druart Date: Thu Nov 1 13:31:31 2018 -0300 Bug 21709: Replace 'no popup' plugin links with a span Test plan: Edit a bibliographic record Notice that the icons next to fields linked with a plugin can be a link or not. The browser displays a pointer or not. It will remove the ambiguity to display an icon that is clickable but does nothing when clicked. We could also have another icon to disociate both behaviors. Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens (cherry picked from commit 9fa97774ae6b3c84028b15f8c768460a012320ea) Signed-off-by: Martin Renvoize commit cd147f78d7e5ce8b48afa021ffc4f2ede3ebb38f Author: Nick Clemens Date: Fri May 10 12:10:42 2019 +0000 Bug 22782: DBIC update for SocialData Signed-off-by: Nick Clemens (cherry picked from commit 5ecbe281aff13e53d4fbc5064714de9209410358) Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Items.pm | 2 +- C4/XSLT.pm | 4 +- Koha.pm | 2 +- Koha/Item.pm | 14 ++++++ Koha/Patron/Modification.pm | 14 ++++-- Koha/Patron/Modifications.pm | 6 ++- Koha/Schema/Result/Item.pm | 19 ++++++- Koha/Schema/Result/SocialData.pm | 7 +-- Koha/Schema/Result/TmpHoldsqueue.pm | 29 +++++++++-- acqui/addorderiso2709.pl | 4 +- installer/data/mysql/kohastructure.sql | 6 ++- installer/data/mysql/updatedatabase.pl | 19 +++++++ .../prog/en/modules/cataloguing/addbiblio.tt | 2 +- .../bootstrap/en/includes/item-status.inc | 2 +- .../bootstrap/en/includes/opac-bottom.inc | 3 +- t/db_dependent/Items.t | 4 +- t/db_dependent/Koha/Item.t | 52 ++++++++++++++++++++ t/db_dependent/Koha/Patron/Modifications.t | 41 ++++++++++++++- t/db_dependent/SIP/Transaction.t | 5 +- 19 files changed, 204 insertions(+), 31 deletions(-) create mode 100644 t/db_dependent/Koha/Item.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 24 16:14:39 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 24 May 2019 14:14:39 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.05-39-g3960731 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via 396073150e0371471e18ec975a7ba4f2dbe4b3ea (commit) via db1be3d9905ff8c8d2506948ca8c3b6eef7fa609 (commit) via 7d96c2b771943824e4ab9c0517ec837c4375f297 (commit) via 7c260de1678b88a278b87f1de5c0d764d674c558 (commit) from 4c5ae7ffc69443c5f3b956a1dc596743afb6c8d6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 396073150e0371471e18ec975a7ba4f2dbe4b3ea Author: Jonathan Druart Date: Fri May 10 11:11:14 2019 -0500 Bug 22812: Use Koha::Subscription in NewSubscription Starting to write tests I realize that we are going to add too much specific logic which is already handled in Koha::Object->store. The easiest and safe way is to use it :) Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens (cherry picked from commit b41f215bfedbae0898a9291d2f14e2a3dd560049) Signed-off-by: Martin Renvoize commit db1be3d9905ff8c8d2506948ca8c3b6eef7fa609 Author: Jonathan Druart Date: Mon May 6 13:50:54 2019 -0500 Bug 22812: Fix GROUP BY in checkrouting On the way, let fix this error DBD::mysql::st execute failed: Mixing of GROUP columns (MIN(),MAX(),COUNT(),...) with no GROUP columns is illegal if there is no GROUP BY clause [for Statement "SELECT count(routingid) routingids FROM subscription LEFT JOIN subscriptionroutinglist Test plan: Create a routing list, search for subscriptions In the action list you should see "Edit routing list (1)" or "New routing list" Signed-off-by: Liz Rea Signed-off-by: Marcel de Rooy Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens (cherry picked from commit 256b134a94e83b7072b5891a2d60f0e08e813583) Signed-off-by: Martin Renvoize commit 7d96c2b771943824e4ab9c0517ec837c4375f297 Author: Jonathan Druart Date: Mon May 6 13:50:26 2019 -0500 Bug 22812: Add tests for checkrouting Signed-off-by: Liz Rea Signed-off-by: Marcel de Rooy Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens (cherry picked from commit 0759811ab629e8215ee270b4ec920f71d9bc0d25) Signed-off-by: Martin Renvoize commit 7c260de1678b88a278b87f1de5c0d764d674c558 Author: Jonathan Druart Date: Mon May 6 13:34:19 2019 -0500 Bug 22812: Fix new subscription with strict sql modes With sql_strict_modes turned on, if you try to create a new subscription you will get: Incorrect integer value: '' for column '$INT_COLUMN' at row 1 Signed-off-by: Liz Rea Signed-off-by: Marcel de Rooy Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens (cherry picked from commit e8e7ea352ef237555ee4d47c98feb879f3eb9e31) Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Serials.pm | 73 ++++++++++++++++++++++++++++------------------ t/db_dependent/Serials.t | 17 ++++++++++- 2 files changed, 61 insertions(+), 29 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 24 17:16:15 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 24 May 2019 15:16:15 +0000 Subject: [koha-commits] main Koha release repository branch 18.05.x updated. v18.05.11-80-gd397871 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.05.x has been updated via d39787147ca98bf2b2b982d60dbbc22e21c0a676 (commit) from aacb4e6bb9e6cc0539134a0389e1babe540eb142 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d39787147ca98bf2b2b982d60dbbc22e21c0a676 Author: Nick Clemens Date: Fri Apr 19 11:25:43 2019 +0000 Bug 22743: Add password modal to overdrive results page This patch also removes a line abotu ratings which was throwing an error. Confirm stars rating for OD results are still shown as expected To test: 1 - Enable overdrive circulation with password required 2 - Sign in to OPAC but not overdrive 3 - Perform a search that returns overdrive results 4 - Click in to results page http://localhost:8080/cgi-bin/koha/opac-overdrive-search.pl?q=cats 5 - Note 'Login to OverDrive account' link 6 - Click it 7 - Nothing happens! 8 - Apply patch 9 - Repeat 10 - Success! Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens (cherry picked from commit 7be176cf1da5adb5f264bb9668667dfeb1d9a2ae) Signed-off-by: Martin Renvoize (cherry picked from commit 461c7176735cbfd4ed7db97a9fa094b60ac2e0ca) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: .../opac-tmpl/bootstrap/en/modules/opac-overdrive-search.tt | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 24 17:50:23 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 24 May 2019 15:50:23 +0000 Subject: [koha-commits] main Koha release repository branch 18.05.x updated. v18.05.11-82-g713784f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.05.x has been updated via 713784ff0b775dff5966b48c274490ce227e102a (commit) via a53d1a733cad6595e142498fef9132f0d2715144 (commit) from d39787147ca98bf2b2b982d60dbbc22e21c0a676 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 713784ff0b775dff5966b48c274490ce227e102a Author: Jonathan Druart Date: Fri Jun 8 12:19:41 2018 -0300 Bug 20891: Escape html then JSON To my understanding we need to escape first html chars then to JSON. If this patch works we will need to rethink the 'To' TT plugin. It was originally designed to have several escape methods, but with these changes it will not make sense to name it 'To' if used only to escape JSON IIRC we should keep the 2 different ways to use it: * [% To.json( string ) %] * [% string | $To %] otherwise it will be hard to use it when called in argument of patron-title.inc (`git grep To.json`) Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens (cherry picked from commit bdf0d85c1de9cbb37cc8a40b0b4a2e86633d3aaf) Signed-off-by: Martin Renvoize (cherry picked from commit 6bf436065ebf93cbda4e67c05a238b0e63c22d42) Signed-off-by: Lucas Gass commit a53d1a733cad6595e142498fef9132f0d2715144 Author: Jonathan Druart Date: Thu Jun 7 12:17:26 2018 -0300 Bug 20891: Escape list's names in JSON When someone uses \ in the description of a list, the datatable in staff won't load and keeps processing. Test plan: - Create a list named "" - Create another list named "k\o\h\a" - Hit /cgi-bin/koha/virtualshelves/shelves.pl => Without this patch the lists will not be displayed, JSON is malformated => With this patch everything is ok Signed-off-by: Marcel de Rooy Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens (cherry picked from commit 2be0195895628ec491ee1f25368e60181c4f1eb2) Signed-off-by: Martin Renvoize (cherry picked from commit 05ffb6c6af451aa764f0cb4be1d712d7334f1167) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: Koha/Template/Plugin/To.pm | 9 ++++++++- .../prog/en/modules/virtualshelves/tables/shelves_results.tt | 4 ++-- 2 files changed, 10 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 24 18:05:12 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 24 May 2019 16:05:12 +0000 Subject: [koha-commits] main Koha release repository branch 18.05.x updated. v18.05.11-83-g7258095 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.05.x has been updated via 7258095decfd92f9a76850137d5915794d92fb05 (commit) from 713784ff0b775dff5966b48c274490ce227e102a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7258095decfd92f9a76850137d5915794d92fb05 Author: Mark Tompsett Date: Mon May 28 16:45:29 2018 +0000 Bug 20692: Extreme toggle checking for plack TEST PLAN --------- sudo koha-plack --disable sudo koha-plack --disable sudo koha-plack --enable sudo koha-plack --disable echo $? sudo koha-plack --disable echo $? sudo koha-list --noplack echo $? sudo koha-plack --enable echo $? sudo koha-plack --enable echo $? sudo koha-list --plack echo $? git bz apply 20692 sudo perl ~/misc4dev/cp_debian_files.pl then repeat the test. It should also be noted, because the enable and disable are now split, if for some reason they become out of sync, an enable or disable should correct them. Because these are bash scripts, the test tool (/home/vagrant/qa-test-tools/koha-qa.pl) does not apply. Signed-off-by: Liz Rea Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens (cherry picked from commit de20398db303a1ee45b62f9aa51f124597ed0cd8) Signed-off-by: Martin Renvoize (cherry picked from commit 84adcb4017e7be038e5e32c37a6b40e4ab9f59c7) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: debian/scripts/koha-functions.sh | 54 ++++++++++++++++++++++-- debian/scripts/koha-plack | 84 ++++++++++++++++++++++++++++++++++---- 2 files changed, 126 insertions(+), 12 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 24 18:38:17 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 24 May 2019 16:38:17 +0000 Subject: [koha-commits] main Koha release repository branch 18.05.x updated. v18.05.11-85-g05db4ab Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.05.x has been updated via 05db4abd2c2368bb930d0903874501b028dbc98a (commit) via 011d467bb20929bb117c1c70af606ec0a19c5077 (commit) from 7258095decfd92f9a76850137d5915794d92fb05 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 05db4abd2c2368bb930d0903874501b028dbc98a Author: Nick Clemens Date: Thu Apr 25 17:47:14 2019 +0000 Bug 22715: Remove extraneous html filter Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens (cherry picked from commit 7e85754083bd66f45009f55a01e9dec9eda81504) Signed-off-by: Martin Renvoize (cherry picked from commit 310330590a14757ac3b35a2956ba56512ee65534) Signed-off-by: Lucas Gass commit 011d467bb20929bb117c1c70af606ec0a19c5077 Author: Kyle M Hall Date: Tue Apr 16 10:34:56 2019 -0400 Bug 22715: Searching for patrons with "" in the circulation note hangs patron search To replicate: Edit a patron to have a circ note, include quoted text in it, such as "this is quoted string" Go to the patron search, search for a set of results that would include the patron with the quotes in the note Enjoy looking at "Processing" for forever. Test Plan: 1) Apply this patch 2) Attempt to replicate using the steps above Signed-off-by: Liz Rea I took this a step further and used for my test note and this worked just fine. YAY. Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens (cherry picked from commit 6e641c5bcb7370556326fb64838fce1eefbc2c18) Signed-off-by: Martin Renvoize (cherry picked from commit 57a7cea7200f69966089b06c54e1482d4daae5ef) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/members/tables/members_results.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 24 18:44:32 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 24 May 2019 16:44:32 +0000 Subject: [koha-commits] main Koha release repository branch 18.05.x updated. v18.05.11-86-gbfb5fb4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.05.x has been updated via bfb5fb46cc287e248d4c6d2f2fb0a41bbd23d17d (commit) from 05db4abd2c2368bb930d0903874501b028dbc98a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit bfb5fb46cc287e248d4c6d2f2fb0a41bbd23d17d Author: Kyle M Hall Date: Wed Oct 17 14:43:11 2018 -0400 Bug 21589: Series link formed from 830 field is incorrect Bug 13692 corrected the series link for records using a 490/800 combination When a record has a 490/830 conbination for series, the link is malformed (title is used as author, title is blank) Test Plan: 1) Catalog two or more records with 830 fields 2) Note the series links are broken 3) Apply this patch 4) Reload the record details page 5) The series link should now work 6) Repeat for the OPAC Signed-off-by: Claire Gravely Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens (cherry picked from commit 20496bc78b7830d812fda454a0fe243fae9c465c) Signed-off-by: Martin Renvoize (cherry picked from commit 07fc6e0c53512882534af0364c3bb741be20c179) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: .../prog/en/xslt/MARC21slim2intranetDetail.xsl | 33 +++++++++++++++++++- .../bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 32 ++++++++++++++++++- 2 files changed, 63 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 24 19:49:48 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 24 May 2019 17:49:48 +0000 Subject: [koha-commits] main Koha release repository branch 18.05.x updated. v18.05.11-87-g3e48b16 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.05.x has been updated via 3e48b16f000ff5c61dda0dad382e64094d8007c0 (commit) from bfb5fb46cc287e248d4c6d2f2fb0a41bbd23d17d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3e48b16f000ff5c61dda0dad382e64094d8007c0 Author: Jonathan Druart Date: Tue Apr 23 22:49:46 2019 -0400 Bug 22621: Fix filters on subscription search results Caused by commit 4e698f7b478a094d7b32ebfeaa917bca05ebcc5b Bug 18426: Allow to edit subscriptions in batch There is a shift caused by a hidden column, which make the filters searching on the previous column. Test plan: - Add 1+ searchable additional field for subscription - Create a new subscription - Search for subscriptions - Use the column filters to filter the results => The results must be filtered accordingly Signed-off-by: Claire Gravely Signed-off-by: Kyle M Hall Signed-off-by: Nick Clemens (cherry picked from commit 1d6e9ff44c19379a41e9ce688685a24788583e0c) Signed-off-by: Martin Renvoize (cherry picked from commit b61c41f0efebac66d561070d5a3e4533354d90d0) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/serials/serials-search.tt | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 24 20:05:25 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 24 May 2019 18:05:25 +0000 Subject: [koha-commits] main Koha release repository branch 18.05.x updated. v18.05.11-88-g2f3be30 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.05.x has been updated via 2f3be3095c575c226b16b2caa39c5cfa8892256a (commit) from 3e48b16f000ff5c61dda0dad382e64094d8007c0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2f3be3095c575c226b16b2caa39c5cfa8892256a Author: Mirko Tietgen Date: Tue Apr 30 10:56:20 2019 +0200 Bug 22808: Move Cache.t to db_dependent Cache.t fails during package build. Moving it to db_dependent fixes the problem. Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens (cherry picked from commit 6509d73d7925fe5d317d6f2baa1d1565d8d36220) Signed-off-by: Martin Renvoize (cherry picked from commit 3653df7715744f583bd33c62775d2ec8f7753b0a) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: t/{ => db_dependent}/Cache.t | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename t/{ => db_dependent}/Cache.t (100%) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 29 17:03:40 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 29 May 2019 15:03:40 +0000 Subject: [koha-commits] main Koha release repository branch 17.11.x updated. v17.11.18 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 17.11.x has been updated via 7993fa60eb1eabc9f8b3cfacea2ff96b1edba9b3 (commit) via 586a3a11dbf2234c8a18b7b0b27ed83505352eb2 (commit) via 86f3a4feed9a9b37aacc67bdea9e3327043203df (commit) via c1592ff118a3c18bb1ffdb0fc67a94c874d45af4 (commit) via 573ad1da0dd29761a1b3f47c0ff411ae618f218a (commit) via c98928671a7dd46a315d2601af1999cf9c42f5c1 (commit) via 524ba89732466f5d1db6df17ae826a4d613b3087 (commit) via e3f3f18b83b7ea470e0ad73e24cd58bccab5adac (commit) via 8b2778781c9ebd9687515fac4b9f86ff0eb272e2 (commit) from d1e8a21bc39210075537c567ef83200812c75a10 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7993fa60eb1eabc9f8b3cfacea2ff96b1edba9b3 Author: Fridolin Somers Date: Tue Apr 30 16:23:27 2019 +0200 Update release notes for 17.11.18 release Signed-off-by: Fridolin Somers commit 586a3a11dbf2234c8a18b7b0b27ed83505352eb2 Author: Fridolin Somers Date: Tue Apr 30 09:51:59 2019 +0200 Increment version for 17.11.18 release Signed-off-by: Fridolin Somers commit 86f3a4feed9a9b37aacc67bdea9e3327043203df Author: Tomas Cohen Arazi Date: Fri Apr 5 15:13:36 2019 -0300 Bug 22068: (QA follow-up) Return meaningful error codes Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens (cherry picked from commit e98dacf9f1f8464f0db394da6bc1152f96713597) Signed-off-by: Martin Renvoize (cherry picked from commit 912a97f8b49b89d03ed524bed2072db0a50c4527) Signed-off-by: Lucas Gass (cherry picked from commit 147d67cebfa6a67b0a783fda03be588d08910a7c) Signed-off-by: Fridolin Somers commit c1592ff118a3c18bb1ffdb0fc67a94c874d45af4 Author: Jonathan Druart Date: Thu Feb 14 17:03:17 2019 -0300 Bug 22068: Prevent patrons to cancel article request they did not create opac-article-request-cancel.pl doesn't check that the article request to be cancelled actually belongs to the logged-in borrower. This results in any logged-in user being able to cancel any article request just by changing the id in the URL. Test plan: - Login with Patron P1, create an article request - Cancel it - Create another one - Copy the cancellation link (must be /cgi-bin/koha/opac-article-request-cancel.pl?id=X) - Login with Patron P2 - Hit the cancellation link => Without this patch the article request is cancelled => With this patch applied there is a 404 redirection Note that the 404 will also appears when the article request id does not exist. Signed-off-by: Ere Maijala Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens (cherry picked from commit 0b931d5de3c4fe9fa2b4823d9b8727b28a46aa7c) Signed-off-by: Martin Renvoize (cherry picked from commit dc32211a8ea12e67453e5af9edaac0a73b52e2de) Signed-off-by: Lucas Gass (cherry picked from commit 96a700c3dd0d4008c6c0250ac24c8c0c2e8b9dee) Signed-off-by: Fridolin Somers commit 573ad1da0dd29761a1b3f47c0ff411ae618f218a Merge: 524ba89 c989286 Author: Fridolin Somers Date: Tue Apr 30 09:50:46 2019 +0200 Merge remote-tracking branch 'translate/17.11.18-translate-20190430' into 17.11.x commit c98928671a7dd46a315d2601af1999cf9c42f5c1 Author: Koha translators <> Date: Tue Apr 30 04:33:37 2019 -0300 Translation updates for Koha 17.11.18 commit 524ba89732466f5d1db6df17ae826a4d613b3087 Author: Marcel de Rooy Date: Fri Apr 12 07:02:06 2019 +0000 Bug 22478: (QA follow-up) Handle category in opac-shelves like a boolean The category parameter should be restricted to 1 or 2 (private/public). In order to keep same behavior, no parameter means 1 (private). Note: Adding the same line in intranet counterpart. Test plan [1] Check for category empty, '1a', '11' etc. And with script ;) Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize (cherry picked from commit 3d06afa4cdd9131fb9784a9d76b14a669e35ffc7) Signed-off-by: Lucas Gass (cherry picked from commit fd18249965235586deb2e3cc3f4653acd59ecc37) Signed-off-by: Fridolin Somers commit e3f3f18b83b7ea470e0ad73e24cd58bccab5adac Author: Jonathan Druart Date: Thu Mar 14 19:42:50 2019 -0300 Bug 22478: Prevent XSS vulnerabilities when pagination appears This is a bad one as we thought we were XSS safe since bug 13618. The html code generated in C4::Output::pagination_bar must escape the variables and values correctly. This patch needs to be widely tested, everywhere the pagination appears, to make sure we will not introduce regressions. Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize (cherry picked from commit d4d1107afa873614ace241557e424de0dcbad20a) Signed-off-by: Lucas Gass (cherry picked from commit f7b12a1cf3da62d8ed884692b4161dca1d456bfe) Signed-off-by: Fridolin Somers commit 8b2778781c9ebd9687515fac4b9f86ff0eb272e2 Author: Jonathan Druart Date: Thu Mar 21 14:45:37 2019 -0300 Bug 22542: Force back button to display personal data This is a follow-up of bug 5371 The following command must not return anything: grep ^output_html_with_http_headers `git grep -l -P "authnotrequired\s*=>\s*0" opac`|grep -v force_no_caching This must be a test somehwere to prevent further regressions. Signed-off-by: Katrin Fischer Signed-off-by: Chris Cormack Signed-off-by: Martin Renvoize (cherry picked from commit 20d3d6788ec814e721d97f348be3749fffe662b6) Signed-off-by: Lucas Gass (cherry picked from commit 63691c6f248e769ecf3165f5363f4bb1a96e4c3a) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: C4/Output.pm | 6 +- Koha.pm | 2 +- installer/data/mysql/updatedatabase.pl | 6 + ...s_17_11_17.html => release_notes_17_11_18.html} | 121 +++--- ...notes_17_11_17.md => release_notes_17_11_18.md} | 114 +++--- misc/translator/po/am-Ethi-marc-MARC21.po | 2 +- misc/translator/po/am-Ethi-marc-NORMARC.po | 2 +- misc/translator/po/am-Ethi-marc-UNIMARC.po | 2 +- misc/translator/po/am-Ethi-opac-bootstrap.po | 2 +- misc/translator/po/am-Ethi-staff-help.po | 2 +- misc/translator/po/am-Ethi-staff-prog.po | 2 +- misc/translator/po/ar-Arab-marc-MARC21.po | 2 +- misc/translator/po/ar-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ar-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/ar-Arab-opac-bootstrap.po | 2 +- misc/translator/po/ar-Arab-staff-help.po | 2 +- misc/translator/po/ar-Arab-staff-prog.po | 2 +- misc/translator/po/as-IN-marc-MARC21.po | 2 +- misc/translator/po/as-IN-marc-NORMARC.po | 2 +- misc/translator/po/as-IN-marc-UNIMARC.po | 2 +- misc/translator/po/as-IN-opac-bootstrap.po | 2 +- misc/translator/po/as-IN-staff-help.po | 2 +- misc/translator/po/as-IN-staff-prog.po | 2 +- misc/translator/po/az-AZ-marc-MARC21.po | 2 +- misc/translator/po/az-AZ-marc-NORMARC.po | 2 +- misc/translator/po/az-AZ-marc-UNIMARC.po | 2 +- misc/translator/po/az-AZ-opac-bootstrap.po | 2 +- misc/translator/po/az-AZ-staff-help.po | 2 +- misc/translator/po/az-AZ-staff-prog.po | 2 +- misc/translator/po/be-BY-marc-MARC21.po | 2 +- misc/translator/po/be-BY-marc-NORMARC.po | 2 +- misc/translator/po/be-BY-marc-UNIMARC.po | 2 +- misc/translator/po/be-BY-opac-bootstrap.po | 2 +- misc/translator/po/be-BY-staff-help.po | 2 +- misc/translator/po/be-BY-staff-prog.po | 2 +- misc/translator/po/bg-Cyrl-marc-MARC21.po | 2 +- misc/translator/po/bg-Cyrl-marc-NORMARC.po | 2 +- misc/translator/po/bg-Cyrl-marc-UNIMARC.po | 2 +- misc/translator/po/bg-Cyrl-opac-bootstrap.po | 2 +- misc/translator/po/bg-Cyrl-staff-help.po | 2 +- misc/translator/po/bg-Cyrl-staff-prog.po | 2 +- misc/translator/po/bn-IN-marc-MARC21.po | 2 +- misc/translator/po/bn-IN-marc-NORMARC.po | 2 +- misc/translator/po/bn-IN-marc-UNIMARC.po | 2 +- misc/translator/po/bn-IN-opac-bootstrap.po | 2 +- misc/translator/po/bn-IN-staff-help.po | 2 +- misc/translator/po/bn-IN-staff-prog.po | 2 +- misc/translator/po/ca-ES-marc-MARC21.po | 2 +- misc/translator/po/ca-ES-marc-NORMARC.po | 2 +- misc/translator/po/ca-ES-marc-UNIMARC.po | 2 +- misc/translator/po/ca-ES-opac-bootstrap.po | 2 +- misc/translator/po/ca-ES-staff-help.po | 2 +- misc/translator/po/ca-ES-staff-prog.po | 2 +- misc/translator/po/cs-CZ-marc-MARC21.po | 2 +- misc/translator/po/cs-CZ-marc-NORMARC.po | 2 +- misc/translator/po/cs-CZ-marc-UNIMARC.po | 2 +- misc/translator/po/cs-CZ-opac-bootstrap.po | 2 +- misc/translator/po/cs-CZ-pref.po | 22 +- misc/translator/po/cs-CZ-staff-help.po | 29 +- misc/translator/po/cs-CZ-staff-prog.po | 22 +- misc/translator/po/cy-GB-marc-MARC21.po | 2 +- misc/translator/po/cy-GB-marc-NORMARC.po | 2 +- misc/translator/po/cy-GB-marc-UNIMARC.po | 2 +- misc/translator/po/cy-GB-opac-bootstrap.po | 2 +- misc/translator/po/cy-GB-staff-help.po | 2 +- misc/translator/po/cy-GB-staff-prog.po | 2 +- misc/translator/po/da-DK-marc-MARC21.po | 2 +- misc/translator/po/da-DK-marc-NORMARC.po | 2 +- misc/translator/po/da-DK-marc-UNIMARC.po | 2 +- misc/translator/po/da-DK-opac-bootstrap.po | 2 +- misc/translator/po/da-DK-staff-help.po | 2 +- misc/translator/po/da-DK-staff-prog.po | 2 +- misc/translator/po/de-CH-marc-MARC21.po | 2 +- misc/translator/po/de-CH-marc-NORMARC.po | 2 +- misc/translator/po/de-CH-marc-UNIMARC.po | 2 +- misc/translator/po/de-CH-opac-bootstrap.po | 2 +- misc/translator/po/de-CH-staff-help.po | 2 +- misc/translator/po/de-CH-staff-prog.po | 2 +- misc/translator/po/de-DE-marc-MARC21.po | 2 +- misc/translator/po/de-DE-marc-NORMARC.po | 2 +- misc/translator/po/de-DE-marc-UNIMARC.po | 2 +- misc/translator/po/de-DE-opac-bootstrap.po | 2 +- misc/translator/po/de-DE-staff-help.po | 2 +- misc/translator/po/de-DE-staff-prog.po | 10 +- misc/translator/po/el-GR-marc-MARC21.po | 10 +- misc/translator/po/el-GR-marc-NORMARC.po | 2 +- misc/translator/po/el-GR-marc-UNIMARC.po | 2 +- misc/translator/po/el-GR-opac-bootstrap.po | 10 +- misc/translator/po/el-GR-staff-help.po | 2 +- misc/translator/po/el-GR-staff-prog.po | 10 +- misc/translator/po/en-GB-marc-MARC21.po | 2 +- misc/translator/po/en-GB-marc-NORMARC.po | 2 +- misc/translator/po/en-GB-marc-UNIMARC.po | 2 +- misc/translator/po/en-GB-opac-bootstrap.po | 2 +- misc/translator/po/en-GB-staff-help.po | 2 +- misc/translator/po/en-GB-staff-prog.po | 2 +- misc/translator/po/en-NZ-marc-MARC21.po | 2 +- misc/translator/po/en-NZ-marc-NORMARC.po | 2 +- misc/translator/po/en-NZ-marc-UNIMARC.po | 2 +- misc/translator/po/en-NZ-opac-bootstrap.po | 2 +- misc/translator/po/en-NZ-staff-help.po | 2 +- misc/translator/po/en-NZ-staff-prog.po | 2 +- misc/translator/po/eo-marc-MARC21.po | 2 +- misc/translator/po/eo-marc-NORMARC.po | 2 +- misc/translator/po/eo-marc-UNIMARC.po | 2 +- misc/translator/po/eo-opac-bootstrap.po | 2 +- misc/translator/po/eo-staff-help.po | 2 +- misc/translator/po/eo-staff-prog.po | 2 +- misc/translator/po/es-ES-marc-MARC21.po | 16 +- misc/translator/po/es-ES-marc-NORMARC.po | 2 +- misc/translator/po/es-ES-marc-UNIMARC.po | 16 +- misc/translator/po/es-ES-opac-bootstrap.po | 2 +- misc/translator/po/es-ES-pref.po | 41 +- misc/translator/po/es-ES-staff-help.po | 139 +++---- misc/translator/po/es-ES-staff-prog.po | 401 ++++++++++---------- misc/translator/po/eu-marc-MARC21.po | 2 +- misc/translator/po/eu-marc-NORMARC.po | 2 +- misc/translator/po/eu-marc-UNIMARC.po | 2 +- misc/translator/po/eu-opac-bootstrap.po | 2 +- misc/translator/po/eu-staff-help.po | 2 +- misc/translator/po/eu-staff-prog.po | 2 +- misc/translator/po/fa-Arab-marc-MARC21.po | 2 +- misc/translator/po/fa-Arab-marc-NORMARC.po | 2 +- misc/translator/po/fa-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/fa-Arab-opac-bootstrap.po | 2 +- misc/translator/po/fa-Arab-staff-help.po | 2 +- misc/translator/po/fa-Arab-staff-prog.po | 2 +- misc/translator/po/fi-FI-marc-MARC21.po | 2 +- misc/translator/po/fi-FI-marc-NORMARC.po | 2 +- misc/translator/po/fi-FI-marc-UNIMARC.po | 2 +- misc/translator/po/fi-FI-opac-bootstrap.po | 2 +- misc/translator/po/fi-FI-staff-help.po | 2 +- misc/translator/po/fi-FI-staff-prog.po | 2 +- misc/translator/po/fo-FO-marc-MARC21.po | 2 +- misc/translator/po/fo-FO-marc-NORMARC.po | 2 +- misc/translator/po/fo-FO-marc-UNIMARC.po | 2 +- misc/translator/po/fo-FO-opac-bootstrap.po | 2 +- misc/translator/po/fo-FO-staff-help.po | 2 +- misc/translator/po/fo-FO-staff-prog.po | 2 +- misc/translator/po/fr-CA-marc-MARC21.po | 2 +- misc/translator/po/fr-CA-marc-NORMARC.po | 2 +- misc/translator/po/fr-CA-marc-UNIMARC.po | 2 +- misc/translator/po/fr-CA-opac-bootstrap.po | 2 +- misc/translator/po/fr-CA-staff-help.po | 2 +- misc/translator/po/fr-CA-staff-prog.po | 55 ++- misc/translator/po/fr-FR-marc-MARC21.po | 2 +- misc/translator/po/fr-FR-marc-NORMARC.po | 2 +- misc/translator/po/fr-FR-marc-UNIMARC.po | 2 +- misc/translator/po/fr-FR-opac-bootstrap.po | 2 +- misc/translator/po/fr-FR-pref.po | 41 +- misc/translator/po/fr-FR-staff-help.po | 2 +- misc/translator/po/fr-FR-staff-prog.po | 6 +- misc/translator/po/ga-marc-MARC21.po | 2 +- misc/translator/po/ga-marc-NORMARC.po | 2 +- misc/translator/po/ga-marc-UNIMARC.po | 2 +- misc/translator/po/ga-opac-bootstrap.po | 2 +- misc/translator/po/ga-staff-help.po | 2 +- misc/translator/po/ga-staff-prog.po | 2 +- misc/translator/po/gl-marc-MARC21.po | 2 +- misc/translator/po/gl-marc-NORMARC.po | 2 +- misc/translator/po/gl-marc-UNIMARC.po | 2 +- misc/translator/po/gl-opac-bootstrap.po | 2 +- misc/translator/po/gl-staff-help.po | 2 +- misc/translator/po/gl-staff-prog.po | 2 +- misc/translator/po/he-Hebr-marc-MARC21.po | 2 +- misc/translator/po/he-Hebr-marc-NORMARC.po | 2 +- misc/translator/po/he-Hebr-marc-UNIMARC.po | 2 +- misc/translator/po/he-Hebr-opac-bootstrap.po | 2 +- misc/translator/po/he-Hebr-staff-help.po | 2 +- misc/translator/po/he-Hebr-staff-prog.po | 2 +- misc/translator/po/hi-marc-MARC21.po | 2 +- misc/translator/po/hi-marc-NORMARC.po | 2 +- misc/translator/po/hi-marc-UNIMARC.po | 2 +- misc/translator/po/hi-opac-bootstrap.po | 2 +- misc/translator/po/hi-staff-help.po | 2 +- misc/translator/po/hi-staff-prog.po | 2 +- misc/translator/po/hr-HR-marc-MARC21.po | 2 +- misc/translator/po/hr-HR-marc-NORMARC.po | 2 +- misc/translator/po/hr-HR-marc-UNIMARC.po | 2 +- misc/translator/po/hr-HR-opac-bootstrap.po | 2 +- misc/translator/po/hr-HR-staff-help.po | 2 +- misc/translator/po/hr-HR-staff-prog.po | 2 +- misc/translator/po/hu-HU-marc-MARC21.po | 2 +- misc/translator/po/hu-HU-marc-NORMARC.po | 2 +- misc/translator/po/hu-HU-marc-UNIMARC.po | 2 +- misc/translator/po/hu-HU-opac-bootstrap.po | 2 +- misc/translator/po/hu-HU-staff-help.po | 2 +- misc/translator/po/hu-HU-staff-prog.po | 2 +- misc/translator/po/hy-Armn-marc-MARC21.po | 2 +- misc/translator/po/hy-Armn-marc-NORMARC.po | 2 +- misc/translator/po/hy-Armn-marc-UNIMARC.po | 2 +- misc/translator/po/hy-Armn-opac-bootstrap.po | 2 +- misc/translator/po/hy-Armn-staff-help.po | 2 +- misc/translator/po/hy-Armn-staff-prog.po | 2 +- misc/translator/po/ia-marc-MARC21.po | 2 +- misc/translator/po/ia-marc-NORMARC.po | 2 +- misc/translator/po/ia-marc-UNIMARC.po | 2 +- misc/translator/po/ia-opac-bootstrap.po | 2 +- misc/translator/po/ia-staff-help.po | 2 +- misc/translator/po/ia-staff-prog.po | 2 +- misc/translator/po/id-ID-marc-MARC21.po | 2 +- misc/translator/po/id-ID-marc-NORMARC.po | 2 +- misc/translator/po/id-ID-marc-UNIMARC.po | 2 +- misc/translator/po/id-ID-opac-bootstrap.po | 2 +- misc/translator/po/id-ID-staff-help.po | 2 +- misc/translator/po/id-ID-staff-prog.po | 2 +- misc/translator/po/iq-CA-marc-MARC21.po | 2 +- misc/translator/po/iq-CA-marc-NORMARC.po | 2 +- misc/translator/po/iq-CA-marc-UNIMARC.po | 2 +- misc/translator/po/iq-CA-opac-bootstrap.po | 2 +- misc/translator/po/iq-CA-staff-help.po | 2 +- misc/translator/po/iq-CA-staff-prog.po | 2 +- misc/translator/po/is-IS-marc-MARC21.po | 2 +- misc/translator/po/is-IS-marc-NORMARC.po | 2 +- misc/translator/po/is-IS-marc-UNIMARC.po | 2 +- misc/translator/po/is-IS-opac-bootstrap.po | 2 +- misc/translator/po/is-IS-staff-help.po | 2 +- misc/translator/po/is-IS-staff-prog.po | 2 +- misc/translator/po/it-IT-marc-MARC21.po | 2 +- misc/translator/po/it-IT-marc-NORMARC.po | 2 +- misc/translator/po/it-IT-marc-UNIMARC.po | 2 +- misc/translator/po/it-IT-opac-bootstrap.po | 2 +- misc/translator/po/it-IT-staff-help.po | 2 +- misc/translator/po/it-IT-staff-prog.po | 2 +- misc/translator/po/iu-CA-marc-MARC21.po | 2 +- misc/translator/po/iu-CA-marc-NORMARC.po | 2 +- misc/translator/po/iu-CA-marc-UNIMARC.po | 2 +- misc/translator/po/iu-CA-opac-bootstrap.po | 2 +- misc/translator/po/iu-CA-staff-help.po | 2 +- misc/translator/po/iu-CA-staff-prog.po | 2 +- misc/translator/po/ja-Jpan-JP-marc-MARC21.po | 2 +- misc/translator/po/ja-Jpan-JP-marc-NORMARC.po | 2 +- misc/translator/po/ja-Jpan-JP-marc-UNIMARC.po | 2 +- misc/translator/po/ja-Jpan-JP-opac-bootstrap.po | 2 +- misc/translator/po/ja-Jpan-JP-staff-help.po | 2 +- misc/translator/po/ja-Jpan-JP-staff-prog.po | 2 +- misc/translator/po/ka-marc-MARC21.po | 2 +- misc/translator/po/ka-marc-NORMARC.po | 2 +- misc/translator/po/ka-marc-UNIMARC.po | 2 +- misc/translator/po/ka-opac-bootstrap.po | 2 +- misc/translator/po/ka-staff-help.po | 2 +- misc/translator/po/ka-staff-prog.po | 2 +- misc/translator/po/km-KH-marc-MARC21.po | 2 +- misc/translator/po/km-KH-marc-NORMARC.po | 2 +- misc/translator/po/km-KH-marc-UNIMARC.po | 2 +- misc/translator/po/km-KH-opac-bootstrap.po | 2 +- misc/translator/po/km-KH-staff-help.po | 2 +- misc/translator/po/km-KH-staff-prog.po | 2 +- misc/translator/po/kn-Knda-marc-MARC21.po | 2 +- misc/translator/po/kn-Knda-marc-NORMARC.po | 2 +- misc/translator/po/kn-Knda-marc-UNIMARC.po | 2 +- misc/translator/po/kn-Knda-opac-bootstrap.po | 2 +- misc/translator/po/kn-Knda-staff-help.po | 2 +- misc/translator/po/kn-Knda-staff-prog.po | 2 +- misc/translator/po/ko-Kore-KP-marc-MARC21.po | 2 +- misc/translator/po/ko-Kore-KP-marc-NORMARC.po | 2 +- misc/translator/po/ko-Kore-KP-marc-UNIMARC.po | 2 +- misc/translator/po/ko-Kore-KP-opac-bootstrap.po | 2 +- misc/translator/po/ko-Kore-KP-staff-help.po | 2 +- misc/translator/po/ko-Kore-KP-staff-prog.po | 2 +- misc/translator/po/ku-Arab-marc-MARC21.po | 2 +- misc/translator/po/ku-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ku-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/ku-Arab-opac-bootstrap.po | 2 +- misc/translator/po/ku-Arab-staff-help.po | 2 +- misc/translator/po/ku-Arab-staff-prog.po | 2 +- misc/translator/po/lo-Laoo-marc-MARC21.po | 2 +- misc/translator/po/lo-Laoo-marc-NORMARC.po | 2 +- misc/translator/po/lo-Laoo-marc-UNIMARC.po | 2 +- misc/translator/po/lo-Laoo-opac-bootstrap.po | 2 +- misc/translator/po/lo-Laoo-staff-help.po | 2 +- misc/translator/po/lo-Laoo-staff-prog.po | 2 +- misc/translator/po/mi-NZ-marc-MARC21.po | 2 +- misc/translator/po/mi-NZ-marc-NORMARC.po | 2 +- misc/translator/po/mi-NZ-marc-UNIMARC.po | 2 +- misc/translator/po/mi-NZ-opac-bootstrap.po | 2 +- misc/translator/po/mi-NZ-staff-help.po | 2 +- misc/translator/po/mi-NZ-staff-prog.po | 2 +- misc/translator/po/ml-marc-MARC21.po | 2 +- misc/translator/po/ml-marc-NORMARC.po | 2 +- misc/translator/po/ml-marc-UNIMARC.po | 2 +- misc/translator/po/ml-opac-bootstrap.po | 2 +- misc/translator/po/ml-staff-help.po | 2 +- misc/translator/po/ml-staff-prog.po | 2 +- misc/translator/po/mon-marc-MARC21.po | 2 +- misc/translator/po/mon-marc-NORMARC.po | 2 +- misc/translator/po/mon-marc-UNIMARC.po | 2 +- misc/translator/po/mon-opac-bootstrap.po | 2 +- misc/translator/po/mon-staff-help.po | 2 +- misc/translator/po/mon-staff-prog.po | 2 +- misc/translator/po/mr-marc-MARC21.po | 2 +- misc/translator/po/mr-marc-NORMARC.po | 2 +- misc/translator/po/mr-marc-UNIMARC.po | 2 +- misc/translator/po/mr-opac-bootstrap.po | 2 +- misc/translator/po/mr-staff-help.po | 2 +- misc/translator/po/mr-staff-prog.po | 2 +- misc/translator/po/ms-MY-marc-MARC21.po | 2 +- misc/translator/po/ms-MY-marc-NORMARC.po | 2 +- misc/translator/po/ms-MY-marc-UNIMARC.po | 2 +- misc/translator/po/ms-MY-opac-bootstrap.po | 2 +- misc/translator/po/ms-MY-staff-help.po | 2 +- misc/translator/po/ms-MY-staff-prog.po | 2 +- misc/translator/po/my-marc-MARC21.po | 2 +- misc/translator/po/my-marc-NORMARC.po | 2 +- misc/translator/po/my-marc-UNIMARC.po | 2 +- misc/translator/po/my-opac-bootstrap.po | 2 +- misc/translator/po/my-staff-help.po | 2 +- misc/translator/po/my-staff-prog.po | 2 +- misc/translator/po/nb-NO-marc-MARC21.po | 2 +- misc/translator/po/nb-NO-marc-NORMARC.po | 2 +- misc/translator/po/nb-NO-marc-UNIMARC.po | 2 +- misc/translator/po/nb-NO-opac-bootstrap.po | 2 +- misc/translator/po/nb-NO-staff-help.po | 2 +- misc/translator/po/nb-NO-staff-prog.po | 2 +- misc/translator/po/ne-NE-marc-MARC21.po | 2 +- misc/translator/po/ne-NE-marc-NORMARC.po | 2 +- misc/translator/po/ne-NE-marc-UNIMARC.po | 2 +- misc/translator/po/ne-NE-opac-bootstrap.po | 2 +- misc/translator/po/ne-NE-staff-help.po | 2 +- misc/translator/po/ne-NE-staff-prog.po | 2 +- misc/translator/po/nl-BE-marc-MARC21.po | 2 +- misc/translator/po/nl-BE-marc-NORMARC.po | 2 +- misc/translator/po/nl-BE-marc-UNIMARC.po | 2 +- misc/translator/po/nl-BE-opac-bootstrap.po | 2 +- misc/translator/po/nl-BE-staff-help.po | 2 +- misc/translator/po/nl-BE-staff-prog.po | 2 +- misc/translator/po/nl-NL-marc-MARC21.po | 2 +- misc/translator/po/nl-NL-marc-NORMARC.po | 2 +- misc/translator/po/nl-NL-marc-UNIMARC.po | 2 +- misc/translator/po/nl-NL-opac-bootstrap.po | 2 +- misc/translator/po/nl-NL-staff-help.po | 2 +- misc/translator/po/nl-NL-staff-prog.po | 2 +- misc/translator/po/nn-NO-marc-MARC21.po | 2 +- misc/translator/po/nn-NO-marc-NORMARC.po | 2 +- misc/translator/po/nn-NO-marc-UNIMARC.po | 2 +- misc/translator/po/nn-NO-opac-bootstrap.po | 2 +- misc/translator/po/nn-NO-staff-help.po | 2 +- misc/translator/po/nn-NO-staff-prog.po | 2 +- misc/translator/po/oc-marc-MARC21.po | 2 +- misc/translator/po/oc-marc-NORMARC.po | 2 +- misc/translator/po/oc-marc-UNIMARC.po | 2 +- misc/translator/po/oc-opac-bootstrap.po | 2 +- misc/translator/po/oc-staff-help.po | 2 +- misc/translator/po/oc-staff-prog.po | 2 +- misc/translator/po/pbr-marc-MARC21.po | 2 +- misc/translator/po/pbr-marc-NORMARC.po | 2 +- misc/translator/po/pbr-marc-UNIMARC.po | 2 +- misc/translator/po/pbr-opac-bootstrap.po | 2 +- misc/translator/po/pbr-staff-help.po | 2 +- misc/translator/po/pbr-staff-prog.po | 2 +- misc/translator/po/pl-PL-marc-MARC21.po | 2 +- misc/translator/po/pl-PL-marc-NORMARC.po | 2 +- misc/translator/po/pl-PL-marc-UNIMARC.po | 2 +- misc/translator/po/pl-PL-opac-bootstrap.po | 2 +- misc/translator/po/pl-PL-staff-help.po | 2 +- misc/translator/po/pl-PL-staff-prog.po | 2 +- misc/translator/po/prs-marc-MARC21.po | 2 +- misc/translator/po/prs-marc-NORMARC.po | 2 +- misc/translator/po/prs-marc-UNIMARC.po | 2 +- misc/translator/po/prs-opac-bootstrap.po | 2 +- misc/translator/po/prs-staff-help.po | 2 +- misc/translator/po/prs-staff-prog.po | 2 +- misc/translator/po/pt-BR-marc-MARC21.po | 2 +- misc/translator/po/pt-BR-marc-NORMARC.po | 2 +- misc/translator/po/pt-BR-marc-UNIMARC.po | 2 +- misc/translator/po/pt-BR-opac-bootstrap.po | 2 +- misc/translator/po/pt-BR-staff-help.po | 2 +- misc/translator/po/pt-BR-staff-prog.po | 2 +- misc/translator/po/pt-PT-marc-MARC21.po | 2 +- misc/translator/po/pt-PT-marc-NORMARC.po | 2 +- misc/translator/po/pt-PT-marc-UNIMARC.po | 2 +- misc/translator/po/pt-PT-opac-bootstrap.po | 2 +- misc/translator/po/pt-PT-staff-help.po | 2 +- misc/translator/po/pt-PT-staff-prog.po | 10 +- misc/translator/po/ro-RO-marc-MARC21.po | 2 +- misc/translator/po/ro-RO-marc-NORMARC.po | 2 +- misc/translator/po/ro-RO-marc-UNIMARC.po | 2 +- misc/translator/po/ro-RO-opac-bootstrap.po | 2 +- misc/translator/po/ro-RO-staff-help.po | 2 +- misc/translator/po/ro-RO-staff-prog.po | 2 +- misc/translator/po/ru-RU-marc-MARC21.po | 2 +- misc/translator/po/ru-RU-marc-NORMARC.po | 2 +- misc/translator/po/ru-RU-marc-UNIMARC.po | 2 +- misc/translator/po/ru-RU-opac-bootstrap.po | 2 +- misc/translator/po/ru-RU-staff-help.po | 2 +- misc/translator/po/ru-RU-staff-prog.po | 2 +- misc/translator/po/rw-RW-marc-MARC21.po | 2 +- misc/translator/po/rw-RW-marc-NORMARC.po | 2 +- misc/translator/po/rw-RW-marc-UNIMARC.po | 2 +- misc/translator/po/rw-RW-opac-bootstrap.po | 2 +- misc/translator/po/rw-RW-staff-help.po | 2 +- misc/translator/po/rw-RW-staff-prog.po | 2 +- misc/translator/po/sd-PK-marc-MARC21.po | 2 +- misc/translator/po/sd-PK-marc-NORMARC.po | 2 +- misc/translator/po/sd-PK-marc-UNIMARC.po | 2 +- misc/translator/po/sd-PK-opac-bootstrap.po | 2 +- misc/translator/po/sd-PK-staff-help.po | 2 +- misc/translator/po/sd-PK-staff-prog.po | 2 +- misc/translator/po/sk-SK-marc-MARC21.po | 2 +- misc/translator/po/sk-SK-marc-NORMARC.po | 2 +- misc/translator/po/sk-SK-marc-UNIMARC.po | 2 +- misc/translator/po/sk-SK-opac-bootstrap.po | 14 +- misc/translator/po/sk-SK-staff-help.po | 2 +- misc/translator/po/sk-SK-staff-prog.po | 2 +- misc/translator/po/sl-SI-marc-MARC21.po | 2 +- misc/translator/po/sl-SI-marc-NORMARC.po | 2 +- misc/translator/po/sl-SI-marc-UNIMARC.po | 2 +- misc/translator/po/sl-SI-opac-bootstrap.po | 2 +- misc/translator/po/sl-SI-staff-help.po | 2 +- misc/translator/po/sl-SI-staff-prog.po | 2 +- misc/translator/po/sq-AL-marc-MARC21.po | 2 +- misc/translator/po/sq-AL-marc-NORMARC.po | 2 +- misc/translator/po/sq-AL-marc-UNIMARC.po | 2 +- misc/translator/po/sq-AL-opac-bootstrap.po | 2 +- misc/translator/po/sq-AL-staff-help.po | 2 +- misc/translator/po/sq-AL-staff-prog.po | 2 +- misc/translator/po/sr-Cyrl-marc-MARC21.po | 2 +- misc/translator/po/sr-Cyrl-marc-NORMARC.po | 2 +- misc/translator/po/sr-Cyrl-marc-UNIMARC.po | 2 +- misc/translator/po/sr-Cyrl-opac-bootstrap.po | 2 +- misc/translator/po/sr-Cyrl-staff-help.po | 2 +- misc/translator/po/sr-Cyrl-staff-prog.po | 2 +- misc/translator/po/sv-SE-marc-MARC21.po | 2 +- misc/translator/po/sv-SE-marc-NORMARC.po | 2 +- misc/translator/po/sv-SE-marc-UNIMARC.po | 2 +- misc/translator/po/sv-SE-opac-bootstrap.po | 2 +- misc/translator/po/sv-SE-staff-help.po | 2 +- misc/translator/po/sv-SE-staff-prog.po | 119 +++--- misc/translator/po/sw-KE-marc-MARC21.po | 2 +- misc/translator/po/sw-KE-marc-NORMARC.po | 2 +- misc/translator/po/sw-KE-marc-UNIMARC.po | 2 +- misc/translator/po/sw-KE-opac-bootstrap.po | 2 +- misc/translator/po/sw-KE-staff-help.po | 2 +- misc/translator/po/sw-KE-staff-prog.po | 2 +- misc/translator/po/ta-LK-marc-MARC21.po | 2 +- misc/translator/po/ta-LK-marc-NORMARC.po | 2 +- misc/translator/po/ta-LK-marc-UNIMARC.po | 2 +- misc/translator/po/ta-LK-opac-bootstrap.po | 2 +- misc/translator/po/ta-LK-staff-help.po | 2 +- misc/translator/po/ta-LK-staff-prog.po | 2 +- misc/translator/po/ta-marc-MARC21.po | 2 +- misc/translator/po/ta-marc-NORMARC.po | 2 +- misc/translator/po/ta-marc-UNIMARC.po | 2 +- misc/translator/po/ta-opac-bootstrap.po | 2 +- misc/translator/po/ta-staff-help.po | 2 +- misc/translator/po/ta-staff-prog.po | 2 +- misc/translator/po/tet-marc-MARC21.po | 2 +- misc/translator/po/tet-marc-NORMARC.po | 2 +- misc/translator/po/tet-marc-UNIMARC.po | 2 +- misc/translator/po/tet-opac-bootstrap.po | 2 +- misc/translator/po/tet-staff-help.po | 2 +- misc/translator/po/tet-staff-prog.po | 2 +- misc/translator/po/th-TH-marc-MARC21.po | 2 +- misc/translator/po/th-TH-marc-NORMARC.po | 2 +- misc/translator/po/th-TH-marc-UNIMARC.po | 2 +- misc/translator/po/th-TH-opac-bootstrap.po | 2 +- misc/translator/po/th-TH-staff-help.po | 2 +- misc/translator/po/th-TH-staff-prog.po | 2 +- misc/translator/po/tl-PH-marc-MARC21.po | 2 +- misc/translator/po/tl-PH-marc-NORMARC.po | 2 +- misc/translator/po/tl-PH-marc-UNIMARC.po | 2 +- misc/translator/po/tl-PH-opac-bootstrap.po | 2 +- misc/translator/po/tl-PH-staff-help.po | 2 +- misc/translator/po/tl-PH-staff-prog.po | 2 +- misc/translator/po/tr-TR-marc-MARC21.po | 2 +- misc/translator/po/tr-TR-marc-NORMARC.po | 2 +- misc/translator/po/tr-TR-marc-UNIMARC.po | 2 +- misc/translator/po/tr-TR-opac-bootstrap.po | 2 +- misc/translator/po/tr-TR-staff-help.po | 2 +- misc/translator/po/tr-TR-staff-prog.po | 2 +- misc/translator/po/tvl-marc-MARC21.po | 2 +- misc/translator/po/tvl-marc-NORMARC.po | 2 +- misc/translator/po/tvl-marc-UNIMARC.po | 2 +- misc/translator/po/tvl-opac-bootstrap.po | 2 +- misc/translator/po/tvl-staff-help.po | 2 +- misc/translator/po/tvl-staff-prog.po | 2 +- misc/translator/po/uk-UA-marc-MARC21.po | 2 +- misc/translator/po/uk-UA-marc-NORMARC.po | 2 +- misc/translator/po/uk-UA-marc-UNIMARC.po | 2 +- misc/translator/po/uk-UA-opac-bootstrap.po | 2 +- misc/translator/po/uk-UA-staff-help.po | 2 +- misc/translator/po/uk-UA-staff-prog.po | 2 +- misc/translator/po/ur-Arab-marc-MARC21.po | 2 +- misc/translator/po/ur-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ur-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/ur-Arab-opac-bootstrap.po | 2 +- misc/translator/po/ur-Arab-staff-help.po | 2 +- misc/translator/po/ur-Arab-staff-prog.po | 2 +- misc/translator/po/vi-VN-marc-MARC21.po | 2 +- misc/translator/po/vi-VN-marc-NORMARC.po | 2 +- misc/translator/po/vi-VN-marc-UNIMARC.po | 2 +- misc/translator/po/vi-VN-opac-bootstrap.po | 2 +- misc/translator/po/vi-VN-staff-help.po | 2 +- misc/translator/po/vi-VN-staff-prog.po | 2 +- misc/translator/po/zh-Hans-CN-marc-MARC21.po | 2 +- misc/translator/po/zh-Hans-CN-marc-NORMARC.po | 2 +- misc/translator/po/zh-Hans-CN-marc-UNIMARC.po | 2 +- misc/translator/po/zh-Hans-CN-opac-bootstrap.po | 2 +- misc/translator/po/zh-Hans-CN-staff-help.po | 2 +- misc/translator/po/zh-Hans-CN-staff-prog.po | 2 +- misc/translator/po/zh-Hant-TW-marc-MARC21.po | 2 +- misc/translator/po/zh-Hant-TW-marc-NORMARC.po | 2 +- misc/translator/po/zh-Hant-TW-marc-UNIMARC.po | 2 +- misc/translator/po/zh-Hant-TW-opac-bootstrap.po | 2 +- misc/translator/po/zh-Hant-TW-staff-help.po | 2 +- misc/translator/po/zh-Hant-TW-staff-prog.po | 2 +- opac/clubs/clubs-tab.pl | 2 +- opac/clubs/enroll.pl | 2 +- opac/opac-account-pay.pl | 2 +- opac/opac-addbybiblionumber.pl | 2 +- opac/opac-alert-subscribe.pl | 2 +- opac/opac-article-request-cancel.pl | 13 +- opac/opac-illrequests.pl | 2 +- opac/opac-request-article.pl | 2 +- opac/opac-reserve.pl | 15 +- opac/opac-sendbasket.pl | 4 +- opac/opac-sendshelf.pl | 6 +- opac/opac-shareshelf.pl | 3 +- opac/opac-shelves.pl | 1 + opac/opac-suggestions.pl | 2 +- opac/svc/auth/googleopenidconnect | 2 +- virtualshelves/shelves.pl | 1 + 522 files changed, 1159 insertions(+), 1088 deletions(-) copy misc/release_notes/{release_notes_17_11_17.html => release_notes_17_11_18.html} (72%) copy misc/release_notes/{release_notes_17_11_17.md => release_notes_17_11_18.md} (68%) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 30 09:40:21 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 30 May 2019 07:40:21 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.05-52-gc276dd6 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via c276dd6397211bacdc1881ec853619496b5bc53f (commit) via 20d62cf1c6d31766a2d21ef0e83785f14934c9dc (commit) via a2b68c92fec8e48a00aa663866245c67aae48029 (commit) via b74763da098ffed73228f355316e9e23463c2894 (commit) via fdaf56ec101f60175986be97db670ea6f68d41a0 (commit) via 03a09852697f5f53be3551ddd8bdb1dfdb33417b (commit) via f1eb918616666fe23f9d13aa5c0fea72a6d890d1 (commit) via e0eea1b15d727085a3a22932d813c9fe3b8f8088 (commit) via f9820f38a8a96e5529cc476f043b86b9398d0bd7 (commit) via 8375bdbd53c09de3ebf406662ff6f3a6ba9ce3ee (commit) via 9b471e00f050108029c51ed4a9821eb64f7f9611 (commit) via d8e0930549e3578155acd7db533f0a42d605190a (commit) via 69e27289868cae86446ad77492d4405ee49adaba (commit) from 396073150e0371471e18ec975a7ba4f2dbe4b3ea (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c276dd6397211bacdc1881ec853619496b5bc53f Author: Jonathan Druart Date: Wed May 1 21:05:30 2019 -0400 Bug 22781: Correctly filter the emails Ho, another bug! The email was not correctly filtered. Test plan: Use the evil string for an email, do a search. => Notice that without this patch the results never show up Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens (cherry picked from commit 5410186f6829fc4b74a845e8954bd7eea3f19862) Signed-off-by: Martin Renvoize commit 20d62cf1c6d31766a2d21ef0e83785f14934c9dc Author: Jonathan Druart Date: Wed May 1 20:54:02 2019 -0400 Bug 22781: Does not double filter address Ho, a bug! Some fields in the address where double filtered. Test plan: Use the evil strings in the address field and do a search, you will see double html encoded characters without this patch. Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens (cherry picked from commit ecb12104ffc7284089a1c8134ca8811e99e7419c) Signed-off-by: Martin Renvoize commit a2b68c92fec8e48a00aa663866245c67aae48029 Author: Jonathan Druart Date: Wed May 1 20:29:05 2019 -0400 Bug 22781: Test patron's info filtering The patron's data was not correctly escaped actually. Test plan: This is a good value for the whole patchset: fir's"tname \123 ? use it for a patron's firstname, then do a search Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens (cherry picked from commit 35d00030ceb572822979300a5291356a32427a16) Signed-off-by: Martin Renvoize commit b74763da098ffed73228f355316e9e23463c2894 Author: Jonathan Druart Date: Wed May 1 20:28:04 2019 -0400 Bug 22781: Escape cardnumber, category's description, library's name and dateexpiry This will fix the previous failure. Note that other fields like borrowernumber, Price escaped values, integers, etc. could be escaped the same way but will be useless (save polar bears). Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens (cherry picked from commit 3a3057545c56f4f1a41fcd7643265204844cd2d3) Signed-off-by: Martin Renvoize commit fdaf56ec101f60175986be97db670ea6f68d41a0 Author: Jonathan Druart Date: Wed May 1 20:28:55 2019 -0400 Bug 22781: Add tests Test plan: Apply only this patch => The tests will fail, the library's name is not correctly escaped. Note: This applies for the whole patchset, when the tests fail you will need to remove the patrons added by the tests with the following SQL query: delete from borrowers where surname like "test_patron_%"; We are expecting END to be called even if something goes wrong, but DESTROY must be used instead. This will be fixed separately, on its own bug report. Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens (cherry picked from commit 6e8ecb8c6c8cf5d5188d2ad138e4fdbd8f395b3e) Signed-off-by: Martin Renvoize commit 03a09852697f5f53be3551ddd8bdb1dfdb33417b Author: Martin Renvoize Date: Mon Feb 11 14:04:01 2019 +0000 Bug 22225: Correctly use invoiceincgst over listincgst Mistakenly, we were looking at listincgst in the templates but using invoiceincgst in the scripts. This patch rectifies that by switching to use invoiceincgst in the templates too. Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens (cherry picked from commit 43047ee734e2b6b650e43710a712390433cbb2bd) Signed-off-by: Martin Renvoize commit f1eb918616666fe23f9d13aa5c0fea72a6d890d1 Author: Jonathan Druart Date: Fri May 10 12:27:40 2019 -0500 Bug 22878: Do not pass layout_id on creating a layout Attempting to create a patron card layout with mysql strict mode on gives the following error: DBD::mysql::st execute failed: Incorrect integer value: '' for column 'layout_id' at row 1 Test plan: - Turn on sql_strict_modes - Create a new patron card => Must success with this patch applied Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens (cherry picked from commit 8d53fae9494b50c0cf2dcc98b18982b0d8fc416f) Signed-off-by: Martin Renvoize commit e0eea1b15d727085a3a22932d813c9fe3b8f8088 Author: Jonathan Druart Date: Fri May 10 12:27:34 2019 -0500 Bug 22878: Add tests Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens (cherry picked from commit 9f18afa7b34574cd872c94ee366a8d3e75085413) Signed-off-by: Martin Renvoize commit f9820f38a8a96e5529cc476f043b86b9398d0bd7 Author: Aleisha Amohia Date: Mon Apr 29 03:14:35 2019 +0000 Bug 7862: Preventing warns when creating a notice To reproduce warns: 1) Go to Tools -> Notices & slips 2) Create a new notice of any module Notice these warns: Use of uninitialized value $code in regexp compilation at /home/vagrant/kohaclone/tools/letter.pl line 265. Use of uninitialized value $code in regexp compilation at /home/vagrant/kohaclone/tools/letter.pl line 265. Use of uninitialized value $code in regexp compilation at /home/vagrant/kohaclone/tools/letter.pl line 265. CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_svc_letters_get line 50, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_svc_letters_get line 50, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. 3) Create a new notice of the Circulation module Notice this additional warn: Use of uninitialized value $code in pattern match (m//) at /home/vagrant/kohaclone/tools/letter.pl line 258. To test: 4) Apply patch and refresh page 5) Run steps 1-3 again and confirm no warns show Sponsored-by: Catalyst IT Signed-off-by: Maryse Simard Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens (cherry picked from commit 700b7dfa09e38c074cebbbb5caac64e031d5c0d5) Signed-off-by: Martin Renvoize commit 8375bdbd53c09de3ebf406662ff6f3a6ba9ce3ee Author: Nick Clemens Date: Wed May 15 12:10:15 2019 +0000 Bug 22836: (follow-up) improve test message Signed-off-by: Nick Clemens (cherry picked from commit 92ab7f66eb5371596d8c46e56f4fdb503ed5d81c) Signed-off-by: Martin Renvoize commit 9b471e00f050108029c51ed4a9821eb64f7f9611 Author: Jonathan Druart Date: Thu May 2 21:04:54 2019 -0400 Bug 22836: (follow-up) Bug 22478: (QA follow-up) Make test consistent with variable name One occurrence was missing. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens (cherry picked from commit 7799f4ddd1f1fe111081dc3695c9038fa500e961) Signed-off-by: Martin Renvoize commit d8e0930549e3578155acd7db533f0a42d605190a Author: Jonathan Druart Date: Thu May 2 20:49:45 2019 -0400 Revert "Bug 22478: (QA follow-up) Handle category in opac-shelves like a boolean" This reverts commit 375dd35d5354d46c4c16f534494b123ce370c3f4. https://bugs.koha-community.org/show_bug.cgi?id=22836 Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens (cherry picked from commit 7bed2a3fe61ff605b636e292e73b96947de23b29) Signed-off-by: Martin Renvoize commit 69e27289868cae86446ad77492d4405ee49adaba Author: Jonathan Druart Date: Thu May 2 20:49:37 2019 -0400 Revert "Bug 22478: (QA follow-up) Update tests to check for any script tags" This reverts commit d9b3b90849fd95d296b73b330c4e32ff018c81a5. https://bugs.koha-community.org/show_bug.cgi?id=22836 Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens (cherry picked from commit c265fcc476bc4d4fc74d5a23c0d5ef8ef21650b2) Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Creators/Layout.pm | 1 + acqui/orderreceive.pl | 1 - .../prog/en/modules/acqui/orderreceive.tt | 4 +- .../en/modules/members/tables/members_results.tt | 18 +-- opac/opac-shelves.pl | 1 - svc/letters/get | 4 +- t/Patroncards_Layout.t | 14 --- t/db_dependent/Patroncards.t | 34 ++++++ t/db_dependent/selenium/patrons_search.t | 117 ++++++++++++++++++++ t/db_dependent/selenium/regressions.t | 5 +- tools/letter.pl | 11 +- virtualshelves/shelves.pl | 1 - 12 files changed, 175 insertions(+), 36 deletions(-) delete mode 100755 t/Patroncards_Layout.t create mode 100755 t/db_dependent/Patroncards.t create mode 100644 t/db_dependent/selenium/patrons_search.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 30 12:50:52 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 30 May 2019 10:50:52 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v18.11.00-1622-ge65b708 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via e65b708f5385aa9df352cebe3c688a152fe1e176 (commit) via 122d92b9f89ddb22d58134c48dd8fb296fa84f3d (commit) via 22eba6b957fe763f5bcb0412585966dece5d9ea2 (commit) via 8e9cd13d98f5574cc327c02679f612c4f4e18956 (commit) via 9c4f36862261ed1be89770c90f0cfa8b019f5226 (commit) via 7d42e29c8b8cd913b052d10525c4d0b2cb36fc0d (commit) via 02305630824e46c9c7846aa6f163265970463d1e (commit) via 8fed07826ee9fd69f3b92bbb6decb864e4c7dfd2 (commit) via 2329d2ea8393e133bf689eb2d311fb0bcc99640f (commit) via 936cf409992d6393473f564a25f70ea8b390e74b (commit) via 1cdf657c057a7a565016df28a17151a2f4fce134 (commit) via bb06060c4c3e0f4393f24096400ee4c8312a44ec (commit) via 427e4ebc6ba4d52154bc8330b8edf54d5a6b88b2 (commit) via 848a0d41fffba7df1be9f2584770112f0938beb0 (commit) via 366ef794969c3bc67c70ea7c9d85cb04944f4f05 (commit) via 3034c028264f072fc1a447a11a518255282fc990 (commit) via d36566d6eaa9dd02528bbd1219747ccfd4e6b531 (commit) via f5894d41d21b3d57217397f7d8de500082e66157 (commit) via 39c4d9d55e5a2e137adbbbd2b29b5b829f66b59e (commit) via 9613d9f1647bfceeb15b60c731f2c84796a12f87 (commit) via 990c94721c0822d4660021080f52f5c5edf2ef66 (commit) via bf501498634eca478f7f902bb9e41c42731c7622 (commit) via 533ff7ab29a1ca6d35d0e306dd97273838ad3064 (commit) from e9aa9b84fcc1b18a7988b380760374c8c9a6848d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e65b708f5385aa9df352cebe3c688a152fe1e176 Author: Fridolin Somers Date: Tue May 14 08:22:43 2019 +0200 Bug 22901: On items search fix search field change listening In items search, when there is a custom field with authorised values : when changing the conditional select AND/OR then the authorised values select disappears. This behaviour is like when the search field is changed. The bug is that JavaScript code meaning search field change listens on all selects instead of only search field select. Test plan : 1) Define a custom items search field with authorised values 2) Go to items search 3) Click on 'New field' 4) On second line, select custom field 5) The authorised values select appears 6) Select 'AND' in conditional select 7) Without patch the authorised values select disappears, with patch nothing changes 8) On second line, select a non-custom field 9) The authorised values select is replaced by a text field 10) On second line, select custom field 11) The authorised values select appears Signed-off-by: Maryse Simard Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit 122d92b9f89ddb22d58134c48dd8fb296fa84f3d Author: Owen Leonard Date: Thu May 23 18:35:31 2019 +0000 Bug 22981: Remove type attribute from script tags: Catalog This patch removes the "type" attribute from