[koha-commits] main Koha release repository branch 18.11.x updated. v18.11.05-4-gab351fd
Git repo owner
gitmaster at git.koha-community.org
Wed May 8 16:34:40 CEST 2019
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 18.11.x has been updated
via ab351fdb42bcae228aa82e8f0655e4be3a231551 (commit)
via 3477fc785fef1ca60051709509f05e296d320061 (commit)
via 5b9f4cd775bfafbd6989c30b0435bd47c0014434 (commit)
via 0a848d49012d2beef5627a89f9ad8544615fa35c (commit)
from 8fab429baa5d4e9f2f96ae34945205d9e09610b0 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit ab351fdb42bcae228aa82e8f0655e4be3a231551
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Wed Feb 27 07:09:12 2019 -0300
Bug 22420: Remove wrong calculation on approved tags
Before the patch from bug 14385, the passed structure (that is returned
by get_approval_rows() looks like:
\ [
[0] {
approved 1,
approved_by 51,
approved_by_name undef,
date_approved "2019-02-26 15:36:42",
term "another",
weight_total 3
},
[1] {
...
After the introduced 'filtering', we loose the information about the
term weight!:
\ [
[0] {
approved 1,
author "Heylin, Clinton.",
biblionumber 1,
borrowernumber 51,
date_created "2019-02-26 15:36:37",
language undef,
subtitle [],
tag_id 1,
term "word",
time_created_display "15:36:37",
title "E Street shuffle :",
visible 1,
XSLTBloc "
<<<BUNCH OF GENERATED HTML HERE>>>
...
The code even calls GetMarcBiblio. This needs to be reverted as it is
plain wrong. If it was worth removing *some* biblios from the
weight_total value, then this calculation should be done somewhere else,
without fetching the MARC data again.
Signed-off-by: Claudio <costalc at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 28bcc5aa68733e41d50a6a801088b06857968f42)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 3477fc785fef1ca60051709509f05e296d320061
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Mon Dec 17 13:35:09 2018 +0000
Bug 22010: Check preferences for ebook integration
To test:
1 - Enable OverDrive and RecordedBooks (you can put anything in the
prefs)
2 - Search on the opac - verify you get results (or search error) on
first page of results'
3 - Go to second page of results - OD and RB are not searched
4 - Apply patch
5 - Verify nothing has changed
If you have valid credentials:
1 - Enable RB prefs
2 - Sign in with an account that has an email matching your registered
account for recordedbooks
3 - Confirm you RB account loads on opac-user.pl
Otherwise:
Read the patches, verify it all makes sense
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 7a44c9edb969cd92db4de0223a2c9db06d576451)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 5b9f4cd775bfafbd6989c30b0435bd47c0014434
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Sun Apr 28 21:40:21 2019 -0400
Bug 22357: Do not duplicate report rows if several reports exist
At the moment every time you run runreport.pl with the --store-results
option another line will appear for your report in the saved
reports table. This is not a data, but a display problem as the
report is still only stored once.
1) Create a report and note the report number
2) Run from command line (replace X by report number) :
misc/cronjobs/runreport.pl X --format=csv --csv-header --store-results
3) Go to saved reports table
4) Look at the table, each run of the cronjob will create a new row
in the table instead of just updating the saved results column.
5) Apply patch
6) Veriy the table displays correctly again and there are no regressions
QA: Run t/db_dependent/Reports/Guided.t
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 4ca1d8e3b3f60722321f9f4b5f1f0caa461beecb)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 0a848d49012d2beef5627a89f9ad8544615fa35c
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Apr 26 20:49:14 2019 -0400
Bug 22717: (bug 20287 follow-up) Fix Google OpenId auto registration
Silly bug caused by:
commit ef410fd62f279a10687636a4f26babb2c91ecadc
Bug 20287: Replace occurrences of AddMember with Koha::Patron->new->store->borrowernumber
Constructors take a hashref!
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 59b740613e7a72bf6e5283c2876bad9444a7ef6a)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
-----------------------------------------------------------------------
Summary of changes:
C4/External/OverDrive.pm | 18 -------
C4/Reports/Guided.pm | 3 +-
.../bootstrap/en/includes/opac-bottom.inc | 5 +-
.../bootstrap/en/modules/opac-overdrive-search.tt | 2 +-
.../opac-tmpl/bootstrap/en/modules/opac-results.tt | 7 ++-
opac/opac-search.pl | 6 +--
opac/opac-tags.pl | 18 -------
opac/svc/auth/googleopenidconnect | 4 +-
opac/svc/overdrive_proxy | 2 +-
t/External/OverDrive.t | 55 --------------------
10 files changed, 17 insertions(+), 103 deletions(-)
delete mode 100755 t/External/OverDrive.t
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list