[koha-commits] main Koha release repository branch master updated. v18.11.00-1531-g735d23c

Git repo owner gitmaster at git.koha-community.org
Tue May 14 20:40:13 CEST 2019


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  735d23c299669b40d3e3e2a4fe21b88fc6cca00f (commit)
       via  6692800794cbf403e8be8c8062608b60148c0d56 (commit)
       via  6d1b7ff27eb2d53d637c169c7132a66d546c0124 (commit)
       via  a7419482c1e08b4de2dd707e4a7c4b3185ebb771 (commit)
       via  d4b503aa14b9297889c2a5b6f18fd2132c7bb304 (commit)
       via  b90bbc125969dc0048dde2ec37531a6ef6cd2b36 (commit)
       via  5c81d986212b480d9b491e46b3fb4498c0eb2c2c (commit)
       via  49a6aac8b6d8fd13999638f5a6ae4d4481dbf304 (commit)
       via  f21ebad7d298f25e44771e5833d1d1d4d6d8f777 (commit)
       via  af1067f3d466cf3bd32c4747c4a00dd7542c1fe0 (commit)
       via  f45fe692b14f45300456327bc74fd0a0872dff75 (commit)
      from  31684a426be4dcdf75a06f1f15fcfc73726fa6ae (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 735d23c299669b40d3e3e2a4fe21b88fc6cca00f
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed May 8 16:37:40 2019 -0500

    Bug 11853: Add tests
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 6692800794cbf403e8be8c8062608b60148c0d56
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed May 8 16:37:50 2019 -0500

    Bug 11853: Allow to clear the date of birth at the OPAC
    
    A patron is not able to clear their date of birth.
    
    When cleared tt is set to NULL in DB which means, for the patron's
    modifications feature, that nothing has been changed.
    
    Test plan:
    0/ Do not apply the patch
    1/ Edit your personal details at the OPAC
    2/ Add a date of birth
    3/ On the staff interface, approve the modification request
    => OK it is updated
    4/ Edit your personal details and clear the date of birth
    5/ On the staff interface
    => KO the table display is wrong, nothing is marked has changed
    6/ Approve the modification requiest
    => KO it has not been cleared
    7/ Apply the patch and repeat 1 to 6 and confirm that the behaviors are
    now correct.
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 6d1b7ff27eb2d53d637c169c7132a66d546c0124
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Fri May 10 13:24:39 2019 +0000

    Bug 22881: Trying to clear search history via the navbar X doesn't clear any searches
    
    This patch undoes a mistake introduced in my patch for Bug 21479. A
    "preventDefault()" was added to the search history clear button by
    mistake. The "confirmDelete" function only works if the default action
    of the link is allowed to complete.
    
    To test you must have the EnableOpacSearchHistory system preference
    enabled. Apply the patch and log into the OPAC as a patron who has a
    search history.
    
    Click the "X" link in the header next to the "Search history" link.
    Confirm that you want to clear your search history. The page should
    refresh. Navigate to your account -> Your search history to confirm that
    your search history has been cleared.
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit a7419482c1e08b4de2dd707e4a7c4b3185ebb771
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Sun May 12 19:26:41 2019 -0500

    Bug 22893: Embed contributors.yaml for debian packages
    
    Like history.txt we need to tell some debian/ files to copy contributors.yaml
    Also pick it for the `make install` process (Makefile.PL)
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit d4b503aa14b9297889c2a5b6f18fd2132c7bb304
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Sun May 12 19:22:54 2019 -0500

    Bug 22893: Do not crash if contributors.yaml does not exist
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit b90bbc125969dc0048dde2ec37531a6ef6cd2b36
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Tue May 14 18:15:54 2019 +0000

    Bug 22899: DBRev 18.12.00.075
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 5c81d986212b480d9b491e46b3fb4498c0eb2c2c
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Tue May 14 13:21:55 2019 +0100

    Bug 22899: (QA follow-up) Change accessor name
    
    This patch changes pending_hold to has_pending_hold to signify that
    we're returning a boolean and not a Koha::Hold object.
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 49a6aac8b6d8fd13999638f5a6ae4d4481dbf304
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Tue May 14 13:17:01 2019 +0100

    Bug 22899: (QA follow-up) Ensure constraint is created
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit f21ebad7d298f25e44771e5833d1d1d4d6d8f777
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Mon May 13 20:09:05 2019 +0000

    Bug 22899: Add pending_hold method to Koha::Item
    
    To test:
     1 - Enable course reserves
     2 - Create a course
     3 - Add an item to the course
     4 - Attempt to view the course on the OPAC
     5 - Internal Server Error
     6 - Apply patch
     7 - Add an item to the holds queue by placing a hold and  running holds queue builder or:
         INSERT INTO tmp_holdsqueue (itemnumber) VALUES (###);
     8 - View the course page, note item appears 'Pending hold'
     9 - Remove the holdsqueue line
    10 - View the course page, note item appears 'Available'
    11 - prove -v t/db_dependent/Koha/Item.t
    
    Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
    I see Jonathan's comments about small improvements, but will sign off as
    everything works as expected here.
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit af1067f3d466cf3bd32c4747c4a00dd7542c1fe0
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Mon May 13 20:08:06 2019 +0000

    Bug 22899: Database update
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit f45fe692b14f45300456327bc74fd0a0872dff75
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Sat May 4 12:33:34 2019 -0400

    Bug 22849: Do not share data (Mana) without agreement
    
    A couple of things wrong in serials/subscription-add.pl
    
    1.
    447     if ( defined( $query->param('mana_id') ) ) {
    
    It's always defined, you wanted to test with ""
    
    2.
    375     if ( (C4::Context->preference('Mana')) and ( grep { $_ eq "subscription" } split(/,/, C4::Context->preference('AutoShareWithMana'))) ){
    
    Mana == 2 == let me think about it
    => I am not expecting to reach Koha::SharedContent in that case
    
    So we are sharing data whereas the library did not decide yet!
    
    Test plan:
    You need to be familiar you Mana to test this patch.
    
    JD: I did not test this patch
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Items.pm                                        |    2 +-
 C4/XSLT.pm                                         |    4 +-
 Koha.pm                                            |    2 +-
 Koha/Item.pm                                       |   14 +++++++
 Koha/Patron/Modification.pm                        |   14 ++++---
 Koha/Patron/Modifications.pm                       |    6 ++-
 Koha/Schema/Result/Item.pm                         |   19 ++++++++-
 Koha/Schema/Result/TmpHoldsqueue.pm                |   29 ++++++++++++--
 Makefile.PL                                        |    1 +
 about.pl                                           |    5 ++-
 debian/koha-common.docs                            |    1 +
 debian/rules                                       |    2 +-
 installer/data/mysql/kohastructure.sql             |    4 +-
 installer/data/mysql/updatedatabase.pl             |   19 +++++++++
 koha-tmpl/intranet-tmpl/prog/en/modules/about.tt   |   16 +++++---
 .../bootstrap/en/includes/item-status.inc          |    2 +-
 .../bootstrap/en/includes/opac-bottom.inc          |    3 +-
 serials/subscription-add.pl                        |    4 +-
 t/db_dependent/Items.t                             |    4 +-
 t/db_dependent/Koha/Item.t                         |   23 ++++++++++-
 t/db_dependent/Koha/Patron/Modifications.t         |   41 +++++++++++++++++++-
 21 files changed, 183 insertions(+), 32 deletions(-)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list