[koha-commits] main Koha release repository branch 18.11.x updated. v18.11.05-39-g3960731

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.11.x has been updated
       via  396073150e0371471e18ec975a7ba4f2dbe4b3ea (commit)
       via  db1be3d9905ff8c8d2506948ca8c3b6eef7fa609 (commit)
       via  7d96c2b771943824e4ab9c0517ec837c4375f297 (commit)
       via  7c260de1678b88a278b87f1de5c0d764d674c558 (commit)
      from  4c5ae7ffc69443c5f3b956a1dc596743afb6c8d6 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 396073150e0371471e18ec975a7ba4f2dbe4b3ea
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri May 10 11:11:14 2019 -0500

    Bug 22812: Use Koha::Subscription in NewSubscription
    
    Starting to write tests I realize that we are going to add too much
    specific logic which is already handled in Koha::Object->store.
    The easiest and safe way is to use it :)
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit b41f215bfedbae0898a9291d2f14e2a3dd560049)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit db1be3d9905ff8c8d2506948ca8c3b6eef7fa609
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon May 6 13:50:54 2019 -0500

    Bug 22812: Fix GROUP BY in checkrouting
    
    On the way, let fix this error
    DBD::mysql::st execute failed: Mixing of GROUP columns
    (MIN(),MAX(),COUNT(),...) with no GROUP columns is illegal if there is
    no GROUP BY clause [for Statement "SELECT count(routingid) routingids
    FROM subscription LEFT JOIN subscriptionroutinglist
    
    Test plan:
    Create a routing list, search for subscriptions
    In the action list you should see "Edit routing list (1)" or "New
    routing list"
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 256b134a94e83b7072b5891a2d60f0e08e813583)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 7d96c2b771943824e4ab9c0517ec837c4375f297
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon May 6 13:50:26 2019 -0500

    Bug 22812: Add tests for checkrouting
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 0759811ab629e8215ee270b4ec920f71d9bc0d25)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 7c260de1678b88a278b87f1de5c0d764d674c558
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon May 6 13:34:19 2019 -0500

    Bug 22812: Fix new subscription with strict sql modes
    
    With sql_strict_modes turned on, if you try to create a new subscription
    you will get:
    Incorrect integer value: '' for column '$INT_COLUMN' at row 1
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit e8e7ea352ef237555ee4d47c98feb879f3eb9e31)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Serials.pm            |   73 ++++++++++++++++++++++++++++------------------
 t/db_dependent/Serials.t |   17 ++++++++++-
 2 files changed, 61 insertions(+), 29 deletions(-)


hooks/post-receive
-- 
main Koha release repository