[koha-commits] main Koha release repository branch 18.11.x updated. v18.11.05-52-gc276dd6
Git repo owner
gitmaster at git.koha-community.org
Thu May 30 09:40:21 CEST 2019
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 18.11.x has been updated
via c276dd6397211bacdc1881ec853619496b5bc53f (commit)
via 20d62cf1c6d31766a2d21ef0e83785f14934c9dc (commit)
via a2b68c92fec8e48a00aa663866245c67aae48029 (commit)
via b74763da098ffed73228f355316e9e23463c2894 (commit)
via fdaf56ec101f60175986be97db670ea6f68d41a0 (commit)
via 03a09852697f5f53be3551ddd8bdb1dfdb33417b (commit)
via f1eb918616666fe23f9d13aa5c0fea72a6d890d1 (commit)
via e0eea1b15d727085a3a22932d813c9fe3b8f8088 (commit)
via f9820f38a8a96e5529cc476f043b86b9398d0bd7 (commit)
via 8375bdbd53c09de3ebf406662ff6f3a6ba9ce3ee (commit)
via 9b471e00f050108029c51ed4a9821eb64f7f9611 (commit)
via d8e0930549e3578155acd7db533f0a42d605190a (commit)
via 69e27289868cae86446ad77492d4405ee49adaba (commit)
from 396073150e0371471e18ec975a7ba4f2dbe4b3ea (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit c276dd6397211bacdc1881ec853619496b5bc53f
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed May 1 21:05:30 2019 -0400
Bug 22781: Correctly filter the emails
Ho, another bug!
The email was not correctly filtered.
Test plan:
Use the evil string for an email, do a search.
=> Notice that without this patch the results never show up
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 5410186f6829fc4b74a845e8954bd7eea3f19862)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 20d62cf1c6d31766a2d21ef0e83785f14934c9dc
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed May 1 20:54:02 2019 -0400
Bug 22781: Does not double filter address
Ho, a bug!
Some fields in the address where double filtered.
Test plan:
Use the evil strings in the address field and do a search, you will see
double html encoded characters without this patch.
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit ecb12104ffc7284089a1c8134ca8811e99e7419c)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit a2b68c92fec8e48a00aa663866245c67aae48029
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed May 1 20:29:05 2019 -0400
Bug 22781: Test patron's info filtering
The patron's data was not correctly escaped actually.
Test plan:
This is a good value for the whole patchset: <strong>fir's"tname</strong> \123 ❤
use it for a patron's firstname, then do a search
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 35d00030ceb572822979300a5291356a32427a16)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit b74763da098ffed73228f355316e9e23463c2894
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed May 1 20:28:04 2019 -0400
Bug 22781: Escape cardnumber, category's description, library's name and dateexpiry
This will fix the previous failure. Note that other fields like
borrowernumber, Price escaped values, integers, etc. could be escaped
the same way but will be useless (save polar bears).
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 3a3057545c56f4f1a41fcd7643265204844cd2d3)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit fdaf56ec101f60175986be97db670ea6f68d41a0
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed May 1 20:28:55 2019 -0400
Bug 22781: Add tests
Test plan:
Apply only this patch
=> The tests will fail, the library's name is not correctly escaped.
Note:
This applies for the whole patchset, when the tests fail you will need
to remove the patrons added by the tests with the following SQL query:
delete from borrowers where surname like "test_patron_%";
We are expecting END to be called even if something goes wrong, but
DESTROY must be used instead. This will be fixed separately, on its own
bug report.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 6e8ecb8c6c8cf5d5188d2ad138e4fdbd8f395b3e)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 03a09852697f5f53be3551ddd8bdb1dfdb33417b
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Mon Feb 11 14:04:01 2019 +0000
Bug 22225: Correctly use invoiceincgst over listincgst
Mistakenly, we were looking at listincgst in the templates but using
invoiceincgst in the scripts. This patch rectifies that by switching to
use invoiceincgst in the templates too.
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 43047ee734e2b6b650e43710a712390433cbb2bd)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit f1eb918616666fe23f9d13aa5c0fea72a6d890d1
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri May 10 12:27:40 2019 -0500
Bug 22878: Do not pass layout_id on creating a layout
Attempting to create a patron card layout with mysql strict mode on gives the following error:
DBD::mysql::st execute failed: Incorrect integer value: '' for column 'layout_id' at row 1
Test plan:
- Turn on sql_strict_modes
- Create a new patron card
=> Must success with this patch applied
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 8d53fae9494b50c0cf2dcc98b18982b0d8fc416f)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit e0eea1b15d727085a3a22932d813c9fe3b8f8088
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri May 10 12:27:34 2019 -0500
Bug 22878: Add tests
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 9f18afa7b34574cd872c94ee366a8d3e75085413)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit f9820f38a8a96e5529cc476f043b86b9398d0bd7
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date: Mon Apr 29 03:14:35 2019 +0000
Bug 7862: Preventing warns when creating a notice
To reproduce warns:
1) Go to Tools -> Notices & slips
2) Create a new notice of any module
Notice these warns:
Use of uninitialized value $code in regexp compilation at
/home/vagrant/kohaclone/tools/letter.pl line 265.
Use of uninitialized value $code in regexp compilation at
/home/vagrant/kohaclone/tools/letter.pl line 265.
Use of uninitialized value $code in regexp compilation at
/home/vagrant/kohaclone/tools/letter.pl line 265.
CGI::param called in list context from package
CGI::Compile::ROOT::home_vagrant_kohaclone_svc_letters_get line 50, this
can lead to vulnerabilities. See the warning in "Fetching the value or
values of a single named parameter" at /usr/share/perl5/CGI.pm line 436.
CGI::param called in list context from package
CGI::Compile::ROOT::home_vagrant_kohaclone_svc_letters_get line 50, this
can lead to vulnerabilities. See the warning in "Fetching the value or
values of a single named parameter" at /usr/share/perl5/CGI.pm line 436.
3) Create a new notice of the Circulation module
Notice this additional warn:
Use of uninitialized value $code in pattern match (m//) at
/home/vagrant/kohaclone/tools/letter.pl line 258.
To test:
4) Apply patch and refresh page
5) Run steps 1-3 again and confirm no warns show
Sponsored-by: Catalyst IT
Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 700b7dfa09e38c074cebbbb5caac64e031d5c0d5)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 8375bdbd53c09de3ebf406662ff6f3a6ba9ce3ee
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Wed May 15 12:10:15 2019 +0000
Bug 22836: (follow-up) improve test message
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 92ab7f66eb5371596d8c46e56f4fdb503ed5d81c)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 9b471e00f050108029c51ed4a9821eb64f7f9611
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu May 2 21:04:54 2019 -0400
Bug 22836: (follow-up) Bug 22478: (QA follow-up) Make test consistent with variable name
One occurrence was missing.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 7799f4ddd1f1fe111081dc3695c9038fa500e961)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit d8e0930549e3578155acd7db533f0a42d605190a
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu May 2 20:49:45 2019 -0400
Revert "Bug 22478: (QA follow-up) Handle category in opac-shelves like a boolean"
This reverts commit 375dd35d5354d46c4c16f534494b123ce370c3f4.
https://bugs.koha-community.org/show_bug.cgi?id=22836
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 7bed2a3fe61ff605b636e292e73b96947de23b29)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 69e27289868cae86446ad77492d4405ee49adaba
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu May 2 20:49:37 2019 -0400
Revert "Bug 22478: (QA follow-up) Update tests to check for any script tags"
This reverts commit d9b3b90849fd95d296b73b330c4e32ff018c81a5.
https://bugs.koha-community.org/show_bug.cgi?id=22836
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit c265fcc476bc4d4fc74d5a23c0d5ef8ef21650b2)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Creators/Layout.pm | 1 +
acqui/orderreceive.pl | 1 -
.../prog/en/modules/acqui/orderreceive.tt | 4 +-
.../en/modules/members/tables/members_results.tt | 18 +--
opac/opac-shelves.pl | 1 -
svc/letters/get | 4 +-
t/Patroncards_Layout.t | 14 ---
t/db_dependent/Patroncards.t | 34 ++++++
t/db_dependent/selenium/patrons_search.t | 117 ++++++++++++++++++++
t/db_dependent/selenium/regressions.t | 5 +-
tools/letter.pl | 11 +-
virtualshelves/shelves.pl | 1 -
12 files changed, 175 insertions(+), 36 deletions(-)
delete mode 100755 t/Patroncards_Layout.t
create mode 100755 t/db_dependent/Patroncards.t
create mode 100644 t/db_dependent/selenium/patrons_search.t
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list