[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.11-97-ga0066c9

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
       via  a0066c945290124b17f0b44febd3316169ccdf3c (commit)
       via  7d29b1c7a830323f28a2f15a07b95130523ba45e (commit)
       via  51d7f8114b983e4add6f1aba257e381683394ffe (commit)
      from  c7e6cb333db10b81c9083196450db8abfc2d17d7 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit a0066c945290124b17f0b44febd3316169ccdf3c
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Thu Jul 5 12:10:26 2018 +0200

    Bug 21036: Remove odd number of elements warnings from AuthoritiesMarc.pm
    
    Like this one (16.11 line number):
    Odd number of elements in anonymous hash at C4/AuthoritiesMarc.pm line 1070.
    
    We need to add a scalar to some MARC::Field::subfield calls. In list context
    an empty list returned affects the hash built around it.
    
    Test plan:
    Could reproduce this warning easily from OPAC authority search.
    opac-authorities-home.pl calling BuildSummary.
    
    Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 88b37330abaee6372ec999c1a81fd216d66a1379)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit b3af8f93637a7d54dac3426f54057f8034b24eee)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

commit 7d29b1c7a830323f28a2f15a07b95130523ba45e
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Thu Jul 5 09:53:57 2018 +0200

    Bug 21036: Fix warnings from C4/Biblio
    
    Use of uninitialized value $isbn in string ne at /usr/share/koha/prodclone/C4/Biblio.pm line 1794. (16.11 line number)
    Trivial edit.
    
    And these warnings from TransformHtmlToXml (with 16.11 line numbers):
    Use of uninitialized value in substr at /usr/share/koha/prodclone/C4/Biblio.pm line 2527.
    Use of uninitialized value in substr at /usr/share/koha/prodclone/C4/Biblio.pm line 2528.
    substr outside of string at /usr/share/koha/prodclone/C4/Biblio.pm line 2528.
    Indicator in 952 is empty at /usr/share/koha/prodclone/C4/Biblio.pm line 2534.
    
    The last warning is not needed and can be removed.
    Note that the code used the construct @$indicator[$j] for $$indicator[$j].
    The first is an array slice. This worked in list context. But apparently
    the second was meant to be used. And can be rewritten as $indicator->[$j]
    which generally is considered more readable.
    The code around indicator1/2 and ind1/2 is simplified. This change is applied
    twice in the same sub.
    
    Test plan:
    Read the changes.
    Run t/Biblio/TransformHtmlToXml.t
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 295e9b1054386cf188c5fc1eb4fd590e5c451513)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 6413f40738185f5319c66b763cb5bedc6fba8745)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

commit 51d7f8114b983e4add6f1aba257e381683394ffe
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Wed Jul 4 16:49:38 2018 +0200

    Bug 21036: Fix uninitialized value within @itemnumber in string ne
    
    Line from 16.11 log:
    Use of uninitialized value within @itemnumber in string ne at /usr/share/koha/prodclone/reserve/modrequest.pl line 70.
    
    Test plan:
    Read the change. Not 100% identical (numeric zero) but should be enough.
    This line is probably not needed at all.
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 4560d9623663e9fd0b60f9a39ec53082cdd90f24)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit ffae11293afb3f80e434e7c84b75e240f7512350)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/AuthoritiesMarc.pm |   10 +++++-----
 C4/Biblio.pm          |   28 +++++++---------------------
 reserve/modrequest.pl |    2 +-
 3 files changed, 13 insertions(+), 27 deletions(-)


hooks/post-receive
-- 
main Koha release repository