[koha-commits] main Koha release repository branch master updated. v19.05.00-1220-g9b2d782

Tue Nov 5 09:37:28 CET 2019

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  9b2d782813589fe4cd30ce51f8f61428f7e82c3d (commit)
       via  e7b3f8e362b2198233a92710b82a40fb1d534168 (commit)
       via  f981da7494cd094d45a5e21159642dd54f688bdb (commit)
       via  00db9a7624306c3f9282bce1a133b0e45396aeac (commit)
       via  d753993290a867752fcdd439fe65e94691a996fb (commit)
       via  73c0100a3dfb542710fd338b15672cd122f02152 (commit)
       via  39bc68c90b9e6ebdd880c4450b426ba30fe6f893 (commit)
       via  025f9ebe80125fdfacf86f95274b249762384a7f (commit)
       via  f601941b50eae7e1a09829313ed020afbf915c0f (commit)
      from  549a09c52178937af28cc11c5bfa7f00cbced1b5 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 9b2d782813589fe4cd30ce51f8f61428f7e82c3d
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Mon Nov 4 11:52:33 2019 -0300

    Bug 23050: (QA follow-up) Add Koha::Plugins::Tab class

    This minimal class encapsulates the tabs to be passed around to the
    templates, so error checking on missing bits is done in a single place.

    It throws exceptions on errors

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit e7b3f8e362b2198233a92710b82a40fb1d534168
Author: Julian Maurice <julian.maurice at biblibre.com>
Date:   Mon Sep 30 10:10:17 2019 +0200

    Bug 23050: Fix creation of biblio tab's id

    (Too much javascript in my head...)

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit f981da7494cd094d45a5e21159642dd54f688bdb
Author: Julian Maurice <julian.maurice at biblibre.com>
Date:   Mon Jul 15 14:28:47 2019 +0200

    Bug 23050: Fix tab's id to avoid compatibility issues

    MDN says:

      Using characters except ASCII letters, digits, '_', '-' and '.' may
      cause compatibility problems, as they weren't allowed in HTML 4.
      Though this restriction has been lifted in HTML5, an ID should start
      with a letter for compatibility.

    https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/id
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 00db9a7624306c3f9282bce1a133b0e45396aeac
Author: Julian Maurice <julian.maurice at biblibre.com>
Date:   Mon Jul 15 14:10:25 2019 +0200

    Bug 23050: Add missing template filters

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit d753993290a867752fcdd439fe65e94691a996fb
Author: Julian Maurice <julian.maurice at biblibre.com>
Date:   Wed Jun 5 16:26:34 2019 +0200

    Bug 23050: Plugin hook to add tabs in intranet biblio details page

    Test Plan:
    1) Enable plugins
    2) Download and install the latest version of this plugin
    https://git.biblibre.com/biblibre/koha-plugin-intranet-detail-hook
    3) Browse to catalogue/detail.pl for a record
    4) Note you see two new tabs with content

    Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 73c0100a3dfb542710fd338b15672cd122f02152
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Mon Nov 4 20:25:11 2019 +0000

    Bug 23522: (QA follow-up) Typo fix in comment

    Tiny typo fix in a new code comment

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 39bc68c90b9e6ebdd880c4450b426ba30fe6f893
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Thu Aug 29 14:51:16 2019 +0000

    Bug 23522: Show actual price on in baskets

    To test:
     1 - Create a new basket in acq, mark it as 'standing'
     2 - Add an item, leave the RRP and Vendor price as 0
     3 - Receive shipments for the vendor
     4 - Select the title from this basket
     5 - On receipt enter an actual cost
     6 - Finsih receiving
     7 - Go to the basket
     8 - Note the total for the order and the basket are 0, keep this browser tab open
     9 - Open a new browser tab and create a new non standing basket
    10 - Add to basket, again with no RRP or vendor price
    11 - Close the basket, receive the item
    12 - Enter an actual cost on receipt
    13 - Return to view the basket
    14 - Total and order are $0
    15 - Apply patch
    16 - Refresh the basket in both tabs
    17 - You now see the actual price for the orders

    Signed-off-by: Rhonda Kuiper <rkuiper at roundrocktexas.gov>
    Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 025f9ebe80125fdfacf86f95274b249762384a7f
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Mon Nov 4 20:12:58 2019 +0000

    Bug 23523: (QA follow-up) Minor POD corrections

    This just fixes a couple of typos in the POD that predate this patch but
    I noticed whilst QAing this ;)

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit f601941b50eae7e1a09829313ed020afbf915c0f
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Thu Aug 29 18:42:24 2019 +0000

    Bug 23523: unitprice tax column values are not populated if entered upon ordering

    To test:
     1 - Add an item to an acquisitions basket
     2 - Make sure to enter 'Actual cost'
     3 - Check the db:
        SELECT * FROM aqorders WHERE ordernumber={your ordernumber}
     4 - Note that unitprice_tax_included and unitprice_tax_excluded are not populated
     5 - Apply patch
     6 - Edit that order
     7 - Check DB
     8 - Values should be populated
     9 - Place another order, ensude values populated on creation
    10 - QA people: prove -v t/db_dependent/Acquisition/populate_order_with_prices.t

    Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Acquisition.pm                                  |   30 +++++---
 Koha/Plugins/Tab.pm                                |   72 ++++++++++++++++++++
 acqui/basket.pl                                    |    7 +-
 catalogue/detail.pl                                |   25 ++++++-
 .../intranet-tmpl/prog/en/modules/acqui/basket.tt  |    8 +++
 .../prog/en/modules/catalogue/detail.tt            |    9 +++
 t/Koha/Plugins/Tab.t                               |   62 +++++++++++++++++
 .../Acquisition/populate_order_with_prices.t       |   46 +++++++++++--
 t/lib/Koha/Plugin/Test.pm                          |   24 ++++++-
 9 files changed, 263 insertions(+), 20 deletions(-)
 create mode 100644 Koha/Plugins/Tab.pm
 create mode 100644 t/Koha/Plugins/Tab.t

hooks/post-receive
-- 
main Koha release repository