[koha-commits] main Koha release repository branch 18.11.x updated. v18.11.10-43-g17a646c

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.11.x has been updated
       via  17a646c633193d6e0f5f5af7e25b268f991c84d0 (commit)
       via  59cbf5ab537e18c6167348aa52541a97b2c7df9d (commit)
      from  67a1152b3f0354a25156a227918269999ea1d2f8 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 17a646c633193d6e0f5f5af7e25b268f991c84d0
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Thu Sep 26 09:08:40 2019 +0200

    Bug 23679: add Unit Test t/db_dependent/Circulation/transferbook.t
    
    I've choosen to add it to db_dependent because we may add other tests
    to cover transferbook() cases that will change DB
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Bin Wen <bin.wen at inlibro.com>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit d096eeab8a7d23cf460b1ad5f10df746f3d62dda)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
    (cherry picked from commit 19b44c8b44b1c0b92afb3f34b4b6fd41ab1faf5d)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

commit 59cbf5ab537e18c6167348aa52541a97b2c7df9d
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Thu Sep 26 09:09:15 2019 +0200

    Bug 23679: fix software error when trying to transfer an unknown barcode
    
    When trying to transfer an unknown barcode in
    /cgi-bin/koha/circ/branchtransfers.pl you get the error :
    
    Can't call method "itemnumber" on an undefined value at
    /home/koha/src/C4/Circulation.pm line 319.
    
    This comes from C4::Circulation::transferbook which should stop when
    finding unknown barcode.
    
    Test plan :
    1) Go to /cgi-bin/koha/circ/branchtransfers.pl
    2) Enter a barcode not existing in database
    3) Without patch you get a software error, with patch you get a message
       saying 'No Item with barcode'
    4) Enter a barcode existing in database and check transfer is OK
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Bin Wen <bin.wen at inlibro.com>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 3848a3a772e2202ac3339bd241adcef987e48361)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
    (cherry picked from commit 43f15f13123c705bb750af43a74997e581b48719)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Circulation.pm                                   |    1 +
 .../{Koha/Database.t => Circulation/transferbook.t} |   19 +++++++++++++++----
 2 files changed, 16 insertions(+), 4 deletions(-)
 copy t/db_dependent/{Koha/Database.t => Circulation/transferbook.t} (63%)


hooks/post-receive
-- 
main Koha release repository