[koha-commits] main Koha release repository branch master updated. v19.05.00-1335-g000c42c

Thu Nov 21 13:00:20 CET 2019

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  000c42cd60f324a9c1d3fd92900b3be834505327 (commit)
       via  43a72e09989a8a8fd943fa3a87a1488b4078fe4f (commit)
       via  fbd46dd3a7f231479c031808df967a9286a864d0 (commit)
       via  d4589500d197ddb543b63b4c84e87e763d050b40 (commit)
       via  2e310fa7f38426b2a53bcca6e66d2ffae3688d17 (commit)
       via  5cd071d66e2bba70f712b4fa4347648a51e1ed1a (commit)
       via  b9422bef708fb8e57bb7cf482efbddd62860ab61 (commit)
       via  f847cfdd7efa8dcf13985409dcd333a933dbe416 (commit)
       via  e083287048f8672f3a32372b88e13d53fb3a8c97 (commit)
       via  838b8cb2f4bdbaaeba1e6958cbeddc0672b776e8 (commit)
      from  75c2cbed874f32fafe4df31f832e9c3259b5e887 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 000c42cd60f324a9c1d3fd92900b3be834505327
Author: Lisette Scheer <lisetteslatah at gmail.com>
Date:   Wed Nov 13 19:41:20 2019 +0000

    Bug 24034: Capitalization on suggestion edit form: No Status

    When editing a purchase suggestion, the "No status"
    option in the status pulldown is incorrectly capatalized.
    This patch fixes the capitazliation.

    To test:
    1) Create a purchase suggestion in the acquisitions module.
    2) Edit the suggestion. Notice the capitalization in the
       status dropdown is incorrect.
    3) Apply the patch.
    4) Repeat step 2.
    5) Note the capitalization has been fixed.
    6) Sign off.

    Signed-off-by: George Williams <george at nekls.org>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 43a72e09989a8a8fd943fa3a87a1488b4078fe4f
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Mon Nov 18 18:55:39 2019 +0000

    Bug 24058: acquisition table displayed even if no order exist (bib detail)

    This patch corrects the template check for existence of acquisitions
    data on the bibliographic detail page. Now it will correctly hide the
    DataTable when there is no data.

    To test, apply the patch and enable the AcquisitionDetails system
    preference.

     - View the bibliographic detail page for a title which has no
       associated Acquisitions data. Under the "Acquisitions details" tab
       you should see only a message, "There is no order for this biblio."

     - View the detail page for a title which has associated Acquisitions
       data. The "Acquisitions details" tab should show the correct
       information.

    Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit fbd46dd3a7f231479c031808df967a9286a864d0
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Nov 19 11:12:32 2019 +0100

    Bug 23721: Use basketgroup's name to name the CSV export file

    When exporting a basket group, the names of the files are different:
     * pdf => aqbasketgroup.name(.pdf)
     * csv => aqbasketgroup.id(.csv)

    Better to use basketgroup's name for consistency and readability

    Test plan:
    Create a basketgroup and export it in pdf and CSV. The name of the
    generated file must be the basketgroup's name suffixed by the extension.

    Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit d4589500d197ddb543b63b4c84e87e763d050b40
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Tue Nov 19 13:01:56 2019 +0000

    Bug 24065: Fail shib login if multiple users matched

    Ideally you could test against active shib, but is a small code change and
    covered by tests and should be readable

    To test:
    prove -v t/Auth_with_shibboleth.t

    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 2e310fa7f38426b2a53bcca6e66d2ffae3688d17
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Mon Nov 4 12:45:16 2019 +0000

    Bug 23184: Don't select branches for export by default

    This patch changes the include to require passing "selectall=1" to select all items

    This include is only used in this page, so changes should not have side effects
    git grep "branch-selector\.inc"

    This patch also corrects a mismatch in the class names

    To test:
    1 - Browse to Tools->Export data
    2 - Note all branches are selected
    3 - Note this will exclude records wiuthout items if you click 'Export bibiographic records'
    4 - Apply patch
    5 - Visit page again
    6 - Note no branches are selected by default
    7 - Confirm 'Select all/Clear all' still work
    8 - Note record with no items are exported by default now

    Signed-off-by: Myka Kennedy Stephens <mkstephens at lancasterseminary.edu>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 5cd071d66e2bba70f712b4fa4347648a51e1ed1a
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Tue Nov 12 18:29:58 2019 +0000

    Bug 24024: Invert names on halds waiting report

    Signed-off-by: Rhonda Kuiper <rkuiper at roundrocktexas.gov>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit b9422bef708fb8e57bb7cf482efbddd62860ab61
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Nov 11 09:42:42 2019 +0100

    Bug 23964: Clarify and expand tests

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit f847cfdd7efa8dcf13985409dcd333a933dbe416
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed Nov 6 14:59:03 2019 +0000

    Bug 23964: (follow-up) Add comments and improve readability

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit e083287048f8672f3a32372b88e13d53fb3a8c97
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Mon Nov 4 16:06:15 2019 +0000

    Bug 23964: ReservesNeedReturn should only apply to available items

    To test:
     1 - Checkout an item to a patron
     2 - Make sure 'ReservesNeedReturn' is set to 'Automatically'
     3 - Place an item level hold on the checked out item
     4 - Note the hold is marked waiting
     5 - Delete the hold
     6 - Apply patch
     7 - Place a new hold
     8 - Hold is not marked waiting
     9 - Please a hold on a different item
    10 - Note it is marked waiting
    11 - Test when item is damaged and hold not allowed on damaged items
    12 - Test when item is in transit
    13 - Test when item has another hold
    14 - Only in the case where none of the above are true should the hold be marked waiting

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 838b8cb2f4bdbaaeba1e6958cbeddc0672b776e8
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Mon Nov 4 16:06:02 2019 +0000

    Bug 23964: Unit tests

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Auth_with_shibboleth.pm                         |   11 ++-
 C4/Reserves.pm                                     |   20 +++-
 acqui/basketgroup.pl                               |    3 +-
 .../prog/en/includes/branch-selector.inc           |   10 +-
 .../prog/en/includes/waiting_holds.inc             |    2 +-
 .../prog/en/modules/catalogue/detail.tt            |    2 +-
 .../prog/en/modules/suggestion/suggestion.tt       |    2 +-
 t/Auth_with_shibboleth.t                           |   31 ++++++-
 t/db_dependent/Reserves.t                          |   97 +++++++++++++-------
 9 files changed, 127 insertions(+), 51 deletions(-)

hooks/post-receive
-- 
main Koha release repository