[koha-commits] main Koha release repository branch master updated. v19.05.00-1346-g1f3a972

Mon Nov 25 10:07:57 CET 2019

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  1f3a9722e4f8d32c7a839137252fc935ad599f74 (commit)
       via  8606ca9a0e8d476b4674ec0325402c16de8e58da (commit)
       via  7b8780daa14dad446c0c7b0cdf4f01fe90531ed3 (commit)
       via  4c853b0034e20d127a42149dd9d6239867d9df67 (commit)
       via  95d5be238cb69b8f4a38bebc6128b82c23d1c208 (commit)
       via  e9163adf3f7bbd4ca0ae7721b272ab2493e4d5ff (commit)
       via  770f24d4f7da01434fb2318425e4275ec791db8f (commit)
      from  1ca7b6c40cfc78bbeaf0c9d5bebeeb2e3b5ce611 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 1f3a9722e4f8d32c7a839137252fc935ad599f74
Author: Magnus Enger <magnus at libriotech.no>
Date:   Wed Nov 20 15:15:15 2019 +0100

    Bug 24072: Typos in advance_notices.pl causes DUEDGST not to be sent

    There are two typos in advance_notics.pl that cause DUEDGST messages
    not to be sent. See Bugzilla for full details.

    If you think the typo is sufficiently obvious, you can just eyeball the
    patch and sign off, methinks. Otherwise, testing can be done something
    like this:
    - Make sure you have enabled enhanced messaging preferences, and a
      patron with "Email" and "Digests only" set for "Item due" messages
    - Issue an item to this patron, with due date today
    - Run something like this to generate advance notices:
      $ sudo koha-shell -c "perl \
      /home/vagrant/kohaclone/misc/cronjobs/advance_notices.pl -n -c" kohadev
    - See that no notices are shown (-n means messages will go to stdout,
      instead of into the message queue).
    - Apply the patch and run advance_notices.pl again, as before. A DUEDGST
      message should now be displayed.

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 8606ca9a0e8d476b4674ec0325402c16de8e58da
Author: Lari Taskula <lari.taskula at hypernova.fi>
Date:   Fri Oct 25 13:39:12 2019 +0000

    Bug 23901: Fix indentation

    This patch only fixes the indentation of code inside the if-block.

    To test:
    1. Apply patch
    2. Run: git diff -w HEAD~1 and observe no result

    Sponsored-by: Koha-Suomi Oy
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 7b8780daa14dad446c0c7b0cdf4f01fe90531ed3
Author: Lari Taskula <lari.taskula at hypernova.fi>
Date:   Fri Oct 25 13:36:11 2019 +0000

    Bug 23901: Fix sms_input is null in opac-messaging.tt

    When sms messaging is disabled, JavaScript breaks in opac-messaging.tt.
    Bug introduced in Bug 22862.

    To test:
    1. Enable EnhancedMessagingPreferences system preference
    2. Disable sms messaging by unsetting SMSSendDriver system preference
    3. Go to OPAC -> your messaging
    4. Observe JavaScript error "sms_input is null" in your browser console
    5. Apply patch
    6. Refresh page and observe the error is gone

    Sponsored-by: Koha-Suomi Oy
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 4c853b0034e20d127a42149dd9d6239867d9df67
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Nov 20 11:52:04 2019 +0100

    Bug 24013: Fix transferbook if item is checked out

    Wrong conflict resolution, the following
      commit 6eade474ed3a84a5ba372a26ac27bf9fb4bd2299
      Bug 18276: Remove GetBiblioFromItemNumber - Easy ones
    restored a previous change from
      commit 546379cc92b733cb29a0b70247a72c770afdad26
      Bug 17680: C4::Circulation - Remove GetItemIssue, simple calls

    Not that "easy" or "simple"...

    Test plan:
    Run the test before and after this patch.

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 95d5be238cb69b8f4a38bebc6128b82c23d1c208
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Nov 20 11:55:55 2019 +0100

    Bug 24013: Add tests

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit e9163adf3f7bbd4ca0ae7721b272ab2493e4d5ff
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Fri Nov 22 18:41:28 2019 +0000

    Bug 24093: Sorting indicators broken on list contents view

    This patch updates the table markup for the lists contents view so that
    the table sort state is correctly indicated by arrows in the table
    headers. The markup changes allow the standard DataTables CSS to apply
    to this table even though it is not a DataTable.

    To test, apply the patch, go to Lists, and view any list with multiple
    titles attached.

     - The list should be sorted by default according to the list's
       settings, and the arrow in the header row should correctly reflect
       the sorting column and direction.
     - Test re-sorting the table by each of the different sortable columns,
       confirming each time that the sorting arrows are correct.

    Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 770f24d4f7da01434fb2318425e4275ec791db8f
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Thu Nov 21 18:08:48 2019 +0000

    Bug 24084: PlainMARC view broken on OPAC if other $.ajax calls produce errors

    This patch removes the use of jQuery's ajaxSetup() and load() to get the
    "plain" MARC view and replaces it with $.get(). This allows for
    error-handling on this specific AJAX request rather than all on the
    page.

    To test, apply the patch and view a bibliographic record in the OPAC.

     - Click the "MARC view" tab.
     - Click the "view plain" link.
      - The plain-text MARC view should load.
      - Clicking "view labeled" should return you to the original view.

    To test error handling, edit opac-MARCdetail.tt line 185 and add a typo
    to the URL, e.g. "opac-showmark.pl." Repeat the above steps. Clicking
    the "view plain" link should trigger an error message: "Sorry, plain
    view is temporarily unavailable."

    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Circulation.pm                                  |    2 +-
 .../prog/en/modules/virtualshelves/shelves.tt      |   50 ++++++++--------
 .../bootstrap/en/modules/opac-MARCdetail.tt        |   62 +++++++++-----------
 .../bootstrap/en/modules/opac-messaging.tt         |   22 +++----
 misc/cronjobs/advance_notices.pl                   |    4 +-
 t/db_dependent/Circulation/transferbook.t          |   33 ++++++++++-
 6 files changed, 100 insertions(+), 73 deletions(-)

hooks/post-receive
-- 
main Koha release repository