From gitmaster at git.koha-community.org Tue Oct 1 09:08:16 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 01 Oct 2019 07:08:16 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-710-g7e35c3d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 7e35c3d14b63a49ea16d248b2d4260555e8fcb3f (commit) via 47c2e215875127b843c9720976f2c94e1cd66662 (commit) via 62ad053894c57ae990a9724cf58beaa4441448c6 (commit) via d096eeab8a7d23cf460b1ad5f10df746f3d62dda (commit) via 3848a3a772e2202ac3339bd241adcef987e48361 (commit) via 740d0bde7860c1d67f1612d5fd3c4a68d0714ef0 (commit) from ace678ba6f19821bbdaaa9b31c96db2c2ce5e026 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7e35c3d14b63a49ea16d248b2d4260555e8fcb3f Author: Katrin Fischer Date: Mon Sep 30 14:59:20 2019 +0200 Bug 23689: (follow-up) Use Library limitations to match other occurrences Signed-off-by: Martin Renvoize commit 47c2e215875127b843c9720976f2c94e1cd66662 Author: Martin Renvoize Date: Fri Sep 27 14:41:51 2019 +0100 Bug 23689: Fix terminology for branches limitations on authorized values This patch corrects the terminology and also updates the tooltip to use the current bootstrap tooltip library. Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 62ad053894c57ae990a9724cf58beaa4441448c6 Author: Kyle M Hall Date: Fri Sep 27 07:23:28 2019 -0400 Bug 23688: System preference uppercasesurnames broken by typo In the process of moving this feature from memberentry.pl to Patron.pm, the 's' on uppercasesurnames was dropped, breaking the feature. Test Plan: 1) Test uppercasesurnames, note it does not work 2) Apply this patch 3) Test uppercasesurnames, note it works now! Signed-off-by: Kyle Hall Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit d096eeab8a7d23cf460b1ad5f10df746f3d62dda Author: Fridolin Somers Date: Thu Sep 26 09:08:40 2019 +0200 Bug 23679: add Unit Test t/db_dependent/Circulation/transferbook.t I've choosen to add it to db_dependent because we may add other tests to cover transferbook() cases that will change DB Signed-off-by: Owen Leonard Signed-off-by: Bin Wen Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 3848a3a772e2202ac3339bd241adcef987e48361 Author: Fridolin Somers Date: Thu Sep 26 09:09:15 2019 +0200 Bug 23679: fix software error when trying to transfer an unknown barcode When trying to transfer an unknown barcode in /cgi-bin/koha/circ/branchtransfers.pl you get the error : Can't call method "itemnumber" on an undefined value at /home/koha/src/C4/Circulation.pm line 319. This comes from C4::Circulation::transferbook which should stop when finding unknown barcode. Test plan : 1) Go to /cgi-bin/koha/circ/branchtransfers.pl 2) Enter a barcode not existing in database 3) Without patch you get a software error, with patch you get a message saying 'No Item with barcode' 4) Enter a barcode existing in database and check transfer is OK Signed-off-by: Owen Leonard Signed-off-by: Bin Wen Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 740d0bde7860c1d67f1612d5fd3c4a68d0714ef0 Author: Owen Leonard Date: Thu May 2 16:26:55 2019 +0000 Bug 22804: OPAC Overdrive JavaScript contains untranslatable strings This patch moves untranslatable strings out of overdrive.js and into opac-bottom.inc where other strings are defined for use in JavaScript files. To test you must have OverDrive integration set up, including OverDriveCirculation. Test the various Overdrive integration features: - Placing holds - Cancelling holds - Checking out - Checking in These features should work as expected. Signed-off-by: Jesse Maseto Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 1 + Koha/Patron.pm | 2 +- .../prog/en/modules/admin/authorised_values.tt | 17 ++++--- .../bootstrap/en/includes/opac-bottom.inc | 11 ++++- koha-tmpl/opac-tmpl/bootstrap/js/overdrive.js | 47 +++++++++++--------- .../Database.t => Circulation/transferbook.t} | 19 ++++++-- t/db_dependent/Koha/Patrons.t | 6 +-- 7 files changed, 66 insertions(+), 37 deletions(-) copy t/db_dependent/{Koha/Database.t => Circulation/transferbook.t} (63%) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Oct 1 09:37:12 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 01 Oct 2019 07:37:12 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-718-g7a68532 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 7a68532048ac6edf62ccbfa0c1f5181fc682c1c7 (commit) via 7d847c22947887880596968cd845e4f684779a60 (commit) via 474eca3dbcabe40eead066c3221d4984b0b890b4 (commit) via a902efb83b203f2f99938388acd88f3fc059422a (commit) via 7aeec1bfef47ea83ceeb51d552c1f5e537a1b84c (commit) via 1306daa0103a07e6478ec58de34f44045e538dc6 (commit) via 15b5767aaed52364f9c32afb1df2272f00fca75b (commit) via 2cfc7c4c284aa40f62fe7992a9e2eca51d1f95b4 (commit) from 7e35c3d14b63a49ea16d248b2d4260555e8fcb3f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7a68532048ac6edf62ccbfa0c1f5181fc682c1c7 Author: Martin Renvoize Date: Tue Oct 1 08:12:28 2019 +0100 Bug 19618: DBRev 19.06.00.030 Signed-off-by: Martin Renvoize commit 7d847c22947887880596968cd845e4f684779a60 Author: Martin Renvoize Date: Thu Sep 12 16:55:17 2019 +0100 Bug 19618: (QA follow-up) POD Fix Sponsored-by: Southeast Kansas Library - SEKLS Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit 474eca3dbcabe40eead066c3221d4984b0b890b4 Author: Agustin Moyano Date: Thu Sep 5 16:08:14 2019 -0300 Bug 19618: Add tests This patch adds tests for new features To test: 1) prove t/db_dependent/Koha/Club/Enrollment.t 2) prove t/db_dependent/Koha/Club/Hold.t 3) prove t/db_dependent/api/v1/clubs_holds.t 4) Sign off Sponsored-by: Southeast Kansas Library - SEKLS Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit a902efb83b203f2f99938388acd88f3fc059422a Author: Agustin Moyano Date: Tue Sep 10 03:20:38 2019 -0300 Bug 19618: Add api endpoint for club holds This patch adds an endpoint in thi api in /api/v1/clubs/{club_id}/holds whith the verb POST that maps to Koha::REST::V1::Clubs::Holds#add controller. Classes for club_holds and club_holds_to_patron_holds new tables where also added. To test: 1) Reach SUCCESS.3 test point of previous patch with club that has no enrollments 2) Click on "Place Hold" SUCCESS => an alert should appear that you cannot place hold on a club without patrons 3) Reach SUCCESS.3 test point of previous patch with club that has enrollments 4) Click on "Place Hold" SUCCESS => holds priority list should appear with holds for every patron in club 5) Repeat steps 3 and 4. SUCCESS => new holds should appear in different order 6) Sign off Sponsored-by: Southeast Kansas Library - SEKLS Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit 7aeec1bfef47ea83ceeb51d552c1f5e537a1b84c Author: Agustin Moyano Date: Thu Sep 5 14:13:27 2019 -0300 Bug 19618: Add ability to place holds for members of a club in intranet This patch adds the ability to place a hold for each member of a club in random order. To test: 1) apply this patch 2) create 2 clubs, (club names should have some part in common, and some part different for each other) 3) in one of them add at least 6 members 4) enter patron clubs management and click on "Actions" button SUCCESS.1 => club with members has a new action called "search to hold" 5) click on search to hold SUCCESS.2 => in the list of bilios there appears an action called "Place hold for " 6) click on "Place hold for " SUCCESS.3 => a new window appears where you can select pickup location (defaults to club's library, if any), and the list of members. 7) go back to the list of bilios in the catalog and click on "Forget " 8) click on "Holds" action of any biblio SUCCESS.4 => a search box appears with two tabs: Patrons and Clubs 9) click on Clubs tab and search by the common part of clubs names SUCCESS.5 => a list of clubs that matches the search appears. If you click on any of them, the same page as SUCCESS.3 appears. 10) go back to the search box in SUCCESS.4 and search by the different part of the name. SUCCESS.6 => because there is only one club that matches search criteria, the same page as SUCCESS.3 appears; 11) Sign off Sponsored-by: Southeast Kansas Library - SEKLS Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit 1306daa0103a07e6478ec58de34f44045e538dc6 Author: Agustin Moyano Date: Thu Sep 5 14:13:36 2019 -0300 Bug 19618: Add club_holds and club_holds_to_patron_holds tables This patch adds 2 new tables 1. club_holds 2. club_holds_to_patron_holds They are ment to keep info about hold requests made in name of a club To test: 1) apply this patch 2) perl installer/data/mysql/updatedatabase.pl SUCCESS => 2 new tables were created Sponsored-by: Southeast Kansas Library - SEKLS Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit 15b5767aaed52364f9c32afb1df2272f00fca75b Author: Owen Leonard Date: Wed Sep 25 11:58:38 2019 +0000 Bug 23648: The logged in link (class "loggedinusername") needs data-patroncategory This patch adds a "data-categorycode" attribte to the logged in link in the global header of the OPAC. This will allow access to the patron category for use in customization and whatnot. To test, apply the patch and log in to the OPAC. Use the browser's DOM inspector tool to examine the logged-in user's name in the header. It should have a "data-categorycode" attribute with the correct value. Signed-off-by: Christopher Brannon Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 2cfc7c4c284aa40f62fe7992a9e2eca51d1f95b4 Author: Katrin Fischer Date: Sat Aug 10 21:55:52 2019 +0200 Bug 23447: Fix capitalization and other minor edits on patron batch edit template Just some small fixes: - Category => Patron category (more specific for translation) - Attribute => Patron attribute - Opac Note => OPAC note - Add missing colons (:) after some of the labels To test: - Find an existing cardnumber - Go to Tools > Patron batch modification - Use cardnumber in input field and continue - Verify strings show as noted above - Apply patch - Repeat and verify strings have changed, everything still works Signed-off-by: Owen Leonard Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- Koha/Club/Enrollment.pm | 18 ++ Koha/Club/Hold.pm | 142 +++++++++++ .../EnrollmentField.pm => Hold/PatronHold.pm} | 14 +- Koha/{Items.pm => Club/Hold/PatronHolds.pm} | 16 +- Koha/{Items.pm => Club/Holds.pm} | 16 +- Koha/Exceptions/ClubHold.pm | 15 ++ Koha/REST/V1/Clubs/Holds.pm | 209 +++++++++++++++ Koha/Schema/Result/Biblio.pm | 19 +- Koha/Schema/Result/Borrower.pm | 19 +- Koha/Schema/Result/Club.pm | 19 +- .../Result/{ItemsLastBorrower.pm => ClubHold.pm} | 89 ++++--- Koha/Schema/Result/ClubHoldsToPatronHold.pm | 167 ++++++++++++ Koha/Schema/Result/Item.pm | 19 +- Koha/Schema/Result/Reserve.pm | 19 +- api/v1/swagger/definitions/club_hold.json | 21 ++ .../swagger/definitions/club_hold_patron_hold.json | 30 +++ .../definitions/club_hold_patron_holds.json | 6 + api/v1/swagger/definitions/club_holds.json | 6 + api/v1/swagger/parameters.json | 3 + api/v1/swagger/parameters/club.json | 9 + api/v1/swagger/paths.json | 3 + api/v1/swagger/paths/clubs.json | 100 ++++++++ catalogue/search.pl | 8 + installer/data/mysql/kohastructure.sql | 39 +++ installer/data/mysql/updatedatabase.pl | 43 ++++ .../intranet-tmpl/prog/en/includes/clubs-table.inc | 111 ++++++++ .../prog/en/modules/catalogue/results.tt | 37 ++- .../intranet-tmpl/prog/en/modules/clubs/clubs.tt | 95 +------ .../prog/en/modules/members/moremember.tt | 2 +- .../prog/en/modules/reserve/request.tt | 268 ++++++++++++++++++-- .../prog/en/modules/tools/modborrowers.tt | 16 +- .../opac-tmpl/bootstrap/en/includes/masthead.inc | 2 +- reserve/request.pl | 73 +++++- .../Koha/{Tags/Indexes.t => Club/Enrollment.t} | 31 ++- t/db_dependent/Koha/Club/Hold.t | 87 +++++++ t/db_dependent/api/v1/clubs_holds.t | 149 +++++++++++ 37 files changed, 1720 insertions(+), 202 deletions(-) create mode 100644 Koha/Club/Hold.pm copy Koha/Club/{Template/EnrollmentField.pm => Hold/PatronHold.pm} (78%) copy Koha/{Items.pm => Club/Hold/PatronHolds.pm} (78%) copy Koha/{Items.pm => Club/Holds.pm} (82%) create mode 100644 Koha/Exceptions/ClubHold.pm create mode 100644 Koha/REST/V1/Clubs/Holds.pm copy Koha/Schema/Result/{ItemsLastBorrower.pm => ClubHold.pm} (52%) create mode 100644 Koha/Schema/Result/ClubHoldsToPatronHold.pm create mode 100644 api/v1/swagger/definitions/club_hold.json create mode 100644 api/v1/swagger/definitions/club_hold_patron_hold.json create mode 100644 api/v1/swagger/definitions/club_hold_patron_holds.json create mode 100644 api/v1/swagger/definitions/club_holds.json create mode 100644 api/v1/swagger/parameters/club.json create mode 100644 api/v1/swagger/paths/clubs.json create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/clubs-table.inc copy t/db_dependent/Koha/{Tags/Indexes.t => Club/Enrollment.t} (59%) create mode 100644 t/db_dependent/Koha/Club/Hold.t create mode 100644 t/db_dependent/api/v1/clubs_holds.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Oct 1 13:08:24 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 01 Oct 2019 11:08:24 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-719-g2fc7027 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 2fc7027fe4b184ee5652df6534171f67c1374c7e (commit) from 7a68532048ac6edf62ccbfa0c1f5181fc682c1c7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2fc7027fe4b184ee5652df6534171f67c1374c7e Author: Martin Renvoize Date: Tue Oct 1 11:45:13 2019 +0100 Bug 19618: (RM follow-up) Add missing use statements The compile test was failing, this patch corrects for some missing use statements and updates the dbic classes to include the type mappings Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: Koha/Club/Hold/PatronHold.pm | 2 +- Koha/Club/Hold/PatronHolds.pm | 4 +++- Koha/Club/Holds.pm | 4 +++- .../Result/{Borrower.pm => Borrower.pm.orig} | 25 ++++++++++++++++++++ Koha/Schema/Result/ClubHold.pm | 8 +++++-- Koha/Schema/Result/ClubHoldsToPatronHold.pm | 7 +++++- 6 files changed, 44 insertions(+), 6 deletions(-) copy Koha/Schema/Result/{Borrower.pm => Borrower.pm.orig} (97%) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Oct 1 13:14:35 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 01 Oct 2019 11:14:35 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-721-gf2b8444 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via f2b844426782cb08ce8bd9d0b304a358b7548f86 (commit) via 992a68e004772de810eeca0b012e3ab635e08fdf (commit) from 2fc7027fe4b184ee5652df6534171f67c1374c7e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f2b844426782cb08ce8bd9d0b304a358b7548f86 Author: Nick Date: Mon Sep 30 14:12:35 2019 +0000 Bug 7074: (QA follow-up) Deal with multiple fields Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 992a68e004772de810eeca0b012e3ab635e08fdf Author: Katrin Fischer Date: Fri Aug 9 14:42:38 2019 +0000 Bug 7074: Show subtitle, part and number of a record in list of checkins Shows the subtitle, part and number information from the biblio tables as part of the title in the list of checkins (for MARC21: 245$b$n$p). To test: - Apply patch - Catalog a record with 245$a$b$n$p filled out - Check the item out to any patron - Verify that in the list of checkouts the information shows - Check out any other items with different 245 - Verify information is correct - In a new tab, return the items - Verify that in the list of checkins the information now matches the checkouts list Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: circ/returns.pl | 3 +++ koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 3 +++ 2 files changed, 6 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Oct 1 16:05:07 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 01 Oct 2019 14:05:07 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-724-g05b9ea8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 05b9ea8fe5d3bc1d74fb33d18d1b19599d4c4d90 (commit) via deb4c4b765ba32ae0d407bc2ef3ccd35e7f5c567 (commit) via 4c17151d74347da0f2ecfb9de49168162a2a21b6 (commit) from f2b844426782cb08ce8bd9d0b304a358b7548f86 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 05b9ea8fe5d3bc1d74fb33d18d1b19599d4c4d90 Author: Martin Renvoize Date: Tue Oct 1 14:42:19 2019 +0100 Bug 23566: Compiled CSS Signed-off-by: Martin Renvoize commit deb4c4b765ba32ae0d407bc2ef3ccd35e7f5c567 Author: Martin Renvoize Date: Tue Oct 1 14:41:04 2019 +0100 Bug 23566: DBRev 19.06.00.031 Signed-off-by: Martin Renvoize commit 4c17151d74347da0f2ecfb9de49168162a2a21b6 Author: Owen Leonard Date: Wed Sep 25 17:10:46 2019 +0000 Bug 23566: Continue on device - with QR codes This patch adds the option to show a QR code on the OPAC bibliographic detail page. The URL of the page is encoded in the image so that scanning it will take the user to that page on their device. The feature is controlled by a new system preference, OPACDetailQRCode, which is disabled by default. The QR Code is generated by a JavaScript library, "kjua" (https://github.com/lrsjng/kjua), which has been added to the "About" page in the staff client. To test, apply the patch and run the database update. Rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - In the staff client, go to Administration -> System preferences. - Locate the OPACDetailQRCode system preferences under OPAC -> Features. It should be disabled. - Enable the preference and switch to the OPAC. - Locate a title in the catalog and view the detail page. - In the sidebar menu there should be a "Send to device" link. - Clicking the link should display a QR Code. - Scan the code using a QR Code-capable device. - The URL should be correct. - Disable the system preference and confirm that the "Send to device" link no longer appears on the OPAC detail page. Signed-off-by: Christopher Brannon Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/updatedatabase.pl | 11 +++ koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 3 + .../prog/en/modules/admin/preferences/opac.pref | 6 ++ koha-tmpl/opac-tmpl/bootstrap/css/opac.css | 2 +- koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss | 14 +++ .../bootstrap/en/includes/opac-detail-sidebar.inc | 8 ++ .../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 27 ++++++ koha-tmpl/opac-tmpl/bootstrap/images/sprite.png | Bin 2561 -> 8286 bytes koha-tmpl/opac-tmpl/lib/kjua/kjua.js | 18 ++++ koha-tmpl/opac-tmpl/lib/kjua/kjua.min.js | 2 + koha-tmpl/opac-tmpl/lib/kjua/lib/defaults.js | 50 +++++++++++ koha-tmpl/opac-tmpl/lib/kjua/lib/dom.js | 32 +++++++ koha-tmpl/opac-tmpl/lib/kjua/lib/draw.js | 48 +++++++++++ koha-tmpl/opac-tmpl/lib/kjua/lib/draw_mode.js | 47 ++++++++++ koha-tmpl/opac-tmpl/lib/kjua/lib/draw_rounded.js | 91 ++++++++++++++++++++ koha-tmpl/opac-tmpl/lib/kjua/lib/qrcode.js | 42 +++++++++ 18 files changed, 402 insertions(+), 3 deletions(-) create mode 100644 koha-tmpl/opac-tmpl/lib/kjua/kjua.js create mode 100644 koha-tmpl/opac-tmpl/lib/kjua/kjua.min.js create mode 100644 koha-tmpl/opac-tmpl/lib/kjua/lib/defaults.js create mode 100644 koha-tmpl/opac-tmpl/lib/kjua/lib/dom.js create mode 100644 koha-tmpl/opac-tmpl/lib/kjua/lib/draw.js create mode 100644 koha-tmpl/opac-tmpl/lib/kjua/lib/draw_mode.js create mode 100644 koha-tmpl/opac-tmpl/lib/kjua/lib/draw_rounded.js create mode 100644 koha-tmpl/opac-tmpl/lib/kjua/lib/qrcode.js hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Oct 1 16:07:26 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 01 Oct 2019 14:07:26 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-727-g291bb7b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 291bb7bacfdf68e6bc8e99d5c1e258fbcbf2344b (commit) via 2ceeebd5244d8e05342a905e52c43747b1778c68 (commit) via 633800120840384374fef3da091800a6d989e723 (commit) from 05b9ea8fe5d3bc1d74fb33d18d1b19599d4c4d90 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 291bb7bacfdf68e6bc8e99d5c1e258fbcbf2344b Author: Magnus Enger Date: Tue Oct 1 10:54:41 2019 +0200 Bug 22280: Add a unit test This patch adds a unit test to t/db_dependent/Illrequests.t, where a new node without any next_actions or prev_actions is added to the core status graph. Running the tests show a lot of warnings about "no query in themelanguage", but that should not be related to the current bug. Signed-off-by: Martin Renvoize commit 2ceeebd5244d8e05342a905e52c43747b1778c68 Author: Martin Renvoize Date: Mon Sep 23 16:49:35 2019 +0100 Bug 22280: (RM follow-up) Correction to POD Minor correction to mislabled POD section for private method. Signed-off-by: Martin Renvoize commit 633800120840384374fef3da091800a6d989e723 Author: Tomas Cohen Arazi Date: Wed Jul 3 15:34:48 2019 -0300 Bug 22280: Fix typo in _status_graph_union Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Isherwood Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: Koha/Illrequest.pm | 8 ++-- t/db_dependent/Illrequests.t | 102 +++++++++++++++++++++++++++++++++++++++++- 2 files changed, 105 insertions(+), 5 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Oct 1 16:37:17 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 01 Oct 2019 14:37:17 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-728-gf7a5466 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via f7a5466c52c4821394c5c44e0fc4e9603ef0e6f6 (commit) from 291bb7bacfdf68e6bc8e99d5c1e258fbcbf2344b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f7a5466c52c4821394c5c44e0fc4e9603ef0e6f6 Author: Joonas Kylmälä Date: Mon Sep 16 10:26:01 2019 +0000 Bug 13193: Make Memcached usage fork safe When a high enough number of forks try to access for example system preferences with Koha::Cache using memcached as backend the results of different cache requests get mixed up. The problem is fixed by using Cache::Memcached::Fast::Safe that is a fork safe version of Cache::Memcached::Fast. Sponsored-by: The National Library of Finland Signed-off-by: David Cook Works as described, and solves an insidious difficult to debug problem in Koha. Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Installer/PerlDependencies.pm | 7 ++++++- Koha/Cache.pm | 6 +++--- koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 2 +- 3 files changed, 10 insertions(+), 5 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Oct 1 16:41:25 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 01 Oct 2019 14:41:25 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-729-g8dfb0e3 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 8dfb0e3a4e4bc6ee9d1b2e550a835f9bc8e64676 (commit) from f7a5466c52c4821394c5c44e0fc4e9603ef0e6f6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8dfb0e3a4e4bc6ee9d1b2e550a835f9bc8e64676 Author: Martin Renvoize Date: Tue Oct 1 15:18:28 2019 +0100 Bug 19618: (RM follow-up) Remove accidentally committed file Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: Koha/Schema/Result/Borrower.pm.orig | 1620 ----------------------------------- 1 file changed, 1620 deletions(-) delete mode 100644 Koha/Schema/Result/Borrower.pm.orig hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Oct 1 16:57:25 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 01 Oct 2019 14:57:25 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-730-g6c92612 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 6c92612c15b3a62356d09c5719a245e52097afbb (commit) from 8dfb0e3a4e4bc6ee9d1b2e550a835f9bc8e64676 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6c92612c15b3a62356d09c5719a245e52097afbb Author: Martin Renvoize Date: Tue Oct 1 15:33:42 2019 +0100 Bug 13193: (RM revert) Make Memcached usage fork safe This reverts commit f7a5466c52c4821394c5c44e0fc4e9603ef0e6f6. We need the new dependancy packaged first. Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Installer/PerlDependencies.pm | 7 +------ Koha/Cache.pm | 6 +++--- koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 2 +- 3 files changed, 5 insertions(+), 10 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Oct 2 10:25:52 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 02 Oct 2019 08:25:52 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.10-6-g076e4ef Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via 076e4eff0544844582dfbbd98edd4192995d57f4 (commit) via 1ffce2e17ad6c1bef13f81e08dc2487283eb697f (commit) via 4b07f9eac57e4abadf4baca773a09c491b52dd58 (commit) via a5cc18716f26cb0ab277fed36e61b70e551fbabe (commit) via 3fd466b2d513fa219bc02e80a730e5f5ed5337b7 (commit) via a3e2bfe51bee65c1e1a337877f25990deaa475c5 (commit) from 2815387d25496a3683d5d5b01eb1560911e4b0d7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 076e4eff0544844582dfbbd98edd4192995d57f4 Author: Marcel de Rooy Date: Fri Sep 6 09:47:19 2019 +0000 Bug 16111: (QA follow-up) Few additional corrections [1] Refining the regex on the format parameter in opac-search.pl [2] Adding a colon to dc:identifier. The Dublin Core specs gives me this example: Identifier="ISBN:0385424728" [3] Replacing last occurrence of rss2 in the rss template Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize (cherry picked from commit 2bbd811027172af1adb68f9904071951056ecbda) Signed-off-by: Fridolin Somers (cherry picked from commit ad787464c913339dacbda41d4cc1a259ac21e53c) Signed-off-by: Lucas Gass commit 1ffce2e17ad6c1bef13f81e08dc2487283eb697f Author: Marcel de Rooy Date: Fri Sep 6 09:02:38 2019 +0000 Bug 16111: (QA follow-up) Changes related to partial revert When reverting the & change, we need to go back to html filter for query_cgi and limit_cgi. In this patch I only replaced it where it is needed. The template contains more references to SEARCH_RESULT.query_cgi and SEARCH_RESULT.limit_cgi which are useless, since searchResults does not return these hash keys at all. This patch fixes one occurrence where SEARCH_RESULT was copied outside the loop that defines the template variable. Obviously, the code for RSS still needs more attention. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize (cherry picked from commit 062c3f9ab2e25b64dad1d4356a976a1416204c05) Signed-off-by: Fridolin Somers (cherry picked from commit 33c0504bb9437b84f36ede00b762fafebb2c80fc) Signed-off-by: Lucas Gass commit 4b07f9eac57e4abadf4baca773a09c491b52dd58 Author: Liz Rea Date: Mon Aug 19 01:51:04 2019 +0000 Bug 16111: Further fixes to the RSS to make feed work - fixed links per the WC3 spec - fixed a problem in the ATOM link To test: do a search, click the RSS icon - it shows xml in most browsers but wont do RSS type things. Apply this patch, restart the things refresh the page, it should do RSS things (i.e. firefox should render it as a nice looking thing, rather than raw XML.) noting that there are a couple of validation errors still, but they don't seem to be show stopping and moreover I wasn't sure how to fix them: Misplaced Item Self reference doesn't match document location (this is a "for widest compatibility you should fix" kind of thing) Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize (cherry picked from commit fafd719dd34aeb4e96377f4404a53df589138efd) Signed-off-by: Fridolin Somers (cherry picked from commit df9272bbef539b04640439bda6a9c6a8f7bc6b8c) Signed-off-by: Lucas Gass commit a5cc18716f26cb0ab277fed36e61b70e551fbabe Author: Jonathan Druart Date: Mon Aug 19 18:24:56 2019 -0400 Bug 16111: [CHANGED] Replace link href by link in rss part Original patch title: Replace & with & Signed-off-by: Liz Rea EDIT: Reverting the changes to C4/Search and opac-search.pl. This requires a few changes, as supplied in the 5th patch. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize (cherry picked from commit 0e1e5ca31fab861c85c9b6e0d3b788f0208402d4) Signed-off-by: Fridolin Somers (cherry picked from commit 48aaf09849a7d0785b54e10cc84c72b03d288ab0) Signed-off-by: Lucas Gass commit 3fd466b2d513fa219bc02e80a730e5f5ed5337b7 Author: Jonathan Druart Date: Mon Aug 19 16:33:06 2019 -0400 Bug 16111: Adjust some more filters Signed-off-by: Liz Rea Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize (cherry picked from commit 4de5d3dd428a23605e6dc49bfc05bfe780f647dc) Signed-off-by: Fridolin Somers (cherry picked from commit 2a036ec11fcb297068fc7e81073f7acaaf15690e) Signed-off-by: Lucas Gass commit a3e2bfe51bee65c1e1a337877f25990deaa475c5 Author: Jonathan Druart Date: Mon Jun 18 17:31:27 2018 -0300 Bug 16111: Fix content type for RSS feed Test plan: GET http://catalogue/cgi-bin/koha/opac-search.pl?idx=kw&q=perl&count=50&sort_by=acqdate_dsc&format=rss2 => Without this patch it returns content type text/html => With this patch it returns text/xml GET http://catalogue/cgi-bin/koha/opac-search.pl?idx=kw&q=perl&count=50&sort_by=acqdate_dsc&format=rss => Without this patch it does not work => With this patch it returns text/xml Bug 16111: Fix atom support Bug 16111: Remove 'rss2' which should be 'rss' or 'atom' Bug 16111: Replace with Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize (cherry picked from commit b946e996ff208e71bbfd5cfb7714f9a656065093) Signed-off-by: Fridolin Somers (cherry picked from commit 5a30719f84857832fc737c287173cdaec5fb30e9) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: .../bootstrap/en/modules/opac-opensearch.tt | 59 +++++++++++--------- .../opac-tmpl/bootstrap/en/modules/opac-results.tt | 6 +- .../bootstrap/en/modules/opac-search-history.tt | 4 +- opac/opac-search.pl | 7 ++- 4 files changed, 43 insertions(+), 33 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Oct 2 15:11:49 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 02 Oct 2019 13:11:49 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-736-g3227e5a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 3227e5ae443a5aefaeed84554ddd7c4f19f1205a (commit) via ab54b5458d9cfe2db7b5290a301513355c3fdd3b (commit) via 72fcd4c7f2956a374986d5683e52f6bb4c2ff90d (commit) via 8d630cd786e86b0ef023a79d7b6fc84be14bfa60 (commit) via 1b902612af69dadf4c13deb8bc6c59950eb493e3 (commit) via 91947546f7d1baae3e8f5bf297dda3240a968cde (commit) from 6c92612c15b3a62356d09c5719a245e52097afbb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3227e5ae443a5aefaeed84554ddd7c4f19f1205a Author: David Gustafsson Date: Mon Sep 30 15:15:35 2019 +0200 Bug 20589: DBRev 19.06.00.032 Signed-off-by: Nick Clemens Signed-off-by: Alex Arnaud Signed-off-by: Martin Renvoize commit ab54b5458d9cfe2db7b5290a301513355c3fdd3b Author: Nick Date: Tue Oct 1 09:02:20 2019 +0000 Bug 20589: Remove expanded_facet variable and fix tests Thi is a rebase from 14419 to remove an unused variable Also update tests to expect the new expected result Signed-off-by: Nick Clemens Signed-off-by: Alex Arnaud Signed-off-by: Martin Renvoize commit 72fcd4c7f2956a374986d5683e52f6bb4c2ff90d Author: Nick Clemens Date: Fri Aug 23 16:45:05 2019 +0000 Bug 20589: Add option for searching entire record if record stored as array Signed-off-by: Nick Clemens Signed-off-by: Alex Arnaud Signed-off-by: Martin Renvoize commit 8d630cd786e86b0ef023a79d7b6fc84be14bfa60 Author: David Gustafsson Date: Mon Jan 14 15:59:55 2019 +0100 Bug 20589: Exclude boolean fields from search fields Signed-off-by: Nick Clemens Signed-off-by: Alex Arnaud Signed-off-by: Martin Renvoize commit 1b902612af69dadf4c13deb8bc6c59950eb493e3 Author: David Gustafsson Date: Thu Apr 4 15:14:19 2019 +0200 Bug 20589: fix QueryBuilder tests Signed-off-by: Nick Clemens Signed-off-by: Alex Arnaud Signed-off-by: Martin Renvoize commit 91947546f7d1baae3e8f5bf297dda3240a968cde Author: David Gustafsson Date: Fri Apr 13 15:46:55 2018 +0200 Bug 20589: Add field boosting and use query_string fields parameter Generate a list of fields for the query_string query fields parameter, with possible boosts, instead of using "_all"-field. Also add "search" flag in search_marc_to_field table so that certain mappings can be excluded from searches. Add option to include/exclude fields in query_string "fields" parameter depending on searching in OPAC or staff client. Refactor code to remove all other dependencies on "_all"-field. How to test: 1) Reindex authorities and biblios. 2) Search biblios and try to verify that this works as expected. 3) Search authorities and try to verify that this works as expected. 4) Go to "Search engine configuration" 5) Change some "Boost", "Staff client", and "OPAC" settings and save. 6) Verify that those settings where saved accordingly. 7) Click the "Biblios" or "Authorities" tab and change one or more "Searchable" settings 8) Verfiy that those settings where saved accordingly. 9) Try to verify that these settings has taken effect by peforming some biblios and/or authorities searches. Sponsorded-by: Gothenburg Univesity Library Signed-off-by: Nick Clemens Signed-off-by: Alex Arnaud Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- Koha/Schema/Result/SearchField.pm | 20 +- Koha/Schema/Result/SearchMarcToField.pm | 12 +- Koha/SearchEngine/Elasticsearch.pm | 71 ++++-- Koha/SearchEngine/Elasticsearch/QueryBuilder.pm | 243 ++++++++++++++++---- Koha/SearchField.pm | 1 - Koha/SearchFields.pm | 15 -- admin/searchengine/elasticsearch/field_config.yaml | 34 ++- admin/searchengine/elasticsearch/index_config.yaml | 12 +- admin/searchengine/elasticsearch/mappings.pl | 76 ++++-- catalogue/search.pl | 9 +- installer/data/mysql/kohastructure.sql | 3 + installer/data/mysql/updatedatabase.pl | 23 ++ .../admin/searchengine/elasticsearch/mappings.tt | 66 +++++- .../prog/en/modules/catalogue/advsearch.tt | 5 + opac/opac-search.pl | 24 +- .../Koha/SearchEngine/Elasticsearch/QueryBuilder.t | 152 ++++++++---- 17 files changed, 565 insertions(+), 203 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Oct 2 15:16:34 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 02 Oct 2019 13:16:34 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-737-g0bdd859 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 0bdd859e2943e0315a9468c8c7d4b4f6b597ea2a (commit) from 3227e5ae443a5aefaeed84554ddd7c4f19f1205a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0bdd859e2943e0315a9468c8c7d4b4f6b597ea2a Author: Owen Leonard Date: Fri Jul 19 14:06:59 2019 +0000 Bug 23351: Clean up localization template This patch modifies the template used for translation of item type descriptions. It is updated with more consistent Bootstrap grid markup and improved handling of adding and removing rows from the DataTable. To test you should have more than one translation installed. - Apply the patch and go to Administration -> Item types. - Edit an item type. - Click the translate link. - Add a new translation. The table of translations should be updated with your new translation. - Test the "Delete" link corresponding to your new entry. It should work correctly. Signed-off-by: Jesse Maseto Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/admin/localization.tt | 84 ++++++++++++++------ 1 file changed, 61 insertions(+), 23 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Oct 3 11:54:22 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 03 Oct 2019 09:54:22 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-745-g660a5b6 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 660a5b6ebc4eb35bfcca54ef3bde5e00c304c446 (commit) via 0dd2d6883d1e98bed92b25c321110b37da739e88 (commit) via 491a2e858f4c75d6278626862be01f05ef9682cf (commit) via b63b55cda70604041c9f04f5f1e302540bff29eb (commit) via 95a2ffc542c2c93dfbc5c09d7c06186a1f58f458 (commit) via 18f9ed465dc990252a0462f86010b874fdde5d77 (commit) via c66cebf744778dbfc15597079549c161a7836d63 (commit) via c855b1ca287758b535fe5ba885949accac4e474a (commit) from 0bdd859e2943e0315a9468c8c7d4b4f6b597ea2a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 660a5b6ebc4eb35bfcca54ef3bde5e00c304c446 Author: Katrin Fischer Date: Wed Oct 2 07:41:45 2019 +0000 Bug 23713: (follow-up) Add missing semicolon Adds a missing semicolon to one of the lines with translated messages. Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 0dd2d6883d1e98bed92b25c321110b37da739e88 Author: Owen Leonard Date: Tue Oct 1 15:55:19 2019 +0000 Bug 23713: Subscription add form broken for translations This patch makes a change to the subscription entry template as a workaround to a translation bug which is causing JavaScript errors when using translated templates. To test, apply the patch and update and install the de-DE template: > cd misc/translator > perl translate update de-DE > perl translate install de-DE - Go to Administration -> System preferences and enable the "Deutsch (de-DE)" language under I18N/L10N preferences -> language. - Switch to the "Deutsch" translation. - Go to Zeitschriften (Serials) -> Neues Abonnement (New subscription) and open the browser console. There should be no errors. - Links which trigger JavaScript events should work correctly: "Lieferant suchen," "Nach Datensatz suchen," etc. Reported-by: Katrin Fischer Thanks-to: Michael Hoffert and Alexander Arlt from koha-de for reporting it initially and figuring out the root of the issue Signed-off-by: Julian Maurice Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 491a2e858f4c75d6278626862be01f05ef9682cf Author: Kyle M Hall Date: Wed Oct 2 14:58:55 2019 -0400 Bug 23722: Document allow_empty_passwords in the example SIP config file The example SIP config file in Koha is kind of a kitchen sink document where all available SIP2 options should be demonstrated. The allow_empty_passwords flag should be included in it. Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit b63b55cda70604041c9f04f5f1e302540bff29eb Author: Nick Date: Mon Sep 30 13:37:19 2019 +0000 Bug 21985: Fix further occurences Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 95a2ffc542c2c93dfbc5c09d7c06186a1f58f458 Author: Jonathan Druart Date: Thu Mar 14 19:19:45 2019 -0300 Bug 21985: Trying to fix the next failure Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 18f9ed465dc990252a0462f86010b874fdde5d77 Author: Jonathan Druart Date: Sun Dec 16 12:28:48 2018 -0300 Bug 21985: Fix Circulation tests when ES it set, by using build_sample_item We should use build_sample item (from bug 21971) to create items, otherwise we may not have a valid biblioitem and/or MARC record. Test plan: Set SearchEngine to ES prove that the tests in Circulation.t now pass Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit c66cebf744778dbfc15597079549c161a7836d63 Author: Christophe Croullebois Date: Thu Aug 29 15:23:01 2019 +0200 Bug 23252: Adds noEnterSubmit class in ajax context In cataloging.js $(document).ready adds noEnterSubmit class. This does not work in ajax context, it works with $(document).ajaxSuccess. Test plan : 1) 1.1) Verify you have an item subfield linked to items.itemnotes, ie 952$z 1.2) Verify 952$z exists in ACQ framework 2) 2.1) Verify system preference "AcqCreateItem" is on "placing an order" 2.2) Go to an acquisition basket 2.3) Click "Add to basket" and "From a new (empty) record" 2.4) Go to "Item" block 2.5) Verify that $z has "noEnterSubmit" class 2.6) Verify that typing enter in $z does not submit the form 3) 3.1) Change system preference "AcqCreateItem" to "receiving an order" 3.2) Go to "Receive shipment" 3.3) Receive an order 3.4) Go to "Item" block 3.5) Verify that $z has "noEnterSubmit" class 3.6) Verify that typing enter in $z does not submit the form Signed-off-by: Kyle M Hall Signed-off-by: Bouzid Fergani Signed-off-by: Martin Renvoize commit c855b1ca287758b535fe5ba885949accac4e474a Author: Fridolin Somers Date: Tue Jul 2 15:57:09 2019 +0200 Bug 23252: Add missing input_marceditor class in item editor In serials receive and acquisition order creation from iso2709, the item edition form shows inputs that are missing "input_marceditor" class. They are also missing tabindex and id. The side effect is that those inputs dont get the "noEnterSubmit" class so form is posted if a barcode scanner is used or if enter is used on keyboard. Test plan : 1) 1.1) Verify you have an item subfield linked to items.itemnotes, ie 952$z 1.2) Verify system preference "AcqCreateItem" is on "placing an order" 2) 2.2) Go to cataloguing module and edit an item 2.3) Verify that $z has an id, tabindex and "input_marceditor" class. 2.4) Verify that typing enter in $z does not submit the form 3) 3.1) Go to a serial with items creation, click on receive 3.2) Change status to "Arrived" 3.3) Verify that $z has an id, tabindex and "input_marceditor" class. 3.4) Verify that typing enter in $z does not submit the form 4) 4.1) Go to an acquisition basket 4.2) Click "Add to basket" and "From a staged file" 4.3) Click "Add orders" on a staged file 4.4) Go in tab "Item information" 4.5) Verify that $z has an id, tabindex and "input_marceditor" class. Signed-off-by: Kyle M Hall Signed-off-by: Bouzid Fergani Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Items.pm | 2 +- etc/SIPconfig.xml | 1 + .../prog/en/modules/serials/subscription-add.tt | 8 +- koha-tmpl/intranet-tmpl/prog/js/cataloging.js | 3 + t/db_dependent/Circulation.t | 349 ++++++-------------- t/lib/TestBuilder.pm | 1 + 6 files changed, 118 insertions(+), 246 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Oct 3 12:24:39 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 03 Oct 2019 10:24:39 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-755-g214220e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 214220ed09d26349ab84ecccb29533b2e62ca668 (commit) via e2ec92a9e6cfe178834d7080cb896f7c179ee13e (commit) via f96bf638ea0c40dbca8b1801b578b5f3740a6424 (commit) via 3ddfee352735d94f4939a53de6414e2282253d9f (commit) via 5236e897aadc314d7110b0290e96541f83997b46 (commit) via fed5158d66abafbe482a3625fa010c160c82a529 (commit) via ec5a5d6e72e4dfbc0a439cbaa9ee1b990c258361 (commit) via da46b4d93345adc55d701a1d64a91bea979e7b0f (commit) via 059cc81891082910f14cf9586288a8d302de5f7f (commit) via dca51f46aa127fcce439561656da5606dc72e4f8 (commit) from 660a5b6ebc4eb35bfcca54ef3bde5e00c304c446 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 214220ed09d26349ab84ecccb29533b2e62ca668 Author: Lucas Gass Date: Wed Oct 2 14:05:25 2019 +0000 Bug 23711: Fix bad path Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit e2ec92a9e6cfe178834d7080cb896f7c179ee13e Author: Lucas Gass Date: Mon Sep 30 23:23:31 2019 +0000 Bug 23711: Change icons and remove unused SVG Signed-off-by: Fridolin Somers Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit f96bf638ea0c40dbca8b1801b578b5f3740a6424 Author: Lucas Gass Date: Mon Sep 30 20:39:54 2019 +0000 Bug 23711: Icons on staff main page should be font icons Signed-off-by: Fridolin Somers Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 3ddfee352735d94f4939a53de6414e2282253d9f Author: Owen Leonard Date: Fri Sep 6 15:37:43 2019 +0000 Bug 23543: Adding Withdrawn to the Item Search This patch adds "Withdrawn" status to the item search form and item search results. To test you should have one or more items in your catalog which have a 'Withdrawn' status. Perform an item search and limit to a widthdrawn status. Verify that the search returns the correct results and that the withdrawn column in search results shows the correct information. Test the "Export results to CSV" button. The resulting file should contain the correct data, including withdrawn status. Signed-off-by: Joe Sikowitz Signed-off-by: David Roberts Signed-off-by: Katrin Fischer Signed-off-by: Kelly McElligott Signed-off-by: Martin Renvoize commit 5236e897aadc314d7110b0290e96541f83997b46 Author: Martin Renvoize Date: Thu Oct 3 10:51:53 2019 +0100 Bug 18084: Compiled CSS Signed-off-by: Martin Renvoize commit fed5158d66abafbe482a3625fa010c160c82a529 Author: Owen Leonard Date: Tue Jun 11 18:29:32 2019 +0000 Bug 18084: Language selector hidden in user menu on mobile interfaces This patch updates templates and CSS so that the language-selection menu in the header will not be hidden if the browser width is too narrow. This patch also makes some more general improvements to the responsive adaptability of the header elements. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Test the changes by viewing pages in the OPAC and adjusting your browser width, paying attention to how elements in the top menu adapt to different sizes. Test under varying conditions: - Logged in/not loggeed user - Search history enabled and disabled - OpacLangSelectorMode showing menu in header or not - opacuserlogin enabled or disabled Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit ec5a5d6e72e4dfbc0a439cbaa9ee1b990c258361 Author: Martin Renvoize Date: Thu Oct 3 10:49:31 2019 +0100 Bug 23686: DBRev 19.06.00.032 Signed-off-by: Martin Renvoize commit da46b4d93345adc55d701a1d64a91bea979e7b0f Author: Katrin Fischer Date: Wed Oct 2 13:51:26 2019 +0000 Bug 23686: (QA follow-up) Fix updatedatabase and make descriptions consistent Signed-off-by: Martin Renvoize commit 059cc81891082910f14cf9586288a8d302de5f7f Author: Nicolas Legrand Date: Fri Sep 27 10:14:35 2019 +0200 Bug 23686: Check onsite checkout when the last checkout was an onsite one Prevent from checking again and again the onsite checkout box when doing onsite checkouts in batches. If preceding checkout was an onsite one, the box will be checked. Test plan: 1. enable OnSiteCheckouts 2. make your circulation rules able to checkout onsite 3. onsite checkout a document 4. you should return to the checkout page, the box isn't checked 5. apply patch 6. updatedatabase.pl 7. redo steps 3, it should again print a checkout page with an unchecked onsite checkout box 8. enable OnSiteCheckoutAutoCheck system preference 9. redo step 3 10. when returning to the checkout page, the onsite checkout box should be already checked Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize commit dca51f46aa127fcce439561656da5606dc72e4f8 Author: Owen Leonard Date: Fri Sep 13 18:10:25 2019 +0000 Bug 23612: If no columns in a table can be toggled, don't show columns button This patch makes a change to the JavaScript setup for DataTables button controls so that if there are no toggle-able buttons (or there is no columns configuration at all) the column selection menu button will not appear. To test, apply the patch and go to Administration -> Columns settings. - In the Administration section, find the section for the "libraries" table. - In the "Cannot be toggled" column, check all the checkboxes. - Save. - Go to Administration -> Libraries. - At the top of the table there should be no "Columns" button, only "Clear filter" and "Export" buttons. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- catalogue/itemsearch.pl | 20 +++- circ/circulation.pl | 5 +- installer/data/mysql/sysprefs.sql | 1 + installer/data/mysql/updatedatabase.pl | 11 ++ koha-tmpl/intranet-tmpl/prog/css/mainpage.css | 45 ++------ .../en/includes/catalogue/itemsearch_item.csv.inc | 2 +- .../en/includes/catalogue/itemsearch_item.json.inc | 1 + .../prog/en/includes/columns_settings.inc | 31 +++--- .../includes/csv_headers/catalogue/itemsearch.tt | 2 +- .../en/modules/admin/preferences/circulation.pref | 6 ++ .../prog/en/modules/catalogue/itemsearch.tt | 11 ++ .../prog/en/modules/circ/circulation.tt | 4 + .../intranet-tmpl/prog/en/modules/intranet-main.tt | 28 ++--- koha-tmpl/intranet-tmpl/prog/img/koha-egg.svg | 1 + .../prog/img/staff-home-icons-sprite.png | Bin 10479 -> 0 bytes koha-tmpl/opac-tmpl/bootstrap/css/opac.css | 2 +- .../opac-tmpl/bootstrap/css/src/_responsive.scss | 54 +++------- koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss | 111 ++++++++++++++++++-- .../bootstrap/en/includes/masthead-langmenu.inc | 58 +++++----- .../opac-tmpl/bootstrap/en/includes/masthead.inc | 82 ++++++++++----- koha-tmpl/opac-tmpl/bootstrap/js/script.js | 19 ++-- .../staff-home-icons-sprite.svg | 1 - 23 files changed, 307 insertions(+), 190 deletions(-) create mode 100644 koha-tmpl/intranet-tmpl/prog/img/koha-egg.svg delete mode 100644 koha-tmpl/intranet-tmpl/prog/img/staff-home-icons-sprite.png delete mode 100644 misc/interface_customization/staff-home-icons-sprite.svg hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Oct 3 15:39:47 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 03 Oct 2019 13:39:47 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-756-g3de3269 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 3de3269d9253395ad1e4c47c515605a78a157943 (commit) from 214220ed09d26349ab84ecccb29533b2e62ca668 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3de3269d9253395ad1e4c47c515605a78a157943 Author: Martin Renvoize Date: Thu Oct 3 14:02:27 2019 +0100 Bug 20589: (RM follow-up) Fix Koha::SearchField.t This patch removes the unit test for the weighted_fields method which this bug removed. Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: t/db_dependent/Koha/SearchField.t | 66 +------------------------------------ 1 file changed, 1 insertion(+), 65 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Oct 3 17:22:28 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 03 Oct 2019 15:22:28 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-757-g1175b9f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 1175b9fb8703376d051267446dc9c585442c2201 (commit) from 3de3269d9253395ad1e4c47c515605a78a157943 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1175b9fb8703376d051267446dc9c585442c2201 Author: Nick Date: Thu Oct 3 14:42:25 2019 +0000 Bug 20589: (follow-up) Fix tests Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: Koha/SearchEngine/Elasticsearch.pm | 1 - t/Koha/SearchEngine/Elasticsearch.t | 22 +++++++++++++++++++--- 2 files changed, 19 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Oct 7 12:26:10 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 07 Oct 2019 10:26:10 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-758-g43519c0 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 43519c0525a07b8f784fd9166eb0db3430e29042 (commit) from 1175b9fb8703376d051267446dc9c585442c2201 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 43519c0525a07b8f784fd9166eb0db3430e29042 Author: Martin Renvoize Date: Fri Oct 4 13:19:18 2019 +0100 Bug 23612: (RM follow-up) Fix failing tests Trailing comma's were causing hidden javascript errors during selenium tests. Error was identified by adding a $s->capture($driver) line to the relevant selenium test and using the following JS snippet to dump errors to the screen. (function () { var ul = null; function createErrorList() { ul = document.createElement('ul'); ul.setAttribute('id', 'js_error_list'); //ul.style.display = 'none'; document.body.appendChild(ul); } window.onerror = function(msg){ if (ul === null) createErrorList(); var li = document.createElement("li"); li.appendChild(document.createTextNode(msg)); ul.appendChild(li); }; })(); Which clearly showed the following error. ReferenceError: KohaTable is not defined Removing the trailing comma's introduced in this bug resolved the issue. Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Oct 7 13:35:19 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 07 Oct 2019 11:35:19 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-759-g5c76ad7 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 5c76ad78a3d5c9d485a7884deb2fe39834fb880c (commit) from 43519c0525a07b8f784fd9166eb0db3430e29042 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5c76ad78a3d5c9d485a7884deb2fe39834fb880c Author: Martin Renvoize Date: Mon Oct 7 12:08:36 2019 +0100 Bug 18084: (RM follow-up) Fix authentication tests A change to the way we hide/expose the user menu in the opac resulted in the authentication selenium tests failing. This was due to the logout button being identified as hidden under the new code and as such the logout action not being triggered correctly between each login test. The was was simply to add an additonal 'click' event called on the menu button to put the logout link into the visible viewport. Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: t/db_dependent/selenium/authentication.t | 4 ++++ 1 file changed, 4 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Oct 7 14:22:33 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 07 Oct 2019 12:22:33 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-774-g6a17bf7 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 6a17bf77853a433c71938a1344486932c30d899a (commit) via a3ec118dd9b8b6ff34ab721e81198dafb92c703e (commit) via 5a92300abf50fc3b82bd82f746e2c48a569a0b3d (commit) via 3567f21ebb2aff72327b4c000df187dbb96275d3 (commit) via 7a80c94d96d5d0717d9a73a4d73fd1b7256bb181 (commit) via 12d33316918d6e333c670d0cc4a218bda2c964c6 (commit) via a9d5147dfd26539dc13989d82faa54032ba26600 (commit) via b5f1297aa93c00b8d2b190a0a71fb5b41343af81 (commit) via 541b1fca0b5816dfb16104674e3a15bd75af371e (commit) via 92b57309ba82c4213e4023e22bc73cebbffcad13 (commit) via 9249a1751a505c4e1c384e66d11bb370a664985d (commit) via 2f54850591f589b6a5750f3cff5df846d3e52ee1 (commit) via e909494ac90b2c473815795e9256ecd2f967b223 (commit) via 43d999cc7c7edc54e3df7482b3ab3607755e4b6d (commit) via a4bee10d0b73e12721e65908283a37a675bb44c4 (commit) from 5c76ad78a3d5c9d485a7884deb2fe39834fb880c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6a17bf77853a433c71938a1344486932c30d899a Author: Nick Date: Thu Oct 3 13:21:35 2019 +0000 Bug 23730: Fix export of reports To test: 1 - Run a saved report 2 - Attempt to export results 3 - It fails 4 - Apply patch 5 - It succeeds Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit a3ec118dd9b8b6ff34ab721e81198dafb92c703e Author: Agustin Moyano Date: Thu Oct 3 14:14:47 2019 -0300 Bug 23710: (follow-up) Add tests for new features in Koha::REST::V!::Holds::add and return error when hold date in future is not allowed and it is passed as parameter Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit 5a92300abf50fc3b82bd82f746e2c48a569a0b3d Author: Agustin Moyano Date: Wed Oct 2 11:26:57 2019 -0300 Bug 23710: (follow-up) Human readable error messages in request.tt, check AllowHoldPolicyOverride and AllowHoldDateInFuture in Koha::REST::V1::Holds.pm Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit 3567f21ebb2aff72327b4c000df187dbb96275d3 Author: Agustin Moyano Date: Tue Oct 1 15:26:55 2019 -0300 Bug 23710: Use API to place holds for patrons This patch effectively uses API to place holds for patrons. It adds a listener on submit event of the form in javascript, where it calls holds API. To test: 1. Place a hold on any biblio for a patron SUCCESS => hold is placed or rejected, but no blank page with JSON error is shown. 2. Place a multi hold for any patron SUCCESS => holds are placed or rejected, but no blank page with JSON error is shown. 3. Sign off Signed-off-by: Lisette Scheer Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit 7a80c94d96d5d0717d9a73a4d73fd1b7256bb181 Author: Nicolas Legrand Date: Mon Sep 23 18:55:56 2019 +0200 Bug 23671: Elasticsearch shouldn't throw exception on an uppercase subfield identifier Prevent Elasticsearch from throwing an exception when the mappings include uppercase subfield identifier. Though forbidden in MARC21, It doesn't seem to be the case for Unimarc or ISO 2709 as a whole. It is also possible to define such a subfield identifier in the Koha MARC Framework and in the Elasticsearch mappings. Test plan: 1. add a 995Z subfield identifier in Elasticsearch mappings (Administration -> Search engine configuration) 2. run $KOHA_PATH/misc/search_tools/rebuild_elasticsearch.pl -v -d -b 3. see it throw: “Invalid MARC field expression: 995Z” 4. apply patch 5. rerun $KOHA_PATH/misc/search_tools/rebuild_elasticsearch.pl -v -d -b 6. sababa Signed-off-by: Séverine QUEUNE Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 12d33316918d6e333c670d0cc4a218bda2c964c6 Author: Nicolas Legrand Date: Mon Sep 23 18:27:32 2019 +0200 Bug 23670: Load Koha::Exceptions::ElasticSearch module in Koha::SearchEngine::Elasticsearch Prevent Koha::SearchEngine::Elasticsearch from dying when trying to run Koha::Exceptions::Elasticsearch::MARCFieldExprParseError->throw() Plan test: 1. Go to Administration -> Searchengine configuration, and add a mapping for 995Z, whatever the search field (I did it with local-classification), save 2. run $KOHA_PATH/misc/search_tools/rebuild_elasticsearch.pl -v -d -b 3. see it die asking for Koha::Exceptions::Elasticsearch 4. apply patch 5. rerun $KOHA_PATH/misc/search_tools/rebuild_elasticsearch.pl -v -d -b 6. see it throw: Invalid MARC field expression: 995Z Signed-off-by: Séverine QUEUNE Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit a9d5147dfd26539dc13989d82faa54032ba26600 Author: Martin Renvoize Date: Mon Oct 7 12:45:23 2019 +0100 Bug 23007: DBRev 19.06.00.034 Signed-off-by: Martin Renvoize commit b5f1297aa93c00b8d2b190a0a71fb5b41343af81 Author: Nick Clemens Date: Wed Jun 12 19:54:42 2019 +0000 Bug 23007: Retain focus on 'barcode' input if transfers don't block circ To test: 1 - Apply patches 2 - Update database 3 - Confirm TransfersBlockCirc defaults to 'Block' 4 - Check in an item that needs transfer 5 - Confirm you must deal with the modal to proceed 6 - Repeat checking to get 'wrong-transfer-modal' 7 - Confirm you must deal with it to proceed 8 - Switch the pref to 'Don't block' 9 - Find a new item or cancel/fulfill the preceeding transfer 10 - Check in the item to generate transfer 11 - Note focus remains on the barcode field and you can continue scanning (or typing if you don't have a scanner) 12 - Note typing and pressing enter continues without requiring you to deal with modal 13 - Repeat for wrong transfer modal 14 - Verify hold and other modals still block continuing circulation Signed-off-by: Maryse Simard Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 541b1fca0b5816dfb16104674e3a15bd75af371e Author: Nick Clemens Date: Thu Jun 27 10:54:26 2019 +0000 Bug 23007: Add TransfersBlockCirc system preference Signed-off-by: Maryse Simard Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 92b57309ba82c4213e4023e22bc73cebbffcad13 Author: Martin Renvoize Date: Mon Oct 7 12:25:24 2019 +0100 Bug 23039: Compiled CSS Signed-off-by: Martin Renvoize commit 9249a1751a505c4e1c384e66d11bb370a664985d Author: Nick Clemens Date: Fri Aug 30 19:56:28 2019 +0000 Bug 23039: Don't hide the checkin dialogs Signed-off-by: Nick Clemens Signed-off-by: Bouzid Fergani Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit 2f54850591f589b6a5750f3cff5df846d3e52ee1 Author: Owen Leonard Date: Tue Jul 30 15:16:26 2019 +0000 Bug 23039: Hold found modal on checkin screen ( circulation.pl ) obscures Check in message info This patch modifies the checkin process so that any errors or messages related to the current checkin are displayed in any hold/transit modal which is displayed. This prevents any information from being hidden by the modal. This patch also adds an "information" button to the checkout form which the user can click to redisplay the last modal which was dismissed (unless confirming the modal reloads the page). To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Test the checkin process with various types of items: - Item not checked out - Item not checked out, on hold - Item not checked out, needs to be transferred - Item is marked lost, needs to be transferred - Item checked out, patron has waiting holds (with WaitingNotifyAtCheckin enabled) - Item checked out, patron has outstanding fines (with FineNotifyAtCheckin enabled) - Test that the modal redisplay button works in cases where the modal is dismissed without triggering a page reload: - Hold confirmation -> Ignore - Transfer confirmation -> OK Signed-off-by: Nick Clemens Signed-off-by: Bouzid Fergani Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit e909494ac90b2c473815795e9256ecd2f967b223 Author: Dobrica Pavlinusic Date: Wed Oct 2 11:32:17 2019 +0200 Bug 23589: Discharge notice does not show non-latin characters It seems that discarge notices never got support for truetype fonts, so notices are missing non-latin characters. Signed-off-by: Theodoros Theodoropoulos Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 43d999cc7c7edc54e3df7482b3ab3607755e4b6d Author: Dobrica Pavlinusic Date: Thu Oct 3 09:34:17 2019 +0200 Bug 23723: using exit inside eval to stop sending output to browser doesn't work under plack When fixing Bug 23589 Theodoros Theodoropoulos noticed that we are sending headers and html after pdf output to browser. Using exit inside eval block doesn't stop plack from generating headers and html page after exit since CGI::Compile will catch exit but doesn't stop emiting output. Example is: eval { warn "in eval"; exit; }; warn "after eval"; Under CGI, this would print just "in eval", but under plack we get both lines and thus generate additional header and html after we already sent pdf data. Signed-off-by: Theodoros Theodoropoulos Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit a4bee10d0b73e12721e65908283a37a675bb44c4 Author: Björn Nylén Date: Fri Sep 14 08:19:46 2018 +0200 Bug 21343: Respect patron language preference in automtic renewals To test: 1) Set up different automatic renewal notices for Default and one other language 2) Make sure you have checkouts due for auto-renewal to patrons with non-Default language pref 3) Run automatic_renewals.pl . All patrons will get the default-language notice 4) Apply patch. 5) Repeat 2) 6) Run automatic_renewals.pl . Patrons will receive notices according to their language preference. Sponsored-by: Lund University Library Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- Koha/Patron/Discharge.pm | 20 +- Koha/REST/V1/Holds.pm | 14 +- Koha/SearchEngine/Elasticsearch.pm | 3 +- installer/data/mysql/sysprefs.sql | 1 + installer/data/mysql/updatedatabase.pl | 10 + .../intranet-tmpl/prog/css/src/staff-global.scss | 32 ++ koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 2 +- .../en/modules/admin/preferences/circulation.pref | 6 + .../intranet-tmpl/prog/en/modules/circ/returns.tt | 498 ++++++++++---------- .../prog/en/modules/reserve/request.tt | 93 +++- members/discharge.pl | 4 +- misc/cronjobs/automatic_renewals.pl | 1 + opac/opac-discharge.pl | 4 +- reports/guided_reports.pl | 2 +- t/db_dependent/api/v1/holds.t | 66 ++- 16 files changed, 489 insertions(+), 269 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Oct 7 15:31:52 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 07 Oct 2019 13:31:52 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-775-g8b97be3 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 8b97be3671732c68bc5d3b720f1b4e48dd73377d (commit) from 6a17bf77853a433c71938a1344486932c30d899a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8b97be3671732c68bc5d3b720f1b4e48dd73377d Author: Martin Renvoize Date: Mon Oct 7 14:05:17 2019 +0100 Bug 23039: (RM follow-up) Fix basic_workflow test This bug altered the markup of the returns page subtly, introducing a new div level and as such changing the required xpath expression for the checkin submission button in the basic_workflow tests. Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: t/db_dependent/selenium/basic_workflow.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Oct 7 15:33:08 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 07 Oct 2019 13:33:08 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-793-g22aaf8f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 22aaf8f1f9ade2a37a14ef409388b012224041da (commit) via 47e48f3ade4eba7fc12cf39c865b366e092a73f2 (commit) via 4ecc88b25969d3bb663b55de9ba377b9170f9992 (commit) via ef897b41f5b7e5f7f9427d8e55390988bf91d6cd (commit) via 3c0cdedfb00528e64dc35c98523258d641e312e4 (commit) via 2cb34d25cc99ab8ec62e561cf6f1658d09f15efd (commit) via d8d17dfaa38909e9882732a61b34de29e6e7c722 (commit) via 3046c1f850a5750181afb87e9ed216516b63c5b9 (commit) via f8e1db67f033031a94d3427718b920e24498ac1b (commit) via 131bce2cedc400e4ee139828657e94b7a1ce2f41 (commit) via b488527ebeb3b335854f2290aa1c6cf80f464eb0 (commit) via dd18ec355bcd369b4d9b1017caf0851d067cf811 (commit) via b090ff49df4dca3a93d5c3a32f91e7924950ec0a (commit) via 3bed943ba2c8150490a6c6cde628ff3857a98613 (commit) via 7c97f5263d474adc11688b9b7773c5b8705d10d3 (commit) via e26ab5d79094e2c420542f8e8781aac347380bda (commit) via 26c0b237649602ba21763059e05873b5161e7280 (commit) via 42f4249bf1e5087d84606e95d07a24865af1e15e (commit) from 8b97be3671732c68bc5d3b720f1b4e48dd73377d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 22aaf8f1f9ade2a37a14ef409388b012224041da Author: Martin Renvoize Date: Mon Oct 7 13:55:38 2019 +0100 Bug 18421: DBRev 19.06.00.035 Signed-off-by: Martin Renvoize commit 47e48f3ade4eba7fc12cf39c865b366e092a73f2 Author: Maryse Simard Date: Fri Jan 4 09:18:33 2019 -0500 Bug 18421: (follow-up) Center image in results table Adds the "thumbnail" class to the image to have it centered. Signed-off-by: Alex Buckley Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 4ecc88b25969d3bb663b55de9ba377b9170f9992 Author: Owen Leonard Date: Fri Oct 5 15:14:57 2018 +0000 Bug 18421: (follow-up) Adding missing filters This patch adds template filters as prompted by the QA tool. Signed-off-by: Alex Buckley Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit ef897b41f5b7e5f7f9427d8e55390988bf91d6cd Author: Charles Farmer Date: Wed Aug 8 17:43:27 2018 -0400 Bug 18421: (follow-up) QA fixes Use the community's terminology, change coce.js's path, update