[koha-commits] main Koha release repository branch master updated. v19.05.00-758-g43519c0

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  43519c0525a07b8f784fd9166eb0db3430e29042 (commit)
      from  1175b9fb8703376d051267446dc9c585442c2201 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 43519c0525a07b8f784fd9166eb0db3430e29042
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Fri Oct 4 13:19:18 2019 +0100

    Bug 23612: (RM follow-up) Fix failing tests
    
    Trailing comma's were causing hidden javascript errors during selenium
    tests.
    
    Error was identified by adding a $s->capture($driver) line to the
    relevant selenium test and using the following JS snippet to dump errors
    to the screen.
    
       (function () {
           var ul = null;
           function createErrorList() {
               ul = document.createElement('ul');
               ul.setAttribute('id', 'js_error_list');
               //ul.style.display = 'none';
               document.body.appendChild(ul);
           }
           window.onerror = function(msg){
               if (ul === null)
                   createErrorList();
               var li = document.createElement("li");
               li.appendChild(document.createTextNode(msg));
               ul.appendChild(li);
           };
       })();
    
    Which clearly showed the following error.
    
        ReferenceError: KohaTable is not defined
    
    Removing the trailing comma's introduced in this bug resolved the issue.
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)


hooks/post-receive
-- 
main Koha release repository