[koha-commits] main Koha release repository branch master updated. v19.05.00-774-g6a17bf7
Git repo owner
gitmaster at git.koha-community.org
Mon Oct 7 14:22:33 CEST 2019
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 6a17bf77853a433c71938a1344486932c30d899a (commit)
via a3ec118dd9b8b6ff34ab721e81198dafb92c703e (commit)
via 5a92300abf50fc3b82bd82f746e2c48a569a0b3d (commit)
via 3567f21ebb2aff72327b4c000df187dbb96275d3 (commit)
via 7a80c94d96d5d0717d9a73a4d73fd1b7256bb181 (commit)
via 12d33316918d6e333c670d0cc4a218bda2c964c6 (commit)
via a9d5147dfd26539dc13989d82faa54032ba26600 (commit)
via b5f1297aa93c00b8d2b190a0a71fb5b41343af81 (commit)
via 541b1fca0b5816dfb16104674e3a15bd75af371e (commit)
via 92b57309ba82c4213e4023e22bc73cebbffcad13 (commit)
via 9249a1751a505c4e1c384e66d11bb370a664985d (commit)
via 2f54850591f589b6a5750f3cff5df846d3e52ee1 (commit)
via e909494ac90b2c473815795e9256ecd2f967b223 (commit)
via 43d999cc7c7edc54e3df7482b3ab3607755e4b6d (commit)
via a4bee10d0b73e12721e65908283a37a675bb44c4 (commit)
from 5c76ad78a3d5c9d485a7884deb2fe39834fb880c (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 6a17bf77853a433c71938a1344486932c30d899a
Author: Nick <nick at bywatersolutions.com>
Date: Thu Oct 3 13:21:35 2019 +0000
Bug 23730: Fix export of reports
To test:
1 - Run a saved report
2 - Attempt to export results
3 - It fails
4 - Apply patch
5 - It succeeds
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit a3ec118dd9b8b6ff34ab721e81198dafb92c703e
Author: Agustin Moyano <agustinmoyano at theke.io>
Date: Thu Oct 3 14:14:47 2019 -0300
Bug 23710: (follow-up) Add tests for new features in Koha::REST::V!::Holds::add and return error when hold date in future is not allowed and it is passed as parameter
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 5a92300abf50fc3b82bd82f746e2c48a569a0b3d
Author: Agustin Moyano <agustinmoyano at theke.io>
Date: Wed Oct 2 11:26:57 2019 -0300
Bug 23710: (follow-up) Human readable error messages in request.tt, check AllowHoldPolicyOverride and AllowHoldDateInFuture in Koha::REST::V1::Holds.pm
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 3567f21ebb2aff72327b4c000df187dbb96275d3
Author: Agustin Moyano <agustinmoyano at theke.io>
Date: Tue Oct 1 15:26:55 2019 -0300
Bug 23710: Use API to place holds for patrons
This patch effectively uses API to place holds for patrons. It adds a listener on submit event of the form in javascript, where it calls holds API.
To test:
1. Place a hold on any biblio for a patron
SUCCESS => hold is placed or rejected, but no blank page with JSON error is shown.
2. Place a multi hold for any patron
SUCCESS => holds are placed or rejected, but no blank page with JSON error is shown.
3. Sign off
Signed-off-by: Lisette Scheer <lisetteslatah at gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 7a80c94d96d5d0717d9a73a4d73fd1b7256bb181
Author: Nicolas Legrand <nicolas.legrand at bulac.fr>
Date: Mon Sep 23 18:55:56 2019 +0200
Bug 23671: Elasticsearch shouldn't throw exception on an uppercase subfield identifier
Prevent Elasticsearch from throwing an exception when the mappings
include uppercase subfield identifier.
Though forbidden in MARC21, It doesn't seem to be the case for Unimarc
or ISO 2709 as a whole. It is also possible to define such a subfield
identifier in the Koha MARC Framework and in the Elasticsearch
mappings.
Test plan:
1. add a 995Z subfield identifier in Elasticsearch mappings
(Administration -> Search engine configuration)
2. run $KOHA_PATH/misc/search_tools/rebuild_elasticsearch.pl -v -d -b
3. see it throw: “Invalid MARC field expression: 995Z”
4. apply patch
5. rerun $KOHA_PATH/misc/search_tools/rebuild_elasticsearch.pl -v -d -b
6. sababa
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 12d33316918d6e333c670d0cc4a218bda2c964c6
Author: Nicolas Legrand <nicolas.legrand at bulac.fr>
Date: Mon Sep 23 18:27:32 2019 +0200
Bug 23670: Load Koha::Exceptions::ElasticSearch module in Koha::SearchEngine::Elasticsearch
Prevent Koha::SearchEngine::Elasticsearch from dying when trying to run
Koha::Exceptions::Elasticsearch::MARCFieldExprParseError->throw()
Plan test:
1. Go to Administration -> Searchengine configuration, and add a mapping
for 995Z, whatever the search field (I did it with local-classification),
save
2. run $KOHA_PATH/misc/search_tools/rebuild_elasticsearch.pl -v -d -b
3. see it die asking for Koha::Exceptions::Elasticsearch
4. apply patch
5. rerun $KOHA_PATH/misc/search_tools/rebuild_elasticsearch.pl -v -d -b
6. see it throw: Invalid MARC field expression: 995Z
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit a9d5147dfd26539dc13989d82faa54032ba26600
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Mon Oct 7 12:45:23 2019 +0100
Bug 23007: DBRev 19.06.00.034
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit b5f1297aa93c00b8d2b190a0a71fb5b41343af81
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Wed Jun 12 19:54:42 2019 +0000
Bug 23007: Retain focus on 'barcode' input if transfers don't block circ
To test:
1 - Apply patches
2 - Update database
3 - Confirm TransfersBlockCirc defaults to 'Block'
4 - Check in an item that needs transfer
5 - Confirm you must deal with the modal to proceed
6 - Repeat checking to get 'wrong-transfer-modal'
7 - Confirm you must deal with it to proceed
8 - Switch the pref to 'Don't block'
9 - Find a new item or cancel/fulfill the preceeding transfer
10 - Check in the item to generate transfer
11 - Note focus remains on the barcode field and you can continue scanning (or typing if you don't have a scanner)
12 - Note typing and pressing enter continues without requiring you to deal with modal
13 - Repeat for wrong transfer modal
14 - Verify hold and other modals still block continuing circulation
Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 541b1fca0b5816dfb16104674e3a15bd75af371e
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Jun 27 10:54:26 2019 +0000
Bug 23007: Add TransfersBlockCirc system preference
Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 92b57309ba82c4213e4023e22bc73cebbffcad13
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Mon Oct 7 12:25:24 2019 +0100
Bug 23039: Compiled CSS
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 9249a1751a505c4e1c384e66d11bb370a664985d
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Aug 30 19:56:28 2019 +0000
Bug 23039: Don't hide the checkin dialogs
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 2f54850591f589b6a5750f3cff5df846d3e52ee1
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue Jul 30 15:16:26 2019 +0000
Bug 23039: Hold found modal on checkin screen ( circulation.pl ) obscures Check in message info
This patch modifies the checkin process so that any errors or messages
related to the current checkin are displayed in any hold/transit modal
which is displayed. This prevents any information from being hidden by
the modal.
This patch also adds an "information" button to the checkout form which
the user can click to redisplay the last modal which was dismissed
(unless confirming the modal reloads the page).
To test, apply the patch and rebuild the staff client CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).
- Test the checkin process with various types of items:
- Item not checked out
- Item not checked out, on hold
- Item not checked out, needs to be transferred
- Item is marked lost, needs to be transferred
- Item checked out, patron has waiting holds (with
WaitingNotifyAtCheckin enabled)
- Item checked out, patron has outstanding fines (with
FineNotifyAtCheckin enabled)
- Test that the modal redisplay button works in cases where the modal
is dismissed without triggering a page reload:
- Hold confirmation -> Ignore
- Transfer confirmation -> OK
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit e909494ac90b2c473815795e9256ecd2f967b223
Author: Dobrica Pavlinusic <dpavlin at rot13.org>
Date: Wed Oct 2 11:32:17 2019 +0200
Bug 23589: Discharge notice does not show non-latin characters
It seems that discarge notices never got support for truetype
fonts, so notices are missing non-latin characters.
Signed-off-by: Theodoros Theodoropoulos <theod at lib.auth.gr>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 43d999cc7c7edc54e3df7482b3ab3607755e4b6d
Author: Dobrica Pavlinusic <dpavlin at rot13.org>
Date: Thu Oct 3 09:34:17 2019 +0200
Bug 23723: using exit inside eval to stop sending output to browser doesn't work under plack
When fixing Bug 23589 Theodoros Theodoropoulos noticed that we are sending
headers and html after pdf output to browser.
Using exit inside eval block doesn't stop plack from generating
headers and html page after exit since CGI::Compile will catch
exit but doesn't stop emiting output. Example is:
eval {
warn "in eval";
exit;
};
warn "after eval";
Under CGI, this would print just "in eval", but under plack we get both lines
and thus generate additional header and html after we already sent pdf data.
Signed-off-by: Theodoros Theodoropoulos <theod at lib.auth.gr>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit a4bee10d0b73e12721e65908283a37a675bb44c4
Author: Björn Nylén <bjorn.nylen at ub.lu.se>
Date: Fri Sep 14 08:19:46 2018 +0200
Bug 21343: Respect patron language preference in automtic renewals
To test:
1) Set up different automatic renewal notices for Default and one other language
2) Make sure you have checkouts due for auto-renewal to patrons with non-Default language pref
3) Run automatic_renewals.pl . All patrons will get the default-language notice
4) Apply patch.
5) Repeat 2)
6) Run automatic_renewals.pl . Patrons will receive notices according to their language preference.
Sponsored-by: Lund University Library
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
-----------------------------------------------------------------------
Summary of changes:
Koha.pm | 2 +-
Koha/Patron/Discharge.pm | 20 +-
Koha/REST/V1/Holds.pm | 14 +-
Koha/SearchEngine/Elasticsearch.pm | 3 +-
installer/data/mysql/sysprefs.sql | 1 +
installer/data/mysql/updatedatabase.pl | 10 +
.../intranet-tmpl/prog/css/src/staff-global.scss | 32 ++
koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 2 +-
.../en/modules/admin/preferences/circulation.pref | 6 +
.../intranet-tmpl/prog/en/modules/circ/returns.tt | 498 ++++++++++----------
.../prog/en/modules/reserve/request.tt | 93 +++-
members/discharge.pl | 4 +-
misc/cronjobs/automatic_renewals.pl | 1 +
opac/opac-discharge.pl | 4 +-
reports/guided_reports.pl | 2 +-
t/db_dependent/api/v1/holds.t | 66 ++-
16 files changed, 489 insertions(+), 269 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list