[koha-commits] main Koha release repository branch master updated. v19.05.00-886-g90e2882
Git repo owner
gitmaster at git.koha-community.org
Wed Oct 9 15:55:15 CEST 2019
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 90e2882568375bce956d0cb50edfa070c42cafce (commit)
via afa1106782d794b98efa90200ac793d7078a2686 (commit)
via 83a545d8318560eb2ee385289ff8c291f07f6716 (commit)
via bc9871f428af323901ebe57a6d0888f1dcf871cf (commit)
via 759790c97aee0c5e7d768459f3cf7525961666ef (commit)
via ce8896f17d99cbbc663b8cc59110ce01d8e70afd (commit)
via a94e863c3ed17c177c9ce5d284616791fd5cd380 (commit)
from 13de5a93200bd6621d1fa2eab5279d51264dce8a (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 90e2882568375bce956d0cb50edfa070c42cafce
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Wed Oct 9 08:28:32 2019 -0400
Bug 23626: Add missing TT failure
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit afa1106782d794b98efa90200ac793d7078a2686
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Mon Oct 7 12:34:07 2019 -0400
Bug 23626: [alternate] Default to including all rows
If a person is fetching all data, it seems most likely that that person wants
to see all the data in the chart. We should default to that behavior.
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 83a545d8318560eb2ee385289ff8c291f07f6716
Author: Nick <nick at bywatersolutions.com>
Date: Wed Oct 2 09:58:59 2019 +0000
Bug 23626: Only fetch full chart data if requested
This patchset prevents the full return of report data unless explicitly requested by the user for charting purposes
Additionally the user is warned if requesting more than 1000 rows of data
To test:
1 - Create a report that returns over 1000 rows of data
2 - Run the report
3 - Note you have two buttons now 'Chart data' and 'Fetch all data for chart'
4 - Click chart data
5 - Note the note that you are only charting visible data
6 - Create the chart and confirm it works
7 - Close the chart
8 - Click 'Fetch all data'
9 - Note the confirm window
10 - Click 'cancel', note there is no change
11 - Repeat and click ok
12 - Fetch all data button is gone
13 - Page to next data, note fetch all does not return
14 - Click 'Chart data'
15 - Note you now have checkbox option to use all data in report
16 - Click it
17 - Create chart
18 - Confirm it works as expected
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit bc9871f428af323901ebe57a6d0888f1dcf871cf
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue Oct 8 14:18:01 2019 +0000
Bug 23778: Regression: Guarantor entry section no longer has a unique id
This patch adds back a fieldset ID which was accidentally removed by Bug
14570:
<fieldset id="memberentry_guarantor" class="rows">
This ID is important if libraries want to customize the patron entry
page to hide the guarantor section.
To test, apply the patch and go to Patrons -> New patron.
Inspect the markup and look at the fieldset labeled "Guarantor
information." It should have the correct ID attribute.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 759790c97aee0c5e7d768459f3cf7525961666ef
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Sat Jun 8 15:34:24 2019 -0500
Bug 22927: Do not check an already lost item when marked as withdrawn or damaged
Due to how moredetail.pl was written it was hard to know which action
was triggered.
Test plan:
- Set MarkLostItemsAsReturned to "from the items tab of the catalog
module."
- Check an item out to a patron
- Use additem.pl to set that item to a lost status without returning it
- go to moredetail.pl for that item
- mark item as either damaged or withdrawn without interacting with the
lost dropdown
- note that item has not been returned
Note for QA: Maybe we could have just tested if exists $item_changes->{'itemlost'}
to call LostItem
Signed-off-by: Claudie Trégouët <claudie.tregouet at biblibre.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit ce8896f17d99cbbc663b8cc59110ce01d8e70afd
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Fri Aug 9 13:51:46 2019 +0200
Bug 22997: Unit test
Run prove t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit a94e863c3ed17c177c9ce5d284616791fd5cd380
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Tue May 28 15:48:54 2019 +0200
Bug 22997: Searching gives no results in auth_finder.pl
During cataloguing of an existing biblio, on an heading field,
the use of tag editor fills authorities finder with existing value :
Search main heading ($a only)
Search main heading
Default operator beeing 'contains'.
Actually with Elasticsearch those search give no results.
Example with heading :
200
$a Casaubon
$b Isaac
$f 1559-1614
Call to Elasticsearch :
"query" : {
"bool" : {
"must" : [
{
"query_string" : {
"query" : "Casaubon*",
"default_field" : "heading-main",
}
},
{
"query_string" : {
"query" : "(Isaac*) AND (1559-1614*)",
"default_field" : "heading"
}
}
]
}
},
"sort" : [
{
"heading__sort.phrase" : "asc"
}
]
}
Patch adds to "query_string" :
analyze_wildcard : true.
Test plan :
1) Use Elasticsearch
2) Edit an existing biblio record
3) Use tag editor on a heading
4) Click search => You get correct results
5) Check also search in authorities-home.pl
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
-----------------------------------------------------------------------
Summary of changes:
Koha/SearchEngine/Elasticsearch/QueryBuilder.pm | 7 ++++-
catalogue/updateitem.pl | 13 +++++-----
koha-tmpl/intranet-tmpl/prog/en/includes/chart.inc | 14 +++++++---
.../prog/en/includes/reports-toolbar.inc | 8 +++++-
.../prog/en/modules/catalogue/moredetail.tt | 11 ++++----
.../prog/en/modules/members/memberentrygen.tt | 2 +-
.../en/modules/reports/guided_reports_start.tt | 27 +++++++++++++++-----
reports/guided_reports.pl | 13 ++++++----
.../Koha/SearchEngine/Elasticsearch/QueryBuilder.t | 3 ++-
9 files changed, 67 insertions(+), 31 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list