[koha-commits] main Koha release repository branch 18.11.x updated. v18.11.10-24-g9273726

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.11.x has been updated
       via  92737269971aa1922d5f243e0541338ec3dd8895 (commit)
      from  1823373769a7edd33152f0eabb28d434ff588d2c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 92737269971aa1922d5f243e0541338ec3dd8895
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Wed May 31 16:54:32 2017 +0200

    Bug 18710: Wrong subfield modified in batch item modification
    
    In Tools > Batch item modification, one can modify or delete a subfield.
    When deleting a subfield et modifying another, the wrong subfield gets modified.
    
    This is caused by the fact that disabled inputs are not posted in form.
    So for a subfield to delete :
    Input name=field_value is not posted. But input name=subfield is posted with subfield code.
    So these 2 arrays does not have the same size :
        my @subfields = $input->multi_param('subfield');
        my @values    = $input->multi_param('field_value');
    
    For exemple, deleting $2, not changing $u and modidying $v will modify $u with value for $v o_O
    
    This patch correts but setting disabled all inputs of a deleted subfield : field_value, tag, subfield and mandatory. Like it was not present in the form.
    
    Test plan :
    - Go to Tools > Batch item modification
    - Enter a barcode and submit
    - Lets say there are subfields : $2 (not mandatory), $u and $v
    - Check the subfield $2 to be deleted
    => $2 input is disabled
    - Enter a text in $v
    - Submit the form
    => Without patch, the text for $v gets into $u
    => With patch, the text for $v gets into $v
    - Check the subfield $2 is well deleted
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit adb232c8f0f4bf8574ca3dce9548196430c57fb0)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
    (cherry picked from commit d8a1871dd0a08b86931c80ad717b4d5e55577c3f)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)


hooks/post-receive
-- 
main Koha release repository