[koha-commits] main Koha release repository branch 18.11.x updated. v18.11.10-28-g539e2a3

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.11.x has been updated
       via  539e2a3c7f824dc4b2167f2dcc25d0b1a35b70be (commit)
       via  8416677e76adf9fb1ed42b8cc4b42f82928fb908 (commit)
      from  0ab73be4169a8f795195e6573ae844d65371d599 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 539e2a3c7f824dc4b2167f2dcc25d0b1a35b70be
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Tue Sep 17 15:41:12 2019 -0400

    Bug 23625: Make new 'required' attributes match the currently used syntax in other templates
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 0aeb5998481a28fb72c8f184bd3f85f7491dc858)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
    (cherry picked from commit 267d0a90333006004f527fbc535556e04f6786de)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

commit 8416677e76adf9fb1ed42b8cc4b42f82928fb908
Author: Eric Phetteplace <phette23 at gmail.com>
Date:   Mon Sep 16 12:53:32 2019 -0700

    Bug 23625: ArticleRequestsMandatoryFields* only affects field labels, does not make inputs required
    
    Test plan:
    
    1. Enable article requests ( syspref: ArticleRequests => Enable, Circ and fine rules ALL/ALL (or a given category/itemtype): Article requests => Yes )
    2. Set one or more fields to require in the ArticleRequestsMandatoryFields, ArticleRequestsMandatoryFieldsItemOnly, and/or ArticleRequestsMandatoryFieldsRecordOnly settings (all these settings are affected in the same manner)
    3. Search for a title and select the "Request Article" button from the OPAC search results
    4. Authenticate as a patron
    5. Neglect to fill out at least one of the mandatory fields
    6. Select the "Place Request" button at the bottom of the form
    7. The form submits despite the empty mandatory fields
    8. Apply patch
    9. Repeat steps 3, 5, & 6
    10 . The form should refuse to submit, show a browser-native message about the missing required fields.
    
    Sponsored-by: California College of the Arts
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 64148cf4ac6f20787a809b36243672430faa6e8f)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
    (cherry picked from commit 4d8dece7ff91d619f71b1edfd8803300ed9a06bf)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 .../bootstrap/en/modules/opac-request-article.tt   |   23 +++++++++++++-------
 1 file changed, 15 insertions(+), 8 deletions(-)


hooks/post-receive
-- 
main Koha release repository