[koha-commits] main Koha release repository branch master updated. v19.05.00-965-g194a491

Git repo owner gitmaster at git.koha-community.org
Mon Oct 21 11:09:22 CEST 2019


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  194a49137f254161721b167a7e2133725e8874e9 (commit)
       via  9658cd4d18b330711a7a8e3391a83d52b35050c6 (commit)
       via  8a243ffd94bc1dcae49c712818a79007579b4f6c (commit)
       via  a473e231f771ad088511ed9e8eb514fd28117a13 (commit)
       via  fcf149d32598f3c4ead2d36dbd3f7a3cafd83e30 (commit)
      from  d595a931320e7567810b48f4e896f930bace4cb2 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 194a49137f254161721b167a7e2133725e8874e9
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Thu Oct 17 17:28:15 2019 +0100

    Bug 20086: (follow-up) No need to call ->new on Koha::Database
    
    We should use the existing pattern of calling schema directly on
    Koha::Database rather than creating a new object.
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 9658cd4d18b330711a7a8e3391a83d52b35050c6
Author: Nick <nick at bywatersolutions.com>
Date:   Thu Oct 17 14:31:27 2019 +0000

    Bug 20086: Execute AddRenewal in a transaction to avoid partial success and doubled fines
    
    This patch starts a transaction and only commits if renewal and fines
    updates and charges are successful (partial in any cna be problematic)
    
    There is no feedback (as currently there is none either) but if part
    fails, all fails.
    
    I didn't include stats and notifications in the transaction, but we
    could. (Edit JD: not true, they are included)
    
    To test:
    1 - Apply patch
    2 - prove t/db_dependent/Circulation.t
    3 - Attempt circs and renewals should be no difference
    4 - If possible make part of transaction fail and ensure all fails
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Amended: commit title and one indendation (return statement)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 8a243ffd94bc1dcae49c712818a79007579b4f6c
Author: Magnus Enger <magnus at libriotech.no>
Date:   Mon Sep 30 15:01:35 2019 +0200

    Bug 23700: Fix output of koha-plack --restart
    
    To test:
    - Run "sudo koha-plack restart kohadev" and verify the output is
      out of line.
    - Apply the patch
    - If you are on e.g. kohadevbox you need to copy koha-plack to
      /usr/sbin/ thus:
      sudo cp debian/scripts/koha-plack /usr/sbin/koha-plack
    - Run "sudo koha-plack restart kohadev" again and check that you
      get two lines of output, nicely aligned with the "OK" inside the
      square brackets.
    
    Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit a473e231f771ad088511ed9e8eb514fd28117a13
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Fri Oct 18 12:34:43 2019 +0000

    Bug 23712: (QA follow-up) Silence two other warns too
    
    Caused by undefined method:
    Use of uninitialized value in concatenation (.) or string at /usr/share/koha/Koha/Illrequest.pm line 857.
    Use of uninitialized value in concatenation (.) or string at /usr/share/koha/Koha/Illrequest.pm line 859.
    
    Test plan:
    Run test again
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit fcf149d32598f3c4ead2d36dbd3f7a3cafd83e30
Author: Magnus Enger <magnus at libriotech.no>
Date:   Tue Oct 1 16:41:31 2019 +0200

    Bug 23712: Silence warns from Koha/Illrequest/Logger.pm
    
    To test:
    - Run: $ sudo koha-shell -c "prove t/db_dependent/Illrequests.t" kohadev
    - Observe the warnings about "no query in themelanguage"
    - Apply the patch
    - Run prove again
    - Observe the lack of warnings about "no query in themelanguage"
      (There will be a couple of other warnings, but they are not
      related to the present bug.)
    
    Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Circulation.pm         |  189 +++++++++++++++++++++++----------------------
 Koha/Illrequest.pm        |    4 +-
 Koha/Illrequest/Logger.pm |    3 +-
 debian/scripts/koha-plack |    9 +--
 4 files changed, 102 insertions(+), 103 deletions(-)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list