[koha-commits] main Koha release repository branch master updated. v19.05.00-980-gf4936fd

Mon Oct 21 11:27:19 CEST 2019

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  f4936fd46a284aeb1976965b83a6a29caefa2890 (commit)
       via  1800a2e6b810d2ec789ece4b9b9c1fb2c3ad666d (commit)
       via  7ce5cb0865fb7eb9174a4b4edbf80e9acfcda920 (commit)
       via  ab4a8755c22269dbe0f8809667c0e0f1e03bc3ea (commit)
       via  3c0c75e6af321f02f7934979fbda0091578cfa8a (commit)
       via  d7d5a40548c5adb918cd4b35706db0679e46b005 (commit)
      from  6d8a26e5759fa81eff296fb733699ee8cdce3c7e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit f4936fd46a284aeb1976965b83a6a29caefa2890
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Tue Oct 8 15:43:10 2019 -0300

    Bug 23770: (follow-up) Use ->to_api in /cities

    This patch aims to prove the behaviour does not differ. So you can run
    the tests for the endpoints, and the behaviour remains.

    The mappings and methods cannot be removed until $c->objects->search is
    fixed to make use of them as well. That will happen once all used
    Koha::Object-based classes implement the mappings.

    To test:
    1. Apply this patch
    2. Run:
       $ kshell
      k$ prove t/db_dependent/api/v1/cities.t
    => SUCCESS: Tests pass!

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 1800a2e6b810d2ec789ece4b9b9c1fb2c3ad666d
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Tue Oct 8 12:51:52 2019 -0300

    Bug 23770: (follow-up) Add tests for Koha::Objects->TO_JSON

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 7ce5cb0865fb7eb9174a4b4edbf80e9acfcda920
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Tue Oct 8 12:13:23 2019 -0300

    Bug 23770: Unit tests

    This patch introduces tests for the new to_api method introduced in
    Koha::Object(s).

    It uses Koha::City as a sample for simplicity. And it also uses
    Koha::Illrequests to test the case in which there's no to_api_mapping
    method defined on the class, to highlight that a fallback to calling
    TO_JSON is done. [1]

    [1] This is done under the assumption Illrequests controller code
    doesn't use any kind of mapping as the rest of the API controllers do,
    so there's little chance it would be added in a future.

    To test:
    1. Apply this patchset
    2. Run:
       $ kshell
      k$ prove t/db_dependent/Koha/Object.t \
               t/db_dependent/Koha/Objects.t
    => SUCCESS: Tests pass!
    3. Sign off :-D

    Sponsored-by: ByWater Solutions
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit ab4a8755c22269dbe0f8809667c0e0f1e03bc3ea
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Tue Oct 8 12:12:56 2019 -0300

    Bug 23770: Add to_api_mapping method to Koha::City

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 3c0c75e6af321f02f7934979fbda0091578cfa8a
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Mon Oct 7 15:55:09 2019 -0300

    Bug 23770: Add Koha::Object(s)->to_api method

    Generic method that changes the attribute names of an object in the
    presence of the to_api_mapping method. It otherwise falls back to
    returning the TO_JSON output.

    This is WIP submitted early for scrutiny. Tests and example usage in an
    API controller coming.

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit d7d5a40548c5adb918cd4b35706db0679e46b005
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Fri Jul 19 10:24:01 2019 +0000

    Bug 23346: Add without-db-name parameter to koha-dump

    Test plan:
    Run koha-dump [yourdb]. Rename the files in var/spool/koha/[yourdb]
    Run koha-dump --without-db-name [yourdb]
    Run a diff between the unzipped sql files. The last dump should not
    contain a CREATE DATABASE and USE statement. See BZ 15664 c4.

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha/City.pm                  |   21 ++++++++++++++--
 Koha/Object.pm                |   34 ++++++++++++++++++++++++++
 Koha/Objects.pm               |   12 +++++++++
 Koha/REST/V1/Cities.pm        |    6 ++---
 debian/scripts/koha-dump      |    9 ++++++-
 t/db_dependent/Koha/Object.t  |   54 ++++++++++++++++++++++++++++++++++++++++-
 t/db_dependent/Koha/Objects.t |   52 ++++++++++++++++++++++++++++++++++++++-
 7 files changed, 180 insertions(+), 8 deletions(-)

hooks/post-receive
-- 
main Koha release repository