[koha-commits] main Koha release repository branch master updated. v19.05.00-1107-gd4af82d

Sat Oct 26 09:17:44 CEST 2019

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  d4af82d411613f4d12d5e3e31de399aa43355cb4 (commit)
       via  a5bf7b1e558ea38998d4661f074e99d028178c96 (commit)
       via  a693c7243c23f888e2fad38a4fff9f37ff4a9301 (commit)
       via  bbdee010aa192ec0df436a79730343df2b855ff4 (commit)
       via  8f3093c9a09c9c88b6885ac79b8273cf212f6f65 (commit)
       via  080958231e02c7e1139aea33cbe20baa184d4c4b (commit)
       via  af9333292799695b5322a5cf1598e12f08f0a66c (commit)
       via  f8e2c489cb668aab9e7484c2dd67c1c05f37b2a5 (commit)
       via  9063d05662ead802ebb8bbb53730834e6ea5e458 (commit)
       via  34e5391d9080f6e9c7bef48878ab888510aca7d0 (commit)
       via  28055d334741f8045423f9ac54106050e6b40d01 (commit)
      from  a53641328c7f20ae5de9de246fb6f3a1d3edf80c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit d4af82d411613f4d12d5e3e31de399aa43355cb4
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri Oct 25 15:28:49 2019 +0200

    Bug 23382: Use floating time zone to prevent tests to fail because of DST

    Today Friday Oct 25th, DST next Sunday => Date math are wrong, 96 hours
    diff becomes 95.
    To avoid that we use the floating timezone

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit a5bf7b1e558ea38998d4661f074e99d028178c96
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Fri Oct 25 11:29:58 2019 +0100

    Bug 23382: (follow-up) Ensure closed day is inside charge window

    We're testing with an hourly loan of 96 hours to catch a closed day.
    However, our closed day was hard coded to be a Wednesday so if you ran
    the tests on a Friday the 96 hour loan would not catch a Wednesday.

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit a693c7243c23f888e2fad38a4fff9f37ff4a9301
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Wed Oct 16 13:10:43 2019 +0100

    Bug 23382: hours_between should match the logic of days_between

    The loops for subtraction holiday dates in hours_between and
    days_between differed and as such their handling of start and end
    boundaries for days also differed.  This patch makes them handle the
    boundary days consistently.

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit bbdee010aa192ec0df436a79730343df2b855ff4
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Wed Oct 16 13:08:23 2019 +0100

    Bug 23382: Truncate dates to minutes for comparison.

    It's somewhat of a mess in C4::Circulation as to when dates are
    truncated and when they are not and as such Koha::Charges::Fees could
    not reliably assume that the dates passed in were consistent with each
    other. As such, we take the approach of always truncating to the
    greatest minute smaller than the passed in dates so we are comparing
    like for like.

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 8f3093c9a09c9c88b6885ac79b8273cf212f6f65
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Wed Oct 16 11:44:11 2019 +0100

    Bug 23382: (follow-up) Further improve test coverage

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 080958231e02c7e1139aea33cbe20baa184d4c4b
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Wed Oct 2 11:20:27 2019 +0100

    Bug 23382: (follow-up) Ensure tests pass on Wednesdays

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit af9333292799695b5322a5cf1598e12f08f0a66c
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Thu Sep 19 14:48:45 2019 +0100

    Bug 23382: (follow-up) Clarify variable names

    This patch updates the variable name '$branch' to '$branchcode' in a
    number of places to make it clearer what the variable contains.

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit f8e2c489cb668aab9e7484c2dd67c1c05f37b2a5
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Fri Aug 16 08:32:55 2019 +0100

    Bug 23382: Fix logic in C4::Circulation::CanBookBeIssued

    It looks like over progressive rebases of bug 20912 a clause was lost
    within CanBookBeIssued such that a fatal error may be triggered if an
    item with no corresponding itemtype was passed into the routine.

    Additionally the we were passing a Koha::Library object to CalcDateDue
    rather than a branchcode which resulted in a different duedate being
    used in 'CanBookBeIssued' when compared to 'AddIssue'.

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 9063d05662ead802ebb8bbb53730834e6ea5e458
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Thu Aug 15 14:57:08 2019 +0100

    Bug 23382: Add hourly tests for Circulation

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 34e5391d9080f6e9c7bef48878ab888510aca7d0
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Tue Aug 6 15:23:39 2019 +0100

    Bug 23382: Add tests for hourly calculations

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 28055d334741f8045423f9ac54106050e6b40d01
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Tue Aug 6 14:38:28 2019 +0100

    Bug 23382: Improve test coverage

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Circulation.pm                  |   44 +++---
 Koha/Calendar.pm                   |   12 +-
 Koha/Charges/Fees.pm               |   48 ++++--
 t/db_dependent/Circulation.t       |  163 ++++++++++++++-----
 t/db_dependent/Koha/Charges/Fees.t |  305 +++++++++++++++++++++++++++++++++---
 5 files changed, 478 insertions(+), 94 deletions(-)

hooks/post-receive
-- 
main Koha release repository