[koha-commits] main Koha release repository branch master updated. v19.05.00-1161-ga9bdeac
Git repo owner
gitmaster at git.koha-community.org
Thu Oct 31 13:45:05 CET 2019
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via a9bdeac01a732d29d32c0c6519bea3c835b49784 (commit)
via eec93f0628d524f08860f0c727141e2e7c072d5b (commit)
via 469b419adb6375dce2f7a4e52938c51605d491ff (commit)
via df2a054681cca94700998ce2d142bc11212a592b (commit)
via efa8ef9dcb5fb0bd1710c0c2866c320fbd2e084f (commit)
via 93143b207fb2647449a0a0e3446e7aeacb8ddae8 (commit)
via bfcbe72edbeed0cfbbd403a1c19427bee11eac46 (commit)
via 9dbf0ff0e0ea968fa408fc6e12bfbc943ceb9f26 (commit)
via 40e841da984f0aeb13a4632ce83a638cee47a434 (commit)
via a670f9068d982d3f905967255006faf871cdaf4f (commit)
via 291f03fe65da4476b33adf9f9e7e533668b9a313 (commit)
via a44ffa0926d648b4b1509c56e3227784f5404942 (commit)
via 15d95a74e4712139ae7b377a5879d66e6d0d5277 (commit)
via f08de08858f570fcf836051f490cf661142e2388 (commit)
via e97887bcbbbda9a84a9386719db242bb5043f428 (commit)
via e89c5bfed6a75d7222c8328e2b4371066ee06ff3 (commit)
via 2e09dc9319bd95e479879a52fbbe3e8c934e741f (commit)
via e2eaafd939ffdeeae3ae02814dc81eb015f04808 (commit)
from c76c509d830b48e009f55d7da23faf3baba600a5 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit a9bdeac01a732d29d32c0c6519bea3c835b49784
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Thu Oct 31 12:21:01 2019 +0000
Bug 22706: (RM follow-up) Add unit tests
Helps if one actually adds the new test file to the commit!
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit eec93f0628d524f08860f0c727141e2e7c072d5b
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Thu Oct 31 12:16:46 2019 +0000
Bug 14697: DBRev 19.06.00.047
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 469b419adb6375dce2f7a4e52938c51605d491ff
Author: Josef Moravec <josef.moravec at gmail.com>
Date: Wed Oct 30 18:00:53 2019 +0000
Bug 14697: (QA follow-up) Remove tab chars
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit df2a054681cca94700998ce2d142bc11212a592b
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Wed Oct 30 12:17:15 2019 -0300
Bug 14697: (follow-up) Add auth values to the sample data
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit efa8ef9dcb5fb0bd1710c0c2866c320fbd2e084f
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Oct 29 17:43:13 2019 -0300
Bug 14697: (QA follow-up) Restore FK on issue_id and adjust tests
This patch reintroduces the FK constraint on issue_id. The tests are
adjusted to reflect the UNIQUE constraint we also added.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 93143b207fb2647449a0a0e3446e7aeacb8ddae8
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Oct 29 15:57:06 2019 -0300
Bug 14697: (QA follow-up) Add missing AV category
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Lisette Scheer <lisetteslatah at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit bfcbe72edbeed0cfbbd403a1c19427bee11eac46
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Oct 29 15:38:48 2019 -0300
Bug 14697: (QA follow-up) Organize tests in subtests
This patch organizes the tests better, and adds some more.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Lisette Scheer <lisetteslatah at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 9dbf0ff0e0ea968fa408fc6e12bfbc943ceb9f26
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Oct 29 10:27:18 2019 -0300
Bug 14697: Make controller methods rely on the stashed user
This patch adjusts the return values and HTTP status codes, as well as
removing the use of C4::Context->userenv. It also makes the date
calculation happen on the DB engine in the case of resolving the claim.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Lisette Scheer <lisetteslatah at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 40e841da984f0aeb13a4632ce83a638cee47a434
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Oct 28 16:18:52 2019 -0300
Bug 14697: (follow-up) Rely on the UNIQUE constraint and return 409 for issue_id
This patch avoids querying the DB for an already existing
Koha::Checkouts::ReturnClaim with the same issue_id, now that there's a
UNIQUE constraint on it.
Also, 409 should be returned instead. Tests added for this changes.
To test:
- Apply this patch
- Run:
$ kshell
k$ prove t/db_dependent/api/v1/return_claims.t
=> SUCCESS: tests pass!
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Lisette Scheer <lisetteslatah at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit a670f9068d982d3f905967255006faf871cdaf4f
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Tue Oct 29 12:32:15 2019 -0300
Bug 14697: Schema updates
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Lisette Scheer <lisetteslatah at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 291f03fe65da4476b33adf9f9e7e533668b9a313
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Tue Oct 29 12:29:54 2019 -0300
Bug 14697: Enhance the return claims feature
This adds a "Claims returned" feature that extends and enhances the claims returned lost status.
To use this feature, a new LOST status to represent an item claimed as returned needs to be created.
The value of this LOST authorised value should be set in the new syspref ClaimReturnedLostValue.
Setting this system preference turns on the feature.
Once the feature is enabled, you should be able to mark checked out items as return claims from the
checkout and patron details pages, and also modify them from the new claims tab on those pages.
Returning a claimed item will notify the librarian that the item in question has a claim on it.
Setting the ClaimReturnedWarningThreshold will add an alert to make librarians aware that this
patron has many return claims on the patron's record.
Test Plan:
1) Create a "Claims Returned" lost value
2) Create some RETURN_CLAIM_RESOLUTION authorized values
3) Set ClaimReturnedLostValue
4) Set ClaimReturnedChargeFee
5) Set ClaimReturnedWarningThreshold
6) Create some checkouts
7) Claim some returns
8) Verify ClaimReturnedChargeFee works with all 3 options
9) Verify ClaimReturnedWarningThreshold shows a warning once the threshold has been exceeded
10) Edit notes on a claim
11) Resolve a claim
12) Delete a claim
Sponsored-by: North Central Regional Library System
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Lisette Scheer <lisetteslatah at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit a44ffa0926d648b4b1509c56e3227784f5404942
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Tue Oct 29 12:29:37 2019 -0300
Bug 14697: Add routes to handle return claims
This patch adds the /return_claims route to add new return claims, and
then routes to updates notes and the resolution code.
To test:
1. Apply this patches
2. Run:
$ kshell
k$ prove t/db_dependent/api/v1/return_claims.t
=> SUCCESS: Tests pass!
3. Sign off :-D
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Lisette Scheer <lisetteslatah at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 15d95a74e4712139ae7b377a5879d66e6d0d5277
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Tue Oct 29 12:28:53 2019 -0300
Bug 14697: Add Koha::Patron->return_claims
Adds the ability to get a list of a patron's return claims directly
from the Patron object.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Lisette Scheer <lisetteslatah at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit f08de08858f570fcf836051f490cf661142e2388
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Tue Oct 29 12:28:36 2019 -0300
Bug 14697: Add Koha::Checkout->claim_returned
Adds the ability to generate a return claim from a Checkout object.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Lisette Scheer <lisetteslatah at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit e97887bcbbbda9a84a9386719db242bb5043f428
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Tue Oct 29 12:28:24 2019 -0300
Bug 14697: Add return claim handling to AddReturn
This adds the ability to alert a librarian of an item claimed as returned is actually returned.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Lisette Scheer <lisetteslatah at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit e89c5bfed6a75d7222c8328e2b4371066ee06ff3
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Tue Oct 29 12:26:56 2019 -0300
Bug 14697: Introduce Koha::Checkouts::ReturnClaim(s)
This patch introduces the Koha::Object(s)-derived classes for handling
return claims. Tests are added to cover the overloaded ->store method,
and domain-specific exceptions are added as well.
To test:
1. Apply this patches
2. Run:
$ kshell
k$ prove t/db_dependent/Koha/Checkouts/ReturnClaim.t
=> SUCCESS: Tests pass!
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Lisette Scheer <lisetteslatah at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 2e09dc9319bd95e479879a52fbbe3e8c934e741f
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Fri Feb 22 09:40:35 2019 -0500
Bug 14697: Add new schema file
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Lisette Scheer <lisetteslatah at gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit e2eaafd939ffdeeae3ae02814dc81eb015f04808
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Fri Feb 22 08:46:34 2019 -0500
Bug 14697: Update database
This patch introduces the new table and related sysprefs.
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Lisette Scheer <lisetteslatah at gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Circulation.pm | 14 +
Koha.pm | 2 +-
Koha/Checkout.pm | 56 ++-
Koha/Checkouts/ReturnClaim.pm | 113 ++++++
Koha/{Checkouts.pm => Checkouts/ReturnClaims.pm} | 39 ++-
.../{Token.pm => Checkouts/ReturnClaims.pm} | 24 +-
Koha/Patron.pm | 12 +
Koha/REST/V1/ReturnClaims.pm | 255 ++++++++++++++
Koha/Schema/Result/Borrower.pm | 64 +++-
Koha/Schema/Result/Issue.pm | 19 +-
Koha/Schema/Result/Item.pm | 19 +-
.../Result/{ArticleRequest.pm => ReturnClaim.pm} | 221 ++++++------
api/v1/swagger/definitions.json | 3 +
api/v1/swagger/definitions/return_claim.json | 93 +++++
api/v1/swagger/paths.json | 12 +
api/v1/swagger/paths/return_claims.json | 361 ++++++++++++++++++++
circ/circulation.pl | 1 +
circ/returns.pl | 4 +-
installer/data/mysql/de-DE/optional/auth_val.sql | 4 +
installer/data/mysql/en/optional/auth_val.sql | 4 +
installer/data/mysql/es-ES/optional/auth_val.sql | 4 +
installer/data/mysql/fr-CA/facultatif/auth_val.sql | 4 +
.../fr-FR/1-Obligatoire/authorised_values.sql | 4 +
installer/data/mysql/it-IT/necessari/auth_val.sql | 4 +
installer/data/mysql/kohastructure.sql | 29 ++
installer/data/mysql/mandatory/auth_val_cat.sql | 4 +
.../data/mysql/nb-NO/2-Valgfritt/auth_val.sql | 4 +
installer/data/mysql/pl-PL/optional/auth_val.sql | 4 +
...authorised_values_[RETURN_CLAIM_RESOLUTION].sql | 5 +
...authorised_values_[RETURN_CLAIM_RESOLUTION].txt | 1 +
installer/data/mysql/sysprefs.sql | 3 +
...authorised_values_[RETURN_CLAIM_RESOLUTION].sql | 5 +
...authorised_values_[RETURN_CLAIM_RESOLUTION].txt | 1 +
installer/data/mysql/updatedatabase.pl | 62 ++++
.../prog/en/includes/checkouts-table.inc | 71 ++++
.../prog/en/includes/patron-return-claims.inc | 15 +
.../intranet-tmpl/prog/en/includes/strings.inc | 5 +
.../en/modules/admin/preferences/circulation.pref | 19 ++
.../prog/en/modules/catalogue/moredetail.tt | 36 +-
.../prog/en/modules/circ/circulation.tt | 36 ++
.../intranet-tmpl/prog/en/modules/circ/returns.tt | 17 +
.../prog/en/modules/members/moremember.tt | 25 ++
koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 282 ++++++++++++++-
members/moremember.pl | 1 +
svc/checkouts | 61 ++--
svc/return_claims | 127 +++++++
t/db_dependent/Circulation/ReturnClaims.t | 136 ++++++++
t/db_dependent/Circulation/Returns.t | 27 +-
t/db_dependent/Koha/Checkouts/ReturnClaim.t | 133 ++++++++
t/db_dependent/Koha/Plugins/Patron.t | 86 +++++
t/db_dependent/api/v1/return_claims.t | 279 +++++++++++++++
51 files changed, 2636 insertions(+), 174 deletions(-)
create mode 100644 Koha/Checkouts/ReturnClaim.pm
copy Koha/{Checkouts.pm => Checkouts/ReturnClaims.pm} (60%)
copy Koha/Exceptions/{Token.pm => Checkouts/ReturnClaims.pm} (55%)
create mode 100644 Koha/REST/V1/ReturnClaims.pm
copy Koha/Schema/Result/{ArticleRequest.pm => ReturnClaim.pm} (55%)
create mode 100644 api/v1/swagger/definitions/return_claim.json
create mode 100644 api/v1/swagger/paths/return_claims.json
create mode 100644 installer/data/mysql/ru-RU/authorised_values/authorised_values_[RETURN_CLAIM_RESOLUTION].sql
create mode 100644 installer/data/mysql/ru-RU/authorised_values/authorised_values_[RETURN_CLAIM_RESOLUTION].txt
create mode 100644 installer/data/mysql/uk-UA/authorised_values/authorised_values_[RETURN_CLAIM_RESOLUTION].sql
create mode 100644 installer/data/mysql/uk-UA/authorised_values/authorised_values_[RETURN_CLAIM_RESOLUTION].txt
create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/patron-return-claims.inc
create mode 100755 svc/return_claims
create mode 100644 t/db_dependent/Circulation/ReturnClaims.t
create mode 100644 t/db_dependent/Koha/Checkouts/ReturnClaim.t
create mode 100644 t/db_dependent/Koha/Plugins/Patron.t
create mode 100644 t/db_dependent/api/v1/return_claims.t
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list