[koha-commits] main Koha release repository branch 19.05.x updated. v19.05.03-55-g0b8d8e7

Mon Sep 9 13:00:37 CEST 2019

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.05.x has been updated
       via  0b8d8e7ecb4e2d830ff49715168c5734fac6a7ed (commit)
       via  8313c80b8dd8ce553440bc28af424794db39d2ef (commit)
       via  68ef35daf5a0536884f48c98f3f6fa2bf1506119 (commit)
       via  9fb3f8d32bfd065fa2e55f1c6a7a94036b84590b (commit)
       via  6e013cf383f1f23b34e9878a86ea0b945833132f (commit)
       via  64825cb321fc63c814bf5ada06ae043cfb4f2708 (commit)
       via  967887b8892efab9d487f8991179ea305649e645 (commit)
      from  8d5a50384fb65a508b0cf944e6f6c070df888aaf (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 0b8d8e7ecb4e2d830ff49715168c5734fac6a7ed
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Fri Sep 6 13:24:10 2019 +0100

    Bug 23539: (RM follow-up) Update DBIC classes

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 49e30bc67d91f300df2efd9b7a2cf0526221fb96)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 8313c80b8dd8ce553440bc28af424794db39d2ef
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Fri Sep 6 13:20:14 2019 +0100

    Bug 23539: DBRev 19.05.03.003

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 38322b5a43b37575d4d1c2da1d4b5b0ef3b83bf4)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 68ef35daf5a0536884f48c98f3f6fa2bf1506119
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Wed Sep 4 13:48:41 2019 -0400

    Bug 23539: accountlines.accounttype should match authorised_values.authorised_value in size

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 00c61beff999c12823111fb594bec2c57a5c0d58)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 9fb3f8d32bfd065fa2e55f1c6a7a94036b84590b
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Sun Sep 1 15:26:02 2019 -0400

    Bug 23289: Quote new 'rows' MariaDB reserved word

    Since MariaDB 10.2.4 rows is a reserved word:
    https://mariadb.com/kb/en/library/mariadb-1024-release-notes/

    """
    New reserved word: ROWS. This can no longer be used as an identifier
    without being quoted.
    """

    Test plan:
    With MariaDB >= 10.2.4, create a new label template.
    Also, prove t/db_dependent/Labels/t_Template.t

    Without this patch you will get the following SQL error: DBD::mysql::st execute failed: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'rows, creator, template_code, page_height,

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit aede6896dd6ebc660894bcde117ccd213e2c3de6)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 6e013cf383f1f23b34e9878a86ea0b945833132f
Author: Mason James <mtj at kohaaloha.com>
Date:   Tue Sep 3 16:02:32 2019 +1200

    Bug 23530: Fix cart showing only hidden items

    Items hidden with the OpacHiddenItems system preference
    were still displayed in the OPAC cart and the normal items
    were hidden instead. This patch corrects the display.

    To test:
    - prep a test bib with hidden and other items using
      the OpacHiddenItems system preference
    - add bib to cart
    - observe that hidden items are displayed - non-hidden items are hidden
    - apply patch, reload page
    - observe that hidden items are hidden, non-hidden items are displayed

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 60ce66b6b658bfbe0d9ca459afc673042c7a854f)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 64825cb321fc63c814bf5ada06ae043cfb4f2708
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Sat Jun 22 20:33:45 2019 -0500

    Bug 23079: Add tests

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 6b6fe8f88b33e3455ae30526109674bfa4f3d185)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 967887b8892efab9d487f8991179ea305649e645
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Sat Jun 22 20:40:04 2019 -0500

    Bug 23079: Handle invalid timezones when adding/subtracting durations

    On Nov 3rd 2019, Brazil will skip from 00:00 to 1:00 (http://www.currenttimeonline.com/dst/dst.do?tz=America/Sao_Paulo), DateTime consider it as an invalid date.
    It is a problem when we are playing with dates without the time part (always 00:00).
    When we instantiate a DateTime (from dt_from_string) we are already handling this issue, and use the floating timezone (since bug 12669).

    The problem remains when we generate a DateTime then add or subtract a duration, which will result in an invalid date:

    DateTime->new(year => 2019, month => 12, day => 3, time_zone => 'America/Sao_Paulo')->subtract(days => 30);

    => Nov 3rd 2019, kaboom.

    We should replace all the problematic occurrences of dt_from_string->subtract (or ->add)
    with dt_from_string(undef, undef, 'floating'), to use the floating timezone and avoid the error.

    Actually there are not many of them, I have found only 3 that could
    produce real problems.

    The other occurrences are:
    - in tests => Not a big deal (for now)
    - called on a datetime, so it will explode if called at midnight
    00:00:00 (and nobody should work at that time).

    Test plan:
    0/ Define the timezone to 'America/Sao_Paulo' (in your koha-conf.xml file), restart_all
    1/ Set a patron's expiry date to Dec 3rd 2019, and
    NotifyBorrowerDeparture to 30 (default value)
    2/ See the checkouts page for this user
    => Without this patch you get "Invalid local time for date in time zone:
    America/Sao_Paulo"
    => With this patch apply the page displays correctly

    QA will review the 2 other occurrences.

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit d0040dff9f435be65503e88afe45ce196bce9c4a)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Creators/Template.pm                |    4 ++--
 Koha.pm                                |    2 +-
 Koha/Patron.pm                         |    2 +-
 Koha/Schema/Result/Accountline.pm      |    8 ++++----
 acqui/duplicate_orders.pl              |    2 +-
 acqui/histsearch.pl                    |    2 +-
 installer/data/mysql/kohastructure.sql |    2 +-
 installer/data/mysql/updatedatabase.pl |    8 ++++++++
 opac/opac-basket.pl                    |    7 ++++---
 t/db_dependent/Koha/Patrons.t          |   31 +++++++++++++++++++++++--------
 10 files changed, 46 insertions(+), 22 deletions(-)

hooks/post-receive
-- 
main Koha release repository