[koha-commits] main Koha release repository branch master updated. v19.05.00-609-g16399fd
Git repo owner
gitmaster at git.koha-community.org
Thu Sep 12 10:06:17 CEST 2019
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 16399fd2363ff4bacd2ab4ffe042d211a10e071d (commit)
via 81b2e7f4cbe7f1d2d178ef80048deac196ed80ac (commit)
via 7f8375f009e6d926ec9965ad2cbd8be1f35dd194 (commit)
via 27a165363261741ecf5c10187a572f1278be0a17 (commit)
via 5583a0a42c193b4992b3550e4d26bae0ae2630e7 (commit)
via 1ad03f5509ea287c7402c64577595a9c8cd60dfb (commit)
via 9519c92f736c7acacafc19a4fb91b663c186294e (commit)
from b26c2a18630538ee515f8e383293efd2c2928c70 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 16399fd2363ff4bacd2ab4ffe042d211a10e071d
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Wed Sep 11 08:57:42 2019 +0100
Bug 20691: DBRev 19.06.00.026
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 81b2e7f4cbe7f1d2d178ef80048deac196ed80ac
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Sep 10 15:09:20 2019 -0300
Bug 20691: (QA follow-up) API-related fixes
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 7f8375f009e6d926ec9965ad2cbd8be1f35dd194
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Sep 10 15:01:34 2019 -0300
Bug 20691: (QA follow-up) Fix atomic update
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 27a165363261741ecf5c10187a572f1278be0a17
Author: Agustin Moyano <agustinmoyano at theke.io>
Date: Thu May 23 00:15:47 2019 -0300
Bug 20691: (follow-up) Fix qa fails
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 5583a0a42c193b4992b3550e4d26bae0ae2630e7
Author: Kyle M Hall <kyle at bywatetsolutions.com>
Date: Wed May 22 03:20:13 2019 -0300
Bug 20691: Implement fines view
This patch implements the logic to show guarantee's fines with guarantor user.
To test:
1) Apply (if not already done) steps 1 to 5 of previous patch
2) Apply this patch
3) Set OPACFinesTab and AllowStaffToSetFinesVisibilityForGuarantor preference to "Allow"
4) Find a guarantee and in accounting create a manual invoice
5) Enter OPAC with guarantor user
CHECK => In summary there is no "Relatives fines" tab
6) On intranet edit guarantee and set "Show fines to guarantors" to "Yes" and save
7) Reload guarantor's OPAC
SUCCESS => You see a "Relatives fines" tab with guarantee's fines information
8) Sign off
Signed-off-by: Agustin Moyano <agustinmoyano at theke.io>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 1ad03f5509ea287c7402c64577595a9c8cd60dfb
Author: Kyle M Hall <kyle at bywatetsolutions.com>
Date: Wed May 22 02:41:24 2019 -0300
Bug 20691: Add ability to turn feature on and off
This patch adds two preferences
1. AllowPatronToSetFinesVisibilityForGuarantor: Allow/Don't allow patrons to choose their own privacy settings for showing the patron's fines to the patron's guarantor
2. AllowStaffToSetFinesVisibilityForGuarantor: Allow/Don't allow staff to set the ability for a patron's fines to be viewed by linked patrons in the OPAC
Also adds a tinyint, non nullable, default to 0 column in borrower and deletedborrower named privacy_guarantor_fines.
1. privacy_guarantor_fines = 0 => don't allow guarantor to see guarantee's fines
2. privacy_guarantor_fines = 1 => allow guarantor to see guarantee's fines
To test:
1) git reset --hard master
2) apply patches (including dependencies)
3) perl installer/data/mysql/updatedatabase.pl
4) dbic
5) restart_all
6) in intranet search for AllowPatronToSetFinesVisibilityForGuarantor and AllowStaffToSetFinesVisibilityForGuarantor preferences
SUCCESS => both preferences should be present
7) search for a patron with guarantor
SUCCESS => in details tab, in "Library use" section you should see a row labeled "Show fines to guarantor"
8) edit
CHECK => in Guarantor information there is no "Show fines to guarantor" select
9) set AllowStaffToSetFinesVisibilityForGuarantor preference to "Allow"
10) return to patron with guarantor and edit
SUCCESS => in Guarantor information section there is a "Show fines to guarantor" select
11) change "Show fines to guarantor" select to "Yes" and save
SUCCESS => Value is saved
12) go to details tab
SUCCESS => in "Library use" section you see a row labeled "Show fines to guarantor" with value "Yes"
13) set OPACPrivacy preference to "Allow"
14) open 2 opacs, one with a patron that has a guarantor and another that hasn't and go to "your privacy" tab.
CHECK => in both opacs you should not see a "Allow your guarantor to view your current fines?" select
15) in intranet set AllowPatronToSetFinesVisibilityForGuarantor to "Allow"
16) refresh both opacs
SUCCESS => in Patron that has guarantor you see a "Allow your guarantor to view your current fines?" select
=> in Patron without guarantor you don't see a "Allow your guarantor to view your current fines?" select
17) in Patron with guarantor change value of select and save
SUCCESS => Value is saved
18) in intranet set OPACPrivacy preference to "Don't allow" and AllowPatronToSetFinesVisibilityForGuarantor to "Don't allow"
19) got to "your personal details" in both opacs
CHECK => in both opacs you should not see no Privacy section with a "Allow your guarantor to view your current fines?" select
20) in intranet set AllowPatronToSetFinesVisibilityForGuarantor to "Allow"
21) refresh both opacs
SUCCESS => in Patron that has guarantor you see a "Allow your guarantor to view your current fines?" select in a Privacy section
=> in Patron without guarantor there is no Privacy section
22) in Patron with guarantor change value of select and update
SUCCESS => Value is saved
23) Sign off
Signed-off-by: Agustin Moyano <agustinmoyano at theke.io>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 9519c92f736c7acacafc19a4fb91b663c186294e
Author: Kyle M Hall <kyle at bywatetsolutions.com>
Date: Tue May 1 13:03:32 2018 -0400
Bug 20691: Database update
Signed-off-by: Agustin Moyano <agustinmoyano at theke.io>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
-----------------------------------------------------------------------
Summary of changes:
Koha.pm | 2 +-
Koha/Schema/Result/Borrower.pm | 17 +++--
Koha/Schema/Result/Deletedborrower.pm | 12 +++-
api/v1/swagger/definitions/patron.json | 4 ++
installer/data/mysql/kohastructure.sql | 2 +
installer/data/mysql/sysprefs.sql | 2 +
installer/data/mysql/updatedatabase.pl | 32 +++++++++
.../prog/en/modules/admin/preferences/opac.pref | 7 ++
.../prog/en/modules/admin/preferences/patrons.pref | 6 ++
.../prog/en/modules/members/memberentrygen.tt | 15 ++++
.../prog/en/modules/members/moremember.tt | 11 ++-
.../bootstrap/en/includes/account-table.inc | 40 +++++++++++
.../bootstrap/en/modules/opac-memberentry.tt | 72 ++++++++++++++++----
.../opac-tmpl/bootstrap/en/modules/opac-privacy.tt | 36 +++++++---
.../opac-tmpl/bootstrap/en/modules/opac-user.tt | 21 ++++++
opac/opac-account.pl | 28 ++++++++
opac/opac-memberentry.pl | 4 +-
opac/opac-privacy.pl | 5 +-
opac/opac-user.pl | 13 ++++
...ckouts_to_relatives => show_fines_to_relatives} | 17 +++--
20 files changed, 303 insertions(+), 43 deletions(-)
copy opac/svc/patron/{show_checkouts_to_relatives => show_fines_to_relatives} (74%)
mode change 100755 => 100644
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list