[koha-commits] main Koha release repository branch 19.05.x updated. v19.05.03-66-g1a16ac1

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.05.x has been updated
       via  1a16ac1b7df407e2456e8692a0aca512a61cbf2b (commit)
       via  0c64cce2e07bad0c1a690bf47106e11dc69d3687 (commit)
       via  550d53d26dff6632bc6248aefdb097cca33a4f7a (commit)
       via  aee8bd9651741b629f32769f4eacd143f50d7267 (commit)
       via  93b8ea9685ab565018fee3caa021f10a99586830 (commit)
      from  ad787464c913339dacbda41d4cc1a259ac21e53c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 1a16ac1b7df407e2456e8692a0aca512a61cbf2b
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Sep 6 15:51:26 2019 -0300

    Bug 23404: (QA follow-up) Minor fix
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit cb432e7f522f2f052d561dad3b36bc97ca7868a4)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 0c64cce2e07bad0c1a690bf47106e11dc69d3687
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Wed Jul 31 10:59:37 2019 +0200

    Bug 23404: Change UT calls
    
    Run prove t/db_dependent/Circulation/TooMany.t
    Tests are OK
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit e98af5828a56b52426ae7aa12d1c85e4f9fb41d2)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 550d53d26dff6632bc6248aefdb097cca33a4f7a
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Wed Jul 31 15:56:22 2019 +0200

    Bug 23404: fix Circulation::TooMany error on itemtype when at biblio level
    
    Circulation::TooMany gets itemtype from $item var beeing a Koha::Item unblessed.
    When itemtype is at biblio level, calling $item->{'itemtype'} is wrong.
    
    Test plan :
    1) On a catalog with itemtype at item level : pref item-level_itypes=1
    2) Create a biblio record with itemtype BOOK
    3) Create an item on this biblio record with itemtype BOOK
    4) Delete all issuing rules
    5) Create a issuing rule with itemtype BOOK, any catagorie, any branch
    6) Check-out the item
    7) => Checkout is allowed
    8) Check-in item
    9) Change itemtype at biblio level : pref item-level_itypes=0
    10) Check-out the item
    11) => Checkout is not allowed
        You see message "No circulation rule is defined for this patron and itemtype combination"
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 9e1fa801d6f1ff718d8689c855483b8b9c735a9f)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit aee8bd9651741b629f32769f4eacd143f50d7267
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Wed Jul 31 11:21:14 2019 +0200

    Bug 23404: add UT to show bug
    
    Run prove t/db_dependent/Circulation/TooMany.t
    It fails on :
        #   Failed test 'We are only allowed one, and we have one (itemtype on biblioitem)'
        #   at t/db_dependent/Circulation/TooMany.t line 547.
        #     Structures begin differing at:
        #          $got->{reason} = 'NO_RULE_DEFINED'
        #     $expected->{reason} = 'TOO_MANY_CHECKOUTS'
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 445b0cb8b595136afdebaee2db3bc768b42b445b)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 93b8ea9685ab565018fee3caa021f10a99586830
Author: Caroline Cyr La Rose <caroline at inlibro.com>
Date:   Fri Aug 16 14:28:59 2019 -0400

    Bug 23353: ACQ framework makes fr-CA web installer explode
    
    This patch removes the standalone ACQ framework SQL file in the fr-CA
    directory and adds the ACQ framework creation SQL in the default
    framework file, as it is in other languages.
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 811bee9bce57e67fd22562b3bb62397335b4eeb5)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Circulation.pm                                  |   13 +--
 .../obligatoire/marc21_framework_DEFAULT.sql       |   56 +++++++++++
 .../obligatoire/marc21_sample_acq_framework.sql    |   56 -----------
 .../obligatoire/marc21_sample_acq_framework.txt    |    1 -
 t/db_dependent/Circulation/TooMany.t               |  106 +++++++++++---------
 5 files changed, 122 insertions(+), 110 deletions(-)
 delete mode 100644 installer/data/mysql/fr-CA/marcflavour/marc21/obligatoire/marc21_sample_acq_framework.sql
 delete mode 100644 installer/data/mysql/fr-CA/marcflavour/marc21/obligatoire/marc21_sample_acq_framework.txt


hooks/post-receive
-- 
main Koha release repository