[koha-commits] main Koha release repository branch 18.11.x updated. v18.11.09-45-gf8c8d6d

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.11.x has been updated
       via  f8c8d6df0a571fd1e604e0cd03f47c512dca0d00 (commit)
      from  371eb680acde7273f5b0ed4335f0c1c0515c694c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit f8c8d6df0a571fd1e604e0cd03f47c512dca0d00
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Sat Jun 22 19:29:42 2019 -0500

    Bug 22786: Prevent fund creation for locked budgets
    
    If a budget is locked, there is a "New fund for $budget" link that is
    disabled but clickable.
    We should ensure that the link is not clickable and prevent it at
    controller level (do we need it at module level, ie.
    Koha::Acquisition::Fund->store?)
    
    Test plan:
    - Create a budget, lock it
    - Go to /cgi-bin/koha/admin/aqbudgetperiods.pl
    - Click on the name of the budget you just created
    => The "New > New fund for $budget_name" button should be disabled
    - Click it anyway
    => Without this patch the form to add a new fund is displayed
    => With this patch applied nothing happens
    - Hit /cgi-bin/koha/admin/aqbudgets.pl?op=add_form&budget_period_id=XXX
    With XXX the budget's id
    => Without this patch the form is displayed
    => With this patch applied you get a message:
      "The budget is locked, fund creation is not possible."
    And you are not able to create a new fund
    
    QA notes:
    1. See description
    2. The add_validate op can still be forced, let trust librarians with
    administration permissions for now.
    
    Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 9215ca42d28bec10f55a9c660bb5816045bb9656)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
    (cherry picked from commit 8d5a50384fb65a508b0cf944e6f6c070df888aaf)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 admin/aqbudgets.pl                                                |    2 ++
 koha-tmpl/intranet-tmpl/prog/en/includes/blocking_errors.inc      |    2 ++
 .../intranet-tmpl/prog/en/includes/budgets-admin-toolbar.inc      |    5 ++++-
 3 files changed, 8 insertions(+), 1 deletion(-)


hooks/post-receive
-- 
main Koha release repository