From gitmaster at git.koha-community.org Wed Apr 1 00:45:12 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 31 Mar 2020 22:45:12 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.04-8-g96e6362ab7 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 96e6362ab721621dd7e24d6f8a56d168e2a9b497 (commit) via 68488f40558d66b7e4e444c1ed57a260b33ee034 (commit) from 9b0ba1c096ed72bd867792a11de59a825355e6dc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 96e6362ab721621dd7e24d6f8a56d168e2a9b497 Author: Marcel de Rooy Date: Fri Mar 20 10:12:24 2020 +0000 Bug 24809: (QA follow-up) Add prefix to prevent disambiguity This seems not to be needed. Just at the safe side. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 68488f40558d66b7e4e444c1ed57a260b33ee034 Author: Nick Clemens Date: Thu Mar 5 10:59:22 2020 +0000 Bug 24809: Get only timestamp of deleted items attached to existing bibs when check if bib deleted To test: 1 - Edit/create a file in the koha home dir '/var/lib/koha/{instance}/OAI.yaml' with content like below: format: marcxml: metadataPrefix: marcxml metadataNamespace: http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim schema: http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd include_items: 1 2 - Set the systempreferences below to indicated values: OAI-PMH => Enable OAI-PMH:ConfFile => /var/lib/koha/{instace}/OAI.yaml 3 - View a record with items and confirm the items show: http://localhost:8080/cgi-bin/koha/oai.pl?verb=GetRecord&metadataPrefix=marcxml&identifier=KOHA-OAI-TEST:4 4 - Delete the items, then delete the record 5 - Reload the URL from step 3 6 - Internal Server Error: Empty String at /kohadevbox/koha/Koha/OAI/Server/Record.pm line 58. at /usr/share/perl/5.24/Carp.pm line 167 7 - Apply patch 8 - restart_all 9 - Repeat 10 - Reload URL from step 3 11 - Success Signed-off-by: Michal Denar Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: Koha/OAI/Server/GetRecord.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Apr 1 00:50:49 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 31 Mar 2020 22:50:49 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.04-12-g9056d53e32 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 9056d53e32667ae997516a00586c02f567cb948a (commit) via dec127df2ab986ed555f7a2cadc94491abecfbfe (commit) via 6298eafa642529283ed82f72638bb434762a2c15 (commit) via e3cffae41f82fb22100bcf269696107cb102660e (commit) from 96e6362ab721621dd7e24d6f8a56d168e2a9b497 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9056d53e32667ae997516a00586c02f567cb948a Author: Marcel de Rooy Date: Tue Feb 25 13:40:52 2020 +0000 Bug 24294: (QA follow-up) Add rollback and 008 default test Default for 008 was not tested yet. Only wondering if we should insert default values only when we meet an undefined value. Or should we also add if we meet an empty string? Is the latter not more realistic in MARC? Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit dec127df2ab986ed555f7a2cadc94491abecfbfe Author: Jonathan Druart Date: Thu Jan 2 12:09:27 2020 +0100 Bug 24294: Add default value support for control fields in ACQ framework When trying to add an order using the ACQ framework with a 008@ tag, Koha explodes: Control fields (generally, just tags below 010) do not have subfields, use data() at /home/vagrant/kohaclone/C4/Acquisition.pm line 3272. Test plan: Set a default value for a control field in the ACQ framework Turn on UseACQFrameworkForBiblioRecords Create a new order from a new record The default value should be displayed Save => No crash Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 6298eafa642529283ed82f72638bb434762a2c15 Author: Katrin Fischer Date: Sun Feb 23 21:25:00 2020 +0000 Bug 24605: (QA follow-up) Fix unencoded series link in staff interface Same change as the first patch, but for the staff detail page. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit e3cffae41f82fb22100bcf269696107cb102660e Author: Nick Clemens Date: Thu Feb 6 17:45:07 2020 +0000 Bug 24605: Fix unencoded series link To test: 1 - Add an 830 to a record with a volume subfield separated by a semicolon 830$aThe series ;$vvol 8. 2 - View the record in the opac 3 - Click the series link, no results 4 - View the link url - the semicolon is not encoded 5 - Apply patch 6 - link works 7 - URL is corrrectly encoded Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: C4/Acquisition.pm | 24 ++++++++++++++++------ .../prog/en/xslt/MARC21slim2intranetDetail.xsl | 2 +- .../bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 2 +- t/db_dependent/Acquisition/FillWithDefaultValues.t | 18 +++++++++++++++- 4 files changed, 37 insertions(+), 9 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Apr 1 16:22:36 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 01 Apr 2020 14:22:36 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.04-13-ga0808619e8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via a0808619e86f9902546bc9d221db4c33567f2fac (commit) from 9056d53e32667ae997516a00586c02f567cb948a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a0808619e86f9902546bc9d221db4c33567f2fac Author: Nick Clemens Date: Tue Feb 25 18:51:41 2020 +0000 Bug 24732: Set DumpTemplateVars Dumper options for Indent and Sort To test: 1 - Enable sysprefs DumpTemplateVarsOpac DumpTemplateVarsIntranet 2 - View some pages on staff client and opac 3 - View the page source 4 - See a large mass of comments including the page vars at the top of the source 5 - Refresh page and note order of vars changes 6 - Apply patch 7 - View page source on some pages and note things are much easier to read 8 - Refresh page and note variable order does not change Signed-off-by: George Williams Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-open.inc | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-open.inc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Apr 1 18:03:32 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 01 Apr 2020 16:03:32 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.04-16-g4154a7fbbc Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 4154a7fbbcdbe9973251185e38f2a2038a08a705 (commit) via be7e2880c35be387a09dd6413eefaf04dadb7dc7 (commit) via 484ce7d8bdd2ca25e8e85118276f617ce9cf1e1d (commit) from a0808619e86f9902546bc9d221db4c33567f2fac (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4154a7fbbcdbe9973251185e38f2a2038a08a705 Author: Joy Nelson Date: Wed Apr 1 15:35:46 2020 +0000 Bug 24103: DBRev 19.11.04.001 Signed-off-by: Joy Nelson commit be7e2880c35be387a09dd6413eefaf04dadb7dc7 Author: Nick Clemens Date: Fri Feb 14 11:34:46 2020 +0000 Bug 24103: (follow-up) Dump query on opac authorities search Signed-off-by: Owen Leonard Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 484ce7d8bdd2ca25e8e85118276f617ce9cf1e1d Author: Nick Clemens Date: Mon Nov 25 14:58:00 2019 +0000 Bug 24103: Add option to dump search query to templates To test: 1 - Apply patch, update database 2 - Note new syspref 'DumpSearchQueryTemplate' 3 - Leave it off 4 - Enable DumpTemplateVariablesOpac and Staff 5 - Search on staff and opac 6 - View the source 7 - Search for 'search_query' - you shouldn't find it 8 - Enable the new pref 9 - Repeat, but you should find the query 10 - Test staff/opac search and advanced search, cataloguing search, authority search, authfinder search, adding to a basket form a new biblio 11 - All should work and show the query 12 - This will work under both ES and Zebra Signed-off-by: Owen Leonard Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- authorities/auth_finder.pl | 1 + authorities/authorities-home.pl | 1 + catalogue/search.pl | 2 ++ cataloguing/addbooks.pl | 3 +++ installer/data/mysql/sysprefs.sql | 1 + installer/data/mysql/updatedatabase.pl | 10 ++++++++++ .../intranet-tmpl/prog/en/modules/admin/preferences/logs.pref | 6 ++++++ opac/opac-authorities-home.pl | 1 + opac/opac-search.pl | 2 ++ 10 files changed, 28 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Apr 1 21:29:10 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 01 Apr 2020 19:29:10 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.04-18-ge41f2c9824 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via e41f2c9824a150d293cffd62de3e3c32d8bc809e (commit) via 8c8053d9e7df577340f2a8112478dfd35530da54 (commit) from 4154a7fbbcdbe9973251185e38f2a2038a08a705 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e41f2c9824a150d293cffd62de3e3c32d8bc809e Author: Kyle M Hall Date: Fri Feb 21 09:41:27 2020 -0500 Bug 24705: Holds placed via SIP will be given first priority The SIP server does not calculate and pass a priority to AddReserve, which causes the hold to be given priority 1. Test Plan: 1) Place a hold via SIP for a record with existing holds 2) Note the new hold is top priority 3) Apply this patch 4) Restart SIP 5) Repeat step 1 6) New hold should be last priority Signed-off-by: Christofer Zorn Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 8c8053d9e7df577340f2a8112478dfd35530da54 Author: Jonathan Druart Date: Mon Feb 24 10:40:54 2020 +0100 Bug 24705: Add tests Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: C4/SIP/ILS/Transaction/Hold.pm | 3 +- t/db_dependent/SIP/Transaction.t | 62 +++++++++++++++++++++++++++++++++++++++- 2 files changed, 63 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Apr 1 22:36:56 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 01 Apr 2020 20:36:56 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.04-20-g789866e585 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 789866e585be0a5c439559383325cbe4db525412 (commit) via f9f7b5cc80eb84309dd1ff667e3166e0e8634ef4 (commit) from e41f2c9824a150d293cffd62de3e3c32d8bc809e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 789866e585be0a5c439559383325cbe4db525412 Author: Nick Clemens Date: Wed Feb 26 03:16:26 2020 +0000 Bug 24733: created_by param should be an arrayref We allow for the user to add multiple users to this field, and the search function expects and array. We have been treating it as a scalar TO test: 1 - Have an open basket in acquisitions 2 - Add to basket - from an existing order (copy) 3 - Enter a name in the 'Basket created by' field and select a user 4 - Hit search 5 - ISE (Can't use string ("1") as an ARRAY ref while "strict refs" in use at /usr/share/koha/lib/C4/Acquisition.pm line 2482.) 6 - Apply patch 7 - Repeat 1-4 8 - Success! 9 - Test with mutiple 'created by' entries as well Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit f9f7b5cc80eb84309dd1ff667e3166e0e8634ef4 Author: Nazlı Çetin Date: Fri Feb 21 14:33:42 2020 +0000 Bug 21879: Code cleaning in printinvoice.pl Coming from commit 51aa6db46c604aa202a3d8f8e5028557480efbd5 Bug 12001: Move GetMemberAccountRecords to the Koha namespace Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: acqui/duplicate_orders.pl | 3 ++- members/printinvoice.pl | 12 ------------ 2 files changed, 2 insertions(+), 13 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Apr 1 22:57:46 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 01 Apr 2020 20:57:46 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.04-26-gc78e180c56 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via c78e180c56691ed50472ec87b780135f78992868 (commit) via 99b12c3a98e97e12a1f3a69d0e3719701b031d42 (commit) via 84026f258909e1203f34793a1089388cd933d1c9 (commit) via 06c7de991ef72297fad75097f377889dc4438652 (commit) via e145be8b6d8f36f5be968648606147775ecfaa59 (commit) via 175640e0a89cbc0267a41ecc5e8b5b83ba33ae7a (commit) from 789866e585be0a5c439559383325cbe4db525412 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c78e180c56691ed50472ec87b780135f78992868 Author: Katrin Fischer Date: Sat Feb 29 10:49:46 2020 +0100 Bug 24736: (QA follow-up) Change tooltip wording Suggesting a change of the tooltip wording to read: There are no enrollments for this club yet Signed-off-by: Martin Renvoize commit 99b12c3a98e97e12a1f3a69d0e3719701b031d42 Author: Jonathan Druart Date: Wed Feb 26 17:46:49 2020 +0100 Bug 24736: Disable "Enrollments" link if nobody enrolled to the club yet The link is disabled but it's possible to click and access the page anyway. Test plan: - Create a new club template - Create a new club - Click the Actions > Enrollments link => Without this patch you can access the page => With this patch applied you cannot, and a tooltip explains why (feel free to suggest another wording) - Add a new patron to this club (from /cgi-bin/koha/opac-user.pl#opac-user-clubs) - Notice that the action link is not enabled and click takes you to the list of enrollments Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 84026f258909e1203f34793a1089388cd933d1c9 Author: Andrew Fuerste-Henry Date: Thu Feb 27 14:09:02 2020 -0600 Bug 24747: Corrects on-screen instructions in branch transfer limits To test: 1- go to cgi-bin/koha/admin/branch_transfer_limits.pl 2- see wording "Check the boxes for the libraries you accept to checkin items from" 3- apply patch 4- see wording "Check the boxes for the libraries you allow your items to be transferred to" To verify new wording accuractely describes behavior: 1- Set UseBranchTransferLimits set to Enforce using itemtype 2- Confirm circ rules allow holds 3- Confirm hold policy by item type allows holds 4- Confirm all branches are valid pickup locations in branch setup 5- In Branch Transfer Limits, set dropdown to Branch A, select itemtype Book, disable all transfers so Branch A does not accept books from any other branch 6- Find a patron from Branch A 7- Find a book from Branch B 8- On the intranet, successfully place hold on item for patron for pickup at branch A 9- Cancel hold 10- Log into opac as patron 11- Successfully place hold on item for pickup at Branch A 12- Cancel hold 13- In Branch Transfer Limits, set dropdown to Branch A, select itemtype Book, ENABLE all transfers so Branch A DOES accept books from any other branch 14- In Branch Transfer Limits, set dropdown to Branch B, select itemtype Book, disable all transfers so Branch B does not accept books from any other branch 15- On the intranet, try to place a hold on item for patron, confirm Branch B is your only pickup option 16- On the OPAC, log in as patron, try to place a hold on item, confirm Branch B is your only pickup option Signed-off-by: Kelly McElligott Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 06c7de991ef72297fad75097f377889dc4438652 Author: David Cook Date: Fri Feb 28 00:17:58 2020 +0000 Bug 24739: Perform IPv6 tests only if Net::Netmask is correct version Test plan: 0. Apply patch 1. Set up Koha on stretch (e.g. koha/koha-testing:master) 2. perl t/Koha/Middlware/RealIP.t 3. Observe the following: Subtest: IPv6 support ok 1 - Warn on IPv6 koha_trusted_proxies ok 2 - Unable to parse IPv6 address for trusted proxy, so ignore the X-Forwarded-For header 1..2 ok 13 - IPv6 support 4. Set up Koha on buster (e.g. koha/koha-testing:master-buster) 5. perl t/Koha/Middlware/RealIP.t 6. Observe the following: Subtest: IPv6 support ok 1 - Trust proxy (2001:db8:1234:5678:abcd:1234:abcd:1234) using IPv6 CIDR notation, so use the X-Forwarded-For header for the remote address 1..1 ok 13 - IPv6 support Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit e145be8b6d8f36f5be968648606147775ecfaa59 Author: Martin Renvoize Date: Thu Feb 27 09:16:12 2020 +0000 Bug 24739: Skip tests when IPv6 support is found Signed-off-by: David Cook Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit 175640e0a89cbc0267a41ecc5e8b5b83ba33ae7a Author: David Cook Date: Fri Feb 28 00:28:02 2020 +0000 Bug 24753: Change Koha/Middlware to Koha/Middleware in test name Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/includes/clubs-table.inc | 4 +-- .../en/modules/admin/branch_transfer_limits.tt | 2 +- t/Koha/{Middlware => Middleware}/RealIP.t | 39 +++++++++++++++++----- 3 files changed, 34 insertions(+), 11 deletions(-) rename t/Koha/{Middlware => Middleware}/RealIP.t (74%) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Apr 1 23:09:17 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 01 Apr 2020 21:09:17 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.04-29-gc0422998f8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via c0422998f89daf82eb898ddb951d46df97a6f1e4 (commit) via 5811331a5a07b84c39de7485fd2d21df7d45be34 (commit) via 4516a3ead6577131cc8087527a6d0c42158597f8 (commit) from c78e180c56691ed50472ec87b780135f78992868 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c0422998f89daf82eb898ddb951d46df97a6f1e4 Author: David Cook Date: Mon Jan 13 17:05:17 2020 +1100 Bug 17464: Order deny,allow / Deny from all was deprecated in Apache 2.4 and is now a hard error Patch change Apache access control from 2.2 to 2.4 directives. Test plan: 0. Apply patch 1. Build Koha from source 2. Copy or symlink koha-dev/etc/koha-httpd.conf into your relevant Apache directory. 3. Reload Apache 4. Note a lack of syntax errors regarding the "Order" directive Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 5811331a5a07b84c39de7485fd2d21df7d45be34 Author: Maryse Simard Date: Wed Aug 21 17:20:16 2019 -0400 Bug 23488: Line wrapping doesn't always respect word order in Patron card creator When wrapping long lines of text, the line is divided by removing each word from the end of the line and putting it in a new one until the line is the right width. When the word to be removed appears multiple time in the line, it is not the last occurrence that is removed. This patch changes the regular expression used to remove the part of the text that is wrapped to a new line, making sure it removes it at the end of the text. Test plan: 1. Go to Tools > Patron card creator 2. Have a card template and a card batch -> If needs be, you can create them by using New > Card template or New > Card batch 3. Create a layout and use one text field containing a long text with at least one word which is repeated a minimum of 2 times (preferably towrdds the end of the text, since it has to be picked as one of the words to appear in the new line). You can use this: one two three one two three one two three one two three one two three one two three one two three one two three ... 4. Go to Manage > Card batches and export a batch 5. Choose the layout set up in 3. 6. Click the Export button and open the resulting pdf file 7. Notice all the repeated word have been grouped -> For this example : all of the ones appear first, followed by all the twos and only then the threes. 8. Apply patch 9. Repeat step 4 through 7 => this time the order of the words has not changed! Signed-off-by: Gabriel DeCarufel Signed-off-by: William Frazilien Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 4516a3ead6577131cc8087527a6d0c42158597f8 Author: Owen Leonard Date: Fri Feb 28 16:48:37 2020 +0000 Bug 23753: Add missing humanMsg library to pages using background job JavaScript The JavaScript used to process background uploads calls the humanMsg library under some circumstances. There are several templates which use background-job-progressbar.js which don't include the humanMsg assets. This patch corrects those templates. Note: upload-images.tt has been modified to remove the inclusion of background-job-progressbar.js because it was unused. To test, apply the patch and test the following processes which include background job processing: - Batch item modification -- the background job is triggered when you submit your changes - Batch record modification -- the background job is triggered when you submit your changes - Stage MARC for import -- the background job is triggered when you click the "Sage for import" button after uploading a file - Staged MARC management -- the background job is triggered when you click "Import this batch into the catalog" In each case the process should complete correctly. If you would like to test the error message handling provided by the humanMsg library you can deliberately introduce an error into the JavaScript. After applying the patch you can modify js/background-job-progressbar.js to alter line 63 from: url: f.action, ...to: url: f.action + "foo", Perform the same tests and confirm that you see an error message. Don't forget to undo your changes to background-job-progressbar.js before signing off. Signed-off-by: Maryse Simard Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: C4/Patroncards/Patroncard.pm | 2 +- etc/koha-httpd.conf | 6 ++---- koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt | 3 ++- .../prog/en/modules/tools/batch_record_modification.tt | 2 ++ koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt | 2 ++ koha-tmpl/intranet-tmpl/prog/en/modules/tools/stage-marc-import.tt | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/tools/upload-images.tt | 1 - 7 files changed, 10 insertions(+), 8 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Apr 1 23:20:11 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 01 Apr 2020 21:20:11 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.04-34-g8386f5f5e8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 8386f5f5e828565457ea4421773b0d0fe5168483 (commit) via 21d9aa62a3f79ac594e2b92f0dcb644a7cf11ff8 (commit) via 116abbc530dfffe66a55f39508aa5378a4118d18 (commit) via 06235e20eea8a8e619e6192edb0a8808297716ef (commit) via 74c8c459e3e032bd35125c620fc25cae2201abbd (commit) from c0422998f89daf82eb898ddb951d46df97a6f1e4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8386f5f5e828565457ea4421773b0d0fe5168483 Author: Joy Nelson Date: Wed Apr 1 20:52:41 2020 +0000 Bug 22273: DBRev 19.11.04.002 Signed-off-by: Joy Nelson commit 21d9aa62a3f79ac594e2b92f0dcb644a7cf11ff8 Author: Joy Nelson Date: Wed Apr 1 20:50:17 2020 +0000 Bug 22273: DBRev 19.11.04.002 Signed-off-by: Joy Nelson commit 116abbc530dfffe66a55f39508aa5378a4118d18 Author: Marcel de Rooy Date: Wed Dec 18 13:49:59 2019 +0000 Bug 22273: Modify Koha::ArticleRequest->store to fill created_on For a new record, store should fill created_on. The database will always update the timestamp updated_on. Since open also calls SUPER::store, we do not need to call it twice. Test plan: [1] Run t/db_dependent/ArticleRequests.t [2] In the interface, add two article requests. Change the status of one to PROCESSING. Check created_on and updated_on in the article_requests table. The changed request should have updated_on > created_on. Signed-off-by: Bernardo Gonzalez Kriegel [1] Tests pass ok 12 - New article request has created_on date set ok 13 - New article request has updated_on date set [2] Work as described. No errors Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 06235e20eea8a8e619e6192edb0a8808297716ef Author: Marcel de Rooy Date: Wed Dec 18 14:35:50 2019 +0000 Bug 22273: Database revision for table article_requests Column created_on should not be updated. It is filled once by the store method of Koha::ArticleRequest. Column updated_on should be a timestamp, updated by the database. Note: Although higher versions of MySQL and MariaDB support two timestamps (NOT NULL) in one table, I kept on the safe side by allowing NULL on the created_on column. @RM: Don't forget to run DBIx update. Test plan: Run new install or upgrade. Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 74c8c459e3e032bd35125c620fc25cae2201abbd Author: Marcel de Rooy Date: Wed Dec 18 13:39:57 2019 +0000 Bug 22273: Replace typo opan by opac in POD Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- Koha/ArticleRequest.pm | 17 ++++++----------- installer/data/mysql/kohastructure.sql | 4 ++-- installer/data/mysql/updatedatabase.pl | 9 +++++++++ t/db_dependent/ArticleRequests.t | 5 +++-- 5 files changed, 21 insertions(+), 16 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Apr 1 23:46:07 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 01 Apr 2020 21:46:07 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.04-35-g5d22e0b3a3 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 5d22e0b3a331e35b8f1e494bc366c1624c982cf8 (commit) from 8386f5f5e828565457ea4421773b0d0fe5168483 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5d22e0b3a331e35b8f1e494bc366c1624c982cf8 Author: Jonathan Druart Date: Thu Feb 13 12:03:36 2020 +0100 Bug 17532: Make koha-shell propagate the error code Context: I am trying to make koha-misc4dev stop when something wrong happens. Basically we do not want the process to continue of the DB has not been populated correctly. It will make the errors easier to catch. The issue: Say a script that will return an error (die in perl for an easy example), koha-shell will not return the 255 error code, but 0 instead. The caller cannot know something wrong happened The solution is to propagate the error and make koha-shell return the same error code as the command it executed An example: === t.pl === die('something wrong'); % perl t.pl;echo $? something wrong at t.pl line 1. 255 % sudo koha-shell kohadev -p -c 'perl xxx.pl' ; echo $? something wrong at xxx.pl line 1. 0 Signed-off-by: Tomas Cohen Arazi Tested it with $ sudo debian/scripts/koha-shell kohadev -c 'exit 8' $ echo $? 8 The unpatched version returns 0 (forgets about the error code). Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: debian/scripts/koha-shell | 2 ++ 1 file changed, 2 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Apr 2 00:50:37 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 01 Apr 2020 22:50:37 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.04-40-g5bf9a83495 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 5bf9a83495971a196224f9342394a5b2d065d3e1 (commit) via 1fbd4468642aa09b999b3baf014b6f3a0afd6df8 (commit) via d09da7444c90ec4d80757a7d2c72be643d1a9f70 (commit) via 74e3ef126c5992ac049a35c75a7d3879669d7a49 (commit) via a3143506b2edf7ffca185e650c18b89dc249423f (commit) from 5d22e0b3a331e35b8f1e494bc366c1624c982cf8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5bf9a83495971a196224f9342394a5b2d065d3e1 Author: Fridolin Somers Date: Thu May 23 07:55:15 2019 +0200 Bug 22969: fix biblionumber on 001 in UNIMARC XSLT In UNIMARC default configuration the 001 is linked to biblio.biblionumber. In some XSLT files, 090$a is used. This is by default biblioitems.biblionumber so it usually works but it may not be the same and var biblionumber is used to create hyperlinks to record detail page. Test plan : 1) Use UNIMARC database 2) Set default in all XSLT system preferences 3) At OPAC, perform a search and click on a result 4) Check displayed page shows the correct biblio record 5) Same at intranet Signed-off-by: Bernardo Gonzalez Kriegel Tested on clean UNIMARC install. Before insert new records: "alter table biblioitems AUTO_INCREMENT = 5" Added two records, with result: +--------------+------------------+ | biblionumber | biblioitemnumber | +--------------+------------------+ | 1 | 5 | | 2 | 6 | +--------------+------------------+ Without patch, OPAC results shows for first record http://opac/cgi-bin/koha/opac-detail.pl?biblionumber=5, Wrong! with patch result is correct Works, no errors Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 1fbd4468642aa09b999b3baf014b6f3a0afd6df8 Author: Owen Leonard Date: Wed Mar 4 18:29:24 2020 +0000 Bug 24798: smart-rules.tt has erroneous comments This patch corrects a couple of invalid Template Toolkit comments in the Circulation and Fines rules template. To test, apply the patch and log into the staff client as an administrator. On the Circulation and Fines Rules page "View source" and look for instances of the text "[#% Default branch %#]" There should be none. Signed-off-by: David Nind Signed-off-by: Marcel de Rooy [EDIT] There is a theoretical difference between [% # and [%#. The latter marks the whole directive as a comment and not just until EOL. Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit d09da7444c90ec4d80757a7d2c72be643d1a9f70 Author: Owen Leonard Date: Wed Mar 4 19:47:26 2020 +0000 Bug 24803: Remove JS error when clicking "Log in to your account" This patch removes the "data-toggle" attribute from the login link in order to avoid a JavaScript error. Since we have a custom click handler to trigger the modal we don't need Bootstrap's "automatic" modal handling. Test plan: 1. Apply patch 2. Open F12 dev tools 3. Click "Log in to your account" on OPAC 4. Observe no Javascript errors in console Signed-off-by: David Cook Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 74e3ef126c5992ac049a35c75a7d3879669d7a49 Author: David Cook Date: Thu Feb 27 00:28:48 2020 +0000 Bug 24719: Remove use of CGI object in C4::Context::set_remote_address() This patch replaces the CGI "http" object method with its equivalent class method, which doesn't require object instantiation and thus skips global initialization and premature handling of the incoming HTTP request. Test plan: 0. Disable Plack if it is enabled 1. Set koha_trusted_proxies in koha-conf.xml to 1.1.1.1 2. Clear Memcached 3. Try to upload MARCXML file to /cgi-bin/koha/tools/stage-marc-import.pl 4. Note that form below "Upload progress" never appears and errors show in browser console 5. Apply the patch 6. Try to upload MARCXML file to /cgi-bin/koha/tools/stage-marc-import.pl 7. Note that form appears below "Upload progress" Signed-off-by: Nick Clemens Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit a3143506b2edf7ffca185e650c18b89dc249423f Author: Julian Maurice Date: Fri Jan 31 11:13:47 2020 +0100 Bug 24552: Be compatible with Search::Elasticsearch 6.00 There is no need to specify the `client` param here because '5_0::Direct' is the default value for Search::Elasticsearch 5.x and it breaks when Search::Elasticsearch 6.x is installed Test plan: 1. Apply the patch 2. Make sure you have Search::Elasticsearch 5.x 3. Reload starman 4. Verify that search works 5. Install Search::Elasticsearch 6.x 6. Reload starman 7. Verify that search works Signed-off-by: Michal Denar Signed-off-by: Ere Maijala Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: C4/Context.pm | 3 +-- Koha/SearchEngine/Elasticsearch.pm | 1 - koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt | 4 ++-- koha-tmpl/intranet-tmpl/prog/en/xslt/UNIMARCslim2intranetDetail.xsl | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslim2OPACDetail.xsl | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslim2OPACResults.xsl | 6 ++---- 7 files changed, 8 insertions(+), 12 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Apr 2 01:10:05 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 01 Apr 2020 23:10:05 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.04-42-g30f12f7dec Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 30f12f7dece8e2f214781df824f45e83b5243c67 (commit) via c405b03dd367adb7c1c274477865a7444f59c9e9 (commit) from 5bf9a83495971a196224f9342394a5b2d065d3e1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 30f12f7dece8e2f214781df824f45e83b5243c67 Author: Kyle M Hall Date: Wed Mar 4 12:08:29 2020 -0500 Bug 24802: Updating holds can cause suspensions to apply to wrong hold On request.pl, the table of holds shows a suspend_until date picker for each hold, *unless* that hold is waiting or in transit. The script reserve/modrequest.pl assumes that there will be a suspend_until input for each hold, but that is incorrect. Assume there are 20 holds on a record, and 10 of them are waiting or in transit. If you were to then set the suspend until date on the 10 open holds, and use the "Update hold(s)" button, those 10 suspensions would apply to the 10 found holds and not the holds they should apply to! Test Plan: 1) Place two holds on a record 2) Check in an item and trap it for the first hold 3) Now that one hold is waiting and the other is not, attempt to set a suspension date using the "Update hold(s)" button 4) Note your hold does not get suspended! 5) Apply this patch 6) Restart all the things! 7) Repeat steps 1-3 8) Your hold should now be suspended! Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit c405b03dd367adb7c1c274477865a7444f59c9e9 Author: Jonathan Druart Date: Thu Mar 5 16:27:15 2020 +0100 Bug 24813: Prevent api/v1/holds.t to fail randomly Hold cannot be suspended if found=W: Koha::Hold->suspend_hold 90 if ( $self->is_found ) { # We can't suspend found holds So when TestBuilder generate a hold with found=W the test fail. A question however: Why did not we have the correct exception displayed somewhere? That would be much more helpful to find the problem! Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc | 4 ++-- reserve/modrequest.pl | 4 ++-- t/db_dependent/api/v1/holds.t | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Apr 2 17:02:41 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 02 Apr 2020 15:02:41 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.04-43-g61e7f3bbd7 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 61e7f3bbd7d6bf8e4341869255d9de8156643d69 (commit) from 30f12f7dece8e2f214781df824f45e83b5243c67 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 61e7f3bbd7d6bf8e4341869255d9de8156643d69 Author: Joy Nelson Date: Thu Apr 2 14:35:51 2020 +0000 DBRev: followup Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Apr 2 18:55:03 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 02 Apr 2020 16:55:03 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.04-47-g00379c1899 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 00379c189976ac9e7e2429f5261a0b562206fc5d (commit) via 390f838d27984ea47572b729145b1268e9866f29 (commit) via c1c3cfed5ca2709b99587e8907b68d158ce013f9 (commit) via 508a6ad027b34c2279fbb1ff994152144b38ceb8 (commit) from 61e7f3bbd7d6bf8e4341869255d9de8156643d69 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 00379c189976ac9e7e2429f5261a0b562206fc5d Author: Jonathan Druart Date: Tue Feb 18 16:13:11 2020 +0100 Bug 23384: Fix use statement order for ArticleRequest::Status Koha::ArticleRequest is used by Koha::ArticleRequests so Koha::ArticleRequest::Status should not be needed in Koha::ArticleRequest. Also Koha::ArticleRequest::Status must be loaded before Koha::ArticleRequest Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 390f838d27984ea47572b729145b1268e9866f29 Author: Marcel de Rooy Date: Fri Mar 6 11:13:15 2020 +0000 Bug 24760: (follow-up) Add a neighboring test messsage Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit c1c3cfed5ca2709b99587e8907b68d158ce013f9 Author: Julian Maurice Date: Fri Feb 28 14:22:34 2020 +0100 Bug 24760: Use C4::BackgroundJob->fetch in tests Starting with YAML 1.30 and YAML::Syck 1.32, these modules don't bless loaded objects by default. This is not a problem as C4::BackgroundJob->fetch bless them anyway. So, instead of testing what's in the session, test the result of C4::BackgroundJob->fetch, which is what's used everywhere else Test plan: 1. Install latest version of YAML::Syck (or YAML if YAML::Syck is not installed) 2. prove t/db_dependent/BackgroundJob.t => should FAIL 3. Apply patch 4. prove t/db_dependent/BackgroundJob.t => should PASS 5. Verify that background jobs are still working (for instance, tools/batchMod.pl) Signed-off-by: Michal Denar Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 508a6ad027b34c2279fbb1ff994152144b38ceb8 Author: David Gustafsson Date: Tue Mar 3 14:32:31 2020 +0100 Bug 24788: Remove autoloaded column accessors in Koha::Object->store Columns are accessed as methods, relying on AUTOLOAD, in Koha::Object->store. This could be a source of strange bugs if a column name clashes with an existing method name. To test: 1) Apply patches for Bug 14957 2) Follow the testing instructions, when saving a new marc rule and error is thrown. 3) Apply patch 4) Try saving a new rule once again, this should now work Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: Koha/ArticleRequest.pm | 1 - Koha/ArticleRequests.pm | 2 +- Koha/Object.pm | 14 ++++++++------ Koha/Patron.pm | 1 + t/db_dependent/BackgroundJob.t | 12 +++++------- 5 files changed, 15 insertions(+), 15 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Apr 2 21:15:15 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 02 Apr 2020 19:15:15 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.04-55-gd6a0b07984 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via d6a0b07984ed63e91723fa484890f111077dbd10 (commit) via a5e723b887fe085ba36527bbf14e4c1d9d30556d (commit) via dd8df39986ebc7c055894fea0148f900ba4a3a45 (commit) via 9ce0f3a73e4de58fb04f4e7977a6299e4b480b5b (commit) via ce96ed4336f99d97c31bc87cfea3369ddfaf0a02 (commit) via f2aeaede38b05cb93146d9fbe86bcd4a2a76b8d5 (commit) via a0a579d773c95ec87a647497cc755b0a4cc7f55f (commit) via 20118bb795ce046c2b00152aeccb94ae998375e6 (commit) from 00379c189976ac9e7e2429f5261a0b562206fc5d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d6a0b07984ed63e91723fa484890f111077dbd10 Author: Jonathan Druart Date: Tue Feb 4 12:09:00 2020 +0100 Bug 19008: Replace issues with checkouts in print statement Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit a5e723b887fe085ba36527bbf14e4c1d9d30556d Author: Magnus Enger Date: Fri Aug 2 13:57:13 2019 +0200 Bug 19008: More database cleanups - QA followup This patch tries to change the POD as suggested in the QA process. Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit dd8df39986ebc7c055894fea0148f900ba4a3a45 Author: Fridolin Somers Date: Fri Jul 28 16:09:14 2017 +0200 Bug 19008: More database cleanups - item transfers misc/cronjobs/cleanup_database.pl provides some database cleanup. Yet some tables that could need cleanup are not in this script. This patch adds cleanup for branchtransfers table. Test plan : - Count : select count(*),datearrived from branchtransfers group by datearrived; - Run cleanup : misc/cronjobs/cleanup_database.pl -v --transfers 30 - Recount Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 9ce0f3a73e4de58fb04f4e7977a6299e4b480b5b Author: Fridolin Somers Date: Fri Jul 28 16:01:51 2017 +0200 Bug 19008: More database cleanups - old reserves misc/cronjobs/cleanup_database.pl provides some database cleanup. Yet some tables that could need cleanup are not in this script. This patch adds cleanup for old_reserves table. Test plan : - Count : select count(*),date(timestamp) from old_reserves group by date(timestamp); - Run cleanup : misc/cronjobs/cleanup_database.pl -v --old-reserves 30 - Recount Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit ce96ed4336f99d97c31bc87cfea3369ddfaf0a02 Author: Fridolin Somers Date: Fri Jul 28 14:57:33 2017 +0200 Bug 19008: More database cleanups - old issues misc/cronjobs/cleanup_database.pl provides some database cleanup. Yet some tables that could need cleanup are not in this script. This patch adds cleanup for old_issues table. Test plan : - Count : select count(*),date(timestamp) from old_issues group by date(timestamp); - Run cleanup : misc/cronjobs/cleanup_database.pl -v --old-issues 30 - Recount Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit f2aeaede38b05cb93146d9fbe86bcd4a2a76b8d5 Author: Fridolin Somers Date: Fri Jul 28 14:43:45 2017 +0200 Bug 19008: More database cleanups - deleted patrons misc/cronjobs/cleanup_database.pl provides some database cleanup. Yet some tables that could need cleanup are not in this script. This patch adds cleanup for deletedborrowers table. Test plan : - Count : select count(*),date(updated_on) from deletedborrowers group by date(updated_on); - Run cleanup : misc/cronjobs/cleanup_database.pl -v --deleted-patrons 30 - Recount Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit a0a579d773c95ec87a647497cc755b0a4cc7f55f Author: Fridolin Somers Date: Fri Jul 28 14:05:03 2017 +0200 Bug 19008: More database cleanups - deleted catalog misc/cronjobs/cleanup_database.pl provides some database cleanup. Yet some tables that could need cleanup are not in this script. This patch adds cleanup for deleted catalog tables. Note that deletedbiblio_metadata is managed by foreign key on biblionumber. Test plan : - Count : select count(*),year(timestamp) from deleteditems group by year(timestamp); select count(*),year(timestamp) from deletedbiblio group by year(timestamp); select count(*),year(timestamp) from deletedbiblioitems group by year(timestamp); - Run cleanup : misc/cronjobs/cleanup_database.pl -v --deleted-catalog 30 - Recount Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 20118bb795ce046c2b00152aeccb94ae998375e6 Author: Fridolin Somers Date: Fri Jul 28 14:12:22 2017 +0200 Bug 19008: More database cleanups - statistics misc/cronjobs/cleanup_database.pl provides some database cleanup. Yet some tables that could need cleanup are not in this script. This patch adds cleanup for statistics table. Test plan : - Count statistics : select count(*),date(datetime) from statistics group by date(datetime); - Run cleanup : misc/cronjobs/cleanup_database.pl -v --statistics 30 - Recount statistics Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: misc/cronjobs/cleanup_database.pl | 114 +++++++++++++++++++++++++++++++++++++- 1 file changed, 113 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Apr 2 23:04:14 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 02 Apr 2020 21:04:14 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.04-60-ga988616855 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via a9886168559f158a3c9bfcee859ffc28b6939354 (commit) via 49ef424bf6f96b87838bcb728196a9051010b309 (commit) via 913f6b9e8a8cc8dbc0481a258dea9344d2ce9ecf (commit) via e8bb094e5cc42e8d2b4745b3e8d8338c816e0c17 (commit) via 0c3b750f1af64c201d26428d8eacbedd03f925e7 (commit) from d6a0b07984ed63e91723fa484890f111077dbd10 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a9886168559f158a3c9bfcee859ffc28b6939354 Author: Martin Renvoize Date: Wed Mar 11 11:27:38 2020 +0000 Bug 24839: (QA follow-up) Remove unused variables Whilst QAing I spotted a couple of unused variables in the test.. no harm in removing them ;) Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 49ef424bf6f96b87838bcb728196a9051010b309 Author: Nick Clemens Date: Tue Mar 10 09:37:56 2020 -0400 Bug 24839: Return hold info to transfer script and set borrowernumber To test: 1 - Place a hold on an item 2 - Go to Circulation->Transfers 3 - Attempt to transfer item to a branch it is not expected at 4 - No warning 5 - Apply patches 6 - Repeate 7 - You get a notice that there is a hold and must deal with the hold (or ignore) Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 913f6b9e8a8cc8dbc0481a258dea9344d2ce9ecf Author: Nick Clemens Date: Tue Mar 10 09:59:16 2020 -0400 Bug 24839: Unit tests Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit e8bb094e5cc42e8d2b4745b3e8d8338c816e0c17 Author: Fridolin Somers Date: Mon Mar 2 18:03:54 2020 +0300 Bug 24777: Use patron.is_debarred instead of patron.debarred in return.tt In return page return.tt, when there is an hold message, patron is said as restricted even if restriction end date is in the past. Test plan : 1) For a patron Jon Doe create a manual restriction with end date in the past 2) Create an hold for this patron on an item 3) Check in this item => You don't see message "Patron is RESTRICTED" 4) For a patron Kevin Doe create a manual restriction with end date in the future 5) Create an hold for this patron on an item 6) Check in this item => You see message "Patron is RESTRICTED" 7) Repeate 1-6 with system preference HoldsAutoFill enabled 8) Repeate 1-6 with a waiting hold Signed-off-by: Nazlı Çetin Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 0c3b750f1af64c201d26428d8eacbedd03f925e7 Author: Emmi Date: Fri Jul 5 11:46:15 2019 +0300 Bug 23268: Make "Suspend all holds" calendar select a date from tomorrow This patch removes "circulation" and moremember" templates functions for Datepicker plugin. They now use options common for all inputs with "datepicker" class and get "minDate" option from class "futuredate" assigned function in "calender.inc". To test: - Apply patch - Add holds for patron - Use "Suspend all holds" calendar =>Calendar greys out dates past from today Signed-off-by: David Roberts Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 3 +- circ/branchtransfers.pl | 1 + .../intranet-tmpl/prog/en/includes/calendar.inc | 4 +++ .../prog/en/modules/circ/circulation.tt | 9 +----- .../intranet-tmpl/prog/en/modules/circ/returns.tt | 6 ++-- .../prog/en/modules/members/moremember.tt | 10 +------ t/db_dependent/Circulation/transferbook.t | 32 +++++++++++++++------- 7 files changed, 33 insertions(+), 32 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 3 15:55:27 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Apr 2020 13:55:27 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1593-ge065b86abd Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via e065b86abd51f36340fa940ca211931e21689fad (commit) via 9d6362145ff335cec81e64874021c8f7a4479f23 (commit) via 866f0c04a8707b06a00940267cc8aa405b8983f0 (commit) via 86d93a5d4119c37a635dfa844f3e11212ce9555f (commit) via dc6998cea9233072e34d8a7e94c6dcc800b9f49a (commit) via fd1a48f0448c71ab0ccc063a9146faa40b89d86e (commit) via 1aad1ed01ea3fcf417542a36fab014a8602a5cfc (commit) via e21e40ad8446e79316e476cded7c694207c2c3bf (commit) via 9c9818c528bc47458015f89a74c9192f543ca7bb (commit) via f1c779343e7980d3df5b0a64ea5dfe179267289d (commit) via 09a76a440ea8f0101bea2a7dac46e58fb87ac3dd (commit) via 5f323dbe49aa68515f5cbab7fba2e31843759408 (commit) via 09c0c7a555219e2346d769e57585caa128d5bb61 (commit) via 41174f60eafdf68ef2f94b18f19905af302097ec (commit) via 55b9b8e17de19bbc2f5c4e0fa1d2e5937a6c3eaf (commit) via e986d4d0ad98cb5ac8d54d8d30cbf2f4fcb14417 (commit) via 192b9d55a05414bf3e8d64eeaba1926a20ec8ba8 (commit) via a99923a27ba327111819dea144da6d1d10b82c9c (commit) via 502af90868a9fe58a59ebd0d6c2ff960ce897335 (commit) via ebb73e373805380cc5399488793139758adc0ce5 (commit) via 563784bcf5afc2989d354dcf2e91cf3fa667e67d (commit) via 2823fee5cfb08cec398e9d02cfc9e1d65b8fde57 (commit) via 416ae0768858452609cc6d62d1a00601c2a49613 (commit) via 3ed641b33a5969e9c5d2eb027b9bbce761d06ed8 (commit) via f756aa917cfb13c6c2729c5dc07dbd6db5e7441b (commit) via 39c872a71e8d8448310a3daeb6224d4b21a2d162 (commit) via 08322a6f639bd2946b9db70fe6906d5ca12f26bd (commit) via dab0f06a4622ba2ddb178824d0c03f7e260a224a (commit) via 145b0116582630121d9fe90181134040e8fca9ea (commit) from c800ef7e594d9c1edc37ba563b4d508f656e940c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e065b86abd51f36340fa940ca211931e21689fad Author: Jonathan Druart Date: Mon Mar 30 16:11:51 2020 +0200 Bug 25020: Preserve time part when batch extending due dates When selecting a new hard due date, we should keep the time part of the original checkouts. Test plan: 1 - Checkout an item specifying a date due 2 - Checkout an item without specifying a date due 3 - Use Tools->Batch extend due date 4 - Select a hard due date 5 - On the confirmation screen you should see that the time part has been kept 6 - Confirm 7 - Make sure the correct values hava been inserted in DB 8 - Try now using the other option, give a number of days 9 - Repeat 4-7 Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit 9d6362145ff335cec81e64874021c8f7a4479f23 Author: Owen Leonard Date: Tue Mar 31 14:20:23 2020 +0000 Bug 25022: Display problem in authority editor with repeatable field This patch corrects an error in the structure of the authority editor template so that repeating subfields do not generate invalid markup. The correction was found by comparing with addbiblio.tt. If you are viewing the diff, please note that some minor whitespace changes have been made. To reproduce, clone and and populate any repeatable subfield, save, and open the authority for editing again. The clones subfield will be formatting incorrectly, showing bullet points on each line. To test, apply the patch and reload the authority editor showing the record with the cloned subfield. It should display correctly. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit 866f0c04a8707b06a00940267cc8aa405b8983f0 Author: Owen Leonard Date: Tue Mar 31 14:54:41 2020 +0000 Bug 25004: Search results place hold button not enabled when checking result checkboxes on opac-search.pl This patch makes a minor correction to the markup of the OPAC search results page so that the event handlers attached to the checkboxes work correctly. The broken markup broke the jQuery selector used to control the event. An extra was added by mistake by Bug 14715. To test, apply the patch and test the process of selecting multiple titles by checking the checkbox. Doing so should activate the "Place hold" and "Tag" controls. Signed-off-by: David Nind Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 86d93a5d4119c37a635dfa844f3e11212ce9555f Author: Jonathan Druart Date: Wed Apr 1 10:58:28 2020 +0200 Bug 25024: Do not escape $ Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit dc6998cea9233072e34d8a7e94c6dcc800b9f49a Author: Nick Clemens Date: Tue Mar 31 13:55:21 2020 +0000 Bug 25024: Make grep match full string To test: 1 - Create or have a branch with code CPL 2 - Create two new branches 'ACPL' and 'CPLA' 3 - In branch transfer limits disallow some itype or collection from another branch (FPL) to ACPL and CPLA 4 - Set UseBranchTransferLimits to 'Enforce' 5 - Find a biblio with one item belonging to FPL 6 - On opac, attempt to place a hold 7 - Note that ACPL and CPLA don't show in dropdown, OK 8 - Note that CPL is disabled, NOT OK 9 - Apply patch 10 - Place hold 11 - CPL is now enabled Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Joel Sasse Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit fd1a48f0448c71ab0ccc063a9146faa40b89d86e Author: Katrin Fischer Date: Thu Mar 26 22:30:52 2020 +0000 Bug 17938: Fix display of label for repeated MARC 583 - Action note fields When there are mulitple 583 on a record, the label "Action note" will be repeated for each. This fixes it, so that the label only appears once and multiple fields are separated by | following the existing pattern. Also makes sure there is a space between $z and other subfields. Note: Ind. 1 = private - These won't display in the OPAC Ind. 1 = 0 or empty - These will display in the OPAC Staff will display all 583 independent from indicator. To test: - Add one or more records with none, one and muliple 583, at least one including $z For examples see: http://www.loc.gov/marc/bibliographic/bd583.html - Verify display problems - Apply patch - Verify display is improved - one label and $z is followed by a space Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 1aad1ed01ea3fcf417542a36fab014a8602a5cfc Author: Martin Renvoize Date: Fri Apr 3 14:28:05 2020 +0100 Bug 25010: DBRev 19.12.00.062 Signed-off-by: Martin Renvoize commit e21e40ad8446e79316e476cded7c694207c2c3bf Author: Katrin Fischer Date: Thu Mar 26 21:30:06 2020 +0000 Bug 25010: Fix typo 'rewewal' in debit types This fixes a typo in the debit type description of RENT_DAILY_RENEW 1) Go to Administration > Debit types 2) Show all debit types 3) Check for the typo 4) Apply patch 5) Verify that the typo is gone 6) Check account_debit_types table for type: SELECT * FROM account_debit_types; 7) Run database update 8) Repeat and verify typo is gone Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 9c9818c528bc47458015f89a74c9192f543ca7bb Author: Katrin Fischer Date: Sat Mar 28 01:22:35 2020 +0100 Bug 24941: Serials - Fix link to basket from acquisition details information Adding orders from subscriptions makes acquisition information visible in the serials module. In the table of acquisition data is a link back to the basket - but this link is missing the basket number parameter - it doesn't work. This patch fixes the TT variable to make it work. To test: - Add a subscription - Add a new basket - Add a order line using "Add from subscription" - Go to the subscription details page, check the acquisitions tab - Try the link to the basket - it should not work - Apply patch - Try the link again - now it should bring up the basket page with the order. Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit f1c779343e7980d3df5b0a64ea5dfe179267289d Author: Katrin Fischer Date: Sat Mar 28 00:46:55 2020 +0100 Bug 25012: Fix class on OPAC view link in staff detail page Probably a copy & paste error: the OPAC view link on the staff detail page currently has the class succeeding_entry_note. This patch changes it to opac_view to allow for independent styling of the link. Note: The link will only be visible when OPACBaseURL is set. To test: - Use the element inspector or check the source code for the class used on the OPAC view link on the staff detail page - Apply patch - Repeat and verify that the class has changed to opac_view Signed-off-by: David Roberts Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 09a76a440ea8f0101bea2a7dac46e58fb87ac3dd Author: Katrin Fischer Date: Sat Mar 28 00:54:21 2020 +0100 Bug 25013: Fix capitalization: Edit Items on batch item edit Fixes a tiny string issue: Edit Items --> Edit items To test: - Go to tools / batch item edit - Enter a barcode - Check the heading above the edit item form - Apply patch - Verify the heading is now properly capitalized Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 5f323dbe49aa68515f5cbab7fba2e31843759408 Author: Katrin Fischer Date: Sat Mar 28 01:05:14 2020 +0100 Bug 25014: Fix capitalization for "Call Number" in staff and OPAC sort options There are some ocurrences of "Call Number" in the sort option lists in staff and OPAC. The patch changes them to "Call number". To test: - Check the sort option list in staff and OPAC for the typo - Apply patch - Verify it's now all corrected Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 09c0c7a555219e2346d769e57585caa128d5bb61 Author: Martin Renvoize Date: Fri Apr 3 14:15:34 2020 +0100 Bug 24996: Compiled CSS Signed-off-by: Martin Renvoize commit 41174f60eafdf68ef2f94b18f19905af302097ec Author: Owen Leonard Date: Fri Mar 27 01:36:22 2020 +0000 Bug 24996: Unwanted CSS change unhides OPAC results sorting button This patch adds back a CSS selector which was incorrectly removed by Bug 23915. The "Go" button associated with the OPAC search results resort operation should be hidden if JavaScript is enabled. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client) - Perform a search in the OPAC - On the search results page, there should be no "Go" button next to the re-sort/results per page selection fields. Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 55b9b8e17de19bbc2f5c4e0fa1d2e5937a6c3eaf Author: Tomas Cohen Arazi Date: Fri Mar 27 16:38:15 2020 -0300 Bug 25006: Make Koha::Item->as_marc_field skip undefined subfields This patch makes as_marc_field skip subfields that don't have a value or contains an empty string (replicating C4::Items:1021 logic). To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Item.t => FAIL: Tests fail because the generated MARC::Field contains undef subfields. 3. Apply this patch 4. Repeat 2. => SUCCESS: Tests pass! Undefined and empty subfields are skipped! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit e986d4d0ad98cb5ac8d54d8d30cbf2f4fcb14417 Author: Tomas Cohen Arazi Date: Fri Mar 27 16:36:25 2020 -0300 Bug 25006: Regression tests This patch introduces regression tests for as_marc_field. It makes sure there are empty subfields and then uses List::MoreUtils' all to verify all generated MARC subfields contain something (i.e. the undef ones are skipped). Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 192b9d55a05414bf3e8d64eeaba1926a20ec8ba8 Author: Jonathan Druart Date: Mon Mar 30 11:35:35 2020 +0200 Bug 19475: Clear the caches at the end of the tests Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit a99923a27ba327111819dea144da6d1d10b82c9c Author: Emmi Takkinen Date: Wed Mar 4 13:54:34 2020 +0200 Bug 19475: Don't copy holiday if it already exists in target calendar Calendars copy tool created duplicate values to database. Holidays in target calendar weren't checked before inserting new holidays. This patch fixes this. To test: 1. Add holidays for branch A 2. Copy branch A calendar to branch B 3. Repeat copy to branch B => Check database, branch B has now duplicate holidays 4. Delete holidays from branches A and B 5. Apply patch 6. Repeat steps 1-3 => Check database, no duplicates Sponsored-by: Koha-Suomi Oy Signed-off-by: Michal Denar Signed-off-by: Fridolin Somers Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 502af90868a9fe58a59ebd0d6c2ff960ce897335 Author: Emmi Takkinen Date: Thu Mar 12 12:35:39 2020 +0200 Bug 19475: Add unit tests To test prove: t/db_dependent/Holidays.t Sponsored-by: Koha-Suomi Oy Signed-off-by: Fridolin Somers Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit ebb73e373805380cc5399488793139758adc0ce5 Author: Martin Renvoize Date: Fri Apr 3 14:10:07 2020 +0100 Bug 9422: (RM follow-up) Rebase Correction Signed-off-by: Martin Renvoize commit 563784bcf5afc2989d354dcf2e91cf3fa667e67d Author: Katrin Fischer Date: Sun Feb 10 12:09:08 2019 +0100 Bug 9422: Don't allow access to 'Upload patron images' when patronimages syspref is off In addition to checking the patron image upload permission, this adds a check for the patronimages system preference to the tools home page and sidebar. To test: - Check that the patron image upload tool only displays when - system preference patronimages is set to 'Allow' and user is either - superlibrarian or - has bath_upload_patron_images permission - Save URL of patron image uploader page - Turn off patronimages - Verify you get redirected to the home page of Koha when trying to access the page Note: this redirect is already used by the stock rotation feature. Signed-off-by: Martin Renvoize commit 2823fee5cfb08cec398e9d02cfc9e1d65b8fde57 Author: Martin Renvoize Date: Fri Apr 3 14:04:48 2020 +0100 Bug 24474: DBRev 19.12.00.061 Signed-off-by: Martin Renvoize commit 416ae0768858452609cc6d62d1a00601c2a49613 Author: Martin Renvoize Date: Tue Mar 31 09:43:34 2020 +0100 Bug 24474: (QA follow-up) Fix failing test The test was assuming default data and would fail if you ran through the test plan (and disabled all but `onpayment` for the 'MarkLostItemsAsReturned' preference) on the data before running the included unit tests. Signed-off-by: David Nind Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit 3ed641b33a5969e9c5d2eb027b9bbce761d06ed8 Author: Martin Renvoize Date: Fri Feb 14 10:39:21 2020 +0000 Bug 24474: (follow-up) Add LOST_FOUND logic to Koha::Account::pay This patch adds the same updated logic as found in Koha::Account::Line->apply to handle LOST_FOUND credits being applied against their associated LOST debit. Currently a 'LOST_FOUND' credit is never created via the pay method and so the additional test will always pass, but the addition here accounts for possible future uses. Signed-off-by: David Nind Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit f756aa917cfb13c6c2729c5dc07dbd6db5e7441b Author: Martin Renvoize Date: Mon Feb 10 10:31:37 2020 +0000 Bug 24474: (follow-up) Add onpayment to sysprefs file This patch adds the required line to the circulation.pref file to dispaly the onpayment option in the MarkLostItemReturned preference Signed-off-by: David Nind Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit 39c872a71e8d8448310a3daeb6224d4b21a2d162 Author: Martin Renvoize Date: Wed Feb 5 13:10:49 2020 +0000 Bug 24474: Filter out LOST_FOUND Signed-off-by: David Nind Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit 08322a6f639bd2946b9db70fe6906d5ca12f26bd Author: Martin Renvoize Date: Wed Feb 5 10:14:05 2020 +0000 Bug 24474: Add `onpayment` option to `MarkLostItemsReturned` Signed-off-by: David Nind Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit dab0f06a4622ba2ddb178824d0c03f7e260a224a Author: Jonathan Druart Date: Tue Feb 4 15:13:47 2020 +0100 Bug 24474: Add tests This does the following using the interface: - Unselect all the options from MarkLostItemsAsReturned except for 'onpayment' - Check an item out - Create a manual invoice LOST for the checked in item - Renew the item - Check that the item was not returned Signed-off-by: David Nind Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit 145b0116582630121d9fe90181134040e8fca9ea Author: Aleisha Amohia Date: Thu Mar 19 04:37:34 2020 +0000 Bug 24900: Checks in MARC mod templates for when from field does not equal conditional field When MARC modification template actions are applied, they assume that the from field is the same as the conditional field. This patch adds checks for this, as well as tests to confirm the behaviour is correct. CASE 1: Delete 1st field 020 if 651$z exists BROKEN BEHAVIOUR (before patch): deletes the 2nd instance of 020 instead of 1st EXPECTED BEHAVIOUR (corrected by patch): deletes the 1st instance of 020 CASE 2: Delete 1st field 020 if 651$z matches Berlin. (must include '.') BROKEN BEHAVIOUR (before patch): deletes the 2nd instance of 020 EXPECTED BEHAVIOUR (corrected by patch): deletes the 1st instance of 020 CASE 3: Delete field 020 if 650$2 does not match fast BROKEN BEHAVIOUR (before patch): deletes all 020 fields even though 650$2 does match fast EXPECTED BEHAVIOUR (corrected by patch): does not delete 020 fields Confirm tests pass: t/db_dependent/MarcModificationTemplates.t Sponsored-by: Catalyst IT Signed-off-by: Frank Hansen Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Calendar.pm | 38 +++++-- C4/MarcModificationTemplates.pm | 31 +++++- Koha.pm | 2 +- Koha/Account.pm | 37 ++++--- Koha/Account/Line.pm | 18 ++- Koha/Item.pm | 3 +- installer/data/mysql/account_debit_types.sql | 2 +- installer/data/mysql/sysprefs.sql | 2 +- installer/data/mysql/updatedatabase.pl | 37 ++++++- .../intranet-tmpl/prog/en/includes/accounts.inc | 2 +- .../intranet-tmpl/prog/en/includes/resort_form.inc | 4 +- .../intranet-tmpl/prog/en/includes/tools-menu.inc | 4 +- .../en/modules/admin/preferences/circulation.pref | 1 + .../prog/en/modules/authorities/authorities.tt | 25 ++--- .../prog/en/modules/catalogue/results.tt | 4 +- .../prog/en/modules/serials/subscription-detail.tt | 2 +- .../prog/en/modules/tools/batchMod-edit.tt | 2 +- .../en/modules/tools/batch_extend_due_dates.tt | 6 +- .../prog/en/modules/tools/tools-home.tt | 4 +- .../prog/en/xslt/MARC21slim2intranetDetail.xsl | 39 ++++--- koha-tmpl/opac-tmpl/bootstrap/css/opac.css | 2 +- koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss | 1 + .../bootstrap/en/includes/account-table.inc | 2 +- .../bootstrap/en/includes/resort_form.inc | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-results.tt | 1 - .../bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 29 +++-- t/db_dependent/Circulation.t | 45 +++++++- t/db_dependent/Holidays.t | 120 +++++++++++++++++++- t/db_dependent/Koha/Item.t | 11 +- t/db_dependent/MarcModificationTemplates.t | 122 ++++++++++++++++++++- tools/batch_extend_due_dates.pl | 47 ++++++-- tools/picture-upload.pl | 6 + 33 files changed, 535 insertions(+), 118 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 3 19:49:53 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Apr 2020 17:49:53 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.04-66-g2c2e229709 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 2c2e229709e723c7604fecf0a5607486ed1e6d14 (commit) via df4811ae1f2ff5a21ea5a3a7db97b19ecfdc4f6d (commit) via 5fbde57bbcb5c4035c6e7a5a7416ebbc407719e2 (commit) via 120547748d4fe6497512169b4a7a8be895128f87 (commit) via bfe923de3e57631ac59515c65e90e9253988de23 (commit) via b32023b10109e9e487f5aa59d194fa5599231743 (commit) from a9886168559f158a3c9bfcee859ffc28b6939354 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2c2e229709e723c7604fecf0a5607486ed1e6d14 Author: Nick Clemens Date: Mon Mar 9 09:41:26 2020 +0000 Bug 19288: Don't show patron info for item level holds on details.pl unless hold is waiting This persists after bug 20948 - we can still display patron information even if this patron is not the one who will receive the item upon checkin. The holds tab can give an overview of holds and information - I think on the details page the only info we need is whether there might be a item level hold, not who it is for To test: 1 - Place an item level hold for delivery at a branch not matching home branch of item 2 - Place a record level hold for delivery at homebranch of item placed on hold above 3 - Enable LocalHoldsPriority with 'pickup library' matches the item's 'home library' 4 - View the details for the page, it says the item has a hold for the patron with an item level hold 5 - Check in the item, the hold triggered is for the next available patron, ignore the hold 6 - Apply patch 7 - Check details page, 'There is an item-level hold (priority=1)' with no patron info 8 - Check in, next available hold is still the one triggered Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit df4811ae1f2ff5a21ea5a3a7db97b19ecfdc4f6d Author: Fridolin Somers Date: Fri Jul 26 15:43:02 2019 +0200 Bug 23383: fix IdRef syspref test in XSLT IdRef link is displayed via XSLT. There is a test of syspref with just if value is defined. But in installer/data/mysql/sysprefs.sql you see this pref will be 0 by default, which is true in XPATH. We should test that pref is 1. Test plan : 1) Create a fresh UNIMARC database 2) You have pref IdRef disabled 3) Simulate a SUDOC record: Fill a 7..$3 field with a ppn (032581270 for example). Fill the 009 field with an integer 4) Go to the opac detail page of the record => You don't see IdRef link 5) Enable IdRef syspref 6) Go to the opac detail page of the record => You see IdRef link 7) Disable IdRef syspref 8) Go to the opac detail page of the record => You don't see IdRef link Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 5fbde57bbcb5c4035c6e7a5a7416ebbc407719e2 Author: Andrew Fuerste-Henry Date: Wed Mar 11 00:54:03 2020 +0000 Bug 24838: Fix help link for patron categories To test: - go to admin/categories.pl - click Help, confirm it takes you to manual main page - apply patch - restart all - click Help, confirm it takes you to patron categories in manual Signed-off-by: Sally Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 120547748d4fe6497512169b4a7a8be895128f87 Author: Nick Clemens Date: Fri Oct 25 13:49:05 2019 +0000 Bug 23521: (follow-up) Add quotes Not only should terms from facets/limits be grouped, but order should probably matter We build a different facet for "Dillinger Girl" or "Girl Dillinger" The parens are possibly overkill now, but I think it makes it very clear and does not hurt To test: 1 - Follow original plan 2 - Create a new record with 'Girl Dillinger' as author 3 - Search for 'Dill*' 4 - You get all three records (and maybe others that match) 5 - Limit by 'Girl Dillinger' - you get two records 6 - Same for 'Dillinger Girl' 7 - Apply patch 8 - Limits/facets for 'Dillinger Girl' and 'Girl Dillinger' now match a isngle record Signed-off-by: Ere Maijala Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit bfe923de3e57631ac59515c65e90e9253988de23 Author: Alex Arnaud Date: Thu Aug 29 15:06:14 2019 +0000 Bug 23521: Put parentheses arround limit terms Test plan: - Use Elasticsearch 6 (you'll need Bug 18969), - create a biblio (#1) with "Dillinger Girl" in author and what you want in title, - create another biblio (#2) with the word "girl" in the title and "Dillinger Escaplan" as author - reindex - search * and refine on "Dillinger Girl" - Ko => Biblio #1 and #2 appear - Apply this patch, - search * and refine on "Dillinger Girl" - Ok => anly biblio #1 appears - use Elasticsearch 5 again - check for no search regression Signed-off-by: Séverine QUEUNE Signed-off-by: Séverine QUEUNE Signed-off-by: Nick Clemens Signed-off-by: Ere Maijala Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit b32023b10109e9e487f5aa59d194fa5599231743 Author: Andrew Isherwood Date: Mon Feb 3 11:14:50 2020 +0000 Bug 24565: Add patron profile to ILL list pages We need the API call to get ILL requests on the patron profile page, this commit allows this. Test plan: - Do not apply the patch. - Go to the "Ill requests history" page for a patron who has made ILL requests - TEST: Observe that no requests are displayed - Apply the patch - Refresh the page - TEST: Observe that requests are displayed - Go to the main "ILL requests" page - TEST: Observe that requests are displayed Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: Koha/Manual.pm | 2 +- Koha/SearchEngine/Elasticsearch/QueryBuilder.pm | 8 +++++++- .../intranet-tmpl/prog/en/modules/catalogue/detail.tt | 10 ++++------ koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js | 12 ++++++++++-- .../opac-tmpl/bootstrap/en/xslt/UNIMARCslimUtils.xsl | 2 +- .../Koha/SearchEngine/Elasticsearch/QueryBuilder.t | 16 +++++++++++++++- 6 files changed, 38 insertions(+), 12 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 3 20:00:50 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Apr 2020 18:00:50 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.04-76-gc35acfaebe Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via c35acfaebeb4c1e4bd378a8af64175706cfa3e4c (commit) via 04359d9bbb2dabe8eefac60cd5ed68c81d91379c (commit) via 59955a13836fba246746ca8aaa2384c800425665 (commit) via 46b219864e3ea001d05dc69e960fd77c00c5eed6 (commit) via f641a3d247c23328715e6e091d1e3f8b2fb3f4c6 (commit) via 81f32a92ac7e883a98b40511c1d4e3d44b68b480 (commit) via 5d4f396c7e9114dbfb0bb45bc2b9e862b2af0ecd (commit) via 572c3afef1a3b6dfe3ee4d841737170ee92b7e1f (commit) via 37de3685a4d527663f98ca11d09b4d911e00a770 (commit) via 16d756791ece7325f4541b7f2b7caaee7c9c12c5 (commit) from 2c2e229709e723c7604fecf0a5607486ed1e6d14 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c35acfaebeb4c1e4bd378a8af64175706cfa3e4c Author: Martin Renvoize Date: Sun Mar 8 08:39:40 2020 +0000 Bug 24402: About template corrections With the 20.05 team we introduced and expanded some roles. This patch adds support for: * removal of the release maintainer for development releases * a list of documentation managers * a list of packaging manager Signed-off-by: Michal Denar Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 04359d9bbb2dabe8eefac60cd5ed68c81d91379c Author: Katrin Fischer Date: Fri Mar 13 08:47:53 2020 +0000 Bug 22943: Remove unused line from Auth.t Removes an unnecessary variable declaration from Auth.t Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 59955a13836fba246746ca8aaa2384c800425665 Author: Martin Renvoize Date: Mon Mar 9 09:17:50 2020 +0000 Bug 22943: (QA follow-up) Add new cases A few additional cases were introduced since the original bug was authored. This patch simply catches those cases and makes the same change. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 46b219864e3ea001d05dc69e960fd77c00c5eed6 Author: Hayley Mapley Date: Mon May 27 13:57:05 2019 +1200 Bug 22943: Renames the in_ipset function to in_iprange in C4::Auth Bug 14407 introduced a new system preference to allow limiting the online self checkout system to an IP or IP Range. The function that handles this is called in_ipset, which is the name of a linux tool. To stop confusion, this patch renames the function to 'in_iprange', and the variable 'ipset' within it to 'iprange'. To test, follow the test plans outlined in Bug 14407 and confirm that everything works as expected. Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit f641a3d247c23328715e6e091d1e3f8b2fb3f4c6 Author: Owen Leonard Date: Tue Feb 11 15:10:48 2020 +0000 Bug 24627: Correct style of clubs search results during hold process This patch updates some markup and CSS so that the process of selecting a club from search results during the hold process looks the same as when selecting a patron: Club names should be links (like patron names are) and the table row should have a hover color to help indicate that it is clickable. This patch also changes the markup of the Patrons/Clubs tabs a little bit to make the information clearer: Superfluous Bootstrap-related tab markup has been removed, and the patron and club search results have been moved into their respective tab containers. This means that if you search for a patron but then switch to the clubs tab the patron list doesn't still display. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client) - You should have more than one patron club defined. - Begin the process of placing a hold on a title. - Test the process of searching for both patrons and clubs. - In each case the name (patron or club) should be an active link. - Hovering your mouse over the table rows should change the row background to yellow. - Clicking the other tab at this stage should hide the search results from your last search. - Whether you click the linked name or elsewhere in the table row you should be correctly redirected to the next step in the holds process. Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 81f32a92ac7e883a98b40511c1d4e3d44b68b480 Author: Lucas Gass Date: Thu Mar 12 22:38:47 2020 +0000 Bug 24858: Correct labels on wording in ExcludeHolidaysFromMaxPickUpDelay TO TEST: - Apply patch - mark your library closed today and tomorrow - set ReservesMaxPickUpDelay to 1 day - set ExcludeHolidaysFromMaxPickUpDelay to "Ignore the calendar" - place hold, capture hold - hold expiration date is set to tomorrow (doesn't skip closed days) - Set ExcludeHolidaysFromMaxPickUpDelay to "Use the calendar" - Place hold, capture hold - hold expiration date is set to the day after tomorrow (skips closed days) Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 5d4f396c7e9114dbfb0bb45bc2b9e862b2af0ecd Author: Kyle M Hall Date: Thu Mar 12 07:07:48 2020 -0400 Bug 24767: Hide the "Claim returned" tab if the feature is turned off The ability to claim an item "claim returned" is not there if the syspref is empty, however, the Claim Returned tab is stil present on the patrons detail page. Test Plan: 1) Ensure ClaimReturnedLostValue is not set 2) Note the claims tabs on the circulation and patron details pages 3) Apply this patch 4) Refresh those pages 5) The claims tabs should be gone! Signed-off-by: Sally Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 572c3afef1a3b6dfe3ee4d841737170ee92b7e1f Author: Jonathan Druart Date: Thu Mar 12 15:09:02 2020 +0100 Bug 5103: Refactor the code to avoid repetition Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 37de3685a4d527663f98ca11d09b4d911e00a770 Author: Aleisha Amohia Date: Wed Mar 11 03:08:12 2020 +0000 Bug 5103: (follow-up) Using mapped item fields instead of hardcoding subfields Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 16d756791ece7325f4541b7f2b7caaee7c9c12c5 Author: Aleisha Amohia Date: Wed Feb 26 02:52:24 2020 +0000 Bug 5103: Format dates in MARC detail using dateformat syspref This patch fixes the formatting of dates on the following pages: - catalogue/MARCdetail.pl (staff) - cataloguing/additem.pl (staff) - opac-MARCdetail.pl (opac) To test: 1) Ensure that the following fields are visible in the opac, intranet and editor. You may need to edit the subfields in your default bibliographic framework 952$d date accessioned 952$q date due/on loan 952$r date last seen 952$s date last borrowed 952$w replacement price date Also ensure you have dateformat system preference set 2) Go to cataloguing/additem.pl for a biblio. Fill in the fields above if required. Save 3) Remain on cataloguing/additem.pl. Notice the items table at the top of the page, the dates are in the generic yyyy-mm-dd format 4) Go to catalogue/MARCdetail.pl for that biblio. Notice dates in wrong format 5) View this biblio in the opac opac-MARCdetail.pl. Scroll to bottom to items table. Notice dates in wrong format. 6) Apply patch, restart memcached and plack and refresh pages 7) Dates should now be formatted according to dateformat preference 8) Confirm that changing the preference changes the format of the dates Sponsored-by: Catalyst IT Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: C4/Auth.pm | 16 ++-- catalogue/MARCdetail.pl | 7 ++ cataloguing/additem.pl | 22 +++++- koha-tmpl/intranet-tmpl/prog/css/src/_tables.scss | 2 +- .../intranet-tmpl/prog/css/src/staff-global.scss | 6 ++ .../intranet-tmpl/prog/en/includes/about-team.inc | 32 ++++++-- .../en/includes/circ-patron-search-results.inc | 3 +- .../intranet-tmpl/prog/en/includes/clubs-table.inc | 4 +- .../en/modules/admin/preferences/circulation.pref | 4 +- .../prog/en/modules/circ/circulation.tt | 41 +++++----- .../prog/en/modules/members/moremember.tt | 40 +++++----- .../prog/en/modules/reserve/request.tt | 89 +++++++++++----------- opac/opac-MARCdetail.pl | 8 ++ opac/sco/help.pl | 4 +- opac/sco/printslip.pl | 4 +- opac/sco/sco-main.pl | 4 +- opac/sco/sco-patron-image.pl | 4 +- t/Auth.t | 29 ++++--- 18 files changed, 191 insertions(+), 128 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 3 20:47:23 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Apr 2020 18:47:23 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.04-83-g2244ed8072 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 2244ed80725a91d101d1796ab118d4fccc5ff61e (commit) via e513e32d0e3c004236048b6673f55eb45bbd82ae (commit) via 3b06b06cf3f41afbd7af136e250783e0f97acfc5 (commit) via ab2a1b82052c00c2230c162763975ec0ac8dc989 (commit) via f7729a02547ec1b4e71b13c70757bb48ad622b51 (commit) via 66742f6e705d5841c6559f346883bdc2f6ee1053 (commit) via b58bb48b0b7401d010bb89bdaf7edbee1c6163ce (commit) from c35acfaebeb4c1e4bd378a8af64175706cfa3e4c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2244ed80725a91d101d1796ab118d4fccc5ff61e Author: Jonathan Druart Date: Mon Mar 16 12:39:39 2020 +0100 Bug 24851: Translate the .txt in French Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit e513e32d0e3c004236048b6673f55eb45bbd82ae Author: Jonathan Druart Date: Wed Mar 4 19:06:03 2020 +0100 Bug 24851: Insert libraries sample data for "UNIMARC" I am trying to make koha-testing-docker UNIMARC compabible. In order to have koha-misc4dev insert all the data correctly (users, etc.) we need at least 1 library. I am suggesting to reuse the usual library list for UNIMARC. misc4dev will use fr-FR sample data for "UNIMARC" This is related to https://gitlab.com/koha-community/koha-misc4dev/issues/29 Test plan: outside your box, in koha-testing-docker (up-to-date), edit .env and set KOHA_MARC_FLAVOUR=unimarc DEBUG_GIT_REPO_MISC4DEV_URL=https://gitlab.com/joubu/koha-misc4dev.git DEBUG_GIT_REPO_MISC4DEV_BRANCH=unimarc Then start the koha container When the misc4dev will start its job, the scripts will have the expected data to continue. Without this patch you will get koha_1 | Not enough data in the database, library and/or patron category does not exist at /kohadevbox/misc4dev/create_superlibrarian.pl line 31. And plenty of errors will follow. Also, the sample data used in misc4dev will use CPL (/kohadevbox/misc4dev/data/sql/unimarc/1812/after_22155/items.sql) Signed-off-by: Jon Knight Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 3b06b06cf3f41afbd7af136e250783e0f97acfc5 Author: Jonathan Druart Date: Mon Mar 16 13:01:04 2020 +0100 Bug 24827: Add a test Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit ab2a1b82052c00c2230c162763975ec0ac8dc989 Author: Andreas Roussos Date: Sun Mar 15 08:43:25 2020 +0100 Bug 24827: Specify UTF-8 as encoding in new_from_xml() The MARC preview of staged records fails when a staged record contains items with UTF-8 characters (see attached screenshots). That's because in EmbedItemsInImportBiblio() the call to MARC::Record->new_from_xml() does not explicitly specify 'UTF-8' as the optional encoding to use. This patch fixes that. Test plan (in a MARC21 instance): 0) Stage for import the test record attached to this bug report (make sure that 'Check for embedded item record data?' is set to 'Yes'), then go to Home > Tools > Manage staged MARC records and click on the filename you've just staged. 1) In the 'Citation' column, click on the hyperlink to launch the MARC preview -- notice how it fails to produce any output apart from the modal heading. 2) Apply the patch, and restart Plack if necessary. 3) Re-launch the MARC preview: this time the output should include the whole record, including the embedded item data in field 952. 4) Run the unit tests to ensure nothing was broken inadvertently: $ prove t $ prove xt Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit f7729a02547ec1b4e71b13c70757bb48ad622b51 Author: Andreas Roussos Date: Sun Mar 15 08:34:52 2020 +0100 Bug 24827: Standardise on 'UTF-8' as the encoding name This patch standardises the encoding name used in direct calls to new_from_xml() to 'UTF-8' instead of 'utf8' or 'utf-8'. Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 66742f6e705d5841c6559f346883bdc2f6ee1053 Author: Nick Clemens Date: Mon Mar 16 14:55:31 2020 +0000 Bug 24789: [follow-up] Fix saving of macros Saving was accidentally commented out in patches, this restores that To test: 1 - Create a new macro 2 - Add some content 3 - Reload the macro, no content 4 - Apply patch 5 - Repeat 6 - Macro saves/loads correctly Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit b58bb48b0b7401d010bb89bdaf7edbee1c6163ce Author: Nick Clemens Date: Tue Mar 3 13:26:02 2020 +0000 Bug 24789: Remove ITS macro format To test: 1 - Apply patches 2 - Confirm you can save, load, and run macros 3 - Confirm you have no choice of format Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: C4/Biblio.pm | 2 +- C4/ImportBatch.pm | 2 +- Koha/Biblio/Metadata.pm | 2 +- Koha/BiblioUtils/Iterator.pm | 2 +- .../2-Optionel}/sample_libraries.sql | 0 .../mysql/fr-FR/2-Optionel/sample_libraries.txt | 1 + .../intranet-tmpl/lib/koha/cateditor/macros.js | 6 +- .../intranet-tmpl/lib/koha/cateditor/macros/its.js | 208 --------------------- .../prog/en/includes/cateditor-ui.inc | 15 +- .../prog/en/modules/cataloguing/editor.tt | 1 - misc/batchRebuildBiblioTables.pl | 2 +- misc/migration_tools/build_oai_sets.pl | 2 +- opac/opac-readingrecord.pl | 2 +- svc/bib | 2 +- svc/import_bib | 2 +- svc/new_bib | 2 +- t/db_dependent/ImportBatch.t | 7 +- .../Koha/Z3950Responder/GenericSession.t | 8 +- t/db_dependent/Koha/Z3950Responder/ZebraSession.t | 4 +- 19 files changed, 25 insertions(+), 245 deletions(-) copy installer/data/mysql/{de-DE/optional => fr-FR/2-Optionel}/sample_libraries.sql (100%) create mode 100644 installer/data/mysql/fr-FR/2-Optionel/sample_libraries.txt delete mode 100644 koha-tmpl/intranet-tmpl/lib/koha/cateditor/macros/its.js hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 3 21:05:24 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Apr 2020 19:05:24 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.04-87-gd4db0b96e8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via d4db0b96e8753b1b213b6a2efeea7a61baf0ac7e (commit) via d5e9dc31ca66cff586125d1bbcff8de8bc089387 (commit) via ba69672acec227e4d13d61d7a24fa41533cf6385 (commit) via 29941cd761cae087d0ac44b66e247635816a5352 (commit) from 2244ed80725a91d101d1796ab118d4fccc5ff61e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d4db0b96e8753b1b213b6a2efeea7a61baf0ac7e Author: Jonathan Druart Date: Wed Mar 18 13:43:52 2020 +0100 Bug 24200: (follow-up) Try to fix random failures from Borrower_PrevCheckout.t 2 other occurrences where missing. Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit d5e9dc31ca66cff586125d1bbcff8de8bc089387 Author: Jonathan Druart Date: Fri Jan 10 11:48:09 2020 +0100 Bug 24200: Try to fix random failures from Borrower_PrevCheckout.t It failed inconsistently, let's try to use build_sample_item and see if it fixes the random failures. Test plan: % prove t/db_dependent/Patron/Borrower_PrevCheckout.t must return green Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit ba69672acec227e4d13d61d7a24fa41533cf6385 Author: Lucas Gass Date: Fri Jan 17 22:12:11 2020 +0000 Bug 24456: change default sort orders/make wording clearer TEST PLAN: 1. Apply patch 2. Have some checkout from today and some from multiple previous days. 3. Set todaysIssuesDefaultSortOrder & previousIssuesDefaultSortOrder to 'earliest to latest' and confirm it sorts correctly. 4. Reverse the 2 system preferences and see that it is now sorting the opposite way. 5. Also look at the wording of each system prefence and make sure it makes sense Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 29941cd761cae087d0ac44b66e247635816a5352 Author: Caroline Cyr La Rose Date: Wed Feb 12 14:32:01 2020 -0500 Bug 23236: Remove 'its items may still be processed' in action if no match is found When importing records and looking for duplicate records using record matching rules, there is an option if NO match is found to "ignore incoming record (its items may still be processed)". This doesn't make any sense. Where would the items go if there is no match? To test: 1) Go to Tools > Stage MARC for import 2) Browse and choose a file with at least one record that is not already in your catalog and click on Upload file 3) Fill out the first section with the appropriate information 4) In the Look for existing records in catalog? section, choose a record matching rule 5) In the Action if no match is found drop-down menu, choose Ignore incoming record (its items may still be processed) 6) Click on Stage for import 7) Click on Manage staged records 8) Click Import this batch in the catalog 9) In the table, the record status should say Ignore 10) Apply patch 11) Redo steps 1-9, notice the option Ignore incoming records does not mention items 12) Make sure the tool still works and still ignores the record Signed-off-by: Devinim Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: .../prog/en/includes/tools-nomatch-action.inc | 2 +- .../en/modules/admin/preferences/circulation.pref | 2 +- svc/checkouts | 4 +-- t/db_dependent/Patron/Borrower_PrevCheckout.t | 32 ++++------------------ 4 files changed, 9 insertions(+), 31 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 3 22:10:30 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Apr 2020 20:10:30 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.04-91-g481d51c51c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 481d51c51c71ba41fc518cc52ba6aec777e3332c (commit) via f30e320adc217473f2a01cc211ecabe81e866395 (commit) via 23724c9c7410c0f8b432cfd8019b30753a672d5b (commit) via 5550da8a50dbb60fcad6ea2a43658938d1200803 (commit) from d4db0b96e8753b1b213b6a2efeea7a61baf0ac7e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 481d51c51c71ba41fc518cc52ba6aec777e3332c Author: Owen Leonard Date: Tue Dec 17 15:19:56 2019 +0000 Bug 7882: (follow-up) Only show sortable icon for sortable tags Only tags which can be repeated can be sorted, so the "bars" icon should not display by these tags. Signed-off-by: Maryse Simard Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit f30e320adc217473f2a01cc211ecabe81e866395 Author: Owen Leonard Date: Mon Dec 16 19:06:57 2019 +0000 Bug 7882: (follow-up) Update sorting interaction This follow-up modifies the CSS for the sortable fields so that a different icon is used. Elsewhere in Koha (stock rotation stage sorting) we use the "bars" icon to indicate a sortable element. I think it would be good to continue to use this. The cursor is now styled as a "Move" cursor. The configuration of the sortable function in the script has been updated in two ways: 1. The movement of the element is constrained along the y-axis, and 2. The movement of the element is contstrained to the container within which it can be moved (for the tag, the tab, and for the subfield, the tag). To test, apply the patch and edit a MARC record in the basic cataloging editor. Confirm that the new icon is used, and that the "Move" cursor shows when you hover over the icon. Confirm that a tag can be dragged up and down within the constraints of the visible section. A subfield should be only movable within its parent tag. Signed-off-by: Maryse Simard Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 23724c9c7410c0f8b432cfd8019b30753a672d5b Author: Maryse Simard Date: Wed Oct 23 15:34:39 2019 -0400 Bug 7882: Add ability to move and reorder fields in MARC editor Use jQueryUI sortable to make fields and subfields moveable in the MARC editor for both records and authorities. This patch convert items from div's to ul's and consequently alter css and js to match. It also replace the up arrow with a more adapted icon (from font awesome). Primary authorship by Elliott Davis. To Test: 1. Add or edit a record in cataloguing module. 2. You should be able to move the fields and subfields around. - You can click on any part of the element to drag it, the move icon to the left of the item is a good place to do it. => You can only change the order of fields of the same tag. 3. Make sure all of the javascript driven fonctionnality still work : - Duplicate fields/subfields - Remove fields/subfields - Using the tag editor for control fields or to link authorities - etc 4. Reorder some fields/subfields and save the record. 5. Edit the record again. 6. The order in the editor should match the changes which were saved. - Empty subfields should appear after the ones with content. 7. Repeat steps 1-6 with the authority editor. Signed-off-by: Séverine QUEUNE Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 5550da8a50dbb60fcad6ea2a43658938d1200803 Author: Jonathan Druart Date: Mon Mar 30 16:11:51 2020 +0200 Bug 25020: Preserve time part when batch extending due dates When selecting a new hard due date, we should keep the time part of the original checkouts. Test plan: 1 - Checkout an item specifying a date due 2 - Checkout an item without specifying a date due 3 - Use Tools->Batch extend due date 4 - Select a hard due date 5 - On the confirmation screen you should see that the time part has been kept 6 - Confirm 7 - Make sure the correct values hava been inserted in DB 8 - Try now using the other option, give a number of days 9 - Repeat 4-7 Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: cataloguing/addbiblio.pl | 2 +- koha-tmpl/intranet-tmpl/prog/css/addbiblio.css | 63 +++++++++++++++++++-- .../prog/en/modules/authorities/authorities.tt | 28 +++++---- .../authorities/blinddetail-biblio-search.tt | 6 +- .../prog/en/modules/cataloguing/addbiblio.tt | 42 ++++++++++---- .../en/modules/tools/batch_extend_due_dates.tt | 6 +- koha-tmpl/intranet-tmpl/prog/img/up.png | Bin 362 -> 0 bytes koha-tmpl/intranet-tmpl/prog/js/cataloging.js | 52 +++++++---------- tools/batch_extend_due_dates.pl | 47 ++++++++++++--- 9 files changed, 174 insertions(+), 72 deletions(-) delete mode 100644 koha-tmpl/intranet-tmpl/prog/img/up.png hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 3 22:31:55 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Apr 2020 20:31:55 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.04-92-g09b8c38a82 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 09b8c38a8264c55ae5e7187cb76e608a072729fd (commit) from 481d51c51c71ba41fc518cc52ba6aec777e3332c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 09b8c38a8264c55ae5e7187cb76e608a072729fd Author: Marcel de Rooy Date: Mon Mar 2 11:08:18 2020 +0000 Bug 24756: [19.11.X] Catch two failed to load-variations in Security.t Test 7 in Security.t failed when 'failed to load HTTP resource' was returned by libxml2 instead of 'failed to load external entity'. We now remove the debugging with Dumper again and adjust the regex to include both variations. Signed-off-by: Marcel de Rooy Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: t/db_dependent/Koha/XSLT/Security.t | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 3 22:49:55 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Apr 2020 20:49:55 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.04-98-g93e881a725 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 93e881a7253a8ace8163ae522b80d0338fb003ca (commit) via 9b0177fa39ab83fdb19fcc86e4b15689671c5e9f (commit) via c4a54d8e8afca37bfeb2531cf3d66695da3d6a98 (commit) via f32ccbf2d73229a204dc002f4513e32ea85a11cb (commit) via 58590b9ac722685b5a050da367be2e76145e48c7 (commit) via dff8f391c87192a08995b6596a4cfb744e1efc31 (commit) from 09b8c38a8264c55ae5e7187cb76e608a072729fd (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 93e881a7253a8ace8163ae522b80d0338fb003ca Author: Katrin Fischer Date: Sat Feb 29 23:36:46 2020 +0100 Bug 15775: Change wording slightly maxoutstanding only blocks holds, for checkouts we got noissuechage. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 9b0177fa39ab83fdb19fcc86e4b15689671c5e9f Author: Aleisha Amohia Date: Thu Feb 6 22:25:06 2020 +0000 Bug 15775: Show message on OPAC summary if holds are blocked due to fines To test: 1) Set maxoutstanding syspref to 5 2) Create a manual invoice for a borrower for $6 3) Log in to the OPAC as this borrower 4) Go to opac-user.pl, your summary page 5) Confirm there is a warning box explaining that the borrower is blocked from holds due to fines 6) Back on the staff side, pay some or all of the borrower's fines so they are no longer over the max outstanding amount 7) Refresh the summary page in the OPAC and confirm the warning is gone Sponsored-by: Catalyst IT Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit c4a54d8e8afca37bfeb2531cf3d66695da3d6a98 Author: Aleisha Amohia Date: Wed Mar 11 03:38:44 2020 +0000 Bug 24844: Focus syspref searchbar To test: 1) Go to Administration 2) Notice neither of the syspref search bars are focussed so you have to click inside one to begin searching 3) Apply patch and refresh page 4) Notice the header syspref search bar is now focussed so you can begin typing straight away Sponsored-by: Catalyst IT Signed-off-by: Sally Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit f32ccbf2d73229a204dc002f4513e32ea85a11cb Author: Fridolin Somers Date: Wed Mar 11 14:00:21 2020 +0300 Bug 24847: Select AND by default in items search In items search form, when clicking on "New field" a new conjunction and search field are added. It would save time to select AND conjunction by default, like it is in advanced search. Test plan: 1) Go to items search 2) Click on "New field" 3) Check that AND is selected Signed-off-by: Sally Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 58590b9ac722685b5a050da367be2e76145e48c7 Author: Andrew Isherwood Date: Mon Jan 27 12:00:47 2020 +0000 Bug 24518: Fix IE11 partner filtering This patch adopts the approach detailed in comment #1. It also fixes a couple of additional minor bugs relating to the ILL partner list: - Exclude partners with no email address, we cannot use them - Quote the "value" attribute to avoid warnings displayed by IE, they should be quoted anyway! Test plan: USE IE11 - Apply the patch - Define 3 ILL partner patrons (patrons in the category that has a code that matches the value in the ILL config). One patron should have no email address, the other two should have an email address - Navigate to "Place request with partners" for an ILL request - TEST: Observe that the patron with no email address is not displayed - Try filtering the list - TEST: Observe that the list filters correctly Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit dff8f391c87192a08995b6596a4cfb744e1efc31 Author: Fridolin Somers Date: Fri Sep 8 17:20:38 2017 +0200 Bug 19279: performance of linked items in search When catalog has fields 773 (461 in UNIMARC), those linked items are fetched for display in search results. Looks like the code could be more performant by replacing item search by $9 with direct call with GetMarcItem(). Test plan : 1) Enable system preference EasyAnalyticalRecords 2) Get a record A with a lot of items, it will be the 'Host record' 3) Click on 'Analytics' on this record 4) On one of its items (say item A1) click on 'Create analytics' to create record B 5) Enter the same title as record A and all mandatory fields 6) Edit field 773 (461 in UNIMARC) 6) Check that $0 contains the biblionumber of record A 7) Check that $9 contains the itemnumber of item A1 8) Perform a search on record A title, be sure you see record B with other results => Compare execution times with and without patch Signed-off-by: Hugo Agud Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: C4/Search.pm | 17 +++++------------ .../intranet-tmpl/prog/en/modules/admin/admin-home.tt | 8 ++++++++ .../prog/en/modules/catalogue/itemsearch.tt | 2 +- .../intranet-tmpl/prog/en/modules/ill/ill-requests.tt | 8 +++++--- koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js | 12 +++++++----- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt | 6 ++++++ opac/opac-user.pl | 5 +++++ 7 files changed, 37 insertions(+), 21 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 3 23:04:04 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Apr 2020 21:04:04 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.04-102-ga609803360 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via a609803360556459a092067e98a0ca71c5a6797c (commit) via a8fb7067706344a14da37efb4bf1f6b078e80670 (commit) via 673129ebf89616185d133d9354487e8d8e32d2ef (commit) via 161feda3dda4a8d11872757a84f829934cce0a8e (commit) from 93e881a7253a8ace8163ae522b80d0338fb003ca (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a609803360556459a092067e98a0ca71c5a6797c Author: Jonathan Druart Date: Mon Mar 16 12:16:27 2020 +0100 Bug 24510: Add missing filter Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit a8fb7067706344a14da37efb4bf1f6b078e80670 Author: Jonathan Druart Date: Wed Feb 26 17:38:53 2020 +0100 Bug 24510: Code cleaning Additional test plan: Create 3 clubs: abc adf axy place a hold for on of those club, search for a club 'a' you will get the focus on the "Clubs" tab Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 673129ebf89616185d133d9354487e8d8e32d2ef Author: Owen Leonard Date: Wed Feb 26 15:53:48 2020 +0000 Bug 24510: When Placing a Hold, cursor doesn't focus on Patron Name This alternate patch tries to implement a fix in a more "correct" way by tying the cursor focus to the initialization of the jQueryUI tabs. By configuring both the "create" and "activate" events we can make sure the correct input field is focused. I think the only advantage of this patch over the other one is that tying the focus to the tabs activation makes it a little more obvious where in the DOM loading sequence the focus is being set. To test, follow the original patch's test plan: TEST PLAN: 1. Go to Biblio Record 2. Place Hold (request.pl) - either the Hold above the Bib or the Hold on the left, it does the same thing. 3. Note that the cursor does not go to Patron Name (for whom to place the hold for), it goes to the Top Search bar under Checkout. 4. Apply patch and reload the page. 5. The focus should now be correctly set. 6. Toggle between 'Patrons' and 'Club' tabs. 7. Focus should stay set. Signed-off-by: Lucas Gass Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 161feda3dda4a8d11872757a84f829934cce0a8e Author: Lucas Gass Date: Fri Jan 24 15:34:07 2020 +0000 Bug 24510: Add focus to Patron/club input Signed-off-by: Kelly McElligott Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/reserve/request.tt | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 3 23:19:38 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Apr 2020 21:19:38 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.04-107-g77d9b7e799 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 77d9b7e79995ec0acfc11ba290d5c990417778d9 (commit) via 152d15f6deb7d00b865bfde31e7462b7a39c29ad (commit) via c2307c1e98492684b6a879762581c746dd7e5f50 (commit) via 25a00e828dfda520cf39c7aca219a028196958de (commit) via 1adc4986e9d2f715f44ef4b99b5dece79845f885 (commit) from a609803360556459a092067e98a0ca71c5a6797c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 77d9b7e79995ec0acfc11ba290d5c990417778d9 Author: Kyle M Hall Date: Mon Feb 3 07:56:37 2020 -0500 Bug 24566: UpdateItemLocationOnCheckin triggers SIP2 alert flag, even with checked_in_ok enabled If UpdateItemLocationOnCheckin, it triggers an alert flag but cannot be acted on in the same way as LocalUse and thus should be removed in the same fashion. Test Plan: 1) Enable UpdateItemLocationOnCheckin and set it up to trigger at checkin for an item 2) Return that item via SIP2 3) Note the alert flag is set 4) Apply this patch 5) Repeat steps 1 and 2 6) The alert flag should not be set Signed-off-by: Kyle M Hall Signed-off-by: Kevin Cook Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 152d15f6deb7d00b865bfde31e7462b7a39c29ad Author: Martin Renvoize Date: Thu Mar 19 08:10:00 2020 +0000 Bug 24901: Add tests for transferbook Test plan: 0/ Read the commit and confirm the new tests make sence 1/ Run the tests and verify they pass 2/ Signoff Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit c2307c1e98492684b6a879762581c746dd7e5f50 Author: Martin Renvoize Date: Wed Mar 18 19:25:57 2020 +0000 Bug 24901: Minor refactor of tests Test plan: 0/ Read the change and verify it makes sense Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 25a00e828dfda520cf39c7aca219a028196958de Author: Jonathan Druart Date: Thu Mar 12 10:01:10 2020 +0100 Bug 24856: Remove itemtypes.imageurl in fr-FR sample data in installer/data/mysql/fr-FR/3-LecturePub/sample_itemtypes.sql and installer/data/mysql/fr-FR/4-Conservation/sample_itemtypes.sql the values of imageurl point to non-existent images. Test plan: Insert the 2 sql file and confirm that imageurl is not empty Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 1adc4986e9d2f715f44ef4b99b5dece79845f885 Author: Bernardo Gonzalez Kriegel Date: Sat Mar 14 21:00:24 2020 -0300 Bug 24870: Translate installer data label This patch enable the translation of the labels 'Mandatory' or 'Optional' present at install time for groups of installer files. To test: 1) Try install using de-DE language, at step3 verify 'Mandatory' and 'Optional' labels for marc21 or other data checklist Do not close this window! 2) Apply this patch 3) Update de-DE translation files, reinstall lang files cd misc/translator ./translate update de-DE ./translate install de-DE 4) Reload page at step3, now 'Mandatory' label is translated to 'Pflichtfeld' 5) Verify strings in translation file Search for ^msgid \"Mandatory\" ^msgid \"Optional\" in po/de-DE-staff-prog.po. Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: C4/Installer.pm | 4 +- C4/SIP/ILS/Transaction/Checkin.pm | 1 + .../mysql/fr-FR/3-LecturePub/sample_itemtypes.sql | 24 ++-- .../fr-FR/4-Conservation/sample_itemtypes.sql | 18 +-- .../prog/en/modules/installer/step3.tt | 10 +- t/db_dependent/Circulation/transferbook.t | 134 +++++++++++++++++++-- 6 files changed, 156 insertions(+), 35 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 3 23:28:51 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Apr 2020 21:28:51 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.04-111-g64d8beafa8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 64d8beafa8b5745c5ca2e63fddaf2177246ce937 (commit) via 268a62a6d2f8c6b3fe1a07033b533b31fc88db33 (commit) via ca4f14180b90bab2e8185e919a87657c6fba0e2f (commit) via 839e11eefd01c6e5bf36effaef09028c443ed386 (commit) from 77d9b7e79995ec0acfc11ba290d5c990417778d9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 64d8beafa8b5745c5ca2e63fddaf2177246ce937 Author: Nick Clemens Date: Thu Aug 1 14:57:29 2019 +0000 Bug 23411: Do not fall back to 'email' for SMS messages To test: 1 - Have a patron wiht an sms number, but no email 2 - Enable sms by setting SMSDriver syspref to Email 3 - Set Notice triggers to send an overdue via sms and email 4 - Ensure the selected notice is defined only for 'email' 5 - Checkout an overdue to the patron above You can set a specify a due date in the past 6 - perl misc/cronjobs/overdue_notices.pl -t 7 - Check the patron notices tab, they have a print notice and an SMS notice pending 8 - The SMS notice used the 'email' template 9 - Apply patch 10 - sudo koha-mysql kohadev 11 - DELETE * FROM message_queue WHERE borrowernumber={borrower as above}; 12 - Run the cron again 13 - Patron should have a print notice queued, no sms 14 - Define an SMS notice 15 - delete the message queue 16 - Run again 17 - The patron should have a print and an SMS Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 268a62a6d2f8c6b3fe1a07033b533b31fc88db33 Author: Jonathan Druart Date: Tue Dec 17 11:31:40 2019 +0100 Bug 24250: Do not duplicate debarred comment in patron screen message AF field Caused by commit bddfed75913a2302c19c00b00a6fe86538af6f9f Bug 19933: Remove patronflags - tricky ones Test plan: 1 - Setup SIP in your testing environment https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup 2 - Set a patron to have a restriction 3 - Send a patron status request or patron information command via the SIP cli emulator (see link above) 4 - Note the comment on the restriction is sent only once Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit ca4f14180b90bab2e8185e919a87657c6fba0e2f Author: Jonathan Druart Date: Wed Feb 26 12:51:06 2020 +0100 Bug 23900: Add tests Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 839e11eefd01c6e5bf36effaef09028c443ed386 Author: Jonathan Druart Date: Mon Nov 11 17:54:56 2019 +0100 Bug 23900: Teach label maker to concat database fields Test plan: - define a label layout with this field list: "100a 245s","enumchron copynumber" - find or create a record with values for all of those fields - generate a label for that record - the 100a and 245s successfully display on one line - the enumchron and copynumber are displayed and separated by a space Try other combinations Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: C4/Labels/Label.pm | 13 +++++++++---- C4/SIP/ILS/Patron.pm | 2 +- misc/cronjobs/overdue_notices.pl | 4 ++-- t/db_dependent/Labels/t_Label.t | 37 ++++++++++++++++++++++--------------- 4 files changed, 34 insertions(+), 22 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 3 23:34:52 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Apr 2020 21:34:52 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.04-113-g5995321205 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 59953212052ad480cb76de8946175b3602f7942f (commit) via 2cff3403604f2a01d32032fbc386f2ebbf5c8b87 (commit) from 64d8beafa8b5745c5ca2e63fddaf2177246ce937 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 59953212052ad480cb76de8946175b3602f7942f Author: Aleisha Amohia Date: Tue Feb 25 02:02:22 2020 +0000 Bug 8595: (follow-up) Changing other occurrences of 'host item' to 'host record' Signed-off-by: Michal Denar Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 2cff3403604f2a01d32032fbc386f2ebbf5c8b87 Author: Aleisha Amohia Date: Thu Feb 13 21:23:58 2020 +0000 Bug 8595: Rename 'host item' to 'host record' To test: 1) Enable the syspref EasyAnalyticalRecords 2) Find a biblio record, go to the detail page 3) Click the Edit dropdown and notice the option "Link to host item" 4) Apply patch and refresh page 5) Click the Edit dropdown and confirm the renamed "Link to host record" button Sponsored-by: Catalyst IT Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Michal Denar Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/linkitem.tt | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 3 23:46:34 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Apr 2020 21:46:34 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.04-120-gb17c16f910 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via b17c16f9106eb159a1690da80a2a46b1f3a165ab (commit) via 44d91396128a38a29b21f643f2e6439383a03e5c (commit) via cda91af335a163b9e1d12c2aac57ec46b24ddea4 (commit) via abb8865d75df361de6cbbd812613d4761f837771 (commit) via 1f1ab3842371858ff5e76a721216a686684fd99d (commit) via 78f10451101b38bb160bb50941f377f5c41ea49e (commit) via 32e0e6dafd484f8f92239b1eaf8bc837681189dc (commit) from 59953212052ad480cb76de8946175b3602f7942f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b17c16f9106eb159a1690da80a2a46b1f3a165ab Author: Aleisha Amohia Date: Thu Feb 20 01:36:32 2020 +0000 Bug 24688: Check the priority of the fulfilled hold when fixing priorities Currently when fixing priorities of existing holds, priorities aren't fixed when checking out a middle priority hold because the hold has been fulfilled and deleted. This patch adds a check for, if the hold can't be found, an old hold with the required reserve_id. To test: 1. Place at least four holds on a biblio for different borrowers 2. Check out an item to the 3rd priority borrower 3. Check the existing holds table for the biblio. The priorities might be out of order, or try clicking the dropdowns and there might be an empty dropdown option, or open the browser developer tools and notice the option values in the select are missing value=3. 4. Apply patch and restart memcached 5. Check out an item to the 2nd priority borrower 6. Check the existing holds table for the biblio. Confirm the priorities have been fixed and are now consecutive with no gaps. Sponsored-by: Chartered Accountants Australia and New Zealand Signed-off-by: Emmi Takkinen Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 44d91396128a38a29b21f643f2e6439383a03e5c Author: Marcel de Rooy Date: Wed Mar 18 13:54:52 2020 +0000 Bug 24892: Resolve uninitialized warns from opac-memberentry Especially line 500 (current master). Use of uninitialized value $new_data{"sort2"} in string eq at /usr/share/koha/opac/opac-memberentry.pl line 500. Use of uninitialized value in string eq at /usr/share/koha/opac/opac-memberentry.pl line 500. Simple fix, not completely trivial due to adding xor ;) Test plan: Do not apply, update from opac memberentry. Check warns in log. Apply patch, update again. Less warns? Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit cda91af335a163b9e1d12c2aac57ec46b24ddea4 Author: Katrin Fischer Date: Fri Mar 13 17:40:38 2020 +0000 Bug 24848: Improve manual links for the label creator Some of the manual links in the label creator tool were not working correctly or pointing to the wrong pages. A problem is the label-manage.pl file. This can show different data depending on an added parameter. Example: /cgi-bin/koha/labels/label-manage.pl?label_element=template But it appears that parameters will be ignored when creating links to the manual. So this patch links to the beginning of the label creator section in the manual for now. To test: - Go to the lable creator - Try the various pages of the tool - Note: All 'New ...' links should point to the correct section in the manual (batches, templates, ...) Except: Barcode range. This feature is new and not yet documented in the manual. Link goes to label creator section. - Note: All 'Manage ...' links should point to the beginning of the 'label creator' section in the manual Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit abb8865d75df361de6cbbd812613d4761f837771 Author: Nick Clemens Date: Tue Feb 25 14:42:29 2020 +0000 Bug 24553: Use 'barcode' not 'item_id' when removing hold from SIP patron The drop_hold routine was using the wrong parameter for item info in the patron's array of holds. We store it as 'barcode' not 'item_id'. This is true for both waiting and unavailable holds To test: 1 - Apply unit tests patch 2 - prove -v t/db_dependent/SIP/ILS.t 3 - It fails 4 - Apply second patch 5 - prove -v t/db_dependent/SIP/ILS.t 6 - It passes! You can also see bug 24175 - you cna hack sip_cli_emulator to allow cancelling a hold and check the messages, test coverage is improved by this patch and should be sufficient for testing Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 1f1ab3842371858ff5e76a721216a686684fd99d Author: Nick Clemens Date: Tue Feb 25 14:42:17 2020 +0000 Bug 24553: Unit tests Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 78f10451101b38bb160bb50941f377f5c41ea49e Author: Jonathan Druart Date: Mon Mar 16 15:43:49 2020 +0100 Bug 22025: Remove warnings when importing patrons The following warning is raised when importing patrons Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018 if one of the following headers is passed but does not have a value: * privacy * privacy_guarantor_fines * privacy_guarantor_checkouts * anonymized Test plan: - Do not apply the patch - Generated a csv file with at least one those headers - Import it using the import_patrons.pl script (or using the GUI) - Notice the warnings without the patch - Apply the patch - Confirm that the warnings do not longer appear Signed-off-by: Magnus Enger Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 32e0e6dafd484f8f92239b1eaf8bc837681189dc Author: Jonathan Druart Date: Mon Mar 16 15:43:38 2020 +0100 Bug 22025: Add a regression test Signed-off-by: Magnus Enger Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: C4/Reserves.pm | 4 +++ C4/SIP/ILS/Patron.pm | 2 +- Koha/Manual.pm | 16 ++++----- Koha/Patrons/Import.pm | 9 +++++ opac/opac-memberentry.pl | 3 +- t/db_dependent/Koha/Patrons/Import.t | 7 ++-- t/db_dependent/SIP/ILS.t | 69 +++++++++++++++++++++++++++++++++++- 7 files changed, 96 insertions(+), 14 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 3 23:58:01 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Apr 2020 21:58:01 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.04-125-gcd78e5cb18 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via cd78e5cb18a27d7ded9ef1c03f36fdc2bb97a417 (commit) via 6cb9b3634dcc06bdd69b82960a257f38fd75e0d0 (commit) via ca2ebddb1386665a3332ac67f7b5ce971a828c90 (commit) via b713241845e8f730b46c756fa65c4ddd17ed746b (commit) via 554391e56a4bf774283653f98fc24608cd9186e2 (commit) from b17c16f9106eb159a1690da80a2a46b1f3a165ab (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit cd78e5cb18a27d7ded9ef1c03f36fdc2bb97a417 Author: Katrin Fischer Date: Sun Mar 22 12:10:43 2020 +0100 Bug 24876: Fix capitalization on patron search for holds When placing a hold in the staff interface, the heading on the search box reads: Search Patrons or clubs The patch changes it to be Search patrons... instead. Also changes club id to club ID. To test: - Place a hold in the staff interface - Verify the capitalization error - Switch tabs to Clubs, see: club id - Apply patch - Verify it's all good now Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 6cb9b3634dcc06bdd69b82960a257f38fd75e0d0 Author: Marcel de Rooy Date: Tue Mar 10 15:11:07 2020 +0000 Bug 21708: Sort MARC fields in TransformHtmlToMarc Instead of pushing 999 in the front :) Test plan: Do not yet apply this patch. Edit a record. Save. And open MARC view/view plain on opac-detail. Verify that the biblionumber field (MARC21 999) follows leader. Apply this patch. Restart Plack. Edit a record. Save. And open MARC view/view plain on opac-detail. Verify that the biblionumber field is in right position. Run t/db_dependent/Biblio/TransformHtmlToMarc.t. Should pass now. Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit ca2ebddb1386665a3332ac67f7b5ce971a828c90 Author: Marcel de Rooy Date: Wed Mar 11 13:22:31 2020 +0000 Bug 21708: Add a few tests in TransformHtmlToMarc.t Test plan: Run t/db_dependent/Biblio/TransformHtmlToMarc.t without the module change patch. Verify that the test fails on the order of fields. Go to test plan of the second patch. Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit b713241845e8f730b46c756fa65c4ddd17ed746b Author: Liz Rea Date: Fri Jan 3 21:18:27 2020 +0000 Bug 24324: Resolve error with delete_records_via_leader.pl To test: Have a record with the 000 position 5 set to "deleted" (record status) Use koha-shell to run the job with the -i flag: perl misc/cronjobs/delete_records_via_leader.pl -c -i -v * items and the record should be deleted Mark another record with the 000 position 5 set to deleted (record status) Use koha-shell to run the job without the -i flag: perl misc/cronjobs/delete_records_via_leader.pl -c -v * if the record had items, it will not be deleted * if the record did not have items, it will be deleted. Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 554391e56a4bf774283653f98fc24608cd9186e2 Author: Julian Maurice Date: Thu Mar 19 09:38:52 2020 +0100 Bug 24902: Join different mc- limits with AND (elasticsearch) In the advanced search form, you can enable several limits using syspref AdvancedSearchTypes (namely itemtypes, shelving locations, collections) When used, the resulting query parts end up being joined with OR, even if the field is different. That means that if you pick "Book" under itemtypes tab, and "Fiction" under collection tab, it will search "itype:BOOK OR ccode:FIC". It should be AND. For instance, if you select: Itemtypes: ✓ Book ✓ DVD Location: ✓ Child ✓ Adult it should search: itype:(Book OR DVD) AND location:(Child OR Adult) Test plan: 0. Do not apply the patch yet 1. Enable elasticsearch 2. Set syspref AdvancedSearchTypes = 'itemtypes|loc|ccode' 3. Create a new itemtype and a new authorised value for categories LOC and CCODE 4. Create a biblio with the new itemtype, another biblio with the new location, another biblio with the new collection, and again another biblio with the new itemtype, location and collection 5. Verify that you can find these new biblio records using only the "advanced search types" in the advanced search form 6. In the advanced search form, pick all 3 limits (itemtype, location, collection) and verify that it returns the 4 records. 7. Apply the patch 8. Repeat step 6, it should now return only the biblio that satisfies all criteria 9. Verify that if you select more than one {itemtype|location|collection} it still returns results that satisfies any selected criteria 10. prove t/Koha/SearchEngine/ElasticSearch/QueryBuilder.t Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: C4/Biblio.pm | 1 + Koha/SearchEngine/Elasticsearch/QueryBuilder.pm | 26 +++++++----- .../prog/en/modules/reserve/request.tt | 4 +- misc/cronjobs/delete_records_via_leader.pl | 6 +-- t/Koha/SearchEngine/ElasticSearch/QueryBuilder.t | 31 ++++++++++++++- t/db_dependent/Biblio/TransformHtmlToMarc.t | 46 ++++++++++++++++++++-- 6 files changed, 95 insertions(+), 19 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat Apr 4 00:09:52 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Apr 2020 22:09:52 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.04-129-ga6f8e2412d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via a6f8e2412d76536ae14bf2c3eba74bb556fee399 (commit) via cdc1ae5aea82c92dd1a7915708366ac21dfc1182 (commit) via 6705ca9d4ee0d32c7808ee7aba30ffa744625ef1 (commit) via 86799ff8ce364d4c8642b08ce447f05d2b8bb940 (commit) from cd78e5cb18a27d7ded9ef1c03f36fdc2bb97a417 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a6f8e2412d76536ae14bf2c3eba74bb556fee399 Author: Katrin Fischer Date: Thu Aug 15 10:59:46 2019 +0000 Bug 23409: (follow-up) Allow HTML in circulation note and add line breaks in OPAC user account This patch makes 2 changes: - bug 22702 allowed adding HTML to the circulation note, so this patch restores that ability. - display OPAC note and messages as multi-line in OPAC To test: - Add a circulation and an OPAC note with line breaks and HTML tags to the patron account - Add a message with line breaks to the patron account - Check line breaks don't show on - OPAC > patron account > my summary page - Staff > patron account > details - Apply patches - Repeat test Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit cdc1ae5aea82c92dd1a7915708366ac21dfc1182 Author: Alex Arnaud Date: Thu Aug 1 14:48:31 2019 +0200 Bug 23409: show borrowernotes and opacnote's lines feeds Test plan: - Fill borrowernotes and opacnote with lines separated by lines endings, - save and check the content is displayed on a single line, - apply this patch, - check lines endings are displayed Signed-off-by: Katrin Fischer Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 6705ca9d4ee0d32c7808ee7aba30ffa744625ef1 Author: Bernardo Gonzalez Kriegel Date: Sun Mar 15 11:39:42 2020 -0300 Bug 24872: Set languages prefererences after install This patch set 'languages' and 'opaclanguages' system preferences with the language used during install. To test: 1. Apply the patch 2. Do a clean install in a language other than english 3. Verify that 'languages' and 'opaclanguages' system preferences show the language code used during install, besides english. Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 86799ff8ce364d4c8642b08ce447f05d2b8bb940 Author: Mason James Date: Thu Mar 19 20:41:00 2020 +1300 Bug 24874: Printing is broken on opac-results.pl page (19.11.x) to test in 19.11.x... - search for something in opac - print page using file -> print - observe printing is broken (pic1) - apply patch - search for something in opac - print page using file -> print - observe printing is fixed (pic2) it seems this issue was introduced by bug 5287 Signed-off-by: Lucas Gass Signed-off-by: Owen Leonard Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: C4/Installer.pm | 26 ++++++++++++++++++++++ installer/install.pl | 5 +++++ .../prog/en/modules/members/moremember.tt | 8 +++---- koha-tmpl/opac-tmpl/bootstrap/css/src/print.scss | 7 +++++- .../opac-tmpl/bootstrap/en/includes/opac-note.inc | 4 ++-- 5 files changed, 43 insertions(+), 7 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat Apr 4 00:49:01 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Apr 2020 22:49:01 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.04-131-g88590cb678 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 88590cb6784d0b774f48aac9db491d0d32cf6d8a (commit) via b0568a67d12250d8ce32246492202d34e8a4117a (commit) from a6f8e2412d76536ae14bf2c3eba74bb556fee399 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 88590cb6784d0b774f48aac9db491d0d32cf6d8a Author: Katrin Fischer Date: Fri Mar 13 20:30:06 2020 +0000 Bug 24875: Remove extra punctuation from tools start page The patron clubs note was ending with .., but patch also removed some single . to be consistent with the majority of entries on the tools page. To test: - Check the tools start page for ending . in the notes - Apply patch - Verify the punctuation is now consistent Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit b0568a67d12250d8ce32246492202d34e8a4117a Author: Katrin Fischer Date: Fri Mar 13 20:52:24 2020 +0000 Bug 24877: Add link from vendor to linked subscriptions Koha shows the number of subscriptions linked to a vendor, but there is no way to look them up. This adds a link to the subscription search with the vendor name, so there is an easy way to find the subscriptions. To test: - Be superlibrarian or have serials permission - Make sure you have one or more subscriptions linked to vendors - Go to the vendor's detail page in acquisitions - Verify the number of subscriptions is now a link - Verify the search results are correct when clicking on it - Remove permissions (no serials, not superlibrarian) - Verify now the number shows, but is not linked Signed-off-by: Nazlı Çetin Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt | 8 +++++++- koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt | 10 +++++----- 2 files changed, 12 insertions(+), 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat Apr 4 01:07:32 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Apr 2020 23:07:32 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.04-135-g60c88bfa2f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 60c88bfa2f6c23c58ebd953eca2d0c29f6f2dee3 (commit) via 0a6c345703d46f4da4714dd5fa9ae673fab94ec6 (commit) via d3d27f48d8672a5d5f679647a7265ba1fd9bb11e (commit) via 8b3a134435471686c1564f2bc6ee6d3e187fdd06 (commit) from 88590cb6784d0b774f48aac9db491d0d32cf6d8a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 60c88bfa2f6c23c58ebd953eca2d0c29f6f2dee3 Author: Jonathan Druart Date: Fri Mar 27 17:09:27 2020 +0100 Bug 24614: Fix Reports/Guided.t DBD::mysql::st execute failed: Column 'public' cannot be null [for Statement "UPDATE `saved_sql` SET `last_modified` = ?, `notes` = ?, `public` = ?, `report_group` = ?, `report_name` = ?, `report_subgroup` = ?, `savedsql` = ? WHERE ( `id` = ? )" with ParamValues: 0='2020-03-27T16:03:04', 1=undef, 2=undef, 3=undef, 4='Just another report', 5=undef, 6=undef, 7=25] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. # Looks like you planned 17 tests but ran 6. update_sql expect all the paramters to be set, otherwise it will be nulled. The best way to fix it is at test level. There is only 1 occurrence in controller/module, and it sends all the parameters. That is the correct way to do and will make things easier when we will removed them to use Koha::Reports directly Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 0a6c345703d46f4da4714dd5fa9ae673fab94ec6 Author: Jonathan Druart Date: Tue Feb 11 17:21:38 2020 +0100 Bug 24614: Use Koha::Reports from save_report and update_sql In order to get the default value defined at DBMS level, we use Koha::Reports (to inherit from Koha::Object->store) from the 2 add/edit methods of C4::Reports::Guided. A second step would be to remove completely those CRUD subroutines and use directly Koha::Reports instead. Test plan: 1. Add and edit some reports 2. Disable memcached, create a report, edit it => Should not crash 3. Make sure the tests make sense and that they pass after the second patch. The error was: DBD::mysql::db do failed: Column 'cache_expiry' cannot be null [for Statement "UPDATE saved_sql SET savedsql = ?, last_modified = now(), report_name = ?, report_group = ?, report_subgroup = ?, notes = ?, cache_expiry = ?, public = ? WHERE id = ? "] at /kohadevbox/koha/C4/Reports/Guided.pm line 633. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit d3d27f48d8672a5d5f679647a7265ba1fd9bb11e Author: Jonathan Druart Date: Tue Feb 11 17:21:15 2020 +0100 Bug 24614: Add tests Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 8b3a134435471686c1564f2bc6ee6d3e187fdd06 Author: Kyle M Hall Date: Mon Mar 9 09:33:54 2020 -0400 Bug 24829: ClaimReturnedWarningThreshold is always triggered if patron has one or more claims ClaimReturnedWarningThreshold is supposed to display a warning if a patron has more than the number of claims specified in the system preference. Currently the warning is displayed for any number of claims over zero. Test Plan: 1) Make 3 return claims for a patron 2) Set ClaimReturnedWarningThreshold to 4 3) Note the claims warning displays for the patron on circulation.pl 4) Apply this patch 5) Reload circulation.pl, the warning should go away 6) Set ClaimReturnedWarningThreshold to 2 7) Reload the page, the warning should reappear Signed-off-by: Sally Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: C4/Reports/Guided.pm | 43 ++++++++++++++++------ .../prog/en/modules/circ/circulation.tt | 2 +- t/db_dependent/Reports/Guided.t | 6 ++- 3 files changed, 37 insertions(+), 14 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat Apr 4 01:18:42 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Apr 2020 23:18:42 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.04-138-g094d160842 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 094d160842bec43c2e29c1fb5a5e6f4e3f7ab502 (commit) via 57c0fe1ff428d3fe71239c6ed62f493b18437fb9 (commit) via e8b06fca16068d00093b476d31b90359bfdc5363 (commit) from 60c88bfa2f6c23c58ebd953eca2d0c29f6f2dee3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 094d160842bec43c2e29c1fb5a5e6f4e3f7ab502 Author: Kyle M Hall Date: Mon Mar 2 09:36:47 2020 -0500 Bug 24765: Updated on date in Claims returned starts off as 12/31/1969 When an item is claimed returned by staff, there is a column called Updated On - this date field column should remain blank until this claimed returned has been updated. Currently, when an item has been claimed returned, the date in the updated column states 12/31/1969. This date only shows up in the display, it is doesn't show up in the database like this. Test Plan: 1) Enable return claims 2) Make a claim 3) Note the 'updated on' column has the date 1969-12-31 4) Apply this patch 5) Reload the page ( you may need to clear your browser cache ) 6) Note the field is now blank Signed-off-by: Sally Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 57c0fe1ff428d3fe71239c6ed62f493b18437fb9 Author: Tomas Cohen Arazi Date: Thu Mar 19 10:51:40 2020 -0300 Bug 24905: Make installer update log4perl.conf for instances This patch makes koha-common.postinst check if the log4perl.conf files on the instances need tweaking. If they do, it appends the relevant configuration text. To test: 1. Install Koha 19.11 or earlier using the packages 2. Create an instance: $ koha-create --create-db test1 $ koha-create --create-db test2 => FAIL: /etc/koha/sites/test1/log4perl.conf doesn't include an entry for z39.50 3. Apply this patch and run: $ docker run \ --volume=/path/to/your/clone:/koha \ --volume=/dest/path/for/debs:/debs \ --privileged --env VERSION=19.12.00.047 \ koha/koha-dpkg:master Note: Paths need to be adjusted 4. Grab the .deb files and put them on the machine you're testing this 5. Edit /etc/koha/sites/test2/log4perl.conf and add the following text at the bottom: log4perl.logger.z3950 6. Install the debs: $ sudo dpkg -i koha-perldeps koha-deps koha-common => SUCCESS: Install process doesn't explode due to the addition => SUCCESS: /etc/koha/sites/test1/log4perl.conf has a new entry for log4perl.logger.z3950 => SUCCESS: /etc/koha/sites/test2/log4perl.conf doesn't have a new entry for log4perl.logger.z3950 7. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit e8b06fca16068d00093b476d31b90359bfdc5363 Author: Tomas Cohen Arazi Date: Thu Mar 19 09:47:25 2020 -0300 Bug 24905: Add missing entry in log4perl-site.conf.in Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: debian/koha-common.postinst | 28 ++++++++++++++++++++++++++++ debian/templates/log4perl-site.conf.in | 7 +++++++ koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 8 ++++++-- 3 files changed, 41 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat Apr 4 01:30:52 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Apr 2020 23:30:52 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.04-140-gcb7729c55d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via cb7729c55df1ac4197e9fcf92d42789ba3006bca (commit) via bf8ed831f83987eadd7de4455673da28877499f4 (commit) from 094d160842bec43c2e29c1fb5a5e6f4e3f7ab502 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit cb7729c55df1ac4197e9fcf92d42789ba3006bca Author: Nazlı Çetin Date: Fri Mar 27 12:25:46 2020 +0000 Bug 25000: SQL report not updated Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit bf8ed831f83987eadd7de4455673da28877499f4 Author: Nick Clemens Date: Thu Jan 9 15:53:45 2020 +0000 Bug 24386: Prevent double form submission on adding orders to basket from a file To test: 1 - Have a marc record file 2 - Go to Acquisitions, find a vendor, then an open basket 3 - Add to basket from a new file (if you already have one staged you can choose that instead) 4 - Import the file, then add to basket 5 - On the page where you select the records and set info select a record, set matching to 'Do not check' fill in the fund for the order 6 - When ready, click save as many times as you can 7 - When you go to the basket there are many copies of the order added 8 - Don't despair, apply the patch 9 - Repeat above 10 - When ready to add orders, click furiously 11 - The order is only added once! 12 - Success! Signed-off-by: Sally Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: C4/Reports/Guided.pm | 1 + koha-tmpl/intranet-tmpl/prog/js/addorderiso2709.js | 1 + 2 files changed, 2 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 6 12:05:13 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 06 Apr 2020 10:05:13 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1594-gf2efa1898d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via f2efa1898db8b4d8d73bbc99de95571815561750 (commit) from e065b86abd51f36340fa940ca211931e21689fad (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f2efa1898db8b4d8d73bbc99de95571815561750 Author: Martin Renvoize Date: Mon Apr 6 10:36:35 2020 +0100 Bug 24492: (RM follow-up) Varaible name corretion Bug 24492 was not correctly rebased after bug 23355 and did not account for a variable name change in the 'add_cashup' action. This patch deals with that. Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: pos/registers.pl | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 6 12:24:47 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 06 Apr 2020 10:24:47 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1603-g25fa93a406 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 25fa93a40683870c0e9c0fd96d839878aa2229c6 (commit) via 57333cda12111dd9582eabaa06069eda2dd154f5 (commit) via 7fe2c9147b6dd7a53969204586ca7b7460e30a05 (commit) via 27dd3feafde45c4a949d63829035885e995120f2 (commit) via 8cec8d548ce2924eaf4cc9a668ed7f9b7258460e (commit) via dd0d2fa1c99126de9942ca7802baf18a42c2680e (commit) via 8a56f176c083f7156584d07af7650162d13814e2 (commit) via 26d4b7fd5e35f784f951c4f9e9bb084a9f4612a4 (commit) via 93244efa3cbb66ff9e98d1eb4871da56a7565e5f (commit) from f2efa1898db8b4d8d73bbc99de95571815561750 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 25fa93a40683870c0e9c0fd96d839878aa2229c6 Author: Jonathan Druart Date: Mon Apr 6 11:44:18 2020 +0200 Bug 24964: Restore pagination for patrons for owner/users of funds admin/add_user_search.pl sets 'patrons_with_acq_perm_only', to only retrieve patrons with acq (order_manage) permissions. The original bug was hidden in the existing code, but the behavior was terrible. To prevent patrons matching the permissions contrainst to be hidden, we fetched ALL the patrons from the DB, then filtered them depending on their permissions. This might have awful performance on DB with lot of patrons. So basically with this patch we are adding the pagination back to the "owner/users for funds" feature, as the permission filtering is now done at DB level. Signed-off-by: Martin Renvoize commit 57333cda12111dd9582eabaa06069eda2dd154f5 Author: Martin Renvoize Date: Mon Apr 6 10:56:04 2020 +0100 Bug 4944: DBRev 19.12.00.064 Signed-off-by: Martin Renvoize commit 7fe2c9147b6dd7a53969204586ca7b7460e30a05 Author: Jonathan Druart Date: Tue Mar 31 14:45:14 2020 +0200 Bug 4944: Do not rely on the values from cache during the update DB process We never know, as we insert values direcly to the DB, the cache may not be correct. Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 27dd3feafde45c4a949d63829035885e995120f2 Author: Katrin Fischer Date: Fri Mar 27 06:00:29 2020 +0000 Bug 4944: Add OpacNoItemTypeImages system preference At the moment noItemTypeImages pref controls staff and OPAC display. With this patch, there will be a separate OpacNoItemTypes preference that allows to control display of each separately. To test: - Apply patch and run database update In Administration: - Search for 'noItemTypes' preferences - Verify the settings of both prefs match - Toggle prefs, verify everything works ok - Go to the item types configuration page - Try different settings for both prefs: - Both set to No: Only a message with a link to the prefs should show - Both set to Yes or either set to Yes: image configuration options should show In the OPAC: - Check the following pages with item-level_itypes = record - advanced search - detail page - place hold page - Check the following pages with item-level_itypes = item - result list - a list (opac-shelves) - checkouts and overdues tabs in patron account (Note: this didn't work right before, but will now.) - reading history in patron account Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 8cec8d548ce2924eaf4cc9a668ed7f9b7258460e Author: Martin Renvoize Date: Mon Apr 6 10:48:09 2020 +0100 Bug 22534: DBRev 19.12.00.063 Signed-off-by: Martin Renvoize commit dd0d2fa1c99126de9942ca7802baf18a42c2680e Author: Alex Buckley Date: Mon Mar 23 04:14:39 2020 +0000 Bug 22534: Added syspref for defining what guarantee fields are pre filled Librarians should be able to define what sections in member entryfields in 'Main address', 'Contact' and 'Alternate contact' in member entry form for guarantee's are pre-filled from guarantor's record The 'Guarantor surname, 'Guarantor first name' and 'relationship' fields in the 'Contact' section should not be filled from guarantor patron record as those fields are intended for guarantor's without patron records in Koha. Test plan: 1. On an adult patron's record (which has all fields filled out in the 'Main address', 'Contact' (Except for 'Guarantor surname', 'Guarantor first name', and 'relationship'), 'Alternate address', and 'Alternate contact') select 'Add guarantee' 2. Observe: * Fields in 'Main address' are all automatically pre-filled from guarantor record * Fields in 'Contact' (except 'Guarantor surname', 'Guarantor firstname' and 'relationship') are all automatically pre-filled from guarantor record * Fields in 'Alternate address' (except for Contact note) are pre-filled from guarantor record * None of the fields in 'Alternate contact' are pre-filled from guarantor 4. Apply patch 5. Run database updates cd installer/data/mysql sudo koha-shell ./updatedatabase.pl 6. Restart plack: sudo koha-plack --restart 7. Go to Administration > Global system preferences and search for the new PrefillGuaranteeField system preference 8. Observe this syspref contains checkboxes and the following are selected by default: Contact - Primary email Contact - Primary phone Main address - Address Main address - City Main address - Country Main address - State Main address - ZIP/Postal code Main address - street number Please note: 'Contact - Guarantor surname', 'Contact - Guarantor first name', Contact - relationship' are not in PrefillGuaranteeField syspref as they are for non Koha patrons and so should not be pre-filled from a Koha patron. 9. Repeat step 1 and observe the following fields are prefilled from guarantor: In Main address section - streetnumber address city state zipcode/postal code country In Contact section - Primary phone Primary email 10. In the PrefillGuaranteeField syspref click '[Select all]' checkboxes 11. Repeat step 1 and observe all fields in 'Main address', 'Contact' (except Guarantor surname, Guarantor first name, and relationship), Alternate address and Alterate contact are filled from guarantor record. i.e. The values in guarantor's 'Alternate address' fields fill the guarantee's 'Alternate address' fields 12. Change a few of the prefilled field values and 'Save' and observe your changes have been saved in addition to the unaltered pre-filled values in other fields 13. Amend PrefillGuarantee field syspref to have no checkboxes selected 14. Repeat step 1 and observe none of the fields in Main address, Contact, Alternate address and Alternate contact are pre-filled 15. Run tests: sudo koha-shell prove xt prove t Sponsored-by: Waitaki Distict Council, NZ Signed-off-by: Sally Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 8a56f176c083f7156584d07af7650162d13814e2 Author: Martin Renvoize Date: Thu Dec 5 17:42:50 2019 +0000 Bug 24183: Add before_send_messages hook This patch adds a simple hook to the process_message_queue cronjob to allow plugins to pre-process messages in the messaging queue before they are sent. Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit 26d4b7fd5e35f784f951c4f9e9bb084a9f4612a4 Author: Marcel de Rooy Date: Thu Feb 20 14:43:43 2020 +0000 Bug 24699: Split items.uri in OPAC detail view Same change as in bug 24697 for staff. If there are more URIs in 952u, we split them and show the real URL instead of Link to resource or the value of pref URLLinkText. I introduced a few template variables here to make the code a bit more compact and readable. Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit 93244efa3cbb66ff9e98d1eb4871da56a7565e5f Author: Jonathan Druart Date: Mon Jan 13 10:48:11 2020 +0100 Bug 16547: Do not display "multi holds" view if only one is selected If a hold is selected from the result list, we should let the ability to select an item-level hold. Test plan: I. Detail page 1/ Go to a bibliographic record detail page 2/ Click "Place hold" 3/ Select a patron => No change expected, you can select an item II. Search result, multiple holds 1/ Search for an item with more than one search result 2/ Select several items, click 'Place hold' 3/ Enter a patron card number => No change expected, item level holds are not available. III. Search result, single hold 1/ Search for an item with more than one search result 2/ Select only one item, click 'Place hold' 3/ Enter a patron card number => With this patch applied, item level hold is available. The screen is the same as when you place a hold from the bibliographic record detail page => Without this patch you cannot place an item-level hold QA notes: We could go a bit further and remove the 2 biblionumbers and biblionumber from hold script, as well as remove the checkMultiHold in request.tt. We should not have a biblionumbers param that contain a list of biblionumber separated by '/' but several biblionumber parameters instead. QA notes 2: About placerequest.pl, see bug 19618 comment 27. Signed-off-by: David Nind Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/UsageStats.pm | 1 + Koha.pm | 2 +- installer/data/mysql/sysprefs.sql | 4 +- installer/data/mysql/updatedatabase.pl | 21 +++++++++ .../prog/en/modules/admin/itemtypes.tt | 14 +++--- .../prog/en/modules/admin/preferences/admin.pref | 2 +- .../prog/en/modules/admin/preferences/opac.pref | 7 +++ .../prog/en/modules/admin/preferences/patrons.pref | 36 ++++++++++++++++ .../prog/en/modules/catalogue/advsearch.tt | 2 +- .../prog/en/modules/catalogue/results.tt | 1 - .../prog/en/modules/common/patron_search.tt | 8 +--- .../prog/en/modules/reserve/request.tt | 12 ------ .../prog/en/modules/virtualshelves/shelves.tt | 1 - .../bootstrap/en/modules/opac-advsearch.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 47 +++++++-------------- .../bootstrap/en/modules/opac-readingrecord.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 2 +- .../bootstrap/en/modules/opac-results-grouped.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-results.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-user.tt | 4 +- members/.nfs0000000000721f7f00000014 | Bin 0 -> 16384 bytes members/memberentry.pl | 15 +++---- misc/cronjobs/process_message_queue.pl | 17 ++++++++ reserve/modrequest.pl | 3 +- reserve/placerequest.pl | 18 +++----- reserve/request.pl | 7 ++- 27 files changed, 138 insertions(+), 96 deletions(-) create mode 100644 members/.nfs0000000000721f7f00000014 hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 6 13:49:20 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 06 Apr 2020 11:49:20 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1647-gce940939d4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via ce940939d445aad121a6b48f72c6c93bd79c0157 (commit) via a5301a99ab015423fe9315eb5e7ccbf25aa9f118 (commit) via c98d6f14ee588e5648c97ad75dfa07d0a719739f (commit) via 0885344e8056f34dd2cd9f38626fcaf321dda961 (commit) via bbb72bbd8d0b43c5b16401ee3c27a60fcc089093 (commit) via fb1bdea6d1eefba754d0eb384a8c2e4b03ffd150 (commit) via d6134c29174494e5fd85cb1d3c2a8f733c769a8f (commit) via 01c3067a7ca66e358b89ddf34eb08b48df0c5d1b (commit) via 3509f9cff86da2faea2ccc53ecdd0fdee70366c5 (commit) via dcc93ec356dbc5a4a94b3e9f63a9c4073a3f4176 (commit) via b8b2301f1320c2b7978b202cd1d196ae838dd8b5 (commit) via f12da2c1dd7333578324b2e9b6a5e78190a1e7f6 (commit) via fefb95b2e7cba0a0bfd47eacae92c1319ad5d496 (commit) via 185adc167433133626710edd296555db2d27865c (commit) via 12d2d3f69bbd04889e21ccd4568a1b40dadfad2c (commit) via c95ae98d6085495e055d6d6775fb8e0acc1e1cc5 (commit) via 282b85ef69b7e1fb55409d609e870832383ef710 (commit) via fc8f2d261bbf6a1850c9f8fa2de230550e27a616 (commit) via 7de7d4095a6092bc4b3dacd1f2e3b5c616fc572f (commit) via ffb5a071cbf8a5d54ecfcf26994fd0349b994180 (commit) via d198aaec04d5dc9ee26a702fb81fdad62d4edde6 (commit) via a0775299e2109fb54fef1c104616290a5b2d929e (commit) via 7fd92fcce9efdb45cc4fb6f309bfccbd3779a415 (commit) via fa23374d06f75f47e674cb46298b8e2a8325e404 (commit) via 499c6e45d271c507a757deb58d9dd42f4323a47d (commit) via 96883e69b577e1861741d5d5c4ea48d40f4eca1d (commit) via 414da449ddc341624c8ae35ebb1e86f07ecf70fb (commit) via 5d05b4d01c6393c4566fc10d080f14717f881798 (commit) via 5877fcf2c9caacfb7c0417403a2bdf209c94e230 (commit) via 87c3a1fa6316552650aacc4699555beafc1be24b (commit) via d6d0c4b7921a80ff62336efcd8ca01bf562c0f02 (commit) via 5523fb02734a91aa86d44c2e6aac30050adcc85e (commit) via 910815a49ca0dbec4f31fd8a62ea075ccba269f1 (commit) via fb482d2767c7a70d7e60c4bd892aa334447f3938 (commit) via 48e1716a8a5c0bd7de2de7f76fd12c8f18c88715 (commit) via 2a2da6c0ea1e323fb3ab5c9a44db45acc906b1b4 (commit) via dd1d8f35a9330c9edc01627ef806c463ff31db80 (commit) via f5edd39e612656d7fffbedc29f7112a49cd5999b (commit) via a592317d864148c80c09d4f3a7d17a2a1506a1ac (commit) via be853b43039832a9b7a7fbca4b74602b10ec43dc (commit) via 67daec2e5a3bf3eea207fe8250db43878ed7ffc3 (commit) via dd55209f251dfbb34a6c95266ea6e0fd4d6580d8 (commit) via cede9bbe43f39d44317b7cd9ba742a71d45e67f9 (commit) via 2e1e9c5b4846b057ac707f3e5fc84427c1dd71d9 (commit) from 25fa93a40683870c0e9c0fd96d839878aa2229c6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ce940939d445aad121a6b48f72c6c93bd79c0157 Author: Martin Renvoize Date: Mon Apr 6 11:25:02 2020 +0100 Bug 4461: DBRev 19.12.00.066 Signed-off-by: Martin Renvoize commit a5301a99ab015423fe9315eb5e7ccbf25aa9f118 Author: Jonathan Druart Date: Fri Apr 3 15:06:53 2020 +0200 Bug 4461: Use inbound_email_address to know if we display the dropdown list Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit c98d6f14ee588e5648c97ad75dfa07d0a719739f Author: Jonathan Druart Date: Fri Apr 3 13:52:12 2020 +0200 Bug 4461: Correctly deal with encoding/escaping chars This patch deals (hopefully) correctly with encoding and escaping chars. It also remove OPACBaseURL from the url stored in DB, and readd is on display, to avoid possible attacks. Test plan: Go to the authority search fill term with something hacky And Ŝ♥m€ E★tr₳ Search Click the "Report a problem" link Fill the form and make sure the url is displayed correctly submit Check problem_reports.problempage in DB => Should be correctly displayed Go to staff interface, "OPAC problem reports" => Confirm the link is correctly display Click it => Confirm that you are at the OPAC, and the URL is correct Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 0885344e8056f34dd2cd9f38626fcaf321dda961 Author: Jonathan Druart Date: Fri Apr 3 14:40:16 2020 +0200 Bug 4461: Extend problem_reports.problempage to TEXT 255 chars is not enough if want want to store any kind of URL, for instance an authorities search can be much longer Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit bbb72bbd8d0b43c5b16401ee3c27a60fcc089093 Author: Jonathan Druart Date: Fri Apr 3 14:39:45 2020 +0200 Bug 4461: dbic schema update Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit fb1bdea6d1eefba754d0eb384a8c2e4b03ffd150 Author: Jonathan Druart Date: Fri Apr 3 14:04:38 2020 +0200 Bug 4461: Hide link if KohaAdminEmailAddress is not set opac-reportproblem.pl returns a 404 in that case Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit d6134c29174494e5fd85cb1d3c2a8f733c769a8f Author: Jonathan Druart Date: Thu Apr 2 12:51:39 2020 +0200 Bug 4461: Fix OPAC link from staff QA: We have a security issue here, we should not make this link clickable from the staff side. Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 01c3067a7ca66e358b89ddf34eb08b48df0c5d1b Author: Jonathan Druart Date: Thu Apr 2 11:25:31 2020 +0200 Bug 4461: get_effective_email has been renamed inbound_email_address On commit 027051c938924a33a64014794705526ab68351af Bug 22823: Rename method with ->inbound_email_address Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 3509f9cff86da2faea2ccc53ecdd0fdee70366c5 Author: Aleisha Amohia Date: Wed Mar 18 22:50:50 2020 +0000 Bug 4461: Fix status and borrowernumber fields in problem_reports and more status varchar(6) with readable statuses borrowernumber not null default 0 hide form if message successfully sent fixing hide viewed and hide closed filters adding recipient column Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit dcc93ec356dbc5a4a94b3e9f63a9c4073a3f4176 Author: Martin Renvoize Date: Wed Mar 11 09:08:52 2020 +0000 Bug 4461: DBIC Schema Files Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit b8b2301f1320c2b7978b202cd1d196ae838dd8b5 Author: Aleisha Amohia Date: Thu Mar 19 00:26:33 2020 +0000 Bug 4461: Checks on library email before enqueuing letter Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit f12da2c1dd7333578324b2e9b6a5e78190a1e7f6 Author: Jonathan Druart Date: Thu Mar 12 12:51:27 2020 +0100 Bug 4461: Update license statements Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit fefb95b2e7cba0a0bfd47eacae92c1319ad5d496 Author: Martin Renvoize Date: Wed Mar 11 09:06:09 2020 +0000 Bug 4461: (follow-up) Add missing relationship accessor I think this was a simple case of Aliesha missing a file when commiting. So I could proceed with testing I just quickly re-implimented the patron relationship accessor. Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 185adc167433133626710edd296555db2d27865c Author: Aleisha Amohia Date: Wed Mar 11 01:52:27 2020 +0000 Bug 4461: Manage problem reports on the staff client Test plan: - Update database and upgrade schema files (if you haven't already). Restart memcached - Check your user's permissions and ensure the 'problem_reports' permission is ticked. Confirm the OPACReportProblem syspref is enabled - Log into the OPAC and submit a problem report - Log into the staff client - You should see a box at the bottom of the main page showing your pending problem report - Click the link and confirm it takes you to the new page for managing problem reports - Go to Administration - Confirm you can see a link to 'OPAC problem reports' under the 'Additional parameters' heading - Click 'OPAC problem reports' - Confirm your problem report is showing in the table - Open the OPAC in another tab and submit at least two more problem reports (so you should have at least three in the table after refreshing) - Try the different buttons - selecting multiple problem reports and using the big 'mark viewed', 'mark closed', 'mark new' buttons. Confirm there are no failures and that the number of selected problem reports is correct - select all, clear all, hide viewed, hide closed, hide new, show all - individual 'mark viewed', 'mark closed', 'mark new' buttons for each problem report. Confirm the status shows and the correct button is disabled while others are enabled - Confirm the problem page link works as expected Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 12d2d3f69bbd04889e21ccd4568a1b40dadfad2c Author: Aleisha Amohia Date: Tue Mar 10 22:52:29 2020 +0000 Bug 4461: Add problem reports link to mainpage and admin home Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit c95ae98d6085495e055d6d6775fb8e0acc1e1cc5 Author: Aleisha Amohia Date: Tue Mar 10 22:27:56 2020 +0000 Bug 4461: Adding user flags for managing OPAC problem reports Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 282b85ef69b7e1fb55409d609e870832383ef710 Author: Martin Renvoize Date: Mon Mar 2 15:18:33 2020 +0000 Bug 4461: Use get_effective_email from bug 22823 Use the get_effective_email from Koha::Library to get an appropriate inbound address for the branch as aposed to using branchemail directly. Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit fc8f2d261bbf6a1850c9f8fa2de230550e27a616 Author: Martin Renvoize Date: Mon Mar 2 15:16:37 2020 +0000 Bug 4461: Drop 'from_address' use 'reply_address' This patch adds support for using the reply-to field added in bug 10269 and drops 'from_address' as it will get defined at a later stage in the emailing process anyway. Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 7de7d4095a6092bc4b3dacd1f2e3b5c616fc572f Author: Martin Renvoize Date: Mon Mar 2 14:58:15 2020 +0000 Bug 4461: Remove hard requirement on OpacKohaUrl Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit ffb5a071cbf8a5d54ecfcf26994fd0349b994180 Author: Jonathan Druart Date: Wed Feb 26 12:15:42 2020 +0100 Bug 4461: Better error handling Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit d198aaec04d5dc9ee26a702fb81fdad62d4edde6 Author: Jonathan Druart Date: Wed Feb 26 11:59:34 2020 +0100 Bug 4461: Simplify recipients code As the feature is now turned off without KohaAdminEmailAddress, we only need to check if the email address of the library if defined. Not that we should not check for $library->branchreplyto or ReplytoDefault, but only $library->branchemail, as we do everywhere else (I think) Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit a0775299e2109fb54fef1c104616290a5b2d929e Author: Jonathan Druart Date: Wed Feb 26 11:41:39 2020 +0100 Bug 4461: Redirect to 404 if KohaAdminEmailAddress is not defined Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 7fd92fcce9efdb45cc4fb6f309bfccbd3779a415 Author: Jonathan Druart Date: Wed Feb 26 11:28:30 2020 +0100 Bug 4461: Use our local_referer instead of HTTP_REFERER Cannot remember why exactly, but it seems that we should not use HTTP_REFERER directly. Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit fa23374d06f75f47e674cb46298b8e2a8325e404 Author: Jonathan Druart Date: Wed Feb 26 11:08:51 2020 +0100 Bug 4461: Use KohaAdminEmailAddress pref as 'from' We usually do not specify the from_address on enqueuing the notice, but when sending it (from _send_message_by_email). That way a) the code is centralized (as we must use $patron->notice_email_address) and b) the email used is the one that is in the DB when the letter is effectively sent. Here I guess you need to give it when the notice is enqueued as you want to default to the koha admin address. I do not think it's a good idea, we should not send an email with "from" if not really sent by the user. We have the borrowernumber anyway to know who filled the form. Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 499c6e45d271c507a757deb58d9dd42f4323a47d Author: Jonathan Druart Date: Wed Feb 26 10:58:38 2020 +0100 Bug 4461: Rename report date with created_on And make it a timestamp type column Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 96883e69b577e1861741d5d5c4ea48d40f4eca1d Author: Aleisha Amohia Date: Tue Feb 25 04:04:43 2020 +0000 Bug 4461: (follow-up) Creating sample notice and other fixes - filters - capitalisation - atomic update Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 414da449ddc341624c8ae35ebb1e86f07ecf70fb Author: Aleisha Amohia Date: Tue Feb 11 19:48:30 2020 +0000 Bug 4461: (follow-up) Redirect to 404 if OPACProblemReport not enabled Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 5d05b4d01c6393c4566fc10d080f14717f881798 Author: Aleisha Amohia Date: Tue Feb 11 03:16:11 2020 +0000 Bug 4461: Submit a problem report To test: 1) Apply patch, update database, rebuild schema file 2) Restart koha-common and memcached 3) Confirm that your user has an email address. 4) Confirm that your library does NOT have an email address. 5) Confirm that syspref KohaAdminEmailAddress and syspref ReplytoDefault are not filled. Enable the OPACReportProblem syspref. 6) Log into OPAC 7) Click the 'Report a problem' link at the bottom of whatever page you're on 8) Notice that there is no form is and there is an error message alerting that reports cannot be submitted 9) Add an email address for your library (in either the email field or the replyto field). Refresh the OPAC problem report page. The form should now show, and the recipient field should say 'library'. 10) Complete the form and submit. Check the message_queue in the database and confirm the to_address is correct. Confirm there is a success message. 11) Add an email address for the syspref KohaAdminEmailAddress and refresh the OPAC problem report page again. The recipient field should now be a dropdown. Select the Koha Administrator option. 12) Complete the form and submit. Check the message_queue in the database and confirm the to_address is the value in KohaAdminEmailAddress. Confirm there is a success message. 13) Ensure all details in the message_queue are correct. 14) Log out of the OPAC 15) Click the Report a problem link again and confirm you are forced to log in Sponsored-by: Catalyst IT Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 5877fcf2c9caacfb7c0417403a2bdf209c94e230 Author: Aleisha Amohia Date: Tue Feb 11 00:00:11 2020 +0000 Bug 4461: Problem Report Koha objects Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 87c3a1fa6316552650aacc4699555beafc1be24b Author: Aleisha Amohia Date: Mon Feb 10 00:50:51 2020 +0000 Bug 4461: Database and syspref changes Adding problem_reports table and OPACReportProblem syspref Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit d6d0c4b7921a80ff62336efcd8ca01bf562c0f02 Author: Martin Renvoize Date: Mon Apr 6 11:11:12 2020 +0100 Bug 23173: DBRev 19.12.00.065 Signed-off-by: Martin Renvoize commit 5523fb02734a91aa86d44c2e6aac30050adcc85e Author: Kyle M Hall Date: Wed Apr 1 15:13:06 2020 -0400 Bug 23173: (follow-up) Fix QA script errors Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit 910815a49ca0dbec4f31fd8a62ea075ccba269f1 Author: Kyle M Hall Date: Wed Apr 1 15:09:48 2020 -0400 Bug 23173: (follow-up) Small improvements in efficiency Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit fb482d2767c7a70d7e60c4bd892aa334447f3938 Author: Andrew Isherwood Date: Mon Mar 16 12:06:03 2020 +0000 Bug 23173: (follow-up) Display available partners When selecting partners for search during the "Place request with partner libraries" workflow, there was no indication of which partners could actually be searched (i.e. are attached to a Z target and enabled for partner search). We now list them Signed-off-by: Niamh Walker-Headon Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit 48e1716a8a5c0bd7de2de7f76fd12c8f18c88715 Author: Andrew Isherwood Date: Mon Feb 17 12:29:19 2020 +0000 Bug 23173: (follow-up) Allow for customisable display name We now allow for the service to return a name that can be specified in the plugin config. This patch switches to using that, rather than just the plugin name defined in the plugin's metadata hashref Signed-off-by: Niamh Walker-Headon Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit 2a2da6c0ea1e323fb3ab5c9a44db45acc906b1b4 Author: Andrew Isherwood Date: Thu Feb 6 11:08:41 2020 +0000 Bug 23173: (follow-up) Allow for wide characters The conversion of the metadata into Base64 for passing in the API call to the plugin API routes was failing if the metadata contained a wide character, so we now encode it into UTF-8 first Signed-off-by: Niamh Walker-Headon Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit dd1d8f35a9330c9edc01627ef806c463ff31db80 Author: Andrew Isherwood Date: Tue Sep 10 16:32:49 2019 +0100 Bug 23173: Add unit tests Test Koha::Illrequests::Availability Signed-off-by: Niamh Walker-Headon Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit f5edd39e612656d7fffbedc29f7112a49cd5999b Author: Andrew Isherwood Date: Thu Jul 11 14:15:55 2019 +0100 Bug 23173: Provide core infrastructure This patch adds the required infrastructure to enable ILL availability plugins to intercept the request creation process and, using the supplied metadata, search for and display possible relevant items from whichever availability plugins are installed. Currently three availability plugins exist: z39.50 - Searches any number of the Koha instance's configured Z targets https://github.com/PTFS-Europe/koha-plugin-ill-avail-z3950 EDS - Searches the EBSCO Discovery Service https://github.com/PTFS-Europe/koha-plugin-ill-avail-eds Unpaywall - Searches the Unpaywall API for possible open access versions of the requested item https://github.com/PTFS-Europe/koha-plugin-ill-avail-unpaywall The Unpaywall plugin is intended to serve as a "reference" plugin as the API it deals with is extremely simple Signed-off-by: Niamh Walker-Headon Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit a592317d864148c80c09d4f3a7d17a2a1506a1ac Author: Andrew Isherwood Date: Fri Jun 21 10:17:03 2019 +0100 Bug 23173: Add ILLCheckAvailability syspref This patch adds the new syspref "ILLCheckAvailability" Sponsored-by: Public Health England Signed-off-by: Niamh Walker-Headon Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit be853b43039832a9b7a7fbca4b74602b10ec43dc Author: Tomas Cohen Arazi Date: Wed Apr 1 00:11:19 2020 -0300 Bug 18227: (QA follow-up) Add fix to koha-common.postinst Now koha-common.postinst has a way to patch log4perl configs on instances, we should patch the Z3950 responder config accordingly, before it is backported to 19.11 or the 20.05 release :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit 67daec2e5a3bf3eea207fe8250db43878ed7ffc3 Author: Olli-Antti Kivilahti Date: Wed Mar 8 12:51:43 2017 +0200 Bug 18227: Handle utf8 in Koha::Logger No more wide characters in print when logging to a file with Koha::Logger. Test with this string "♯Turpo :" Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit dd55209f251dfbb34a6c95266ea6e0fd4d6580d8 Author: Kyle M Hall Date: Wed Apr 1 06:19:24 2020 -0400 Bug 24537: Tidy code Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit cede9bbe43f39d44317b7cd9ba742a71d45e67f9 Author: David Cook Date: Thu Jan 30 14:53:09 2020 +1100 Bug 24537: Allow IP ranges in ILS-DI:AuthorizedIPs using Net::Netmask This patch uses Net::Netmask to match IPs from ILS-DI:AuthorizedIPs against $ENV{REMOTE_USER}. By using Net::Netmask, we can use addresses in a variety of formats. This includes 127.0.0.1, 192.168.1.0/24, 10.0.0, and so on. To Test: 1. Apply the patch 2. Empty the 'ILS-DI:AuthorizedIPs' system preference 3. Send a request to '/cgi-bin/koha/ilsdi.pl?service=LookupPatron&id=1&id_type=cardnumber' 3b. Note that the request is successful 4. Set the 'ILS-DI:AuthorizedIPs' system preference to a subnet including your IP address (e.g. 192.168.1.0/24) 5. Send a request to '/cgi-bin/koha/ilsdi.pl?service=LookupPatron&id=1&id_type=cardnumber' 5b. Note that the request is successful 6. Set the 'ILS-DI:AuthorizedIPs' system preference to a subnet that doesn't include your IP address (e.g. 1.1.1) 7. Send a request to '/cgi-bin/koha/ilsdi.pl?service=LookupPatron&id=1&id_type=cardnumber' 7b. Note that your request is refused 8. Try a variety of permutations including bad values (e.g. 192.168.1.) or multiple values (e.g. 10.0.0.0/8,192.168.1.0/24) or multiple values including a mix of good and bad values Signed-off-by: David Nind Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit 2e1e9c5b4846b057ac707f3e5fc84427c1dd71d9 Author: Nick Clemens Date: Mon Mar 30 15:16:36 2020 +0000 Bug 23601: Prevent default for auxclick The issue appears to be that the default action is not prevented for middle click because it registers an 'auxclick' event as opposed to a 'click' event To test: 1 - Perform a search in staff client 2 - Shift-click and hold on a result 3 - Note a new tab opens 4 - Release the click, no change 5 - Middle click and hold on a result 6 - New tab opens 7 - Release, a second new tab opens 8 - Apply patch 9 - Reload page 10 - Middle click and hold 11 - New tab opens 12 - Release 13 - No new tab Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Auth.pm | 3 +- C4/InstallAuth.pm | 1 + C4/Letters.pm | 1 + Koha.pm | 2 +- Koha/Illrequest/Availability.pm | 127 +++++++++++ Koha/{Review.pm => ProblemReport.pm} | 34 +-- Koha/{Items.pm => ProblemReports.pm} | 23 +- Koha/Schema/Result/Borrower.pm | 19 +- Koha/Schema/Result/Branch.pm | 19 +- Koha/Schema/Result/ProblemReport.pm | 189 +++++++++++++++++ circ/checkout-notes.pl => admin/problem-reports.pl | 42 ++-- debian/koha-common.postinst | 1 + debian/templates/log4perl-site.conf.in | 3 + etc/log4perl.conf | 3 + ill/ill-requests.pl | 78 ++++++- .../data/mysql/de-DE/mandatory/sample_notices.sql | 3 +- .../data/mysql/en/mandatory/sample_notices.yml | 17 ++ .../data/mysql/es-ES/mandatory/sample_notices.sql | 3 +- .../mysql/fr-CA/obligatoire/sample_notices.sql | 3 +- .../mysql/fr-FR/1-Obligatoire/sample_notices.sql | 3 +- installer/data/mysql/it-IT/necessari/notices.sql | 3 +- installer/data/mysql/kohastructure.sql | 21 ++ .../mysql/nb-NO/1-Obligatorisk/sample_notices.sql | 3 +- .../data/mysql/pl-PL/mandatory/sample_notices.sql | 3 +- .../data/mysql/ru-RU/mandatory/sample_notices.sql | 3 +- installer/data/mysql/sysprefs.sql | 2 + .../data/mysql/uk-UA/mandatory/sample_notices.sql | 4 +- installer/data/mysql/updatedatabase.pl | 57 +++++ installer/data/mysql/userflags.sql | 3 +- installer/data/mysql/userpermissions.sql | 3 +- koha-tmpl/intranet-tmpl/js/browser.js | 2 +- .../intranet-tmpl/prog/css/src/staff-global.scss | 23 ++ .../intranet-tmpl/prog/en/includes/admin-menu.inc | 3 + .../prog/en/includes/ill-availability-table.inc | 16 ++ .../intranet-tmpl/prog/en/includes/permissions.inc | 9 + .../prog/en/modules/admin/admin-home.tt | 4 + .../en/modules/admin/preferences/circulation.pref | 7 + .../prog/en/modules/admin/preferences/opac.pref | 8 + .../prog/en/modules/admin/problem-reports.tt | 231 +++++++++++++++++++++ .../prog/en/modules/ill/ill-requests.tt | 87 +++++++- .../intranet-tmpl/prog/en/modules/intranet-main.tt | 9 +- .../prog/en/modules/plugins/plugins-home.tt | 1 + .../prog/js/ill-availability-partner.js | 41 ++++ .../intranet-tmpl/prog/js/ill-availability.js | 222 ++++++++++++++++++++ koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss | 9 + .../en/includes/ill-availability-table.inc | 17 ++ .../bootstrap/en/includes/opac-bottom.inc | 11 +- .../bootstrap/en/modules/opac-illrequests.tt | 47 +++++ .../bootstrap/en/modules/opac-reportproblem.tt | 96 +++++++++ .../opac-tmpl/bootstrap/js/ill-availability.js | 178 ++++++++++++++++ mainpage.pl | 3 + opac/ilsdi.pl | 21 +- opac/opac-illrequests.pl | 43 ++++ opac/opac-reportproblem.pl | 144 +++++++++++++ svc/{checkout_notes => problem_reports} | 29 +-- .../Illrequest/Availability.t} | 47 ++--- tools/letter.pl | 4 + 57 files changed, 1860 insertions(+), 128 deletions(-) create mode 100644 Koha/Illrequest/Availability.pm copy Koha/{Review.pm => ProblemReport.pm} (68%) copy Koha/{Items.pm => ProblemReports.pm} (78%) create mode 100644 Koha/Schema/Result/ProblemReport.pm copy circ/checkout-notes.pl => admin/problem-reports.pl (53%) create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/ill-availability-table.inc create mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/admin/problem-reports.tt create mode 100644 koha-tmpl/intranet-tmpl/prog/js/ill-availability-partner.js create mode 100644 koha-tmpl/intranet-tmpl/prog/js/ill-availability.js create mode 100644 koha-tmpl/opac-tmpl/bootstrap/en/includes/ill-availability-table.inc create mode 100644 koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reportproblem.tt create mode 100644 koha-tmpl/opac-tmpl/bootstrap/js/ill-availability.js create mode 100755 opac/opac-reportproblem.pl copy svc/{checkout_notes => problem_reports} (63%) copy t/{Koha/Script_cron.t => db_dependent/Illrequest/Availability.t} (52%) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 6 13:56:07 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 06 Apr 2020 11:56:07 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1650-gc80ced404f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via c80ced404fa0eff291509b42280c81b7d23d0ad6 (commit) via 875108d46e0dacec4221261a29e680023fa5167d (commit) via da3606ac3ff10df6fb111d96070d6d33d0b37f34 (commit) from ce940939d445aad121a6b48f72c6c93bd79c0157 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c80ced404fa0eff291509b42280c81b7d23d0ad6 Author: Martin Renvoize Date: Mon Apr 6 12:28:36 2020 +0100 Bug 20754: DBRev 19.12.00.067 Signed-off-by: Martin Renvoize commit 875108d46e0dacec4221261a29e680023fa5167d Author: Marcel de Rooy Date: Fri May 4 10:42:38 2018 +0200 Bug 20754: DB revision to remove double accepted shares [Originally submitted for bug 11943, parked at 20754.] [Attempt to revive it now.] Although it is no problem to have them, we could do a cleanup. This patch just removes duplicate rows from the table. Note: I considered adding a unique index like: ALTER TABLE virtualshelfshares ADD UNIQUE INDEX (shelfnumber, borrowernumber, invitekey); But the possible NULL values in borrowernumber and/or invitekey require additional code changes. So I left it alone. Test plan: [1] Create two records with same borrowernumber and shelfnumber in the shares table, if not present already. [2] Run updatedatabase.pl Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit da3606ac3ff10df6fb111d96070d6d33d0b37f34 Author: Julian Maurice Date: Thu Feb 6 16:15:43 2020 +0100 Bug 24604: Add 'Pay' button under Transactions tab in patron accounting It does the same thing as the 'Pay' button under 'Make a payment' tab. It is nothing more than a shortcut. Signed-off-by: David Nind Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/updatedatabase.pl | 20 ++++++++++++++++++++ .../prog/en/modules/members/boraccount.tt | 3 +++ 3 files changed, 24 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 6 14:30:28 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 06 Apr 2020 12:30:28 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1651-gf8d173cb15 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via f8d173cb1529f02dc1be860189583e9cc642096f (commit) from c80ced404fa0eff291509b42280c81b7d23d0ad6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f8d173cb1529f02dc1be860189583e9cc642096f Author: Martin Renvoize Date: Mon Apr 6 13:02:54 2020 +0100 Bug 4944: (RM follow-up) Add OpacNoItemTypeImages to UsageStats test Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: t/db_dependent/UsageStats.t | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Apr 7 14:11:01 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 07 Apr 2020 12:11:01 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1652-g2633796e1f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 2633796e1fd68c6f8f4af0d81085ad89d6d0799b (commit) from f8d173cb1529f02dc1be860189583e9cc642096f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2633796e1fd68c6f8f4af0d81085ad89d6d0799b Author: Martin Renvoize Date: Tue Apr 7 12:43:43 2020 +0100 Bug 23355: (RM follow-up) Restore lost ID's Some ID's were lost during a QA followup, this patch restores them. Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt | 6 +++--- koha-tmpl/intranet-tmpl/prog/en/modules/pos/registers.tt | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Apr 8 09:43:07 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 08 Apr 2020 07:43:07 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1653-gbad8c7089a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via bad8c7089addceca18aacae14d9b7ed30a4722aa (commit) from 2633796e1fd68c6f8f4af0d81085ad89d6d0799b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit bad8c7089addceca18aacae14d9b7ed30a4722aa Author: Jonathan Druart Date: Wed Apr 8 08:47:49 2020 +0200 Bug 24801: (follow-up) Display all the libraries - Selenium fix We have it failing now for the delete link.. 14:26:50 selenium_1 | 05:26:50.451 WARN - Exception: Unable to locate element: {"method":"xpath","selector":"//*[@id=\"delete_library_UT_BC\"]"} Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: t/db_dependent/selenium/administration_tasks.t | 3 +++ 1 file changed, 3 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Apr 8 13:22:21 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 08 Apr 2020 11:22:21 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1666-g94ec55d767 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 94ec55d767cd9a61368757154e36e6e0d5bcafcf (commit) via 6ac037f817def256c85706413036bee3f78ed40e (commit) via c878a9e825ab740c2d1bc820875485cc816ed492 (commit) via bb527d54f598f91e4373282032fbc1ab9b0515d3 (commit) via 947b16b322b9fe719a1bef6c25d4172db3d7cc8e (commit) via b3e15a720578b2f03ffea818bac4df585741b1a1 (commit) via 77457a496a43d9d3bd0330d2ed511b0d1388d8b0 (commit) via c88c8e5322d1205ca4e39409b34f8d02311182ad (commit) via d132c10bfcff87b117ff454bb431fdbd1f08c92c (commit) via e925568a3067e77173f4d21f476b28f8aa068571 (commit) via 9789a43025d139d4d0b872fa0b51c0dc1df0d7dc (commit) via df58c3e2c9af7b0218f6db957dbb781f0cb1f278 (commit) via 2f2db163bd108e165b2e54a7258ec1176c213285 (commit) from bad8c7089addceca18aacae14d9b7ed30a4722aa (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 94ec55d767cd9a61368757154e36e6e0d5bcafcf Author: Martin Renvoize Date: Wed Apr 8 10:43:54 2020 +0100 Bug 24840: (follow-up) Catch some further cases of DateTime->now This patch corrects a few additional cases where DateTime->now is called directly instead of via Koha::DateUtils. Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 6ac037f817def256c85706413036bee3f78ed40e Author: Nick Clemens Date: Thu Mar 26 11:05:32 2020 +0000 Bug 24840: Replace DateTime->now with dt_from_string We should use Koha::DateUtils instead of Date::Time directly This patch simplay replaces calls to now() with a call to dt_from_string() which does effectively the same thing. Probably reading the code and verifying changes is sufficient but... To test: 1 - confirm the files all compile 2 - confirm all tests pass 3 - confirm Koha still works Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit c878a9e825ab740c2d1bc820875485cc816ed492 Author: Jonathan Druart Date: Wed Apr 8 11:45:51 2020 +0200 Bug 25081: Fix wrong comment Not directly related to previous patch, coming from 23435. Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit bb527d54f598f91e4373282032fbc1ab9b0515d3 Author: Janusz Kaczmarek Date: Tue Apr 7 22:23:20 2020 +0200 Bug 25081: Fix creation of new item for a received issue The Bug 23435 introduced the idea of multiple copies added while receiving a new issue. Unfortunately, under some circumstances, it causes no items being added at all. It occurs stochastically, only under some conditions. But it is quite likely to happen while receiving a supplemental issue. The reason fot hist is that, in serials-edit.pl, line ca 292 and infra, @num_copies is treated in the same way as @tags, while it should be treated similarly to @bibnums. It will be obvious after examining the content of parameters tag, subfield, field_value, ..., number_of_copies. In other words, for every edited issue number_of_copies is a scalar. Nota bene: a) beter to initialize $countdistinct with zero; b) note that in master, now, before applying the patch, $itemhash{$item}->{'num_copies'} is treated once as a scalar and in the next line--as an array: $itemhash{$item}->{'num_copies'} //= 1; for (my $copy = 0; $copy < $itemhash{$item}->{'num_copies'}[$index];){ TEST PLAN ========= 1. Have a subscription with the option "Create an item record when receiving this serial" active and try to receive a supplemental issue. Control that a new item under the biblio record (usually) will not be created. 2. Apply the patch. 3. Repeat p. 1 -- a new item should be created. Signed-off-by: Aleisha Amohia Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 947b16b322b9fe719a1bef6c25d4172db3d7cc8e Author: Kyle M Hall Date: Fri Mar 27 12:01:05 2020 -0400 Bug 22937: Add hint to groups editor Signed-off-by: Lisette Scheer Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit b3e15a720578b2f03ffea818bac4df585741b1a1 Author: Jonathan Druart Date: Wed Apr 8 11:28:31 2020 +0200 Bug 25046: Add test Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 77457a496a43d9d3bd0330d2ed511b0d1388d8b0 Author: Andreas Roussos Date: Thu Apr 2 19:14:57 2020 +0200 Bug 25046: Include borrowers.othernames in SELECT statement In C4/Utils/DataTables/Members.pm, the SELECT statement that fetches patron data from the database does not include borrowers.othernames in the field list. As a consequence, when the output is in the form of a DataTable, the Template Toolkit files that refer to .othernames (such as the patron-title.inc include) won't display the information from the 'Other name' input field if that field has been filled in. This patch fixes that. Test plan: 0) Have a few patrons with some data in the 'Other name' field. 1) Perform a generic search in Home > Patrons to ensure you will get a DataTable with results. 2) Observe that the 'Name' column does not include 'Other name' info. 3) Apply the patch, and restart Plack if necessary. 4) Repeat your search: this time you should see the information from the 'Other name' field, it will be next to the patron's First name and within parentheses. Sponsored-by: Eugenides Foundation Library Signed-off-by: Devinim Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit c88c8e5322d1205ca4e39409b34f8d02311182ad Author: Jonathan Druart Date: Wed Apr 8 10:42:41 2020 +0200 Bug 7046: Preselect dropdown option and prefill input With previous renew values Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit d132c10bfcff87b117ff454bb431fdbd1f08c92c Author: Alex Buckley Date: Mon Nov 27 15:31:35 2017 +1300 Bug 7046: Implemented subscription renewal dropdown sub length element To make this work I moved the _get_sub_length function from subscription-add.pl to C4/Serials.pm so that the subscription-renew.pl script could also call it to store the sublength for the appropriate field of the subscriptions database table. Test plan: 1. Create a subscription and notice that there is a dropdown box for sub length containing the values: issues, weeks, months 2. Renew the subscription and notice that there are 3 input text boxes: 'number of num', 'number of weeks' and 'number of months' 3. Input a 'Number of weeks' value of 2 4. Query the subscription database table and notice that the value of 2 has been stored in the weeklength field for the subscription record you just renewed 5. Apply the patch 6. Renew the subscription and notice that there is now a sublength dropdown box containing issues, weeks and months 7. Set the month value to 3 8. Query the database and notice that 3 was stored in the monthlength field for the subscription record 9. Create a new subscription and select the sub length values of issues and 3 10. Query the database and notice that the numberlength field for the subscription you just created is set to 3 showing that the sublength dropbox is still working for creating a new subscription Sponsored-By: Catalyst IT Signed-off-by: Dilan Johnpullé Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit e925568a3067e77173f4d21f476b28f8aa068571 Author: Jonathan Druart Date: Wed Mar 11 16:21:06 2020 +0100 Bug 24826: Remove warnings from Sendmail Use of uninitialized value $mail{"Cc"} in substitution (s///) at /usr/share/perl5/Mail/Sendmail.pm Signed-off-by: Martin Renvoize commit 9789a43025d139d4d0b872fa0b51c0dc1df0d7dc Author: David Roberts Date: Fri Apr 3 15:23:01 2020 +0000 Bug 24940: Serials statistics wizard: order vendor list alphabetically This patch changes the dropdown from being sorted by aqbookseller.id to aqbookseller.name To test: 1) Add at least 2 vendors: - First: ZZZZ - Second: AAAA 2) Add subscriptions for each of the vendors 3) Check the pull down in the serials statistics wizard and verify it lists them as ZZZZ, AAAA 4) Apply the patch 5) Re-check the pull down in the wizard and check that the vendors are now listed AAAA,ZZZZ Signed-off-by: Devinim Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit df58c3e2c9af7b0218f6db957dbb781f0cb1f278 Author: Tomas Cohen Arazi Date: Mon Mar 30 09:39:13 2020 -0300 Bug 25019: Make the ViewPolicy filter initialization standard This patch makes the ViewPolicy filter use the 'params' accessor instead of relying of ->{options} which has no accessor. This will allow interacting with the filter object be similar through all the filters in the chain. To test, we just need to verify no behaviour change takes place: 1. Run: $ kshell k$ prove t/db_dependent/Filter_MARC_ViewPolicy.t => SUCCESS: Tests pass 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests still pass! 4. Sign off :-D Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 2f2db163bd108e165b2e54a7258ec1176c213285 Author: Jonathan Druart Date: Fri Apr 3 11:42:59 2020 +0200 Bug 25041: Restore #ASKED anchor in suggestions table On commit 4494e8ba6ca7d28972fcc1161c680ecf0b091f62 Bug 23594: Batch modification for itemtypes on suggestions page The anchors of the tabs on suggestion.pl has been replaced with tab_$count instead of the status code. There was a need at the time, but I cannot remember it. I restored the previous behavior, and did not find any regressions. Test plan: 1 - Add several suggestions to Koha 2 - Set them in different status, leaving at least one pending 3 - Go to home page, note it shows count of pending 4 - Click the link on home page 5 - It takes you to correct tab Signed-off-by: David Nind Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 20 ++++----- C4/Letters.pm | 2 +- C4/MarcModificationTemplates.pm | 3 +- C4/Serials.pm | 25 ++++++++++- C4/Utils/DataTables/Members.pm | 1 + Koha/Calendar.pm | 2 +- Koha/Checkout.pm | 3 +- Koha/Checkouts.pm | 3 +- Koha/EDI.pm | 5 ++- Koha/Edifact/Order.pm | 3 +- Koha/Edifact/Transport.pm | 3 +- Koha/Email.pm | 4 +- Koha/Filter/MARC/ViewPolicy.pm | 16 ++----- Koha/Illrequest.pm | 3 +- Koha/Patron/Password/Recovery.pm | 3 +- Koha/Sitemapper/Writer.pm | 4 +- Koha/StockRotationItem.pm | 12 ++--- circ/overdue.pl | 2 +- circ/returns.pl | 6 +-- .../fix_unclosed_nonaccruing_fines_bug17135.pl | 2 +- installer/data/mysql/updatedatabase.pl | 2 +- .../prog/en/modules/admin/library_groups.tt | 2 + .../prog/en/modules/serials/subscription-renew.tt | 51 ++++++++++++++-------- .../prog/en/modules/suggestion/suggestion.tt | 6 +-- members/summary-print.pl | 3 +- misc/cronjobs/fines.pl | 2 +- misc/cronjobs/overdue_notices.pl | 4 +- misc/cronjobs/update_totalissues.pl | 3 +- opac/opac-ics.pl | 2 +- reports/serials_stats.pl | 3 +- serials/serials-edit.pl | 8 ++-- serials/subscription-add.pl | 15 +------ serials/subscription-renew.pl | 11 +++-- t/Circulation/AgeRestrictionMarkers.t | 5 ++- t/db_dependent/DecreaseLoanHighHolds.t | 5 ++- t/db_dependent/Letters/TemplateToolkit.t | 2 +- t/db_dependent/OAI/Server.t | 2 +- t/db_dependent/Passwordrecovery.t | 11 ++--- t/db_dependent/Serials/ReNewSubscription.t | 28 +++++++++++- t/db_dependent/Sitemapper.t | 3 +- t/db_dependent/Utils/Datatables_Members.t | 12 ++++- 41 files changed, 190 insertions(+), 112 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Apr 8 14:46:14 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 08 Apr 2020 12:46:14 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1667-g78b67d21c5 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 78b67d21c5f15bccdc7ae8f180d4f0a266196e9f (commit) from 94ec55d767cd9a61368757154e36e6e0d5bcafcf (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 78b67d21c5f15bccdc7ae8f180d4f0a266196e9f Author: Martin Renvoize Date: Wed Apr 8 13:18:46 2020 +0100 Bug 7046: (RM follow-up) Add Filters Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/serials/subscription-renew.tt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Apr 8 16:58:39 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 08 Apr 2020 14:58:39 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-3-gc188cf91a0 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via c188cf91a0c66196620f1efeeea8e39ae30da182 (commit) from faed28348d4bdc0bcd9639b3c38208960ac5fb7f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c188cf91a0c66196620f1efeeea8e39ae30da182 Author: Nick Clemens Date: Fri Feb 21 21:11:37 2020 +0000 Bug 24711: Don't add logout input to login form To test: 1 - Set OpacPublic syspref to 'Disable' 2 - Log in to OPAC 3 - Log out 4 - Try to log in again 5 - No error, but you get the login form again 6 - Apply patch 7 - Repeat 8 - This time you can log in again Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit a137b170c0f4bac8fdd69dd4e9fe6e46c60edd59) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Apr 8 17:04:12 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 08 Apr 2020 15:04:12 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-4-gf6d61ce5e0 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via f6d61ce5e07c633143843604722f29b0d92d8fce (commit) from c188cf91a0c66196620f1efeeea8e39ae30da182 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f6d61ce5e07c633143843604722f29b0d92d8fce Author: Fridolin Somers Date: Tue Jan 28 16:09:20 2020 +0100 Bug 24527: misc/cronjobs/update_totalissues.pl problem with multiple items misc/cronjobs/update_totalissues.pl when issuing statistics table, no-incremental, has a problem for biblio with multiple items. The first SQL query gets the biblios linked to items with issues in statistics : SELECT biblio.biblionumber, COUNT(statistics.itemnumber) FROM biblio LEFT JOIN items ON (biblio.biblionumber=items.biblionumber) LEFT JOIN statistics ON (items.itemnumber=statistics.itemnumber) WHERE statistics.type = 'issue' $limit GROUP BY biblio.biblionumber The second SQL query is : SELECT biblio.biblionumber, 0 FROM biblio LEFT JOIN items ON (biblio.biblionumber=items.biblionumber) LEFT JOIN statistics ON (items.itemnumber=statistics.itemnumber) WHERE statistics.itemnumber IS NULL GROUP BY biblio.biblionumber The problem is that this second query will set to 0 where ANY item has no entry in statistics table. So when running it sets 0 to the biblio that had a value from first query. I think the best fix is to use "WHERE statistics.type = 'issue'" inside que JOIN : LEFT JOIN statistics ON (items.itemnumber=statistics.itemnumber AND statistics.type = 'issue') Test plan : 1) Begin with an empty database 2) Create a biblio 1 with no items 3) Create a biblio 2 with 3 items 4) Create a biblio 3 with 2 items 5) Checkout and checkin all items of biblio 2 6) Checkout and checkin the firt item of biblio 3 7) run misc/cronjobs/update_totalissues.pl --use-stats -v 8) Check biblio 1 has biblioitems.totalissues = 0 9) Check biblio 2 has biblioitems.totalissues = 3 10) Without patch the biblio 3 has biblioitems.totalissues = 0 11) With patch the biblio 3 has biblioitems.totalissues = 1 12) Check misc/cronjobs/update_totalissues.pl --incremental is OK Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 91da9841d78d26db205c6493c27c174c20e7b7c2) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: misc/cronjobs/update_totalissues.pl | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Apr 8 17:23:11 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 08 Apr 2020 15:23:11 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-5-gc9154e6e83 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via c9154e6e83614f4808d529a967e150e6b08bcd41 (commit) from f6d61ce5e07c633143843604722f29b0d92d8fce (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c9154e6e83614f4808d529a967e150e6b08bcd41 Author: Jonathan Druart Date: Fri Feb 21 10:31:54 2020 +0100 Bug 24682: Make UsageStatsGeolocation readonly (and redirect to the config page) To prevent invalid values in this pref (and so on the server), we should make this input readonly on the syspref page. The sysprefs related to Hea should be edited from the dedicated page, so also adding a note about that. Test plan: Search syspref with "UsageStats" Notice the note about the admin page Notice the UsageStatsGeolocation input is now readonly (and resized, to display the whole value when filled) Signed-off-by: Maryse Simard Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 60a0c1c51cc4667eefa62232d7a45a823168a378) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt | 6 +++++- .../intranet-tmpl/prog/en/modules/admin/preferences/admin.pref | 2 ++ 2 files changed, 7 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Apr 8 17:30:14 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 08 Apr 2020 15:30:14 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-8-ga9d7aa8518 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via a9d7aa85186ddd7f0488c89337544d56d09fcccb (commit) via d0623804ebd5145c87e05ec9ff1ebf5f7b2ef051 (commit) via 7399a8de944674dfdb1ffb9dd014427d7750dd14 (commit) from c9154e6e83614f4808d529a967e150e6b08bcd41 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a9d7aa85186ddd7f0488c89337544d56d09fcccb Author: Marcel de Rooy Date: Fri Nov 29 09:45:48 2019 +0000 Bug 24114: (QA follow-up) Fix counts for lock, anonymize and delete Since these operations impact on the resultset, the counts should be saved before. Signed-off-by: Marcel de Rooy Signed-off-by: Bouzid Fergani Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 9b0ba1c096ed72bd867792a11de59a825355e6dc) Signed-off-by: Lucas Gass commit d0623804ebd5145c87e05ec9ff1ebf5f7b2ef051 Author: Marcel de Rooy Date: Fri Nov 29 09:17:19 2019 +0000 Bug 24114: (follow-up) Resolve warning on non-numeric subtraction Argument "" isn't numeric in subtraction (-) at /usr/share/koha/Koha/Patrons.pm line 290. Coming from an empty or undefined FailedLoginAttempts. Test plan: Verify that Koha/Patrons.t still passes. Signed-off-by: Marcel de Rooy Signed-off-by: Bouzid Fergani Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit c242f8667794cc4217155c783dfe8065d77ac788) Signed-off-by: Lucas Gass commit 7399a8de944674dfdb1ffb9dd014427d7750dd14 Author: Jonathan Druart Date: Tue Nov 26 11:11:35 2019 +0100 Bug 24114: Remove warn statements from Koha::Patrons The warn must be done in the cronjob. Signed-off-by: Marcel de Rooy Followed this test plan (with two follow-ups applied): [1] Prefs: UnsubscribeReflectionDelay=1, PatronAnonymizeDelay=2, PatronRemovalDelay=3, FailedLoginAttempts was undef [2] Pick borrower and set expiry to NOW-2, and lock him (login_attempts=-1) Could be achieved too by settings FailedLoginAttempts and trying wrong passwords. Run cleanup job: Locked 0 patrons Anonymized 1 patrons Deleted 0 patrons [3] Pick borrower, set expiry to NOW-3. Run cleanup job: Locked 0 patrons Anonymized 0 patrons Deleted 1 patrons Signed-off-by: Bouzid Fergani Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit d7f922eb63c420375f42ab419d9db154650fbd4d) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: Koha/Patrons.pm | 19 +++++-------------- misc/cronjobs/cleanup_database.pl | 23 +++++++++++++++++++---- t/db_dependent/Koha/Patrons.t | 11 ++++++++++- 3 files changed, 34 insertions(+), 19 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Apr 8 17:35:43 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 08 Apr 2020 15:35:43 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-10-g27be06c672 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 27be06c67281bf24df755c67e305da420c11eac8 (commit) via d474a4edb165d7116b5bfc459d33e04cc88ca456 (commit) from a9d7aa85186ddd7f0488c89337544d56d09fcccb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 27be06c67281bf24df755c67e305da420c11eac8 Author: Marcel de Rooy Date: Fri Mar 20 10:12:24 2020 +0000 Bug 24809: (QA follow-up) Add prefix to prevent disambiguity This seems not to be needed. Just at the safe side. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 96e6362ab721621dd7e24d6f8a56d168e2a9b497) Signed-off-by: Lucas Gass commit d474a4edb165d7116b5bfc459d33e04cc88ca456 Author: Nick Clemens Date: Thu Mar 5 10:59:22 2020 +0000 Bug 24809: Get only timestamp of deleted items attached to existing bibs when check if bib deleted To test: 1 - Edit/create a file in the koha home dir '/var/lib/koha/{instance}/OAI.yaml' with content like below: format: marcxml: metadataPrefix: marcxml metadataNamespace: http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim schema: http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd include_items: 1 2 - Set the systempreferences below to indicated values: OAI-PMH => Enable OAI-PMH:ConfFile => /var/lib/koha/{instace}/OAI.yaml 3 - View a record with items and confirm the items show: http://localhost:8080/cgi-bin/koha/oai.pl?verb=GetRecord&metadataPrefix=marcxml&identifier=KOHA-OAI-TEST:4 4 - Delete the items, then delete the record 5 - Reload the URL from step 3 6 - Internal Server Error: Empty String at /kohadevbox/koha/Koha/OAI/Server/Record.pm line 58. at /usr/share/perl/5.24/Carp.pm line 167 7 - Apply patch 8 - restart_all 9 - Repeat 10 - Reload URL from step 3 11 - Success Signed-off-by: Michal Denar Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 68488f40558d66b7e4e444c1ed57a260b33ee034) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: Koha/OAI/Server/GetRecord.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Apr 8 17:45:09 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 08 Apr 2020 15:45:09 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-12-g0870bb6da6 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 0870bb6da6191759512e8b7a29ebe7a2f169ee62 (commit) via e94543c454e1de6688f910515885757f1b467caf (commit) from 27be06c67281bf24df755c67e305da420c11eac8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0870bb6da6191759512e8b7a29ebe7a2f169ee62 Author: Katrin Fischer Date: Sun Feb 23 21:25:00 2020 +0000 Bug 24605: (QA follow-up) Fix unencoded series link in staff interface Same change as the first patch, but for the staff detail page. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 6298eafa642529283ed82f72638bb434762a2c15) Signed-off-by: Lucas Gass commit e94543c454e1de6688f910515885757f1b467caf Author: Nick Clemens Date: Thu Feb 6 17:45:07 2020 +0000 Bug 24605: Fix unencoded series link To test: 1 - Add an 830 to a record with a volume subfield separated by a semicolon 830$aThe series ;$vvol 8. 2 - View the record in the opac 3 - Click the series link, no results 4 - View the link url - the semicolon is not encoded 5 - Apply patch 6 - link works 7 - URL is corrrectly encoded Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit e3cffae41f82fb22100bcf269696107cb102660e) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Apr 8 18:04:50 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 08 Apr 2020 16:04:50 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-14-ga71ceb222d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via a71ceb222d623c3492f235f80817fc6ecc85027a (commit) via 98e48a892c875ec5e4a6195ec1b7b449be4bb383 (commit) from 0870bb6da6191759512e8b7a29ebe7a2f169ee62 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a71ceb222d623c3492f235f80817fc6ecc85027a Author: Marcel de Rooy Date: Tue Feb 25 13:40:52 2020 +0000 Bug 24294: (QA follow-up) Add rollback and 008 default test Default for 008 was not tested yet. Only wondering if we should insert default values only when we meet an undefined value. Or should we also add if we meet an empty string? Is the latter not more realistic in MARC? Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 9056d53e32667ae997516a00586c02f567cb948a) Signed-off-by: Lucas Gass commit 98e48a892c875ec5e4a6195ec1b7b449be4bb383 Author: Jonathan Druart Date: Thu Jan 2 12:09:27 2020 +0100 Bug 24294: Add default value support for control fields in ACQ framework When trying to add an order using the ACQ framework with a 008@ tag, Koha explodes: Control fields (generally, just tags below 010) do not have subfields, use data() at /home/vagrant/kohaclone/C4/Acquisition.pm line 3272. Test plan: Set a default value for a control field in the ACQ framework Turn on UseACQFrameworkForBiblioRecords Create a new order from a new record The default value should be displayed Save => No crash Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit dec127df2ab986ed555f7a2cadc94491abecfbfe) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/Acquisition.pm | 24 ++++++++++++++++------ t/db_dependent/Acquisition/FillWithDefaultValues.t | 18 +++++++++++++++- 2 files changed, 35 insertions(+), 7 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Apr 8 23:27:07 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 08 Apr 2020 21:27:07 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-15-g06a39725e2 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 06a39725e22dbf4837bbb1c04fabc3ea0e83904d (commit) from a71ceb222d623c3492f235f80817fc6ecc85027a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 06a39725e22dbf4837bbb1c04fabc3ea0e83904d Author: Nick Clemens Date: Tue Feb 25 18:51:41 2020 +0000 Bug 24732: Set DumpTemplateVars Dumper options for Indent and Sort To test: 1 - Enable sysprefs DumpTemplateVarsOpac DumpTemplateVarsIntranet 2 - View some pages on staff client and opac 3 - View the page source 4 - See a large mass of comments including the page vars at the top of the source 5 - Refresh page and note order of vars changes 6 - Apply patch 7 - View page source on some pages and note things are much easier to read 8 - Refresh page and note variable order does not change Signed-off-by: George Williams Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit a0808619e86f9902546bc9d221db4c33567f2fac) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-open.inc | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-open.inc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Apr 8 23:59:25 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 08 Apr 2020 21:59:25 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-16-ga367c5229f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via a367c5229fe29375a987de6cc62c58ec0f11046c (commit) from 06a39725e22dbf4837bbb1c04fabc3ea0e83904d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a367c5229fe29375a987de6cc62c58ec0f11046c Author: Nazlı Çetin Date: Fri Feb 21 14:33:42 2020 +0000 Bug 21879: Code cleaning in printinvoice.pl Coming from commit 51aa6db46c604aa202a3d8f8e5028557480efbd5 Bug 12001: Move GetMemberAccountRecords to the Koha namespace Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize (cherry picked from commit f9f7b5cc80eb84309dd1ff667e3166e0e8634ef4) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: members/printinvoice.pl | 12 ------------ 1 file changed, 12 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Apr 9 00:04:14 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 08 Apr 2020 22:04:14 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-17-g63374a8db6 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 63374a8db6f759c8bb3e9b6ca1029ad07d2bb938 (commit) from a367c5229fe29375a987de6cc62c58ec0f11046c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 63374a8db6f759c8bb3e9b6ca1029ad07d2bb938 Author: Nick Clemens Date: Wed Feb 26 03:16:26 2020 +0000 Bug 24733: created_by param should be an arrayref We allow for the user to add multiple users to this field, and the search function expects and array. We have been treating it as a scalar TO test: 1 - Have an open basket in acquisitions 2 - Add to basket - from an existing order (copy) 3 - Enter a name in the 'Basket created by' field and select a user 4 - Hit search 5 - ISE (Can't use string ("1") as an ARRAY ref while "strict refs" in use at /usr/share/koha/lib/C4/Acquisition.pm line 2482.) 6 - Apply patch 7 - Repeat 1-4 8 - Success! 9 - Test with mutiple 'created by' entries as well Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize (cherry picked from commit 789866e585be0a5c439559383325cbe4db525412) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: acqui/duplicate_orders.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Apr 9 00:18:01 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 08 Apr 2020 22:18:01 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-18-g67a4e40f5c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 67a4e40f5cd1866d5ed27f211800731bd4c14764 (commit) from 63374a8db6f759c8bb3e9b6ca1029ad07d2bb938 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 67a4e40f5cd1866d5ed27f211800731bd4c14764 Author: Andrew Fuerste-Henry Date: Thu Feb 27 14:09:02 2020 -0600 Bug 24747: Corrects on-screen instructions in branch transfer limits To test: 1- go to cgi-bin/koha/admin/branch_transfer_limits.pl 2- see wording "Check the boxes for the libraries you accept to checkin items from" 3- apply patch 4- see wording "Check the boxes for the libraries you allow your items to be transferred to" To verify new wording accuractely describes behavior: 1- Set UseBranchTransferLimits set to Enforce using itemtype 2- Confirm circ rules allow holds 3- Confirm hold policy by item type allows holds 4- Confirm all branches are valid pickup locations in branch setup 5- In Branch Transfer Limits, set dropdown to Branch A, select itemtype Book, disable all transfers so Branch A does not accept books from any other branch 6- Find a patron from Branch A 7- Find a book from Branch B 8- On the intranet, successfully place hold on item for patron for pickup at branch A 9- Cancel hold 10- Log into opac as patron 11- Successfully place hold on item for pickup at Branch A 12- Cancel hold 13- In Branch Transfer Limits, set dropdown to Branch A, select itemtype Book, ENABLE all transfers so Branch A DOES accept books from any other branch 14- In Branch Transfer Limits, set dropdown to Branch B, select itemtype Book, disable all transfers so Branch B does not accept books from any other branch 15- On the intranet, try to place a hold on item for patron, confirm Branch B is your only pickup option 16- On the OPAC, log in as patron, try to place a hold on item, confirm Branch B is your only pickup option Signed-off-by: Kelly McElligott Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit 84026f258909e1203f34793a1089388cd933d1c9) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/admin/branch_transfer_limits.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Apr 9 00:25:36 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 08 Apr 2020 22:25:36 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-19-ge2777a0a0d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via e2777a0a0d69cb5ee366e77fa82375ccff59e10c (commit) from 67a4e40f5cd1866d5ed27f211800731bd4c14764 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e2777a0a0d69cb5ee366e77fa82375ccff59e10c Author: Owen Leonard Date: Fri Feb 28 16:48:37 2020 +0000 Bug 23753: Add missing humanMsg library to pages using background job JavaScript The JavaScript used to process background uploads calls the humanMsg library under some circumstances. There are several templates which use background-job-progressbar.js which don't include the humanMsg assets. This patch corrects those templates. Note: upload-images.tt has been modified to remove the inclusion of background-job-progressbar.js because it was unused. To test, apply the patch and test the following processes which include background job processing: - Batch item modification -- the background job is triggered when you submit your changes - Batch record modification -- the background job is triggered when you submit your changes - Stage MARC for import -- the background job is triggered when you click the "Sage for import" button after uploading a file - Staged MARC management -- the background job is triggered when you click "Import this batch into the catalog" In each case the process should complete correctly. If you would like to test the error message handling provided by the humanMsg library you can deliberately introduce an error into the JavaScript. After applying the patch you can modify js/background-job-progressbar.js to alter line 63 from: url: f.action, ...to: url: f.action + "foo", Perform the same tests and confirm that you see an error message. Don't forget to undo your changes to background-job-progressbar.js before signing off. Signed-off-by: Maryse Simard Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 4516a3ead6577131cc8087527a6d0c42158597f8) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt | 3 ++- .../intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt | 2 ++ koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt | 2 ++ koha-tmpl/intranet-tmpl/prog/en/modules/tools/stage-marc-import.tt | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/tools/upload-images.tt | 1 - 5 files changed, 7 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Apr 9 00:28:15 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 08 Apr 2020 22:28:15 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-20-gc077e5a806 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via c077e5a80676767cd059ebbfa8c2e8c140cc5d37 (commit) from e2777a0a0d69cb5ee366e77fa82375ccff59e10c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c077e5a80676767cd059ebbfa8c2e8c140cc5d37 Author: Maryse Simard Date: Wed Aug 21 17:20:16 2019 -0400 Bug 23488: Line wrapping doesn't always respect word order in Patron card creator When wrapping long lines of text, the line is divided by removing each word from the end of the line and putting it in a new one until the line is the right width. When the word to be removed appears multiple time in the line, it is not the last occurrence that is removed. This patch changes the regular expression used to remove the part of the text that is wrapped to a new line, making sure it removes it at the end of the text. Test plan: 1. Go to Tools > Patron card creator 2. Have a card template and a card batch -> If needs be, you can create them by using New > Card template or New > Card batch 3. Create a layout and use one text field containing a long text with at least one word which is repeated a minimum of 2 times (preferably towrdds the end of the text, since it has to be picked as one of the words to appear in the new line). You can use this: one two three one two three one two three one two three one two three one two three one two three one two three ... 4. Go to Manage > Card batches and export a batch 5. Choose the layout set up in 3. 6. Click the Export button and open the resulting pdf file 7. Notice all the repeated word have been grouped -> For this example : all of the ones appear first, followed by all the twos and only then the threes. 8. Apply patch 9. Repeat step 4 through 7 => this time the order of the words has not changed! Signed-off-by: Gabriel DeCarufel Signed-off-by: William Frazilien Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 5811331a5a07b84c39de7485fd2d21df7d45be34) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/Patroncards/Patroncard.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Apr 9 00:37:42 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 08 Apr 2020 22:37:42 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-21-g97df645697 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 97df645697f238f503d6afe1105d203eacd6fc51 (commit) from c077e5a80676767cd059ebbfa8c2e8c140cc5d37 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 97df645697f238f503d6afe1105d203eacd6fc51 Author: David Cook Date: Mon Jan 13 17:05:17 2020 +1100 Bug 17464: Order deny,allow / Deny from all was deprecated in Apache 2.4 and is now a hard error Patch change Apache access control from 2.2 to 2.4 directives. Test plan: 0. Apply patch 1. Build Koha from source 2. Copy or symlink koha-dev/etc/koha-httpd.conf into your relevant Apache directory. 3. Reload Apache 4. Note a lack of syntax errors regarding the "Order" directive Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit c0422998f89daf82eb898ddb951d46df97a6f1e4) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: etc/koha-httpd.conf | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Apr 9 22:03:45 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 09 Apr 2020 20:03:45 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-22-gc779db2d75 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via c779db2d75d2808b8a4b36f53bf467ec8dd5a33d (commit) from 97df645697f238f503d6afe1105d203eacd6fc51 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c779db2d75d2808b8a4b36f53bf467ec8dd5a33d Author: Jonathan Druart Date: Thu Feb 13 12:03:36 2020 +0100 Bug 17532: Make koha-shell propagate the error code Context: I am trying to make koha-misc4dev stop when something wrong happens. Basically we do not want the process to continue of the DB has not been populated correctly. It will make the errors easier to catch. The issue: Say a script that will return an error (die in perl for an easy example), koha-shell will not return the 255 error code, but 0 instead. The caller cannot know something wrong happened The solution is to propagate the error and make koha-shell return the same error code as the command it executed An example: === t.pl === die('something wrong'); % perl t.pl;echo $? something wrong at t.pl line 1. 255 % sudo koha-shell kohadev -p -c 'perl xxx.pl' ; echo $? something wrong at xxx.pl line 1. 0 Signed-off-by: Tomas Cohen Arazi Tested it with $ sudo debian/scripts/koha-shell kohadev -c 'exit 8' $ echo $? 8 The unpatched version returns 0 (forgets about the error code). Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 5d22e0b3a331e35b8f1e494bc366c1624c982cf8) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: debian/scripts/koha-shell | 2 ++ 1 file changed, 2 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Apr 9 22:06:11 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 09 Apr 2020 20:06:11 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-23-ge5cf4065d1 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via e5cf4065d11d850e89b614148be58f766638698d (commit) from c779db2d75d2808b8a4b36f53bf467ec8dd5a33d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e5cf4065d11d850e89b614148be58f766638698d Author: Julian Maurice Date: Fri Jan 31 11:13:47 2020 +0100 Bug 24552: Be compatible with Search::Elasticsearch 6.00 There is no need to specify the `client` param here because '5_0::Direct' is the default value for Search::Elasticsearch 5.x and it breaks when Search::Elasticsearch 6.x is installed Test plan: 1. Apply the patch 2. Make sure you have Search::Elasticsearch 5.x 3. Reload starman 4. Verify that search works 5. Install Search::Elasticsearch 6.x 6. Reload starman 7. Verify that search works Signed-off-by: Michal Denar Signed-off-by: Ere Maijala Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit a3143506b2edf7ffca185e650c18b89dc249423f) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: Koha/SearchEngine/Elasticsearch.pm | 1 - 1 file changed, 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Apr 9 22:14:26 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 09 Apr 2020 20:14:26 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-24-gd8cb07d665 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via d8cb07d6658850a84f125956d6f058a1fa72de74 (commit) from e5cf4065d11d850e89b614148be58f766638698d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d8cb07d6658850a84f125956d6f058a1fa72de74 Author: David Cook Date: Thu Feb 27 00:28:48 2020 +0000 Bug 24719: Remove use of CGI object in C4::Context::set_remote_address() This patch replaces the CGI "http" object method with its equivalent class method, which doesn't require object instantiation and thus skips global initialization and premature handling of the incoming HTTP request. Test plan: 0. Disable Plack if it is enabled 1. Set koha_trusted_proxies in koha-conf.xml to 1.1.1.1 2. Clear Memcached 3. Try to upload MARCXML file to /cgi-bin/koha/tools/stage-marc-import.pl 4. Note that form below "Upload progress" never appears and errors show in browser console 5. Apply the patch 6. Try to upload MARCXML file to /cgi-bin/koha/tools/stage-marc-import.pl 7. Note that form appears below "Upload progress" Signed-off-by: Nick Clemens Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 74e3ef126c5992ac049a35c75a7d3879669d7a49) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/Context.pm | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Apr 9 22:16:07 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 09 Apr 2020 20:16:07 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-25-g1f9ef66e4f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 1f9ef66e4f024e1e44c088ca02dd1af81e452a5c (commit) from d8cb07d6658850a84f125956d6f058a1fa72de74 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1f9ef66e4f024e1e44c088ca02dd1af81e452a5c Author: Lucas Gass Date: Thu Apr 9 19:49:11 2020 +0000 Revert "Bug 24719: Remove use of CGI object in C4::Context::set_remote_address()" This reverts commit d8cb07d6658850a84f125956d6f058a1fa72de74. Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/Context.pm | 19 ------------------- 1 file changed, 19 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Apr 9 22:33:41 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 09 Apr 2020 20:33:41 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-26-gb791fabc93 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via b791fabc939ace33aa915d3ae6e2480ce2901581 (commit) from 1f9ef66e4f024e1e44c088ca02dd1af81e452a5c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b791fabc939ace33aa915d3ae6e2480ce2901581 Author: Owen Leonard Date: Wed Mar 4 18:29:24 2020 +0000 Bug 24798: smart-rules.tt has erroneous comments This patch corrects a couple of invalid Template Toolkit comments in the Circulation and Fines rules template. To test, apply the patch and log into the staff client as an administrator. On the Circulation and Fines Rules page "View source" and look for instances of the text "[#% Default branch %#]" There should be none. Signed-off-by: David Nind Signed-off-by: Marcel de Rooy [EDIT] There is a theoretical difference between [% # and [%#. The latter marks the whole directive as a comment and not just until EOL. Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 1fbd4468642aa09b999b3baf014b6f3a0afd6df8) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Apr 9 22:38:19 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 09 Apr 2020 20:38:19 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-27-g76ecea1430 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 76ecea1430bbbf236ab60064b4c81fe2a60d9d9b (commit) from b791fabc939ace33aa915d3ae6e2480ce2901581 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 76ecea1430bbbf236ab60064b4c81fe2a60d9d9b Author: Fridolin Somers Date: Thu May 23 07:55:15 2019 +0200 Bug 22969: fix biblionumber on 001 in UNIMARC XSLT In UNIMARC default configuration the 001 is linked to biblio.biblionumber. In some XSLT files, 090$a is used. This is by default biblioitems.biblionumber so it usually works but it may not be the same and var biblionumber is used to create hyperlinks to record detail page. Test plan : 1) Use UNIMARC database 2) Set default in all XSLT system preferences 3) At OPAC, perform a search and click on a result 4) Check displayed page shows the correct biblio record 5) Same at intranet Signed-off-by: Bernardo Gonzalez Kriegel Tested on clean UNIMARC install. Before insert new records: "alter table biblioitems AUTO_INCREMENT = 5" Added two records, with result: +--------------+------------------+ | biblionumber | biblioitemnumber | +--------------+------------------+ | 1 | 5 | | 2 | 6 | +--------------+------------------+ Without patch, OPAC results shows for first record http://opac/cgi-bin/koha/opac-detail.pl?biblionumber=5, Wrong! with patch result is correct Works, no errors Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 5bf9a83495971a196224f9342394a5b2d065d3e1) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/xslt/UNIMARCslim2intranetDetail.xsl | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslim2OPACDetail.xsl | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslim2OPACResults.xsl | 6 ++---- 3 files changed, 4 insertions(+), 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Apr 9 22:44:14 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 09 Apr 2020 20:44:14 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-28-g1993e98edf Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 1993e98edf0c272d6d93e18292a5c8b79da4b458 (commit) from 76ecea1430bbbf236ab60064b4c81fe2a60d9d9b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1993e98edf0c272d6d93e18292a5c8b79da4b458 Author: Jonathan Druart Date: Thu Mar 5 16:27:15 2020 +0100 Bug 24813: Prevent api/v1/holds.t to fail randomly Hold cannot be suspended if found=W: Koha::Hold->suspend_hold 90 if ( $self->is_found ) { # We can't suspend found holds So when TestBuilder generate a hold with found=W the test fail. A question however: Why did not we have the correct exception displayed somewhere? That would be much more helpful to find the problem! Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit c405b03dd367adb7c1c274477865a7444f59c9e9) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: t/db_dependent/api/v1/holds.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Apr 9 23:07:24 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 09 Apr 2020 21:07:24 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-29-gbcf6cdb6ea Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via bcf6cdb6eaa683adcd0cf2c51f229b5f0942ddac (commit) from 1993e98edf0c272d6d93e18292a5c8b79da4b458 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit bcf6cdb6eaa683adcd0cf2c51f229b5f0942ddac Author: David Gustafsson Date: Tue Mar 3 14:32:31 2020 +0100 Bug 24788: Remove autoloaded column accessors in Koha::Object->store Columns are accessed as methods, relying on AUTOLOAD, in Koha::Object->store. This could be a source of strange bugs if a column name clashes with an existing method name. To test: 1) Apply patches for Bug 14957 2) Follow the testing instructions, when saving a new marc rule and error is thrown. 3) Apply patch 4) Try saving a new rule once again, this should now work Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 508a6ad027b34c2279fbb1ff994152144b38ceb8) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: Koha/Object.pm | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Apr 9 23:11:41 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 09 Apr 2020 21:11:41 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-31-g8e1b95951f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 8e1b95951f374a8b524330e70668fb98043920e7 (commit) via 3f556c45695781cc50fa746975550af7818c7f32 (commit) from bcf6cdb6eaa683adcd0cf2c51f229b5f0942ddac (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8e1b95951f374a8b524330e70668fb98043920e7 Author: Marcel de Rooy Date: Fri Mar 6 11:13:15 2020 +0000 Bug 24760: (follow-up) Add a neighboring test messsage Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 390f838d27984ea47572b729145b1268e9866f29) Signed-off-by: Lucas Gass commit 3f556c45695781cc50fa746975550af7818c7f32 Author: Julian Maurice Date: Fri Feb 28 14:22:34 2020 +0100 Bug 24760: Use C4::BackgroundJob->fetch in tests Starting with YAML 1.30 and YAML::Syck 1.32, these modules don't bless loaded objects by default. This is not a problem as C4::BackgroundJob->fetch bless them anyway. So, instead of testing what's in the session, test the result of C4::BackgroundJob->fetch, which is what's used everywhere else Test plan: 1. Install latest version of YAML::Syck (or YAML if YAML::Syck is not installed) 2. prove t/db_dependent/BackgroundJob.t => should FAIL 3. Apply patch 4. prove t/db_dependent/BackgroundJob.t => should PASS 5. Verify that background jobs are still working (for instance, tools/batchMod.pl) Signed-off-by: Michal Denar Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit c1c3cfed5ca2709b99587e8907b68d158ce013f9) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: t/db_dependent/BackgroundJob.t | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Apr 9 23:17:13 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 09 Apr 2020 21:17:13 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-32-gd35840f11d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via d35840f11dfdc74baed4acdfb6a49939bd5916a0 (commit) from 8e1b95951f374a8b524330e70668fb98043920e7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d35840f11dfdc74baed4acdfb6a49939bd5916a0 Author: Jonathan Druart Date: Tue Feb 18 16:13:11 2020 +0100 Bug 23384: Fix use statement order for ArticleRequest::Status Koha::ArticleRequest is used by Koha::ArticleRequests so Koha::ArticleRequest::Status should not be needed in Koha::ArticleRequest. Also Koha::ArticleRequest::Status must be loaded before Koha::ArticleRequest Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 00379c189976ac9e7e2429f5261a0b562206fc5d) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: Koha/ArticleRequest.pm | 1 - Koha/ArticleRequests.pm | 2 +- Koha/Patron.pm | 2 ++ 3 files changed, 3 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Apr 9 23:23:23 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 09 Apr 2020 21:23:23 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-40-g445847db69 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 445847db6900349987d7fb265ea08017dc626d50 (commit) via a700428bbc9845caa554597f0cd0af04f1afe707 (commit) via cebaf458140e34fad7a7dcae077c0e0326a95d25 (commit) via 032a0011401fb0e66d5c16bfe88580584acded57 (commit) via 2f869f288ffb46bba401deafcfa420103f3bdc66 (commit) via 6e0d48f14e885ad5cf3a7ee191f1110150a714b6 (commit) via 0f0e097bc79bc6452d1161bfd7a89a01f5c012c6 (commit) via 6f9c8b9e1c597d9e7599b5a9abcd9d4147924a9f (commit) from d35840f11dfdc74baed4acdfb6a49939bd5916a0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 445847db6900349987d7fb265ea08017dc626d50 Author: Jonathan Druart Date: Tue Feb 4 12:09:00 2020 +0100 Bug 19008: Replace issues with checkouts in print statement Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit d6a0b07984ed63e91723fa484890f111077dbd10) Signed-off-by: Lucas Gass commit a700428bbc9845caa554597f0cd0af04f1afe707 Author: Magnus Enger Date: Fri Aug 2 13:57:13 2019 +0200 Bug 19008: More database cleanups - QA followup This patch tries to change the POD as suggested in the QA process. Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit a5e723b887fe085ba36527bbf14e4c1d9d30556d) Signed-off-by: Lucas Gass commit cebaf458140e34fad7a7dcae077c0e0326a95d25 Author: Fridolin Somers Date: Fri Jul 28 16:09:14 2017 +0200 Bug 19008: More database cleanups - item transfers misc/cronjobs/cleanup_database.pl provides some database cleanup. Yet some tables that could need cleanup are not in this script. This patch adds cleanup for branchtransfers table. Test plan : - Count : select count(*),datearrived from branchtransfers group by datearrived; - Run cleanup : misc/cronjobs/cleanup_database.pl -v --transfers 30 - Recount Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit dd8df39986ebc7c055894fea0148f900ba4a3a45) Signed-off-by: Lucas Gass commit 032a0011401fb0e66d5c16bfe88580584acded57 Author: Fridolin Somers Date: Fri Jul 28 16:01:51 2017 +0200 Bug 19008: More database cleanups - old reserves misc/cronjobs/cleanup_database.pl provides some database cleanup. Yet some tables that could need cleanup are not in this script. This patch adds cleanup for old_reserves table. Test plan : - Count : select count(*),date(timestamp) from old_reserves group by date(timestamp); - Run cleanup : misc/cronjobs/cleanup_database.pl -v --old-reserves 30 - Recount Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 9ce0f3a73e4de58fb04f4e7977a6299e4b480b5b) Signed-off-by: Lucas Gass commit 2f869f288ffb46bba401deafcfa420103f3bdc66 Author: Fridolin Somers Date: Fri Jul 28 14:57:33 2017 +0200 Bug 19008: More database cleanups - old issues misc/cronjobs/cleanup_database.pl provides some database cleanup. Yet some tables that could need cleanup are not in this script. This patch adds cleanup for old_issues table. Test plan : - Count : select count(*),date(timestamp) from old_issues group by date(timestamp); - Run cleanup : misc/cronjobs/cleanup_database.pl -v --old-issues 30 - Recount Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit ce96ed4336f99d97c31bc87cfea3369ddfaf0a02) Signed-off-by: Lucas Gass commit 6e0d48f14e885ad5cf3a7ee191f1110150a714b6 Author: Fridolin Somers Date: Fri Jul 28 14:43:45 2017 +0200 Bug 19008: More database cleanups - deleted patrons misc/cronjobs/cleanup_database.pl provides some database cleanup. Yet some tables that could need cleanup are not in this script. This patch adds cleanup for deletedborrowers table. Test plan : - Count : select count(*),date(updated_on) from deletedborrowers group by date(updated_on); - Run cleanup : misc/cronjobs/cleanup_database.pl -v --deleted-patrons 30 - Recount Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit f2aeaede38b05cb93146d9fbe86bcd4a2a76b8d5) Signed-off-by: Lucas Gass commit 0f0e097bc79bc6452d1161bfd7a89a01f5c012c6 Author: Fridolin Somers Date: Fri Jul 28 14:05:03 2017 +0200 Bug 19008: More database cleanups - deleted catalog misc/cronjobs/cleanup_database.pl provides some database cleanup. Yet some tables that could need cleanup are not in this script. This patch adds cleanup for deleted catalog tables. Note that deletedbiblio_metadata is managed by foreign key on biblionumber. Test plan : - Count : select count(*),year(timestamp) from deleteditems group by year(timestamp); select count(*),year(timestamp) from deletedbiblio group by year(timestamp); select count(*),year(timestamp) from deletedbiblioitems group by year(timestamp); - Run cleanup : misc/cronjobs/cleanup_database.pl -v --deleted-catalog 30 - Recount Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit a0a579d773c95ec87a647497cc755b0a4cc7f55f) Signed-off-by: Lucas Gass commit 6f9c8b9e1c597d9e7599b5a9abcd9d4147924a9f Author: Fridolin Somers Date: Fri Jul 28 14:12:22 2017 +0200 Bug 19008: More database cleanups - statistics misc/cronjobs/cleanup_database.pl provides some database cleanup. Yet some tables that could need cleanup are not in this script. This patch adds cleanup for statistics table. Test plan : - Count statistics : select count(*),date(datetime) from statistics group by date(datetime); - Run cleanup : misc/cronjobs/cleanup_database.pl -v --statistics 30 - Recount statistics Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 20118bb795ce046c2b00152aeccb94ae998375e6) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: misc/cronjobs/cleanup_database.pl | 114 +++++++++++++++++++++++++++++++++++++- 1 file changed, 113 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 13 20:35:32 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 13 Apr 2020 18:35:32 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-68-g80f886090b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 80f886090bc0e72396fd4f0d5f0c8bf9eebcd394 (commit) from 8ef75d10e46f45f6e4fae634e5262d2415b1a7b1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 80f886090bc0e72396fd4f0d5f0c8bf9eebcd394 Author: Kyle M Hall Date: Mon Feb 3 07:56:37 2020 -0500 Bug 24566: UpdateItemLocationOnCheckin triggers SIP2 alert flag, even with checked_in_ok enabled If UpdateItemLocationOnCheckin, it triggers an alert flag but cannot be acted on in the same way as LocalUse and thus should be removed in the same fashion. Test Plan: 1) Enable UpdateItemLocationOnCheckin and set it up to trigger at checkin for an item 2) Return that item via SIP2 3) Note the alert flag is set 4) Apply this patch 5) Repeat steps 1 and 2 6) The alert flag should not be set Signed-off-by: Kyle M Hall Signed-off-by: Kevin Cook Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 77d9b7e79995ec0acfc11ba290d5c990417778d9) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/SIP/ILS/Transaction/Checkin.pm | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 13 21:45:44 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 13 Apr 2020 19:45:44 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-70-g707f7e6bbc Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 707f7e6bbcfeece5cf8801cb4f1fbc9c4dc087cf (commit) via 8052278d1ec60cd49cd78b37e4959b9cfa17096d (commit) from 80f886090bc0e72396fd4f0d5f0c8bf9eebcd394 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 707f7e6bbcfeece5cf8801cb4f1fbc9c4dc087cf Author: Jonathan Druart Date: Wed Feb 26 12:51:06 2020 +0100 Bug 23900: Add tests Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit ca4f14180b90bab2e8185e919a87657c6fba0e2f) Signed-off-by: Lucas Gass commit 8052278d1ec60cd49cd78b37e4959b9cfa17096d Author: Jonathan Druart Date: Mon Nov 11 17:54:56 2019 +0100 Bug 23900: Teach label maker to concat database fields Test plan: - define a label layout with this field list: "100a 245s","enumchron copynumber" - find or create a record with values for all of those fields - generate a label for that record - the 100a and 245s successfully display on one line - the enumchron and copynumber are displayed and separated by a space Try other combinations Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 839e11eefd01c6e5bf36effaef09028c443ed386) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/Labels/Label.pm | 13 +++++++++---- t/db_dependent/Labels/t_Label.t | 37 ++++++++++++++++++++++--------------- 2 files changed, 31 insertions(+), 19 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Apr 14 10:41:28 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 14 Apr 2020 08:41:28 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1697-gd13fbc0bda Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via d13fbc0bdad3b9b75f112ca0de5a26d8f4bdc193 (commit) from 65c5407d41fd5ba8a37f163b1a02e9c5a8cfa9f8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d13fbc0bdad3b9b75f112ca0de5a26d8f4bdc193 Author: Martin Renvoize Date: Tue Apr 14 09:13:17 2020 +0100 Bug 23173: Compiled CSS Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 2 +- koha-tmpl/opac-tmpl/bootstrap/css/opac.css | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 13 19:55:37 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 13 Apr 2020 17:55:37 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-66-g42bc9671ca Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 42bc9671ca47272258cecde2abccdef521a58b56 (commit) from 3e2d76bbfaec296179dc9563bdc6024ef2d210a6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 42bc9671ca47272258cecde2abccdef521a58b56 Author: Bernardo Gonzalez Kriegel Date: Sat Mar 14 21:00:24 2020 -0300 Bug 24870: Translate installer data label This patch enable the translation of the labels 'Mandatory' or 'Optional' present at install time for groups of installer files. To test: 1) Try install using de-DE language, at step3 verify 'Mandatory' and 'Optional' labels for marc21 or other data checklist Do not close this window! 2) Apply this patch 3) Update de-DE translation files, reinstall lang files cd misc/translator ./translate update de-DE ./translate install de-DE 4) Reload page at step3, now 'Mandatory' label is translated to 'Pflichtfeld' 5) Verify strings in translation file Search for ^msgid \"Mandatory\" ^msgid \"Optional\" in po/de-DE-staff-prog.po. Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 1adc4986e9d2f715f44ef4b99b5dece79845f885) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/Installer.pm | 4 ++-- koha-tmpl/intranet-tmpl/prog/en/modules/installer/step3.tt | 10 ++++++++-- 2 files changed, 10 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 13 22:39:34 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 13 Apr 2020 20:39:34 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-80-gee5ecb043e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via ee5ecb043e985ff59fe045b5f596d8f90d907ef3 (commit) via 198484d3b9d7536ff9ee8569151e4c95b4146e03 (commit) from 2ea4f02f8462d7806f9a05d270f6d4f8e3ed9aaa (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ee5ecb043e985ff59fe045b5f596d8f90d907ef3 Author: Marcel de Rooy Date: Tue Mar 10 15:11:07 2020 +0000 Bug 21708: Sort MARC fields in TransformHtmlToMarc Instead of pushing 999 in the front :) Test plan: Do not yet apply this patch. Edit a record. Save. And open MARC view/view plain on opac-detail. Verify that the biblionumber field (MARC21 999) follows leader. Apply this patch. Restart Plack. Edit a record. Save. And open MARC view/view plain on opac-detail. Verify that the biblionumber field is in right position. Run t/db_dependent/Biblio/TransformHtmlToMarc.t. Should pass now. Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 6cb9b3634dcc06bdd69b82960a257f38fd75e0d0) Signed-off-by: Lucas Gass commit 198484d3b9d7536ff9ee8569151e4c95b4146e03 Author: Marcel de Rooy Date: Wed Mar 11 13:22:31 2020 +0000 Bug 21708: Add a few tests in TransformHtmlToMarc.t Test plan: Run t/db_dependent/Biblio/TransformHtmlToMarc.t without the module change patch. Verify that the test fails on the order of fields. Go to test plan of the second patch. Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit ca2ebddb1386665a3332ac67f7b5ce971a828c90) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/Biblio.pm | 1 + t/db_dependent/Biblio/TransformHtmlToMarc.t | 46 +++++++++++++++++++++++++++-- 2 files changed, 44 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 10 18:16:12 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Apr 2020 16:16:12 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-44-geeb0a86d0f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via eeb0a86d0ff012b7f2f2984660a94917dba2f4e7 (commit) from a31d2ca846a7d7fc62dc7e05a0136e2ee3b4db0a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit eeb0a86d0ff012b7f2f2984660a94917dba2f4e7 Author: Nick Clemens Date: Mon Mar 9 09:41:26 2020 +0000 Bug 19288: Don't show patron info for item level holds on details.pl unless hold is waiting This persists after bug 20948 - we can still display patron information even if this patron is not the one who will receive the item upon checkin. The holds tab can give an overview of holds and information - I think on the details page the only info we need is whether there might be a item level hold, not who it is for To test: 1 - Place an item level hold for delivery at a branch not matching home branch of item 2 - Place a record level hold for delivery at homebranch of item placed on hold above 3 - Enable LocalHoldsPriority with 'pickup library' matches the item's 'home library' 4 - View the details for the page, it says the item has a hold for the patron with an item level hold 5 - Check in the item, the hold triggered is for the next available patron, ignore the hold 6 - Apply patch 7 - Check details page, 'There is an item-level hold (priority=1)' with no patron info 8 - Check in, next available hold is still the one triggered Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 2c2e229709e723c7604fecf0a5607486ed1e6d14) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 13 19:02:38 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 13 Apr 2020 17:02:38 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-59-g22e48c05e2 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 22e48c05e2311539078ca0801dc6b4278cf2f58d (commit) via 0acd6c823aa0f8e45ae6dcb39bb6f18e45a745ea (commit) from ed09fd488d02e249af6c41a05898d2eb7b892e41 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 22e48c05e2311539078ca0801dc6b4278cf2f58d Author: Jonathan Druart Date: Wed Mar 18 13:43:52 2020 +0100 Bug 24200: (follow-up) Try to fix random failures from Borrower_PrevCheckout.t 2 other occurrences where missing. Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit d4db0b96e8753b1b213b6a2efeea7a61baf0ac7e) Signed-off-by: Lucas Gass commit 0acd6c823aa0f8e45ae6dcb39bb6f18e45a745ea Author: Jonathan Druart Date: Fri Jan 10 11:48:09 2020 +0100 Bug 24200: Try to fix random failures from Borrower_PrevCheckout.t It failed inconsistently, let's try to use build_sample_item and see if it fixes the random failures. Test plan: % prove t/db_dependent/Patron/Borrower_PrevCheckout.t must return green Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit d5e9dc31ca66cff586125d1bbcff8de8bc089387) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: t/db_dependent/Patron/Borrower_PrevCheckout.t | 32 +++++++-------------------- 1 file changed, 8 insertions(+), 24 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 13 22:58:14 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 13 Apr 2020 20:58:14 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-83-g3a21d8d4f3 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 3a21d8d4f3576490e17a422789fd2550e90e2c64 (commit) from 81f26f5276df9439f093c560127451dfe8c656a1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3a21d8d4f3576490e17a422789fd2550e90e2c64 Author: Bernardo Gonzalez Kriegel Date: Sun Mar 15 11:39:42 2020 -0300 Bug 24872: Set languages prefererences after install This patch set 'languages' and 'opaclanguages' system preferences with the language used during install. To test: 1. Apply the patch 2. Do a clean install in a language other than english 3. Verify that 'languages' and 'opaclanguages' system preferences show the language code used during install, besides english. Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 6705ca9d4ee0d32c7808ee7aba30ffa744625ef1) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/Installer.pm | 26 ++++++++++++++++++++++++++ installer/install.pl | 5 +++++ 2 files changed, 31 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 13 23:16:04 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 13 Apr 2020 21:16:04 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-88-g45078456b4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 45078456b49382395f89bca54457cdac2d5f775d (commit) from 98178e0bb8162c648b03b32f54d609b3990b4e83 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 45078456b49382395f89bca54457cdac2d5f775d Author: Nick Clemens Date: Thu Jan 9 15:53:45 2020 +0000 Bug 24386: Prevent double form submission on adding orders to basket from a file To test: 1 - Have a marc record file 2 - Go to Acquisitions, find a vendor, then an open basket 3 - Add to basket from a new file (if you already have one staged you can choose that instead) 4 - Import the file, then add to basket 5 - On the page where you select the records and set info select a record, set matching to 'Do not check' fill in the fund for the order 6 - When ready, click save as many times as you can 7 - When you go to the basket there are many copies of the order added 8 - Don't despair, apply the patch 9 - Repeat above 10 - When ready to add orders, click furiously 11 - The order is only added once! 12 - Success! Signed-off-by: Sally Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit bf8ed831f83987eadd7de4455673da28877499f4) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/js/addorderiso2709.js | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 10 18:07:32 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Apr 2020 16:07:32 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-42-gbacd18d29b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via bacd18d29b1b2e5ceeb8ec7ca4a0dcbccd418d87 (commit) from 419d5064257b8163601a6e20637f4ec62b91febc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit bacd18d29b1b2e5ceeb8ec7ca4a0dcbccd418d87 Author: Andrew Fuerste-Henry Date: Wed Mar 11 00:54:03 2020 +0000 Bug 24838: Fix help link for patron categories To test: - go to admin/categories.pl - click Help, confirm it takes you to manual main page - apply patch - restart all - click Help, confirm it takes you to patron categories in manual Signed-off-by: Sally Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 5fbde57bbcb5c4035c6e7a5a7416ebbc407719e2) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: Koha/Manual.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 10 18:20:54 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Apr 2020 16:20:54 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-47-g5d52c0076f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 5d52c0076f91a8fa0bf087736a957deed53bb8a6 (commit) via b66e890f8495a7bf785310af957226973db04b0d (commit) via 70b49296512b341355ffbcc74513c5aa1ef6790c (commit) from eeb0a86d0ff012b7f2f2984660a94917dba2f4e7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5d52c0076f91a8fa0bf087736a957deed53bb8a6 Author: Jonathan Druart Date: Thu Mar 12 15:09:02 2020 +0100 Bug 5103: Refactor the code to avoid repetition Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 572c3afef1a3b6dfe3ee4d841737170ee92b7e1f) Signed-off-by: Lucas Gass commit b66e890f8495a7bf785310af957226973db04b0d Author: Aleisha Amohia Date: Wed Mar 11 03:08:12 2020 +0000 Bug 5103: (follow-up) Using mapped item fields instead of hardcoding subfields Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 37de3685a4d527663f98ca11d09b4d911e00a770) Signed-off-by: Lucas Gass commit 70b49296512b341355ffbcc74513c5aa1ef6790c Author: Aleisha Amohia Date: Wed Feb 26 02:52:24 2020 +0000 Bug 5103: Format dates in MARC detail using dateformat syspref This patch fixes the formatting of dates on the following pages: - catalogue/MARCdetail.pl (staff) - cataloguing/additem.pl (staff) - opac-MARCdetail.pl (opac) To test: 1) Ensure that the following fields are visible in the opac, intranet and editor. You may need to edit the subfields in your default bibliographic framework 952$d date accessioned 952$q date due/on loan 952$r date last seen 952$s date last borrowed 952$w replacement price date Also ensure you have dateformat system preference set 2) Go to cataloguing/additem.pl for a biblio. Fill in the fields above if required. Save 3) Remain on cataloguing/additem.pl. Notice the items table at the top of the page, the dates are in the generic yyyy-mm-dd format 4) Go to catalogue/MARCdetail.pl for that biblio. Notice dates in wrong format 5) View this biblio in the opac opac-MARCdetail.pl. Scroll to bottom to items table. Notice dates in wrong format. 6) Apply patch, restart memcached and plack and refresh pages 7) Dates should now be formatted according to dateformat preference 8) Confirm that changing the preference changes the format of the dates Sponsored-by: Catalyst IT Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 16d756791ece7325f4541b7f2b7caaee7c9c12c5) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: catalogue/MARCdetail.pl | 7 +++++++ cataloguing/additem.pl | 22 ++++++++++++++++++++-- opac/opac-MARCdetail.pl | 8 ++++++++ 3 files changed, 35 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 13 19:27:39 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 13 Apr 2020 17:27:39 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-64-g5418efe482 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 5418efe4824d4ec11e44fc40bda35294190ab0c7 (commit) from 0935c5d350b008ea0a4fe4da541f5cf3fffc9323 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5418efe4824d4ec11e44fc40bda35294190ab0c7 Author: Marcel de Rooy Date: Mon Mar 2 11:08:18 2020 +0000 Bug 24756: [19.11.X] Catch two failed to load-variations in Security.t Test 7 in Security.t failed when 'failed to load HTTP resource' was returned by libxml2 instead of 'failed to load external entity'. We now remove the debugging with Dumper again and adjust the regex to include both variations. Signed-off-by: Marcel de Rooy Signed-off-by: Joy Nelson (cherry picked from commit 09b8c38a8264c55ae5e7187cb76e608a072729fd) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: t/db_dependent/Koha/XSLT/Security.t | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 13 22:18:38 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 13 Apr 2020 20:18:38 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-75-g798f176f29 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 798f176f2908ad7b53b6da6341c512a4398d6b86 (commit) from 1df598be10f83c76038f14eb40a14882d6323fb4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 798f176f2908ad7b53b6da6341c512a4398d6b86 Author: Katrin Fischer Date: Fri Mar 13 17:40:38 2020 +0000 Bug 24848: Improve manual links for the label creator Some of the manual links in the label creator tool were not working correctly or pointing to the wrong pages. A problem is the label-manage.pl file. This can show different data depending on an added parameter. Example: /cgi-bin/koha/labels/label-manage.pl?label_element=template But it appears that parameters will be ignored when creating links to the manual. So this patch links to the beginning of the label creator section in the manual for now. To test: - Go to the lable creator - Try the various pages of the tool - Note: All 'New ...' links should point to the correct section in the manual (batches, templates, ...) Except: Barcode range. This feature is new and not yet documented in the manual. Link goes to label creator section. - Note: All 'Manage ...' links should point to the beginning of the 'label creator' section in the manual Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit cda91af335a163b9e1d12c2aac57ec46b24ddea4) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: Koha/Manual.pm | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Apr 14 10:04:33 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 14 Apr 2020 08:04:33 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1696-g65c5407d41 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 65c5407d41fd5ba8a37f163b1a02e9c5a8cfa9f8 (commit) via 81c141d41aef41d2dbdd50b1874f4964b83d6767 (commit) via 967c781259ead4367b55cc37bf50938b1d7c984e (commit) via a9ee30774a748e23e315228b9c706acf80cc9a38 (commit) via 51e504cbfe2fe046da840a4c23090d476fcdb6f8 (commit) via 0004816118483dc132c98d27c417f1b59255441f (commit) via 7bcfa8219739312f60eb2e36f642d7ac685d9879 (commit) via 12243e35962e09b04fd247150477cbc2cfda7254 (commit) via 7d9842a7cc969571c53c9e1fafdc145bbd6036c7 (commit) via daf033945746edb60d7b76ab69204d1e859fe3ed (commit) via d54376a52374a2b83eadd40dd35d8bbfcba2de63 (commit) via 0e2119570d9c8deb0b15b8bff92975cfdfa5c3f4 (commit) via 3336147258cd71c446026919469ba052a62b6bac (commit) via ed69870da5253a3cca853d841d2e3adb844b31fb (commit) via 3dd79180f33bcdf810251638ae3984cbc832e024 (commit) via 9ac2ddda0b1506ea09a7c95a98926ea9e9c36bcf (commit) via 9e2f3200eaf2d09c0124fbf506d114b95b2f1920 (commit) via 25966df4d7164e931e35ae5a640ae85eb2644ce3 (commit) via a57efe865921c4d4945245d3970b3391490de249 (commit) via a22315ef6153d5c64b4dfd763cf6802a3035e941 (commit) via f7cb46560322ef77858c6f489ae332962942616d (commit) via f406aa2ae35c0d49a91316d00a4fca0cd0109c5c (commit) via 04e4656cd252759efae3606b8e368cfab1dbff5f (commit) via f5447b33de9ded3868d97fcf033c7acda33cc168 (commit) via 94ed64e5b1e348fcd06d2d41b880c52b6822df57 (commit) via 479474e532dca6ded90770fc7a0c00500ea4f787 (commit) via 6fa71e82f80c838f4182587f691d1c329a0941bd (commit) via 3eec846d7f49c39cb4b4079818eeb42268aca769 (commit) via aa967afa8ec12988a8118ba3b41dd3df3f3fe18f (commit) from 78b67d21c5f15bccdc7ae8f180d4f0a266196e9f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 65c5407d41fd5ba8a37f163b1a02e9c5a8cfa9f8 Author: Jonathan Druart Date: Thu Apr 2 16:03:17 2020 +0200 Bug 25044: Remove the need to define koha_object[s]_class for standard object class names In Koha::Object[s]->prefetch_whitelist, there is a call to the koha_object[s]_class DBIC resultset class. We should not, otherwise those 2 methods will have to be defined all the time, even when we can guess it easily. Koha::Item <> Schema::Result::Item => standard Koha::Acquisition::Order <> Schema::Result::Aqorder => non-standard sub _get_object_class { my ( $type ) = @_; return unless $type; if( $type->can('koha_object_class') ) { return $type->koha_object_class; } $type =~ s|Schema::Result::||; return ${type}; } Test plan: % prove t/db_dependent/Koha/Object.t t/db_dependent/Koha/Objects.t should return green before and after this patch Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 81c141d41aef41d2dbdd50b1874f4964b83d6767 Author: David Roberts Date: Mon Apr 13 01:22:07 2020 +0000 Bug 20370: Misleading comment for bcrypt - #encrypt it; Instead it should be #hash it This patch changes the wording of the comment To test: 1) Check the wording of Line 67 of Koha/AuthUtils.pm 2) Apply the patch 3) Check that the wording has changed from "Encrypt it" to "Hash it" Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 967c781259ead4367b55cc37bf50938b1d7c984e Author: Liz Rea Date: Thu Apr 9 15:50:04 2020 +0000 Bug 24993: fix increment Aparently ((i++)) isn't portable, changed for an admittedly uglier but functional increment. Signed-off-by: Jonathan Druart Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit a9ee30774a748e23e315228b9c706acf80cc9a38 Author: Jonathan Druart Date: Wed Apr 8 11:57:06 2020 +0200 Bug 24993: Make sure we are not going to loop indefinitely Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 51e504cbfe2fe046da840a4c23090d476fcdb6f8 Author: Jonathan Druart Date: Thu Apr 2 12:36:16 2020 +0200 Bug 24993: Make sure SIP server is stopped before restarting it Sometimes doing koha-sip --restart instance happens too fast and the SIP server is not started. To test: - have SIP enabled and running for your instance - issue a restart, make sure it restarts sudo koha-sip --restart inst Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 0004816118483dc132c98d27c417f1b59255441f Author: Tomas Cohen Arazi Date: Mon Mar 30 10:06:43 2020 -0300 Bug 25008: Overload Koha::RecordProcessor->options to update filters This patch overloads the 'options' accessor generated by Class:Accessor. It does so the passed options are used to refresh the loaded filters. Tests are added for this overloaded method as well. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/RecordProcessor.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 7bcfa8219739312f60eb2e36f642d7ac685d9879 Author: Tomas Cohen Arazi Date: Mon Mar 30 10:20:11 2020 -0300 Bug 25008: Tests for ->options Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 12243e35962e09b04fd247150477cbc2cfda7254 Author: Tomas Cohen Arazi Date: Fri Mar 27 17:53:32 2020 -0300 Bug 25008: Regression tests This patch highlights a behaviour of Koha::RecordProcessor that is unexpected: if you change the original options using ->options, the loaded filters don't pick the change. That's because the filter objects are loaded on ->new, and they are never updated. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/RecordProcessor.t => FAIL: Test prove ->options doesn't update the filters! Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 7d9842a7cc969571c53c9e1fafdc145bbd6036c7 Author: Lucas Gass Date: Thu Mar 26 22:46:26 2020 +0000 Bug 24764: TinyMCE shouldnt do automatic code cleanup when editing HTML in News Feature TEST PLAN: 1. Make a new news item and use the TinyMCE editor, click on the <> icon to go to the Source code editor 2. Add some HTML like and save it. 3. Go back in and notice that TinyMCE has changed it to:

TEST

4. It should not auto clean up and also it should not autowrap with

tag. 5. Apply patch patch, and repeat step 2. Save again. 6. It should not have automatiicly changed any HTML or added any

wrapper. Signed-off-by: David Cook Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit daf033945746edb60d7b76ab69204d1e859fe3ed Author: Marcel de Rooy Date: Thu Mar 19 14:39:14 2020 +0100 Bug 24903: Add tests for _handle_seqno Trivial tests. Test plan: Run t/Serials/ModSerialStatus.t Signed-off-by: Marcel de Rooy Signed-off-by: Laurence Rault Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit d54376a52374a2b83eadd40dd35d8bbfcba2de63 Author: Marcel de Rooy Date: Thu Mar 19 14:20:38 2020 +0100 Bug 24903: Special characters like parentheses in numbering pattern cause duplication in recievedlist Test plan: Use serial with a numbering pattern with parentheses like "2018 (No. 1)". Mark serial issue as arrived, check receivedlist on summary. Edit issue again, check if not duplicated on receivedlist. Mark issue as missing or not available, check missinglist. Mark missing issue as not missing, check list again. Signed-off-by: Marcel de Rooy Signed-off-by: Laurence Rault Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 0e2119570d9c8deb0b15b8bff92975cfdfa5c3f4 Author: Jonathan Druart Date: Tue Apr 7 13:25:09 2020 +0200 Bug 25038: Fix tabs on the OPAC reading history view OPAC reading history table has three tabs for different checkout types: All, Checkouts, On-site checkouts. However, all of your checkouts are visible every tab regardless of checkout type. Test plan: 1. Enable OnSiteCheckouts system preference 2. Perform two checkouts: one normal checkout, one on-site checkout 3. Go to OPAC /cgi-bin/koha/opac-readingrecord.pl 4. Observe your checkouts all are visible in first tab 5. Select second tab and notice that the table is now filtered 6. Same with third tab Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Signed-off-by: Lari Taskula Signed-off-by: Martin Renvoize commit 3336147258cd71c446026919469ba052a62b6bac Author: Kyle M Hall Date: Fri Apr 10 06:43:51 2020 -0400 Bug 24966: Add unit tests Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit ed69870da5253a3cca853d841d2e3adb844b31fb Author: Marcel de Rooy Date: Fri Apr 10 09:50:13 2020 +0000 Bug 24966: (QA follow-up) Fix return value of hold_patron_bcode It is used in list context, but we need a scalar value. Can be fixed by adding scalar's, or returning empty string as here. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit 3dd79180f33bcdf810251638ae3984cbc832e024 Author: Martin Renvoize Date: Fri Apr 3 11:16:39 2020 +0100 Bug 25040: monkeypatch Schema::Loader for recent MariaDB Recent versions of MariaDB changed the output of 'DESCRIBE' for timestamp columns with defaults from `CURRENT_TIMESTAMP` to `current_timestamp()`. As such the code inside DBIx::Class::Schema::Loader which catches such cases and outputs `\"current_timestamp"` as a sensible cross platform default is missed and this leads of inconsistent class files and bugs with out default lookup code in Koha::Objects. This patch serves as a backport of the code I have submitted upstream such that out developers can continue to use update_dbix_class_files.pl to build their schema classes from the database and regardless of their db server version get a consistently correct output. Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 9ac2ddda0b1506ea09a7c95a98926ea9e9c36bcf Author: Jonathan Druart Date: Mon Apr 6 12:44:13 2020 +0200 Bug 25069: Fix AddressFormat="fr" behavior Something went wrong during a rebase of bug 13618 commit dcd1f5d48c758aee17b6c6f069c6146b42efe117 Bug 13618: Add html filters to all the variables Several changes related to AddressFormat are wrong: - [% IF Koha.Preference( 'AddressFormat' ) %] - [% INCLUDE "member-main-address-style-${ Koha.Preference( 'AddressFormat' ) }.inc" %] - [% ELSE %] - [% INCLUDE 'member-main-address-style-us.inc' %] - [% END %] + [% SWITCH Koha.Preference( 'AddressFormat' ) %] + [% CASE 'de' %] + [% INCLUDE 'member-main-address-style-de.inc' %] + [% CASE # us %] + [% INCLUDE 'member-main-address-style-us.inc' %] + [% END %] Test plan: Create a patron with all the address fields filled Play with the 3 option values of AddressFormat, and confirm that the address is displayed correctly on the patron's view, and in the patron module (top left) Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit 9e2f3200eaf2d09c0124fbf506d114b95b2f1920 Author: Jonathan Druart Date: Tue Apr 7 13:32:51 2020 +0200 Bug 25005: (bug 22868 follow-up) Fix suggestions pending on main page There is a "Suggestions pending approval" link on the main page that is displayed if there are new suggestions and the logged in user has the permission to manage them. On bug bug 22868 the permission changed from acquisition.suggestions_manage to suggestions.suggestions_manage But in the template, one occurrence has not been replaced correctly (certainly because it was already wrong actually). Test plan: Create a suggestion at the OPAC Create a patron with the suggestions permission Use this patron to login at the staff interface => Without this patch the link does not appear on the main page => With this patch applied the link appears Signed-off-by: David Roberts Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit 25966df4d7164e931e35ae5a640ae85eb2644ce3 Author: Jonathan Druart Date: Wed Mar 11 13:01:52 2020 +0100 Bug 24800: Handle inexistent return date on self checking See bug 24800 comment 0 for a description of the problem. We do not want the SIP server to crash if it receives a checkin request with a return date that is not given. The option this patch chose is to parse it only if provided. Signed-off-by: Clemens Elmlinger Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit a57efe865921c4d4945245d3970b3391490de249 Author: Jonathan Druart Date: Wed Mar 11 12:56:41 2020 +0100 Bug 24800: Add tests Signed-off-by: Clemens Elmlinger Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit a22315ef6153d5c64b4dfd763cf6802a3035e941 Author: Nick Clemens Date: Fri Apr 3 12:14:27 2020 +0000 Bug 25050: Adjust marc_records_to_documents to search entire mapping array There was an assumption in the ES code that match-heading mappings will appear in a specified portion of the mappings array. Certain mappings setups will not meet this assumption. We need to move our searching up one level The key seems to be having a mapping for a complete field, say 150, in both the match-heading and another field as well as having mappings for ungrouped fields like 150a 150ab etc. The unit test coverage should be sufficient for testing Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit f7cb46560322ef77858c6f489ae332962942616d Author: Nick Clemens Date: Fri Apr 3 12:12:49 2020 +0000 Bug 25050: Unit tests This patch simplay alters the data we use for the tests, doing so causes them to fail To test: 1 - Apply only this patch 2 - prove -v t/Koha/SearchEngine/Elasticsearch.t 3 - It fails! 4 - Apply next patch 5 - It passes! Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit f406aa2ae35c0d49a91316d00a4fca0cd0109c5c Author: Aleisha Amohia Date: Mon Mar 16 22:09:51 2020 +0000 Bug 24266: (alternate patch) Only use defined borrowernumbers in reconcile_balances.pl cron I believe the error is triggered when borrowernumbers are left empty in the accountlines table. Not sure why this would happen, but it appears to be what causes the problem. Do not apply the first patch if testing this patch. To test: 1) sudo koha-mysql INSTANCENAME 2) Create a test borrower, add any payment etc to create an accountline, then delete this borrower 3) ensure the AccountAutoReconcile syspref is disabled 4) Go to another borrower's accounting tab 5) Create a manual credit or debit. Confirm this shows in the 'Make a payment' tab as an amount that COULD be applied, but isn't automatically applied 6) in your terminal, run the reconcile_balances.pl script 7) Confirm the error does not show in the logs and the balance for the borrower is correctly reconciled. Sponsored-by: Horowhenua District Council Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit 04e4656cd252759efae3606b8e368cfab1dbff5f Author: Kyle M Hall Date: Thu Apr 9 08:24:44 2020 -0400 Bug 25095: Remove warn left in FeePayment.pm It appears that a debugging statement was accidentally left in FeePayment.pm by bug 5605. Signed-off-by: Devinim Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit f5447b33de9ded3868d97fcf033c7acda33cc168 Author: Kyle M Hall Date: Wed Apr 8 10:52:23 2020 -0400 Bug 22778: Add unit test Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 94ed64e5b1e348fcd06d2d41b880c52b6822df57 Author: Kyle M Hall Date: Thu Apr 25 15:50:35 2019 -0400 Bug 22778: Suggestions with no "suggester" can cause errors If one tries to modify a suggestion that has no suggester you will get the following error: Can't call method "lang" on an undefined value at /usr/share/koha/lib/C4/Suggestions.pm line 506 Koha assumes that every suggestion has a borrowernumber in suggestedby Test Plan: 1) Create a suggestion with an unpopulated suggestedby 2) Attempt to modify that suggestion 3) Note the error 4) Apply this patch 5) Restart all teh things 6) Attempt to modify that suggestion 7) No error! Signed-off-by: David Roberts Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 479474e532dca6ded90770fc7a0c00500ea4f787 Author: Jonathan Druart Date: Wed Apr 8 16:11:54 2020 +0200 Bug 24027: Add POD about the new parameter in Koha::Item->store Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 6fa71e82f80c838f4182587f691d1c329a0941bd Author: Tomas Cohen Arazi Date: Wed Apr 8 10:17:32 2020 -0300 Bug 24027: (QA follow-up) Fix POD warning Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 3eec846d7f49c39cb4b4079818eeb42268aca769 Author: Andrew Nugged Date: Mon Apr 6 19:11:35 2020 +0300 Bug 24027: Call ModZebra once after all items added/deleted in a batch Issue description: - call to ModZebra was unconditional inside 'store' method for Koha::Item, so it was after each item added, or deleted. - ModZebra called with param biblionumber, so it is the same parameter across calls for each items with same biblionumber, especially when we adding/removing in a batch. - with ElasticSearch enabled this makes even more significant load and it is also progressively grows when more items already in DB Solution: - to add extra parameter 'skip_modzebra_update' and propagate it down to 'store' method call to prevent call of ModZebra, - but to call ModZebra once after the whole batch loop in the upper layer Test plan / how to replicate: - make sure that you have in the admin settings "SearchEngine" set to "Elasticsearch" and your ES is configured and working ( /cgi-bin/koha/admin/preferences.pl?op=search&searchfield=SearchEngine ) - select one of biblioitems without items ( /cgi-bin/koha/cataloguing/additem.pl?biblionumber=XXX ) - press button "add multiple copies of this item", - enter 200 items, start measuring time and submit the page/form... On my test machine when adding 200 items 3 times in a row (so 600 in total, but to show that time grows with every next batch gradually): WHEN ElasticSearch DISABLED (only Zebra queue): - 9s, 12s, 13s WHEN ElasticSearch ENABLED: - 1.3m, 3.2m, 4.8m WITH PATCH WHEN ElasticSearch ENABLED: - 10s, 13s, 15s Same slowness (because also same call to ModZebra) happens when you try to delete all items ("op=delallitems"). And same fix. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit aa967afa8ec12988a8118ba3b41dd3df3f3fe18f Author: Theodoros Theodoropoulos Date: Wed Apr 8 08:21:12 2020 +0100 Bug 23514: Split Call Numbers for all layout types This patch ensures call numbers are properly split for layout types other than 'BAR'. Test plan: 1. Go to Label Creator and choose/create a Label Layout with "Choose layout type: Biblio" 2. make sure you have at least "itemcallnumber" in Bibliographic data to print/Data fields 3. check "Split call numbers" box and save the layout (ie testlayout) 4. create a label batch, using items that have a call number (ie DC611.B848 H84 1997). LCC is used here, but you may try with Dewey as well. 5. export selected batch using any template and the layout you created in previous step to a PDF 6. Call numbers are splitted (as expected) in the resulting PDF file 7. edit the layout you created in the previous step (ie testlayout) and change the "Choose layout type:" to either Biblio/Barcode (BIBBAR) or Barcode/Biblio (BARBIB) 8. export the same batch using the same template and layout as before 9. Call numbers are NOT splitted at all After patch is applied, call numbers splitting functions are applied even in Biblio/Barcode (BIBBAR) or Barcode/Biblio (BARBIB) layout types. Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Items.pm | 18 +++++-- C4/Labels/Label.pm | 2 +- C4/SIP/ILS/Item.pm | 4 +- C4/SIP/ILS/Transaction/Checkin.pm | 27 +++++----- C4/SIP/ILS/Transaction/FeePayment.pm | 2 - C4/Serials.pm | 29 ++++++++--- C4/Suggestions.pm | 3 +- Koha/AuthUtils.pm | 2 +- Koha/Item.pm | 30 ++++++++--- Koha/Object.pm | 2 +- Koha/RecordProcessor.pm | 23 +++++++++ Koha/Schema/Loader/mysql.pm | 59 ++++++++++++++++++++++ Koha/SearchEngine/Elasticsearch.pm | 2 +- cataloguing/additem.pl | 9 +++- debian/scripts/koha-sip | 10 ++++ .../intranet-tmpl/prog/en/includes/circ-menu.inc | 9 ++-- .../intranet-tmpl/prog/en/modules/intranet-main.tt | 2 +- .../prog/en/modules/members/memberentrygen.tt | 20 ++++---- .../prog/en/modules/tools/koha-news.tt | 4 ++ .../bootstrap/en/modules/opac-readingrecord.tt | 10 ++-- misc/cronjobs/reconcile_balances.pl | 3 +- misc/devel/update_dbix_class_files.pl | 8 ++- t/Koha/SearchEngine/Elasticsearch.t | 41 ++++++++++++--- t/RecordProcessor.t | 54 ++++++++++++++++++++ t/Serials/ModSerialStatus.t | 38 ++++++++++++++ t/db_dependent/Koha/Object.t | 10 +++- t/db_dependent/Koha/Objects.t | 10 +++- t/db_dependent/SIP/Message.t | 32 +++++++++++- t/db_dependent/SIP/Transaction.t | 56 +++++++++++++++++++- t/db_dependent/Suggestions.t | 35 ++++++++++++- 30 files changed, 477 insertions(+), 77 deletions(-) create mode 100644 Koha/Schema/Loader/mysql.pm create mode 100755 t/Serials/ModSerialStatus.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Apr 14 06:30:48 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 14 Apr 2020 04:30:48 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.15-14-gd0facd2b73 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via d0facd2b73c095bbd4a386ca8b1f271cb1911c8f (commit) via 9e593de322b6602eeb549f651ad4273e9f0d4044 (commit) via 4a2faccfbb1b7ab60a6c8318df94450ac0528ace (commit) from 2bad119d043d46ea5998e40dc8a15f2deba682ad (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d0facd2b73c095bbd4a386ca8b1f271cb1911c8f Author: Hayley Mapley Date: Tue Apr 14 16:00:40 2020 +1200 Bug 24673 (18.11.x U18 follow-up): Fixing t/db_dependent/Koha/XSLT/Security.t The test t/db_dependent/Koha/XSLT/Security.t failed on Jenkins for U18 when this bug's patches were backported, due to it returning a different IO error message for XSLT. This patch adds a condition to the regex which matches both messages: 'Failed to load external entity' and 'Failed to load HTTP resource' Signed-off-by: Hayley Mapley commit 9e593de322b6602eeb549f651ad4273e9f0d4044 Author: Katrin Fischer Date: Sun Feb 23 21:25:00 2020 +0000 Bug 24605: (QA follow-up) Fix unencoded series link in staff interface Same change as the first patch, but for the staff detail page. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 6298eafa642529283ed82f72638bb434762a2c15) Signed-off-by: Lucas Gass (cherry picked from commit 0870bb6da6191759512e8b7a29ebe7a2f169ee62) commit 4a2faccfbb1b7ab60a6c8318df94450ac0528ace Author: Nick Clemens Date: Thu Feb 6 17:45:07 2020 +0000 Bug 24605: Fix unencoded series link To test: 1 - Add an 830 to a record with a volume subfield separated by a semicolon 830$aThe series ;$vvol 8. 2 - View the record in the opac 3 - Click the series link, no results 4 - View the link url - the semicolon is not encoded 5 - Apply patch 6 - link works 7 - URL is corrrectly encoded Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit e3cffae41f82fb22100bcf269696107cb102660e) Signed-off-by: Lucas Gass (cherry picked from commit e94543c454e1de6688f910515885757f1b467caf) ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 2 +- t/db_dependent/Koha/XSLT/Security.t | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 10 18:13:08 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Apr 2020 16:13:08 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-43-ga31d2ca846 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via a31d2ca846a7d7fc62dc7e05a0136e2ee3b4db0a (commit) from bacd18d29b1b2e5ceeb8ec7ca4a0dcbccd418d87 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a31d2ca846a7d7fc62dc7e05a0136e2ee3b4db0a Author: Fridolin Somers Date: Fri Jul 26 15:43:02 2019 +0200 Bug 23383: fix IdRef syspref test in XSLT IdRef link is displayed via XSLT. There is a test of syspref with just if value is defined. But in installer/data/mysql/sysprefs.sql you see this pref will be 0 by default, which is true in XPATH. We should test that pref is 1. Test plan : 1) Create a fresh UNIMARC database 2) You have pref IdRef disabled 3) Simulate a SUDOC record: Fill a 7..$3 field with a ppn (032581270 for example). Fill the 009 field with an integer 4) Go to the opac detail page of the record => You don't see IdRef link 5) Enable IdRef syspref 6) Go to the opac detail page of the record => You see IdRef link 7) Disable IdRef syspref 8) Go to the opac detail page of the record => You don't see IdRef link Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit df4811ae1f2ff5a21ea5a3a7db97b19ecfdc4f6d) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslimUtils.xsl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 13 19:14:05 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 13 Apr 2020 17:14:05 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-60-g5d49c80644 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 5d49c806445e00dd55259d805c7d88a73378e61f (commit) from 22e48c05e2311539078ca0801dc6b4278cf2f58d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5d49c806445e00dd55259d805c7d88a73378e61f Author: Jonathan Druart Date: Mon Mar 30 16:11:51 2020 +0200 Bug 25020: Preserve time part when batch extending due dates When selecting a new hard due date, we should keep the time part of the original checkouts. Test plan: 1 - Checkout an item specifying a date due 2 - Checkout an item without specifying a date due 3 - Use Tools->Batch extend due date 4 - Select a hard due date 5 - On the confirmation screen you should see that the time part has been kept 6 - Confirm 7 - Make sure the correct values hava been inserted in DB 8 - Try now using the other option, give a number of days 9 - Repeat 4-7 Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 5550da8a50dbb60fcad6ea2a43658938d1200803) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: .../en/modules/tools/batch_extend_due_dates.tt | 6 +-- tools/batch_extend_due_dates.pl | 47 ++++++++++++++++++---- 2 files changed, 40 insertions(+), 13 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 13 22:52:34 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 13 Apr 2020 20:52:34 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-82-g81f26f5276 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 81f26f5276df9439f093c560127451dfe8c656a1 (commit) via a5d5cf6cb218db98195de3dc372b377b3b6671b0 (commit) from ee5ecb043e985ff59fe045b5f596d8f90d907ef3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 81f26f5276df9439f093c560127451dfe8c656a1 Author: Lucas Gass Date: Mon Apr 13 20:24:02 2020 +0000 Bug 24874: Compile CSS Signed-off-by: Lucas Gass commit a5d5cf6cb218db98195de3dc372b377b3b6671b0 Author: Mason James Date: Thu Mar 19 20:41:00 2020 +1300 Bug 24874: Printing is broken on opac-results.pl page (19.11.x) to test in 19.11.x... - search for something in opac - print page using file -> print - observe printing is broken (pic1) - apply patch - search for something in opac - print page using file -> print - observe printing is fixed (pic2) it seems this issue was introduced by bug 5287 Signed-off-by: Lucas Gass Signed-off-by: Owen Leonard Signed-off-by: Joy Nelson (cherry picked from commit 86799ff8ce364d4c8642b08ce447f05d2b8bb940) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/css/opac.css | 2 +- koha-tmpl/opac-tmpl/bootstrap/css/print.css | 2 +- koha-tmpl/opac-tmpl/bootstrap/css/src/print.scss | 7 ++++++- 3 files changed, 8 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Apr 14 07:08:27 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 14 Apr 2020 05:08:27 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.15-16-g25a2a70963 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via 25a2a7096327d4338b75c2c3cce6beee0b1f7a1a (commit) from 986cc8e8910966e61b3dd09da170d9ebe63c478c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 25a2a7096327d4338b75c2c3cce6beee0b1f7a1a Author: Andrew Fuerste-Henry Date: Thu Feb 27 14:09:02 2020 -0600 Bug 24747: Corrects on-screen instructions in branch transfer limits To test: 1- go to cgi-bin/koha/admin/branch_transfer_limits.pl 2- see wording "Check the boxes for the libraries you accept to checkin items from" 3- apply patch 4- see wording "Check the boxes for the libraries you allow your items to be transferred to" To verify new wording accuractely describes behavior: 1- Set UseBranchTransferLimits set to Enforce using itemtype 2- Confirm circ rules allow holds 3- Confirm hold policy by item type allows holds 4- Confirm all branches are valid pickup locations in branch setup 5- In Branch Transfer Limits, set dropdown to Branch A, select itemtype Book, disable all transfers so Branch A does not accept books from any other branch 6- Find a patron from Branch A 7- Find a book from Branch B 8- On the intranet, successfully place hold on item for patron for pickup at branch A 9- Cancel hold 10- Log into opac as patron 11- Successfully place hold on item for pickup at Branch A 12- Cancel hold 13- In Branch Transfer Limits, set dropdown to Branch A, select itemtype Book, ENABLE all transfers so Branch A DOES accept books from any other branch 14- In Branch Transfer Limits, set dropdown to Branch B, select itemtype Book, disable all transfers so Branch B does not accept books from any other branch 15- On the intranet, try to place a hold on item for patron, confirm Branch B is your only pickup option 16- On the OPAC, log in as patron, try to place a hold on item, confirm Branch B is your only pickup option Signed-off-by: Kelly McElligott Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit 84026f258909e1203f34793a1089388cd933d1c9) Signed-off-by: Lucas Gass (cherry picked from commit 67a4e40f5cd1866d5ed27f211800731bd4c14764) ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/admin/branch_transfer_limits.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 10 18:38:32 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Apr 2020 16:38:32 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-48-g1f80f34cee Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 1f80f34cee73197c13ffedb408fbe3c6c54d3758 (commit) from 5d52c0076f91a8fa0bf087736a957deed53bb8a6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1f80f34cee73197c13ffedb408fbe3c6c54d3758 Author: Lucas Gass Date: Thu Mar 12 22:38:47 2020 +0000 Bug 24858: Correct labels on wording in ExcludeHolidaysFromMaxPickUpDelay TO TEST: - Apply patch - mark your library closed today and tomorrow - set ReservesMaxPickUpDelay to 1 day - set ExcludeHolidaysFromMaxPickUpDelay to "Ignore the calendar" - place hold, capture hold - hold expiration date is set to tomorrow (doesn't skip closed days) - Set ExcludeHolidaysFromMaxPickUpDelay to "Use the calendar" - Place hold, capture hold - hold expiration date is set to the day after tomorrow (skips closed days) Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 81f32a92ac7e883a98b40511c1d4e3d44b68b480) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/admin/preferences/circulation.pref | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 13 19:42:22 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 13 Apr 2020 17:42:22 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-65-g3e2d76bbfa Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 3e2d76bbfaec296179dc9563bdc6024ef2d210a6 (commit) from 5418efe4824d4ec11e44fc40bda35294190ab0c7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3e2d76bbfaec296179dc9563bdc6024ef2d210a6 Author: Andrew Isherwood Date: Mon Jan 27 12:00:47 2020 +0000 Bug 24518: Fix IE11 partner filtering This patch adopts the approach detailed in comment #1. It also fixes a couple of additional minor bugs relating to the ILL partner list: - Exclude partners with no email address, we cannot use them - Quote the "value" attribute to avoid warnings displayed by IE, they should be quoted anyway! Test plan: USE IE11 - Apply the patch - Define 3 ILL partner patrons (patrons in the category that has a code that matches the value in the ILL config). One patron should have no email address, the other two should have an email address - Navigate to "Place request with partners" for an ILL request - TEST: Observe that the patron with no email address is not displayed - Try filtering the list - TEST: Observe that the list filters correctly Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 58590b9ac722685b5a050da367be2e76145e48c7) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt | 8 +++++--- koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js | 12 +++++++----- 2 files changed, 12 insertions(+), 8 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 13 22:22:01 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 13 Apr 2020 20:22:01 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-76-gf117fa6f97 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via f117fa6f97a10008071e029d4fdc7a516f22200f (commit) from 798f176f2908ad7b53b6da6341c512a4398d6b86 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f117fa6f97a10008071e029d4fdc7a516f22200f Author: Marcel de Rooy Date: Wed Mar 18 13:54:52 2020 +0000 Bug 24892: Resolve uninitialized warns from opac-memberentry Especially line 500 (current master). Use of uninitialized value $new_data{"sort2"} in string eq at /usr/share/koha/opac/opac-memberentry.pl line 500. Use of uninitialized value in string eq at /usr/share/koha/opac/opac-memberentry.pl line 500. Simple fix, not completely trivial due to adding xor ;) Test plan: Do not apply, update from opac memberentry. Check warns in log. Apply patch, update again. Less warns? Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 44d91396128a38a29b21f643f2e6439383a03e5c) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: opac/opac-memberentry.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 13 23:02:36 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 13 Apr 2020 21:02:36 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-84-g1a1fa23f3c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 1a1fa23f3c1413b27eda211417be0ba3e7c6d2a7 (commit) from 3a21d8d4f3576490e17a422789fd2550e90e2c64 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1a1fa23f3c1413b27eda211417be0ba3e7c6d2a7 Author: Katrin Fischer Date: Fri Mar 13 20:30:06 2020 +0000 Bug 24875: Remove extra punctuation from tools start page The patron clubs note was ending with .., but patch also removed some single . to be consistent with the majority of entries on the tools page. To test: - Check the tools start page for ending . in the notes - Apply patch - Verify the punctuation is now consistent Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 88590cb6784d0b774f48aac9db491d0d32cf6d8a) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Apr 14 04:36:36 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 14 Apr 2020 02:36:36 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.15-8-gfc703cae7c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via fc703cae7cabd692891aec706161c2c14734c6d8 (commit) from 28d7dca810daf23b48f482040684ad34ef88f114 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit fc703cae7cabd692891aec706161c2c14734c6d8 Author: Nick Clemens Date: Fri Feb 21 21:11:37 2020 +0000 Bug 24711: Don't add logout input to login form To test: 1 - Set OpacPublic syspref to 'Disable' 2 - Log in to OPAC 3 - Log out 4 - Try to log in again 5 - No error, but you get the login form again 6 - Apply patch 7 - Repeat 8 - This time you can log in again Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit a137b170c0f4bac8fdd69dd4e9fe6e46c60edd59) Signed-off-by: Lucas Gass (cherry picked from commit c188cf91a0c66196620f1efeeea8e39ae30da182) Signed-off-by: Hayley Mapley ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 10 19:12:27 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Apr 2020 17:12:27 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-53-g83cb6a7077 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 83cb6a7077ed891568b34e39a4bdbb80631c4417 (commit) via bcd43d5cf729b0fda91e6e1af8e55aa8021340e5 (commit) from b3843211de3181f56918a4e9c7dfafeaef8cb5e3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 83cb6a7077ed891568b34e39a4bdbb80631c4417 Author: Nick Clemens Date: Mon Mar 16 14:55:31 2020 +0000 Bug 24789: [follow-up] Fix saving of macros Saving was accidentally commented out in patches, this restores that To test: 1 - Create a new macro 2 - Add some content 3 - Reload the macro, no content 4 - Apply patch 5 - Repeat 6 - Macro saves/loads correctly Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 66742f6e705d5841c6559f346883bdc2f6ee1053) Signed-off-by: Lucas Gass commit bcd43d5cf729b0fda91e6e1af8e55aa8021340e5 Author: Nick Clemens Date: Tue Mar 3 13:26:02 2020 +0000 Bug 24789: Remove ITS macro format To test: 1 - Apply patches 2 - Confirm you can save, load, and run macros 3 - Confirm you have no choice of format Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit b58bb48b0b7401d010bb89bdaf7edbee1c6163ce) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/lib/koha/cateditor/macros.js | 6 +- .../intranet-tmpl/lib/koha/cateditor/macros/its.js | 208 --------------------- .../prog/en/includes/cateditor-ui.inc | 15 +- .../prog/en/modules/cataloguing/editor.tt | 1 - 4 files changed, 3 insertions(+), 227 deletions(-) delete mode 100644 koha-tmpl/intranet-tmpl/lib/koha/cateditor/macros/its.js hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Apr 14 05:36:49 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 14 Apr 2020 03:36:49 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.15-11-g2bad119d04 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via 2bad119d043d46ea5998e40dc8a15f2deba682ad (commit) via edf7b852923f8ed7194c538e64a955c4ba373946 (commit) from 7a92d126df700be6ffcfbc3a371a04808714f2d6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2bad119d043d46ea5998e40dc8a15f2deba682ad Author: Marcel de Rooy Date: Fri Mar 20 10:12:24 2020 +0000 Bug 24809: (QA follow-up) Add prefix to prevent disambiguity This seems not to be needed. Just at the safe side. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 96e6362ab721621dd7e24d6f8a56d168e2a9b497) Signed-off-by: Lucas Gass (cherry picked from commit 27be06c67281bf24df755c67e305da420c11eac8) Signed-off-by: Hayley Mapley commit edf7b852923f8ed7194c538e64a955c4ba373946 Author: Nick Clemens Date: Thu Mar 5 10:59:22 2020 +0000 Bug 24809: Get only timestamp of deleted items attached to existing bibs when check if bib deleted To test: 1 - Edit/create a file in the koha home dir '/var/lib/koha/{instance}/OAI.yaml' with content like below: format: marcxml: metadataPrefix: marcxml metadataNamespace: http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim schema: http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd include_items: 1 2 - Set the systempreferences below to indicated values: OAI-PMH => Enable OAI-PMH:ConfFile => /var/lib/koha/{instace}/OAI.yaml 3 - View a record with items and confirm the items show: http://localhost:8080/cgi-bin/koha/oai.pl?verb=GetRecord&metadataPrefix=marcxml&identifier=KOHA-OAI-TEST:4 4 - Delete the items, then delete the record 5 - Reload the URL from step 3 6 - Internal Server Error: Empty String at /kohadevbox/koha/Koha/OAI/Server/Record.pm line 58. at /usr/share/perl/5.24/Carp.pm line 167 7 - Apply patch 8 - restart_all 9 - Repeat 10 - Reload URL from step 3 11 - Success Signed-off-by: Michal Denar Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 68488f40558d66b7e4e444c1ed57a260b33ee034) Signed-off-by: Lucas Gass (cherry picked from commit d474a4edb165d7116b5bfc459d33e04cc88ca456) Signed-off-by: Hayley Mapley ----------------------------------------------------------------------- Summary of changes: Koha/OAI/Server/GetRecord.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 13 22:34:32 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 13 Apr 2020 20:34:32 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-78-g2ea4f02f84 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 2ea4f02f8462d7806f9a05d270f6d4f8e3ed9aaa (commit) from d29f435e2676e104ae84bac840924c48f54b5568 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2ea4f02f8462d7806f9a05d270f6d4f8e3ed9aaa Author: Liz Rea Date: Fri Jan 3 21:18:27 2020 +0000 Bug 24324: Resolve error with delete_records_via_leader.pl To test: Have a record with the 000 position 5 set to "deleted" (record status) Use koha-shell to run the job with the -i flag: perl misc/cronjobs/delete_records_via_leader.pl -c -i -v * items and the record should be deleted Mark another record with the 000 position 5 set to deleted (record status) Use koha-shell to run the job without the -i flag: perl misc/cronjobs/delete_records_via_leader.pl -c -v * if the record had items, it will not be deleted * if the record did not have items, it will be deleted. Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit b713241845e8f730b46c756fa65c4ddd17ed746b) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: misc/cronjobs/delete_records_via_leader.pl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 13 23:18:49 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 13 Apr 2020 21:18:49 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-89-g3f0eee4276 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 3f0eee42766b2ccd4b2ffea57af0d9fb2c057758 (commit) from 45078456b49382395f89bca54457cdac2d5f775d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3f0eee42766b2ccd4b2ffea57af0d9fb2c057758 Author: Nazlı Çetin Date: Fri Mar 27 12:25:46 2020 +0000 Bug 25000: SQL report not updated Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit cb7729c55df1ac4197e9fcf92d42789ba3006bca) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/Reports/Guided.pm | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Apr 14 06:55:35 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 14 Apr 2020 04:55:35 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.15-15-g986cc8e891 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via 986cc8e8910966e61b3dd09da170d9ebe63c478c (commit) from d0facd2b73c095bbd4a386ca8b1f271cb1911c8f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 986cc8e8910966e61b3dd09da170d9ebe63c478c Author: Nick Clemens Date: Wed Feb 26 03:16:26 2020 +0000 Bug 24733: created_by param should be an arrayref We allow for the user to add multiple users to this field, and the search function expects and array. We have been treating it as a scalar TO test: 1 - Have an open basket in acquisitions 2 - Add to basket - from an existing order (copy) 3 - Enter a name in the 'Basket created by' field and select a user 4 - Hit search 5 - ISE (Can't use string ("1") as an ARRAY ref while "strict refs" in use at /usr/share/koha/lib/C4/Acquisition.pm line 2482.) 6 - Apply patch 7 - Repeat 1-4 8 - Success! 9 - Test with mutiple 'created by' entries as well Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize (cherry picked from commit 789866e585be0a5c439559383325cbe4db525412) Signed-off-by: Lucas Gass (cherry picked from commit 63374a8db6f759c8bb3e9b6ca1029ad07d2bb938) Signed-off-by: Hayley Mapley ----------------------------------------------------------------------- Summary of changes: acqui/duplicate_orders.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 10 19:06:20 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Apr 2020 17:06:20 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-51-gb3843211de Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via b3843211de3181f56918a4e9c7dfafeaef8cb5e3 (commit) via 33c6cdd91f1580656d43a02ac0f5d41303857778 (commit) via e4eb3a70415665e868fef2688ee9a3b56d8283e9 (commit) from 1f80f34cee73197c13ffedb408fbe3c6c54d3758 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b3843211de3181f56918a4e9c7dfafeaef8cb5e3 Author: Katrin Fischer Date: Fri Mar 13 08:47:53 2020 +0000 Bug 22943: Remove unused line from Auth.t Removes an unnecessary variable declaration from Auth.t Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 04359d9bbb2dabe8eefac60cd5ed68c81d91379c) Signed-off-by: Lucas Gass commit 33c6cdd91f1580656d43a02ac0f5d41303857778 Author: Martin Renvoize Date: Mon Mar 9 09:17:50 2020 +0000 Bug 22943: (QA follow-up) Add new cases A few additional cases were introduced since the original bug was authored. This patch simply catches those cases and makes the same change. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 59955a13836fba246746ca8aaa2384c800425665) Signed-off-by: Lucas Gass commit e4eb3a70415665e868fef2688ee9a3b56d8283e9 Author: Hayley Mapley Date: Mon May 27 13:57:05 2019 +1200 Bug 22943: Renames the in_ipset function to in_iprange in C4::Auth Bug 14407 introduced a new system preference to allow limiting the online self checkout system to an IP or IP Range. The function that handles this is called in_ipset, which is the name of a linux tool. To stop confusion, this patch renames the function to 'in_iprange', and the variable 'ipset' within it to 'iprange'. To test, follow the test plans outlined in Bug 14407 and confirm that everything works as expected. Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 46b219864e3ea001d05dc69e960fd77c00c5eed6) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/Auth.pm | 16 ++++++++-------- opac/sco/help.pl | 4 ++-- opac/sco/printslip.pl | 4 ++-- opac/sco/sco-main.pl | 4 ++-- opac/sco/sco-patron-image.pl | 4 ++-- t/Auth.t | 29 ++++++++++++++--------------- 6 files changed, 30 insertions(+), 31 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Apr 14 12:36:34 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 14 Apr 2020 10:36:34 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1698-gca46310b26 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via ca46310b26e2f2f1f048b76aae8bdf63058dd029 (commit) from d13fbc0bdad3b9b75f112ca0de5a26d8f4bdc193 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ca46310b26e2f2f1f048b76aae8bdf63058dd029 Author: Martin Renvoize Date: Tue Apr 14 11:08:32 2020 +0100 Bug 22534: (RM follow-up) Remove errant hidden file An nfs share file got commited by mistake :( Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: members/.nfs0000000000721f7f00000014 | Bin 16384 -> 0 bytes 1 file changed, 0 insertions(+), 0 deletions(-) delete mode 100644 members/.nfs0000000000721f7f00000014 hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 13 19:21:42 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 13 Apr 2020 17:21:42 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-63-g0935c5d350 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 0935c5d350b008ea0a4fe4da541f5cf3fffc9323 (commit) via c2af44728ced273ccbf96c21b59842bbc7641348 (commit) via 3dd55ca547f5ca2271c2d3346ca2ee8d82ff85d1 (commit) from 5d49c806445e00dd55259d805c7d88a73378e61f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0935c5d350b008ea0a4fe4da541f5cf3fffc9323 Author: Owen Leonard Date: Tue Dec 17 15:19:56 2019 +0000 Bug 7882: (follow-up) Only show sortable icon for sortable tags Only tags which can be repeated can be sorted, so the "bars" icon should not display by these tags. Signed-off-by: Maryse Simard Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 481d51c51c71ba41fc518cc52ba6aec777e3332c) Signed-off-by: Lucas Gass commit c2af44728ced273ccbf96c21b59842bbc7641348 Author: Owen Leonard Date: Mon Dec 16 19:06:57 2019 +0000 Bug 7882: (follow-up) Update sorting interaction This follow-up modifies the CSS for the sortable fields so that a different icon is used. Elsewhere in Koha (stock rotation stage sorting) we use the "bars" icon to indicate a sortable element. I think it would be good to continue to use this. The cursor is now styled as a "Move" cursor. The configuration of the sortable function in the script has been updated in two ways: 1. The movement of the element is constrained along the y-axis, and 2. The movement of the element is contstrained to the container within which it can be moved (for the tag, the tab, and for the subfield, the tag). To test, apply the patch and edit a MARC record in the basic cataloging editor. Confirm that the new icon is used, and that the "Move" cursor shows when you hover over the icon. Confirm that a tag can be dragged up and down within the constraints of the visible section. A subfield should be only movable within its parent tag. Signed-off-by: Maryse Simard Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit f30e320adc217473f2a01cc211ecabe81e866395) Signed-off-by: Lucas Gass commit 3dd55ca547f5ca2271c2d3346ca2ee8d82ff85d1 Author: Maryse Simard Date: Wed Oct 23 15:34:39 2019 -0400 Bug 7882: Add ability to move and reorder fields in MARC editor Use jQueryUI sortable to make fields and subfields moveable in the MARC editor for both records and authorities. This patch convert items from div's to ul's and consequently alter css and js to match. It also replace the up arrow with a more adapted icon (from font awesome). Primary authorship by Elliott Davis. To Test: 1. Add or edit a record in cataloguing module. 2. You should be able to move the fields and subfields around. - You can click on any part of the element to drag it, the move icon to the left of the item is a good place to do it. => You can only change the order of fields of the same tag. 3. Make sure all of the javascript driven fonctionnality still work : - Duplicate fields/subfields - Remove fields/subfields - Using the tag editor for control fields or to link authorities - etc 4. Reorder some fields/subfields and save the record. 5. Edit the record again. 6. The order in the editor should match the changes which were saved. - Empty subfields should appear after the ones with content. 7. Repeat steps 1-6 with the authority editor. Signed-off-by: Séverine QUEUNE Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 23724c9c7410c0f8b432cfd8019b30753a672d5b) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: cataloguing/addbiblio.pl | 2 +- koha-tmpl/intranet-tmpl/prog/css/addbiblio.css | 63 +++++++++++++++++++-- .../prog/en/modules/authorities/authorities.tt | 28 +++++---- .../authorities/blinddetail-biblio-search.tt | 6 +- .../prog/en/modules/cataloguing/addbiblio.tt | 42 ++++++++++---- koha-tmpl/intranet-tmpl/prog/img/up.png | Bin 362 -> 0 bytes koha-tmpl/intranet-tmpl/prog/js/cataloging.js | 52 +++++++---------- 7 files changed, 134 insertions(+), 59 deletions(-) delete mode 100644 koha-tmpl/intranet-tmpl/prog/img/up.png hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 13 18:54:10 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 13 Apr 2020 16:54:10 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-57-ged09fd488d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via ed09fd488d02e249af6c41a05898d2eb7b892e41 (commit) from 5d0a186b071a06d7c56de28febb358dbeafd44f2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ed09fd488d02e249af6c41a05898d2eb7b892e41 Author: Lucas Gass Date: Fri Jan 17 22:12:11 2020 +0000 Bug 24456: change default sort orders/make wording clearer TEST PLAN: 1. Apply patch 2. Have some checkout from today and some from multiple previous days. 3. Set todaysIssuesDefaultSortOrder & previousIssuesDefaultSortOrder to 'earliest to latest' and confirm it sorts correctly. 4. Reverse the 2 system preferences and see that it is now sorting the opposite way. 5. Also look at the wording of each system prefence and make sure it makes sense Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit ba69672acec227e4d13d61d7a24fa41533cf6385) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref | 2 +- svc/checkouts | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 13 23:08:55 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 13 Apr 2020 21:08:55 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-87-g98178e0bb8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 98178e0bb8162c648b03b32f54d609b3990b4e83 (commit) via 6dde1fa54a7fcf4623adaa2b32f58d5ba5952137 (commit) via b3fa716084bfc8e53f3c470eed368333c7e75b30 (commit) from 1a1fa23f3c1413b27eda211417be0ba3e7c6d2a7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 98178e0bb8162c648b03b32f54d609b3990b4e83 Author: Jonathan Druart Date: Fri Mar 27 17:09:27 2020 +0100 Bug 24614: Fix Reports/Guided.t DBD::mysql::st execute failed: Column 'public' cannot be null [for Statement "UPDATE `saved_sql` SET `last_modified` = ?, `notes` = ?, `public` = ?, `report_group` = ?, `report_name` = ?, `report_subgroup` = ?, `savedsql` = ? WHERE ( `id` = ? )" with ParamValues: 0='2020-03-27T16:03:04', 1=undef, 2=undef, 3=undef, 4='Just another report', 5=undef, 6=undef, 7=25] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. # Looks like you planned 17 tests but ran 6. update_sql expect all the paramters to be set, otherwise it will be nulled. The best way to fix it is at test level. There is only 1 occurrence in controller/module, and it sends all the parameters. That is the correct way to do and will make things easier when we will removed them to use Koha::Reports directly Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 60c88bfa2f6c23c58ebd953eca2d0c29f6f2dee3) Signed-off-by: Lucas Gass commit 6dde1fa54a7fcf4623adaa2b32f58d5ba5952137 Author: Jonathan Druart Date: Tue Feb 11 17:21:38 2020 +0100 Bug 24614: Use Koha::Reports from save_report and update_sql In order to get the default value defined at DBMS level, we use Koha::Reports (to inherit from Koha::Object->store) from the 2 add/edit methods of C4::Reports::Guided. A second step would be to remove completely those CRUD subroutines and use directly Koha::Reports instead. Test plan: 1. Add and edit some reports 2. Disable memcached, create a report, edit it => Should not crash 3. Make sure the tests make sense and that they pass after the second patch. The error was: DBD::mysql::db do failed: Column 'cache_expiry' cannot be null [for Statement "UPDATE saved_sql SET savedsql = ?, last_modified = now(), report_name = ?, report_group = ?, report_subgroup = ?, notes = ?, cache_expiry = ?, public = ? WHERE id = ? "] at /kohadevbox/koha/C4/Reports/Guided.pm line 633. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 0a6c345703d46f4da4714dd5fa9ae673fab94ec6) Signed-off-by: Lucas Gass commit b3fa716084bfc8e53f3c470eed368333c7e75b30 Author: Jonathan Druart Date: Tue Feb 11 17:21:15 2020 +0100 Bug 24614: Add tests Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit d3d27f48d8672a5d5f679647a7265ba1fd9bb11e) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/Reports/Guided.pm | 43 +++++++++++++++++++++++++++++------------ t/db_dependent/Reports/Guided.t | 6 +++++- 2 files changed, 36 insertions(+), 13 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Apr 14 04:17:37 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 14 Apr 2020 02:17:37 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.15-7-g28d7dca810 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via 28d7dca810daf23b48f482040684ad34ef88f114 (commit) via 87eac5cc3ab2ee7f95ca52781ab3a97754ece0bc (commit) from 55f94a201e40a96e49be602204a14507e4fb1913 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 28d7dca810daf23b48f482040684ad34ef88f114 Author: Fridolin Somers Date: Tue Nov 5 09:55:25 2019 +0100 Bug 23968: Add div this id around OPACMySummaryNote content Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit cffa7623e13d8a21e66f5c9dc8caaa5668738411) Signed-off-by: Lucas Gass (cherry picked from commit faed28348d4bdc0bcd9639b3c38208960ac5fb7f) Signed-off-by: Hayley Mapley commit 87eac5cc3ab2ee7f95ca52781ab3a97754ece0bc Author: Fridolin Somers Date: Tue Nov 5 09:52:59 2019 +0100 Bug 23968: fix OPACMySummaryNote feature The system preference OPACMySummaryNote is used to display on the logged-in patron summary page at OPAC. It does not display anymore. Looks like it comes from code : [% IF OPACMySummaryNote %][% Koha.Preference('OPACMySummaryNote') | $raw %][% END %] OPACMySummaryNote used to be a provided variable. Test plan: 1) Enable system preference OPACMySummaryNote 2) Enter some HTML into it 3) Go to OPAC and loggin 4) Check you see the HTML in opac-user.pl 5) Disable the preference 6) Check you dont see the HTML anymore Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit d5c501bf63f9d42bc9d872eef391c0864753c8ba) Signed-off-by: Lucas Gass (cherry picked from commit 0f75bffeeb7d6518a707dc800e7d12091946706b) Signed-off-by: Hayley Mapley ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 13 20:27:09 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 13 Apr 2020 18:27:09 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-67-g8ef75d10e4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 8ef75d10e46f45f6e4fae634e5262d2415b1a7b1 (commit) from 42bc9671ca47272258cecde2abccdef521a58b56 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8ef75d10e46f45f6e4fae634e5262d2415b1a7b1 Author: Jonathan Druart Date: Thu Mar 12 10:01:10 2020 +0100 Bug 24856: Remove itemtypes.imageurl in fr-FR sample data in installer/data/mysql/fr-FR/3-LecturePub/sample_itemtypes.sql and installer/data/mysql/fr-FR/4-Conservation/sample_itemtypes.sql the values of imageurl point to non-existent images. Test plan: Insert the 2 sql file and confirm that imageurl is not empty Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 25a00e828dfda520cf39c7aca219a028196958de) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: .../mysql/fr-FR/3-LecturePub/sample_itemtypes.sql | 24 +++++++++++----------- .../fr-FR/4-Conservation/sample_itemtypes.sql | 18 ++++++++-------- 2 files changed, 21 insertions(+), 21 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 13 21:49:20 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 13 Apr 2020 19:49:20 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-71-g38e82d3a90 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 38e82d3a90601145ae60855e632667f7df171a35 (commit) from 707f7e6bbcfeece5cf8801cb4f1fbc9c4dc087cf (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 38e82d3a90601145ae60855e632667f7df171a35 Author: Jonathan Druart Date: Tue Dec 17 11:31:40 2019 +0100 Bug 24250: Do not duplicate debarred comment in patron screen message AF field Caused by commit bddfed75913a2302c19c00b00a6fe86538af6f9f Bug 19933: Remove patronflags - tricky ones Test plan: 1 - Setup SIP in your testing environment https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup 2 - Set a patron to have a restriction 3 - Send a patron status request or patron information command via the SIP cli emulator (see link above) 4 - Note the comment on the restriction is sent only once Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 268a62a6d2f8c6b3fe1a07033b533b31fc88db33) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/SIP/ILS/Patron.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 13 18:47:22 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 13 Apr 2020 16:47:22 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-55-g499d53b00a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 499d53b00a252aebc19e496325438061a3e0e9dd (commit) via 2dde0c9f33706424d9d53c0ec13a02348a7c7622 (commit) from 83cb6a7077ed891568b34e39a4bdbb80631c4417 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 499d53b00a252aebc19e496325438061a3e0e9dd Author: Jonathan Druart Date: Mon Mar 16 12:39:39 2020 +0100 Bug 24851: Translate the .txt in French Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 2244ed80725a91d101d1796ab118d4fccc5ff61e) Signed-off-by: Lucas Gass commit 2dde0c9f33706424d9d53c0ec13a02348a7c7622 Author: Jonathan Druart Date: Wed Mar 4 19:06:03 2020 +0100 Bug 24851: Insert libraries sample data for "UNIMARC" I am trying to make koha-testing-docker UNIMARC compabible. In order to have koha-misc4dev insert all the data correctly (users, etc.) we need at least 1 library. I am suggesting to reuse the usual library list for UNIMARC. misc4dev will use fr-FR sample data for "UNIMARC" This is related to https://gitlab.com/koha-community/koha-misc4dev/issues/29 Test plan: outside your box, in koha-testing-docker (up-to-date), edit .env and set KOHA_MARC_FLAVOUR=unimarc DEBUG_GIT_REPO_MISC4DEV_URL=https://gitlab.com/joubu/koha-misc4dev.git DEBUG_GIT_REPO_MISC4DEV_BRANCH=unimarc Then start the koha container When the misc4dev will start its job, the scripts will have the expected data to continue. Without this patch you will get koha_1 | Not enough data in the database, library and/or patron category does not exist at /kohadevbox/misc4dev/create_superlibrarian.pl line 31. And plenty of errors will follow. Also, the sample data used in misc4dev will use CPL (/kohadevbox/misc4dev/data/sql/unimarc/1812/after_22155/items.sql) Signed-off-by: Jon Knight Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit e513e32d0e3c004236048b6673f55eb45bbd82ae) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: .../data/mysql/{de-DE/optional => fr-FR/2-Optionel}/sample_libraries.sql | 0 installer/data/mysql/fr-FR/2-Optionel/sample_libraries.txt | 1 + 2 files changed, 1 insertion(+) copy installer/data/mysql/{de-DE/optional => fr-FR/2-Optionel}/sample_libraries.sql (100%) create mode 100644 installer/data/mysql/fr-FR/2-Optionel/sample_libraries.txt hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 13 22:24:25 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 13 Apr 2020 20:24:25 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-77-gd29f435e26 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via d29f435e2676e104ae84bac840924c48f54b5568 (commit) from f117fa6f97a10008071e029d4fdc7a516f22200f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d29f435e2676e104ae84bac840924c48f54b5568 Author: Aleisha Amohia Date: Thu Feb 20 01:36:32 2020 +0000 Bug 24688: Check the priority of the fulfilled hold when fixing priorities Currently when fixing priorities of existing holds, priorities aren't fixed when checking out a middle priority hold because the hold has been fulfilled and deleted. This patch adds a check for, if the hold can't be found, an old hold with the required reserve_id. To test: 1. Place at least four holds on a biblio for different borrowers 2. Check out an item to the 3rd priority borrower 3. Check the existing holds table for the biblio. The priorities might be out of order, or try clicking the dropdowns and there might be an empty dropdown option, or open the browser developer tools and notice the option values in the select are missing value=3. 4. Apply patch and restart memcached 5. Check out an item to the 2nd priority borrower 6. Check the existing holds table for the biblio. Confirm the priorities have been fixed and are now consecutive with no gaps. Sponsored-by: Chartered Accountants Australia and New Zealand Signed-off-by: Emmi Takkinen Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit b17c16f9106eb159a1690da80a2a46b1f3a165ab) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/Reserves.pm | 4 ++++ 1 file changed, 4 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Apr 14 05:21:03 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 14 Apr 2020 03:21:03 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.15-9-g7a92d126df Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via 7a92d126df700be6ffcfbc3a371a04808714f2d6 (commit) from fc703cae7cabd692891aec706161c2c14734c6d8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7a92d126df700be6ffcfbc3a371a04808714f2d6 Author: Fridolin Somers Date: Tue Jan 28 16:09:20 2020 +0100 Bug 24527: misc/cronjobs/update_totalissues.pl problem with multiple items misc/cronjobs/update_totalissues.pl when issuing statistics table, no-incremental, has a problem for biblio with multiple items. The first SQL query gets the biblios linked to items with issues in statistics : SELECT biblio.biblionumber, COUNT(statistics.itemnumber) FROM biblio LEFT JOIN items ON (biblio.biblionumber=items.biblionumber) LEFT JOIN statistics ON (items.itemnumber=statistics.itemnumber) WHERE statistics.type = 'issue' $limit GROUP BY biblio.biblionumber The second SQL query is : SELECT biblio.biblionumber, 0 FROM biblio LEFT JOIN items ON (biblio.biblionumber=items.biblionumber) LEFT JOIN statistics ON (items.itemnumber=statistics.itemnumber) WHERE statistics.itemnumber IS NULL GROUP BY biblio.biblionumber The problem is that this second query will set to 0 where ANY item has no entry in statistics table. So when running it sets 0 to the biblio that had a value from first query. I think the best fix is to use "WHERE statistics.type = 'issue'" inside que JOIN : LEFT JOIN statistics ON (items.itemnumber=statistics.itemnumber AND statistics.type = 'issue') Test plan : 1) Begin with an empty database 2) Create a biblio 1 with no items 3) Create a biblio 2 with 3 items 4) Create a biblio 3 with 2 items 5) Checkout and checkin all items of biblio 2 6) Checkout and checkin the firt item of biblio 3 7) run misc/cronjobs/update_totalissues.pl --use-stats -v 8) Check biblio 1 has biblioitems.totalissues = 0 9) Check biblio 2 has biblioitems.totalissues = 3 10) Without patch the biblio 3 has biblioitems.totalissues = 0 11) With patch the biblio 3 has biblioitems.totalissues = 1 12) Check misc/cronjobs/update_totalissues.pl --incremental is OK Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 91da9841d78d26db205c6493c27c174c20e7b7c2) Signed-off-by: Lucas Gass (cherry picked from commit f6d61ce5e07c633143843604722f29b0d92d8fce) Signed-off-by: Hayley Mapley ----------------------------------------------------------------------- Summary of changes: misc/cronjobs/update_totalissues.pl | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 10 18:01:30 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 10 Apr 2020 16:01:30 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-41-g419d506425 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 419d5064257b8163601a6e20637f4ec62b91febc (commit) from 445847db6900349987d7fb265ea08017dc626d50 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 419d5064257b8163601a6e20637f4ec62b91febc Author: Andrew Isherwood Date: Mon Feb 3 11:14:50 2020 +0000 Bug 24565: Add patron profile to ILL list pages We need the API call to get ILL requests on the patron profile page, this commit allows this. Test plan: - Do not apply the patch. - Go to the "Ill requests history" page for a patron who has made ILL requests - TEST: Observe that no requests are displayed - Apply the patch - Refresh the page - TEST: Observe that requests are displayed - Go to the main "ILL requests" page - TEST: Observe that requests are displayed Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit b32023b10109e9e487f5aa59d194fa5599231743) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 13 21:52:14 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 13 Apr 2020 19:52:14 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-72-g816758d76f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 816758d76f319e4dcf5b7a53e5a0f111f48dafe9 (commit) from 38e82d3a90601145ae60855e632667f7df171a35 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 816758d76f319e4dcf5b7a53e5a0f111f48dafe9 Author: Nick Clemens Date: Thu Aug 1 14:57:29 2019 +0000 Bug 23411: Do not fall back to 'email' for SMS messages To test: 1 - Have a patron wiht an sms number, but no email 2 - Enable sms by setting SMSDriver syspref to Email 3 - Set Notice triggers to send an overdue via sms and email 4 - Ensure the selected notice is defined only for 'email' 5 - Checkout an overdue to the patron above You can set a specify a due date in the past 6 - perl misc/cronjobs/overdue_notices.pl -t 7 - Check the patron notices tab, they have a print notice and an SMS notice pending 8 - The SMS notice used the 'email' template 9 - Apply patch 10 - sudo koha-mysql kohadev 11 - DELETE * FROM message_queue WHERE borrowernumber={borrower as above}; 12 - Run the cron again 13 - Patron should have a print notice queued, no sms 14 - Define an SMS notice 15 - delete the message queue 16 - Run again 17 - The patron should have a print and an SMS Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 64d8beafa8b5745c5ca2e63fddaf2177246ce937) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: misc/cronjobs/overdue_notices.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 13 18:50:06 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 13 Apr 2020 16:50:06 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-56-g5d0a186b07 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 5d0a186b071a06d7c56de28febb358dbeafd44f2 (commit) from 499d53b00a252aebc19e496325438061a3e0e9dd (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5d0a186b071a06d7c56de28febb358dbeafd44f2 Author: Caroline Cyr La Rose Date: Wed Feb 12 14:32:01 2020 -0500 Bug 23236: Remove 'its items may still be processed' in action if no match is found When importing records and looking for duplicate records using record matching rules, there is an option if NO match is found to "ignore incoming record (its items may still be processed)". This doesn't make any sense. Where would the items go if there is no match? To test: 1) Go to Tools > Stage MARC for import 2) Browse and choose a file with at least one record that is not already in your catalog and click on Upload file 3) Fill out the first section with the appropriate information 4) In the Look for existing records in catalog? section, choose a record matching rule 5) In the Action if no match is found drop-down menu, choose Ignore incoming record (its items may still be processed) 6) Click on Stage for import 7) Click on Manage staged records 8) Click Import this batch in the catalog 9) In the table, the record status should say Ignore 10) Apply patch 11) Redo steps 1-9, notice the option Ignore incoming records does not mention items 12) Make sure the tool still works and still ignores the record Signed-off-by: Devinim Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 29941cd761cae087d0ac44b66e247635816a5352) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/includes/tools-nomatch-action.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 13 21:56:19 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 13 Apr 2020 19:56:19 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-74-g1df598be10 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 1df598be10f83c76038f14eb40a14882d6323fb4 (commit) via 9e64cbe1bf42dbfe4790209dded1169a3f3d1970 (commit) from 816758d76f319e4dcf5b7a53e5a0f111f48dafe9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1df598be10f83c76038f14eb40a14882d6323fb4 Author: Aleisha Amohia Date: Tue Feb 25 02:02:22 2020 +0000 Bug 8595: (follow-up) Changing other occurrences of 'host item' to 'host record' Signed-off-by: Michal Denar Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 59953212052ad480cb76de8946175b3602f7942f) Signed-off-by: Lucas Gass commit 9e64cbe1bf42dbfe4790209dded1169a3f3d1970 Author: Aleisha Amohia Date: Thu Feb 13 21:23:58 2020 +0000 Bug 8595: Rename 'host item' to 'host record' To test: 1) Enable the syspref EasyAnalyticalRecords 2) Find a biblio record, go to the detail page 3) Click the Edit dropdown and notice the option "Link to host item" 4) Apply patch and refresh page 5) Click the Edit dropdown and confirm the renamed "Link to host record" button Sponsored-by: Catalyst IT Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Michal Denar Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 2cff3403604f2a01d32032fbc386f2ebbf5c8b87) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/linkitem.tt | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Apr 14 16:50:47 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 14 Apr 2020 14:50:47 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1699-g1cae1929d3 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 1cae1929d366d16e36f7a777537bbef9a906d62c (commit) from ca46310b26e2f2f1f048b76aae8bdf63058dd029 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1cae1929d366d16e36f7a777537bbef9a906d62c Author: Tomas Cohen Arazi Date: Tue Apr 14 08:53:15 2020 -0300 Bug 25044: (follow-up) Fix wrong tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: t/Koha/REST/Plugin/Query.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Apr 14 17:40:24 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 14 Apr 2020 15:40:24 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1711-g63b44f2ddd Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 63b44f2ddd9cb67b80b840a7ad2bd3d77971cb2d (commit) via 73fd85fd02c2ea5aa69c93413e3d7fcd00c12b15 (commit) via a2f24f8e58410cd6d7ceed131182131dd3ce46aa (commit) via 79754df526d4b0225419678b76ece8315000d671 (commit) via 8a049803665d3e600f19ae70158c53132ec5a505 (commit) via c0f615fe533b802dec0e4a49923556e117ceca78 (commit) via 2598feedb90faedf31e12c0f1f90e7707b11f846 (commit) via 467dbcc60962dcef31c109a4efb93e2085af6696 (commit) via 135ab4c26ad8f32f4aed291578145b82574ab075 (commit) via 1709388c3a9c59f8d5bcd9d73add2236acdda84f (commit) via 51dbb84a78e7ad833ab2ce6104ed54954ded6835 (commit) via 30ea935720f8848be8a9a467d9dda89275d4557b (commit) from 1cae1929d366d16e36f7a777537bbef9a906d62c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 63b44f2ddd9cb67b80b840a7ad2bd3d77971cb2d Author: Martin Renvoize Date: Tue Apr 14 15:57:58 2020 +0100 Bug 21190: DBRev 19.12.00.068 Signed-off-by: Martin Renvoize commit 73fd85fd02c2ea5aa69c93413e3d7fcd00c12b15 Author: Marcel de Rooy Date: Thu Jan 30 09:27:56 2020 +0000 Bug 21190: (follow-up) Save patron id in failure when available The wrong password might belong to an existing user. If that is the case, we have a $patron. Note that logaction will save the object info but has no user in the context environment for a failure. Test plan: Login with good user, bad pw and bad user, bad pw. Check logviewer. Signed-off-by: Marcel de Rooy Signed-off-by: Michal Denar Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit a2f24f8e58410cd6d7ceed131182131dd3ce46aa Author: Marcel de Rooy Date: Mon Oct 28 10:06:11 2019 +0000 Bug 21190: Add tests for authentication success and failure Test plan: Run t/db_dependent/Log.t Signed-off-by: Marcel de Rooy Signed-off-by: Jon Knight Signed-off-by: Michal Denar Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 79754df526d4b0225419678b76ece8315000d671 Author: Marcel de Rooy Date: Fri Oct 25 10:12:16 2019 +0000 Bug 21190: Allow browsing the system logs for AUTH events Trivial change, adding AUTH to viewlog template only. Test plan: Look for the Authentication log lines in viewlog.pl (intranet tools). Signed-off-by: Marcel de Rooy Signed-off-by: Jon Knight Signed-off-by: Michal Denar Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 8a049803665d3e600f19ae70158c53132ec5a505 Author: Marcel de Rooy Date: Fri Oct 25 09:55:32 2019 +0000 Bug 21190: Add authentication logging to checkpw Add optional logging for successful and failing login attempts in checkpw. Test plan: Enable the preferences Perform a good login and a bad attempt Check action_logs Signed-off-by: Marcel de Rooy Signed-off-by: Jon Knight Signed-off-by: Michal Denar Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit c0f615fe533b802dec0e4a49923556e117ceca78 Author: Marcel de Rooy Date: Fri Oct 25 09:36:03 2019 +0000 Bug 21190: Introduce preferences AuthFailureLog and AuthSuccessLog Test plan: Run atomic update. Check the Logs tab of preferences. Signed-off-by: Marcel de Rooy Signed-off-by: Jon Knight Signed-off-by: Michal Denar Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 2598feedb90faedf31e12c0f1f90e7707b11f846 Author: Marcel de Rooy Date: Fri Oct 25 08:21:20 2019 +0000 Bug 21190: Remove t/Log.t Since we have t/db../Log.t and t/Log.t simply does nothing, we would better remove it. No test plan either :) Signed-off-by: Marcel de Rooy Signed-off-by: Jon Knight Signed-off-by: Michal Denar Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 467dbcc60962dcef31c109a4efb93e2085af6696 Author: Marcel de Rooy Date: Fri Oct 25 08:10:18 2019 +0000 Bug 21190: Add interfaces parameter to POD in C4::Logs Just fixing documentation along the way. No test plan, just read the patch. Signed-off-by: Marcel de Rooy Signed-off-by: Jon Knight Signed-off-by: Michal Denar Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 135ab4c26ad8f32f4aed291578145b82574ab075 Author: Marcel de Rooy Date: Fri Oct 25 07:32:56 2019 +0000 Bug 21190: Add subtest to Log.t for GDPR logging Apart from a new subtest, doing some more cleanup: [1] Copyright statement [2] Removing the (unneeded) flush [3] Removing C4::Log from the BEGIN block; we seem to skip that nowadays. [4] $succes goes to the subtest, $schema and $dbh are global our vars. Not required but just what we should do if it would run under Plack. Test plan: Run t/db_dependent/Log.t Signed-off-by: Marcel de Rooy Signed-off-by: Jon Knight Signed-off-by: Michal Denar Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 1709388c3a9c59f8d5bcd9d73add2236acdda84f Author: Marcel de Rooy Date: Fri Oct 25 07:14:18 2019 +0000 Bug 21190: Prepare Log.t for further changes This patch only makes cosmetic changes: [1] It moves the existing tests at 'root level' inside a new subtest. [2] It obviously adds indentation for step 1. [3] It fixes some whitespace (tabs, space before newline) Test plan: Run t/db../Log.t Signed-off-by: Marcel de Rooy Signed-off-by: Jon Knight Signed-off-by: Michal Denar Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 51dbb84a78e7ad833ab2ce6104ed54954ded6835 Author: Jonathan Druart Date: Tue Mar 31 16:39:12 2020 +0200 Bug 25027: Use localStorage instead of sessionStorage for results browser Staff side, when a search a done and a result clicked, a browser appears on the left, to navigate between the different results. We use sessionStorage to know the list of biblionumber from the result. As sessionStorage is only for the current tab, we do some ugly things, to catch the click events, then open the new tab, attach it to the current window, and put the focus back on the result list. We really should not do that, and let the user decide what they want to do with their clicks! To do so, let use the correct storage, localStorage, and have the results shared between the windows. We may need to clear that at some point, isn't it? Test plan: Launch a search, click result (left or middle), confirm you see the browser and that the window/tab opened like any other websites (depending on your web browser settings). Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 30ea935720f8848be8a9a467d9dda89275d4557b Author: Martin Renvoize Date: Tue Apr 14 15:54:17 2020 +0100 Bug 20754: (RM follow-up) Fix DB Update Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Auth.pm | 9 ++ C4/Log.pm | 2 +- Koha.pm | 2 +- installer/data/mysql/sysprefs.sql | 2 + installer/data/mysql/updatedatabase.pl | 16 +- koha-tmpl/intranet-tmpl/js/browser.js | 22 +-- .../prog/en/modules/admin/preferences/logs.pref | 13 ++ .../intranet-tmpl/prog/en/modules/tools/viewlog.tt | 3 +- t/Log.t | 12 -- t/db_dependent/Log.t | 173 ++++++++++++--------- 10 files changed, 147 insertions(+), 107 deletions(-) delete mode 100755 t/Log.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Apr 14 18:51:29 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 14 Apr 2020 16:51:29 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1761-g3999741d4a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 3999741d4a753ba593e4716618deac2141c4c889 (commit) via 66b62058d6d95469bc0fe1add52f7319a0839401 (commit) via 234262fae33a73d96d9c04e1ede0a48eca1fd5d2 (commit) via d117a7d3eadbb9ce019b92e18187ed53b2ef3249 (commit) via 323e1a2a2f28881e6aed13c78df1d0a3d5069c4e (commit) via b925d88de16e5e391a91f32d62dc32355095be84 (commit) via 2ce0327480b95c7fbb6b556966524d7c803ef2d7 (commit) via dcaba0ac4eb969abddcdb7d79c0c2c6f6e0f8dff (commit) via c132946cc075f0d622440054c439f69ff38544b5 (commit) via 0a70b46119c5df2c610a396393887161be9b3f85 (commit) via 2fbae01c9b127516953bbeafd77d1a030379f3a8 (commit) via e5e26645ee411488f01502892f841ba54a79604e (commit) via 0d4fed889904c5eeba05f12bdbf8d14f0e3ae0a8 (commit) via 83cde3858e5bfaf0619ecd4e9075d47e7063f199 (commit) via 17afb2b9ba6e9c38c9ed106deb7c2cf1023d7a5c (commit) via 29f399f1f8608310172b8f6963ad79a077783225 (commit) via 5793a29221cb9b687ec43381d6e1562d1b948e55 (commit) via 2e4fa2d677873778d53b92422642b62e9034cd77 (commit) via 936976a1fe9d0996c22e1b3727d5782a9f114cb2 (commit) via ec6c143f1b26f219f1e9ab5852436da09c857758 (commit) via 74c63d27c7f250da99255d7e64cfdad08a1702aa (commit) via e788ac4e5838ad530424eeff24302f5aee4c452a (commit) via fc4cffe1f0ac1379ddd1ce621189f1ef2d55d1fa (commit) via bf60a9c88cd223e53acd1d8e58508eb6d1febbb5 (commit) via fc29f2afa177fd3c497bcf5ec4bdb9299d396dc9 (commit) via f3e02aedf38b7f72207df5263c184d3e6af60f52 (commit) via 860264af6f6e3b51fb8b6eac4da25599c8568931 (commit) via 70ea3e39a883a4feb85f894e4fb25b59d21d5688 (commit) via 675ab180b098af15c2a24d90c1015a2291fd9126 (commit) via 294d6f54e5e57279168c042f76c209eb2b0e346e (commit) via b32c8fb91bf6c19124e7626a45191e3c50e0b73e (commit) via 91f9f8cdfd1ecbf56bbc4771d7c58cd9b468fc64 (commit) via 220c4906bf1bc399e639d5bd1c2c84319c54e3b8 (commit) via 82244a30b75435ee7e37d07e499c49844732d941 (commit) via f843e8be51edfd3f7d01e79d3d63bb1f389bc8f1 (commit) via 97876fa76dc3f618e76c6ff246da68be197a74dd (commit) via 6380c479b64ee78f6533312fc9c97530a843ac08 (commit) via 41e6f0447c00a817ff982ce70bbf98f78b968712 (commit) via f5b8b6b38c4db29ab66d5aeaf50eb6f1ab4e6e19 (commit) via 6f6f68d55b0a2740fde5c75364c12736b00bd020 (commit) via 468047c383536d802e1e02e3fefb2168dc9d27c7 (commit) via 86db304cd45ad2fc2f59bde30ae261b18831e8c6 (commit) via e98e77bd7323876c45854280ab9788f01c41503c (commit) via cd268bdbb2a9dfd2c70bc3f1fe1057b5860d06b4 (commit) via d6fc05891b5558fd5f2bb95c1fd200bcc43e2806 (commit) via 2d2ffbd075c95eb465fcc32c53b19f11d67cb4b6 (commit) via 77b7014f883e4f48310c3e03ca56f50a6ffa60f2 (commit) via d3a6cc48d0b7c6557d8d263580a96e1d87d79814 (commit) via fd831a07883993e8437fa80cb631cff3d4ed27ed (commit) via 6aee18111ed9c4efa92a242974c5ac439aa38880 (commit) from 63b44f2ddd9cb67b80b840a7ad2bd3d77971cb2d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3999741d4a753ba593e4716618deac2141c4c889 Author: Martin Renvoize Date: Tue Apr 14 17:21:25 2020 +0100 Bug 22887: DBRev 19.12.00.071 Signed-off-by: Martin Renvoize commit 66b62058d6d95469bc0fe1add52f7319a0839401 Author: Jonathan Druart Date: Tue Apr 14 10:12:57 2020 +0200 Bug 22887: Remove dup fr-FR for existing installs Signed-off-by: Martin Renvoize commit 234262fae33a73d96d9c04e1ede0a48eca1fd5d2 Author: Lari Taskula Date: Tue Apr 7 11:47:44 2020 +0000 Bug 22887: Schema changes Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit d117a7d3eadbb9ce019b92e18187ed53b2ef3249 Author: Jonathan Druart Date: Thu Mar 26 10:29:11 2020 +0100 Bug 22887: Rely on unique constraint in av admin Test plan: Try to create 2 AV with the same code for the same category. You should see a warning Signed-off-by: Martin Renvoize Signed-off-by: Lari Taskula Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 323e1a2a2f28881e6aed13c78df1d0a3d5069c4e Author: Jonathan Druart Date: Thu Mar 26 10:36:03 2020 +0100 Bug 22887: Remove dup in fr-FR av.sql https://en.wikipedia.org/wiki/Cocos_(Keeling)_Islands Signed-off-by: Martin Renvoize Signed-off-by: Lari Taskula Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit b925d88de16e5e391a91f32d62dc32355095be84 Author: Jonathan Druart Date: Thu Mar 26 10:28:50 2020 +0100 Bug 22887: Warn if duplicates exist Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 2ce0327480b95c7fbb6b556966524d7c803ef2d7 Author: Martin Renvoize Date: Fri May 10 15:32:03 2019 +0100 Bug 22887: Add unique constraint to authorised_values Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit dcaba0ac4eb969abddcdb7d79c0c2c6f6e0f8dff Author: Nick Clemens Date: Tue Mar 10 07:12:07 2020 -0400 Bug 24620: Fix test, remove replaced code, use dt_from_string Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit c132946cc075f0d622440054c439f69ff38544b5 Author: Nick Clemens Date: Mon Feb 10 18:19:07 2020 +0000 Bug 24620: Close existing transfers when setting item to waiting This patch adds a clause in ModReserveAffect to check if there are existing transfers and close them when setting a hold to waiting To test: 1 - Set AutomaticItemReturn to Do 2 - Checkin an item from Library B at Library A 3 - Confirm item is in transfer (check the details page) 4 - Place a item level hold for pickup at library A 5 - Checkin the item at Library A 6 - Confirm the hold 7 - View the details page 8 - Note the item is in transit and waiting 9 - Apply patch 10 - Delete hold and repeat 11 - Confirm that transfer is closed when hold marked waiting Signed-off-by: Sally Signed-off-by: Stina Hallin Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 0a70b46119c5df2c610a396393887161be9b3f85 Author: Nick Clemens Date: Mon Feb 10 18:18:45 2020 +0000 Bug 24620: Unit tests Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 2fbae01c9b127516953bbeafd77d1a030379f3a8 Author: Jonathan Druart Date: Tue Apr 14 10:18:31 2020 +0200 Bug 23571: (QA follow-up) Remove perlcritic warning Bareword file handle opened at line 138, column 5. See pages 202,204 of PBP. (Severity: 5) Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit e5e26645ee411488f01502892f841ba54a79604e Author: Tomas Cohen Arazi Date: Mon Apr 13 15:50:54 2020 -0300 Bug 23571: (QA follow-up) Add missing newline in warning Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 0d4fed889904c5eeba05f12bdbf8d14f0e3ae0a8 Author: Tomas Cohen Arazi Date: Sun Apr 12 10:27:57 2020 -0300 Bug 23571: Prevent concurrent execution of fines.pl This patch introduces locking in fines.pl. It does so by leveraging on bug 25109, which introduces a generic locking implementation on Koha::Script. The introduced changes: 1. Try to get the lock 2.a. If success, normal execution happens 2.b. If rejected, cronlogaction is called with a meaningful message and a normal exit happens, so we don't flood the logs in vain. --verbose will make the script print the same message on STDERR, as already is the case with this script To test: 1. Apply this patch 2. In two separate consoles run: $ kshell k$ perl misc/cronjobs/fines.pl --verbose SUCCESS => The first one runs normally, the second one exists really fast and prints a message about the lock. 3. Sign off :-D Sponsored-by: Orex Digital Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 83cde3858e5bfaf0619ecd4e9075d47e7063f199 Author: Tomas Cohen Arazi Date: Mon Apr 13 15:45:50 2020 -0300 Bug 25109: (QA follow-up) Add a test for lockdir writable in about.pl Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 17afb2b9ba6e9c38c9ed106deb7c2cf1023d7a5c Author: Tomas Cohen Arazi Date: Mon Apr 13 12:02:29 2020 -0300 Bug 25109: (QA follow-up) Fix typo in configuration entry name This patch fixes an error in the configuration retrieving line. Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 29f399f1f8608310172b8f6963ad79a077783225 Author: Tomas Cohen Arazi Date: Mon Apr 13 08:43:10 2020 -0300 Bug 25109: Add 'wait' tests This simple patch introduces a test for the lock waiting scenario. It replicates the previous tests, but calls a script that passes the wait => 1 parameter to ->lock_exec. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 5793a29221cb9b687ec43381d6e1562d1b948e55 Author: Tomas Cohen Arazi Date: Fri Apr 10 19:37:31 2020 -0300 Bug 25109: Add ->new and ->lock_exec to Koha::Script Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 2e4fa2d677873778d53b92422642b62e9034cd77 Author: Tomas Cohen Arazi Date: Fri Apr 10 19:36:41 2020 -0300 Bug 25109: Add entry in about.pl about the configuration lockdir entry Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 936976a1fe9d0996c22e1b3727d5782a9f114cb2 Author: Tomas Cohen Arazi Date: Fri Apr 10 19:36:09 2020 -0300 Bug 25109: Add lockdir configuration entry Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit ec6c143f1b26f219f1e9ab5852436da09c857758 Author: Fridolin Somers Date: Tue Oct 22 14:31:08 2019 +0200 Bug 23871: data inconsistencies - check title exists In biblio records, a field must be linked to biblio.title. 200$a in UNIMARC, 100$a MARC21 (and other). If this field is undefined, some pages like checkouts table can fail. Test plan : 1) Remove biblio title in SQL : UPDATE biblio SET title='' WHERE biblionumber=XXX 2) Run misc/maintenance/search_for_data_inconsistencies.pl 3) You see the record as an inconsistency 4) Reset a title UPDATE biblio SET title='50 shades of Grey' WHERE biblionumber=XXX 5) Run misc/maintenance/search_for_data_inconsistencies.pl 6) Record is no longer an inconsistency Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 74c63d27c7f250da99255d7e64cfdad08a1702aa Author: Fridolin Somers Date: Wed Mar 11 17:39:18 2020 +0300 Bug 21865: allow test arg alone Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit e788ac4e5838ad530424eeff24302f5aee4c452a Author: Fridolin Somers Date: Mon Nov 19 15:45:49 2018 +0100 Bug 21865: add confirm to remove_unused_authorities.pl script Like in most scripts in misc, add confirm argument to ensure script is not run without knowing what it does. Test plan: 1) Run misc/migration_tools/remove_unused_authorities.pl -h 2) You see help line for confirm 3) Run misc/migration_tools/remove_unused_authorities.pl 4) You see help and script does nothing 5) Run misc/migration_tools/remove_unused_authorities.pl -c 6) Script runs like wanted Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit fc4cffe1f0ac1379ddd1ce621189f1ef2d55d1fa Author: Fridolin Somers Date: Mon Nov 19 15:19:46 2018 +0100 Bug 21865: ES compatiblity of remove_unused_authorities.pl The script misc/migration_tools/remove_unused_authorities.pl directly checks if Zebra search is OK. This patch changes so that this test is only if Zebra is the search engine. It also adds a test on the search off any authority number indexed (index 'an'). With Zebra its : an,alwaysmatches='' With ES its : an:* This test ensure that biblios records are indexed and that not all autorities will be deleted. Test plan: 1) On a catalog create a new authority 2) Use Zebra in systempreference SearchEngine 3) Stop Zebra server 4) Run misc/migration_tools/remove_unused_authorities.pl -c 5) The script does nothing and says : Zebra server seems not to be available. This script needs Zebra runs. 6) Restart Zebra server 7) Delete biblio index base 8) Run misc/migration_tools/remove_unused_authorities.pl -c 9) The script does nothing and says : Searching authority number in biblio records seems not to be available : an,alwaysmatches='' 10) Use ElasticSearch in systempreference SearchEngine 11) Delete biblio index base 12) Run misc/migration_tools/remove_unused_authorities.pl -c 13) The script does nothing and says : Searching authority number in biblio records seems not to be available : an:* Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit bf60a9c88cd223e53acd1d8e58508eb6d1febbb5 Author: Fridolin Somers Date: Mon Nov 19 14:46:05 2018 +0100 Bug 21865: improve remove_unused_authorities.pl script remove_unused_authorities.pl script can be improved. This patch changes changes verbosity so than test mode can be used to know the autorities that are used and those that can be deleted. It also writes a line in output if limited authority type(s). This patch also removes the unused vars $thresholdmin and $thresholdmax. It also changes the query to use SQL with parameters for authority types. Test plan : 1) On a catalog create a new authority 2) Be sure catalog is well indexed 3) Run misc/migration_tools/remove_unused_authorities.pl -t 4) You will see the line : *** Testing only, authorities will not be deleted. *** 5) You will see lines of : authid=x type=y : used X time(s) 6) You will see the line for the authority created in 1) : authid=x type=y : can be deleted 7) You will see at the end : x authorities parsed y can be deleted because unused z unchanged because used 8) Run misc/migration_tools/remove_unused_authorities.pl 9) You don't see the line : *** Testing only, authorities will not be deleted. *** 10) You will see lines of : authid=x type=y : used X time(s) 11) You will see the line for the authority created in 1) : authid=x type=y : deleted 12) You will see at the end : x authorities parsed y deleted because unused z unchanged because used 13) Run misc/migration_tools/remove_unused_authorities.pl --auth NP --auth CO 14) You see the line : Restricted to authority type(s) : NP,CO. Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit fc29f2afa177fd3c497bcf5ec4bdb9299d396dc9 Author: Martin Renvoize Date: Tue Apr 14 16:52:49 2020 +0100 Bug 22774: DBRev 19.12.00.070 Signed-off-by: Martin Renvoize commit f3e02aedf38b7f72207df5263c184d3e6af60f52 Author: Katrin Fischer Date: Mon Apr 13 20:28:06 2020 +0200 Bug 22774: (QA follow-up) Rephrase OPAC notes I've changed the OPAC notes a little bit, main change is the removal of the tags used to highlight single words in one sentence as they would result in splitting up the sentence into multiple parts which makes proper translations really hard. Signed-off-by: Martin Renvoize commit 860264af6f6e3b51fb8b6eac4da25599c8568931 Author: Katrin Fischer Date: Mon Apr 13 20:11:00 2020 +0200 Bug 22774: (QA follow-up) Add syspref descriptions to database update and sysprefs.sql Moves the updatedatabase entry to the new format and adds information for the explanation column of the systempreferences table. Also slightly rephrases the description in the system preference editor. To test: - Verify database update still works the same with addition of explanations - Verify the sys pref description makes sense Signed-off-by: Martin Renvoize commit 70ea3e39a883a4feb85f894e4fb25b59d21d5688 Author: Nazlı Çetin Date: Mon Mar 23 13:30:48 2020 +0000 Bug 22774: (follow-up) Limit purchase suggestion in a specified time period Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 675ab180b098af15c2a24d90c1015a2291fd9126 Author: Devinim Date: Thu Jan 9 10:48:15 2020 +0000 Bug 22774: Limit Purchase Suggestion in a specified Time period Test plan: 1 - Apply this patch 2 - Run updatedatabase.pl 3 - By default the preferences are blank and do not limit. 4 - Set the limits to 3 in 30 days 5 - Go to purchase suggestion page from OPAC as a logged in patron 6 - Place 3 suggestions and confirm you cannot place any more 7 - Alter one of the suggestions to have been made more than 30 days ago UPDATE suggestions SET suggesteddate = '2020-01-01' WHERE suggestionid=3; 8 - Confirm you can place another suggestion 9 - Log out of OPAC 10 - Make sure AnonSyggestions is set to 'Allow' and AnonymousPatron is set 11 - Confirm anonymous suggestions are not limited by the syspref 12 - Confirm that a blank value in either MaxTotalSuggestions or NumberOfSuggestionDays does not limit suggestions Signed-off-by: Kelly McElligott Signed-off-by: Rhonda Kuiper Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 294d6f54e5e57279168c042f76c209eb2b0e346e Author: Nazlı Çetin Date: Fri Feb 21 14:08:16 2020 +0000 Bug 22774: New systempreferences for suggestions added to sysprefs.sql Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit b32c8fb91bf6c19124e7626a45191e3c50e0b73e Author: Jonathan Druart Date: Fri Mar 15 19:38:29 2019 -0300 Bug 20728: Remove the 2 GetLastOrder* subroutines At this point the 2 subroutines are no longer in used. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 91f9f8cdfd1ecbf56bbc4771d7c58cd9b468fc64 Author: Jonathan Druart Date: Fri Mar 15 19:37:52 2019 -0300 Bug 20728: Replace the calls by their Koha::Acq::Orders->search equivalent There are 2 subroutines from C4::Acquisition that could be removed: - GetLastOrderReceivedFromSubscriptionid - GetLastOrderNotReceivedFromSubscriptionid After bug 20726 only GetLastOrderReceivedFromSubscriptionid will be used (from acqui/neworderempty.pl) and this call could be replaced easily with Koha::Acquisition::Orders The code (+ tests) related to these 2 subroutines could then be removed. The parameters for the search is basic and does no really deserve its own subroutine. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 220c4906bf1bc399e639d5bd1c2c84319c54e3b8 Author: Jonathan Druart Date: Fri Mar 15 19:24:19 2019 -0300 Bug 20728: Proof that there is no cheating To make sure the replacing code will acchieve the same things as the actual one, we replace the raw SQL query with the DBIC version of it. Then the tests will show us that they are equivalent. Test plan: Apply only this patch, run the tests, confirm they pass. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 82244a30b75435ee7e37d07e499c49844732d941 Author: Martin Renvoize Date: Tue Apr 14 16:37:43 2020 +0100 Bug 23591: Compiled CSS Signed-off-by: Martin Renvoize commit f843e8be51edfd3f7d01e79d3d63bb1f389bc8f1 Author: Jonathan Druart Date: Tue Nov 19 17:35:09 2019 +0100 Bug 23591: Hide archived suggestions However we are adding a note on top of the table to tell how many suggestions are archived. It seems that there is no good reason to display the archived suggestions on this table. Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 97876fa76dc3f618e76c6ff246da68be197a74dd Author: Jonathan Druart Date: Mon Nov 18 16:37:43 2019 +0100 Bug 23591: Use same css for suggestion notes Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 6380c479b64ee78f6533312fc9c97530a843ac08 Author: Jonathan Druart Date: Mon Nov 18 15:50:55 2019 +0100 Bug 23591: Display a new "Suggestion detail" tab on the bib detail page This patch adds a new "Suggestion detail" tab on the bibliographic detail page. It will help suggestion management. Test plan: - Create several suggestions for a given biblio - Go to the detail page of the bibliographic record and confirm that there is a new "Suggestion detail" tab with all the suggestions you created. Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 41e6f0447c00a817ff982ce70bbf98f78b968712 Author: Jonathan Druart Date: Mon Nov 18 15:52:57 2019 +0100 Bug 23591: Add some useful methods to Koha::Suggestions Those are methods initially written for bug 23991. I finally need them before than expected. Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit f5b8b6b38c4db29ab66d5aeaf50eb6f1ab4e6e19 Author: Jonathan Druart Date: Mon Feb 17 17:21:03 2020 +0100 Bug 23596: (follow-up) Add missing use statement and set correct variable name Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 6f6f68d55b0a2740fde5c75364c12736b00bd020 Author: Jonathan Druart Date: Fri Nov 8 15:50:57 2019 +0100 Bug 23596: Edit suggestion's reason when receiving This patch displays and let the librarian edit the suggestion.reason information when receiving an order. Note that if no reason was given the edit is not possible (easily modifiable if needed but it seems that we do not want to display too much details unnecessarily) Test plan: - Create a suggestion and fill the reason - Create an order from this suggestion - Close the basket and start receiving the order => The reason is displayed and editable - Modify the reason and click Save - Receive again => The reason has been correctly modified - Play with the "Others..." option and give a specific reason Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE Signed-off-by: Bouzid Fergani Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 468047c383536d802e1e02e3fefb2168dc9d27c7 Author: David Roberts Date: Sat Apr 4 23:13:00 2020 +0000 Bug 25053: Clarify the description of syspref PatronSelfRegistrationExpireTemporaryAccountsDelay This patch changes the wording of this system preference. To test: 1) Check the current wording of this system preference. 2) Install the patch. 3) Check that the wording of this system preference has changed to "Delete patrons still in the category indicated by PatronSelfRegistrationDefaultCategory X days after account creation." Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 86db304cd45ad2fc2f59bde30ae261b18831e8c6 Author: Martin Renvoize Date: Tue Apr 14 16:25:31 2020 +0100 Bug 22784: DBRev 19.12.00.069 Signed-off-by: Martin Renvoize commit e98e77bd7323876c45854280ab9788f01c41503c Author: Katrin Fischer Date: Sat Apr 11 09:39:31 2020 +0000 Bug 22784: Fix small display issue with fa icon in suggestions table The was not closed resulting in the "Archived" displaying in the wrong font. Might be a browser specific issue, but adding the closing fixed it and follows the existing pattern. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit cd268bdbb2a9dfd2c70bc3f1fe1057b5860d06b4 Author: Jonathan Druart Date: Fri Mar 27 07:55:52 2020 +0100 Bug 22784: DBIC changes Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit d6fc05891b5558fd5f2bb95c1fd200bcc43e2806 Author: Jonathan Druart Date: Thu Nov 14 16:41:40 2019 +0100 Bug 22784: Add a cronjob to archive suggestions given age or status criteria In order to deal automatically with suggestions that need to be archived, this cronjob will help to add the "archived" flag following their age or status. Test plan: - Execute the script with the --help parameter and read the documentation. - Does it make sense? - Use it without the --confirm flag and try several combination For instance you will want to archive suggestions that have been rejected for more than a week: perl misc/cronjobs/archive_purchase_suggestions.pl --age-date-field=rejecteddate --age=weeks:1 or even suggestion that have been suggested for more than a year and have a ORDERED status: perl misc/cronjobs/archive_purchase_suggestions.pl --age-date-field=suggesteddate --age=years:1 --status=ORDERED - Use it with the --confirm flag and make sure the suggestions have been archived. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 2d2ffbd075c95eb465fcc32c53b19f11d67cb4b6 Author: Jonathan Druart Date: Mon Nov 18 15:16:24 2019 +0100 Bug 22784: Do not display an empty table This is terrible and highlight that the whole script must be rewrite. GetDistinctValues does not handle the "archived" flag (and we do not want to put our hands there), so let's hack that and plan to rewrite the whole script. Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 77b7014f883e4f48310c3e03ca56f50a6ffa60f2 Author: Jonathan Druart Date: Mon Nov 18 14:56:05 2019 +0100 Bug 22784: Bugfix - do not modify #description build Debian packages from a git repository Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit d3a6cc48d0b7c6557d8d263580a96e1d87d79814 Author: Jonathan Druart Date: Wed Nov 13 16:34:56 2019 +0100 Bug 22784: Add the ability to archive/unarchive a purchase suggestions There are performance issues when searching suggestions if there are thousands of suggestions. To prevent that we are going to add the ability to archive purchase suggestions, in order to remove them from the search list (by default). Test plan: 0. Apply all the patches, execute the updatedatabase.pl script, restart all 1. Create some suggestions 2. Search for them 3. Use the "Archive" action button for one of them 4. Restart the search => The archived suggestion does no longer appear in the list 5. Use the filter "Included archived" in the "Suggestion information" filter box => The archived suggestion is now displayed 6. Use other filters => The "archived" filter is kept from one search to another 7. Use one of the action at the bottom of the suggestion list (change the status for instance) => The "archived" filter is still kept Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit fd831a07883993e8437fa80cb631cff3d4ed27ed Author: Jonathan Druart Date: Wed Nov 13 15:06:23 2019 +0100 Bug 22784: DB Changes Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 6aee18111ed9c4efa92a242974c5ac439aa38880 Author: Kyle M Hall Date: Thu Jan 30 10:29:05 2020 -0500 Bug 24547: Add more action logs for holds It seems like ModReserveFill and ModReserveAffect should both produce action logs for holds. Test Plan: 1) Apply this patch 2) Place a hold 3) Check in the item to trap the hold 4) Check out the item to fill the hold 5) Check the action logs for that reserve id 6) Note the new logs! Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Acquisition.pm | 65 ------- C4/Reserves.pm | 19 +- C4/Suggestions.pm | 5 + Koha.pm | 2 +- Koha/Schema/Result/AuthorisedValue.pm | 20 ++- Koha/Schema/Result/Suggestion.pm | 16 +- Koha/Script.pm | 97 +++++++++++ Koha/Suggestion.pm | 62 ++++++- Makefile.PL | 9 + about.pl | 14 ++ acqui/finishreceive.pl | 9 + acqui/neworderempty.pl | 15 +- acqui/orderreceive.pl | 10 +- admin/authorised_values.pl | 31 ++-- catalogue/detail.pl | 14 ++ debian/templates/koha-conf-site.xml.in | 1 + etc/koha-conf.xml | 1 + .../fr-FR/1-Obligatoire/authorised_values.sql | 1 - installer/data/mysql/kohastructure.sql | 2 + installer/data/mysql/sysprefs.sql | 2 + installer/data/mysql/updatedatabase.pl | 57 ++++++ .../intranet-tmpl/prog/css/src/staff-global.scss | 12 ++ koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 14 ++ .../prog/en/modules/acqui/orderreceive.tt | 54 +++++- .../prog/en/modules/admin/authorised_values.tt | 2 - .../prog/en/modules/admin/preferences/opac.pref | 12 +- .../prog/en/modules/catalogue/detail.tt | 82 +++++++++ .../prog/en/modules/suggestion/suggestion.tt | 50 +++++- .../bootstrap/en/modules/opac-suggestions.tt | 23 ++- misc/cronjobs/archive_purchase_suggestions.pl | 193 +++++++++++++++++++++ misc/cronjobs/fines.pl | 14 ++ .../maintenance/search_for_data_inconsistencies.pl | 15 ++ misc/migration_tools/remove_unused_authorities.pl | 87 ++++++---- opac/opac-suggestions.pl | 23 ++- suggestion/suggestion.pl | 22 ++- t/Koha/Script.t | 40 ++++- t/Koha/sleep.pl | 19 ++ t/Koha/wait.pl | 17 ++ t/db_dependent/Acquisition/OrderFromSubscription.t | 17 +- t/db_dependent/Circulation.t | 43 ++++- t/db_dependent/Koha/Suggestions.t | 63 ++++++- 42 files changed, 1086 insertions(+), 170 deletions(-) create mode 100755 misc/cronjobs/archive_purchase_suggestions.pl create mode 100755 t/Koha/sleep.pl create mode 100755 t/Koha/wait.pl hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Apr 14 21:20:04 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 14 Apr 2020 19:20:04 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1762-g60f4104626 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 60f4104626e4c846f089789fdf67adcf7db3e8f3 (commit) from 3999741d4a753ba593e4716618deac2141c4c889 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 60f4104626e4c846f089789fdf67adcf7db3e8f3 Author: Martin Renvoize Date: Tue Apr 14 19:51:45 2020 +0100 Bug 22887: (RM follow-up) Fix Charges Test The charges test added a duplicate authorised value needlessly (it's already present in the sample data). Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: t/db_dependent/Koha/Charges/Sales.t | 9 --------- 1 file changed, 9 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Apr 15 00:14:29 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 14 Apr 2020 22:14:29 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.15-17-g88b0ba01e9 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via 88b0ba01e94f95efaedd74808a7833d1d1a58632 (commit) from 25a2a7096327d4338b75c2c3cce6beee0b1f7a1a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 88b0ba01e94f95efaedd74808a7833d1d1a58632 Author: David Cook Date: Mon Jan 13 17:05:17 2020 +1100 Bug 17464: Order deny,allow / Deny from all was deprecated in Apache 2.4 and is now a hard error Patch change Apache access control from 2.2 to 2.4 directives. Test plan: 0. Apply patch 1. Build Koha from source 2. Copy or symlink koha-dev/etc/koha-httpd.conf into your relevant Apache directory. 3. Reload Apache 4. Note a lack of syntax errors regarding the "Order" directive Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit c0422998f89daf82eb898ddb951d46df97a6f1e4) Signed-off-by: Lucas Gass (cherry picked from commit 97df645697f238f503d6afe1105d203eacd6fc51) Signed-off-by: Hayley Mapley ----------------------------------------------------------------------- Summary of changes: etc/koha-httpd.conf | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Apr 15 00:29:49 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 14 Apr 2020 22:29:49 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.15-18-gef79c94ebd Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via ef79c94ebd87813e5786c77b64793e8ff6fe40ff (commit) from 88b0ba01e94f95efaedd74808a7833d1d1a58632 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ef79c94ebd87813e5786c77b64793e8ff6fe40ff Author: Owen Leonard Date: Wed Mar 4 18:29:24 2020 +0000 Bug 24798: smart-rules.tt has erroneous comments This patch corrects a couple of invalid Template Toolkit comments in the Circulation and Fines rules template. To test, apply the patch and log into the staff client as an administrator. On the Circulation and Fines Rules page "View source" and look for instances of the text "[#% Default branch %#]" There should be none. Signed-off-by: David Nind Signed-off-by: Marcel de Rooy [EDIT] There is a theoretical difference between [% # and [%#. The latter marks the whole directive as a comment and not just until EOL. Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 1fbd4468642aa09b999b3baf014b6f3a0afd6df8) Signed-off-by: Lucas Gass (cherry picked from commit b791fabc939ace33aa915d3ae6e2480ce2901581) Signed-off-by: Hayley Mapley ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Apr 15 00:45:19 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 14 Apr 2020 22:45:19 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.15-19-gdb9102617e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via db9102617e8db020fa5a598632538a7997612e95 (commit) from ef79c94ebd87813e5786c77b64793e8ff6fe40ff (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit db9102617e8db020fa5a598632538a7997612e95 Author: Jonathan Druart Date: Thu Mar 5 16:27:15 2020 +0100 Bug 24813: Prevent api/v1/holds.t to fail randomly Hold cannot be suspended if found=W: Koha::Hold->suspend_hold 90 if ( $self->is_found ) { # We can't suspend found holds So when TestBuilder generate a hold with found=W the test fail. A question however: Why did not we have the correct exception displayed somewhere? That would be much more helpful to find the problem! Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit c405b03dd367adb7c1c274477865a7444f59c9e9) Signed-off-by: Lucas Gass (cherry picked from commit 1993e98edf0c272d6d93e18292a5c8b79da4b458) Signed-off-by: Hayley Mapley ----------------------------------------------------------------------- Summary of changes: t/db_dependent/api/v1/holds.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Apr 15 02:08:23 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 15 Apr 2020 00:08:23 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.15-20-ge41180c459 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via e41180c459f3f8adc5427ae95292b6aa78511f09 (commit) from db9102617e8db020fa5a598632538a7997612e95 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e41180c459f3f8adc5427ae95292b6aa78511f09 Author: Andrew Fuerste-Henry Date: Wed Mar 11 00:54:03 2020 +0000 Bug 24838: Fix help link for patron categories To test: - go to admin/categories.pl - click Help, confirm it takes you to manual main page - apply patch - restart all - click Help, confirm it takes you to patron categories in manual Signed-off-by: Sally Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 5fbde57bbcb5c4035c6e7a5a7416ebbc407719e2) Signed-off-by: Lucas Gass (cherry picked from commit bacd18d29b1b2e5ceeb8ec7ca4a0dcbccd418d87) Signed-off-by: Hayley Mapley ----------------------------------------------------------------------- Summary of changes: Koha/Manual.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Apr 15 02:27:46 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 15 Apr 2020 00:27:46 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.04-143-g5575d6799c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 5575d6799c9cf4927f62dd82478df7af5c04eab8 (commit) via 2eead92f18b774aff746a872038132f726885064 (commit) via 300f5e6a061b6774fef078902f16236eac3b25ba (commit) from cb7729c55df1ac4197e9fcf92d42789ba3006bca (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5575d6799c9cf4927f62dd82478df7af5c04eab8 Author: Nick Clemens Date: Tue Mar 24 12:15:26 2020 +0000 Bug 22771: (QA follow-up) Fix POD Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 2eead92f18b774aff746a872038132f726885064 Author: David Gustafsson Date: Fri Mar 6 14:07:53 2020 +0100 Bug 22771: Fix mistakes in list of nonfiling character fields Signed-off-by: David Nind Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 300f5e6a061b6774fef078902f16236eac3b25ba Author: David Gustafsson Date: Wed Feb 26 16:14:36 2020 +0100 Bug 22771: Respect nonfiling indicators for search fields Strip initial characters from search fields in accordance with nonfiling character indicators. To test: 1) Apply patch 2) Run tests in t/Koha/SearchEngine/Elasticsearch.t 3) All tests should pass Signed-off-by: David Nind Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: Koha/SearchEngine/Elasticsearch.pm | 104 ++++++++++++++++++++++++++++++++---- t/Koha/SearchEngine/Elasticsearch.t | 25 ++++++++- 2 files changed, 117 insertions(+), 12 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Apr 15 03:45:47 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 15 Apr 2020 01:45:47 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.15-21-g91faeb16bb Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via 91faeb16bb0059fc694d40fae7b97c8317c4789f (commit) from e41180c459f3f8adc5427ae95292b6aa78511f09 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 91faeb16bb0059fc694d40fae7b97c8317c4789f Author: Jonathan Druart Date: Mon Mar 30 16:11:51 2020 +0200 Bug 25020: Preserve time part when batch extending due dates When selecting a new hard due date, we should keep the time part of the original checkouts. Test plan: 1 - Checkout an item specifying a date due 2 - Checkout an item without specifying a date due 3 - Use Tools->Batch extend due date 4 - Select a hard due date 5 - On the confirmation screen you should see that the time part has been kept 6 - Confirm 7 - Make sure the correct values hava been inserted in DB 8 - Try now using the other option, give a number of days 9 - Repeat 4-7 Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 5550da8a50dbb60fcad6ea2a43658938d1200803) Signed-off-by: Lucas Gass (cherry picked from commit 5d49c806445e00dd55259d805c7d88a73378e61f) Signed-off-by: Hayley Mapley ----------------------------------------------------------------------- Summary of changes: .../en/modules/tools/batch_extend_due_dates.tt | 6 +-- tools/batch_extend_due_dates.pl | 47 ++++++++++++++++++---- 2 files changed, 40 insertions(+), 13 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Apr 15 10:02:56 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 15 Apr 2020 08:02:56 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1766-gcc6c3f5815 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via cc6c3f581593e4b9c6e31b5209c95d01f7a30ae4 (commit) via 909e172c17d0bb69fa9f9a25bf7d075b7dcc99c2 (commit) via 0a1fdaf9f22016dddc1c324a62e4ff52276e9aba (commit) via 0ef1e1a24ca0ecc53c81d2c1dae218004e7730b6 (commit) from 60f4104626e4c846f089789fdf67adcf7db3e8f3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit cc6c3f581593e4b9c6e31b5209c95d01f7a30ae4 Author: Jonathan Druart Date: Tue Apr 14 12:00:01 2020 +0200 Bug 25137: (bug 23084 follow-up) Fix incorrect grep ternary condition The lack of parenthesis makes the condition evaluated wrong. Test plan: - confirm you have a branch with code X - enter X in PatronSelfRegistrationLibraryList - go to cgi-bin/koha/opac-memberentry.pl (either as a logged in patron or as a self-reg patron) - confirm branch dropdown is not empty and contain X - empty out PatronSelfRegistrationLibraryList - reload cgi-bin/koha/opac-memberentry.pl and confirm branches show Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 909e172c17d0bb69fa9f9a25bf7d075b7dcc99c2 Author: Martin Renvoize Date: Fri Mar 6 11:38:03 2020 +0000 Bug 24820: Use 'date' instead of 'timestamp' for cashup Prior to this patch we were comparing cash register action timestamp to accountlines date fields to fetch the list of outstanding accountlines. accountlines.date is a transient field used as 'updated_on' and so this was a logical mistake. We should be using the 'date' field which is fixed 'created_on' time. Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 0a1fdaf9f22016dddc1c324a62e4ff52276e9aba Author: Martin Renvoize Date: Tue Apr 14 10:16:58 2020 +0100 Bug 25139: Corrections to date picker handling It would appear one has to format the dates in the controller rather than in the template for input fields.. I wasn't aware of this caveat until now. Test plan 1/ Prior to applying patch attempt to look at previous transactions ensuring you enter a 'to' date. 2/ Note a catastrophic failure 3/ Apply patch 4/ Look at the same date range and note you no longer get a failure but are instead faced with the requested transactions. 5/ Signoff Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 0ef1e1a24ca0ecc53c81d2c1dae218004e7730b6 Author: Marcel de Rooy Date: Thu Feb 20 12:10:57 2020 +0000 Bug 24697: Split items.uri on staff detail view If there are more URIs, we split on vertical bar and show the real URL instead of duplicated text. Otherwise display depends on the pref URLLinkText. Test plan: Create item with uri = A | B | C Create another item with uri = D Check the results on staff detail view (items table). Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: Koha/Cash/Register.pm | 2 +- .../intranet-tmpl/prog/en/modules/catalogue/detail.tt | 14 +++++++++----- koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt | 4 ++-- opac/opac-memberentry.pl | 6 +++++- pos/register.pl | 7 ++++--- 5 files changed, 21 insertions(+), 12 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Apr 15 13:19:06 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 15 Apr 2020 11:19:06 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1767-gae297d8f02 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via ae297d8f0284c06e479ca8b4c96c92f008935b0d (commit) from cc6c3f581593e4b9c6e31b5209c95d01f7a30ae4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ae297d8f0284c06e479ca8b4c96c92f008935b0d Author: Martin Renvoize Date: Wed Apr 15 11:51:12 2020 +0100 Bug 24820: (RM follow-up) Fix test after switch to 'date' field Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: t/db_dependent/Koha/Cash/Register.t | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Apr 15 13:50:28 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 15 Apr 2020 11:50:28 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1768-gc0f79717ee Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via c0f79717eeaca4b1ca703148ea7d61bb0311689c (commit) from ae297d8f0284c06e479ca8b4c96c92f008935b0d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c0f79717eeaca4b1ca703148ea7d61bb0311689c Author: Tomas Cohen Arazi Date: Tue Apr 14 17:02:24 2020 -0300 Bug 22784: (QA follow-up) booleans should be TINYINT As per the coding guidelines, they should be TINYINT(1). Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: Koha/Schema/Result/Suggestion.pm | 8 ++++---- installer/data/mysql/kohastructure.sql | 2 +- installer/data/mysql/updatedatabase.pl | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Apr 15 13:58:14 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 15 Apr 2020 11:58:14 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1775-g0f3c451c9d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 0f3c451c9dcb7597e9906a44a1c623a736cc7e5e (commit) via 3175067e2343b282b7df29b0e7b2fdd20c8fd806 (commit) via 88239d126c1bb0c6e08ca15619df2eb7762718ed (commit) via 806bee5a2e5f58235200f0201a9b9c21314f9c5f (commit) via 21e39818e42088ef316d7a29637094cd164c01b9 (commit) via 4b60a9f2bc54d52c01e8f942f751f395caacdeed (commit) via b0e930aad8d58f9f9be791e7a6dbe996986f8560 (commit) from c0f79717eeaca4b1ca703148ea7d61bb0311689c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0f3c451c9dcb7597e9906a44a1c623a736cc7e5e Author: Martin Renvoize Date: Wed Apr 15 12:30:12 2020 +0100 Bug 24380: DBRev 19.12.00.072 Signed-off-by: Martin Renvoize commit 3175067e2343b282b7df29b0e7b2fdd20c8fd806 Author: Jonathan Druart Date: Wed Apr 15 12:44:47 2020 +0200 Bug 24380: (QA follow-up) Simplify condition Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 88239d126c1bb0c6e08ca15619df2eb7762718ed Author: Jonathan Druart Date: Wed Apr 15 12:48:44 2020 +0200 Bug 24380: (QA follow-up) Do not use compare float with precision Forbidden pattern: Do not use compare float with precision (bug 24408). Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 806bee5a2e5f58235200f0201a9b9c21314f9c5f Author: Kyle M Hall Date: Wed Apr 8 10:39:28 2020 -0400 Bug 24380: Add syspref CalculateFinesOnBackdate Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 21e39818e42088ef316d7a29637094cd164c01b9 Author: Kyle M Hall Date: Wed Jan 8 15:27:31 2020 -0500 Bug 24380: Backdated returns do not update fines unless CalculateFinesOnReturn is enabled In Koha 18.11 backdating a return triggered a recalculation of the fine. This was removed in bug 14591, and I believe it was in error. The bug report itself has no justification for the change in behavior. Test Plan: 1) Disable CalculateFinesOnReturn 2) Backdate an overdue with fines, note the fine does not change 3) Apply this patch 4) Repeat step 2 5) The fine should be updated! Signed-off-by: Kelly McElligott Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 4b60a9f2bc54d52c01e8f942f751f395caacdeed Author: Kyle M Hall Date: Wed Jan 22 14:01:14 2020 -0500 Bug 24380: Unit Test Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit b0e930aad8d58f9f9be791e7a6dbe996986f8560 Author: Katrin Fischer Date: Sat Apr 11 13:40:39 2020 +0000 Bug 25120: Make accounting the default tab when opening the pref editor The default/active tab when opening the sys pref editor used to be 'Acquisitions' as the first tab, but should now be the new first 'Accounting' To test: - Go to Administration > System preferences - Verify the Aquisition tab is second and preselected - Apply patch - Repeat - Verify now Accounting is selected Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 10 ++++- Koha.pm | 2 +- admin/preferences.pl | 2 +- installer/data/mysql/sysprefs.sql | 1 + installer/data/mysql/updatedatabase.pl | 10 +++++ .../en/modules/admin/preferences/circulation.pref | 6 +++ t/db_dependent/Circulation/Returns.t | 43 +++++++++++++++++++++- 7 files changed, 70 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Apr 15 14:09:20 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 15 Apr 2020 12:09:20 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1779-g4da2a353b7 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 4da2a353b71f0d9ae9f508704dddb65fa493e457 (commit) via b87fdec6da2c3bee74180b5a8611645a718e1e5b (commit) via e83ed955fdd7c01b0be49ef78fdf1bdc7168efa2 (commit) via 24d1e78575ee9b5e80115bb608a3263794fa67a7 (commit) from 0f3c451c9dcb7597e9906a44a1c623a736cc7e5e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4da2a353b71f0d9ae9f508704dddb65fa493e457 Author: Martin Renvoize Date: Wed Apr 15 12:37:24 2020 +0100 Bug 25152: DBRev 19.12.00.073 Signed-off-by: Martin Renvoize commit b87fdec6da2c3bee74180b5a8611645a718e1e5b Author: Jonathan Druart Date: Wed Apr 15 11:29:21 2020 +0200 Bug 25152: Make subscription.closed tinyint(1) https://wiki.koha-community.org/wiki/Coding_Guidelines#SQL12:_Booleans Boolean fields must be tinyint(1), not int(1) Signed-off-by: Martin Renvoize commit e83ed955fdd7c01b0be49ef78fdf1bdc7168efa2 Author: Katrin Fischer Date: Mon Apr 13 04:32:56 2020 +0200 Bug 22468: Standardize on labelling ccode table columns as Collections We now display the descriptions everywhere, so we should drop the 'code' from labels. This changes text in a lot of playes in Koha, including: - The relatives checkouts table when displayed for the guarantor - The new order and order receive forms in acquisitoins (item creation) - The description of CCODE in the authorised values table - The column description on results in item search - The branch tranfers page - Course reserves: add reserve items (one and in batch) - Patron account > statistics tab Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 24d1e78575ee9b5e80115bb608a3263794fa67a7 Author: Katrin Fischer Date: Mon Apr 13 04:18:36 2020 +0200 Bug 24939: Fix capitalization of labels in sys pref editor The headings/labels of sections in the sys pref editor didn't follow Koha's capitalization rules. To test: - Go to Administration > System preferences - Check all tabs for the spelling of the headings Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- Koha/Schema/Result/Subscription.pm | 12 ++++++++---- installer/data/mysql/kohastructure.sql | 2 +- installer/data/mysql/updatedatabase.pl | 7 +++++++ .../prog/en/includes/relatives-issues-table.inc | 2 +- .../prog/en/modules/acqui/neworderempty.tt | 2 +- .../prog/en/modules/acqui/orderreceive.tt | 4 ++-- .../prog/en/modules/admin/authorised_values.tt | 2 +- .../prog/en/modules/admin/preferences/admin.pref | 2 +- .../en/modules/admin/preferences/cataloguing.pref | 4 ++-- .../en/modules/admin/preferences/circulation.pref | 20 ++++++++++---------- .../modules/admin/preferences/enhanced_content.pref | 4 ++-- .../prog/en/modules/admin/preferences/opac.pref | 6 +++--- .../prog/en/modules/admin/preferences/searching.pref | 6 +++--- .../prog/en/modules/catalogue/itemsearch.tt | 6 +++--- .../prog/en/modules/circ/branchtransfers.tt | 4 ++-- .../en/modules/course_reserves/add_items-step2.tt | 2 +- .../en/modules/course_reserves/batch_add_items.tt | 2 +- .../prog/en/modules/members/statistics.tt | 2 +- 19 files changed, 51 insertions(+), 40 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Apr 15 15:40:07 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 15 Apr 2020 13:40:07 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1781-g36cb0e6ae4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 36cb0e6ae423c1c3c7176d219bba953554ff08df (commit) via c6b6b0a42746bd19653216e607ed048846aaab5b (commit) from 4da2a353b71f0d9ae9f508704dddb65fa493e457 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 36cb0e6ae423c1c3c7176d219bba953554ff08df Author: Jonathan Druart Date: Wed Apr 15 15:04:16 2020 +0200 Bug 22887: Remove superfluous warn statements We print them in the description later Signed-off-by: Martin Renvoize commit c6b6b0a42746bd19653216e607ed048846aaab5b Author: Jonathan Druart Date: Wed Apr 15 15:03:15 2020 +0200 Bug 22887: Fix SQL syntax for MySQL 5.5 This does not happen on MySQL 8 or latest MariaDB, but does on MySQL 5.5 "Non-grouping field 'c' is used in HAVING clause" Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/updatedatabase.pl | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Apr 15 15:48:48 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 15 Apr 2020 13:48:48 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1782-g48188a1065 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 48188a1065b11a4e83e67d5b2e08c45552b80f1e (commit) from 36cb0e6ae423c1c3c7176d219bba953554ff08df (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 48188a1065b11a4e83e67d5b2e08c45552b80f1e Author: Jonathan Druart Date: Wed Apr 15 15:17:11 2020 +0200 Bug 24131: Prevent the first description to be displayed twice If there are several lines to display, the first one was displayed twice: Upgrade to 19.12.00.071 done [13:10:22]: Bug 22887 - Add unique constraint to authorised_values - Add unique constraint to authorised_values - WARNING - Cannot create unique constraint on authorised_value(category, authorised_value) - The following entries are duplicated: COUNTRY:aaa (2) Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/updatedatabase.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Apr 15 19:05:51 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 15 Apr 2020 17:05:51 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.04-144-g39395a410f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 39395a410fa026518398f800c070942f8193b5c7 (commit) from 5575d6799c9cf4927f62dd82478df7af5c04eab8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 39395a410fa026518398f800c070942f8193b5c7 Author: Joy Nelson Date: Wed Apr 15 16:38:47 2020 +0000 Bug 24627: Compiled CSS Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 2 +- koha-tmpl/opac-tmpl/bootstrap/css/print.css | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Apr 15 19:15:30 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 15 Apr 2020 17:15:30 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.04-147-g3b697742db Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 3b697742dbdecd4f9d1f7e1f7622263f4853acf9 (commit) via 44352f319e042c411feecffa1812fc8455de4e25 (commit) via 20654202733ebcec492805306a99b539e17bdbec (commit) from 39395a410fa026518398f800c070942f8193b5c7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3b697742dbdecd4f9d1f7e1f7622263f4853acf9 Author: Jonathan Druart Date: Tue Apr 7 15:37:13 2020 +0200 Bug 24901: Fix tests for 19.11.x Signed-off-by: Joy Nelson commit 44352f319e042c411feecffa1812fc8455de4e25 Author: Martin Renvoize Date: Thu Mar 19 08:10:00 2020 +0000 Bug 24901: Add tests for transferbook Test plan: 0/ Read the commit and confirm the new tests make sence 1/ Run the tests and verify they pass 2/ Signoff Signed-off-by: Nick Clemens Signed-off-by: Joy Nelson commit 20654202733ebcec492805306a99b539e17bdbec Author: Martin Renvoize Date: Wed Mar 18 19:25:57 2020 +0000 Bug 24901: Minor refactor of tests Test plan: 0/ Read the change and verify it makes sense Signed-off-by: Nick Clemens Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: t/db_dependent/Circulation/transferbook.t | 43 +++++++++++++++++-------------- 1 file changed, 24 insertions(+), 19 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Apr 15 19:27:08 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 15 Apr 2020 17:27:08 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.04-149-ge78d039ea7 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via e78d039ea7c063de720c79dd45e18bf6b2377e3c (commit) via ca3178fa3b1d52e31117cafad372d34c9ef0aa23 (commit) from 3b697742dbdecd4f9d1f7e1f7622263f4853acf9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e78d039ea7c063de720c79dd45e18bf6b2377e3c Author: Jonathan Druart Date: Tue Apr 7 15:38:37 2020 +0200 Bug 24705: Fix tests for 19.11.x Signed-off-by: Joy Nelson commit ca3178fa3b1d52e31117cafad372d34c9ef0aa23 Author: Jonathan Druart Date: Tue Apr 7 15:30:06 2020 +0200 Bug 24553: Fix tests for 19.11.x Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: t/db_dependent/SIP/ILS.t | 11 +++++------ t/db_dependent/SIP/Transaction.t | 11 +++++------ 2 files changed, 10 insertions(+), 12 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Apr 16 00:27:21 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 15 Apr 2020 22:27:21 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.15-22-g9cce44c5cb Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via 9cce44c5cb6a418e5e2af3b86176986415649735 (commit) from 91faeb16bb0059fc694d40fae7b97c8317c4789f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9cce44c5cb6a418e5e2af3b86176986415649735 Author: Bernardo Gonzalez Kriegel Date: Sat Mar 14 21:00:24 2020 -0300 Bug 24870: Translate installer data label This patch enable the translation of the labels 'Mandatory' or 'Optional' present at install time for groups of installer files. To test: 1) Try install using de-DE language, at step3 verify 'Mandatory' and 'Optional' labels for marc21 or other data checklist Do not close this window! 2) Apply this patch 3) Update de-DE translation files, reinstall lang files cd misc/translator ./translate update de-DE ./translate install de-DE 4) Reload page at step3, now 'Mandatory' label is translated to 'Pflichtfeld' 5) Verify strings in translation file Search for ^msgid \"Mandatory\" ^msgid \"Optional\" in po/de-DE-staff-prog.po. Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 1adc4986e9d2f715f44ef4b99b5dece79845f885) Signed-off-by: Lucas Gass (cherry picked from commit 42bc9671ca47272258cecde2abccdef521a58b56) Signed-off-by: Hayley Mapley ----------------------------------------------------------------------- Summary of changes: C4/Installer.pm | 4 ++-- koha-tmpl/intranet-tmpl/prog/en/modules/installer/step3.tt | 10 ++++++++-- 2 files changed, 10 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Apr 16 01:24:23 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 15 Apr 2020 23:24:23 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-90-g50719fa9a5 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 50719fa9a5ba168067fc9a9072490136203d9995 (commit) from 3f0eee42766b2ccd4b2ffea57af0d9fb2c057758 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 50719fa9a5ba168067fc9a9072490136203d9995 Author: Lucas Gass Date: Wed Apr 15 22:57:10 2020 +0000 Revert "Bug 24858: Correct labels on wording in ExcludeHolidaysFromMaxPickUpDelay" This reverts commit 1f80f34cee73197c13ffedb408fbe3c6c54d3758. Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/admin/preferences/circulation.pref | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Apr 16 03:26:51 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Apr 2020 01:26:51 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.15-23-g9c9478c5c5 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via 9c9478c5c564a1b00848a350ec2cdd250ca43ae6 (commit) from 9cce44c5cb6a418e5e2af3b86176986415649735 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9c9478c5c564a1b00848a350ec2cdd250ca43ae6 Author: Aleisha Amohia Date: Thu Feb 20 01:36:32 2020 +0000 Bug 24688: Check the priority of the fulfilled hold when fixing priorities Currently when fixing priorities of existing holds, priorities aren't fixed when checking out a middle priority hold because the hold has been fulfilled and deleted. This patch adds a check for, if the hold can't be found, an old hold with the required reserve_id. To test: 1. Place at least four holds on a biblio for different borrowers 2. Check out an item to the 3rd priority borrower 3. Check the existing holds table for the biblio. The priorities might be out of order, or try clicking the dropdowns and there might be an empty dropdown option, or open the browser developer tools and notice the option values in the select are missing value=3. 4. Apply patch and restart memcached 5. Check out an item to the 2nd priority borrower 6. Check the existing holds table for the biblio. Confirm the priorities have been fixed and are now consecutive with no gaps. Sponsored-by: Chartered Accountants Australia and New Zealand Signed-off-by: Emmi Takkinen Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit b17c16f9106eb159a1690da80a2a46b1f3a165ab) Signed-off-by: Lucas Gass (cherry picked from commit d29f435e2676e104ae84bac840924c48f54b5568) Signed-off-by: Hayley Mapley ----------------------------------------------------------------------- Summary of changes: C4/Reserves.pm | 4 ++++ 1 file changed, 4 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Apr 16 16:58:52 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Apr 2020 14:58:52 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-91-g3d394c4e64 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 3d394c4e6409271f19d57e889408b387caa614a3 (commit) from 50719fa9a5ba168067fc9a9072490136203d9995 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3d394c4e6409271f19d57e889408b387caa614a3 Author: Nick Clemens Date: Wed Apr 15 17:53:49 2020 +0000 Bug 25144: [19.05.x only] Remove subtitle from query Signed-off-by: Lucas Gass Signed-off-by: Jonathan Druart Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: cataloguing/value_builder/cn_browser.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Apr 16 20:48:44 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Apr 2020 18:48:44 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1786-g75f3cb5680 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 75f3cb5680693cfca0a0d9e57f52bfcc57ed7481 (commit) via be618ab400bc15e4c3804ffdbdbc3e8c3e659ba3 (commit) via 8992bb2e6f9b6eb5f9dbe96b28df62904f82bfba (commit) via 2633bed5c4f5e07db0e69719c4750f03e6151782 (commit) from 48188a1065b11a4e83e67d5b2e08c45552b80f1e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 75f3cb5680693cfca0a0d9e57f52bfcc57ed7481 Author: Tomas Cohen Arazi Date: Wed Apr 15 11:48:23 2020 -0300 Bug 25131: (QA follow-up) Move test for needs_install outside the plugin This follow-up patch moves the check outside the register routine. The Mojo plugin won't be loaded unless there's no need to install. As the original tests rely on V1.pm to be able to load the plugin, they are still valid, and they should still pass as there's no behaviour change. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit be618ab400bc15e4c3804ffdbdbc3e8c3e659ba3 Author: Tomas Cohen Arazi Date: Tue Apr 14 16:24:38 2020 -0300 Bug 25131: Skip loading API plugins if Koha is not installed This patch adds a check on Koha being actually installed to the PluginRoutes Mojolicious plugin. If Koha is not installed, plugin routes won't be tried to get installed. This has the effect of making the webinstaller functional again (when enable_plugins is set to 1). To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/REST/Plugin/PluginRoutes.t => FAIL: Tests fail! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Reset your working branch 6. Delete your database (e.g. in koha-testing-docker): $ mysql -hdb -ppassword > DROP DATABASE koha_kohadev; > CREATE DATABASE koha_kohadev; \q 7. Set enable_plugins to 1 in koha-conf.xml 8. Restart all: $ service memcached restart $ koha-plack --restart kohadev 9. Open the staff interface => FAIL: Hangs, the logs show nasty errors (koha-plack-err) 10. Apply this patches 11. Restart all 12. Repeat 10 => SUCCESS: The web installer shows up :-D 13. Sign off :-D Signed-off-by: David Nind Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit 8992bb2e6f9b6eb5f9dbe96b28df62904f82bfba Author: Tomas Cohen Arazi Date: Tue Apr 14 16:24:33 2020 -0300 Bug 25131: Regression tests Signed-off-by: David Nind Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit 2633bed5c4f5e07db0e69719c4750f03e6151782 Author: Tomas Cohen Arazi Date: Tue Apr 14 16:21:37 2020 -0300 Bug 25131: Add C4::Context->needs_install This trivial patch adds a new convenient way to ask if Koha is installed. It uses the same approach as C4::Auth:730 To test: 1. Apply this patch 2. Run: $ kshell k$ t/Context.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: David Nind Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Context.pm | 13 +++++++ Koha/REST/Plugin/PluginRoutes.pm | 7 ++-- Koha/REST/V1.pm | 4 +- t/Context.t | 15 +++++++- t/db_dependent/Koha/REST/Plugin/PluginRoutes.t | 52 +++++++++++++++++++++++++- 5 files changed, 84 insertions(+), 7 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Apr 16 20:55:10 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 16 Apr 2020 18:55:10 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1791-g8aa9f2cc07 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 8aa9f2cc078932a0a4db434f8bd793de29a8ff7b (commit) via 665c8328d11cb3ff83c9b48e25bc583757daaf7d (commit) via dbf604e141429fb32501bc13ed74919823d8c7ee (commit) via 429c57d8d6fd88053f2bff93465ab78f1ef82aa3 (commit) via a348fc18e414d3d68916ae863c18344233eafdc9 (commit) from 75f3cb5680693cfca0a0d9e57f52bfcc57ed7481 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8aa9f2cc078932a0a4db434f8bd793de29a8ff7b Author: David Roberts Date: Wed Apr 15 16:34:40 2020 +0000 Bug 25147: AllowSelfCheckReturns is in the wrong system preference section This patch moves the AllowSelfCheckReturns system preference to the "Self check-in module" section of the Circulation system preferences. To test: 1) Check that the AllowSelfCheckReturns system preference is currently in the "Self Checkout" section of the Circulation system preferences. 2) Apply the patch 3) The preference should now be in the "Self check-in module" section of the Circulation system preferences. Signed-off-by: Devinim Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 665c8328d11cb3ff83c9b48e25bc583757daaf7d Author: Jonathan Druart Date: Thu Apr 16 11:51:32 2020 +0200 Bug 25136: Join the 2 ifs Highlight that we only need this for action="new" Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit dbf604e141429fb32501bc13ed74919823d8c7ee Author: Lucas Gass Date: Wed Apr 15 22:46:23 2020 +0000 Bug 25136: Make PatronSelfRegistrationLibraryList only effect new registration This patch makes it so PatronSelfRegistrationLibraryList will only effect the registration from and not the modification form. TO TEST: 1. Turn on self reg and add some libaries to PatronSelfRegistrationLibraryList. 2. Notice that the libaries that display in the borrower_branchcode dropdown are the ones you selected on both the new registration from and the modification form. 3. Apply patch. 4. Now only the new registration from should show libaries on PatronSelfRegistrationLibraryList. 5. The modifciation dropdown should still show all libraries. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 429c57d8d6fd88053f2bff93465ab78f1ef82aa3 Author: Owen Leonard Date: Sat Mar 28 17:42:50 2020 +0000 Bug 25007: (follow-up) Fix the way image check alters layout A question in the bug report asks: Why is is necessary to change the Bootstrap class to col-xs-12? The JavaScript which checks for the existence of an Amazon cover image is designed to remove the Amazon cover's container if there is none. Changing the class of cover image column is gone. However, the check is incorrect because it doesn't account for Local Covers. There might be both a 1 x 1 pixel Amazon image and a local cover image, so the layout shouldn't be changed unless there are no images present. To test, apply the patch and view the bibliographic details page of various titles including: - Amazon cover present, no local cover - No Amazon cover, local cover image present - Both Amazon and local cover image Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit a348fc18e414d3d68916ae863c18344233eafdc9 Author: Lucas Gass Date: Fri Mar 27 20:40:30 2020 +0000 Bug 25007: Check for normaalized ISBN when building Amazon link TO RECREATE: -Have Amazon images turned on and local images too. -Have a record with a local cover image -Make sure the record has no ISBN in 020 field. -Load detail page of that record and see that the local cover images is not on the right hand side like it should be but forced underneath 'catalogue_detail_biblio' in an odd spot. -Apply patch and reload page -The image should be back in its normal spot Signed-off-by: David Nind Signed-off-by: Owen Leonard Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/admin/preferences/circulation.pref | 12 ++++++------ koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 9 +++++---- opac/opac-memberentry.pl | 4 +++- 3 files changed, 14 insertions(+), 11 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 17 09:52:14 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 17 Apr 2020 07:52:14 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1796-gedee0266c4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via edee0266c477c627d9be5f86d09182c042d2607c (commit) via aa1d792a149a59473e3ddcb7d9b471b8e07e1a79 (commit) via 7fb2524a9a144e96cf0b57a3f8cf4a13a917ad67 (commit) via 67c7b281aea90bdda7bd15e1d2fdd657caefac74 (commit) via 4e9a8b6413a0ce64e5757842a61ed122d8fe8d15 (commit) from 8aa9f2cc078932a0a4db434f8bd793de29a8ff7b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit edee0266c477c627d9be5f86d09182c042d2607c Author: Martin Renvoize Date: Fri Apr 17 08:24:57 2020 +0100 Bug 25147: DBRev 19.12.00.074 Signed-off-by: Martin Renvoize commit aa1d792a149a59473e3ddcb7d9b471b8e07e1a79 Author: Martin Renvoize Date: Fri Apr 17 08:18:44 2020 +0100 Bug 25147: Clarify section name Clarify the preference section headings for Self-checkout and Self-checkin. Signed-off-by: Martin Renvoize commit 7fb2524a9a144e96cf0b57a3f8cf4a13a917ad67 Author: Martin Renvoize Date: Fri Apr 17 08:16:10 2020 +0100 Bug 25147: Rename preference This patch renames the preference from the ambiguous 'AllowSelfCheckReturns' to 'SCOAllowCheckin' which is more consistent with other preferences affecting this module. Signed-off-by: Martin Renvoize commit 67c7b281aea90bdda7bd15e1d2fdd657caefac74 Author: Martin Renvoize Date: Fri Apr 17 07:55:09 2020 +0100 Bug 25152: (RM follow-up) Correction to update description Signed-off-by: Martin Renvoize commit 4e9a8b6413a0ce64e5757842a61ed122d8fe8d15 Author: Martin Renvoize Date: Fri Apr 17 07:51:16 2020 +0100 Bug 25147: AllowSelfCheckReturns is in the wrong system preference section This reverts commit 8aa9f2cc078932a0a4db434f8bd793de29a8ff7b. I agree with the following comment and as such have reverted the patch. Quoting Phil Ringnalda : Everything currently in the chunk labelled "Self Checkout" is preferences used to control sco-main.pl, a feature that does checkout and renewal, and optionally with the preference AllSelfCheckReturns, also checkin. Everything currently in the chunk labelled "Self check-in module" is preferences used to control sci-main.pl, a separate feature that does only checkin, and does checkin whether or not AllowSelfCheckReturns is set. I'd think a better solution would be to either rename the preference, which is actually AllowReturnsInSelfCheckout, or rename the chunks to make it more clear that they are preferences for two different features. Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/sysprefs.sql | 2 +- installer/data/mysql/updatedatabase.pl | 10 +++++++++- .../prog/en/modules/admin/preferences/circulation.pref | 16 ++++++++-------- 4 files changed, 19 insertions(+), 11 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 17 09:58:20 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 17 Apr 2020 07:58:20 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1797-ged79b1709a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via ed79b1709a846d3f084590586c49e04aeac4896f (commit) from edee0266c477c627d9be5f86d09182c042d2607c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ed79b1709a846d3f084590586c49e04aeac4896f Author: Martin Renvoize Date: Fri Apr 17 08:30:40 2020 +0100 Bug 25147: (RM follow-up) Update display I missed the display change in the preference name change.. oops. Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 17 10:30:48 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 17 Apr 2020 08:30:48 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1798-g081a4c75be Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 081a4c75be2431e1a6fc470a5b8834fa866e2453 (commit) from ed79b1709a846d3f084590586c49e04aeac4896f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 081a4c75be2431e1a6fc470a5b8834fa866e2453 Author: Martin Renvoize Date: Fri Apr 17 09:02:58 2020 +0100 Bug 25147: (RM follow-up) Update pref references. Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/UsageStats.pm | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt | 8 ++++---- opac/sco/sco-main.pl | 6 +++--- t/db_dependent/UsageStats.t | 2 +- 4 files changed, 9 insertions(+), 9 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 17 10:47:33 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 17 Apr 2020 08:47:33 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1802-gf300af96a7 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via f300af96a7fd1ad96f8dfd132882bafcec8a8426 (commit) via 52339bcef0d735b39a9ca9c198dd3d54d092fba7 (commit) via 2d5d9a54bd9b8927b82066b35dcaec20cad764ea (commit) via 039afd0936871670598b8b7f24dc5a9be93dd240 (commit) from 081a4c75be2431e1a6fc470a5b8834fa866e2453 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f300af96a7fd1ad96f8dfd132882bafcec8a8426 Author: Katrin Fischer Date: Fri Mar 27 23:48:56 2020 +0100 Bug 25011: Improve display of MARC21 508 - Production credits in staff and OPAC Makes some tiny changes to improve display and consistency between OPAC and staff: - Capitalization fix: Production Credits - Production credits - Changes div to span avoiding display issues - Make sequence of fields in display match (505, 508, 586) To test: - Catalog one or more records with none, one and multiple 508 $a - Check and compare the staff and OPAC detail pages, both should display the production credits information correctly Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit 52339bcef0d735b39a9ca9c198dd3d54d092fba7 Author: Kyle M Hall Date: Tue Jan 30 11:10:07 2018 -0500 Bug 20101: Cronjob automatic_item_modification_by_age.pl does not log run in action logs C4::Log::cronlogaction() was never implemented in automatic_item_modification_by_age.pl. Test Plan: 1) Apply this patch 2) Enable CronjobLog 3) Run automatic_item_modification_by_age.pl succesfully 4) Note the run is noted in the action logs Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit 2d5d9a54bd9b8927b82066b35dcaec20cad764ea Author: Martin Renvoize Date: Fri Apr 17 09:13:13 2020 +0100 Bug 25086: DBRev 19.12.00.075 Signed-off-by: Martin Renvoize commit 039afd0936871670598b8b7f24dc5a9be93dd240 Author: Agustin Moyano Date: Wed Apr 8 16:53:43 2020 -0300 Bug 25086: Set changed_fields column as nullable This patch changed_fields column as nullable. To test: 1. Do not apply any patch 2. Set PatronSelfRegistrationVerifyByEmail preference to require 3. Fill self registration form in opac and submit CHECK => OPAC dies with a nasty message, that says Field 'changed_fields' doesn't have a default value 4. Apply this patch and updatedatabase 5. Repeat step 3 SUCCESS => Registry process continues as expected 6. Sign off Sponsored-by: Orex Digital Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- Koha/Schema/Result/BorrowerModification.pm | 8 +++---- installer/data/mysql/kohastructure.sql | 2 +- installer/data/mysql/updatedatabase.pl | 8 +++++++ .../prog/en/xslt/MARC21slim2intranetDetail.xsl | 26 +++++++++++----------- .../bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 22 +++++++++--------- .../cronjobs/automatic_item_modification_by_age.pl | 3 +++ 7 files changed, 41 insertions(+), 30 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 17 10:56:40 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 17 Apr 2020 08:56:40 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1807-g2484fb6ac5 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 2484fb6ac508e7709de9473694512ce09b12aff9 (commit) via 1be518588b69db80b43ef21c442f2bf8e74f044a (commit) via 7426cb6432ce35434335f08b7d391ef83acd3705 (commit) via 4de218561460290cc5807c6770bafa597a416cce (commit) via d7efe9ffbbff7dc641f4840bd01b1a969b6d5c4f (commit) from f300af96a7fd1ad96f8dfd132882bafcec8a8426 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2484fb6ac508e7709de9473694512ce09b12aff9 Author: Owen Leonard Date: Sun Mar 29 00:19:39 2020 +0000 Bug 25016: Coce should not return a 1-pixel Amazon cover image This patch adds an onload function to the JavaScript which loads images from Coce. In the case where the image is 1 x 1 pixel the image should be removed. To test you should have Coce enabled and Amazon.com included in the list of sources. - Apply the patch and view the bibliographic details page under a variety of conditions: - A title which has a matching Amazon image: - The image should load as expected. - A title which doesn't have a matching Amazon image - The image should not be found in the source at all after the page has loaded. - Test with local cover images enabled Signed-off-by: Lucas Gass Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 1be518588b69db80b43ef21c442f2bf8e74f044a Author: Marcel de Rooy Date: Mon Feb 24 12:52:13 2020 +0000 Bug 24715: Cache repeatable subfield in TransformKohaToMarc Implemented by calling GetMarcSubfieldStructure and improving _check_split which may check repeatability in a specific framework, and return the framework hash. Test plan: Run t/db_dependent/Biblio/TransformKohaToMarc.t Optionally, follow the test plan of bug 21800#comment7. Signed-off-by: Marcel de Rooy Signed-off-by: Ere Maijala Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 7426cb6432ce35434335f08b7d391ef83acd3705 Author: Jonathan Druart Date: Wed Jan 31 14:51:22 2018 -0300 Bug 20116: Cache language list Signed-off-by: Liz Rea Signed-off-by: Bouzid Fergani Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit 4de218561460290cc5807c6770bafa597a416cce Author: Jonathan Druart Date: Wed May 16 17:26:09 2018 -0300 Bug 20116: Flush the caches When languages are added or removed when need to flush the caches to keep the interface consistent Signed-off-by: Liz Rea Signed-off-by: Bouzid Fergani Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit d7efe9ffbbff7dc641f4840bd01b1a969b6d5c4f Author: Jonathan Druart Date: Wed Jan 31 14:36:22 2018 -0300 Bug 20116: Prepare the ground Just refactoring to make the next patch more readable Signed-off-by: Liz Rea Signed-off-by: Bouzid Fergani Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Biblio.pm | 12 +++- C4/Languages.pm | 85 +++++++++++++++++++---------- debian/scripts/koha-translate | 17 +++++- koha-tmpl/intranet-tmpl/js/coce.js | 8 ++- misc/bin/clear_cache.pl | 9 +++ misc/translator/translate | 4 ++ t/db_dependent/Biblio/TransformKohaToMarc.t | 6 +- 7 files changed, 105 insertions(+), 36 deletions(-) create mode 100755 misc/bin/clear_cache.pl hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 17 11:52:24 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 17 Apr 2020 09:52:24 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1813-g2b7ac72d70 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 2b7ac72d7086c66d14b9d08337eecea94c4d8929 (commit) via 0e9d45e7b4cb2e6a6d6b9559671b5d91c0e6fab4 (commit) via 7d09c46cf7e049f1e32c6bb57f49c46288d486f5 (commit) via cd5be730420ebed9d66a4feaae19df79a4c3559d (commit) via 021598e8a4043433a8d435298dd584ac8127aacc (commit) via 9287585f3823b9375d5bdbbc7128e0141dafb4f6 (commit) from 2484fb6ac508e7709de9473694512ce09b12aff9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2b7ac72d7086c66d14b9d08337eecea94c4d8929 Author: Martin Renvoize Date: Fri Apr 17 10:20:27 2020 +0100 Bug 22887: (RM follow-up) Restore warnings in updatedatabase Signed-off-by: Martin Renvoize commit 0e9d45e7b4cb2e6a6d6b9559671b5d91c0e6fab4 Author: Martin Renvoize Date: Fri Apr 17 10:17:32 2020 +0100 Bug 21901: DBRev 19.12.00.076 Signed-off-by: Martin Renvoize commit 7d09c46cf7e049f1e32c6bb57f49c46288d486f5 Author: Marcel de Rooy Date: Fri Apr 17 08:04:14 2020 +0000 Bug 21901: (QA follow-up) Add a few NOT NULL constraints in dbrev We need to specify NOT NULL on subscription and -history as well. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit cd5be730420ebed9d66a4feaae19df79a4c3559d Author: Jonathan Druart Date: Mon Mar 9 15:25:29 2020 +0100 Bug 21901: Add a warning if we removed entries Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit 021598e8a4043433a8d435298dd584ac8127aacc Author: Martin Renvoize Date: Fri Jan 31 13:21:41 2020 +0000 Bug 21901: (QA follow-up) Ensure consistent data before adding keys Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit 9287585f3823b9375d5bdbbc7128e0141dafb4f6 Author: Jonathan Druart Date: Wed Dec 11 08:29:27 2019 +0100 Bug 21901: Add FK on subscription and serial tables In order to improve performance in the serial modules and add DB constraints, this patch is going to add missing foreign key on the following columns: * serial.biblionumber * serial.subscription * subscriptionhistory.biblionumber * subscriptionhistory.subscriptionid * subscription.biblionumber Once done, some code can be removed from the Del* subroutines, as the ON CASCASE clause will make the RDBMS handles the deletions. Test plan: 0/ It would be useful to test the update DB entry on a big and old production DB, to make sure the constraints will be added correctly. We could remove the entries before creating the constraints, but it can be unecessary 1/ Make sure you can recreate a fresh install with the kohastructure.sql from this patch 2/ Make sure you can upgrade from a master install 3/ Create a subscription, serial, etc. and delete the biblio => The subscription/serials should have been deleted from the DB 4/ Create a subscription, serial, etc. and delete the subscription => The serials should have been deleted from the DB Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Biblio.pm | 7 -- C4/Serials.pm | 2 - Koha.pm | 2 +- Koha/Schema/Result/Biblio.pm | 49 ++++++++++- Koha/Schema/Result/Serial.pm | 48 ++++++++--- Koha/Schema/Result/Subscription.pm | 53 +++++++++++- Koha/Schema/Result/Subscriptionhistory.pm | 44 ++++++++-- installer/data/mysql/kohastructure.sql | 63 +++++++------- installer/data/mysql/updatedatabase.pl | 132 ++++++++++++++++++++++++++++++ t/db_dependent/Biblio.t | 34 +++++++- 10 files changed, 371 insertions(+), 63 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 17 11:54:36 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 17 Apr 2020 09:54:36 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1814-ga1437dae8d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via a1437dae8d175e4d6fe15ea10cfb5b6923f76c08 (commit) from 2b7ac72d7086c66d14b9d08337eecea94c4d8929 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a1437dae8d175e4d6fe15ea10cfb5b6923f76c08 Author: Jonathan Druart Date: Fri Apr 17 10:42:21 2020 +0200 Bug 23463: Remove double store call Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Items.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 17 15:04:57 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 17 Apr 2020 13:04:57 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1815-g96bc0afee2 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 96bc0afee25f16953279c4c91f21c9cf2fc62f4b (commit) from a1437dae8d175e4d6fe15ea10cfb5b6923f76c08 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 96bc0afee25f16953279c4c91f21c9cf2fc62f4b Author: Martin Renvoize Date: Fri Apr 17 13:36:39 2020 +0100 Bug 21901: (RM follow-up) Use TestBuilder to fix tests A few tests failed due to missing values for foreign key relationships. Switching to TestBuilder for data mocking resolves this elegantly. Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: t/db_dependent/Letters/TemplateToolkit.t | 61 ++++++++++++++++---------------- t/db_dependent/Serials.t | 55 ++++++++++++++++++++++------ 2 files changed, 74 insertions(+), 42 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 17 15:18:37 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 17 Apr 2020 13:18:37 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1825-geed7aa216c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via eed7aa216c2096f2ac329d143b7ccbcb2c81139c (commit) via 54630c842e800efefd95a4facf9907cd29a5b9cb (commit) via ca452f07d5a04eb0159b35b3dc97173241a78f82 (commit) via 66135bc4c5e805b6b525a5dacbb208f696ee6b39 (commit) via 9a65730c0fdae9c1c866a5e4b6471fc3bb6754c6 (commit) via 8e4bf7608e233a7e6284b39262a77b23867b6f67 (commit) via 7d15ff34043aeb2a812a1139aba084cf4c1bc136 (commit) via 6229b51d663b868532102e60a4517ae2d4fb44cd (commit) via 27716ceef8b5b97405bb4807eac2b58fe3d5e11b (commit) via e08eae728ce36b0ee6913501fd44a4a3b5ae976b (commit) from 96bc0afee25f16953279c4c91f21c9cf2fc62f4b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit eed7aa216c2096f2ac329d143b7ccbcb2c81139c Author: Katrin Fischer Date: Sat Apr 11 10:36:36 2020 +0000 Bug 24768: Add 'Return claims' to column configuration for checkouts tables The checkouts tables on the checkouts and details tabs in the staff patron account support column confiugration, but the new column "Return claims" was missing. This patch adds the column to the column configuration. To test: - Make sure to test with a patron having return claims and without - Verify cou can toggle the visibility of the return claims column from top of the tables in the checkouts and details tabs - Go to administrastion > column configuration - Change the settings for the issues tables in the Patrons and Circulation sections - Verify the changes have been applied to the tables as configured Signed-off-by: David Roberts Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit 54630c842e800efefd95a4facf9907cd29a5b9cb Author: Devinim Date: Thu Apr 16 11:09:54 2020 +0000 Bug 25138: (follow-up) Terminology: Point of sale should use library instead of branch Signed-off-by: Devinim Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit ca452f07d5a04eb0159b35b3dc97173241a78f82 Author: Katrin Fischer Date: Sun Apr 12 02:25:48 2020 +0000 Bug 25138: Terminology: Point of sale should use library instead of branch This fixes the navigation on the Point of sale page: Branch details => Library details And the heading and the 'no register defined for this branch/library' message on the page it links to. To test: - Activate cash registers and point of sales features - Go to the point of sales page - Verify text on the menu to the left - Click on the Branch/library details - verify text and heading Signed-off-by: Devinim Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit 66135bc4c5e805b6b525a5dacbb208f696ee6b39 Author: Martin Renvoize Date: Fri Apr 17 13:48:47 2020 +0100 Bug 23727: DBRev 19.12.00.077 Signed-off-by: Martin Renvoize commit 9a65730c0fdae9c1c866a5e4b6471fc3bb6754c6 Author: Martin Renvoize Date: Thu Feb 20 17:15:57 2020 +0000 Bug 23727: (QA follow-up) Fix for boolean flags Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit 8e4bf7608e233a7e6284b39262a77b23867b6f67 Author: Martin Renvoize Date: Thu Feb 20 17:10:49 2020 +0000 Bug 23727: (QA follow-up) Fix script tags Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit 7d15ff34043aeb2a812a1139aba084cf4c1bc136 Author: Kyle M Hall Date: Fri Feb 14 15:22:17 2020 -0500 Bug 23727: Editing course reserve items is broken Adding an item to course reserves and trying to edit any values in a second step does not work. Values are not saved and the table shows all values as "Unchanged". This patch set adds two new sets of columns to the course_items table. The first set determines if the specified column should be swapped or not. The was previously 'implied' by the column being set to undef which has been the root problem with that way of knowing if a column should swap or not. The second set of new columns are for storing the item field values while the item is on course reserve. Previously, the column values were swapped between the items table and the course_items table, which leaves ambiguity as to what each value is. Now, the original columns *always* store the value when the item is on course reserve, and the new storage columns store the original item value while the item is on reserve, and are NULL when an item is *not* on reserve. Test Plan: 1) Apply this patch 2) Add and edit course items, not the new checkboxes for enabling fields 3) Everything should function as before Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit 6229b51d663b868532102e60a4517ae2d4fb44cd Author: Kyle M Hall Date: Fri Feb 14 08:57:05 2020 -0500 Bug 23727: Add Koha Object(s) related to course reserves Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit 27716ceef8b5b97405bb4807eac2b58fe3d5e11b Author: Kyle M Hall Date: Fri Feb 14 08:45:11 2020 -0500 Bug 23727: Update Schema Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit e08eae728ce36b0ee6913501fd44a4a3b5ae976b Author: Kyle M Hall Date: Fri Feb 14 08:41:28 2020 -0500 Bug 23727: Add new columns Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/CourseReserves.pm | 181 +++++++++++---------- Koha.pm | 2 +- Koha/{Desk.pm => Course.pm} | 17 +- Koha/{Desk.pm => Course/Instructor.pm} | 17 +- Koha/{Desks.pm => Course/Instructors.pm} | 22 +-- .../V1/CirculationRules.pm => Course/Item.pm} | 57 +++++-- Koha/{Desks.pm => Course/Items.pm} | 22 +-- Koha/{Desk.pm => Course/Reserve.pm} | 17 +- Koha/{Desks.pm => Course/Reserves.pm} | 22 +-- Koha/{Desks.pm => Courses.pm} | 22 +-- Koha/Schema/Result/CourseItem.pm | 74 ++++++++- admin/columns_settings.yml | 5 + course_reserves/add_items.pl | 32 +++- course_reserves/batch_add_items.pl | 19 ++- installer/data/mysql/kohastructure.sql | 8 + installer/data/mysql/updatedatabase.pl | 69 ++++++++ .../intranet-tmpl/prog/en/includes/pos-menu.inc | 2 +- .../en/modules/course_reserves/add_items-step2.tt | 89 ++++++++-- .../en/modules/course_reserves/batch_add_items.tt | 39 ++++- .../en/modules/course_reserves/course-details.tt | 24 ++- .../intranet-tmpl/prog/en/modules/pos/register.tt | 2 +- .../intranet-tmpl/prog/en/modules/pos/registers.tt | 4 +- t/db_dependent/CourseReserves/CourseItems.t | 101 +++++++----- 23 files changed, 576 insertions(+), 271 deletions(-) copy Koha/{Desk.pm => Course.pm} (74%) copy Koha/{Desk.pm => Course/Instructor.pm} (70%) copy Koha/{Desks.pm => Course/Instructors.pm} (67%) copy Koha/{REST/V1/CirculationRules.pm => Course/Item.pm} (53%) copy Koha/{Desks.pm => Course/Items.pm} (69%) copy Koha/{Desk.pm => Course/Reserve.pm} (71%) copy Koha/{Desks.pm => Course/Reserves.pm} (68%) copy Koha/{Desks.pm => Courses.pm} (71%) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 17 17:33:06 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 17 Apr 2020 15:33:06 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1826-g4b290b9833 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 4b290b9833293d4e56e2e4597e9645e331bc1ee1 (commit) from eed7aa216c2096f2ac329d143b7ccbcb2c81139c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4b290b9833293d4e56e2e4597e9645e331bc1ee1 Author: Martin Renvoize Date: Fri Apr 17 16:05:43 2020 +0100 Bug 24768: (RM follow-up) Add missing koha_object_class's Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: Koha/Schema/Result/CourseInstructor.pm | 7 ++++++- Koha/Schema/Result/CourseItem.pm | 8 +++++++- Koha/Schema/Result/CourseReserve.pm | 7 ++++++- 3 files changed, 19 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 17 21:12:42 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 17 Apr 2020 19:12:42 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.04-152-g5613ca4165 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 5613ca4165c64b40e80a772997b3180755b7e437 (commit) via eff216747b8faa05b825edb899f588db93a7cc02 (commit) via e072ccfda73f33a426a109fe0ace3c941495990b (commit) from e78d039ea7c063de720c79dd45e18bf6b2377e3c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5613ca4165c64b40e80a772997b3180755b7e437 Author: Jonathan Druart Date: Thu Jan 23 10:47:17 2020 +0100 Bug 24487: Add 2 more tests And make sure tests pass if there is no patron with borrowernumber=10 in DB. Signed-off-by: Tomas Cohen Arazi Ammended test description Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Joy Nelson commit eff216747b8faa05b825edb899f588db93a7cc02 Author: Agustin Moyano Date: Thu Jan 23 01:50:29 2020 -0300 Bug 24487: Don't apply matching criteria to path parameters This patch separates query parameters from path parameters, and uses exact matching for the later. To test: 1. Apply this patch 2. prove t/Koha/REST/Plugin/Query.t t/db_dependent/Koha/REST/Plugin/Objects.t SUCCESS => tests ok 3. Sign off Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Joy Nelson commit e072ccfda73f33a426a109fe0ace3c941495990b Author: Agustin Moyano Date: Wed Jan 22 20:44:04 2020 -0300 Bug 24487: Regresion test This patch introduces a regresion test where a path parameter is combined with 'contains' match criteria To test: 1. apply this patch 2. prove t/db_dependent/Koha/REST/Plugin/Objects.t Test should fail at this point. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: Koha/REST/Plugin/Objects.pm | 12 +++++- Koha/REST/Plugin/Query.pm | 9 ++++- t/Koha/REST/Plugin/Query.t | 37 ++++++++---------- t/db_dependent/Koha/REST/Plugin/Objects.t | 62 +++++++++++++++++++++++++++---- 4 files changed, 89 insertions(+), 31 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Apr 17 21:37:22 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 17 Apr 2020 19:37:22 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.04-154-g3401e94d94 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 3401e94d942a8d8a4e216ea44bd295f96b8f3e24 (commit) via d3ba9dc0fe423347f0e0e90b66be3ebeb7a6dec1 (commit) from 5613ca4165c64b40e80a772997b3180755b7e437 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3401e94d942a8d8a4e216ea44bd295f96b8f3e24 Author: Marcel de Rooy Date: Thu Jul 14 13:51:21 2016 +0200 Bug 16922: Add RewriteRule to apache-shared-intranet for dev package installs As a simple alternative to the solution in bug 9949 or just as an additional measure, this patch adds a rewrite rule for intranet in order to intercept potential misuse of perl scripts that could be reached on a dev package install via the cgi-bin/koha scriptalias. It simply rewrites them to the nonexistent "notfound", resulting in a regular 404 error. The rewrite rule does not harm regular installs and is just a little extra step in securing a dev install. You should have more security measures in place to secure your staff client. QA Note: Although a rewrite rule may not be our first choice, this one rule is more elegant and easier to maintain than e.g. a whole bunch of aliases. Note: This patch should have a regular and a dev install signoff. Test plan: [1] Make sure that this rewrite rule is inserted in your actual apache config via /etc/koha/apache-shared-intranet.conf. Restart Apache. [2] For regular package installs: Try one of the URLs in step 3. Verify that your staff client still operates as usual. Test a few URLs inside some modules. [3] For dev installs: Try some URLs like below. Expect 404 errors only, not 500s. If you do not see a 404, go back! /misc/stage_file.pl /t/db_dependent/default_search_class.pl /installer/data/mysql/updatedatabase.pl /Makefile.PL [4] Do you see an additional directory to add to the regex? Please report. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Joy Nelson commit d3ba9dc0fe423347f0e0e90b66be3ebeb7a6dec1 Author: Tomas Cohen Arazi Date: Fri Mar 27 18:16:58 2020 -0300 Bug 25009: Avoid leakages in opac-showmarc.pl This patch cleans opac-showmarc.pl so it doesn't allow retrieving records from import batches without requiring any permissions in the OPAC. it does so by just removing the code portion that does that. It also cleans the record fetch operation and how the record processor is initialized to it actually works :-D To test: 1. Perform a successful Z39.50 search in cataloguing (this fetches 20 records usually) 2. Query your DB for a valid import_record_id: $ koha-mysql kohadev > SELECT * FROM import_records LIMIT 1; 3. Notice some of the MARCXML details (title, author, etc), and the import_record_id 4. Point your browser to the opac-showmarc.pl URL like this: http://kohadev.mydnsname.org:8080/cgi-bin/koha/opac-showmarc.pl?importid=20 => FAIL: You get the record! (Bonus: no field/subfield takes place) 5. Hide some obvious subfield on the framework for a known (to you) biblionumber 6. Point your browser to: http://kohadev.mydnsname.org:8080/cgi-bin/koha/opac-showmarc.pl?id= => FAIL: No filtering takes place 7. Apply this patch 8. Repeat 4 => SUCCESS: You get an error because you did a bad request (no id param) 9. Repeat 6 => SUCCESS: Subfield filtering actually works! 10. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: debian/templates/apache-shared-intranet.conf | 3 ++ opac/opac-showmarc.pl | 41 +++++++++++++++++----------- 2 files changed, 28 insertions(+), 16 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 20 01:40:25 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sun, 19 Apr 2020 23:40:25 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.15-24-gc468e3f7d4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via c468e3f7d47e0bd17629609453444f0d76f93119 (commit) from 9c9478c5c564a1b00848a350ec2cdd250ca43ae6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c468e3f7d47e0bd17629609453444f0d76f93119 Author: Liz Rea Date: Fri Jan 3 21:18:27 2020 +0000 Bug 24324: Resolve error with delete_records_via_leader.pl To test: Have a record with the 000 position 5 set to "deleted" (record status) Use koha-shell to run the job with the -i flag: perl misc/cronjobs/delete_records_via_leader.pl -c -i -v * items and the record should be deleted Mark another record with the 000 position 5 set to deleted (record status) Use koha-shell to run the job without the -i flag: perl misc/cronjobs/delete_records_via_leader.pl -c -v * if the record had items, it will not be deleted * if the record did not have items, it will be deleted. Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit b713241845e8f730b46c756fa65c4ddd17ed746b) Signed-off-by: Hayley Mapley ----------------------------------------------------------------------- Summary of changes: misc/cronjobs/delete_records_via_leader.pl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 20 03:45:17 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 20 Apr 2020 01:45:17 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.15-25-g3b8c2467e5 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via 3b8c2467e5bde0311f520e286832a52ad0b4a17e (commit) from c468e3f7d47e0bd17629609453444f0d76f93119 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3b8c2467e5bde0311f520e286832a52ad0b4a17e Author: Marcel de Rooy Date: Thu Jul 14 13:51:21 2016 +0200 Bug 16922: Add RewriteRule to apache-shared-intranet for dev package installs As a simple alternative to the solution in bug 9949 or just as an additional measure, this patch adds a rewrite rule for intranet in order to intercept potential misuse of perl scripts that could be reached on a dev package install via the cgi-bin/koha scriptalias. It simply rewrites them to the nonexistent "notfound", resulting in a regular 404 error. The rewrite rule does not harm regular installs and is just a little extra step in securing a dev install. You should have more security measures in place to secure your staff client. QA Note: Although a rewrite rule may not be our first choice, this one rule is more elegant and easier to maintain than e.g. a whole bunch of aliases. Note: This patch should have a regular and a dev install signoff. Test plan: [1] Make sure that this rewrite rule is inserted in your actual apache config via /etc/koha/apache-shared-intranet.conf. Restart Apache. [2] For regular package installs: Try one of the URLs in step 3. Verify that your staff client still operates as usual. Test a few URLs inside some modules. [3] For dev installs: Try some URLs like below. Expect 404 errors only, not 500s. If you do not see a 404, go back! /misc/stage_file.pl /t/db_dependent/default_search_class.pl /installer/data/mysql/updatedatabase.pl /Makefile.PL [4] Do you see an additional directory to add to the regex? Please report. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Joy Nelson (cherry picked from commit 3401e94d942a8d8a4e216ea44bd295f96b8f3e24) Signed-off-by: Hayley Mapley ----------------------------------------------------------------------- Summary of changes: debian/templates/apache-shared-intranet.conf | 3 +++ 1 file changed, 3 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 20 13:45:16 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 20 Apr 2020 11:45:16 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1828-g510ee153c0 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 510ee153c0d0d0bc01ca1abc3cd6aa28a4d0f9ff (commit) via 8758cffcd2b3573561eda9d28ce45bb920a6978d (commit) from 4b290b9833293d4e56e2e4597e9645e331bc1ee1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 510ee153c0d0d0bc01ca1abc3cd6aa28a4d0f9ff Author: Martin Renvoize Date: Mon Apr 20 12:17:44 2020 +0100 Bug 25176: Compiled CSS Signed-off-by: Martin Renvoize commit 8758cffcd2b3573561eda9d28ce45bb920a6978d Author: Owen Leonard Date: Fri Apr 17 11:40:36 2020 +0000 Bug 25176: Fix style of checkout form This patch makes a small CSS change in order to fix a display problem with the checkout form where the form's width doesn't match that of the "last checked out" message. To test, apply the patch and regenerate the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Check an item out to a patron. Confirm that the green-bordered "Checked out" message under the checkout form matches the width of the form. Signed-off-by: David Roberts Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss | 1 + koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 20 13:54:58 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 20 Apr 2020 11:54:58 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1833-gc54654c129 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via c54654c12944250ed75bbdd011e6ac6cacf58d3f (commit) via 3ba823db6ea9c77e74dcdaa4d3a88f424ea7695d (commit) via 8218653df75cc61676ce40f2feea70bb5671614b (commit) via 563120a004f03a96c935b179af36cace874f708c (commit) via d8dd31142c0bfd9b09f9fa8e02fc292cf9deed2c (commit) from 510ee153c0d0d0bc01ca1abc3cd6aa28a4d0f9ff (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c54654c12944250ed75bbdd011e6ac6cacf58d3f Author: Katrin Fischer Date: Mon Apr 13 21:45:22 2020 +0000 Bug 13557: Add hint for on-site checkouts to list of current checkouts in OPAC In the list of checkouts it's currently not possible for the patront or tell the difference between normal checkouts (item is at home with them) and on-site checouts (items remained at the library). This patch adds a hint to the list of checkouts to allow differentiating these kinds of checkouts. To test: - In your patron account, have multiple checkouts, some on-site, some others, overdue items, etc. - Go to: OPAC > your summary > Checked out - Verify that there is no hint for the on-site checkouts - Apply patch - Check again, there should now be a note The note also has a class, so would be easy to be hidden or formatted differently: class="onsite_checkout". Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 3ba823db6ea9c77e74dcdaa4d3a88f424ea7695d Author: Katrin Fischer Date: Tue Apr 14 13:14:37 2020 +0000 Bug 21211: Add patron toolbar to suggestions, discharges and ill requests tabs When paging through the patron account in staff, using the tabs on the right, you notice that some pages are missing the patron toolbar on top and that the headings, where they exist, vary in size. This patch adds the patron toolbar to 3 more tabs and changes headings to h1 to be consistent with older tabs. It has also been suggested on another tab that this is preferrable for screen readers. Note: Modification log was left out for now, as this is also used in tools. To test: - Activate ILL (ILLModule pref) - Activate discharges (UseDischarge pref) - Go to any patron account, tab through the tabs... - Verify that discharge, purchase suggestions and ill requests are missing the toolbar - Apply patch - Verify that the toolbar now appears on these pages and works correctly - Also veriy that the headings are now consistently h1 on all pages Signed-off-by: David Roberts Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 8218653df75cc61676ce40f2feea70bb5671614b Author: Katrin Fischer Date: Tue Apr 14 16:57:38 2020 +0000 Bug 18680: Add an empty entry by default to sort1/sort2 values in patron account When using sort1/sort2 with authorised values to create a pull down list, there will be no empty entry unless one is manually added to the authorised values list. This is not a good default behaviour, as it can easily cause errors on patron creation. Without the empty entry, the first alphabetic value is pre-selected and will be saved if not explicitly changed. It also doesn't allow to mark sort1/sort2 as mandatory, as the value is always 'set', the required message won't be triggered. This adds an empty parameter to av-build-dropbox.inc to allow selectively adding this empty entry without causing side-effects in other places this include is used. To test: - Create authorised values for either Bsort1 or Bsort2 authorised value category - Create a new patron: - you should see a pull down list on one and an input field for the other - for the pull down list, there will be no empty entry and the first alphabetic value will be preselected - Make your sort1 and sort2 mandatory using BorrowerMandatoryField - Verify there is still on empty entry - Apply patch - Repeat tests and verify that the behaviour is as expected - There should now be an empty entry - When the field is marked mandatory and empty is left, the required warning will be shown. Signed-off-by: David Roberts Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 563120a004f03a96c935b179af36cace874f708c Author: Katrin Fischer Date: Mon Apr 13 03:46:25 2020 +0200 Bug 10561: Rephrase DisplayOPACiconsXSLT and DisplayIconsXSLT slightly As the pref removes the whole 'line' of information, this tries to makes the behaviour a little clearer by adding a 'and descriptions' to the pref text. It now reads: [Show|Don't show] the format, audience, and material type icons and descriptions in XSLT MARC21 results and detail pages in ... To test: - Check both preference descriptions in the staff client - Verify the text reads correctly and this helps things Signed-off-by: David Roberts Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit d8dd31142c0bfd9b09f9fa8e02fc292cf9deed2c Author: Jonathan Druart Date: Fri Apr 17 11:22:04 2020 +0200 Bug 13518: Delete patron's modifications along with the patron The table borrower_modifications has no FK constraint on the borrowernumber and will remain untouched when the patron is deleted. If the borrowernumber doesn't exist in the database, the modification entry is no longer visible in Koha. The problem is that this table is used for the borrower modifications and the self-registration features. So far borrowernumber is the PK (int(11) NOT NULL DEFAULT '0'), for the self-registration feature we can have borrowernumber that is not defined (0 is used) Ideally we would like to have borrowernumber a DEFAULT NULL, and use NULL for self-reg, but then we will loose the PK (PK cannot be NULL). As we cannot keep the correct constraints at DB level anyway, we will need to handle consistency at code-level. Test plan: Create a new patron Do some modification at the OPAC Delete the patron Confirm that the modifications as been removed (directly in DB) Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: Koha/Patron.pm | 5 +++++ koha-tmpl/intranet-tmpl/prog/en/includes/av-build-dropbox.inc | 6 ++++-- koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref | 2 +- .../prog/en/modules/admin/preferences/staff_client.pref | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/members/discharge.tt | 6 ++++-- koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/members/ill-requests.tt | 5 ++++- koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt | 4 ++-- .../intranet-tmpl/prog/en/modules/members/purchase-suggestions.tt | 3 ++- koha-tmpl/intranet-tmpl/prog/en/modules/members/statistics.tt | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt | 1 + t/db_dependent/Koha/Patrons.t | 5 ++++- 12 files changed, 30 insertions(+), 13 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 20 15:05:49 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 20 Apr 2020 13:05:49 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1842-g80dc5c36b8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 80dc5c36b823be0113ff7b456d17ad81e1da368e (commit) via 2dc31f65aef1357d98c20872eaa9a2a6f3b98beb (commit) via e5001c5a37f4df02cad9f0490376fc2179aa966b (commit) via 14783dabbee9817329c50972f18d63cf22b2edf2 (commit) via fa580344912781d8b010f81fab8e1e4298c493e7 (commit) via b331d19e8df506991fc1deafc372c27a1554015a (commit) via e5870e30de55129b5b1037a00283aa9c6aa4095d (commit) via 93fbfcb1bfb420a415c75d850b3eef0dacb2df06 (commit) via 743f40a202ba915dccbf35058e5b7ecf707e3e67 (commit) from c54654c12944250ed75bbdd011e6ac6cacf58d3f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 80dc5c36b823be0113ff7b456d17ad81e1da368e Author: Jonathan Druart Date: Mon Apr 20 12:38:05 2020 +0200 Bug 14229: Remove extra spaces Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 2dc31f65aef1357d98c20872eaa9a2a6f3b98beb Author: Katrin Fischer Date: Thu Apr 16 00:29:57 2020 +0200 Bug 14229: Add link from patron search results fine to accounting tab in patron account This adds a link to the accounting tab from the patron search results by making the amount in the Fines column clickable. To test: - Make sure you have some patrons with fines, credits and 0,00 - Search for your patrons using the patron search, make sure you get more than one result for your search - Check the results table - the amount should always be linked and lead to the patron account accounting > transactions tab. Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit e5001c5a37f4df02cad9f0490376fc2179aa966b Author: Katrin Fischer Date: Mon Apr 13 18:22:04 2020 +0000 Bug 24819: (follow-up) Rename suggestor to suggester I believe I suggested a typo - trying to fix it here. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 14783dabbee9817329c50972f18d63cf22b2edf2 Author: Matthias Meusburger Date: Tue Mar 24 14:52:31 2020 +0100 Bug 24819: (follow-up) Rename suggestion_search to suggestor_search Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit fa580344912781d8b010f81fab8e1e4298c493e7 Author: Matthias Meusburger Date: Thu Mar 5 16:41:25 2020 +0100 Bug 24819: Allow the librarian to choose a patron when entering a purchase suggestion Sometimes librarians are creating purchase suggestions that came from patrons which didn't use the opac (but sent an email, or told the librarian verbally...) This patch allows the librarian to change the creator of the purchase suggestion when entering it. This way, the patron will be able to receive notifications during the purchase suggestion workflow. Test plan: - Apply the patch - Check that you can change the default creator of the purchase suggestion when creating a new suggestion by clicking on 'Set to patron' (Home > Acquisitions > Suggestions management > New purchase suggestion) - Check that you can also change the creator of the purchase suggestion when editing an existing suggestion Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit b331d19e8df506991fc1deafc372c27a1554015a Author: Nick Clemens Date: Wed Apr 8 10:11:38 2020 +0000 Bug 20484: Allow configuration of ES before switching to ES To test: 1 - Set SearchEngine syspref to Zebra 2 - Be a user with permission to manage search engine configuration (manage_search_engine_config) 3 - Confirm you do not see 'Search engine configuration' on Admin main page 4 - Apply patch 5 - Confirm you see it with '(Elasticsearch)' appended 6 - Be a user without above permission 7 - Confirm you cannot see the 'Search engine configuration' 8 - Confirm you cannot access directly: /cgi-bin/koha/admin/searchengine/elasticsearch/mappings.pl Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit e5870e30de55129b5b1037a00283aa9c6aa4095d Author: Owen Leonard Date: Mon Apr 13 17:45:22 2020 +0000 Bug 25135: Improve clarity and navigation of columns settings administration This patch makes some modifications to the columns setting administration template so that the headings are a little clearer. In-page navigation is added for each section. To test, apply the patch and go to Administration -> Columns settings. - Confirm that the collapsing panels work correctly. - Expand a section and confirm that the "jump to" links work correctly. Signed-off-by: Bernardo Gonzalez Kriegel Looks good, works good. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 93fbfcb1bfb420a415c75d850b3eef0dacb2df06 Author: Owen Leonard Date: Fri Apr 17 13:32:35 2020 +0000 Bug 23349: (follow-up) Correct translation function This patch corrects the translation function inside results.js. It should be two underscores instead of one. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 743f40a202ba915dccbf35058e5b7ecf707e3e67 Author: Owen Leonard Date: Mon Apr 6 20:39:35 2020 +0000 Bug 23349: Add batch operations to staff interface catalog search results This patch adds three new options to the staff interface catalog search results for users with cataloging permission: batch edit, batch delete, and merge. The choices are found in an "Edit" menu which is disabled by default. Checking any boxes in the search results table enables the button. To test, apply the patch and log in to Koha as a user with edit_catalogue permission. - Perform a search in the catalog - You should see a disabled "Edit" button in the toolbar at the top of the search results table. - Check a single checkbox. The button should become enabled. - Test the "Batch edit" and "Batch delete" menu items. They should work correctly. - Test the "Merge records" item. It should warn you that you must select at least two records. - Check more than one checkbox and test each menu item again. All should work as expected. - Log in to the staff client as a user who does not have edit_catalogue permission. The "Edit" menu should no longer appear on the search results page. Signed-off-by: Abbey Holt Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/includes/admin-menu.inc | 6 +- .../prog/en/modules/admin/admin-home.tt | 6 +- .../prog/en/modules/admin/columns_settings.tt | 80 ++++++++++++++-------- .../admin/searchengine/elasticsearch/mappings.tt | 6 +- .../prog/en/modules/catalogue/results.tt | 10 +++ .../en/modules/members/tables/members_results.tt | 2 +- .../prog/en/modules/suggestion/suggestion.tt | 9 ++- .../tables/suggester_search.tt} | 0 koha-tmpl/intranet-tmpl/prog/js/pages/results.js | 68 +++++++++++++++++- koha-tmpl/intranet-tmpl/prog/js/suggestions.js | 17 +++++ .../suggester_search.pl | 6 +- 11 files changed, 163 insertions(+), 47 deletions(-) copy koha-tmpl/intranet-tmpl/prog/en/modules/{members/tables/guarantor_search.tt => suggestion/tables/suggester_search.tt} (100%) create mode 100644 koha-tmpl/intranet-tmpl/prog/js/suggestions.js copy members/guarantor_search.pl => suggestion/suggester_search.pl (91%) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Apr 21 13:42:43 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 21 Apr 2020 11:42:43 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1844-ge94ea221df Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via e94ea221df93bb0bcbc3a2e90b4b8ff5daab761a (commit) via 7de19f4e5c00025a29b6b8db2d095592bf48e20c (commit) from 80dc5c36b823be0113ff7b456d17ad81e1da368e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e94ea221df93bb0bcbc3a2e90b4b8ff5daab761a Author: Martin Renvoize Date: Tue Apr 21 12:14:13 2020 +0100 Bug 20484: (RM follow-up) Highlight ES disablement Signed-off-by: Martin Renvoize commit 7de19f4e5c00025a29b6b8db2d095592bf48e20c Author: Nick Clemens Date: Tue Apr 21 10:54:56 2020 +0000 Bug 20484: Implement blocking_errors for ES config page Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: admin/searchengine/elasticsearch/mappings.pl | 13 +++++++++++-- .../intranet-tmpl/prog/en/includes/blocking_errors.inc | 2 ++ .../en/modules/admin/searchengine/elasticsearch/mappings.tt | 4 ++++ 3 files changed, 17 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Apr 21 14:01:06 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 21 Apr 2020 12:01:06 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1850-gc42674cfd9 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via c42674cfd98a2774881f48db5454bdb3392c57c8 (commit) via 3d022f0f27e3c2cfa42dbcad3b472acb5232fc71 (commit) via c7d067667c4c2494505b736553b19150d1838464 (commit) via 8d306ff2ffb399a66e179e1d9e4cf45246dc83af (commit) via 49c15f06ac545a4374441076a7f8192f576b1f26 (commit) via 4a2cc4e9039dbeeb77d776ff8ae1099aa84fde30 (commit) from e94ea221df93bb0bcbc3a2e90b4b8ff5daab761a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c42674cfd98a2774881f48db5454bdb3392c57c8 Author: Martin Renvoize Date: Tue Apr 21 12:33:47 2020 +0100 Bug 24913: DBRev 19.12.00.078 Signed-off-by: Martin Renvoize commit 3d022f0f27e3c2cfa42dbcad3b472acb5232fc71 Author: Aleisha Amohia Date: Tue Apr 14 04:51:41 2020 +0000 Bug 24913: Add PatronSelfRegistrationConfirmEmail syspref To test: 1) update database, restart memcached/plack 2) Go to Administration -> System preferences -> OPAC tab. Enable the new PatronSelfRegistrationConfirmEmail system preference. Enable other required self registration sysprefs. 3) Go to the OPAC home page. (You may need to log out). Click the 'Register' link so you are redirected to the member entry form. 4) Notice the 'Confirm primary email' field after the 'primary email' field. Put 'a at a.com' in primary email, and 'b at b.com' in the confirm field. Scroll to the end of the form and Submit. 5) Confirm the form is not successfully submitted, and an error message is shown to indicate the email addresses do not match. 6) Confirm you cannot cut, copy or paste in either the primary email or confirm primary email fields. Confirm the right click menu doesn't work in these fields. 7) Disable javascript in your browser. 8) Repeat steps 3 and 4. 9) Confirm there is an error message to indicate the email addresses do not match. 10) Re-enable javascript. Fill in the form correctly with matching email addresses and confirm it successfully submits. 11) Disable the PatronSelfRegistrationConfirmEmail syspref. 12) Attempt to register an account on the OPAC again. Confirm the 'confirm email address' field is gone and form works as expected. 13) Re-enable the PatronSelfRegistrationConfirmEmail syspref. 14) Log in to the OPAC and go to your personal details 15) Edit the primary email field 16) Confirm you are able to submit your changes (you should not see an error about emails not matching). Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: holly Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit c7d067667c4c2494505b736553b19150d1838464 Author: Martin Renvoize Date: Mon Apr 20 08:37:10 2020 +0100 Bug 25123: (QA follow-up) Re-used variable name Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 8d306ff2ffb399a66e179e1d9e4cf45246dc83af Author: Nick Clemens Date: Mon Apr 13 11:38:28 2020 +0000 Bug 25123: Count the current fine when reducing for maxFine If maxFine is set, we total the patrons outstanding fines when making an adjustment, however, we neglect to count the amount of a currently updating fine when doing so. To test: 1 - Set maxFine to 5 2 - Create an overdue amount of 4.99 for a patron 3 - Set an itemtype to have a fine of $.10 per day 4 - Checkout an item of that type to a patron and backdate the due date so it is overdue 5 - Run fines.pl with -v 6 - Note the fine is reduced from $.10 (or a multiple) to .01 7 - Run it again, a second cent is added 8 - Repeat and note it keeps happening until the amount of the fine is reached, exceeding the maxFine setting 9 - Apply patch 10 - Note the fine is now reduced to 0 and nothing is added to account Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 49c15f06ac545a4374441076a7f8192f576b1f26 Author: Nick Clemens Date: Mon Apr 13 11:38:23 2020 +0000 Bug 25123: Unit tests Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 4a2cc4e9039dbeeb77d776ff8ae1099aa84fde30 Author: Katrin Fischer Date: Sun Apr 12 22:06:05 2020 +0000 Bug 14369: Only show 'Create labels' link on staged records import when status is imported The label creator won't be able to add a batch for items, if they are not imported into the database (missing itemnumber). This patch hides the link, when the status is not imported, to avoid the error situation. To test: - Export a record with items from your Koha installation - Delete items and record from Koha - Stage the record with the items - the "Create labels" link should be showing - Try to create the labels - note error - Apply patch - Retry - the link should no longer show - Import the records - the link should show now - Create labels again - a new batch should have been created - Verify the link on the batch # leads to the batch in the labels module Bonus: Moves the message from the .pl file to the template to make it translatable. Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Overdues.pm | 1 - Koha.pm | 2 +- installer/data/mysql/sysprefs.sql | 1 + installer/data/mysql/updatedatabase.pl | 7 +++++ .../prog/en/modules/admin/preferences/opac.pref | 6 ++++ .../prog/en/modules/tools/manage-marc-import.tt | 16 ++++++++-- .../bootstrap/en/modules/opac-memberentry.tt | 34 ++++++++++++++++++++++ opac/opac-memberentry.pl | 6 ++++ t/db_dependent/Overdues.t | 32 +++++++++++++++++++- tools/manage-marc-import.pl | 4 +-- 10 files changed, 101 insertions(+), 8 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Apr 21 20:36:55 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 21 Apr 2020 18:36:55 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.04-155-gc33f598c5c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via c33f598c5cdea829390660419498e15f968f9abe (commit) from 3401e94d942a8d8a4e216ea44bd295f96b8f3e24 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c33f598c5cdea829390660419498e15f968f9abe Author: Jonathan Druart Date: Tue Apr 14 13:22:44 2020 +0200 Bug 25142: Fix wrong grep logical test To test and understand what's going on, you can try that bit of code: my @a = qw( a b c a); my @b = qw( b c d ); my @c; @c = grep { 'a' eq $_ } @a ? 'ok' : (); say @c; @c = ( grep { 'a' eq $_ } @a ) ? 'ok' : (); say @c; @c = grep { 'a' eq $_ } @a ? ('ok') : (undef); say @c; The problem here: Have patrons in 3 branches CPL, MPL, SPL Have a non superlibrarian with edit_borrowers permission but without view_borrower_infos_from_any_libraries, from CPL Create a library group with CPL, MPL Use that non superlibrarian to search for patrons You can search for patrons fro CPL and MPL BUT, edit the value for CPL, use SPL (edit the DOM) Search and... oops Apply this patch, try again Also use a superlibrarian patron (and/or with view_borrower_infos_from_any_libraries) and confirm that they can see all patrons Signed-off-by: Bernardo Gonzalez Kriegel Tested with edit_borrowers permission but NOT view_borrower_infos_from_any_libraries Editing the DOM I can search (not edit) from any branch With patch no entries found :) Signed-off-by: Katrin Fischer Amended test plan slightly (+ without) Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: C4/Utils/DataTables/Members.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Apr 21 21:26:39 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 21 Apr 2020 19:26:39 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.04-161-gdf92a325e6 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via df92a325e68d14c3706288faff3951458517b562 (commit) via b0eca65c276c149c8771defaa7a20bb365a419a2 (commit) via 7e96ee9d645b32216b0786338119aba1facfed03 (commit) via b53381c3cf18952fb760646a18457861f6097fe7 (commit) via 769dba699225440ba701ea284ce48ed8189aca0c (commit) via 48e25e8938b6efa89dd45acb1f6ec16171224711 (commit) from c33f598c5cdea829390660419498e15f968f9abe (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit df92a325e68d14c3706288faff3951458517b562 Author: Jonathan Druart Date: Tue Feb 18 10:37:58 2020 +0100 Bug 7611: Adjust tests Signed-off-by: Joy Nelson commit b0eca65c276c149c8771defaa7a20bb365a419a2 Author: Nick Clemens Date: Fri Nov 8 15:49:08 2019 +0000 Bug 7611: (follow-up) separate positive and negative statuses as in the past This patch preserves someting closer to previous functionality. Negative not for loan are in the 'unavailable' section in red, positive ones are in the 'reference' section in green. Itemtype level will also be in green in reference Item specific status will override an itemtype level. The line break between 'reference' and 'unavailable' existed before and is preserved - negative not for loan and checked out items appear here Signed-off-by: Jonathan Druart Signed-off-by: Joy Nelson commit 7e96ee9d645b32216b0786338119aba1facfed03 Author: Nick Clemens Date: Tue Nov 5 16:32:45 2019 +0000 Bug 7611: (follow-up) Fix display of undefined statuses and add a class Signed-off-by: Jonathan Druart Signed-off-by: Joy Nelson commit b53381c3cf18952fb760646a18457861f6097fe7 Author: Nick Date: Tue Oct 15 13:30:02 2019 +0000 Bug 7611: (follow-up) Add missing space Signed-off-by: Jonathan Druart Signed-off-by: Joy Nelson commit 769dba699225440ba701ea284ce48ed8189aca0c Author: Nick Date: Thu Aug 29 12:06:24 2019 +0000 Bug 7611: Change negative notforloan as well This makes the changes apply to both positive and negative notforloan values The extra line generated before is removed Some spans are added and cleaned up and labels moved to CSS to allow for easier altering where needed Itemtypes marked notforloan remain as reference, the label can be changed via css To test: 1 - Have a record with items in various statuses, ideally - 3 available, with 2 in one branch, 1 in another - 3 with itemtype not for loan, 2 in one branch, 1 in another - 3 in a positive not for loan status, 2 and 1 as above - 3 in a negative not for loan status, 2 and 1 as above - 1 in a different positive loan status, but with the same opac description as the negative above 2 - Search the opac to include this record, take a screenshot 3 - Apply patch 4 - Restart all and refresh 5 - Compare to screen shot 6 - Differences include: - Positive statuses are now on separate line with opac description showing - Unavailable (not for loan items) now include callnumber and branch in display - Positive and negative notforloan with same description are combined where branches match - Inspect the elements, note new spans around 'Items available for loan/reference' 7 - Add to OPACUserCSS: .ItemSummary .ItemBranch{ display:none; } .unavailable .ItemSummary .CallNumber,.unavailable .ItemSummary .LabelCallNumber{ display:none; } 8 - Note the branches are hidden, and callnumbe rhidden for unavailable items Signed-off-by: Jessica Zairo Signed-off-by: Jonathan Druart Signed-off-by: Joy Nelson commit 48e25e8938b6efa89dd45acb1f6ec16171224711 Author: Mehdi Hamidi Date: Fri Mar 3 14:33:29 2017 -0500 Bug 7611: Show the NOT_LOAN authorised values for item status in XSLT OPAC search results Added : Call number for all not for loan status XSLT Results template improvement : Use the NOT_LOAN authorised values Improvement : Use the NOT_LOAN authorised values when showing items status in the OPAC search results. Before this patch, these items were only considered as "unavailable". Note : This patch only affects the OPAC XSLT search results template for MARC21 records. This patch was not tested on UNIMARC or NORMARC records. I won't be able to support these formats, so I'm hoping someone could do the same for these other record formats. Patch sponsored by the CCSR ( http://www.ccsr.qc.ca ) Signed-off-by: Jonathan Druart Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: C4/XSLT.pm | 15 ++-- koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss | 8 ++ .../bootstrap/en/xslt/MARC21slim2OPACResults.xsl | 91 +++++++++++++++++----- t/db_dependent/XSLT.t | 6 +- 4 files changed, 92 insertions(+), 28 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Apr 21 22:24:22 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 21 Apr 2020 20:24:22 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.04-162-gd6dc787017 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via d6dc787017fac846b81cd43b65c6fc5d37fc0fcd (commit) from df92a325e68d14c3706288faff3951458517b562 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d6dc787017fac846b81cd43b65c6fc5d37fc0fcd Author: Joy Nelson Date: Tue Apr 21 19:57:26 2020 +0000 Bug 7611: Compiled CSS Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/css/opac.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Apr 22 00:17:41 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 21 Apr 2020 22:17:41 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.15-26-gdfe1bd600c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via dfe1bd600c3155bdc905716c8c745051a3234d06 (commit) from 3b8c2467e5bde0311f520e286832a52ad0b4a17e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit dfe1bd600c3155bdc905716c8c745051a3234d06 Author: Jonathan Druart Date: Tue Apr 14 13:22:44 2020 +0200 Bug 25142: Fix wrong grep logical test To test and understand what's going on, you can try that bit of code: my @a = qw( a b c a); my @b = qw( b c d ); my @c; @c = grep { 'a' eq $_ } @a ? 'ok' : (); say @c; @c = ( grep { 'a' eq $_ } @a ) ? 'ok' : (); say @c; @c = grep { 'a' eq $_ } @a ? ('ok') : (undef); say @c; The problem here: Have patrons in 3 branches CPL, MPL, SPL Have a non superlibrarian with edit_borrowers permission but without view_borrower_infos_from_any_libraries, from CPL Create a library group with CPL, MPL Use that non superlibrarian to search for patrons You can search for patrons fro CPL and MPL BUT, edit the value for CPL, use SPL (edit the DOM) Search and... oops Apply this patch, try again Also use a superlibrarian patron (and/or with view_borrower_infos_from_any_libraries) and confirm that they can see all patrons Signed-off-by: Bernardo Gonzalez Kriegel Tested with edit_borrowers permission but NOT view_borrower_infos_from_any_libraries Editing the DOM I can search (not edit) from any branch With patch no entries found :) Signed-off-by: Katrin Fischer Amended test plan slightly (+ without) Signed-off-by: Joy Nelson (cherry picked from commit c33f598c5cdea829390660419498e15f968f9abe) Signed-off-by: Hayley Mapley ----------------------------------------------------------------------- Summary of changes: C4/Utils/DataTables/Members.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Apr 22 02:31:17 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 22 Apr 2020 00:31:17 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.15-27-gb6954b6b0d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via b6954b6b0de6e7a95de014cbf35f949869589664 (commit) from dfe1bd600c3155bdc905716c8c745051a3234d06 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b6954b6b0de6e7a95de014cbf35f949869589664 Author: Tomas Cohen Arazi Date: Fri Mar 27 18:16:58 2020 -0300 Bug 25009: Avoid leakages in opac-showmarc.pl This patch cleans opac-showmarc.pl so it doesn't allow retrieving records from import batches without requiring any permissions in the OPAC. it does so by just removing the code portion that does that. It also cleans the record fetch operation and how the record processor is initialized to it actually works :-D To test: 1. Perform a successful Z39.50 search in cataloguing (this fetches 20 records usually) 2. Query your DB for a valid import_record_id: $ koha-mysql kohadev > SELECT * FROM import_records LIMIT 1; 3. Notice some of the MARCXML details (title, author, etc), and the import_record_id 4. Point your browser to the opac-showmarc.pl URL like this: http://kohadev.mydnsname.org:8080/cgi-bin/koha/opac-showmarc.pl?importid=20 => FAIL: You get the record! (Bonus: no field/subfield takes place) 5. Hide some obvious subfield on the framework for a known (to you) biblionumber 6. Point your browser to: http://kohadev.mydnsname.org:8080/cgi-bin/koha/opac-showmarc.pl?id= => FAIL: No filtering takes place 7. Apply this patch 8. Repeat 4 => SUCCESS: You get an error because you did a bad request (no id param) 9. Repeat 6 => SUCCESS: Subfield filtering actually works! 10. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Signed-off-by: Joy Nelson (cherry picked from commit d3ba9dc0fe423347f0e0e90b66be3ebeb7a6dec1) Signed-off-by: Hayley Mapley ----------------------------------------------------------------------- Summary of changes: opac/opac-showmarc.pl | 41 +++++++++++++++++++++++++---------------- 1 file changed, 25 insertions(+), 16 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Apr 22 03:10:43 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 22 Apr 2020 01:10:43 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.15-29-g548486bc54 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via 548486bc541f849a1997b335f81237cd78c40c0d (commit) via f1b7767a5f8f6c67633ca7d304b759044364437c (commit) from b6954b6b0de6e7a95de014cbf35f949869589664 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 548486bc541f849a1997b335f81237cd78c40c0d Author: Hayley Mapley Date: Wed Apr 22 12:42:55 2020 +1200 Increment version for 18.11.16 release Signed-off-by: Hayley Mapley commit f1b7767a5f8f6c67633ca7d304b759044364437c Author: Koha translators <> Date: Tue Apr 21 21:29:48 2020 -0300 Translation updates for Koha 18.11.16 Signed-off-by: Hayley Mapley ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/updatedatabase.pl | 6 + misc/translator/po/am-Ethi-marc-MARC21.po | 2 +- misc/translator/po/am-Ethi-marc-NORMARC.po | 2 +- misc/translator/po/am-Ethi-marc-UNIMARC.po | 2 +- misc/translator/po/am-Ethi-opac-bootstrap.po | 416 +++++----- misc/translator/po/am-Ethi-staff-prog.po | 428 +++++++---- misc/translator/po/ar-Arab-marc-MARC21.po | 2 +- misc/translator/po/ar-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ar-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/ar-Arab-opac-bootstrap.po | 416 +++++----- misc/translator/po/ar-Arab-staff-prog.po | 434 +++++++---- misc/translator/po/as-IN-marc-MARC21.po | 2 +- misc/translator/po/as-IN-marc-NORMARC.po | 2 +- misc/translator/po/as-IN-marc-UNIMARC.po | 2 +- misc/translator/po/as-IN-opac-bootstrap.po | 416 +++++----- misc/translator/po/as-IN-staff-prog.po | 426 +++++++---- misc/translator/po/az-AZ-marc-MARC21.po | 2 +- misc/translator/po/az-AZ-marc-NORMARC.po | 2 +- misc/translator/po/az-AZ-marc-UNIMARC.po | 2 +- misc/translator/po/az-AZ-opac-bootstrap.po | 416 +++++----- misc/translator/po/az-AZ-staff-prog.po | 429 +++++++---- misc/translator/po/be-BY-marc-MARC21.po | 2 +- misc/translator/po/be-BY-marc-NORMARC.po | 2 +- misc/translator/po/be-BY-marc-UNIMARC.po | 2 +- misc/translator/po/be-BY-opac-bootstrap.po | 416 +++++----- misc/translator/po/be-BY-staff-prog.po | 436 +++++++---- misc/translator/po/bg-Cyrl-marc-MARC21.po | 2 +- misc/translator/po/bg-Cyrl-marc-NORMARC.po | 2 +- misc/translator/po/bg-Cyrl-marc-UNIMARC.po | 2 +- misc/translator/po/bg-Cyrl-opac-bootstrap.po | 416 +++++----- misc/translator/po/bg-Cyrl-staff-prog.po | 428 +++++++---- misc/translator/po/bn-IN-marc-MARC21.po | 2 +- misc/translator/po/bn-IN-marc-NORMARC.po | 2 +- misc/translator/po/bn-IN-marc-UNIMARC.po | 2 +- misc/translator/po/bn-IN-opac-bootstrap.po | 416 +++++----- misc/translator/po/bn-IN-staff-prog.po | 427 +++++++---- misc/translator/po/ca-ES-marc-MARC21.po | 2 +- misc/translator/po/ca-ES-marc-NORMARC.po | 2 +- misc/translator/po/ca-ES-marc-UNIMARC.po | 2 +- misc/translator/po/ca-ES-opac-bootstrap.po | 416 +++++----- misc/translator/po/ca-ES-staff-prog.po | 429 +++++++---- misc/translator/po/cs-CZ-marc-MARC21.po | 2 +- misc/translator/po/cs-CZ-marc-NORMARC.po | 2 +- misc/translator/po/cs-CZ-marc-UNIMARC.po | 2 +- misc/translator/po/cs-CZ-opac-bootstrap.po | 416 +++++----- misc/translator/po/cs-CZ-staff-prog.po | 448 +++++++---- misc/translator/po/cy-GB-marc-MARC21.po | 2 +- misc/translator/po/cy-GB-marc-NORMARC.po | 2 +- misc/translator/po/cy-GB-marc-UNIMARC.po | 2 +- misc/translator/po/cy-GB-opac-bootstrap.po | 416 +++++----- misc/translator/po/cy-GB-staff-prog.po | 426 +++++++---- misc/translator/po/da-DK-marc-MARC21.po | 2 +- misc/translator/po/da-DK-marc-NORMARC.po | 2 +- misc/translator/po/da-DK-marc-UNIMARC.po | 2 +- misc/translator/po/da-DK-opac-bootstrap.po | 416 +++++----- misc/translator/po/da-DK-staff-prog.po | 431 +++++++---- misc/translator/po/de-CH-marc-MARC21.po | 2 +- misc/translator/po/de-CH-marc-NORMARC.po | 2 +- misc/translator/po/de-CH-marc-UNIMARC.po | 2 +- misc/translator/po/de-CH-opac-bootstrap.po | 416 +++++----- misc/translator/po/de-CH-staff-prog.po | 434 +++++++---- misc/translator/po/de-DE-marc-MARC21.po | 8 +- misc/translator/po/de-DE-marc-NORMARC.po | 2 +- misc/translator/po/de-DE-marc-UNIMARC.po | 2 +- misc/translator/po/de-DE-opac-bootstrap.po | 416 +++++----- misc/translator/po/de-DE-staff-prog.po | 447 +++++++---- misc/translator/po/dz-marc-MARC21.po | 2 +- misc/translator/po/dz-marc-NORMARC.po | 2 +- misc/translator/po/dz-marc-UNIMARC.po | 2 +- misc/translator/po/dz-opac-bootstrap.po | 416 +++++----- misc/translator/po/dz-staff-prog.po | 426 +++++++---- misc/translator/po/el-GR-marc-MARC21.po | 10 +- misc/translator/po/el-GR-marc-NORMARC.po | 2 +- misc/translator/po/el-GR-marc-UNIMARC.po | 2 +- misc/translator/po/el-GR-opac-bootstrap.po | 416 +++++----- misc/translator/po/el-GR-staff-prog.po | 445 +++++++---- misc/translator/po/en-GB-marc-MARC21.po | 2 +- misc/translator/po/en-GB-marc-NORMARC.po | 2 +- misc/translator/po/en-GB-marc-UNIMARC.po | 2 +- misc/translator/po/en-GB-opac-bootstrap.po | 416 +++++----- misc/translator/po/en-GB-staff-prog.po | 431 +++++++---- misc/translator/po/en-NZ-marc-MARC21.po | 2 +- misc/translator/po/en-NZ-marc-NORMARC.po | 2 +- misc/translator/po/en-NZ-marc-UNIMARC.po | 2 +- misc/translator/po/en-NZ-opac-bootstrap.po | 416 +++++----- misc/translator/po/en-NZ-staff-prog.po | 434 +++++++---- misc/translator/po/eo-marc-MARC21.po | 2 +- misc/translator/po/eo-marc-NORMARC.po | 2 +- misc/translator/po/eo-marc-UNIMARC.po | 2 +- misc/translator/po/eo-opac-bootstrap.po | 447 ++++++----- misc/translator/po/eo-staff-prog.po | 427 +++++++---- misc/translator/po/es-ES-marc-MARC21.po | 2 +- misc/translator/po/es-ES-marc-NORMARC.po | 2 +- misc/translator/po/es-ES-marc-UNIMARC.po | 2 +- misc/translator/po/es-ES-opac-bootstrap.po | 416 +++++----- misc/translator/po/es-ES-staff-prog.po | 448 +++++++---- misc/translator/po/eu-marc-MARC21.po | 2 +- misc/translator/po/eu-marc-NORMARC.po | 2 +- misc/translator/po/eu-marc-UNIMARC.po | 2 +- misc/translator/po/eu-opac-bootstrap.po | 451 ++++++----- misc/translator/po/eu-staff-prog.po | 512 ++++++++----- misc/translator/po/fa-Arab-marc-MARC21.po | 2 +- misc/translator/po/fa-Arab-marc-NORMARC.po | 2 +- misc/translator/po/fa-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/fa-Arab-opac-bootstrap.po | 416 +++++----- misc/translator/po/fa-Arab-staff-prog.po | 432 +++++++---- misc/translator/po/fi-FI-marc-MARC21.po | 2 +- misc/translator/po/fi-FI-marc-NORMARC.po | 2 +- misc/translator/po/fi-FI-marc-UNIMARC.po | 2 +- misc/translator/po/fi-FI-opac-bootstrap.po | 416 +++++----- misc/translator/po/fi-FI-staff-prog.po | 434 +++++++---- misc/translator/po/fo-FO-marc-MARC21.po | 2 +- misc/translator/po/fo-FO-marc-NORMARC.po | 2 +- misc/translator/po/fo-FO-marc-UNIMARC.po | 2 +- misc/translator/po/fo-FO-opac-bootstrap.po | 416 +++++----- misc/translator/po/fo-FO-staff-prog.po | 426 +++++++---- misc/translator/po/fr-CA-marc-MARC21.po | 2 +- misc/translator/po/fr-CA-marc-NORMARC.po | 2 +- misc/translator/po/fr-CA-marc-UNIMARC.po | 2 +- misc/translator/po/fr-CA-opac-bootstrap.po | 416 +++++----- misc/translator/po/fr-CA-staff-prog.po | 441 +++++++---- misc/translator/po/fr-FR-marc-MARC21.po | 2 +- misc/translator/po/fr-FR-marc-NORMARC.po | 2 +- misc/translator/po/fr-FR-marc-UNIMARC.po | 8 +- misc/translator/po/fr-FR-opac-bootstrap.po | 416 +++++----- misc/translator/po/fr-FR-pref.po | 14 +- misc/translator/po/fr-FR-staff-prog.po | 452 +++++++---- misc/translator/po/ga-marc-MARC21.po | 2 +- misc/translator/po/ga-marc-NORMARC.po | 2 +- misc/translator/po/ga-marc-UNIMARC.po | 2 +- misc/translator/po/ga-opac-bootstrap.po | 416 +++++----- misc/translator/po/ga-staff-prog.po | 426 +++++++---- misc/translator/po/gd-marc-MARC21.po | 2 +- misc/translator/po/gd-marc-NORMARC.po | 2 +- misc/translator/po/gd-marc-UNIMARC.po | 2 +- misc/translator/po/gd-opac-bootstrap.po | 416 +++++----- misc/translator/po/gd-staff-prog.po | 426 +++++++---- misc/translator/po/gl-marc-MARC21.po | 2 +- misc/translator/po/gl-marc-NORMARC.po | 2 +- misc/translator/po/gl-marc-UNIMARC.po | 2 +- misc/translator/po/gl-opac-bootstrap.po | 416 +++++----- misc/translator/po/gl-staff-prog.po | 429 +++++++---- misc/translator/po/he-Hebr-marc-MARC21.po | 2 +- misc/translator/po/he-Hebr-marc-NORMARC.po | 2 +- misc/translator/po/he-Hebr-marc-UNIMARC.po | 2 +- misc/translator/po/he-Hebr-opac-bootstrap.po | 416 +++++----- misc/translator/po/he-Hebr-staff-prog.po | 429 +++++++---- misc/translator/po/hi-marc-MARC21.po | 2 +- misc/translator/po/hi-marc-NORMARC.po | 2 +- misc/translator/po/hi-marc-UNIMARC.po | 2 +- misc/translator/po/hi-opac-bootstrap.po | 416 +++++----- misc/translator/po/hi-staff-prog.po | 441 +++++++---- misc/translator/po/hr-HR-marc-MARC21.po | 2 +- misc/translator/po/hr-HR-marc-NORMARC.po | 2 +- misc/translator/po/hr-HR-marc-UNIMARC.po | 2 +- misc/translator/po/hr-HR-opac-bootstrap.po | 416 +++++----- misc/translator/po/hr-HR-staff-prog.po | 429 +++++++---- misc/translator/po/hu-HU-marc-MARC21.po | 2 +- misc/translator/po/hu-HU-marc-NORMARC.po | 2 +- misc/translator/po/hu-HU-marc-UNIMARC.po | 2 +- misc/translator/po/hu-HU-opac-bootstrap.po | 422 +++++----- misc/translator/po/hu-HU-staff-prog.po | 429 +++++++---- misc/translator/po/hy-Armn-marc-MARC21.po | 2 +- misc/translator/po/hy-Armn-marc-NORMARC.po | 2 +- misc/translator/po/hy-Armn-marc-UNIMARC.po | 2 +- misc/translator/po/hy-Armn-opac-bootstrap.po | 416 +++++----- misc/translator/po/hy-Armn-staff-prog.po | 458 +++++++---- misc/translator/po/ia-marc-MARC21.po | 2 +- misc/translator/po/ia-marc-NORMARC.po | 2 +- misc/translator/po/ia-marc-UNIMARC.po | 2 +- misc/translator/po/ia-opac-bootstrap.po | 416 +++++----- misc/translator/po/ia-staff-prog.po | 426 +++++++---- misc/translator/po/id-ID-marc-MARC21.po | 2 +- misc/translator/po/id-ID-marc-NORMARC.po | 2 +- misc/translator/po/id-ID-marc-UNIMARC.po | 2 +- misc/translator/po/id-ID-opac-bootstrap.po | 416 +++++----- misc/translator/po/id-ID-staff-prog.po | 429 +++++++---- misc/translator/po/iq-CA-marc-MARC21.po | 2 +- misc/translator/po/iq-CA-marc-NORMARC.po | 2 +- misc/translator/po/iq-CA-marc-UNIMARC.po | 2 +- misc/translator/po/iq-CA-opac-bootstrap.po | 416 +++++----- misc/translator/po/iq-CA-staff-prog.po | 426 +++++++---- misc/translator/po/is-IS-marc-MARC21.po | 2 +- misc/translator/po/is-IS-marc-NORMARC.po | 2 +- misc/translator/po/is-IS-marc-UNIMARC.po | 2 +- misc/translator/po/is-IS-opac-bootstrap.po | 416 +++++----- misc/translator/po/is-IS-staff-prog.po | 429 +++++++---- misc/translator/po/it-IT-marc-MARC21.po | 2 +- misc/translator/po/it-IT-marc-NORMARC.po | 2 +- misc/translator/po/it-IT-marc-UNIMARC.po | 2 +- misc/translator/po/it-IT-opac-bootstrap.po | 416 +++++----- misc/translator/po/it-IT-staff-prog.po | 435 +++++++---- misc/translator/po/iu-CA-marc-MARC21.po | 2 +- misc/translator/po/iu-CA-marc-NORMARC.po | 2 +- misc/translator/po/iu-CA-marc-UNIMARC.po | 2 +- misc/translator/po/iu-CA-opac-bootstrap.po | 416 +++++----- misc/translator/po/iu-CA-staff-prog.po | 426 +++++++---- misc/translator/po/ja-Jpan-JP-marc-MARC21.po | 2 +- misc/translator/po/ja-Jpan-JP-marc-NORMARC.po | 2 +- misc/translator/po/ja-Jpan-JP-marc-UNIMARC.po | 2 +- misc/translator/po/ja-Jpan-JP-opac-bootstrap.po | 416 +++++----- misc/translator/po/ja-Jpan-JP-staff-prog.po | 433 +++++++---- misc/translator/po/ka-marc-MARC21.po | 2 +- misc/translator/po/ka-marc-NORMARC.po | 2 +- misc/translator/po/ka-marc-UNIMARC.po | 2 +- misc/translator/po/ka-opac-bootstrap.po | 416 +++++----- misc/translator/po/ka-staff-prog.po | 426 +++++++---- misc/translator/po/km-KH-marc-MARC21.po | 2 +- misc/translator/po/km-KH-marc-NORMARC.po | 2 +- misc/translator/po/km-KH-marc-UNIMARC.po | 2 +- misc/translator/po/km-KH-opac-bootstrap.po | 416 +++++----- misc/translator/po/km-KH-staff-prog.po | 426 +++++++---- misc/translator/po/kn-Knda-marc-MARC21.po | 2 +- misc/translator/po/kn-Knda-marc-NORMARC.po | 2 +- misc/translator/po/kn-Knda-marc-UNIMARC.po | 2 +- misc/translator/po/kn-Knda-opac-bootstrap.po | 416 +++++----- misc/translator/po/kn-Knda-staff-prog.po | 435 +++++++---- misc/translator/po/ko-Kore-KP-marc-MARC21.po | 2 +- misc/translator/po/ko-Kore-KP-marc-NORMARC.po | 2 +- misc/translator/po/ko-Kore-KP-marc-UNIMARC.po | 2 +- misc/translator/po/ko-Kore-KP-opac-bootstrap.po | 416 +++++----- misc/translator/po/ko-Kore-KP-staff-prog.po | 434 +++++++---- misc/translator/po/ku-Arab-marc-MARC21.po | 2 +- misc/translator/po/ku-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ku-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/ku-Arab-opac-bootstrap.po | 416 +++++----- misc/translator/po/ku-Arab-staff-prog.po | 431 +++++++---- misc/translator/po/lo-Laoo-marc-MARC21.po | 2 +- misc/translator/po/lo-Laoo-marc-NORMARC.po | 2 +- misc/translator/po/lo-Laoo-marc-UNIMARC.po | 2 +- misc/translator/po/lo-Laoo-opac-bootstrap.po | 416 +++++----- misc/translator/po/lo-Laoo-staff-prog.po | 429 +++++++---- misc/translator/po/lv-marc-MARC21.po | 2 +- misc/translator/po/lv-marc-NORMARC.po | 2 +- misc/translator/po/lv-marc-UNIMARC.po | 2 +- misc/translator/po/lv-opac-bootstrap.po | 416 +++++----- misc/translator/po/lv-staff-prog.po | 426 +++++++---- misc/translator/po/mi-NZ-marc-MARC21.po | 2 +- misc/translator/po/mi-NZ-marc-NORMARC.po | 2 +- misc/translator/po/mi-NZ-marc-UNIMARC.po | 2 +- misc/translator/po/mi-NZ-opac-bootstrap.po | 416 +++++----- misc/translator/po/mi-NZ-staff-prog.po | 429 +++++++---- misc/translator/po/ml-marc-MARC21.po | 2 +- misc/translator/po/ml-marc-NORMARC.po | 2 +- misc/translator/po/ml-marc-UNIMARC.po | 2 +- misc/translator/po/ml-opac-bootstrap.po | 416 +++++----- misc/translator/po/ml-staff-prog.po | 426 +++++++---- misc/translator/po/mon-marc-MARC21.po | 2 +- misc/translator/po/mon-marc-NORMARC.po | 2 +- misc/translator/po/mon-marc-UNIMARC.po | 2 +- misc/translator/po/mon-opac-bootstrap.po | 416 +++++----- misc/translator/po/mon-staff-prog.po | 429 +++++++---- misc/translator/po/mr-marc-MARC21.po | 2 +- misc/translator/po/mr-marc-NORMARC.po | 2 +- misc/translator/po/mr-marc-UNIMARC.po | 2 +- misc/translator/po/mr-opac-bootstrap.po | 416 +++++----- misc/translator/po/mr-staff-prog.po | 429 +++++++---- misc/translator/po/ms-MY-marc-MARC21.po | 2 +- misc/translator/po/ms-MY-marc-NORMARC.po | 2 +- misc/translator/po/ms-MY-marc-UNIMARC.po | 2 +- misc/translator/po/ms-MY-opac-bootstrap.po | 416 +++++----- misc/translator/po/ms-MY-staff-prog.po | 453 +++++++---- misc/translator/po/my-marc-MARC21.po | 2 +- misc/translator/po/my-marc-NORMARC.po | 2 +- misc/translator/po/my-marc-UNIMARC.po | 2 +- misc/translator/po/my-opac-bootstrap.po | 416 +++++----- misc/translator/po/my-staff-prog.po | 426 +++++++---- misc/translator/po/nb-NO-marc-MARC21.po | 2 +- misc/translator/po/nb-NO-marc-NORMARC.po | 2 +- misc/translator/po/nb-NO-marc-UNIMARC.po | 2 +- misc/translator/po/nb-NO-opac-bootstrap.po | 416 +++++----- misc/translator/po/nb-NO-staff-prog.po | 433 +++++++---- misc/translator/po/ne-NE-marc-MARC21.po | 2 +- misc/translator/po/ne-NE-marc-NORMARC.po | 2 +- misc/translator/po/ne-NE-marc-UNIMARC.po | 2 +- misc/translator/po/ne-NE-opac-bootstrap.po | 416 +++++----- misc/translator/po/ne-NE-staff-prog.po | 427 +++++++---- misc/translator/po/nl-BE-marc-MARC21.po | 2 +- misc/translator/po/nl-BE-marc-NORMARC.po | 2 +- misc/translator/po/nl-BE-marc-UNIMARC.po | 2 +- misc/translator/po/nl-BE-opac-bootstrap.po | 416 +++++----- misc/translator/po/nl-BE-staff-prog.po | 431 +++++++---- misc/translator/po/nl-NL-marc-MARC21.po | 2 +- misc/translator/po/nl-NL-marc-NORMARC.po | 2 +- misc/translator/po/nl-NL-marc-UNIMARC.po | 2 +- misc/translator/po/nl-NL-opac-bootstrap.po | 416 +++++----- misc/translator/po/nl-NL-staff-prog.po | 440 +++++++---- misc/translator/po/nn-NO-marc-MARC21.po | 2 +- misc/translator/po/nn-NO-marc-NORMARC.po | 2 +- misc/translator/po/nn-NO-marc-UNIMARC.po | 2 +- misc/translator/po/nn-NO-opac-bootstrap.po | 416 +++++----- misc/translator/po/nn-NO-staff-prog.po | 429 +++++++---- misc/translator/po/oc-marc-MARC21.po | 2 +- misc/translator/po/oc-marc-NORMARC.po | 2 +- misc/translator/po/oc-marc-UNIMARC.po | 2 +- misc/translator/po/oc-opac-bootstrap.po | 416 +++++----- misc/translator/po/oc-staff-prog.po | 435 +++++++---- misc/translator/po/pbr-marc-MARC21.po | 2 +- misc/translator/po/pbr-marc-NORMARC.po | 2 +- misc/translator/po/pbr-marc-UNIMARC.po | 2 +- misc/translator/po/pbr-opac-bootstrap.po | 416 +++++----- misc/translator/po/pbr-staff-prog.po | 427 +++++++---- misc/translator/po/pl-PL-marc-MARC21.po | 2 +- misc/translator/po/pl-PL-marc-NORMARC.po | 2 +- misc/translator/po/pl-PL-marc-UNIMARC.po | 2 +- misc/translator/po/pl-PL-opac-bootstrap.po | 416 +++++----- misc/translator/po/pl-PL-staff-prog.po | 441 +++++++---- misc/translator/po/prs-marc-MARC21.po | 2 +- misc/translator/po/prs-marc-NORMARC.po | 2 +- misc/translator/po/prs-marc-UNIMARC.po | 2 +- misc/translator/po/prs-opac-bootstrap.po | 416 +++++----- misc/translator/po/prs-staff-prog.po | 429 +++++++---- misc/translator/po/pt-BR-marc-MARC21.po | 2 +- misc/translator/po/pt-BR-marc-NORMARC.po | 2 +- misc/translator/po/pt-BR-marc-UNIMARC.po | 2 +- misc/translator/po/pt-BR-opac-bootstrap.po | 416 +++++----- misc/translator/po/pt-BR-staff-prog.po | 442 +++++++---- misc/translator/po/pt-PT-marc-MARC21.po | 2 +- misc/translator/po/pt-PT-marc-NORMARC.po | 2 +- misc/translator/po/pt-PT-marc-UNIMARC.po | 2 +- misc/translator/po/pt-PT-opac-bootstrap.po | 424 +++++----- misc/translator/po/pt-PT-staff-prog.po | 465 +++++++---- misc/translator/po/ro-RO-marc-MARC21.po | 2 +- misc/translator/po/ro-RO-marc-NORMARC.po | 2 +- misc/translator/po/ro-RO-marc-UNIMARC.po | 2 +- misc/translator/po/ro-RO-opac-bootstrap.po | 416 +++++----- misc/translator/po/ro-RO-staff-prog.po | 429 +++++++---- misc/translator/po/ru-RU-marc-MARC21.po | 2 +- misc/translator/po/ru-RU-marc-NORMARC.po | 2 +- misc/translator/po/ru-RU-marc-UNIMARC.po | 2 +- misc/translator/po/ru-RU-opac-bootstrap.po | 416 +++++----- misc/translator/po/ru-RU-staff-prog.po | 436 +++++++---- misc/translator/po/rw-RW-marc-MARC21.po | 2 +- misc/translator/po/rw-RW-marc-NORMARC.po | 2 +- misc/translator/po/rw-RW-marc-UNIMARC.po | 2 +- misc/translator/po/rw-RW-opac-bootstrap.po | 416 +++++----- misc/translator/po/rw-RW-staff-prog.po | 426 +++++++---- misc/translator/po/sd-PK-marc-MARC21.po | 2 +- misc/translator/po/sd-PK-marc-NORMARC.po | 2 +- misc/translator/po/sd-PK-marc-UNIMARC.po | 2 +- misc/translator/po/sd-PK-opac-bootstrap.po | 416 +++++----- misc/translator/po/sd-PK-staff-prog.po | 428 +++++++---- misc/translator/po/sk-SK-marc-MARC21.po | 414 ++++++---- misc/translator/po/sk-SK-marc-NORMARC.po | 2 +- misc/translator/po/sk-SK-marc-UNIMARC.po | 2 +- misc/translator/po/sk-SK-opac-bootstrap.po | 436 +++++------ misc/translator/po/sk-SK-staff-prog.po | 766 +++++++++++-------- misc/translator/po/sl-SI-marc-MARC21.po | 2 +- misc/translator/po/sl-SI-marc-NORMARC.po | 2 +- misc/translator/po/sl-SI-marc-UNIMARC.po | 2 +- misc/translator/po/sl-SI-opac-bootstrap.po | 416 +++++----- misc/translator/po/sl-SI-staff-prog.po | 426 +++++++---- misc/translator/po/sq-AL-marc-MARC21.po | 65 +- misc/translator/po/sq-AL-marc-NORMARC.po | 2 +- misc/translator/po/sq-AL-marc-UNIMARC.po | 2 +- misc/translator/po/sq-AL-opac-bootstrap.po | 695 +++++++++-------- misc/translator/po/sq-AL-pref.po | 16 +- misc/translator/po/sq-AL-staff-prog.po | 508 +++++++----- misc/translator/po/sr-Cyrl-marc-MARC21.po | 2 +- misc/translator/po/sr-Cyrl-marc-NORMARC.po | 2 +- misc/translator/po/sr-Cyrl-marc-UNIMARC.po | 2 +- misc/translator/po/sr-Cyrl-opac-bootstrap.po | 416 +++++----- misc/translator/po/sr-Cyrl-staff-prog.po | 429 +++++++---- misc/translator/po/sv-SE-marc-MARC21.po | 2 +- misc/translator/po/sv-SE-marc-NORMARC.po | 2 +- misc/translator/po/sv-SE-marc-UNIMARC.po | 2 +- misc/translator/po/sv-SE-opac-bootstrap.po | 416 +++++----- misc/translator/po/sv-SE-staff-prog.po | 434 +++++++---- misc/translator/po/sw-KE-marc-MARC21.po | 2 +- misc/translator/po/sw-KE-marc-NORMARC.po | 2 +- misc/translator/po/sw-KE-marc-UNIMARC.po | 2 +- misc/translator/po/sw-KE-opac-bootstrap.po | 416 +++++----- misc/translator/po/sw-KE-staff-prog.po | 426 +++++++---- misc/translator/po/ta-LK-marc-MARC21.po | 2 +- misc/translator/po/ta-LK-marc-NORMARC.po | 2 +- misc/translator/po/ta-LK-marc-UNIMARC.po | 2 +- misc/translator/po/ta-LK-opac-bootstrap.po | 416 +++++----- misc/translator/po/ta-LK-staff-prog.po | 427 +++++++---- misc/translator/po/ta-marc-MARC21.po | 2 +- misc/translator/po/ta-marc-NORMARC.po | 2 +- misc/translator/po/ta-marc-UNIMARC.po | 2 +- misc/translator/po/ta-opac-bootstrap.po | 416 +++++----- misc/translator/po/ta-staff-prog.po | 427 +++++++---- misc/translator/po/tet-marc-MARC21.po | 2 +- misc/translator/po/tet-marc-NORMARC.po | 2 +- misc/translator/po/tet-marc-UNIMARC.po | 2 +- misc/translator/po/tet-opac-bootstrap.po | 416 +++++----- misc/translator/po/tet-staff-prog.po | 433 +++++++---- misc/translator/po/th-TH-marc-MARC21.po | 2 +- misc/translator/po/th-TH-marc-NORMARC.po | 2 +- misc/translator/po/th-TH-marc-UNIMARC.po | 2 +- misc/translator/po/th-TH-opac-bootstrap.po | 416 +++++----- misc/translator/po/th-TH-staff-prog.po | 429 +++++++---- misc/translator/po/tl-PH-marc-MARC21.po | 2 +- misc/translator/po/tl-PH-marc-NORMARC.po | 2 +- misc/translator/po/tl-PH-marc-UNIMARC.po | 2 +- misc/translator/po/tl-PH-opac-bootstrap.po | 416 +++++----- misc/translator/po/tl-PH-staff-prog.po | 429 +++++++---- misc/translator/po/tr-TR-marc-MARC21.po | 10 +- misc/translator/po/tr-TR-marc-NORMARC.po | 2 +- misc/translator/po/tr-TR-marc-UNIMARC.po | 2 +- misc/translator/po/tr-TR-opac-bootstrap.po | 507 ++++++------ misc/translator/po/tr-TR-pref.po | 74 +- misc/translator/po/tr-TR-staff-prog.po | 977 ++++++++++++++---------- misc/translator/po/tvl-marc-MARC21.po | 2 +- misc/translator/po/tvl-marc-NORMARC.po | 2 +- misc/translator/po/tvl-marc-UNIMARC.po | 2 +- misc/translator/po/tvl-opac-bootstrap.po | 416 +++++----- misc/translator/po/tvl-staff-prog.po | 426 +++++++---- misc/translator/po/uk-UA-marc-MARC21.po | 2 +- misc/translator/po/uk-UA-marc-NORMARC.po | 2 +- misc/translator/po/uk-UA-marc-UNIMARC.po | 2 +- misc/translator/po/uk-UA-opac-bootstrap.po | 416 +++++----- misc/translator/po/uk-UA-staff-prog.po | 444 +++++++---- misc/translator/po/ur-Arab-marc-MARC21.po | 2 +- misc/translator/po/ur-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ur-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/ur-Arab-opac-bootstrap.po | 416 +++++----- misc/translator/po/ur-Arab-staff-prog.po | 427 +++++++---- misc/translator/po/vi-VN-marc-MARC21.po | 2 +- misc/translator/po/vi-VN-marc-NORMARC.po | 2 +- misc/translator/po/vi-VN-marc-UNIMARC.po | 2 +- misc/translator/po/vi-VN-opac-bootstrap.po | 416 +++++----- misc/translator/po/vi-VN-staff-prog.po | 432 +++++++---- misc/translator/po/zh-Hans-CN-marc-MARC21.po | 2 +- misc/translator/po/zh-Hans-CN-marc-NORMARC.po | 2 +- misc/translator/po/zh-Hans-CN-marc-UNIMARC.po | 2 +- misc/translator/po/zh-Hans-CN-opac-bootstrap.po | 416 +++++----- misc/translator/po/zh-Hans-CN-staff-prog.po | 432 +++++++---- misc/translator/po/zh-Hant-TW-marc-MARC21.po | 2 +- misc/translator/po/zh-Hant-TW-marc-NORMARC.po | 2 +- misc/translator/po/zh-Hant-TW-marc-UNIMARC.po | 2 +- misc/translator/po/zh-Hant-TW-opac-bootstrap.po | 432 +++++------ misc/translator/po/zh-Hant-TW-pref.po | 8 +- misc/translator/po/zh-Hant-TW-staff-prog.po | 502 +++++++----- 436 files changed, 44014 insertions(+), 31680 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Apr 22 03:32:11 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 22 Apr 2020 01:32:11 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.15-30-geb3d1f373d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via eb3d1f373ddff4e209a13c3e3a4a06cd3bf118ba (commit) from 548486bc541f849a1997b335f81237cd78c40c0d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit eb3d1f373ddff4e209a13c3e3a4a06cd3bf118ba Author: Hayley Mapley Date: Wed Apr 22 13:05:03 2020 +1200 Update release notes for 18.11.16 release Signed-off-by: Hayley Mapley ----------------------------------------------------------------------- Summary of changes: ...s_18_11_13.html => release_notes_18_11_16.html} | 213 ++++++++++----------- ...notes_18_11_13.md => release_notes_18_11_16.md} | 205 ++++++++++---------- 2 files changed, 208 insertions(+), 210 deletions(-) copy misc/release_notes/{release_notes_18_11_13.html => release_notes_18_11_16.html} (61%) copy misc/release_notes/{release_notes_18_11_13.md => release_notes_18_11_16.md} (51%) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Apr 22 03:34:40 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 22 Apr 2020 01:34:40 +0000 Subject: [koha-commits] main Koha release repository annotated tag v18.11.16 created. v18.11.16 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The annotated tag, v18.11.16 has been created at 6c2f5eb9d7e4dbcb1172246c8937b15041c9358e (tag) tagging eb3d1f373ddff4e209a13c3e3a4a06cd3bf118ba (commit) replaces v18.11.15 tagged by Hayley Mapley on Wed Apr 22 13:07:13 2020 +1200 - Log ----------------------------------------------------------------- Koha release 18.11.16 -----BEGIN PGP SIGNATURE----- iQJRBAABCgA7FiEEeUrTaBok6eOiWqnEKxuPgpNerlQFAl6fmMEdHGhheWxleW1h cGxleUBjYXRhbHlzdC5uZXQubnoACgkQKxuPgpNerlTt/hAAizHUp0a1WTNIt0Cl 0ouQ9SnECFXtN7xRQsPUwI92m6hJB1JMJrcCbjNx8LjGjeHRPrHkh3RFahMi0kxu jljcce934vAJ+xk4tesky0wkNOCN9r4k3thdosHSFDNOZVTkgqrGoBssdxSZd/GQ 9rv/jJtEfmCBTmtUHglAFpBSJGKBMEhcfS7s0fgIBOtneN5ow04O+kp1zfePdXFX qhzbDXwrG6bCkE+dSra9tLqfXC3d0jZjVQtioG2I51Q2SLE292HvoRh7aXaQatkq 4CabuXgUc8dawj3yuxnsJzoiCTMTMS2tNK1EKUUsILE0NvEoEzWAQjjyH9HnH1To 1ihtvIwgpl9+aJeoTMx5k52jbpOpRte4LiFgDLcTbyn2db+kwSA0PZ52kmP+alPm yW6tgpP0hok5PsJKXECbX96uvKsaGTVHeqcHPej5801z3ap2BecjcqvWGjn8yHB6 1TnMgGrUKVicTvZw6v09Dz0DsIatpw1DFty3B2eiwzf4deo3oupiu1BtLc9T+z9c AQy2s70rK+nVTIR0/yal9yeQTAfApRt2upMjWYeFC74v37VpxK2mq1rlfihrWcIe BTfOwxYLyPtT4D7HegLQ+6LRmn3SC/SNR6rD1C8eQM3c2Fkdz7np92Bdum67dPDD xrsSuvGcpkUJdheXFtquk7MwwUs= =3HEK -----END PGP SIGNATURE----- Aleisha Amohia (1): Bug 24688: Check the priority of the fulfilled hold when fixing priorities Andrew Fuerste-Henry (2): Bug 24747: Corrects on-screen instructions in branch transfer limits Bug 24838: Fix help link for patron categories Bernardo González Kriegel (1): Bug 24870: Translate installer data label David Cook (1): Bug 17464: Order deny,allow / Deny from all was deprecated in Apache 2.4 and is now a hard error Fridolin Somers (3): Bug 23968: fix OPACMySummaryNote feature Bug 23968: Add div this id around OPACMySummaryNote content Bug 24527: misc/cronjobs/update_totalissues.pl problem with multiple items Hayley Mapley (4): Bug 24846: DBRev 18.11.15.001 Bug 24673 (18.11.x U18 follow-up): Fixing t/db_dependent/Koha/XSLT/Security.t Increment version for 18.11.16 release Update release notes for 18.11.16 release Jonathan Druart (7): Bug 24846: Add new permission batch_extend_due_dates Bug 24846: Link to the new tool Bug 24846: Add new tool to batch extend due dates Bug 24846: Update items.onloan with the new due date Bug 24813: Prevent api/v1/holds.t to fail randomly Bug 25020: Preserve time part when batch extending due dates Bug 25142: Fix wrong grep logical test Katrin Fischer (1): Bug 24605: (QA follow-up) Fix unencoded series link in staff interface Koha translators (1): Translation updates for Koha 18.11.16 Liz Rea (1): Bug 24324: Resolve error with delete_records_via_leader.pl Marcel de Rooy (2): Bug 24809: (QA follow-up) Add prefix to prevent disambiguity Bug 16922: Add RewriteRule to apache-shared-intranet for dev package installs Nick Clemens (4): Bug 24711: Don't add logout input to login form Bug 24809: Get only timestamp of deleted items attached to existing bibs when check if bib deleted Bug 24605: Fix unencoded series link Bug 24733: created_by param should be an arrayref Owen Leonard (1): Bug 24798: smart-rules.tt has erroneous comments Tomás Cohen Arazi (1): Bug 25009: Avoid leakages in opac-showmarc.pl ----------------------------------------------------------------------- hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Apr 22 10:59:07 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 22 Apr 2020 08:59:07 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1852-g4a84f7a9e0 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 4a84f7a9e0d13898d9a17071e3bd74f904a1e4f8 (commit) via 03ece9452a5eef8ca76dab413f4f5177f69797d1 (commit) from c42674cfd98a2774881f48db5454bdb3392c57c8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4a84f7a9e0d13898d9a17071e3bd74f904a1e4f8 Author: Phil Ringnalda Date: Sun Apr 19 02:37:49 2020 +0000 Bug 20501: Don't cut strings when unhighlighting in intranet search results When you click Unhighlight on the search results of a search in the staff client when the search terms contain the same word twice, like "ma ma", the highlighted words disappear, and don't reappear if you click Highlight. This patch makes the same change to the intranet copy of jquery.highlight-3.js that bug 5844 made to the OPAC copy. Test plan: 1) Without this patch, search in the intranet for ma ma and verify you have at least two matching records. 2) Notice that the Ma in Material type: Book is highlighted. 3) Click Unhighlight, and notice that it has become terial type: Book 4) Apply this patch, repeat the search with a shift+reload to reload the .js 5) Click Unhighlight, and verify that Material type: Book remains Material Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize commit 03ece9452a5eef8ca76dab413f4f5177f69797d1 Author: Nick Clemens Date: Mon Apr 20 18:41:37 2020 +0000 Bug 25223: Make join of aqbasket and aqorders explicit This is simply a SQL change that makes things a bit easier to read and also prevents too much data being returned in a large system To test: 1 - Have some orders in your system in the ordered status 2 - Click the 'Ordered' amount for your budget from Acquisitions home 3 - Note the view of orders, possibly screen shot 4 - Apply patch 5 - Restart all the things 6 - Reload the ordered page 7 - Confirm nothing has changed Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: acqui/ordered.pl | 4 ++-- koha-tmpl/intranet-tmpl/lib/jquery/plugins/jquery.highlight-3.js | 8 ++------ 2 files changed, 4 insertions(+), 8 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Apr 22 13:53:23 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 22 Apr 2020 11:53:23 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1853-g82090e2673 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 82090e2673f44aea18a205ee3cf9deb04bd91c80 (commit) from 4a84f7a9e0d13898d9a17071e3bd74f904a1e4f8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 82090e2673f44aea18a205ee3cf9deb04bd91c80 Author: Martin Renvoize Date: Wed Apr 22 12:24:27 2020 +0100 Bug 24183: (RM follow-up) Remove re-introduced UseKohaPlugins We removed UseKohaPlugins in bug 20415 but incidentally added a reference to it bug 24183. This patch corrects that error. Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: misc/cronjobs/process_message_queue.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Apr 22 15:12:15 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 22 Apr 2020 13:12:15 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1863-g37e6fe6ae5 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 37e6fe6ae59469aeb2078c52b4419c1fe5f3dea8 (commit) via 7283a3a3e7777b1d34a7bf8c3974a4efc6fbe3d7 (commit) via 16a030ebf64ce2a43af097f235cee1bc78a760e3 (commit) via fb9268417bfd9e39f50053e948291c77530609a1 (commit) via bfa921665abfc4fcf8c5c3bc5f115769bf2c9f55 (commit) via 10b60d577053843c2b8935be696ecbf762d7f584 (commit) via a40ef6ece7211ef139e9440a3022ebda7492ff47 (commit) via 41b5db64b352a9cf33595171ca9c2bee70ca4f1a (commit) via 5f586e3d963be70dc1d3b5f55494f40227e43adf (commit) via 74b8c05cfb72146c738d41e88da13346c47d4d22 (commit) from 82090e2673f44aea18a205ee3cf9deb04bd91c80 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 37e6fe6ae59469aeb2078c52b4419c1fe5f3dea8 Author: Kyle M Hall Date: Mon Apr 20 13:16:11 2020 -0400 Bug 25172: Add missing filter Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit 7283a3a3e7777b1d34a7bf8c3974a4efc6fbe3d7 Author: Jonathan Druart Date: Thu Apr 16 17:16:59 2020 +0200 Bug 25172: Identify and display possible problems on the about page Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit 16a030ebf64ce2a43af097f235cee1bc78a760e3 Author: Jonathan Druart Date: Thu Apr 16 16:50:50 2020 +0200 Bug 25172: Adjust tests Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit fb9268417bfd9e39f50053e948291c77530609a1 Author: Jonathan Druart Date: Thu Apr 16 16:12:32 2020 +0200 Bug 25172: Remove _recheck_logfile I don't understand how that could be useful. We do not want to test if the logfile is writable every time we log something! Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit bfa921665abfc4fcf8c5c3bc5f115769bf2c9f55 Author: Jonathan Druart Date: Thu Apr 16 16:11:02 2020 +0200 Bug 25172: Make Koha::Logger explode if init went wrong We do not want to fail silently for the logger. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit 10b60d577053843c2b8935be696ecbf762d7f584 Author: Katrin Fischer Date: Sat Apr 11 14:43:41 2020 +0000 Bug 5614: Organize 'patron' system preferences Until now, there was only "General" and "Privacy". This patch breaks the "General" prefs up into multiple sections. To test: - Go to Administration > Patrons - Verify the current state of things - Apply patch - Reload patch - Verify headings make sense and groups make sense as well Signed-off-by: David Nind Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize commit a40ef6ece7211ef139e9440a3022ebda7492ff47 Author: Nick Date: Wed Oct 2 14:53:42 2019 +0000 Bug 20816: Make SIP tests pass under ES Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize commit 41b5db64b352a9cf33595171ca9c2bee70ca4f1a Author: Nick Clemens Date: Wed Jun 19 17:59:14 2019 +0000 Bug 20816: Add ability to define custom templated fields in SIP patron responses To test: 1 - You will need to enable SIP on your testing instance cp etc/SIPconfig.xml /etc/koha/sites/kohadev/ sudo koha-start-sip add a user listed in the SIPconfig to your system and give them permissions (superlibrarian works) on koha-testing-docker you should be able to start sip with user koha/koha without any adjustments 2 - If you copied the above file you should be set to get custom field DE with dateexpiry Otherwise edit the sip login for the user to have a custom section like: 3 - send a status test using the sip cli tester: perl misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su koha -sp koha -l kohalibrary --patron 23529001000463 -m patron_status_request 4 - send an information test using the sip cli tester: perl misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su koha -sp koha -l kohalibrary --patron 23529001000463 -m patron_information 5 - confirm you receive the DE field with a dateexpiry 6 - Add your own custom fields and confirm it works with several 7 - prove -v t/db_dependent/SIP/Patron.t 8 - prove -v t/db_dependent/SIP/ Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize commit 5f586e3d963be70dc1d3b5f55494f40227e43adf Author: Owen Leonard Date: Tue Mar 17 18:44:23 2020 +0000 Bug 16962: Remove the use of "onclick" from serial collection template This patch removes the use of event attributes like "onclick" from the serial collection template. Events are now defined in JavaScript. To test, apply the patch and go to Serials - Locate or create a subscription for which an item record is NOT created when receiving. - On the serial collection page for this subscription, test that the "Multi receiving" button works correctly. - For any subscription, test that the "Generate next" button works correctly. - In each tab, test that the "select all" and "clear all" links work correctly and affect only that tab. - On a subscription which has expired, test that the "Renew" button works correctly. Signed-off-by: David Nind Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize commit 74b8c05cfb72146c738d41e88da13346c47d4d22 Author: Jonathan Druart Date: Mon Apr 20 11:13:40 2020 +0200 Bug 25186: Fix accordion sections height in columns configuration page The height for each section was the height of the highest section. Now the height is set to the length of the section. Test plan: Go to Administration > Column configuration Open the sections and confirm that the height fits its content. QA: note that I guess "autoHeight: false" was meant to achieve that, but it does not exist in the API of the plugin. Signed-off-by: Owen Leonard Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/SIP/ILS/Patron.pm | 47 ++- C4/SIP/Sip.pm | 1 - C4/SIP/Sip/MsgType.pm | 17 +- Koha/Logger.pm | 88 +---- about.pl | 20 ++ etc/SIPconfig.xml | 1 + koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 15 +- .../prog/en/modules/admin/columns_settings.tt | 2 +- .../prog/en/modules/admin/preferences/patrons.pref | 396 +++++++++++---------- .../prog/en/modules/serials/serials-collection.tt | 65 ++-- t/Logger.t | 41 +-- t/db_dependent/SIP/Message.t | 17 +- t/db_dependent/SIP/Patron.t | 46 ++- t/db_dependent/SIP/Transaction.t | 21 +- 14 files changed, 424 insertions(+), 353 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Apr 22 17:10:33 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 22 Apr 2020 15:10:33 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1864-gb50d891c09 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via b50d891c099d0f21f2528c5a6d5bbb586cf1612e (commit) from 37e6fe6ae59469aeb2078c52b4419c1fe5f3dea8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b50d891c099d0f21f2528c5a6d5bbb586cf1612e Author: Jonathan Druart Date: Wed Apr 22 16:40:08 2020 +0200 Bug 25172: Fix Auth_with_ldap.t # Failed test 'checkpw_ldap tests' # at t/db_dependent/Auth_with_ldap.t line 324. {UNKNOWN}: Configuration not defined at /usr/share/perl5/Log/Log4perl/Config.pm line 579. at /kohadevbox/koha/Koha/Patron.pm line 395 Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: t/db_dependent/Auth_with_ldap.t | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Apr 22 19:19:30 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 22 Apr 2020 17:19:30 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.04-163-gcb641e9715 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via cb641e97150030ed98df180079402855c6d84eeb (commit) from d6dc787017fac846b81cd43b65c6fc5d37fc0fcd (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit cb641e97150030ed98df180079402855c6d84eeb Author: Joy Nelson Date: Wed Apr 22 16:52:21 2020 +0000 Increment version for 19.11.05 release Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/updatedatabase.pl | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Apr 22 19:40:18 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 22 Apr 2020 17:40:18 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.04-164-gc5125b3d4c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via c5125b3d4c3ea2acd3647f86b9b4550a9675aff5 (commit) from cb641e97150030ed98df180079402855c6d84eeb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c5125b3d4c3ea2acd3647f86b9b4550a9675aff5 Author: Joy Nelson Date: Wed Apr 22 17:13:19 2020 +0000 Update release notes for 19.11.05 release Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: misc/release_notes/release_notes_19_11_05.html | 717 +++++++++++++++++++++++++ misc/release_notes/release_notes_19_11_05.md | 567 +++++++++++++++++++ 2 files changed, 1284 insertions(+) create mode 100644 misc/release_notes/release_notes_19_11_05.html create mode 100644 misc/release_notes/release_notes_19_11_05.md hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Apr 22 21:12:22 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 22 Apr 2020 19:12:22 +0000 Subject: [koha-commits] main Koha release repository annotated tag v19.11.05 created. v19.11.05 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The annotated tag, v19.11.05 has been created at 644580dce86f1493b99700f0088650288e31cd4c (tag) tagging c5125b3d4c3ea2acd3647f86b9b4550a9675aff5 (commit) replaces v19.11.04 tagged by Joy Nelson on Wed Apr 22 11:45:15 2020 -0700 - Log ----------------------------------------------------------------- Koha release 19.11.05 -----BEGIN PGP SIGNATURE----- iQGzBAABCAAdFiEEoK5tmgY9tfjnUxz9nJetzohwl0IFAl6gkLsACgkQnJetzohw l0KRYwwAnAN6tCnlFNP1EPNPqKr9IZuirS35CEJfg5Ac+WPncbu05zs20/h58xZE LIdqvQFOpFqZlRp0YvYIdITXWBB91dlctXuu5vukBk97p5h9LEkMeYFMS5fAN34y CsNmCCe2YyU84ubVX2bakLQeszYxwgmHmYFU4ai949GJProvfljfNct7ARPiPk9w erec45xA3YwCj24SlDn2YbwdCpK+Cs7hHferBQi9jBN/C3kS19CLZn924AUubvBi O+dYTd2kAW9bc6kyuJe7L0RfWYoxF3JUf/RSkZnu128lziWoQzLKC4v9+rwB+yTh gqKcn8fYiCFtTpgMj1W3bW7TglZGWYpZjbIdWYdDhVDrLcHBjTwCAwfyk/CTcCz4 oo1UF+0rX0cJ9HBLqiLtKNDX2iQiDzwS0F3SXHbYiWtK0UfrKLHP2Eqwk47BUwtT Aj5Z1hQSqB4ZAkbiE2agwdM+ttdo+QLXMADW1MoSLanAwXCGoGXhJWkepIkftJ32 cGI7c2gD =jI9W -----END PGP SIGNATURE----- Agustin Moyano (2): Bug 24487: Regresion test Bug 24487: Don't apply matching criteria to path parameters Aleisha Amohia (7): Bug 5103: Format dates in MARC detail using dateformat syspref Bug 5103: (follow-up) Using mapped item fields instead of hardcoding subfields Bug 24844: Focus syspref searchbar Bug 15775: Show message on OPAC summary if holds are blocked due to fines Bug 8595: Rename 'host item' to 'host record' Bug 8595: (follow-up) Changing other occurrences of 'host item' to 'host record' Bug 24688: Check the priority of the fulfilled hold when fixing priorities Alex Arnaud (2): Bug 23521: Put parentheses arround limit terms Bug 23409: show borrowernotes and opacnote's lines feeds Andreas Roussos (2): Bug 24827: Standardise on 'UTF-8' as the encoding name Bug 24827: Specify UTF-8 as encoding in new_from_xml() Andrew Fuerste-Henry (2): Bug 24747: Corrects on-screen instructions in branch transfer limits Bug 24838: Fix help link for patron categories Andrew Isherwood (2): Bug 24565: Add patron profile to ILL list pages Bug 24518: Fix IE11 partner filtering Bernardo González Kriegel (2): Bug 24870: Translate installer data label Bug 24872: Set languages prefererences after install Caroline Cyr La Rose (1): Bug 23236: Remove 'its items may still be processed' in action if no match is found David Cook (4): Bug 24753: Change Koha/Middlware to Koha/Middleware in test name Bug 24739: Perform IPv6 tests only if Net::Netmask is correct version Bug 17464: Order deny,allow / Deny from all was deprecated in Apache 2.4 and is now a hard error Bug 24719: Remove use of CGI object in C4::Context::set_remote_address() David Gustafsson (3): Bug 24788: Remove autoloaded column accessors in Koha::Object->store Bug 22771: Respect nonfiling indicators for search fields Bug 22771: Fix mistakes in list of nonfiling character fields Emmi (1): Bug 23268: Make "Suspend all holds" calendar select a date from tomorrow Fridolin Somers (12): Bug 24527: misc/cronjobs/update_totalissues.pl problem with multiple items Bug 22969: fix biblionumber on 001 in UNIMARC XSLT Bug 19008: More database cleanups - statistics Bug 19008: More database cleanups - deleted catalog Bug 19008: More database cleanups - deleted patrons Bug 19008: More database cleanups - old issues Bug 19008: More database cleanups - old reserves Bug 19008: More database cleanups - item transfers Bug 24777: Use patron.is_debarred instead of patron.debarred in return.tt Bug 23383: fix IdRef syspref test in XSLT Bug 19279: performance of linked items in search Bug 24847: Select AND by default in items search Hayley Mapley (1): Bug 22943: Renames the in_ipset function to in_iprange in C4::Auth Jonathan Druart (33): Bug 24682: Make UsageStatsGeolocation readonly (and redirect to the config page) Bug 24114: Remove warn statements from Koha::Patrons Bug 24294: Add default value support for control fields in ACQ framework Bug 24705: Add tests Bug 24736: Disable "Enrollments" link if nobody enrolled to the club yet Bug 17532: Make koha-shell propagate the error code Bug 24813: Prevent api/v1/holds.t to fail randomly Bug 23384: Fix use statement order for ArticleRequest::Status Bug 19008: Replace issues with checkouts in print statement Bug 5103: Refactor the code to avoid repetition Bug 24827: Add a test Bug 24851: Insert libraries sample data for "UNIMARC" Bug 24851: Translate the .txt in French Bug 24200: Try to fix random failures from Borrower_PrevCheckout.t Bug 24200: (follow-up) Try to fix random failures from Borrower_PrevCheckout.t Bug 25020: Preserve time part when batch extending due dates Bug 24510: Code cleaning Bug 24510: Add missing filter Bug 24856: Remove itemtypes.imageurl in fr-FR sample data Bug 23900: Teach label maker to concat database fields Bug 23900: Add tests Bug 24250: Do not duplicate debarred comment in patron screen message AF field Bug 22025: Add a regression test Bug 22025: Remove warnings when importing patrons Bug 24614: Add tests Bug 24614: Use Koha::Reports from save_report and update_sql Bug 24614: Fix Reports/Guided.t Bug 24901: Fix tests for 19.11.x Bug 24553: Fix tests for 19.11.x Bug 24705: Fix tests for 19.11.x Bug 24487: Add 2 more tests Bug 25142: Fix wrong grep logical test Bug 7611: Adjust tests Joy Nelson (8): Bug 24103: DBRev 19.11.04.001 Bug 22273: DBRev 19.11.04.002 Bug 22273: DBRev 19.11.04.002 DBRev: followup Bug 24627: Compiled CSS Bug 7611: Compiled CSS Increment version for 19.11.05 release Update release notes for 19.11.05 release Julian Maurice (3): Bug 24552: Be compatible with Search::Elasticsearch 6.00 Bug 24760: Use C4::BackgroundJob->fetch in tests Bug 24902: Join different mc- limits with AND (elasticsearch) Katrin Fischer (9): Bug 24605: (QA follow-up) Fix unencoded series link in staff interface Bug 24736: (QA follow-up) Change tooltip wording Bug 22943: Remove unused line from Auth.t Bug 15775: Change wording slightly Bug 24848: Improve manual links for the label creator Bug 24876: Fix capitalization on patron search for holds Bug 23409: (follow-up) Allow HTML in circulation note and add line breaks in OPAC user account Bug 24877: Add link from vendor to linked subscriptions Bug 24875: Remove extra punctuation from tools start page Kyle M Hall (6): Bug 24705: Holds placed via SIP will be given first priority Bug 24802: Updating holds can cause suspensions to apply to wrong hold Bug 24767: Hide the "Claim returned" tab if the feature is turned off Bug 24566: UpdateItemLocationOnCheckin triggers SIP2 alert flag, even with checked_in_ok enabled Bug 24829: ClaimReturnedWarningThreshold is always triggered if patron has one or more claims Bug 24765: Updated on date in Claims returned starts off as 12/31/1969 Liz Rea (1): Bug 24324: Resolve error with delete_records_via_leader.pl Lucas Gass (3): Bug 24858: Correct labels on wording in ExcludeHolidaysFromMaxPickUpDelay Bug 24456: change default sort orders/make wording clearer Bug 24510: Add focus to Patron/club input Magnus Enger (1): Bug 19008: More database cleanups - QA followup Marcel de Rooy (13): Bug 24114: (follow-up) Resolve warning on non-numeric subtraction Bug 24114: (QA follow-up) Fix counts for lock, anonymize and delete Bug 24809: (QA follow-up) Add prefix to prevent disambiguity Bug 24294: (QA follow-up) Add rollback and 008 default test Bug 22273: Replace typo opan by opac in POD Bug 22273: Database revision for table article_requests Bug 22273: Modify Koha::ArticleRequest->store to fill created_on Bug 24760: (follow-up) Add a neighboring test messsage Bug 24756: [19.11.X] Catch two failed to load-variations in Security.t Bug 24892: Resolve uninitialized warns from opac-memberentry Bug 21708: Add a few tests in TransformHtmlToMarc.t Bug 21708: Sort MARC fields in TransformHtmlToMarc Bug 16922: Add RewriteRule to apache-shared-intranet for dev package installs Martin Renvoize (8): Bug 24739: Skip tests when IPv6 support is found Bug 24839: (QA follow-up) Remove unused variables Bug 22943: (QA follow-up) Add new cases Bug 24402: About template corrections Bug 24901: Minor refactor of tests Bug 24901: Add tests for transferbook Bug 24901: Minor refactor of tests Bug 24901: Add tests for transferbook Maryse Simard (2): Bug 23488: Line wrapping doesn't always respect word order in Patron card creator Bug 7882: Add ability to move and reorder fields in MARC editor Mason James (1): Bug 24874: Printing is broken on opac-results.pl page (19.11.x) Mehdi Hamidi (1): Bug 7611: Show the NOT_LOAN authorised values for item status in XSLT OPAC search results Nazlı Çetin (2): Bug 21879: Code cleaning in printinvoice.pl Bug 25000: SQL report not updated Nick (2): Bug 7611: Change negative notforloan as well Bug 7611: (follow-up) Add missing space Nick Clemens (20): Bug 24711: Don't add logout input to login form Bug 24809: Get only timestamp of deleted items attached to existing bibs when check if bib deleted Bug 24605: Fix unencoded series link Bug 24732: Set DumpTemplateVars Dumper options for Indent and Sort Bug 24103: Add option to dump search query to templates Bug 24103: (follow-up) Dump query on opac authorities search Bug 24733: created_by param should be an arrayref Bug 24839: Unit tests Bug 24839: Return hold info to transfer script and set borrowernumber Bug 23521: (follow-up) Add quotes Bug 19288: Don't show patron info for item level holds on details.pl unless hold is waiting Bug 24789: Remove ITS macro format Bug 24789: [follow-up] Fix saving of macros Bug 23411: Do not fall back to 'email' for SMS messages Bug 24553: Unit tests Bug 24553: Use 'barcode' not 'item_id' when removing hold from SIP patron Bug 24386: Prevent double form submission on adding orders to basket from a file Bug 22771: (QA follow-up) Fix POD Bug 7611: (follow-up) Fix display of undefined statuses and add a class Bug 7611: (follow-up) separate positive and negative statuses as in the past Owen Leonard (7): Bug 23753: Add missing humanMsg library to pages using background job JavaScript Bug 24803: Remove JS error when clicking "Log in to your account" Bug 24798: smart-rules.tt has erroneous comments Bug 24627: Correct style of clubs search results during hold process Bug 7882: (follow-up) Update sorting interaction Bug 7882: (follow-up) Only show sortable icon for sortable tags Bug 24510: When Placing a Hold, cursor doesn't focus on Patron Name Tomás Cohen Arazi (3): Bug 24905: Add missing entry in log4perl-site.conf.in Bug 24905: Make installer update log4perl.conf for instances Bug 25009: Avoid leakages in opac-showmarc.pl ----------------------------------------------------------------------- hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Apr 22 22:18:42 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 22 Apr 2020 20:18:42 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-92-gd8c747fcf4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via d8c747fcf40aa0fac4d4cef8d2a4d5117ce7bf00 (commit) from 3d394c4e6409271f19d57e889408b387caa614a3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d8c747fcf40aa0fac4d4cef8d2a4d5117ce7bf00 Author: Jonathan Druart Date: Tue Apr 14 13:22:44 2020 +0200 Bug 25142: Fix wrong grep logical test To test and understand what's going on, you can try that bit of code: my @a = qw( a b c a); my @b = qw( b c d ); my @c; @c = grep { 'a' eq $_ } @a ? 'ok' : (); say @c; @c = ( grep { 'a' eq $_ } @a ) ? 'ok' : (); say @c; @c = grep { 'a' eq $_ } @a ? ('ok') : (undef); say @c; The problem here: Have patrons in 3 branches CPL, MPL, SPL Have a non superlibrarian with edit_borrowers permission but without view_borrower_infos_from_any_libraries, from CPL Create a library group with CPL, MPL Use that non superlibrarian to search for patrons You can search for patrons fro CPL and MPL BUT, edit the value for CPL, use SPL (edit the DOM) Search and... oops Apply this patch, try again Also use a superlibrarian patron (and/or with view_borrower_infos_from_any_libraries) and confirm that they can see all patrons Signed-off-by: Bernardo Gonzalez Kriegel Tested with edit_borrowers permission but NOT view_borrower_infos_from_any_libraries Editing the DOM I can search (not edit) from any branch With patch no entries found :) Signed-off-by: Katrin Fischer Amended test plan slightly (+ without) Signed-off-by: Joy Nelson (cherry picked from commit c33f598c5cdea829390660419498e15f968f9abe) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/Utils/DataTables/Members.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Apr 22 22:21:11 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 22 Apr 2020 20:21:11 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-93-gd10e44a9d7 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via d10e44a9d7672873147c9b29cb9880ee54c1b9b5 (commit) from d8c747fcf40aa0fac4d4cef8d2a4d5117ce7bf00 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d10e44a9d7672873147c9b29cb9880ee54c1b9b5 Author: Marcel de Rooy Date: Thu Jul 14 13:51:21 2016 +0200 Bug 16922: Add RewriteRule to apache-shared-intranet for dev package installs As a simple alternative to the solution in bug 9949 or just as an additional measure, this patch adds a rewrite rule for intranet in order to intercept potential misuse of perl scripts that could be reached on a dev package install via the cgi-bin/koha scriptalias. It simply rewrites them to the nonexistent "notfound", resulting in a regular 404 error. The rewrite rule does not harm regular installs and is just a little extra step in securing a dev install. You should have more security measures in place to secure your staff client. QA Note: Although a rewrite rule may not be our first choice, this one rule is more elegant and easier to maintain than e.g. a whole bunch of aliases. Note: This patch should have a regular and a dev install signoff. Test plan: [1] Make sure that this rewrite rule is inserted in your actual apache config via /etc/koha/apache-shared-intranet.conf. Restart Apache. [2] For regular package installs: Try one of the URLs in step 3. Verify that your staff client still operates as usual. Test a few URLs inside some modules. [3] For dev installs: Try some URLs like below. Expect 404 errors only, not 500s. If you do not see a 404, go back! /misc/stage_file.pl /t/db_dependent/default_search_class.pl /installer/data/mysql/updatedatabase.pl /Makefile.PL [4] Do you see an additional directory to add to the regex? Please report. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Joy Nelson (cherry picked from commit 3401e94d942a8d8a4e216ea44bd295f96b8f3e24) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: debian/templates/apache-shared-intranet.conf | 3 +++ 1 file changed, 3 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Apr 22 22:27:11 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 22 Apr 2020 20:27:11 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-94-g021a9bf216 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 021a9bf2162502a6505b1a7c40b7300fe65e1f3d (commit) from d10e44a9d7672873147c9b29cb9880ee54c1b9b5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 021a9bf2162502a6505b1a7c40b7300fe65e1f3d Author: Tomas Cohen Arazi Date: Fri Mar 27 18:16:58 2020 -0300 Bug 25009: Avoid leakages in opac-showmarc.pl This patch cleans opac-showmarc.pl so it doesn't allow retrieving records from import batches without requiring any permissions in the OPAC. it does so by just removing the code portion that does that. It also cleans the record fetch operation and how the record processor is initialized to it actually works :-D To test: 1. Perform a successful Z39.50 search in cataloguing (this fetches 20 records usually) 2. Query your DB for a valid import_record_id: $ koha-mysql kohadev > SELECT * FROM import_records LIMIT 1; 3. Notice some of the MARCXML details (title, author, etc), and the import_record_id 4. Point your browser to the opac-showmarc.pl URL like this: http://kohadev.mydnsname.org:8080/cgi-bin/koha/opac-showmarc.pl?importid=20 => FAIL: You get the record! (Bonus: no field/subfield takes place) 5. Hide some obvious subfield on the framework for a known (to you) biblionumber 6. Point your browser to: http://kohadev.mydnsname.org:8080/cgi-bin/koha/opac-showmarc.pl?id= => FAIL: No filtering takes place 7. Apply this patch 8. Repeat 4 => SUCCESS: You get an error because you did a bad request (no id param) 9. Repeat 6 => SUCCESS: Subfield filtering actually works! 10. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Signed-off-by: Joy Nelson (cherry picked from commit d3ba9dc0fe423347f0e0e90b66be3ebeb7a6dec1) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: opac/opac-showmarc.pl | 41 +++++++++++++++++++++++++---------------- 1 file changed, 25 insertions(+), 16 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Apr 23 00:04:05 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 22 Apr 2020 22:04:05 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-96-gbdcca930f7 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via bdcca930f7b02c9141e8c0634d56713c89290fa8 (commit) via a5ae4ed79325de3f8f9ba242417ebf13aa970249 (commit) from 021a9bf2162502a6505b1a7c40b7300fe65e1f3d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit bdcca930f7b02c9141e8c0634d56713c89290fa8 Author: Lucas Gass Date: Wed Apr 22 21:36:31 2020 +0000 Increment version for 19.05.10 release Signed-off-by: Lucas Gass commit a5ae4ed79325de3f8f9ba242417ebf13aa970249 Author: Koha translators <> Date: Wed Apr 22 18:29:52 2020 -0300 Translation updates for Koha 19.05.10 Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/updatedatabase.pl | 6 + misc/translator/po/am-Ethi-marc-MARC21.po | 2 +- misc/translator/po/am-Ethi-marc-NORMARC.po | 2 +- misc/translator/po/am-Ethi-marc-UNIMARC.po | 50 +- misc/translator/po/am-Ethi-opac-bootstrap.po | 328 +- misc/translator/po/am-Ethi-pref.po | 10 +- misc/translator/po/am-Ethi-staff-prog.po | 1576 +- misc/translator/po/ar-Arab-marc-MARC21.po | 2 +- misc/translator/po/ar-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ar-Arab-marc-UNIMARC.po | 50 +- misc/translator/po/ar-Arab-opac-bootstrap.po | 328 +- misc/translator/po/ar-Arab-pref.po | 18 +- misc/translator/po/ar-Arab-staff-prog.po | 1582 +- misc/translator/po/as-IN-marc-MARC21.po | 2 +- misc/translator/po/as-IN-marc-NORMARC.po | 2 +- misc/translator/po/as-IN-marc-UNIMARC.po | 50 +- misc/translator/po/as-IN-opac-bootstrap.po | 328 +- misc/translator/po/as-IN-pref.po | 10 +- misc/translator/po/as-IN-staff-prog.po | 1546 +- misc/translator/po/az-AZ-marc-MARC21.po | 2 +- misc/translator/po/az-AZ-marc-NORMARC.po | 2 +- misc/translator/po/az-AZ-marc-UNIMARC.po | 50 +- misc/translator/po/az-AZ-opac-bootstrap.po | 328 +- misc/translator/po/az-AZ-pref.po | 10 +- misc/translator/po/az-AZ-staff-prog.po | 1551 +- misc/translator/po/be-BY-marc-MARC21.po | 2 +- misc/translator/po/be-BY-marc-NORMARC.po | 2 +- misc/translator/po/be-BY-marc-UNIMARC.po | 50 +- misc/translator/po/be-BY-opac-bootstrap.po | 328 +- misc/translator/po/be-BY-pref.po | 10 +- misc/translator/po/be-BY-staff-prog.po | 1568 +- misc/translator/po/bg-Cyrl-marc-MARC21.po | 2 +- misc/translator/po/bg-Cyrl-marc-NORMARC.po | 2 +- misc/translator/po/bg-Cyrl-marc-UNIMARC.po | 50 +- misc/translator/po/bg-Cyrl-opac-bootstrap.po | 328 +- misc/translator/po/bg-Cyrl-pref.po | 10 +- misc/translator/po/bg-Cyrl-staff-prog.po | 1576 +- misc/translator/po/bn-IN-marc-MARC21.po | 2 +- misc/translator/po/bn-IN-marc-NORMARC.po | 2 +- misc/translator/po/bn-IN-marc-UNIMARC.po | 50 +- misc/translator/po/bn-IN-opac-bootstrap.po | 328 +- misc/translator/po/bn-IN-pref.po | 10 +- misc/translator/po/bn-IN-staff-prog.po | 1575 +- misc/translator/po/ca-ES-marc-MARC21.po | 2 +- misc/translator/po/ca-ES-marc-NORMARC.po | 2 +- misc/translator/po/ca-ES-marc-UNIMARC.po | 50 +- misc/translator/po/ca-ES-opac-bootstrap.po | 328 +- misc/translator/po/ca-ES-pref.po | 10 +- misc/translator/po/ca-ES-staff-prog.po | 1561 +- misc/translator/po/cs-CZ-marc-MARC21.po | 2 +- misc/translator/po/cs-CZ-marc-NORMARC.po | 2 +- misc/translator/po/cs-CZ-marc-UNIMARC.po | 50 +- misc/translator/po/cs-CZ-opac-bootstrap.po | 341 +- misc/translator/po/cs-CZ-pref.po | 18 +- misc/translator/po/cs-CZ-staff-prog.po | 1605 +- misc/translator/po/cy-GB-marc-MARC21.po | 2 +- misc/translator/po/cy-GB-marc-NORMARC.po | 2 +- misc/translator/po/cy-GB-marc-UNIMARC.po | 50 +- misc/translator/po/cy-GB-opac-bootstrap.po | 328 +- misc/translator/po/cy-GB-pref.po | 10 +- misc/translator/po/cy-GB-staff-prog.po | 1546 +- misc/translator/po/da-DK-marc-MARC21.po | 2 +- misc/translator/po/da-DK-marc-NORMARC.po | 2 +- misc/translator/po/da-DK-marc-UNIMARC.po | 50 +- misc/translator/po/da-DK-opac-bootstrap.po | 328 +- misc/translator/po/da-DK-pref.po | 12 +- misc/translator/po/da-DK-staff-prog.po | 1563 +- misc/translator/po/de-CH-marc-MARC21.po | 2 +- misc/translator/po/de-CH-marc-NORMARC.po | 2 +- misc/translator/po/de-CH-marc-UNIMARC.po | 50 +- misc/translator/po/de-CH-opac-bootstrap.po | 328 +- misc/translator/po/de-CH-pref.po | 18 +- misc/translator/po/de-CH-staff-prog.po | 1574 +- misc/translator/po/de-DE-marc-MARC21.po | 8 +- misc/translator/po/de-DE-marc-NORMARC.po | 2 +- misc/translator/po/de-DE-marc-UNIMARC.po | 50 +- misc/translator/po/de-DE-opac-bootstrap.po | 338 +- misc/translator/po/de-DE-pref.po | 27 +- misc/translator/po/de-DE-staff-prog.po | 1593 +- misc/translator/po/dz-marc-MARC21.po | 2 +- misc/translator/po/dz-marc-NORMARC.po | 2 +- misc/translator/po/dz-marc-UNIMARC.po | 50 +- misc/translator/po/dz-opac-bootstrap.po | 328 +- misc/translator/po/dz-pref.po | 10 +- misc/translator/po/dz-staff-prog.po | 1546 +- misc/translator/po/el-GR-marc-MARC21.po | 2 +- misc/translator/po/el-GR-marc-NORMARC.po | 2 +- misc/translator/po/el-GR-marc-UNIMARC.po | 50 +- misc/translator/po/el-GR-opac-bootstrap.po | 340 +- misc/translator/po/el-GR-pref.po | 18 +- misc/translator/po/el-GR-staff-prog.po | 1589 +- misc/translator/po/en-GB-marc-MARC21.po | 2 +- misc/translator/po/en-GB-marc-NORMARC.po | 2 +- misc/translator/po/en-GB-marc-UNIMARC.po | 50 +- misc/translator/po/en-GB-opac-bootstrap.po | 328 +- misc/translator/po/en-GB-pref.po | 10 +- misc/translator/po/en-GB-staff-prog.po | 1576 +- misc/translator/po/en-NZ-marc-MARC21.po | 2 +- misc/translator/po/en-NZ-marc-NORMARC.po | 2 +- misc/translator/po/en-NZ-marc-UNIMARC.po | 50 +- misc/translator/po/en-NZ-opac-bootstrap.po | 328 +- misc/translator/po/en-NZ-pref.po | 18 +- misc/translator/po/en-NZ-staff-prog.po | 1574 +- misc/translator/po/eo-marc-MARC21.po | 2 +- misc/translator/po/eo-marc-NORMARC.po | 2 +- misc/translator/po/eo-marc-UNIMARC.po | 50 +- misc/translator/po/eo-opac-bootstrap.po | 328 +- misc/translator/po/eo-pref.po | 10 +- misc/translator/po/eo-staff-prog.po | 1579 +- misc/translator/po/es-ES-marc-MARC21.po | 2 +- misc/translator/po/es-ES-marc-NORMARC.po | 2 +- misc/translator/po/es-ES-marc-UNIMARC.po | 50 +- misc/translator/po/es-ES-opac-bootstrap.po | 332 +- misc/translator/po/es-ES-pref.po | 32 +- misc/translator/po/es-ES-staff-prog.po | 1597 +- misc/translator/po/eu-marc-MARC21.po | 2 +- misc/translator/po/eu-marc-NORMARC.po | 2 +- misc/translator/po/eu-marc-UNIMARC.po | 50 +- misc/translator/po/eu-opac-bootstrap.po | 328 +- misc/translator/po/eu-pref.po | 16 +- misc/translator/po/eu-staff-prog.po | 1586 +- misc/translator/po/fa-Arab-marc-MARC21.po | 2 +- misc/translator/po/fa-Arab-marc-NORMARC.po | 2 +- misc/translator/po/fa-Arab-marc-UNIMARC.po | 50 +- misc/translator/po/fa-Arab-opac-bootstrap.po | 328 +- misc/translator/po/fa-Arab-pref.po | 12 +- misc/translator/po/fa-Arab-staff-prog.po | 1566 +- misc/translator/po/fi-FI-marc-MARC21.po | 2 +- misc/translator/po/fi-FI-marc-NORMARC.po | 2 +- misc/translator/po/fi-FI-marc-UNIMARC.po | 50 +- misc/translator/po/fi-FI-opac-bootstrap.po | 328 +- misc/translator/po/fi-FI-pref.po | 18 +- misc/translator/po/fi-FI-staff-prog.po | 1574 +- misc/translator/po/fo-FO-marc-MARC21.po | 2 +- misc/translator/po/fo-FO-marc-NORMARC.po | 2 +- misc/translator/po/fo-FO-marc-UNIMARC.po | 50 +- misc/translator/po/fo-FO-opac-bootstrap.po | 328 +- misc/translator/po/fo-FO-pref.po | 10 +- misc/translator/po/fo-FO-staff-prog.po | 1546 +- misc/translator/po/fr-CA-marc-MARC21.po | 2 +- misc/translator/po/fr-CA-marc-NORMARC.po | 2 +- misc/translator/po/fr-CA-marc-UNIMARC.po | 50 +- misc/translator/po/fr-CA-opac-bootstrap.po | 328 +- misc/translator/po/fr-CA-pref.po | 31 +- misc/translator/po/fr-CA-staff-prog.po | 1593 +- misc/translator/po/fr-FR-marc-MARC21.po | 12 +- misc/translator/po/fr-FR-marc-NORMARC.po | 2 +- misc/translator/po/fr-FR-marc-UNIMARC.po | 60 +- misc/translator/po/fr-FR-opac-bootstrap.po | 338 +- misc/translator/po/fr-FR-pref.po | 32 +- misc/translator/po/fr-FR-staff-prog.po | 1629 +- misc/translator/po/ga-marc-MARC21.po | 2 +- misc/translator/po/ga-marc-NORMARC.po | 2 +- misc/translator/po/ga-marc-UNIMARC.po | 50 +- misc/translator/po/ga-opac-bootstrap.po | 328 +- misc/translator/po/ga-pref.po | 10 +- misc/translator/po/ga-staff-prog.po | 1546 +- misc/translator/po/gd-marc-MARC21.po | 2 +- misc/translator/po/gd-marc-NORMARC.po | 2 +- misc/translator/po/gd-marc-UNIMARC.po | 50 +- misc/translator/po/gd-opac-bootstrap.po | 328 +- misc/translator/po/gd-pref.po | 10 +- misc/translator/po/gd-staff-prog.po | 1546 +- misc/translator/po/gl-marc-MARC21.po | 2 +- misc/translator/po/gl-marc-NORMARC.po | 2 +- misc/translator/po/gl-marc-UNIMARC.po | 50 +- misc/translator/po/gl-opac-bootstrap.po | 328 +- misc/translator/po/gl-pref.po | 10 +- misc/translator/po/gl-staff-prog.po | 1565 +- misc/translator/po/he-Hebr-marc-MARC21.po | 2 +- misc/translator/po/he-Hebr-marc-NORMARC.po | 2 +- misc/translator/po/he-Hebr-marc-UNIMARC.po | 50 +- misc/translator/po/he-Hebr-opac-bootstrap.po | 328 +- misc/translator/po/he-Hebr-pref.po | 10 +- misc/translator/po/he-Hebr-staff-prog.po | 1569 +- misc/translator/po/hi-marc-MARC21.po | 2 +- misc/translator/po/hi-marc-NORMARC.po | 2 +- misc/translator/po/hi-marc-UNIMARC.po | 50 +- misc/translator/po/hi-opac-bootstrap.po | 331 +- misc/translator/po/hi-pref.po | 23 +- misc/translator/po/hi-staff-prog.po | 1616 +- misc/translator/po/hr-HR-marc-MARC21.po | 2 +- misc/translator/po/hr-HR-marc-NORMARC.po | 2 +- misc/translator/po/hr-HR-marc-UNIMARC.po | 50 +- misc/translator/po/hr-HR-opac-bootstrap.po | 328 +- misc/translator/po/hr-HR-pref.po | 10 +- misc/translator/po/hr-HR-staff-prog.po | 1563 +- misc/translator/po/hu-HU-marc-MARC21.po | 2 +- misc/translator/po/hu-HU-marc-NORMARC.po | 2 +- misc/translator/po/hu-HU-marc-UNIMARC.po | 50 +- misc/translator/po/hu-HU-opac-bootstrap.po | 463 +- misc/translator/po/hu-HU-pref.po | 10 +- misc/translator/po/hu-HU-staff-prog.po | 1606 +- misc/translator/po/hy-Armn-marc-MARC21.po | 2 +- misc/translator/po/hy-Armn-marc-NORMARC.po | 2 +- misc/translator/po/hy-Armn-marc-UNIMARC.po | 50 +- misc/translator/po/hy-Armn-opac-bootstrap.po | 328 +- misc/translator/po/hy-Armn-pref.po | 29 +- misc/translator/po/hy-Armn-staff-prog.po | 1595 +- misc/translator/po/ia-marc-MARC21.po | 2 +- misc/translator/po/ia-marc-NORMARC.po | 2 +- misc/translator/po/ia-marc-UNIMARC.po | 50 +- misc/translator/po/ia-opac-bootstrap.po | 328 +- misc/translator/po/ia-pref.po | 10 +- misc/translator/po/ia-staff-prog.po | 1546 +- misc/translator/po/id-ID-marc-MARC21.po | 2 +- misc/translator/po/id-ID-marc-NORMARC.po | 2 +- misc/translator/po/id-ID-marc-UNIMARC.po | 50 +- misc/translator/po/id-ID-opac-bootstrap.po | 328 +- misc/translator/po/id-ID-pref.po | 12 +- misc/translator/po/id-ID-staff-prog.po | 1577 +- misc/translator/po/iq-CA-marc-MARC21.po | 2 +- misc/translator/po/iq-CA-marc-NORMARC.po | 2 +- misc/translator/po/iq-CA-marc-UNIMARC.po | 50 +- misc/translator/po/iq-CA-opac-bootstrap.po | 328 +- misc/translator/po/iq-CA-pref.po | 10 +- misc/translator/po/iq-CA-staff-prog.po | 1546 +- misc/translator/po/is-IS-marc-MARC21.po | 2 +- misc/translator/po/is-IS-marc-NORMARC.po | 2 +- misc/translator/po/is-IS-marc-UNIMARC.po | 50 +- misc/translator/po/is-IS-opac-bootstrap.po | 328 +- misc/translator/po/is-IS-pref.po | 12 +- misc/translator/po/is-IS-staff-prog.po | 1561 +- misc/translator/po/it-IT-marc-MARC21.po | 2 +- misc/translator/po/it-IT-marc-NORMARC.po | 2 +- misc/translator/po/it-IT-marc-UNIMARC.po | 50 +- misc/translator/po/it-IT-opac-bootstrap.po | 328 +- misc/translator/po/it-IT-pref.po | 18 +- misc/translator/po/it-IT-staff-prog.po | 1573 +- misc/translator/po/iu-CA-marc-MARC21.po | 2 +- misc/translator/po/iu-CA-marc-NORMARC.po | 2 +- misc/translator/po/iu-CA-marc-UNIMARC.po | 50 +- misc/translator/po/iu-CA-opac-bootstrap.po | 328 +- misc/translator/po/iu-CA-pref.po | 10 +- misc/translator/po/iu-CA-staff-prog.po | 1546 +- misc/translator/po/ja-Jpan-JP-marc-MARC21.po | 2 +- misc/translator/po/ja-Jpan-JP-marc-NORMARC.po | 2 +- misc/translator/po/ja-Jpan-JP-marc-UNIMARC.po | 50 +- misc/translator/po/ja-Jpan-JP-opac-bootstrap.po | 328 +- misc/translator/po/ja-Jpan-JP-pref.po | 10 +- misc/translator/po/ja-Jpan-JP-staff-prog.po | 1570 +- misc/translator/po/ka-marc-MARC21.po | 40 +- misc/translator/po/ka-marc-NORMARC.po | 2 +- misc/translator/po/ka-marc-UNIMARC.po | 50 +- misc/translator/po/ka-messages.po | 30 +- misc/translator/po/ka-opac-bootstrap.po | 4616 ++--- misc/translator/po/ka-pref.po | 27 +- misc/translator/po/ka-staff-prog.po | 20221 +++++++++++----------- misc/translator/po/km-KH-marc-MARC21.po | 2 +- misc/translator/po/km-KH-marc-NORMARC.po | 2 +- misc/translator/po/km-KH-marc-UNIMARC.po | 50 +- misc/translator/po/km-KH-opac-bootstrap.po | 328 +- misc/translator/po/km-KH-pref.po | 10 +- misc/translator/po/km-KH-staff-prog.po | 1563 +- misc/translator/po/kn-Knda-marc-MARC21.po | 2 +- misc/translator/po/kn-Knda-marc-NORMARC.po | 2 +- misc/translator/po/kn-Knda-marc-UNIMARC.po | 50 +- misc/translator/po/kn-Knda-opac-bootstrap.po | 328 +- misc/translator/po/kn-Knda-pref.po | 10 +- misc/translator/po/kn-Knda-staff-prog.po | 1571 +- misc/translator/po/ko-Kore-KP-marc-MARC21.po | 2 +- misc/translator/po/ko-Kore-KP-marc-NORMARC.po | 2 +- misc/translator/po/ko-Kore-KP-marc-UNIMARC.po | 50 +- misc/translator/po/ko-Kore-KP-opac-bootstrap.po | 328 +- misc/translator/po/ko-Kore-KP-pref.po | 10 +- misc/translator/po/ko-Kore-KP-staff-prog.po | 1564 +- misc/translator/po/ku-Arab-marc-MARC21.po | 2 +- misc/translator/po/ku-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ku-Arab-marc-UNIMARC.po | 50 +- misc/translator/po/ku-Arab-opac-bootstrap.po | 328 +- misc/translator/po/ku-Arab-pref.po | 12 +- misc/translator/po/ku-Arab-staff-prog.po | 1563 +- misc/translator/po/lo-Laoo-marc-MARC21.po | 2 +- misc/translator/po/lo-Laoo-marc-NORMARC.po | 2 +- misc/translator/po/lo-Laoo-marc-UNIMARC.po | 50 +- misc/translator/po/lo-Laoo-opac-bootstrap.po | 328 +- misc/translator/po/lo-Laoo-pref.po | 10 +- misc/translator/po/lo-Laoo-staff-prog.po | 1569 +- misc/translator/po/lv-marc-MARC21.po | 2 +- misc/translator/po/lv-marc-NORMARC.po | 2 +- misc/translator/po/lv-marc-UNIMARC.po | 50 +- misc/translator/po/lv-opac-bootstrap.po | 328 +- misc/translator/po/lv-pref.po | 10 +- misc/translator/po/lv-staff-prog.po | 1546 +- misc/translator/po/mi-NZ-marc-MARC21.po | 2 +- misc/translator/po/mi-NZ-marc-NORMARC.po | 2 +- misc/translator/po/mi-NZ-marc-UNIMARC.po | 50 +- misc/translator/po/mi-NZ-opac-bootstrap.po | 328 +- misc/translator/po/mi-NZ-pref.po | 10 +- misc/translator/po/mi-NZ-staff-prog.po | 1561 +- misc/translator/po/ml-marc-MARC21.po | 2 +- misc/translator/po/ml-marc-NORMARC.po | 2 +- misc/translator/po/ml-marc-UNIMARC.po | 50 +- misc/translator/po/ml-opac-bootstrap.po | 328 +- misc/translator/po/ml-pref.po | 10 +- misc/translator/po/ml-staff-prog.po | 1546 +- misc/translator/po/mon-marc-MARC21.po | 2 +- misc/translator/po/mon-marc-NORMARC.po | 2 +- misc/translator/po/mon-marc-UNIMARC.po | 50 +- misc/translator/po/mon-opac-bootstrap.po | 328 +- misc/translator/po/mon-pref.po | 10 +- misc/translator/po/mon-staff-prog.po | 1549 +- misc/translator/po/mr-marc-MARC21.po | 2 +- misc/translator/po/mr-marc-NORMARC.po | 2 +- misc/translator/po/mr-marc-UNIMARC.po | 50 +- misc/translator/po/mr-opac-bootstrap.po | 328 +- misc/translator/po/mr-pref.po | 10 +- misc/translator/po/mr-staff-prog.po | 1573 +- misc/translator/po/ms-MY-marc-MARC21.po | 2 +- misc/translator/po/ms-MY-marc-NORMARC.po | 2 +- misc/translator/po/ms-MY-marc-UNIMARC.po | 50 +- misc/translator/po/ms-MY-opac-bootstrap.po | 328 +- misc/translator/po/ms-MY-pref.po | 10 +- misc/translator/po/ms-MY-staff-prog.po | 1603 +- misc/translator/po/my-marc-MARC21.po | 2 +- misc/translator/po/my-marc-NORMARC.po | 2 +- misc/translator/po/my-marc-UNIMARC.po | 50 +- misc/translator/po/my-opac-bootstrap.po | 328 +- misc/translator/po/my-pref.po | 10 +- misc/translator/po/my-staff-prog.po | 1546 +- misc/translator/po/nb-NO-marc-MARC21.po | 2 +- misc/translator/po/nb-NO-marc-NORMARC.po | 2 +- misc/translator/po/nb-NO-marc-UNIMARC.po | 50 +- misc/translator/po/nb-NO-opac-bootstrap.po | 328 +- misc/translator/po/nb-NO-pref.po | 18 +- misc/translator/po/nb-NO-staff-prog.po | 1573 +- misc/translator/po/ne-NE-marc-MARC21.po | 2 +- misc/translator/po/ne-NE-marc-NORMARC.po | 2 +- misc/translator/po/ne-NE-marc-UNIMARC.po | 50 +- misc/translator/po/ne-NE-opac-bootstrap.po | 328 +- misc/translator/po/ne-NE-pref.po | 10 +- misc/translator/po/ne-NE-staff-prog.po | 1575 +- misc/translator/po/nl-BE-marc-MARC21.po | 2 +- misc/translator/po/nl-BE-marc-NORMARC.po | 2 +- misc/translator/po/nl-BE-marc-UNIMARC.po | 50 +- misc/translator/po/nl-BE-opac-bootstrap.po | 328 +- misc/translator/po/nl-BE-pref.po | 12 +- misc/translator/po/nl-BE-staff-prog.po | 1571 +- misc/translator/po/nl-NL-marc-MARC21.po | 2 +- misc/translator/po/nl-NL-marc-NORMARC.po | 2 +- misc/translator/po/nl-NL-marc-UNIMARC.po | 50 +- misc/translator/po/nl-NL-opac-bootstrap.po | 349 +- misc/translator/po/nl-NL-pref.po | 10 +- misc/translator/po/nl-NL-staff-prog.po | 1587 +- misc/translator/po/nn-NO-marc-MARC21.po | 2 +- misc/translator/po/nn-NO-marc-NORMARC.po | 2 +- misc/translator/po/nn-NO-marc-UNIMARC.po | 50 +- misc/translator/po/nn-NO-opac-bootstrap.po | 328 +- misc/translator/po/nn-NO-pref.po | 10 +- misc/translator/po/nn-NO-staff-prog.po | 1551 +- misc/translator/po/oc-marc-MARC21.po | 2 +- misc/translator/po/oc-marc-NORMARC.po | 2 +- misc/translator/po/oc-marc-UNIMARC.po | 50 +- misc/translator/po/oc-opac-bootstrap.po | 328 +- misc/translator/po/oc-pref.po | 12 +- misc/translator/po/oc-staff-prog.po | 1571 +- misc/translator/po/pbr-marc-MARC21.po | 2 +- misc/translator/po/pbr-marc-NORMARC.po | 2 +- misc/translator/po/pbr-marc-UNIMARC.po | 50 +- misc/translator/po/pbr-opac-bootstrap.po | 328 +- misc/translator/po/pbr-pref.po | 10 +- misc/translator/po/pbr-staff-prog.po | 1567 +- misc/translator/po/pl-PL-marc-MARC21.po | 2 +- misc/translator/po/pl-PL-marc-NORMARC.po | 2 +- misc/translator/po/pl-PL-marc-UNIMARC.po | 50 +- misc/translator/po/pl-PL-opac-bootstrap.po | 328 +- misc/translator/po/pl-PL-pref.po | 18 +- misc/translator/po/pl-PL-staff-prog.po | 1573 +- misc/translator/po/prs-marc-MARC21.po | 2 +- misc/translator/po/prs-marc-NORMARC.po | 2 +- misc/translator/po/prs-marc-UNIMARC.po | 50 +- misc/translator/po/prs-opac-bootstrap.po | 328 +- misc/translator/po/prs-pref.po | 10 +- misc/translator/po/prs-staff-prog.po | 1569 +- misc/translator/po/pt-BR-marc-MARC21.po | 2 +- misc/translator/po/pt-BR-marc-NORMARC.po | 2 +- misc/translator/po/pt-BR-marc-UNIMARC.po | 50 +- misc/translator/po/pt-BR-opac-bootstrap.po | 328 +- misc/translator/po/pt-BR-pref.po | 18 +- misc/translator/po/pt-BR-staff-prog.po | 1582 +- misc/translator/po/pt-PT-marc-MARC21.po | 2 +- misc/translator/po/pt-PT-marc-NORMARC.po | 2 +- misc/translator/po/pt-PT-marc-UNIMARC.po | 50 +- misc/translator/po/pt-PT-opac-bootstrap.po | 340 +- misc/translator/po/pt-PT-pref.po | 21 +- misc/translator/po/pt-PT-staff-prog.po | 1599 +- misc/translator/po/ro-RO-marc-MARC21.po | 2 +- misc/translator/po/ro-RO-marc-NORMARC.po | 2 +- misc/translator/po/ro-RO-marc-UNIMARC.po | 50 +- misc/translator/po/ro-RO-opac-bootstrap.po | 328 +- misc/translator/po/ro-RO-pref.po | 10 +- misc/translator/po/ro-RO-staff-prog.po | 1561 +- misc/translator/po/ru-RU-marc-MARC21.po | 2 +- misc/translator/po/ru-RU-marc-NORMARC.po | 2 +- misc/translator/po/ru-RU-marc-UNIMARC.po | 50 +- misc/translator/po/ru-RU-opac-bootstrap.po | 328 +- misc/translator/po/ru-RU-pref.po | 10 +- misc/translator/po/ru-RU-staff-prog.po | 1568 +- misc/translator/po/rw-RW-marc-MARC21.po | 2 +- misc/translator/po/rw-RW-marc-NORMARC.po | 2 +- misc/translator/po/rw-RW-marc-UNIMARC.po | 50 +- misc/translator/po/rw-RW-opac-bootstrap.po | 328 +- misc/translator/po/rw-RW-pref.po | 10 +- misc/translator/po/rw-RW-staff-prog.po | 1546 +- misc/translator/po/sd-PK-marc-MARC21.po | 2 +- misc/translator/po/sd-PK-marc-NORMARC.po | 2 +- misc/translator/po/sd-PK-marc-UNIMARC.po | 50 +- misc/translator/po/sd-PK-opac-bootstrap.po | 328 +- misc/translator/po/sd-PK-pref.po | 10 +- misc/translator/po/sd-PK-staff-prog.po | 1576 +- misc/translator/po/sk-SK-marc-MARC21.po | 718 +- misc/translator/po/sk-SK-marc-NORMARC.po | 2 +- misc/translator/po/sk-SK-marc-UNIMARC.po | 64 +- misc/translator/po/sk-SK-opac-bootstrap.po | 361 +- misc/translator/po/sk-SK-pref.po | 18 +- misc/translator/po/sk-SK-staff-prog.po | 1720 +- misc/translator/po/sl-SI-marc-MARC21.po | 2 +- misc/translator/po/sl-SI-marc-NORMARC.po | 2 +- misc/translator/po/sl-SI-marc-UNIMARC.po | 50 +- misc/translator/po/sl-SI-opac-bootstrap.po | 328 +- misc/translator/po/sl-SI-pref.po | 10 +- misc/translator/po/sl-SI-staff-prog.po | 1546 +- misc/translator/po/sq-AL-marc-MARC21.po | 2 +- misc/translator/po/sq-AL-marc-NORMARC.po | 2 +- misc/translator/po/sq-AL-marc-UNIMARC.po | 50 +- misc/translator/po/sq-AL-opac-bootstrap.po | 328 +- misc/translator/po/sq-AL-pref.po | 10 +- misc/translator/po/sq-AL-staff-prog.po | 1579 +- misc/translator/po/sr-Cyrl-marc-MARC21.po | 2 +- misc/translator/po/sr-Cyrl-marc-NORMARC.po | 2 +- misc/translator/po/sr-Cyrl-marc-UNIMARC.po | 50 +- misc/translator/po/sr-Cyrl-opac-bootstrap.po | 328 +- misc/translator/po/sr-Cyrl-pref.po | 10 +- misc/translator/po/sr-Cyrl-staff-prog.po | 1577 +- misc/translator/po/sv-SE-marc-MARC21.po | 2 +- misc/translator/po/sv-SE-marc-NORMARC.po | 2 +- misc/translator/po/sv-SE-marc-UNIMARC.po | 50 +- misc/translator/po/sv-SE-opac-bootstrap.po | 332 +- misc/translator/po/sv-SE-pref.po | 28 +- misc/translator/po/sv-SE-staff-prog.po | 1586 +- misc/translator/po/sw-KE-marc-MARC21.po | 2 +- misc/translator/po/sw-KE-marc-NORMARC.po | 2 +- misc/translator/po/sw-KE-marc-UNIMARC.po | 50 +- misc/translator/po/sw-KE-opac-bootstrap.po | 328 +- misc/translator/po/sw-KE-pref.po | 10 +- misc/translator/po/sw-KE-staff-prog.po | 1546 +- misc/translator/po/ta-LK-marc-MARC21.po | 2 +- misc/translator/po/ta-LK-marc-NORMARC.po | 2 +- misc/translator/po/ta-LK-marc-UNIMARC.po | 50 +- misc/translator/po/ta-LK-opac-bootstrap.po | 328 +- misc/translator/po/ta-LK-pref.po | 10 +- misc/translator/po/ta-LK-staff-prog.po | 1567 +- misc/translator/po/ta-marc-MARC21.po | 2 +- misc/translator/po/ta-marc-NORMARC.po | 2 +- misc/translator/po/ta-marc-UNIMARC.po | 50 +- misc/translator/po/ta-opac-bootstrap.po | 328 +- misc/translator/po/ta-pref.po | 10 +- misc/translator/po/ta-staff-prog.po | 1567 +- misc/translator/po/tet-marc-MARC21.po | 2 +- misc/translator/po/tet-marc-NORMARC.po | 2 +- misc/translator/po/tet-marc-UNIMARC.po | 50 +- misc/translator/po/tet-opac-bootstrap.po | 328 +- misc/translator/po/tet-pref.po | 10 +- misc/translator/po/tet-staff-prog.po | 1573 +- misc/translator/po/th-TH-marc-MARC21.po | 2 +- misc/translator/po/th-TH-marc-NORMARC.po | 2 +- misc/translator/po/th-TH-marc-UNIMARC.po | 50 +- misc/translator/po/th-TH-opac-bootstrap.po | 328 +- misc/translator/po/th-TH-pref.po | 10 +- misc/translator/po/th-TH-staff-prog.po | 1577 +- misc/translator/po/tl-PH-marc-MARC21.po | 2 +- misc/translator/po/tl-PH-marc-NORMARC.po | 2 +- misc/translator/po/tl-PH-marc-UNIMARC.po | 50 +- misc/translator/po/tl-PH-opac-bootstrap.po | 328 +- misc/translator/po/tl-PH-pref.po | 10 +- misc/translator/po/tl-PH-staff-prog.po | 1579 +- misc/translator/po/tr-TR-marc-MARC21.po | 2 +- misc/translator/po/tr-TR-marc-NORMARC.po | 2 +- misc/translator/po/tr-TR-marc-UNIMARC.po | 50 +- misc/translator/po/tr-TR-opac-bootstrap.po | 338 +- misc/translator/po/tr-TR-pref.po | 62 +- misc/translator/po/tr-TR-staff-prog.po | 1965 ++- misc/translator/po/tvl-marc-MARC21.po | 2 +- misc/translator/po/tvl-marc-NORMARC.po | 2 +- misc/translator/po/tvl-marc-UNIMARC.po | 50 +- misc/translator/po/tvl-opac-bootstrap.po | 328 +- misc/translator/po/tvl-pref.po | 10 +- misc/translator/po/tvl-staff-prog.po | 1546 +- misc/translator/po/uk-UA-marc-MARC21.po | 2 +- misc/translator/po/uk-UA-marc-NORMARC.po | 2 +- misc/translator/po/uk-UA-marc-UNIMARC.po | 50 +- misc/translator/po/uk-UA-opac-bootstrap.po | 336 +- misc/translator/po/uk-UA-pref.po | 12 +- misc/translator/po/uk-UA-staff-prog.po | 1592 +- misc/translator/po/ur-Arab-marc-MARC21.po | 2 +- misc/translator/po/ur-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ur-Arab-marc-UNIMARC.po | 50 +- misc/translator/po/ur-Arab-opac-bootstrap.po | 328 +- misc/translator/po/ur-Arab-pref.po | 10 +- misc/translator/po/ur-Arab-staff-prog.po | 1567 +- misc/translator/po/vi-VN-marc-MARC21.po | 2 +- misc/translator/po/vi-VN-marc-NORMARC.po | 2 +- misc/translator/po/vi-VN-marc-UNIMARC.po | 50 +- misc/translator/po/vi-VN-opac-bootstrap.po | 328 +- misc/translator/po/vi-VN-pref.po | 12 +- misc/translator/po/vi-VN-staff-prog.po | 1568 +- misc/translator/po/zh-Hans-CN-marc-MARC21.po | 2 +- misc/translator/po/zh-Hans-CN-marc-NORMARC.po | 2 +- misc/translator/po/zh-Hans-CN-marc-UNIMARC.po | 50 +- misc/translator/po/zh-Hans-CN-opac-bootstrap.po | 328 +- misc/translator/po/zh-Hans-CN-pref.po | 12 +- misc/translator/po/zh-Hans-CN-staff-prog.po | 1570 +- misc/translator/po/zh-Hant-TW-marc-MARC21.po | 2 +- misc/translator/po/zh-Hant-TW-marc-NORMARC.po | 2 +- misc/translator/po/zh-Hant-TW-marc-UNIMARC.po | 56 +- misc/translator/po/zh-Hant-TW-opac-bootstrap.po | 342 +- misc/translator/po/zh-Hant-TW-pref.po | 46 +- misc/translator/po/zh-Hant-TW-staff-prog.po | 1657 +- 519 files changed, 103727 insertions(+), 90084 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Apr 23 00:08:41 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 22 Apr 2020 22:08:41 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-97-g9cfe6e2c3f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 9cfe6e2c3ff2177e2162dfe8ea4d6cca2f7a03c2 (commit) from bdcca930f7b02c9141e8c0634d56713c89290fa8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9cfe6e2c3ff2177e2162dfe8ea4d6cca2f7a03c2 Author: Lucas Gass Date: Wed Apr 22 21:41:30 2020 +0000 Update release notes for 19.05.10 release Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: misc/release_notes/release_notes_19_05_10.html | 604 +++++++++++++++++++++++++ misc/release_notes/release_notes_19_05_10.md | 479 ++++++++++++++++++++ 2 files changed, 1083 insertions(+) create mode 100644 misc/release_notes/release_notes_19_05_10.html create mode 100644 misc/release_notes/release_notes_19_05_10.md hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Apr 23 00:11:23 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 22 Apr 2020 22:11:23 +0000 Subject: [koha-commits] main Koha release repository annotated tag v19.05.10 created. v19.05.10 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The annotated tag, v19.05.10 has been created at 7a2211b85deef98bb1cfbd7e6466472b785a6409 (tag) tagging 9cfe6e2c3ff2177e2162dfe8ea4d6cca2f7a03c2 (commit) replaces v19.05.09 tagged by Lucas Gass on Wed Apr 22 21:44:03 2020 +0000 - Log ----------------------------------------------------------------- Koha release 19.05.10 -----BEGIN PGP SIGNATURE----- iQHPBAABCAA5FiEEmDLvgv/UXWe3ovoFvMrYC6dhTX8FAl6guqMbHGx1Y2FzQGJ5 d2F0ZXJzb2x1dGlvbnMuY29tAAoJELzK2AunYU1/dtUMAKwvAOH4yynxD2BtUfjG zXyx6SJIA8DeROvFZjYBRfruHMpb2TI0yXrqVelps1C/7i8hsHffAEfnhHY4+lbH 8AoOtZGaDhijAPam8MYWvWPiKQi5TwpMed1a3QZ7fwM20f3zYL3RDmwDmKpjxULq c4jAcFCtSJTQM4zovUNsfM7idEl5MLpS87CYaIFh32px64nl8+W4kOOWbcRqJYxL L4ufuXlSctLsFCRl1oa1mOLTv5khE6h1ta4iVo8qn8gtaFXJEZ9fGoE2aAuH3pAU fVVT+mxyEQS388t4Qf82TugOKyV1kQ/3V+Vh+jGd6oJzjDvCgQVQfpD/ZkO1T3JN 4xFfvEBlECVwqQ6Oo65iiJFiX2/eyeJA/HTWKtP9f7VoYoap9xYDANc7xuceW3V3 D4DJXPMyq8YLXySfADI9BTeVXk7Rfr12cviwgsGoIogrEdFUdZTK9egmyIsY/zP0 QA52v5Noe1iQUH2kl4cT1SmtL3wUVcAKKvJ4Da63jDYzpA== =VZiE -----END PGP SIGNATURE----- Aleisha Amohia (5): Bug 5103: Format dates in MARC detail using dateformat syspref Bug 5103: (follow-up) Using mapped item fields instead of hardcoding subfields Bug 8595: Rename 'host item' to 'host record' Bug 8595: (follow-up) Changing other occurrences of 'host item' to 'host record' Bug 24688: Check the priority of the fulfilled hold when fixing priorities Andrew Fuerste-Henry (2): Bug 24747: Corrects on-screen instructions in branch transfer limits Bug 24838: Fix help link for patron categories Andrew Isherwood (2): Bug 24565: Add patron profile to ILL list pages Bug 24518: Fix IE11 partner filtering Bernardo González Kriegel (2): Bug 24870: Translate installer data label Bug 24872: Set languages prefererences after install Caroline Cyr La Rose (1): Bug 23236: Remove 'its items may still be processed' in action if no match is found David Cook (2): Bug 17464: Order deny,allow / Deny from all was deprecated in Apache 2.4 and is now a hard error Bug 24719: Remove use of CGI object in C4::Context::set_remote_address() David Gustafsson (1): Bug 24788: Remove autoloaded column accessors in Koha::Object->store Fridolin Somers (11): Bug 23968: fix OPACMySummaryNote feature Bug 23968: Add div this id around OPACMySummaryNote content Bug 24527: misc/cronjobs/update_totalissues.pl problem with multiple items Bug 22969: fix biblionumber on 001 in UNIMARC XSLT Bug 19008: More database cleanups - statistics Bug 19008: More database cleanups - deleted catalog Bug 19008: More database cleanups - deleted patrons Bug 19008: More database cleanups - old issues Bug 19008: More database cleanups - old reserves Bug 19008: More database cleanups - item transfers Bug 23383: fix IdRef syspref test in XSLT Hayley Mapley (1): Bug 22943: Renames the in_ipset function to in_iprange in C4::Auth Jonathan Druart (21): Bug 24682: Make UsageStatsGeolocation readonly (and redirect to the config page) Bug 24114: Remove warn statements from Koha::Patrons Bug 24294: Add default value support for control fields in ACQ framework Bug 17532: Make koha-shell propagate the error code Bug 24813: Prevent api/v1/holds.t to fail randomly Bug 23384: Fix use statement order for ArticleRequest::Status Bug 19008: Replace issues with checkouts in print statement Bug 5103: Refactor the code to avoid repetition Bug 24851: Insert libraries sample data for "UNIMARC" Bug 24851: Translate the .txt in French Bug 24200: Try to fix random failures from Borrower_PrevCheckout.t Bug 24200: (follow-up) Try to fix random failures from Borrower_PrevCheckout.t Bug 25020: Preserve time part when batch extending due dates Bug 24856: Remove itemtypes.imageurl in fr-FR sample data Bug 23900: Teach label maker to concat database fields Bug 23900: Add tests Bug 24250: Do not duplicate debarred comment in patron screen message AF field Bug 24614: Add tests Bug 24614: Use Koha::Reports from save_report and update_sql Bug 24614: Fix Reports/Guided.t Bug 25142: Fix wrong grep logical test Julian Maurice (2): Bug 24552: Be compatible with Search::Elasticsearch 6.00 Bug 24760: Use C4::BackgroundJob->fetch in tests Katrin Fischer (4): Bug 24605: (QA follow-up) Fix unencoded series link in staff interface Bug 22943: Remove unused line from Auth.t Bug 24848: Improve manual links for the label creator Bug 24875: Remove extra punctuation from tools start page Koha translators (1): Translation updates for Koha 19.05.10 Kyle M Hall (1): Bug 24566: UpdateItemLocationOnCheckin triggers SIP2 alert flag, even with checked_in_ok enabled Liz Rea (1): Bug 24324: Resolve error with delete_records_via_leader.pl Lucas Gass (7): Revert "Bug 24719: Remove use of CGI object in C4::Context::set_remote_address()" Bug 24858: Correct labels on wording in ExcludeHolidaysFromMaxPickUpDelay Bug 24456: change default sort orders/make wording clearer Bug 24874: Compile CSS Revert "Bug 24858: Correct labels on wording in ExcludeHolidaysFromMaxPickUpDelay" Increment version for 19.05.10 release Update release notes for 19.05.10 release Magnus Enger (1): Bug 19008: More database cleanups - QA followup Marcel de Rooy (10): Bug 24114: (follow-up) Resolve warning on non-numeric subtraction Bug 24114: (QA follow-up) Fix counts for lock, anonymize and delete Bug 24809: (QA follow-up) Add prefix to prevent disambiguity Bug 24294: (QA follow-up) Add rollback and 008 default test Bug 24760: (follow-up) Add a neighboring test messsage Bug 24756: [19.11.X] Catch two failed to load-variations in Security.t Bug 24892: Resolve uninitialized warns from opac-memberentry Bug 21708: Add a few tests in TransformHtmlToMarc.t Bug 21708: Sort MARC fields in TransformHtmlToMarc Bug 16922: Add RewriteRule to apache-shared-intranet for dev package installs Martin Renvoize (1): Bug 22943: (QA follow-up) Add new cases Maryse Simard (2): Bug 23488: Line wrapping doesn't always respect word order in Patron card creator Bug 7882: Add ability to move and reorder fields in MARC editor Mason James (1): Bug 24874: Printing is broken on opac-results.pl page (19.11.x) Nazlı Çetin (2): Bug 21879: Code cleaning in printinvoice.pl Bug 25000: SQL report not updated Nick Clemens (11): Bug 24711: Don't add logout input to login form Bug 24809: Get only timestamp of deleted items attached to existing bibs when check if bib deleted Bug 24605: Fix unencoded series link Bug 24732: Set DumpTemplateVars Dumper options for Indent and Sort Bug 24733: created_by param should be an arrayref Bug 19288: Don't show patron info for item level holds on details.pl unless hold is waiting Bug 24789: Remove ITS macro format Bug 24789: [follow-up] Fix saving of macros Bug 23411: Do not fall back to 'email' for SMS messages Bug 24386: Prevent double form submission on adding orders to basket from a file Bug 25144: [19.05.x only] Remove subtitle from query Owen Leonard (4): Bug 23753: Add missing humanMsg library to pages using background job JavaScript Bug 24798: smart-rules.tt has erroneous comments Bug 7882: (follow-up) Update sorting interaction Bug 7882: (follow-up) Only show sortable icon for sortable tags Tomás Cohen Arazi (1): Bug 25009: Avoid leakages in opac-showmarc.pl ----------------------------------------------------------------------- hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Apr 23 00:53:27 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 22 Apr 2020 22:53:27 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.16-1-gb0015b1e31 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via b0015b1e315c2eceb343308755e767cda844b7ff (commit) from eb3d1f373ddff4e209a13c3e3a4a06cd3bf118ba (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b0015b1e315c2eceb343308755e767cda844b7ff Author: Jonathan Druart Date: Wed Apr 22 15:06:16 2020 +0200 Bug 25009: [18.11.x] Add missing biblio_metadata stuffs It adds methods, DBIC rs and Exceptions class for biblio metadata. Note that schema is marcflavour in 18.11 Signed-off-by: Hayley Mapley ----------------------------------------------------------------------- Summary of changes: Koha/Biblio.pm | 16 ++++++++++ Koha/Biblio/Metadata.pm | 53 ++++++++++++++++++++++++++++++++++ Koha/Exceptions/Metadata.pm | 69 ++++++++++++++++++++++++++++++++++++++++++++ Koha/Schema/Result/Biblio.pm | 7 +++++ 4 files changed, 145 insertions(+) create mode 100644 Koha/Exceptions/Metadata.pm hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Apr 23 00:55:51 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 22 Apr 2020 22:55:51 +0000 Subject: [koha-commits] main Koha release repository annotated tag v18.11.16 deleted. v18.11.15-30-geb3d1f373d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The annotated tag, v18.11.16 has been deleted was 6c2f5eb9d7e4dbcb1172246c8937b15041c9358e - Log ----------------------------------------------------------------- eb3d1f373ddff4e209a13c3e3a4a06cd3bf118ba Update release notes for 18.11.16 release ----------------------------------------------------------------------- hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Apr 23 00:57:27 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 22 Apr 2020 22:57:27 +0000 Subject: [koha-commits] main Koha release repository annotated tag v18.11.16 created. v18.11.16 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The annotated tag, v18.11.16 has been created at b290f3eac8c05b1f6ebb0e2fa98e6ed8aa5fcac3 (tag) tagging b0015b1e315c2eceb343308755e767cda844b7ff (commit) replaces v18.11.15 tagged by Hayley Mapley on Thu Apr 23 10:30:14 2020 +1200 - Log ----------------------------------------------------------------- Koha release 18.11.16 -----BEGIN PGP SIGNATURE----- iQJRBAABCgA7FiEEeUrTaBok6eOiWqnEKxuPgpNerlQFAl6gxXYdHGhheWxleW1h cGxleUBjYXRhbHlzdC5uZXQubnoACgkQKxuPgpNerlQH7Q/9Go2FJHfm/NoU89ZF 2psJ6T4n+L2wRW5KZPdOtjUE8h1UeQlW/Zc5sN7r/QcJ3270rZiViMvfI7yh7MGT g6PfbKv2/hIqUgp94Ha9/nEzYNrlHgbmP5ngKnneOAG9pXnh2WmgZGltYvewqMXI L+VZc3zEMVLJoBk8TTaoPHlkOvBN8dwlG/o4InDMVIrPPYusaMkSi81c3i7FAFVm 5sFhpb5nZ7mdtlBvwa+ZgPH0Bnj4B+RxyhBoUGyvzb1iMPZDpQ6guywVN9Z238Xe PFqBLotAax8WDcHIkIp+eO8Gbe5moEwWFM/xNrJbfiBuI35wnF0fc2b0BPXoUNWP Aqq79945eQG1WVMELTEQiwJ+sDnbDmuH376gB18RHv9aN+WeKMBwQVZ9a0uDAEfV 5DccKasfu5B+5vyd7bLvkka9dAgZgjJtpHOXEEFBmZhaERYS0Cgn4nHLjGjg/wFx eyh9zNQgit7b7///R0LnS7kQvAiZH6Lk/TOo+pTQCBWUTAaIrxcj7OLBVophQLPh TZFyB1EaishdMlbLFmtd+r1dMjZ2cyfQnkZc/k3aW6Itu7KwSCGAKL5YYlKwjcTs fy3Y29C3CbG01oSJXySz0Xn4J6vdJZ8YSkXugsAmeqG2GvD7qAjoHptw8J1zggG3 f3DucqoG19T4hnrRdsToKOJ2Z6g= =StQS -----END PGP SIGNATURE----- Aleisha Amohia (1): Bug 24688: Check the priority of the fulfilled hold when fixing priorities Andrew Fuerste-Henry (2): Bug 24747: Corrects on-screen instructions in branch transfer limits Bug 24838: Fix help link for patron categories Bernardo González Kriegel (1): Bug 24870: Translate installer data label David Cook (1): Bug 17464: Order deny,allow / Deny from all was deprecated in Apache 2.4 and is now a hard error Fridolin Somers (3): Bug 23968: fix OPACMySummaryNote feature Bug 23968: Add div this id around OPACMySummaryNote content Bug 24527: misc/cronjobs/update_totalissues.pl problem with multiple items Hayley Mapley (4): Bug 24846: DBRev 18.11.15.001 Bug 24673 (18.11.x U18 follow-up): Fixing t/db_dependent/Koha/XSLT/Security.t Increment version for 18.11.16 release Update release notes for 18.11.16 release Jonathan Druart (8): Bug 24846: Add new permission batch_extend_due_dates Bug 24846: Link to the new tool Bug 24846: Add new tool to batch extend due dates Bug 24846: Update items.onloan with the new due date Bug 24813: Prevent api/v1/holds.t to fail randomly Bug 25020: Preserve time part when batch extending due dates Bug 25142: Fix wrong grep logical test Bug 25009: [18.11.x] Add missing biblio_metadata stuffs Katrin Fischer (1): Bug 24605: (QA follow-up) Fix unencoded series link in staff interface Koha translators (1): Translation updates for Koha 18.11.16 Liz Rea (1): Bug 24324: Resolve error with delete_records_via_leader.pl Marcel de Rooy (2): Bug 24809: (QA follow-up) Add prefix to prevent disambiguity Bug 16922: Add RewriteRule to apache-shared-intranet for dev package installs Nick Clemens (4): Bug 24711: Don't add logout input to login form Bug 24809: Get only timestamp of deleted items attached to existing bibs when check if bib deleted Bug 24605: Fix unencoded series link Bug 24733: created_by param should be an arrayref Owen Leonard (1): Bug 24798: smart-rules.tt has erroneous comments Tomás Cohen Arazi (1): Bug 25009: Avoid leakages in opac-showmarc.pl ----------------------------------------------------------------------- hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 27 12:13:15 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 27 Apr 2020 10:13:15 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1867-gca5b112376 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via ca5b112376f8b74d573f8b8d6c1512a59040ba60 (commit) via 4452036d1c100910c17a7ac7ac54cb83c0120620 (commit) via 95dc574501a331e603cbe385fa4e5f70dc1c5ef2 (commit) from b50d891c099d0f21f2528c5a6d5bbb586cf1612e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ca5b112376f8b74d573f8b8d6c1512a59040ba60 Author: Jonathan Druart Date: Tue Apr 14 13:22:44 2020 +0200 Bug 25142: Fix wrong grep logical test To test and understand what's going on, you can try that bit of code: my @a = qw( a b c a); my @b = qw( b c d ); my @c; @c = grep { 'a' eq $_ } @a ? 'ok' : (); say @c; @c = ( grep { 'a' eq $_ } @a ) ? 'ok' : (); say @c; @c = grep { 'a' eq $_ } @a ? ('ok') : (undef); say @c; The problem here: Have patrons in 3 branches CPL, MPL, SPL Have a non superlibrarian with edit_borrowers permission but without view_borrower_infos_from_any_libraries, from CPL Create a library group with CPL, MPL Use that non superlibrarian to search for patrons You can search for patrons fro CPL and MPL BUT, edit the value for CPL, use SPL (edit the DOM) Search and... oops Apply this patch, try again Also use a superlibrarian patron (and/or with view_borrower_infos_from_any_libraries) and confirm that they can see all patrons Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 4452036d1c100910c17a7ac7ac54cb83c0120620 Author: Tomas Cohen Arazi Date: Fri Mar 27 18:16:58 2020 -0300 Bug 25009: Avoid leakages in opac-showmarc.pl This patch cleans opac-showmarc.pl so it doesn't allow retrieving records from import batches without requiring any permissions in the OPAC. it does so by just removing the code portion that does that. It also cleans the record fetch operation and how the record processor is initialized to it actually works :-D To test: 1. Perform a successful Z39.50 search in cataloguing (this fetches 20 records usually) 2. Query your DB for a valid import_record_id: $ koha-mysql kohadev > SELECT * FROM import_records LIMIT 1; 3. Notice some of the MARCXML details (title, author, etc), and the import_record_id 4. Point your browser to the opac-showmarc.pl URL like this: http://kohadev.mydnsname.org:8080/cgi-bin/koha/opac-showmarc.pl?importid=20 => FAIL: You get the record! (Bonus: no field/subfield takes place) 5. Hide some obvious subfield on the framework for a known (to you) biblionumber 6. Point your browser to: http://kohadev.mydnsname.org:8080/cgi-bin/koha/opac-showmarc.pl?id= => FAIL: No filtering takes place 7. Apply this patch 8. Repeat 4 => SUCCESS: You get an error because you did a bad request (no id param) 9. Repeat 6 => SUCCESS: Subfield filtering actually works! 10. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 95dc574501a331e603cbe385fa4e5f70dc1c5ef2 Author: Marcel de Rooy Date: Thu Jul 14 13:51:21 2016 +0200 Bug 16922: Add RewriteRule to apache-shared-intranet for dev package installs As a simple alternative to the solution in bug 9949 or just as an additional measure, this patch adds a rewrite rule for intranet in order to intercept potential misuse of perl scripts that could be reached on a dev package install via the cgi-bin/koha scriptalias. It simply rewrites them to the nonexistent "notfound", resulting in a regular 404 error. The rewrite rule does not harm regular installs and is just a little extra step in securing a dev install. You should have more security measures in place to secure your staff client. QA Note: Although a rewrite rule may not be our first choice, this one rule is more elegant and easier to maintain than e.g. a whole bunch of aliases. Note: This patch should have a regular and a dev install signoff. Test plan: [1] Make sure that this rewrite rule is inserted in your actual apache config via /etc/koha/apache-shared-intranet.conf. Restart Apache. [2] For regular package installs: Try one of the URLs in step 3. Verify that your staff client still operates as usual. Test a few URLs inside some modules. [3] For dev installs: Try some URLs like below. Expect 404 errors only, not 500s. If you do not see a 404, go back! /misc/stage_file.pl /t/db_dependent/default_search_class.pl /installer/data/mysql/updatedatabase.pl /Makefile.PL [4] Do you see an additional directory to add to the regex? Please report. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Utils/DataTables/Members.pm | 2 +- debian/templates/apache-shared-intranet.conf | 3 ++ opac/opac-showmarc.pl | 41 +++++++++++++++++----------- 3 files changed, 29 insertions(+), 17 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 27 12:46:03 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 27 Apr 2020 10:46:03 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1883-g6c1a4312c4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 6c1a4312c4c6416eeed9220982db69c2ae5cd8f3 (commit) via 3d3a07c5ee0098c3fe504009144b5c0545c0e75f (commit) via ec99043a2ede2f994dae72ee2f68884174f94d4c (commit) via 78cb447c7cd13bd37a48f7b3e2d2aa47b5d7b4d9 (commit) via 5394e8443fcba3e307c4add97bef1216fcaa2b11 (commit) via b97158dd1342ea060a29297df3d691f05065c227 (commit) via 572f486697c18337ea6bb804a0b624e9c8912744 (commit) via 9c66f9f320eab62cb7a0440fc6fc02142558eb1d (commit) via 6f3c1d5af804e16243433b11751f9ad3677aab37 (commit) via 9c39093b3d397790003f82a56ed2a506c3556cc9 (commit) via 69b1a62aa46ce9c378eef678357318714ba8744c (commit) via 8b5719a0e76cd0cb69ada67ff8a147a2a703c8a7 (commit) via 2dac989f1d92a4b5429d1210845cae9cf54e5377 (commit) via 68df51562aaba611511702affbe136a69c3934c4 (commit) via 5e93e9df4bdd648d2f815c1a753a835311f8a64c (commit) via c748a445c0b237932c0a220a9c7f70fa17151962 (commit) from ca5b112376f8b74d573f8b8d6c1512a59040ba60 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6c1a4312c4c6416eeed9220982db69c2ae5cd8f3 Author: Martin Renvoize Date: Mon Apr 27 11:17:33 2020 +0100 Bug 25045: DBRev 19.12.00.079 Signed-off-by: Martin Renvoize commit 3d3a07c5ee0098c3fe504009144b5c0545c0e75f Author: Tomas Cohen Arazi Date: Mon Apr 13 11:47:30 2020 -0300 Bug 25045: (follow-up) Add a note to OpacPublic This patch tweaks the OpacPublic system preference description so users don't expect, incorrectly, this syspref to disable the public API anonymous access. Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit ec99043a2ede2f994dae72ee2f68884174f94d4c Author: Tomas Cohen Arazi Date: Mon Apr 13 11:40:48 2020 -0300 Bug 25045: Allow restricting anonymous requests on the public API This patch introduces a check on the authenticate_api_request method for the RESTPublicAnonymousRequests system preference. If disabled, anonymous requests get rejected. The idea is to replicate the homologous OpacPublic system preference behaviour. To test: 1. Apply the Unit tests patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t => FAIL: Tests fail, 200 is answered instead of 401 on the route. 3. Apply this patch 4. Repeat 2. => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 78cb447c7cd13bd37a48f7b3e2d2aa47b5d7b4d9 Author: Tomas Cohen Arazi Date: Mon Apr 13 11:40:44 2020 -0300 Bug 25045: Unit tests Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 5394e8443fcba3e307c4add97bef1216fcaa2b11 Author: Tomas Cohen Arazi Date: Mon Apr 13 11:36:12 2020 -0300 Bug 25045: Add the RESTPublicAnonymousRequests syspref Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit b97158dd1342ea060a29297df3d691f05065c227 Author: Tomas Cohen Arazi Date: Thu Mar 19 17:04:31 2020 -0300 Bug 24909: Add unprivileged route to get a bibliographic record This patch adds a route to get bibliographic records without privileged access. This needs to match the OPAC expected behaviour. Some things were considered on the implementation: - The ViewPolicy filter that hides/shows things based on the frameworks needded to be used, as in the OPAC. - OpacHiddenItems and OpacHiddenItemsExceptions need to be considered for hiding records the same way the OPAC is expected to. - Avoid using OpacHiddenItemsExceptions, but rely on the patron category instead (use Koha::Patron::Category->override_hidden_items abstraction is used instead so it should keep working once 22547 is moved forward). - Tests should cover all the use cases: * logged in user * anonymous user * logged in with category that overrides * logged in with category that doesn't override This is all implemented on the tests. To test: 1. Apply the tests patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/biblios.t => FAIL: Route not implemented 3. Apply the rest of the patches 4. Repeat 2 => SUCCESS: Tests pass! 5. Try it with your favourite API tool (Postman?) 6. Sign off :-D Note: please notice there isn't a default fallback behaviour for when you don't specify the Accept header, so testing this on a regular browser will just print the accepted mime types instead of the record itself. To test this with a tool (like Postman) you should enable RESTBasicAuthe and make the tool use Basic authentication with valid credentials. And you need to specify any of the following strings on the Accept header: - application/marcxml+xml - application/marc-in-json - application/marc - text/plain Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 572f486697c18337ea6bb804a0b624e9c8912744 Author: Tomas Cohen Arazi Date: Thu Mar 19 17:03:53 2020 -0300 Bug 24909: Route spec Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 9c66f9f320eab62cb7a0440fc6fc02142558eb1d Author: Tomas Cohen Arazi Date: Thu Mar 19 17:03:23 2020 -0300 Bug 24909: Unit tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 6f3c1d5af804e16243433b11751f9ad3677aab37 Author: Katrin Fischer Date: Sun Apr 12 03:19:03 2020 +0000 Bug 21927: Acq - Add blank values in pull downs of mandatory item subfields This is the same fix as on bug 14662, which fixed the behaviour in cataloguing, but for the item form in acquisitions. The code assumes that if a subfield is marked as mandatory, there should be no empty entry in the pull downs. This assumption is not correct, as it leads to the first entry of the pull down being preselected if there is no default set. As the field can never be 'unset', there will never be a 'required' warning. Furthermore, it might be counterproductive to use mandatory fields, as it might be easily forgotten to change the preselected value and those mistakes will be hard to find. Correct behaviour would be to preselect the empty value when there is no default. This means on saving the item an error message is triggered and the cataloger is forced to set the value. To test: - This is best tested with an ACQ framework, but default can be used when no ACQ framework was created. - In your MARC bibliographic framework: - In 952 make itemtype, classification source and some other pull downs like location or collection mandatory and set them to visibel if needed - Create a new basket with 'items created while ordering' - Add a new order, an existing record with 942$c set will work best - Add items for your order line - Verify that the first value of each pull down is preselected, there is no way to trigger the 'required' error - Apply patch - Add a new order line - Verify that classification source is preselected according to the DefaultClassificationSource system preference (try unsetting it later) - Verify all mandatory fields can be set to empty - Verify that you can't save before correctly setting them - Change your frameworks and set a default for itemtype (Ex: BK) and another mandatory and non-mandatory field of your choice - Add a new order line and item and verify the defaults are selected Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 9c39093b3d397790003f82a56ed2a506c3556cc9 Author: Owen Leonard Date: Fri Apr 24 11:49:21 2020 +0000 Bug 25274: Don't initialize DataTable if table isn't present This patch modifies the OPAC basket JavaScript so that a check is added for the existence of the "itemst" table. This avoids an error if the "More details" view is selected and hte "itemst" table isn't present. To reproduce the error, add some items to the OPAC cart and open the cart window. Open the JavaScript console in your browser and click the "More details" link. You'll see an error. To test, apply the patch and perform the same test as above. The error should not be present. Test that table sorting in the "brief" view words correctly. Signed-off-by: David Roberts Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 69b1a62aa46ce9c378eef678357318714ba8744c Author: Bernardo Gonzalez Kriegel Date: Thu Mar 19 07:12:51 2020 -0300 Bug 24897: Remove es-ES installer data With installer data in YAML format and it's translations, there are no need for localized installer files. This patch removes es-ES installer files. To test on top of Bug 24871 1) Apply the patch 2) Translate to spanish cd misc/translator ./translate update es-ES -/translate install es-ES 3) Do a clean install using es-ES, check no problems during install 4) Verify MARC21 frameworks, they must be translated Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 8b5719a0e76cd0cb69ada67ff8a147a2a703c8a7 Author: Bernardo Gonzalez Kriegel Date: Sun Mar 15 18:15:32 2020 -0300 Bug 24871: Add new *-installer*.po translation files This patch simply adds new po files for each supported language. The are not created on update, so the need to add this files. To test: 1) Update your preferred language 2) Check missing *installer*po files 3) Create new translation files: cd /misc/translation ./translate create xx-YY check *installer*po files 4) Apply patch 5) Repeat 1, verify installer files are updated see last modification time Pre-filled translations for some languages (https://translate.koha-community.org/projects/marc21/) Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 2dac989f1d92a4b5429d1210845cae9cf54e5377 Author: Bernardo Gonzalez Kriegel Date: Wed Dec 4 21:51:16 2019 -0300 Bug 25257: Preserve prolog on translated XML files This patch fix the missing xml prolog in translated files, XML or TT. Is fixed teaching C4::TTParse not to ignore constructs, then teaching xgettext.pl to ignore those strings. Net result is that they are copied in the translated file. To test: 1) Update & install your preferred language, (cd misc/translator/; perl translate update xx-YY; perl translate install xx-YY ) 2) Compare the first lines (head -2) of: koha-tmpl/opac-tmpl/bootstrap/en/xslt/compact.xsl koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-opensearch.tt koha-tmpl/intranet-tmpl/prog/en/xslt/plainMARC.xsl and koha-tmpl/opac-tmpl/bootstrap/xx-YY/xslt/compact.xsl koha-tmpl/opac-tmpl/bootstrap/xx-YY/modules/opac-opensearch.tt koha-tmpl/intranet-tmpl/prog/xx-YY/xslt/plainMARC.xsl Check the missing prolog 3) Install this patch, repeat 1 and 2, now the prolog is present on translated files. Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 68df51562aaba611511702affbe136a69c3934c4 Author: Owen Leonard Date: Tue Apr 14 11:52:17 2020 +0000 Bug 25118: Return claims has some translation issues This patch adds the right function calls to checkouts.js so that English strings can be picked up by the translator. The resolution message has been reformatted so that it can be clear without including "on" and "by" in the middle of the string. To test you should have a patron with at least one return claim. Open the checkout page for that patron and open the "Claims" tab. Test the process of editing, deleting, and resolving claims. TESTING TRANSLATABILITY - Update a translation: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for the staff client: misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from checkouts.js for translation, e.g.: #: koha-tmpl/intranet-tmpl/prog/js/checkouts.js:920 msgid "Double click to edit" msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation: > perl translate install fr-FR Switch to the udpated translation and test the functionality under the "Claims" tab again to confirm that your translated strings appear. Note that "untranslatable string" failures reported by the QA script are false positives. Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 5e93e9df4bdd648d2f815c1a753a835311f8a64c Author: Andrew Fuerste-Henry Date: Tue Apr 21 17:41:29 2020 +0000 Bug 25224: Show large print format in search results XSLT To test: 1: find a bib with 008 type Book (Leader position 6 = 'a' and leader position 7 = 'm' -- use bib number 1 in master data) 2: set 008 position 23 to 'd' for large print 3: check your book record in opac and intranet search results, note that your change is not reflected in the "format" note in line with material type 4: find a bib with 008 type Continuing Resource (Leader position 6 = 'a' and leader position 7 = 's' -- use bib number 44 in master data) 5: set 008 position 23 to 'd' for large print 6: check your continuing resource record in opac and intranet search results, note that your change is not reflected in the "format" note in line with material type 7: apply patch, restart_all 8: reload search results from steps 3 and 6, confirm they now say "format: large print" Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit c748a445c0b237932c0a220a9c7f70fa17151962 Author: Nick Clemens Date: Wed Apr 22 13:30:06 2020 +0000 Bug 25248: (bug 23463 follow-up) Item is returned if deletion successful, not 1 To test: 1 - Have a record with some items 2 - Click 'Delete all' under 'Edit' 3 - Confirm deletion 4 - Note you are redirected to additem.pl 5 - Add an item 6 - Apply patch 7 - Delete all items again 8 - Note you are redirected to detail.pl Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Items.pm | 8 +- C4/TTParser.pm | 10 + Koha.pm | 2 +- Koha/REST/V1/Auth.pm | 12 +- Koha/REST/V1/Biblios.pm | 97 + api/v1/swagger/paths.json | 3 + api/v1/swagger/paths/biblios.json | 65 + cataloguing/additem.pl | 2 +- .../data/mysql/es-ES/mandatory/auth_values.sql | 3 - .../data/mysql/es-ES/mandatory/auth_values.txt | 1 - .../data/mysql/es-ES/mandatory/class_sources.sql | 41 - .../data/mysql/es-ES/mandatory/class_sources.txt | 1 - .../mysql/es-ES/mandatory/sample_frequencies.sql | 16 - .../mysql/es-ES/mandatory/sample_frequencies.txt | 1 - .../data/mysql/es-ES/mandatory/sample_notices.sql | 380 - .../data/mysql/es-ES/mandatory/sample_notices.txt | 1 - .../es-ES/mandatory/sample_numberpatterns.sql | 25 - .../es-ES/mandatory/sample_numberpatterns.txt | 1 - .../mysql/es-ES/mandatory/system_preferences.sql | 20 - .../mysql/es-ES/mandatory/system_preferences.txt | 1 - .../marc21/mandatory/authorities_normal_marc21.sql | 2229 ------ .../marc21/mandatory/authorities_normal_marc21.txt | 10 - .../marc21/mandatory/marc21_framework_DEFAULT.sql | 4464 ----------- .../marc21/mandatory/marc21_framework_DEFAULT.txt | 1 - .../optional/marc21_default_matching_rules.sql | 46 - .../optional/marc21_default_matching_rules.txt | 4 - .../optional/marc21_sample_fastadd_framework.sql | 87 - .../optional/marc21_sample_fastadd_framework.txt | 1 - .../optional/marc21_simple_bib_frameworks.sql | 524 -- .../optional/marc21_simple_bib_frameworks.txt | 10 - .../mandatory/authorities_normal_unimarc.sql | 823 -- .../mandatory/authorities_normal_unimarc.txt | 1 - .../mandatory/unimarc_framework_DEFAULT.sql | 1407 ---- .../mandatory/unimarc_framework_DEFAULT.txt | 1 - installer/data/mysql/es-ES/optional/auth_val.sql | 78 - installer/data/mysql/es-ES/optional/auth_val.txt | 1 - .../optional/marc21_holdings_coded_values.sql | 146 - .../optional/marc21_holdings_coded_values.txt | 2 - .../mysql/es-ES/optional/marc21_relatorterms.sql | 226 - .../mysql/es-ES/optional/marc21_relatorterms.txt | 1 - installer/data/mysql/es-ES/optional/parameters.sql | 6 - installer/data/mysql/es-ES/optional/parameters.txt | 1 - .../data/mysql/es-ES/optional/patron_atributes.sql | 2 - .../data/mysql/es-ES/optional/patron_atributes.txt | 2 - .../mysql/es-ES/optional/patron_categories.sql | 23 - .../mysql/es-ES/optional/patron_categories.txt | 25 - .../mysql/es-ES/optional/sample_creator_data.sql | 33 - .../mysql/es-ES/optional/sample_creator_data.txt | 1 - .../data/mysql/es-ES/optional/sample_itemtypes.sql | 9 - .../data/mysql/es-ES/optional/sample_itemtypes.txt | 1 - .../data/mysql/es-ES/optional/sample_libraries.sql | 15 - .../data/mysql/es-ES/optional/sample_libraries.txt | 1 - .../es-ES/optional/sample_libraries_holidays.sql | 4 - .../es-ES/optional/sample_libraries_holidays.txt | 4 - .../data/mysql/es-ES/optional/sample_news.sql | 2 - .../data/mysql/es-ES/optional/sample_news.txt | 1 - .../data/mysql/es-ES/optional/sample_patrons.sql | 51 - .../data/mysql/es-ES/optional/sample_patrons.txt | 1 - .../mysql/es-ES/optional/sample_z3950_servers.sql | 11 - .../mysql/es-ES/optional/sample_z3950_servers.txt | 4 - installer/data/mysql/sysprefs.sql | 1 + installer/data/mysql/updatedatabase.pl | 16 + .../prog/en/modules/admin/preferences/opac.pref | 3 +- .../en/modules/admin/preferences/web_services.pref | 6 + .../prog/en/xslt/MARC21slim2intranetResults.xsl | 3 + koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 21 +- .../opac-tmpl/bootstrap/en/modules/opac-basket.tt | 41 +- .../bootstrap/en/xslt/MARC21slim2OPACResults.xsl | 3 + misc/translator/po/am-Ethi-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/am-Ethi-installer.po | 2930 +++++++ misc/translator/po/ar-Arab-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/ar-Arab-installer.po | 2930 +++++++ misc/translator/po/as-IN-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/as-IN-installer.po | 2930 +++++++ misc/translator/po/az-AZ-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/az-AZ-installer.po | 2930 +++++++ misc/translator/po/be-BY-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/be-BY-installer.po | 2930 +++++++ misc/translator/po/bg-Cyrl-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/bg-Cyrl-installer.po | 2930 +++++++ misc/translator/po/bn-IN-installer-MARC21.po | 7127 +++++++++++++++++ misc/translator/po/bn-IN-installer.po | 2930 +++++++ misc/translator/po/ca-ES-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/ca-ES-installer.po | 2930 +++++++ misc/translator/po/cs-CZ-installer-MARC21.po | 8023 ++++++++++++++++++++ misc/translator/po/cs-CZ-installer.po | 2930 +++++++ misc/translator/po/cy-GB-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/cy-GB-installer.po | 2930 +++++++ misc/translator/po/da-DK-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/da-DK-installer.po | 2930 +++++++ misc/translator/po/de-CH-installer-MARC21.po | 7256 ++++++++++++++++++ misc/translator/po/de-CH-installer.po | 2930 +++++++ misc/translator/po/de-DE-installer-MARC21.po | 7218 ++++++++++++++++++ misc/translator/po/de-DE-installer.po | 2930 +++++++ misc/translator/po/dz-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/dz-installer.po | 2930 +++++++ misc/translator/po/el-GR-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/el-GR-installer.po | 2930 +++++++ misc/translator/po/en-GB-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/en-GB-installer.po | 2930 +++++++ misc/translator/po/en-NZ-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/en-NZ-installer.po | 2930 +++++++ misc/translator/po/eo-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/eo-installer.po | 2930 +++++++ misc/translator/po/es-ES-installer-MARC21.po | 7283 ++++++++++++++++++ misc/translator/po/es-ES-installer.po | 2930 +++++++ misc/translator/po/eu-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/eu-installer.po | 2930 +++++++ misc/translator/po/fa-Arab-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/fa-Arab-installer.po | 2930 +++++++ misc/translator/po/fi-FI-installer-MARC21.po | 7245 ++++++++++++++++++ misc/translator/po/fi-FI-installer.po | 2930 +++++++ misc/translator/po/fo-FO-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/fo-FO-installer.po | 2930 +++++++ misc/translator/po/fr-CA-installer-MARC21.po | 7240 ++++++++++++++++++ misc/translator/po/fr-CA-installer.po | 2930 +++++++ misc/translator/po/fr-FR-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/fr-FR-installer.po | 2930 +++++++ misc/translator/po/ga-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/ga-installer.po | 2930 +++++++ misc/translator/po/gd-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/gd-installer.po | 2930 +++++++ misc/translator/po/gl-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/gl-installer.po | 2930 +++++++ misc/translator/po/he-Hebr-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/he-Hebr-installer.po | 2930 +++++++ misc/translator/po/hi-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/hi-installer.po | 2930 +++++++ misc/translator/po/hr-HR-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/hr-HR-installer.po | 2930 +++++++ misc/translator/po/hu-HU-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/hu-HU-installer.po | 2930 +++++++ misc/translator/po/hy-Armn-installer-MARC21.po | 7213 ++++++++++++++++++ misc/translator/po/hy-Armn-installer.po | 2930 +++++++ misc/translator/po/ia-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/ia-installer.po | 2930 +++++++ misc/translator/po/id-ID-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/id-ID-installer.po | 2930 +++++++ misc/translator/po/iq-CA-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/iq-CA-installer.po | 2930 +++++++ misc/translator/po/is-IS-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/is-IS-installer.po | 2930 +++++++ misc/translator/po/it-IT-installer-MARC21.po | 7226 ++++++++++++++++++ misc/translator/po/it-IT-installer.po | 2930 +++++++ misc/translator/po/iu-CA-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/iu-CA-installer.po | 2930 +++++++ misc/translator/po/ja-Jpan-JP-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/ja-Jpan-JP-installer.po | 2930 +++++++ misc/translator/po/ka-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/ka-installer.po | 2930 +++++++ misc/translator/po/km-KH-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/km-KH-installer.po | 2930 +++++++ misc/translator/po/kn-Knda-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/kn-Knda-installer.po | 2930 +++++++ misc/translator/po/ko-Kore-KP-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/ko-Kore-KP-installer.po | 2930 +++++++ misc/translator/po/ku-Arab-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/ku-Arab-installer.po | 2930 +++++++ misc/translator/po/lo-Laoo-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/lo-Laoo-installer.po | 2930 +++++++ misc/translator/po/lv-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/lv-installer.po | 2930 +++++++ misc/translator/po/mi-NZ-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/mi-NZ-installer.po | 2930 +++++++ misc/translator/po/ml-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/ml-installer.po | 2930 +++++++ misc/translator/po/mon-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/mon-installer.po | 2930 +++++++ misc/translator/po/mr-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/mr-installer.po | 2930 +++++++ misc/translator/po/ms-MY-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/ms-MY-installer.po | 2930 +++++++ misc/translator/po/my-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/my-installer.po | 2930 +++++++ misc/translator/po/nb-NO-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/nb-NO-installer.po | 2930 +++++++ misc/translator/po/ne-NE-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/ne-NE-installer.po | 2930 +++++++ misc/translator/po/nl-BE-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/nl-BE-installer.po | 2930 +++++++ misc/translator/po/nl-NL-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/nl-NL-installer.po | 2930 +++++++ misc/translator/po/nn-NO-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/nn-NO-installer.po | 2930 +++++++ misc/translator/po/oc-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/oc-installer.po | 2930 +++++++ misc/translator/po/pbr-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/pbr-installer.po | 2930 +++++++ misc/translator/po/pl-PL-installer-MARC21.po | 7186 ++++++++++++++++++ misc/translator/po/pl-PL-installer.po | 2930 +++++++ misc/translator/po/prs-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/prs-installer.po | 2930 +++++++ misc/translator/po/pt-BR-installer-MARC21.po | 7816 +++++++++++++++++++ misc/translator/po/pt-BR-installer.po | 2930 +++++++ misc/translator/po/pt-PT-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/pt-PT-installer.po | 2930 +++++++ misc/translator/po/ro-RO-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/ro-RO-installer.po | 2930 +++++++ misc/translator/po/ru-RU-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/ru-RU-installer.po | 2930 +++++++ misc/translator/po/rw-RW-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/rw-RW-installer.po | 2930 +++++++ misc/translator/po/sd-PK-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/sd-PK-installer.po | 2930 +++++++ misc/translator/po/sk-SK-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/sk-SK-installer.po | 2930 +++++++ misc/translator/po/sl-SI-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/sl-SI-installer.po | 2930 +++++++ misc/translator/po/sq-AL-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/sq-AL-installer.po | 2930 +++++++ misc/translator/po/sr-Cyrl-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/sr-Cyrl-installer.po | 2930 +++++++ misc/translator/po/sv-SE-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/sv-SE-installer.po | 2930 +++++++ misc/translator/po/sw-KE-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/sw-KE-installer.po | 2930 +++++++ misc/translator/po/ta-LK-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/ta-LK-installer.po | 2930 +++++++ misc/translator/po/ta-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/ta-installer.po | 2930 +++++++ misc/translator/po/tet-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/tet-installer.po | 2930 +++++++ misc/translator/po/th-TH-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/th-TH-installer.po | 2930 +++++++ misc/translator/po/tl-PH-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/tl-PH-installer.po | 2930 +++++++ misc/translator/po/tr-TR-installer-MARC21.po | 7221 ++++++++++++++++++ misc/translator/po/tr-TR-installer.po | 2930 +++++++ misc/translator/po/tvl-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/tvl-installer.po | 2930 +++++++ misc/translator/po/uk-UA-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/uk-UA-installer.po | 2930 +++++++ misc/translator/po/ur-Arab-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/ur-Arab-installer.po | 2930 +++++++ misc/translator/po/vi-VN-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/vi-VN-installer.po | 2930 +++++++ misc/translator/po/zh-Hans-CN-installer-MARC21.po | 7034 +++++++++++++++++ misc/translator/po/zh-Hans-CN-installer.po | 2930 +++++++ misc/translator/po/zh-Hant-TW-installer-MARC21.po | 7717 +++++++++++++++++++ misc/translator/po/zh-Hant-TW-installer.po | 2930 +++++++ misc/translator/xgettext.pl | 1 + .../api/v1/auth_authenticate_api_request.t | 35 +- t/db_dependent/api/v1/biblios.t | 141 +- 243 files changed, 861659 insertions(+), 10794 deletions(-) delete mode 100644 installer/data/mysql/es-ES/mandatory/auth_values.sql delete mode 100644 installer/data/mysql/es-ES/mandatory/auth_values.txt delete mode 100644 installer/data/mysql/es-ES/mandatory/class_sources.sql delete mode 100644 installer/data/mysql/es-ES/mandatory/class_sources.txt delete mode 100644 installer/data/mysql/es-ES/mandatory/sample_frequencies.sql delete mode 100644 installer/data/mysql/es-ES/mandatory/sample_frequencies.txt delete mode 100644 installer/data/mysql/es-ES/mandatory/sample_notices.sql delete mode 100644 installer/data/mysql/es-ES/mandatory/sample_notices.txt delete mode 100644 installer/data/mysql/es-ES/mandatory/sample_numberpatterns.sql delete mode 100644 installer/data/mysql/es-ES/mandatory/sample_numberpatterns.txt delete mode 100644 installer/data/mysql/es-ES/mandatory/system_preferences.sql delete mode 100644 installer/data/mysql/es-ES/mandatory/system_preferences.txt delete mode 100644 installer/data/mysql/es-ES/marcflavour/marc21/mandatory/authorities_normal_marc21.sql delete mode 100644 installer/data/mysql/es-ES/marcflavour/marc21/mandatory/authorities_normal_marc21.txt delete mode 100644 installer/data/mysql/es-ES/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.sql delete mode 100644 installer/data/mysql/es-ES/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.txt delete mode 100644 installer/data/mysql/es-ES/marcflavour/marc21/optional/marc21_default_matching_rules.sql delete mode 100644 installer/data/mysql/es-ES/marcflavour/marc21/optional/marc21_default_matching_rules.txt delete mode 100644 installer/data/mysql/es-ES/marcflavour/marc21/optional/marc21_sample_fastadd_framework.sql delete mode 100644 installer/data/mysql/es-ES/marcflavour/marc21/optional/marc21_sample_fastadd_framework.txt delete mode 100644 installer/data/mysql/es-ES/marcflavour/marc21/optional/marc21_simple_bib_frameworks.sql delete mode 100644 installer/data/mysql/es-ES/marcflavour/marc21/optional/marc21_simple_bib_frameworks.txt delete mode 100644 installer/data/mysql/es-ES/marcflavour/unimarc/mandatory/authorities_normal_unimarc.sql delete mode 100644 installer/data/mysql/es-ES/marcflavour/unimarc/mandatory/authorities_normal_unimarc.txt delete mode 100644 installer/data/mysql/es-ES/marcflavour/unimarc/mandatory/unimarc_framework_DEFAULT.sql delete mode 100644 installer/data/mysql/es-ES/marcflavour/unimarc/mandatory/unimarc_framework_DEFAULT.txt delete mode 100644 installer/data/mysql/es-ES/optional/auth_val.sql delete mode 100644 installer/data/mysql/es-ES/optional/auth_val.txt delete mode 100644 installer/data/mysql/es-ES/optional/marc21_holdings_coded_values.sql delete mode 100644 installer/data/mysql/es-ES/optional/marc21_holdings_coded_values.txt delete mode 100644 installer/data/mysql/es-ES/optional/marc21_relatorterms.sql delete mode 100644 installer/data/mysql/es-ES/optional/marc21_relatorterms.txt delete mode 100644 installer/data/mysql/es-ES/optional/parameters.sql delete mode 100644 installer/data/mysql/es-ES/optional/parameters.txt delete mode 100644 installer/data/mysql/es-ES/optional/patron_atributes.sql delete mode 100644 installer/data/mysql/es-ES/optional/patron_atributes.txt delete mode 100644 installer/data/mysql/es-ES/optional/patron_categories.sql delete mode 100644 installer/data/mysql/es-ES/optional/patron_categories.txt delete mode 100644 installer/data/mysql/es-ES/optional/sample_creator_data.sql delete mode 100644 installer/data/mysql/es-ES/optional/sample_creator_data.txt delete mode 100644 installer/data/mysql/es-ES/optional/sample_itemtypes.sql delete mode 100644 installer/data/mysql/es-ES/optional/sample_itemtypes.txt delete mode 100644 installer/data/mysql/es-ES/optional/sample_libraries.sql delete mode 100644 installer/data/mysql/es-ES/optional/sample_libraries.txt delete mode 100644 installer/data/mysql/es-ES/optional/sample_libraries_holidays.sql delete mode 100644 installer/data/mysql/es-ES/optional/sample_libraries_holidays.txt delete mode 100644 installer/data/mysql/es-ES/optional/sample_news.sql delete mode 100644 installer/data/mysql/es-ES/optional/sample_news.txt delete mode 100644 installer/data/mysql/es-ES/optional/sample_patrons.sql delete mode 100644 installer/data/mysql/es-ES/optional/sample_patrons.txt delete mode 100644 installer/data/mysql/es-ES/optional/sample_z3950_servers.sql delete mode 100644 installer/data/mysql/es-ES/optional/sample_z3950_servers.txt create mode 100644 misc/translator/po/am-Ethi-installer-MARC21.po create mode 100644 misc/translator/po/am-Ethi-installer.po create mode 100644 misc/translator/po/ar-Arab-installer-MARC21.po create mode 100644 misc/translator/po/ar-Arab-installer.po create mode 100644 misc/translator/po/as-IN-installer-MARC21.po create mode 100644 misc/translator/po/as-IN-installer.po create mode 100644 misc/translator/po/az-AZ-installer-MARC21.po create mode 100644 misc/translator/po/az-AZ-installer.po create mode 100644 misc/translator/po/be-BY-installer-MARC21.po create mode 100644 misc/translator/po/be-BY-installer.po create mode 100644 misc/translator/po/bg-Cyrl-installer-MARC21.po create mode 100644 misc/translator/po/bg-Cyrl-installer.po create mode 100644 misc/translator/po/bn-IN-installer-MARC21.po create mode 100644 misc/translator/po/bn-IN-installer.po create mode 100644 misc/translator/po/ca-ES-installer-MARC21.po create mode 100644 misc/translator/po/ca-ES-installer.po create mode 100644 misc/translator/po/cs-CZ-installer-MARC21.po create mode 100644 misc/translator/po/cs-CZ-installer.po create mode 100644 misc/translator/po/cy-GB-installer-MARC21.po create mode 100644 misc/translator/po/cy-GB-installer.po create mode 100644 misc/translator/po/da-DK-installer-MARC21.po create mode 100644 misc/translator/po/da-DK-installer.po create mode 100644 misc/translator/po/de-CH-installer-MARC21.po create mode 100644 misc/translator/po/de-CH-installer.po create mode 100644 misc/translator/po/de-DE-installer-MARC21.po create mode 100644 misc/translator/po/de-DE-installer.po create mode 100644 misc/translator/po/dz-installer-MARC21.po create mode 100644 misc/translator/po/dz-installer.po create mode 100644 misc/translator/po/el-GR-installer-MARC21.po create mode 100644 misc/translator/po/el-GR-installer.po create mode 100644 misc/translator/po/en-GB-installer-MARC21.po create mode 100644 misc/translator/po/en-GB-installer.po create mode 100644 misc/translator/po/en-NZ-installer-MARC21.po create mode 100644 misc/translator/po/en-NZ-installer.po create mode 100644 misc/translator/po/eo-installer-MARC21.po create mode 100644 misc/translator/po/eo-installer.po create mode 100644 misc/translator/po/es-ES-installer-MARC21.po create mode 100644 misc/translator/po/es-ES-installer.po create mode 100644 misc/translator/po/eu-installer-MARC21.po create mode 100644 misc/translator/po/eu-installer.po create mode 100644 misc/translator/po/fa-Arab-installer-MARC21.po create mode 100644 misc/translator/po/fa-Arab-installer.po create mode 100644 misc/translator/po/fi-FI-installer-MARC21.po create mode 100644 misc/translator/po/fi-FI-installer.po create mode 100644 misc/translator/po/fo-FO-installer-MARC21.po create mode 100644 misc/translator/po/fo-FO-installer.po create mode 100644 misc/translator/po/fr-CA-installer-MARC21.po create mode 100644 misc/translator/po/fr-CA-installer.po create mode 100644 misc/translator/po/fr-FR-installer-MARC21.po create mode 100644 misc/translator/po/fr-FR-installer.po create mode 100644 misc/translator/po/ga-installer-MARC21.po create mode 100644 misc/translator/po/ga-installer.po create mode 100644 misc/translator/po/gd-installer-MARC21.po create mode 100644 misc/translator/po/gd-installer.po create mode 100644 misc/translator/po/gl-installer-MARC21.po create mode 100644 misc/translator/po/gl-installer.po create mode 100644 misc/translator/po/he-Hebr-installer-MARC21.po create mode 100644 misc/translator/po/he-Hebr-installer.po create mode 100644 misc/translator/po/hi-installer-MARC21.po create mode 100644 misc/translator/po/hi-installer.po create mode 100644 misc/translator/po/hr-HR-installer-MARC21.po create mode 100644 misc/translator/po/hr-HR-installer.po create mode 100644 misc/translator/po/hu-HU-installer-MARC21.po create mode 100644 misc/translator/po/hu-HU-installer.po create mode 100644 misc/translator/po/hy-Armn-installer-MARC21.po create mode 100644 misc/translator/po/hy-Armn-installer.po create mode 100644 misc/translator/po/ia-installer-MARC21.po create mode 100644 misc/translator/po/ia-installer.po create mode 100644 misc/translator/po/id-ID-installer-MARC21.po create mode 100644 misc/translator/po/id-ID-installer.po create mode 100644 misc/translator/po/iq-CA-installer-MARC21.po create mode 100644 misc/translator/po/iq-CA-installer.po create mode 100644 misc/translator/po/is-IS-installer-MARC21.po create mode 100644 misc/translator/po/is-IS-installer.po create mode 100644 misc/translator/po/it-IT-installer-MARC21.po create mode 100644 misc/translator/po/it-IT-installer.po create mode 100644 misc/translator/po/iu-CA-installer-MARC21.po create mode 100644 misc/translator/po/iu-CA-installer.po create mode 100644 misc/translator/po/ja-Jpan-JP-installer-MARC21.po create mode 100644 misc/translator/po/ja-Jpan-JP-installer.po create mode 100644 misc/translator/po/ka-installer-MARC21.po create mode 100644 misc/translator/po/ka-installer.po create mode 100644 misc/translator/po/km-KH-installer-MARC21.po create mode 100644 misc/translator/po/km-KH-installer.po create mode 100644 misc/translator/po/kn-Knda-installer-MARC21.po create mode 100644 misc/translator/po/kn-Knda-installer.po create mode 100644 misc/translator/po/ko-Kore-KP-installer-MARC21.po create mode 100644 misc/translator/po/ko-Kore-KP-installer.po create mode 100644 misc/translator/po/ku-Arab-installer-MARC21.po create mode 100644 misc/translator/po/ku-Arab-installer.po create mode 100644 misc/translator/po/lo-Laoo-installer-MARC21.po create mode 100644 misc/translator/po/lo-Laoo-installer.po create mode 100644 misc/translator/po/lv-installer-MARC21.po create mode 100644 misc/translator/po/lv-installer.po create mode 100644 misc/translator/po/mi-NZ-installer-MARC21.po create mode 100644 misc/translator/po/mi-NZ-installer.po create mode 100644 misc/translator/po/ml-installer-MARC21.po create mode 100644 misc/translator/po/ml-installer.po create mode 100644 misc/translator/po/mon-installer-MARC21.po create mode 100644 misc/translator/po/mon-installer.po create mode 100644 misc/translator/po/mr-installer-MARC21.po create mode 100644 misc/translator/po/mr-installer.po create mode 100644 misc/translator/po/ms-MY-installer-MARC21.po create mode 100644 misc/translator/po/ms-MY-installer.po create mode 100644 misc/translator/po/my-installer-MARC21.po create mode 100644 misc/translator/po/my-installer.po create mode 100644 misc/translator/po/nb-NO-installer-MARC21.po create mode 100644 misc/translator/po/nb-NO-installer.po create mode 100644 misc/translator/po/ne-NE-installer-MARC21.po create mode 100644 misc/translator/po/ne-NE-installer.po create mode 100644 misc/translator/po/nl-BE-installer-MARC21.po create mode 100644 misc/translator/po/nl-BE-installer.po create mode 100644 misc/translator/po/nl-NL-installer-MARC21.po create mode 100644 misc/translator/po/nl-NL-installer.po create mode 100644 misc/translator/po/nn-NO-installer-MARC21.po create mode 100644 misc/translator/po/nn-NO-installer.po create mode 100644 misc/translator/po/oc-installer-MARC21.po create mode 100644 misc/translator/po/oc-installer.po create mode 100644 misc/translator/po/pbr-installer-MARC21.po create mode 100644 misc/translator/po/pbr-installer.po create mode 100644 misc/translator/po/pl-PL-installer-MARC21.po create mode 100644 misc/translator/po/pl-PL-installer.po create mode 100644 misc/translator/po/prs-installer-MARC21.po create mode 100644 misc/translator/po/prs-installer.po create mode 100644 misc/translator/po/pt-BR-installer-MARC21.po create mode 100644 misc/translator/po/pt-BR-installer.po create mode 100644 misc/translator/po/pt-PT-installer-MARC21.po create mode 100644 misc/translator/po/pt-PT-installer.po create mode 100644 misc/translator/po/ro-RO-installer-MARC21.po create mode 100644 misc/translator/po/ro-RO-installer.po create mode 100644 misc/translator/po/ru-RU-installer-MARC21.po create mode 100644 misc/translator/po/ru-RU-installer.po create mode 100644 misc/translator/po/rw-RW-installer-MARC21.po create mode 100644 misc/translator/po/rw-RW-installer.po create mode 100644 misc/translator/po/sd-PK-installer-MARC21.po create mode 100644 misc/translator/po/sd-PK-installer.po create mode 100644 misc/translator/po/sk-SK-installer-MARC21.po create mode 100644 misc/translator/po/sk-SK-installer.po create mode 100644 misc/translator/po/sl-SI-installer-MARC21.po create mode 100644 misc/translator/po/sl-SI-installer.po create mode 100644 misc/translator/po/sq-AL-installer-MARC21.po create mode 100644 misc/translator/po/sq-AL-installer.po create mode 100644 misc/translator/po/sr-Cyrl-installer-MARC21.po create mode 100644 misc/translator/po/sr-Cyrl-installer.po create mode 100644 misc/translator/po/sv-SE-installer-MARC21.po create mode 100644 misc/translator/po/sv-SE-installer.po create mode 100644 misc/translator/po/sw-KE-installer-MARC21.po create mode 100644 misc/translator/po/sw-KE-installer.po create mode 100644 misc/translator/po/ta-LK-installer-MARC21.po create mode 100644 misc/translator/po/ta-LK-installer.po create mode 100644 misc/translator/po/ta-installer-MARC21.po create mode 100644 misc/translator/po/ta-installer.po create mode 100644 misc/translator/po/tet-installer-MARC21.po create mode 100644 misc/translator/po/tet-installer.po create mode 100644 misc/translator/po/th-TH-installer-MARC21.po create mode 100644 misc/translator/po/th-TH-installer.po create mode 100644 misc/translator/po/tl-PH-installer-MARC21.po create mode 100644 misc/translator/po/tl-PH-installer.po create mode 100644 misc/translator/po/tr-TR-installer-MARC21.po create mode 100644 misc/translator/po/tr-TR-installer.po create mode 100644 misc/translator/po/tvl-installer-MARC21.po create mode 100644 misc/translator/po/tvl-installer.po create mode 100644 misc/translator/po/uk-UA-installer-MARC21.po create mode 100644 misc/translator/po/uk-UA-installer.po create mode 100644 misc/translator/po/ur-Arab-installer-MARC21.po create mode 100644 misc/translator/po/ur-Arab-installer.po create mode 100644 misc/translator/po/vi-VN-installer-MARC21.po create mode 100644 misc/translator/po/vi-VN-installer.po create mode 100644 misc/translator/po/zh-Hans-CN-installer-MARC21.po create mode 100644 misc/translator/po/zh-Hans-CN-installer.po create mode 100644 misc/translator/po/zh-Hant-TW-installer-MARC21.po create mode 100644 misc/translator/po/zh-Hant-TW-installer.po hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 27 12:53:38 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 27 Apr 2020 10:53:38 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1887-g917a0761ea Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 917a0761ead775e4d35cc3be499e76cf7d6c8da7 (commit) via 67a73e5481168bb49388822c9267d4bbe4605327 (commit) via 43a83aab9f7f9033e4659e89235a9a5ea8a07fb4 (commit) via ec743f54256d219a9d26e6020a28126ef4be61c4 (commit) from 6c1a4312c4c6416eeed9220982db69c2ae5cd8f3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 917a0761ead775e4d35cc3be499e76cf7d6c8da7 Author: Martin Renvoize Date: Mon Apr 27 11:26:22 2020 +0100 Bug 25276: Compiled CSS Signed-off-by: Martin Renvoize commit 67a73e5481168bb49388822c9267d4bbe4605327 Author: Owen Leonard Date: Fri Apr 24 14:24:07 2020 +0000 Bug 25276: Correct hover style of list share button in the OPAC This patch adds missing "btn" classes to the OPAC share button so that its style is consistent with similar controls. The patch also makes some general changes to the OPAC CSS to make sure link color and hover color are applied with enough specificity. This corrects the hover color of the share button but should not change any other existing style. To test you should have the OpacAllowSharingPrivateLists preference enabled. - Rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Log in to the OPAC as a user with one or more private lists. - Go to Lists -> Your lists. - In the list of lists there should be a "Share" link for each list. Hovering your mouse pointer over the link should change the style in the same way the "Edit" link does. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 43a83aab9f7f9033e4659e89235a9a5ea8a07fb4 Author: Owen Leonard Date: Mon Apr 20 11:38:41 2020 +0000 Bug 25211: Add missing share icon to OPAC lists page This patch adds a Font Awesome icon to the "Share" links on the list of lists in the OPAC. To test, apply the patch and log in to the OPAC as a user who has one or more private lists. - Go to Lists -> Your lists - In the table of your lists, each list should have a "Share" link with an icon. Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit ec743f54256d219a9d26e6020a28126ef4be61c4 Author: Lucas Gass Date: Tue Apr 21 20:11:17 2020 +0000 Bug 24957: OpenLibrarySearch shouldnt display if nothing is returned TO TEST: 1. Turn on OpenLibrarySearch 2. Do an OPAC search that returns results that have results with Open Library results and some that do not. 3. Notice results that return nothing simpliy say "Open Library:" with nothing afterwards. 4. Some results return a png from OpenLibrary or "Not found" 5. Apply patch and look at records again. 6. The results that return nothing for OpenLibrary API should now to hidden. Signed-off-by: Heather Hernandez Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/css/opac.css | 2 +- koha-tmpl/opac-tmpl/bootstrap/css/src/_mixins.scss | 1 + koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss | 26 +++++++++++++--------- .../opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 2 +- koha-tmpl/opac-tmpl/bootstrap/js/openlibrary.js | 2 ++ 5 files changed, 21 insertions(+), 12 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 27 13:12:31 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 27 Apr 2020 11:12:31 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1899-ga852fae89a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via a852fae89a8d358f314d93dc7554dea72492e285 (commit) via 79f51b92c51cde6e815461e7a90d1d33fda49bda (commit) via 7b23e92d5f77d930f504739ca61789f44e416313 (commit) via 40cc8075588523913ca1f97b87831a9e68b53cb3 (commit) via 93c0f4420d22a510d56dd04bf11fad6b413e657c (commit) via 652f16d19419d56d9f5258c77b7494889f113d81 (commit) via abc00eb1cfd1ee018396d6df04e6f28d7b363dbb (commit) via e116f744a02b1f2cdf040c7bdf25498641bbc674 (commit) via ec1bfd2b749b8ed9bd8688abdd47b9736ba872d0 (commit) via b50641b4791f68a119ce5060c852e02cdb523956 (commit) via 866c6850e07411b37aae15f00444802ef1919c1b (commit) via 41873b21c894a4be1459b5ba1d93a28fa3b45ea4 (commit) from 917a0761ead775e4d35cc3be499e76cf7d6c8da7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a852fae89a8d358f314d93dc7554dea72492e285 Author: Katrin Fischer Date: Tue Apr 14 10:45:01 2020 +0000 Bug 17232: Make sure all fields are copies when creating a new framework from another Some digging revealed that when you create a new framework and use an old framework as the base, some information would not be copied to the new framework as they were missing from the SQL command used here. - Tag: Important - Subfield: - Important - Default value - Max length - Is a URL - Link To test: - Pick one of the existing frameworks and change the fields listed above. Take note of what you changed. - Create a new framework - Go to "Marc structure" of the new framework - You are offered the option to copy an existing framework - Use your prepared framework - Verify the fields weren't copied - your config was lost - Apply patch - Create another new framework - Repeat the duplication and tests - Verify that now all fields have been copied correctly Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 79f51b92c51cde6e815461e7a90d1d33fda49bda Author: Jonathan Druart Date: Wed Apr 22 15:54:29 2020 +0200 Bug 25249: (bug 19791 follow-up) Display Circulation log when showing patron's log When viewing a patron if you click the 'Modification log' tab you are presetned with both their circulation and members logs: https://staff.arcadiapl.bywatersolutions.com/cgi-bin/koha/tools/viewlog.pl?do_it=1&modules=MEMBERS&modules=CIRCULATION&object=152309&src=circ However, in bug 19791 the modules were locked to 'MEMBERS' if the src=circ We need to add CIRCULATION in as well Test plan: For master follow the test plan on bug 25250. Bug 24982 is not in stable branch, so test plan for stable branches: 1. Modify a patron, add them a fine, and do a checkout 2. Click the "Modification logs" => You see the Patrons and Circulation logs 3. Click submit => You see all patron logs only 4. Apply this patch 5. Click the "Modification logs" => You see the Patrons and Circulation logs 6. Click submit => You see the Patrons and Circulation logs Signed-off-by: Frédéric Demians Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 7b23e92d5f77d930f504739ca61789f44e416313 Author: Nick Clemens Date: Wed Apr 22 14:40:17 2020 +0000 Bug 25250: (bug 24982 follow-up) Don't disable checkboxes if modification log If we are coming from the "Modification logs" of the patron module we should not disable the checkboxes (that are not visible). Otherwise the logs are not longer filtered and all are visible. Test plan: 0. Don't apply this patch 1. Modify a patron, add them a fine, and do a checkout 2. Click the "Modification logs" => You see the Patrons and Circulation logs 3. Click submit => You see all the logs (KO) 4. Apply this patch 5. Click the "Modification logs" => You see the Patrons and Circulation logs 6. Click submit => You see the Patrons only (KO) 7. Apply the patch from bug 25249 8. Click the "Modification logs" => You see the Patrons and Circulation logs 9. Click submit => You see the Patrons and Circulation logs (OK!) Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 40cc8075588523913ca1f97b87831a9e68b53cb3 Author: Martin Renvoize Date: Mon Apr 27 11:39:19 2020 +0100 Bug 23081: DBIC Update Signed-off-by: Martin Renvoize commit 93c0f4420d22a510d56dd04bf11fad6b413e657c Author: Martin Renvoize Date: Mon Apr 27 11:34:29 2020 +0100 Bug 23081: DBRev 19.12.00.080 Signed-off-by: Martin Renvoize commit 652f16d19419d56d9f5258c77b7494889f113d81 Author: Jonathan Druart Date: Mon Apr 27 11:55:15 2020 +0200 Bug 23081: Adjust tests Signed-off-by: Lucas Gass Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit abc00eb1cfd1ee018396d6df04e6f28d7b363dbb Author: Jonathan Druart Date: Mon Apr 27 11:51:35 2020 +0200 Bug 23081: Revert "Bug 24443: Consider NULL as 0 for issues in items search" This reverts commit 80f1374f262544a750b5d81a7d9605c8708c53b1. Signed-off-by: Lucas Gass Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit e116f744a02b1f2cdf040c7bdf25498641bbc674 Author: Andrew Fuerste-Henry Date: Sun Apr 26 23:53:26 2020 +0000 Bug 23081: atomicupdate for change to existing installs Signed-off-by: Lucas Gass Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit ec1bfd2b749b8ed9bd8688abdd47b9736ba872d0 Author: Andrew Fuerste-Henry Date: Sun Apr 26 23:51:25 2020 +0000 Bug 23081: set default to 0 for items.issues and deleteditems.issues To test: - save and run this sql query in reports: select sum(if(issues is null,1,0)),sum(if(issues=0,1,0)) from items - you should see a lot of nulls and no zeros - apply patch - updatedatabase - re-run your query and see that your nulls have changed to zeros - create a new item - rerun your query and see your new item is counted in the zeros, not the nulls Signed-off-by: Lucas Gass Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit b50641b4791f68a119ce5060c852e02cdb523956 Author: Joseph Sikowitz Date: Sat Apr 18 16:06:05 2020 -0400 Bug 24750: Instructor Search Results Adds regex to the split() of the passed parameters to improve searching. Test plan 1. Go to Course Reserves module. 2. Press New course button. 3. Make active the instructor search box. 4. Start typing the last name of a patron that exists in your database. 5. At the end of the last name type ", " and try to add a first name. 6. The search should fail. 7. Apply the patch. 8. Follow steps 1-5 again. 9. You should now be able to search using the following methods 9a. surname, firstname 9b. firstname surname Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 866c6850e07411b37aae15f00444802ef1919c1b Author: Jonathan Druart Date: Tue Apr 21 14:30:19 2020 +0200 Bug 5161: Keep patron's attributes on warning/duplicate When a patron is added or modified and a warning appears (duplicate, inconsistent data, etc.) the form lost the patron's attributes. Test plan: Create some attribute types for patrons Create a new patron, use an userid that already exists and fill the attributes => You get a warning and the attributes are kept Modify the userid and save again Edit the same patron Modify the attributes, as well as the userid (to get the duplicate warning) => You get a warning and the attributes are kept with the modified values Modify the userid and save again => The new values are saved Edit the attributes from the detail page (so not with the full edit form) Modify them and save => The new values are saved Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 41873b21c894a4be1459b5ba1d93a28fa3b45ea4 Author: Lucas Gass Date: Tue Apr 21 21:33:03 2020 +0000 Bug 25233: Staff XSLT material type label "Book" should be "Text" This patch makes the staff client XSLT stylesheets consistent with the ones for the OPAC, it also makes consitent the use of 'Text' when the leader6 = 't' TO TEST: 1. Have a record with leader06 = 'a' and leader07 = 'c' 'd' or 'm'. 2. Check the staff client results and details page. See that the material type label says "Book" 3. Check the OPAC client results and details page. See that the materila type label says "Text" 4. Apply patch. 5. See that both staff client and OPAC results/details all now say "Text" 6. Set the leader6 = 't' and make sure that is says 'Text' on both the staff client and OPAC Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Items.pm | 3 --- Koha.pm | 2 +- Koha/Schema/Result/Deleteditem.pm | 7 ++++--- Koha/Schema/Result/Item.pm | 7 ++++--- admin/marctagstructure.pl | 12 +++++------ circ/ysearch.pl | 2 +- installer/data/mysql/kohastructure.sql | 4 ++-- installer/data/mysql/updatedatabase.pl | 10 +++++++++ .../intranet-tmpl/prog/en/modules/tools/viewlog.tt | 1 + .../prog/en/xslt/MARC21slim2intranetDetail.xsl | 4 ++-- .../prog/en/xslt/MARC21slim2intranetResults.xsl | 4 ++-- koha-tmpl/intranet-tmpl/prog/js/viewlog.js | 12 +++++------ members/memberentry.pl | 24 ++++++++++------------ t/db_dependent/Items.t | 4 ++-- 14 files changed, 52 insertions(+), 44 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 27 13:19:34 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 27 Apr 2020 11:19:34 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1901-g19a241c131 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 19a241c131f03a2640044ac3280759b2e6fd35bc (commit) via 8d77db27691f22f697c665821f5fb3ddaa69be14 (commit) from a852fae89a8d358f314d93dc7554dea72492e285 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 19a241c131f03a2640044ac3280759b2e6fd35bc Author: Martin Renvoize Date: Mon Apr 27 11:51:08 2020 +0100 Bug 25045: (RM follow-up) Add the RESTPublicAnonymousRequests syspref The atomic update alos included a quoting mistake Signed-off-by: Martin Renvoize commit 8d77db27691f22f697c665821f5fb3ddaa69be14 Author: Jonathan Druart Date: Mon Apr 27 12:47:08 2020 +0200 Bug 25045: (follow-up) Add the RESTPublicAnonymousRequests syspref Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/sysprefs.sql | 2 +- installer/data/mysql/updatedatabase.pl | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 27 13:22:32 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 27 Apr 2020 11:22:32 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1902-g1a40ed3887 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 1a40ed3887f19fa40ac8a1d517fdc48434b70a2b (commit) from 19a241c131f03a2640044ac3280759b2e6fd35bc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1a40ed3887f19fa40ac8a1d517fdc48434b70a2b Author: Phil Ringnalda Date: Tue Apr 21 21:34:33 2020 -0700 Bug 25235: Rename the button instead of alerting when replacing an existing record Test plan: Pre-patch 1 - Go to the main Authorities page, search for any authority, click the Actions menubutton and choose Edit 2 - Note the button saying Z39.50 search 3 - Note the modal alert forcing you to click it 4 - Cancel and cancel again, and in the New authority menubutton choose Default 5 - Click the button saying Z39.50 search again, note that it warns you about replacing your totally blank record Apply this patch 6 - Edit an existing authority, note the button says "Replace record via Z39.50/SRU search" 2 - Click the button, verify it still opens the search window with the main entry of the record filled in without an alert 3 - Create a new authority, note the button says "Z39.50/SRU search" 4 - Click the button, verify it still opens the search window but without an alert Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/authorities/authorities.tt | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 27 15:10:00 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 27 Apr 2020 13:10:00 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1903-g733874e24e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 733874e24eb20b10e8387d2a9df565fad284b510 (commit) from 1a40ed3887f19fa40ac8a1d517fdc48434b70a2b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 733874e24eb20b10e8387d2a9df565fad284b510 Author: Martin Renvoize Date: Mon Apr 27 13:42:11 2020 +0100 Bug 25045: (RM follow-up) Correction to updatedatebase.pl Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/updatedatabase.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Apr 27 15:53:35 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 27 Apr 2020 13:53:35 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1904-gf597c66934 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via f597c66934f5d97fca47f3ebaaddab8a532ec899 (commit) from 733874e24eb20b10e8387d2a9df565fad284b510 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f597c66934f5d97fca47f3ebaaddab8a532ec899 Author: Martin Renvoize Date: Mon Apr 27 14:22:21 2020 +0100 Bug 24298: (RM follow-up) Re-introduce TransferTrigger drop through A rebase lost the fall through for TransferTrigger as a message. This patch simply adds back in the dropped elsif statement. Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: circ/returns.pl | 3 +++ 1 file changed, 3 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Apr 28 08:24:49 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 28 Apr 2020 06:24:49 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1905-gf00a2570eb Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via f00a2570eb93f012b13d8cec04375164e6103a84 (commit) from f597c66934f5d97fca47f3ebaaddab8a532ec899 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f00a2570eb93f012b13d8cec04375164e6103a84 Author: Martin Renvoize Date: Tue Apr 28 06:55:56 2020 +0100 Bug 24897: (RM follow-up) Drop tests for es-ES notices This follow-up removes the tests for the presence and validity of the spanish translated notices. Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: xt/sample_notices.t | 1 - 1 file changed, 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Apr 28 22:49:41 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 28 Apr 2020 20:49:41 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-5-g4f868dc0b8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 4f868dc0b802c542a6746a15280e6349b64efa63 (commit) via 25ba1342c3b5e54087428fd5bdb5cc83d6cea65c (commit) via 4d91ae97a17221bcd192d5b89f2cb55056ae26dd (commit) via d611dd49aedfbe3c69c8d5042d3b0b59a6ffaf5f (commit) via 4ed4b51e4bbbcc0e968c1685a6f4eaeefc6d7e37 (commit) from c5125b3d4c3ea2acd3647f86b9b4550a9675aff5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4f868dc0b802c542a6746a15280e6349b64efa63 Author: Jonathan Druart Date: Mon Mar 30 11:35:35 2020 +0200 Bug 19475: Clear the caches at the end of the tests Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 25ba1342c3b5e54087428fd5bdb5cc83d6cea65c Author: Emmi Takkinen Date: Wed Mar 4 13:54:34 2020 +0200 Bug 19475: Don't copy holiday if it already exists in target calendar Calendars copy tool created duplicate values to database. Holidays in target calendar weren't checked before inserting new holidays. This patch fixes this. To test: 1. Add holidays for branch A 2. Copy branch A calendar to branch B 3. Repeat copy to branch B => Check database, branch B has now duplicate holidays 4. Delete holidays from branches A and B 5. Apply patch 6. Repeat steps 1-3 => Check database, no duplicates Sponsored-by: Koha-Suomi Oy Signed-off-by: Michal Denar Signed-off-by: Fridolin Somers Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 4d91ae97a17221bcd192d5b89f2cb55056ae26dd Author: Emmi Takkinen Date: Thu Mar 12 12:35:39 2020 +0200 Bug 19475: Add unit tests To test prove: t/db_dependent/Holidays.t Sponsored-by: Koha-Suomi Oy Signed-off-by: Fridolin Somers Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit d611dd49aedfbe3c69c8d5042d3b0b59a6ffaf5f Author: Martin Renvoize Date: Fri Apr 3 14:10:07 2020 +0100 Bug 9422: (RM follow-up) Rebase Correction Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 4ed4b51e4bbbcc0e968c1685a6f4eaeefc6d7e37 Author: Katrin Fischer Date: Sun Feb 10 12:09:08 2019 +0100 Bug 9422: Don't allow access to 'Upload patron images' when patronimages syspref is off In addition to checking the patron image upload permission, this adds a check for the patronimages system preference to the tools home page and sidebar. To test: - Check that the patron image upload tool only displays when - system preference patronimages is set to 'Allow' and user is either - superlibrarian or - has bath_upload_patron_images permission - Save URL of patron image uploader page - Turn off patronimages - Verify you get redirected to the home page of Koha when trying to access the page Note: this redirect is already used by the stock rotation feature. Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: C4/Calendar.pm | 38 +++++-- .../intranet-tmpl/prog/en/includes/tools-menu.inc | 4 +- .../prog/en/modules/tools/tools-home.tt | 4 +- t/db_dependent/Holidays.t | 120 ++++++++++++++++++++- tools/picture-upload.pl | 6 ++ 5 files changed, 159 insertions(+), 13 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Apr 28 23:05:06 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 28 Apr 2020 21:05:06 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-7-gb5062aaf6b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via b5062aaf6b3bb721e56cf3186fda738432f897f4 (commit) via 2fd3ac8b52e7ab4f2c8f292afb060078b2894554 (commit) from 4f868dc0b802c542a6746a15280e6349b64efa63 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b5062aaf6b3bb721e56cf3186fda738432f897f4 Author: Tomas Cohen Arazi Date: Fri Mar 27 16:38:15 2020 -0300 Bug 25006: Make Koha::Item->as_marc_field skip undefined subfields This patch makes as_marc_field skip subfields that don't have a value or contains an empty string (replicating C4::Items:1021 logic). To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Item.t => FAIL: Tests fail because the generated MARC::Field contains undef subfields. 3. Apply this patch 4. Repeat 2. => SUCCESS: Tests pass! Undefined and empty subfields are skipped! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 2fd3ac8b52e7ab4f2c8f292afb060078b2894554 Author: Tomas Cohen Arazi Date: Fri Mar 27 16:36:25 2020 -0300 Bug 25006: Regression tests This patch introduces regression tests for as_marc_field. It makes sure there are empty subfields and then uses List::MoreUtils' all to verify all generated MARC subfields contain something (i.e. the undef ones are skipped). Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: Koha/Item.pm | 3 ++- t/db_dependent/Koha/Item.t | 11 ++++++++++- 2 files changed, 12 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Apr 28 23:25:34 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 28 Apr 2020 21:25:34 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-10-gf11299f9c0 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via f11299f9c04e6223507f0b4914b3191b60d5845e (commit) via b3ecfd686d5190c937415558497024819992e8d5 (commit) via b85e53dccb76e2a462255b01c6e37f2f040b7ff2 (commit) from b5062aaf6b3bb721e56cf3186fda738432f897f4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f11299f9c04e6223507f0b4914b3191b60d5845e Author: Katrin Fischer Date: Sat Mar 28 00:46:55 2020 +0100 Bug 25012: Fix class on OPAC view link in staff detail page Probably a copy & paste error: the OPAC view link on the staff detail page currently has the class succeeding_entry_note. This patch changes it to opac_view to allow for independent styling of the link. Note: The link will only be visible when OPACBaseURL is set. To test: - Use the element inspector or check the source code for the class used on the OPAC view link on the staff detail page - Apply patch - Repeat and verify that the class has changed to opac_view Signed-off-by: David Roberts Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit b3ecfd686d5190c937415558497024819992e8d5 Author: Katrin Fischer Date: Sat Mar 28 00:54:21 2020 +0100 Bug 25013: Fix capitalization: Edit Items on batch item edit Fixes a tiny string issue: Edit Items --> Edit items To test: - Go to tools / batch item edit - Enter a barcode - Check the heading above the edit item form - Apply patch - Verify the heading is now properly capitalized Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit b85e53dccb76e2a462255b01c6e37f2f040b7ff2 Author: Katrin Fischer Date: Sat Mar 28 01:05:14 2020 +0100 Bug 25014: Fix capitalization for "Call Number" in staff and OPAC sort options There are some ocurrences of "Call Number" in the sort option lists in staff and OPAC. The patch changes them to "Call number". To test: - Check the sort option list in staff and OPAC for the typo - Apply patch - Verify it's now all corrected Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/includes/resort_form.inc | 4 ++-- koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt | 4 ++-- koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt | 2 +- koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/includes/resort_form.inc | 2 +- 5 files changed, 7 insertions(+), 7 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Apr 28 23:46:31 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 28 Apr 2020 21:46:31 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-12-gd35bcd9bb8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via d35bcd9bb8890b8ad2121e21e5e4f44adf571b3e (commit) via 0a505e0b08f92ee0c4131a036028e13896271740 (commit) from f11299f9c04e6223507f0b4914b3191b60d5845e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d35bcd9bb8890b8ad2121e21e5e4f44adf571b3e Author: Katrin Fischer Date: Thu Mar 26 22:30:52 2020 +0000 Bug 17938: Fix display of label for repeated MARC 583 - Action note fields When there are mulitple 583 on a record, the label "Action note" will be repeated for each. This fixes it, so that the label only appears once and multiple fields are separated by | following the existing pattern. Also makes sure there is a space between $z and other subfields. Note: Ind. 1 = private - These won't display in the OPAC Ind. 1 = 0 or empty - These will display in the OPAC Staff will display all 583 independent from indicator. To test: - Add one or more records with none, one and muliple 583, at least one including $z For examples see: http://www.loc.gov/marc/bibliographic/bd583.html - Verify display problems - Apply patch - Verify display is improved - one label and $z is followed by a space Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 0a505e0b08f92ee0c4131a036028e13896271740 Author: Katrin Fischer Date: Sat Mar 28 01:22:35 2020 +0100 Bug 24941: Serials - Fix link to basket from acquisition details information Adding orders from subscriptions makes acquisition information visible in the serials module. In the table of acquisition data is a link back to the basket - but this link is missing the basket number parameter - it doesn't work. This patch fixes the TT variable to make it work. To test: - Add a subscription - Add a new basket - Add a order line using "Add from subscription" - Go to the subscription details page, check the acquisitions tab - Try the link to the basket - it should not work - Apply patch - Try the link again - now it should bring up the basket page with the order. Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/serials/subscription-detail.tt | 2 +- .../prog/en/xslt/MARC21slim2intranetDetail.xsl | 37 +++++++++++----------- .../bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 29 ++++++++--------- 3 files changed, 33 insertions(+), 35 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Apr 29 00:07:53 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 28 Apr 2020 22:07:53 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-14-g49cb58f60f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 49cb58f60f88538d7012730eb409bd12710ae6e9 (commit) via 276e271ef4ec7c6d5196a3214663996b4cd289db (commit) from d35bcd9bb8890b8ad2121e21e5e4f44adf571b3e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 49cb58f60f88538d7012730eb409bd12710ae6e9 Author: Nick Clemens Date: Mon Dec 30 19:27:26 2019 +0000 Bug 19014: [19.11.x] Prevent auto_renew notices form sending if too early to renew Bug 19014: Unit tests Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize Bug 19014: Return auto_too_soon before on_reserve Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize Bug 19014: on_reserve blocks auto_renew Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 276e271ef4ec7c6d5196a3214663996b4cd289db Author: Owen Leonard Date: Tue Mar 31 14:20:23 2020 +0000 Bug 25022: Display problem in authority editor with repeatable field This patch corrects an error in the structure of the authority editor template so that repeating subfields do not generate invalid markup. The correction was found by comparing with addbiblio.tt. If you are viewing the diff, please note that some minor whitespace changes have been made. To reproduce, clone and and populate any repeatable subfield, save, and open the authority for editing again. The clones subfield will be formatting incorrectly, showing bullet points on each line. To test, apply the patch and reload the authority editor showing the record with the cloned subfield. It should display correctly. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 202 +++++++++++---------- .../prog/en/modules/authorities/authorities.tt | 25 ++- t/db_dependent/Circulation.t | 20 +- 3 files changed, 134 insertions(+), 113 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Apr 29 17:53:10 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 29 Apr 2020 15:53:10 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1926-g0bb0b6c7b4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 0bb0b6c7b42428320603896233f45ea5f4af670c (commit) via b33d69684f24249fd14c668fd2164cea380697db (commit) via b6d25fbb674ed58c727987b0a952efaadf27a305 (commit) via 5d36a311fe7dfcd99fd4ac31abca606cc815b280 (commit) via af60dd912a1a3b732bce359b63cfd88a93217cd5 (commit) via 665d651e95145ed38e2a5c796c70bf7b43f48042 (commit) via 9d879dd1eedd99791e9c7e8acb9f5e6dbea81434 (commit) via fa1d3a5a4858bd30e3e6b1d1ccd169f731aadb45 (commit) via a6fbb69c96f695df162e15486da568d27b70fa0f (commit) via 4df3899bc9d09e41138162f7d469221df23dd3bf (commit) via a357079d66b1038e536de72b916dcb7bdb5bf1f9 (commit) via 58bec27564ad92a19ce2eed71f49f3630dbd7c98 (commit) via 1e53d94882bc9abbbfb397b4b980b85aad72e630 (commit) via 0b72e7d6669ea67b73686d6a57ae014707ca0ba0 (commit) via c901dfdeaa5350303e8df5bd2bb92d8e925fe20d (commit) via 971acda4808cda708ec320f997c7f8702e7e2f62 (commit) via 7fa460486ddd887d1bebe00844d6a8e7eba85cce (commit) via 1cd34826643ab0443d4bebef4e106e7f03cd6587 (commit) via d2d53878f6020bff540fc9249b793e5effb3f0dd (commit) via 21ed06369c83ceaf4a4ed67cd4df424acc8efb85 (commit) via 02e8368fad7c566ec8956d5dc9ca5c851931fe12 (commit) from f00a2570eb93f012b13d8cec04375164e6103a84 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0bb0b6c7b42428320603896233f45ea5f4af670c Author: Tomas Cohen Arazi Date: Thu Apr 2 18:40:49 2020 -0300 Bug 25048: Make successful resource deletion return 204 This patch adapts the spec and the controllers so existing routes return 204 and an empty response body when a successful deletion happens. Right now we have a coding guideline but haven't adapted the existing routes. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/*.t => FAIL: Some tests fail 3. Apply this patch 4. Repeat 2. => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: David Nind Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit b33d69684f24249fd14c668fd2164cea380697db Author: Tomas Cohen Arazi Date: Thu Apr 2 18:38:33 2020 -0300 Bug 25048: Regression tests This patch adds regression tests for the response bodies and statuses on DELETE actions against existing API routes. This is just enforcing the existing (voted) Coding guidelines for the API (tm). To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/*.t => FAIL: Several routes have problems Signed-off-by: David Nind Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit b6d25fbb674ed58c727987b0a952efaadf27a305 Author: Jonathan Druart Date: Wed Apr 15 11:02:39 2020 +0200 Bug 25032: Add missing utf8 flag in koha-common.postinst Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit 5d36a311fe7dfcd99fd4ac31abca606cc815b280 Author: Tomas Cohen Arazi Date: Tue Apr 14 17:50:58 2020 -0300 Bug 25032: Chomp stringified exception If we catch a Koha::Exception-derived exception, the log is put in a single line. If the code 'dies' then a newline character is appended to the string. This patch chomps it so it displays in a single line. To test: 1. Tweak Koha::REST::V1::Cities::list in the try block so it dies before render 2. Restart plack and try the original test plan => FAIL: Notice two lines are logged 3. Apply this patch 4. Repeat 2 => SUCCESS: Only one line in the logs 5. Verify rendering a Koha::Exception works as well: Koha::Exceptions::Exception->throw("Nada!"); Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit af60dd912a1a3b732bce359b63cfd88a93217cd5 Author: Tomas Cohen Arazi Date: Thu Apr 2 14:43:27 2020 -0300 Bug 25032: Make existing controllers use unhandled_exception This simple patch removes 'just in case' handling of specific exceptions and makes the current routes controllers use the unhandled_exception helper. Most possible exceptions are already catch by our tools (Koha::Object, etc) and the existing code is not looking for known possible exceptions but has just been copied and pasted since our beginings. Anytime a situation in which an unhandled exception is caught, we (the devs) should report it and specific exception handling discussed and solved. But this has just been useless scaffolding so far. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/*.t => SUCCESS: Tests pass 2. Apply this patch 3. Repeat 1. => SUCCESS: Tests still pass 4. Sign off :-D Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit 665d651e95145ed38e2a5c796c70bf7b43f48042 Author: Tomas Cohen Arazi Date: Tue Mar 31 18:43:02 2020 -0300 Bug 25032: Generic unhandled exception handling on API This patch adds Koha::Logger as the default logger for the API, and introduces a new helper plugin that takes care of handling the unhandled exceptions. Basically, with this we would write something like this in our controller methods: try { ... } catch { if ( know_exception ) { handle_known_exception($_); } $c->unhandled_exception($_); } Without this, we end up adding more and more handling 'just in case'. To test: 1. Edit the Koha/REST/V1/Cities.pm 'list' method adding die("Nada"); before the render step. 2. Restart plack and try the endpoint => FAIL: A generic error is displayed, and no traces of the original problem are found on the logs. 3. Apply this patches, make sure your instance's log4perl has the introduced lines for API with the right path. 4. Repeat 2 => SUCCESS: The message is still generic, but you see something is logged in /var/log/koha/kohadev/api-error.log 5. Change die("Nada"); for a real exception like: use Koha::Exceptions; Koha::Exceptions::DuplicateObject->throw("Nada"); 6. Repeat 2. => SUCCESS: The message is generic, but a meaningful text is added to the logs. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit 9d879dd1eedd99791e9c7e8acb9f5e6dbea81434 Author: Tomas Cohen Arazi Date: Tue Mar 31 18:42:25 2020 -0300 Bug 25032: Add 'api' target to log4perl.conf Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit fa1d3a5a4858bd30e3e6b1d1ccd169f731aadb45 Author: Lucas Gass Date: Wed Apr 15 21:42:36 2020 +0000 Bug 25072: Fix details.tt print CSS TO TEST: -Search for something in the catalog and go to the details page. -Try to print either for the Print button in Koha or File->Print... -Notice the large amount of whitespace on the left -Apply patch -Reload detaials page and attempt to print again. -No whitespace on left side Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit a6fbb69c96f695df162e15486da568d27b70fa0f Author: David Cook Date: Tue Apr 28 11:40:23 2020 +1000 Bug 25299: Show soon to expire patron date This patch fixes the call to show the patron expiry date on the Details page when the patron is soon to expire. Test plan: 0. Do not apply patch yet 1. Create a patron 2. Set patron's date expiry to 3 days from today 3. Go to Details tab 4. Note message "Expiration: Patron's card will expire soon. Patron's card expires on Renew or Edit details" 5. Apply patch 4. Note message pattern "Expiration: Patron's card will expire soon. Patron's card expires on XX/XX/XXXX Renew or Edit details" Signed-off-by: Frédéric Demians Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 4df3899bc9d09e41138162f7d469221df23dd3bf Author: David Cook Date: Tue Apr 28 12:00:15 2020 +1000 Bug 25300: Fix typo in "Edit details" for expiring/expired patron This patch removes a typo in the argument to the "op" parameter for the "Edit details" link when editing an expiring/expired patron on the Details page. Test plan: 0. Do not apply patch yet 1. Create patron 2. Set expiry date to 3 days from now 3. Go to Details tab in patron record 4. Click "Edit details" in "Library use" section 5. Note the form is blank and has no patron data in it 6. Apply the patch 7. Reload the Details page in patron record 8. Click "Edit details" in "Library use" section 9. Note the form now contains your patron data and will work for editing the details Signed-off-by: Frédéric Demians Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit a357079d66b1038e536de72b916dcb7bdb5bf1f9 Author: Owen Leonard Date: Tue Apr 28 11:25:22 2020 +0000 Bug 25282: (follow-up) More corrections This patch adds more corrections missed in the first patch: - Tools -> Patron clubs (in the Clubs table) - Circulation -> Article requests (removed a couple of divs made redundant by the re-used BLOCK) - Tools -> Plugins home Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 58bec27564ad92a19ce2eed71f49f3630dbd7c98 Author: Owen Leonard Date: Mon Apr 27 21:41:08 2020 +0000 Bug 25282: Correct Bootstrap dropdown button markup Incorrect markup surrounding Bootstrap dropdown buttons causes display problems with the buttons are in a DataTable. Dropdown wrapper

s must have a "btn-group" class. To reproduce the problem, look at the MARC bibliographic frameworks page. The "Actions" menu when triggered will not line up with the button. In almost all cases, dropdown buttons inside tables should also have the "dropup" class on their wrapper so that the menu appears above the button. This prevents the menu from disappearing off the bottom of the window when the button is positioned low in the viewport. To test, apply the patch and test the button menus in tables on the following pages: - Acquisitions -> Invoices - Acquisitions -> Add to order -> From external source -> Results - Acquisitions -> Suggestions - Administration -> Budgets - Administration -> Funds - Administration -> Authority types - Administration -> Authority types -> MARC structure - Administration -> MARC bibliographic frameworks - Administration -> MARC bibliographic frameworks -> MARC structure - Administration -> OAI sets configuration - Administration -> Z39.50/SRU servers - Authorities -> Authority search results - Authorities -> New from Z39.50/SRU -> Search results - Cataloging -> Edit items - Cataloging -> New from Z39.50/SRU -> Search results - Circulation -> Article requests - Reports -> Saved reports - Tools -> Patron lists - Tools -> Rotating collections - Serials -> Serials search results Signed-off-by: Phil Ringnalda Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 1e53d94882bc9abbbfb397b4b980b85aad72e630 Author: Didier Gautheron Date: Mon Apr 27 14:42:49 2020 +0200 Bug 25291: Escape barcode in ReturnClaims table display Test Plan: 1) Set ClaimReturnedLostValue 2) Create a checkout 3) Claim a return 4) Change the barcode to something with html inside, will do Without this patch cgi-bin/koha/members/moremember.pl claim tab barcode link is broken. Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 0b72e7d6669ea67b73686d6a57ae014707ca0ba0 Author: Martin Renvoize Date: Fri Mar 6 09:00:08 2020 +0000 Bug 24815: Add additional tests Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit c901dfdeaa5350303e8df5bd2bb92d8e925fe20d Author: Martin Renvoize Date: Thu Mar 5 16:11:33 2020 +0000 Bug 24815: Correct return values of Koha::Cash::Register relations This patch correct all cases of return undef to instead return an empty resultset. Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 971acda4808cda708ec320f997c7f8702e7e2f62 Author: Nick Clemens Date: Mon Apr 27 11:37:13 2020 +0000 Bug 25229: (follow-up) Move QueryBuilder test to Elasticsearch dir Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 7fa460486ddd887d1bebe00844d6a8e7eba85cce Author: Nick Clemens Date: Tue Apr 21 13:47:59 2020 +0000 Bug 25229: Return authid of record rather than 001 Signed-off-by: Frédéric Demians Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 1cd34826643ab0443d4bebef4e106e7f03cd6587 Author: Nick Clemens Date: Mon Apr 27 11:28:51 2020 +0000 Bug 25229: Unit test Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit d2d53878f6020bff540fc9249b793e5effb3f0dd Author: Kyle M Hall Date: Mon Apr 27 07:07:12 2020 -0400 Bug 25227: Display correct message if item is withdrawn and withdrawn returns are allowed Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 21ed06369c83ceaf4a4ed67cd4df424acc8efb85 Author: Kyle M Hall Date: Tue Apr 21 07:11:08 2020 -0400 Bug 25227: Display correct message if item is lost and lost returns are allowed Even if a library allows returns of lost items, the SIP server returns the error message "Item lost, return not allowed" if the checkin was not ok for any reason other than it being withdrawn ( and withdrawn items not being returnable ). The most clear example of this is that when a lost item is not checked out to a patron and is returned. SIP returns that message even though lost items *can* be returned. The actual problem being that the item was not checked out. Test Plan: 1) Ensure you can return lost items 2) Mark an item as lost 3) Check it in via SIP 4) Note the message you get back is "Item lost, return not allowed" 5) Apply this patch 6) Restart your SIP server 7) Repeat steps 2 and 3 8) Note you no longer get the incorrect message! Signed-off-by: Frédéric Demians Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 02e8368fad7c566ec8956d5dc9ca5c851931fe12 Author: Kyle M Hall Date: Mon Apr 27 08:04:07 2020 -0400 Bug 25227: Add unit tests Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/SIP/ILS.pm | 4 +- Koha/Cash/Register.pm | 11 +- Koha/Exceptions/ClubHold.pm | 2 +- Koha/REST/Plugin/Exceptions.pm | 86 +++++++++++++++ Koha/REST/V1.pm | 3 + Koha/REST/V1/Acquisitions/Funds.pm | 9 +- Koha/REST/V1/Acquisitions/Orders.pm | 73 +++---------- Koha/REST/V1/Acquisitions/Vendors.pm | 81 ++++++-------- Koha/REST/V1/Biblios.pm | 18 +--- Koha/REST/V1/Checkouts.pm | 109 ++++++++++--------- Koha/REST/V1/Cities.pm | 62 ++++------- Koha/REST/V1/Clubs/Holds.pm | 26 +---- Koha/REST/V1/Holds.pm | 116 ++++++++------------- Koha/REST/V1/Items.pm | 36 ++----- Koha/REST/V1/Libraries.pm | 76 ++++---------- Koha/REST/V1/Patrons.pm | 72 ++++--------- Koha/REST/V1/Patrons/Account.pm | 59 +++++------ Koha/REST/V1/Patrons/Password.pm | 25 +++-- Koha/REST/V1/ReturnClaims.pm | 47 +-------- Koha/SearchEngine/Elasticsearch/Search.pm | 10 +- api/v1/swagger/paths/acquisitions_orders.json | 5 +- api/v1/swagger/paths/acquisitions_vendors.json | 7 +- api/v1/swagger/paths/cities.json | 7 +- api/v1/swagger/paths/holds.json | 7 +- api/v1/swagger/paths/patrons.json | 7 +- debian/koha-common.postinst | 13 +++ debian/templates/log4perl-site.conf.in | 8 ++ etc/log4perl.conf | 8 ++ koha-tmpl/intranet-tmpl/prog/css/print.css | 5 + .../intranet-tmpl/prog/en/includes/clubs-table.inc | 2 +- .../prog/en/modules/acqui/invoices.tt | 2 +- .../prog/en/modules/acqui/z3950_search.tt | 2 +- .../prog/en/modules/admin/aqbudgetperiods.tt | 2 +- .../prog/en/modules/admin/aqbudgets.tt | 2 +- .../prog/en/modules/admin/auth_tag_structure.tt | 2 +- .../prog/en/modules/admin/authtypes.tt | 2 +- .../prog/en/modules/admin/biblio_framework.tt | 4 +- .../prog/en/modules/admin/marctagstructure.tt | 2 +- .../prog/en/modules/admin/oai_sets.tt | 2 +- .../prog/en/modules/admin/z3950servers.tt | 2 +- .../en/modules/authorities/searchresultlist.tt | 2 +- .../prog/en/modules/cataloguing/additem.tt | 2 +- .../en/modules/cataloguing/z3950_auth_search.tt | 2 +- .../prog/en/modules/cataloguing/z3950_search.tt | 2 +- .../prog/en/modules/circ/article-requests.tt | 6 +- .../prog/en/modules/members/moremember.tt | 6 +- .../prog/en/modules/patron_lists/lists.tt | 2 +- .../prog/en/modules/plugins/plugins-home.tt | 2 +- .../en/modules/reports/guided_reports_start.tt | 46 ++++---- .../rotating_collections/rotatingCollections.tt | 2 +- .../prog/en/modules/serials/serials-search.tt | 2 +- .../prog/en/modules/suggestion/suggestion.tt | 4 +- koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 8 +- .../QueryBuilder.t | 0 t/Koha/SearchEngine/Elasticsearch/Search.t | 65 ++++++++++++ t/db_dependent/Koha/Cash/Register.t | 52 ++++++++- t/db_dependent/SIP/Transaction.t | 78 +++++++++++++- t/db_dependent/api/v1/acquisitions_vendors.t | 12 +-- t/db_dependent/api/v1/cities.t | 4 +- t/db_dependent/api/v1/holds.t | 21 ++-- t/db_dependent/api/v1/patrons.t | 5 +- 61 files changed, 687 insertions(+), 652 deletions(-) create mode 100644 Koha/REST/Plugin/Exceptions.pm rename t/Koha/SearchEngine/{ElasticSearch => Elasticsearch}/QueryBuilder.t (100%) create mode 100644 t/Koha/SearchEngine/Elasticsearch/Search.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Apr 29 18:11:40 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 29 Apr 2020 16:11:40 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-15-g1a20da353e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 1a20da353e6d96a121c7862b0920842c46769007 (commit) from 49cb58f60f88538d7012730eb409bd12710ae6e9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1a20da353e6d96a121c7862b0920842c46769007 Author: Martin Renvoize Date: Thu Dec 5 17:42:50 2019 +0000 Bug 24183: Add before_send_messages hook This patch adds a simple hook to the process_message_queue cronjob to allow plugins to pre-process messages in the messaging queue before they are sent. Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: misc/cronjobs/process_message_queue.pl | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Apr 29 18:31:29 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 29 Apr 2020 16:31:29 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-20-g300dbea812 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 300dbea81219245614d95599c7cd98c51a005242 (commit) via 96956fee2440f20a112bc1413253d6043ada704f (commit) via 6c962a7d5af5117fc7f858b2a78ddb818b679397 (commit) via 62b6e283a2c72d5e8c7f7f9a048df44fba2de8c3 (commit) via b3d97ce0294bebd89c65830b1851cea5d936f0c4 (commit) from 1a20da353e6d96a121c7862b0920842c46769007 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 300dbea81219245614d95599c7cd98c51a005242 Author: Jonathan Druart Date: Mon Apr 6 11:44:18 2020 +0200 Bug 24964: [19.11.x] Do not fetch all patrons for owner/users of funds admin/add_user_search.pl sets 'patrons_with_acq_perm_only', to only retrieve patrons with acq (order_manage) permissions. The original bug was hidden in the existing code, but the behavior was terrible. To prevent patrons matching the permissions contrainst to be hidden, we fetched ALL the patrons from the DB, then filtered them depending on their permissions. This might have awful performance on DB with lot of patrons. So basically with this patch we are adding the pagination back to the "owner/users for funds" feature, as the permission filtering is now done at DB level. Signed-off-by: Joy Nelson commit 96956fee2440f20a112bc1413253d6043ada704f Author: Kyle M Hall Date: Thu Mar 26 08:53:59 2020 -0400 Bug 24964: [19.11.x] Fix perl critic warning Signed-off-by: Kyle M Hall Signed-off-by: Joy Nelson commit 6c962a7d5af5117fc7f858b2a78ddb818b679397 Author: Jonathan Druart Date: Wed Mar 25 13:50:45 2020 +0100 Bug 24964: [19.11.x] Prevent random failures sorting by borrowernumber Signed-off-by: Fridolin Somers Signed-off-by: Kyle M Hall Signed-off-by: Joy Nelson commit 62b6e283a2c72d5e8c7f7f9a048df44fba2de8c3 Author: Jonathan Druart Date: Wed Mar 25 11:21:15 2020 +0100 Bug 24964: [19.11.x] Do not filter patrons after they have been fetched The svc/members/search script is called in different places. In some places (Set owner for a fund, add users to a fund, or set a manager to a suggestion), we need patrons to be filtered depending on the permissions they have. For instance you can only set a fund's owner with a patron that has acquisition.order_manage. Currently we have fetching X (default 20) patrons, then filter them depending on their permission. Says you have 3 patrons that have the correct permissions but are not in the 20 first patrons, if you do not define a search term, the search result will be empty. This is not ideal and we should filter when requesting the DB. Test plan: - Have more than 20 patrons, remove them their permissions - Create 3 more: 1 superlibrarian 1 with the full acq permission 1 with acquisition.order_manage - Create a fund and set a owner - Search for patrons, without specifying a search term (to get them all) => Without this patch the new patrons you created are not displayed => With this patch they are! Same test plan apply to set a manager to a suggestion (freshly pushed, see bug 23590), with suggestions and suggestions.suggestions_manage Note: The code has been written that way to rely on C4::Auth::haspermission, but the SQL query is quite trivial and the gain is important. Signed-off-by: Fridolin Somers Signed-off-by: Kyle M Hall Signed-off-by: Joy Nelson commit b3d97ce0294bebd89c65830b1851cea5d936f0c4 Author: Jonathan Druart Date: Wed Mar 25 11:20:20 2020 +0100 Bug 24964: [19.11.x] Add tests Signed-off-by: Fridolin Somers Signed-off-by: Kyle M Hall Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: C4/Utils/DataTables/Members.pm | 43 +++++++++++--- .../prog/en/modules/common/patron_search.tt | 8 +-- svc/members/search | 30 ++-------- t/db_dependent/Utils/Datatables_Members.t | 68 ++++++++++++++++++++-- 4 files changed, 106 insertions(+), 43 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Apr 29 19:03:50 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 29 Apr 2020 17:03:50 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-1954-gcb390a35d6 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via cb390a35d637d8f74cc7103ceff60f0a1a4283fc (commit) via 7761051a831ffbe135b994ab3b67273e7bdaa63e (commit) via afec0fb4997524cde1c2ac6ac0c0ab66f9c5d67b (commit) via 9ea7fbcb30bf4b4879d4eb68c940316024c08760 (commit) via f0cbb2063aa17b9832cc89bdd7a532d826dc48c8 (commit) via e03e5a2ecee3c7c773e1cce418703a88cc53bb53 (commit) via cad8d450356a0865ab52880b2e06e9e59e9f3db8 (commit) via cfb73860dcc3ead3fc955ff55303c935aca1f04a (commit) via 94097761d518c37afab52ab91f8149d3b45e29d8 (commit) via 18ea57a92f9fefcb471e094a41b8b51a55a42711 (commit) via 5fed21f065592073e197a062375332903073dba5 (commit) via a51afd969819eb5fabc8a44d14992aa660c6664c (commit) via 605d6c9b6ef6cb6ee3bd10a5d418ca9871f69e13 (commit) via 3ecc5d59fe05c70b34a70afd788dc0a1b612f064 (commit) via d37a3576f21a5eb1ad09efb1080e66fec452c1f6 (commit) via ddad175f1131442b60513370b2cf00b0d87f1652 (commit) via 256fe470fcf92e9732d7b65940756a99febb1693 (commit) via 11bf5d7afaa92f129acca2644c6f69e0a7850093 (commit) via 8cd362a422cba66a1728e7e7d083d0b1d390edb3 (commit) via f6913e74c3b7aa7bfa3d76c4879c331daa1f108c (commit) via 9fa6bb64014f6474e86846985609d8850e0839df (commit) via feab2cbeb2179589c74524135bd2ff57b660a8e1 (commit) via 76bf4dc056f0e234344045569fee2daa63ac2e45 (commit) via 4249b20a394ea8f0addf0bcb162323a8f3cc27d5 (commit) via 5fdd436558c4a9c84e4cfac2a4d6663ee41adc9a (commit) via 985c8f1da93192622b9fdc6c9a1c410391bb983f (commit) via 8b99b6525e876dc6a1e12a117c62ea41d1bf0e43 (commit) via 738f8fe2a53b2679d15d1577d813fb072b162070 (commit) from 0bb0b6c7b42428320603896233f45ea5f4af670c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit cb390a35d637d8f74cc7103ceff60f0a1a4283fc Author: Owen Leonard Date: Thu Apr 23 11:50:34 2020 +0000 Bug 25166: (follow-up) Update icons generated in JS This patch adds aria attributes to Font Awesome icons generated by JavaScript. The icons won't appear under normal circumstances because the code for displaying the modal dialog should replace the icons with a text label. The icons are a fallback. Signed-off-by: Martin Renvoize commit 7761051a831ffbe135b994ab3b67273e7bdaa63e Author: Owen Leonard Date: Wed Apr 15 23:14:15 2020 +0000 Bug 25166: Add "aria-hidden = true" to Font Awesome icons in the OPAC Font Awesome's accessibility guidelines (https://fontawesome.com/v4.7.0/accessibility/) suggest that we include 'aria-hidden="true"' in the icon markup. This prevents screen readers from trying to read the icon. This patch adds the attribute. To test apply the patch and browse the OPAC looking for any problems with icons: On search results, bibliographic details page, the cart, lists, etc. Check the source and verify that Font Awesome icons have the "aria-hidden" attribute. Signed-off-by: Bernardo Gonzalez Kriegel Attribute present, all looks good. The 'aria-label' attribute is not translatable, but it's another problem. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit afec0fb4997524cde1c2ac6ac0c0ab66f9c5d67b Author: Owen Leonard Date: Mon Apr 27 15:21:30 2020 +0000 Bug 25294: Don't show deletion button if user can't delete suggestions This patch adds logic to the OPAC suggestions template so that when the OPACViewOthersSuggestions system preference is enabled and the logged-in user is viewing other users' suggestions, the "Delete selected" button is only displayed when there are suggestions the user can delete. To test you should have suggestions in your system from at least two users. - Set the OPACViewOthersSuggestions preference to "Show" - Log in to the OPAC as a user who hasn't submitted any suggestions - Go to the suggestions page (with "?suggested_by_anyone=1" appended to the URL if necessary, see Bug 22515). - In the table of suggetions, there should be no titles with a checkbox in the first column. - At the bottom of the table there should be no "Delete selected" button. - Log in to the OPAC as a user with suggestions. - Return to the suggestions page and view all suggestions. - There should be titles with corresponding checkboxes and the "Delete selected" button should appear at the bottom. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 9ea7fbcb30bf4b4879d4eb68c940316024c08760 Author: Owen Leonard Date: Fri Mar 27 23:35:51 2020 +0000 Bug 25002: JS Includes should be wrapped with template comments This patch adds HTML comments to Template::Toolkit include files which contain