[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.04-26-gc78e180c56

Wed Apr 1 22:57:46 CEST 2020

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.11.x has been updated
       via  c78e180c56691ed50472ec87b780135f78992868 (commit)
       via  99b12c3a98e97e12a1f3a69d0e3719701b031d42 (commit)
       via  84026f258909e1203f34793a1089388cd933d1c9 (commit)
       via  06c7de991ef72297fad75097f377889dc4438652 (commit)
       via  e145be8b6d8f36f5be968648606147775ecfaa59 (commit)
       via  175640e0a89cbc0267a41ecc5e8b5b83ba33ae7a (commit)
      from  789866e585be0a5c439559383325cbe4db525412 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit c78e180c56691ed50472ec87b780135f78992868
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Sat Feb 29 10:49:46 2020 +0100

    Bug 24736: (QA follow-up) Change tooltip wording

    Suggesting a change of the tooltip wording to read:

    There are no enrollments for this club yet

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 99b12c3a98e97e12a1f3a69d0e3719701b031d42
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Feb 26 17:46:49 2020 +0100

    Bug 24736: Disable "Enrollments" link if nobody enrolled to the club yet

    The link is disabled but it's possible to click and access the page
    anyway.

    Test plan:
    - Create a new club template
    - Create a new club
    - Click the Actions > Enrollments link
    => Without this patch you can access the page
    => With this patch applied you cannot, and a tooltip explains why (feel
    free to suggest another wording)
    - Add a new patron to this club (from /cgi-bin/koha/opac-user.pl#opac-user-clubs)
    - Notice that the action link is not enabled and click takes you to the
    list of enrollments

    Signed-off-by: David Nind <david at davidnind.com>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 84026f258909e1203f34793a1089388cd933d1c9
Author: Andrew Fuerste-Henry <andrew at Andrews-MacBook-Pro.local>
Date:   Thu Feb 27 14:09:02 2020 -0600

    Bug 24747: Corrects on-screen instructions in branch transfer limits

    To test:
    1- go to cgi-bin/koha/admin/branch_transfer_limits.pl
    2- see wording "Check the boxes for the libraries you accept to checkin items from"
    3- apply patch
    4- see wording "Check the boxes for the libraries you allow your items to be transferred to"

    To verify new wording accuractely describes behavior:
    1- Set UseBranchTransferLimits set to Enforce using itemtype
    2- Confirm circ rules allow holds
    3- Confirm hold policy by item type allows holds
    4- Confirm all branches are valid pickup locations in branch setup
    5- In Branch Transfer Limits, set dropdown to Branch A, select itemtype Book, disable all transfers so Branch A does not accept books from any other branch
    6- Find a patron from Branch A
    7- Find a book from Branch B
    8- On the intranet, successfully place hold on item for patron for pickup at branch A
    9- Cancel hold
    10- Log into opac as patron
    11- Successfully place hold on item for pickup at Branch A
    12- Cancel hold
    13- In Branch Transfer Limits, set dropdown to Branch A, select itemtype Book, ENABLE all transfers so Branch A DOES accept books from any other branch
    14- In Branch Transfer Limits, set dropdown to Branch B, select itemtype Book, disable all transfers so Branch B does not accept books from any other branch
    15- On the intranet, try to place a hold on item for patron, confirm Branch B is your only pickup option
    16- On the OPAC, log in as patron, try to place a hold on item, confirm Branch B is your only pickup option

    Signed-off-by: Kelly McElligott <kelly at bywatersolutions.com>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 06c7de991ef72297fad75097f377889dc4438652
Author: David Cook <dcook at prosentient.com.au>
Date:   Fri Feb 28 00:17:58 2020 +0000

    Bug 24739: Perform IPv6 tests only if Net::Netmask is correct version

    Test plan:
    0. Apply patch
    1. Set up Koha on stretch (e.g. koha/koha-testing:master)
    2. perl t/Koha/Middlware/RealIP.t
    3. Observe the following:
    Subtest: IPv6 support
        ok 1 - Warn on IPv6 koha_trusted_proxies
        ok 2 - Unable to parse IPv6 address for trusted proxy, so ignore the X-Forwarded-For header
        1..2
    ok 13 - IPv6 support

    4. Set up Koha on buster (e.g. koha/koha-testing:master-buster)
    5. perl t/Koha/Middlware/RealIP.t
    6. Observe the following:
    Subtest: IPv6 support
        ok 1 - Trust proxy (2001:db8:1234:5678:abcd:1234:abcd:1234) using IPv6 CIDR notation, so use the X-Forwarded-For header for the remote address
        1..1
    ok 13 - IPv6 support

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit e145be8b6d8f36f5be968648606147775ecfaa59
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Thu Feb 27 09:16:12 2020 +0000

    Bug 24739: Skip tests when IPv6 support is found

    Signed-off-by: David Cook <dcook at prosentient.com.au>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 175640e0a89cbc0267a41ecc5e8b5b83ba33ae7a
Author: David Cook <dcook at prosentient.com.au>
Date:   Fri Feb 28 00:28:02 2020 +0000

    Bug 24753: Change Koha/Middlware to Koha/Middleware in test name

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 .../intranet-tmpl/prog/en/includes/clubs-table.inc |  4 +--
 .../en/modules/admin/branch_transfer_limits.tt     |  2 +-
 t/Koha/{Middlware => Middleware}/RealIP.t          | 39 +++++++++++++++++-----
 3 files changed, 34 insertions(+), 11 deletions(-)
 rename t/Koha/{Middlware => Middleware}/RealIP.t (74%)

hooks/post-receive
-- 
main Koha release repository