[koha-commits] main Koha release repository branch master updated. v19.11.00-1666-g94ec55d767
Git repo owner
gitmaster at git.koha-community.org
Wed Apr 8 13:22:21 CEST 2020
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 94ec55d767cd9a61368757154e36e6e0d5bcafcf (commit)
via 6ac037f817def256c85706413036bee3f78ed40e (commit)
via c878a9e825ab740c2d1bc820875485cc816ed492 (commit)
via bb527d54f598f91e4373282032fbc1ab9b0515d3 (commit)
via 947b16b322b9fe719a1bef6c25d4172db3d7cc8e (commit)
via b3e15a720578b2f03ffea818bac4df585741b1a1 (commit)
via 77457a496a43d9d3bd0330d2ed511b0d1388d8b0 (commit)
via c88c8e5322d1205ca4e39409b34f8d02311182ad (commit)
via d132c10bfcff87b117ff454bb431fdbd1f08c92c (commit)
via e925568a3067e77173f4d21f476b28f8aa068571 (commit)
via 9789a43025d139d4d0b872fa0b51c0dc1df0d7dc (commit)
via df58c3e2c9af7b0218f6db957dbb781f0cb1f278 (commit)
via 2f2db163bd108e165b2e54a7258ec1176c213285 (commit)
from bad8c7089addceca18aacae14d9b7ed30a4722aa (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 94ec55d767cd9a61368757154e36e6e0d5bcafcf
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Wed Apr 8 10:43:54 2020 +0100
Bug 24840: (follow-up) Catch some further cases of DateTime->now
This patch corrects a few additional cases where DateTime->now is called
directly instead of via Koha::DateUtils.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 6ac037f817def256c85706413036bee3f78ed40e
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Mar 26 11:05:32 2020 +0000
Bug 24840: Replace DateTime->now with dt_from_string
We should use Koha::DateUtils instead of Date::Time directly
This patch simplay replaces calls to now() with a call to dt_from_string()
which does effectively the same thing.
Probably reading the code and verifying changes is sufficient but...
To test:
1 - confirm the files all compile
2 - confirm all tests pass
3 - confirm Koha still works
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit c878a9e825ab740c2d1bc820875485cc816ed492
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Apr 8 11:45:51 2020 +0200
Bug 25081: Fix wrong comment
Not directly related to previous patch, coming from 23435.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit bb527d54f598f91e4373282032fbc1ab9b0515d3
Author: Janusz Kaczmarek <januszop at gmail.com>
Date: Tue Apr 7 22:23:20 2020 +0200
Bug 25081: Fix creation of new item for a received issue
The Bug 23435 introduced the idea of multiple copies added while
receiving a new issue. Unfortunately, under some circumstances, it
causes no items being added at all. It occurs stochastically, only
under some conditions. But it is quite likely to happen while receiving
a supplemental issue.
The reason fot hist is that, in serials-edit.pl, line ca 292 and infra,
@num_copies is treated in the same way as @tags, while it should be
treated similarly to @bibnums. It will be obvious after examining the
content of parameters tag, subfield, field_value, ..., number_of_copies.
In other words, for every edited issue number_of_copies is a scalar.
Nota bene:
a) beter to initialize $countdistinct with zero;
b) note that in master, now, before applying the patch,
$itemhash{$item}->{'num_copies'} is treated once as a scalar
and in the next line--as an array:
$itemhash{$item}->{'num_copies'} //= 1;
for (my $copy = 0; $copy < $itemhash{$item}->{'num_copies'}[$index];){
TEST PLAN
=========
1. Have a subscription with the option "Create an item
record when receiving this serial" active and try to receive a
supplemental issue. Control that a new item under the biblio record
(usually) will not be created.
2. Apply the patch.
3. Repeat p. 1 -- a new item should be created.
Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 947b16b322b9fe719a1bef6c25d4172db3d7cc8e
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Fri Mar 27 12:01:05 2020 -0400
Bug 22937: Add hint to groups editor
Signed-off-by: Lisette Scheer <lisetteslatah at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit b3e15a720578b2f03ffea818bac4df585741b1a1
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Apr 8 11:28:31 2020 +0200
Bug 25046: Add test
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 77457a496a43d9d3bd0330d2ed511b0d1388d8b0
Author: Andreas Roussos <a.roussos at dataly.gr>
Date: Thu Apr 2 19:14:57 2020 +0200
Bug 25046: Include borrowers.othernames in SELECT statement
In C4/Utils/DataTables/Members.pm, the SELECT statement that fetches
patron data from the database does not include borrowers.othernames
in the field list. As a consequence, when the output is in the form
of a DataTable, the Template Toolkit files that refer to .othernames
(such as the patron-title.inc include) won't display the information
from the 'Other name' input field if that field has been filled in.
This patch fixes that.
Test plan:
0) Have a few patrons with some data in the 'Other name' field.
1) Perform a generic search in Home > Patrons to ensure you will get
a DataTable with results.
2) Observe that the 'Name' column does not include 'Other name' info.
3) Apply the patch, and restart Plack if necessary.
4) Repeat your search: this time you should see the information from
the 'Other name' field, it will be next to the patron's First name
and within parentheses.
Sponsored-by: Eugenides Foundation Library
Signed-off-by: Devinim <nazli at devinim.com.tr>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit c88c8e5322d1205ca4e39409b34f8d02311182ad
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Apr 8 10:42:41 2020 +0200
Bug 7046: Preselect dropdown option and prefill input
With previous renew values
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit d132c10bfcff87b117ff454bb431fdbd1f08c92c
Author: Alex Buckley <alexbuckley at catalyst.net.nz>
Date: Mon Nov 27 15:31:35 2017 +1300
Bug 7046: Implemented subscription renewal dropdown sub length element
To make this work I moved the _get_sub_length function from
subscription-add.pl to C4/Serials.pm so that the subscription-renew.pl
script could also call it to store the sublength for the appropriate
field of the subscriptions database table.
Test plan:
1. Create a subscription and notice that there is a dropdown box for sub
length containing the values: issues, weeks, months
2. Renew the subscription and notice that there are 3 input text boxes:
'number of num', 'number of weeks' and 'number of months'
3. Input a 'Number of weeks' value of 2
4. Query the subscription database table and notice that the value of 2
has been stored in the weeklength field for the subscription record you
just renewed
5. Apply the patch
6. Renew the subscription and notice that there is now a sublength
dropdown box containing issues, weeks and months
7. Set the month value to 3
8. Query the database and notice that 3 was stored in the monthlength
field for the subscription record
9. Create a new subscription and select the sub length values of issues
and 3
10. Query the database and notice that the numberlength field for the
subscription you just created is set to 3 showing that the sublength
dropbox is still working for creating a new subscription
Sponsored-By: Catalyst IT
Signed-off-by: Dilan Johnpullé <dilan at calyx.net.au>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit e925568a3067e77173f4d21f476b28f8aa068571
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Mar 11 16:21:06 2020 +0100
Bug 24826: Remove warnings from Sendmail
Use of uninitialized value $mail{"Cc"} in substitution (s///) at /usr/share/perl5/Mail/Sendmail.pm
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 9789a43025d139d4d0b872fa0b51c0dc1df0d7dc
Author: David Roberts <david at koha-ptfs.co.uk>
Date: Fri Apr 3 15:23:01 2020 +0000
Bug 24940: Serials statistics wizard: order vendor list alphabetically
This patch changes the dropdown from being sorted by aqbookseller.id to
aqbookseller.name
To test:
1) Add at least 2 vendors:
- First: ZZZZ
- Second: AAAA
2) Add subscriptions for each of the vendors
3) Check the pull down in the serials statistics wizard and verify it
lists them as ZZZZ, AAAA
4) Apply the patch
5) Re-check the pull down in the wizard and check that the vendors are
now listed AAAA,ZZZZ
Signed-off-by: Devinim <kohadevinim at devinim.com.tr>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit df58c3e2c9af7b0218f6db957dbb781f0cb1f278
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Mar 30 09:39:13 2020 -0300
Bug 25019: Make the ViewPolicy filter initialization standard
This patch makes the ViewPolicy filter use the 'params' accessor instead
of relying of ->{options} which has no accessor. This will allow
interacting with the filter object be similar through all the filters in
the chain.
To test, we just need to verify no behaviour change takes place:
1. Run:
$ kshell
k$ prove t/db_dependent/Filter_MARC_ViewPolicy.t
=> SUCCESS: Tests pass
2. Apply this patch
3. Repeat 1
=> SUCCESS: Tests still pass!
4. Sign off :-D
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 2f2db163bd108e165b2e54a7258ec1176c213285
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Apr 3 11:42:59 2020 +0200
Bug 25041: Restore #ASKED anchor in suggestions table
On commit 4494e8ba6ca7d28972fcc1161c680ecf0b091f62
Bug 23594: Batch modification for itemtypes on suggestions page
The anchors of the tabs on suggestion.pl has been replaced with
tab_$count instead of the status code.
There was a need at the time, but I cannot remember it.
I restored the previous behavior, and did not find any regressions.
Test plan:
1 - Add several suggestions to Koha
2 - Set them in different status, leaving at least one pending
3 - Go to home page, note it shows count of pending
4 - Click the link on home page
5 - It takes you to correct tab
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Circulation.pm | 20 ++++-----
C4/Letters.pm | 2 +-
C4/MarcModificationTemplates.pm | 3 +-
C4/Serials.pm | 25 ++++++++++-
C4/Utils/DataTables/Members.pm | 1 +
Koha/Calendar.pm | 2 +-
Koha/Checkout.pm | 3 +-
Koha/Checkouts.pm | 3 +-
Koha/EDI.pm | 5 ++-
Koha/Edifact/Order.pm | 3 +-
Koha/Edifact/Transport.pm | 3 +-
Koha/Email.pm | 4 +-
Koha/Filter/MARC/ViewPolicy.pm | 16 ++-----
Koha/Illrequest.pm | 3 +-
Koha/Patron/Password/Recovery.pm | 3 +-
Koha/Sitemapper/Writer.pm | 4 +-
Koha/StockRotationItem.pm | 12 ++---
circ/overdue.pl | 2 +-
circ/returns.pl | 6 +--
.../fix_unclosed_nonaccruing_fines_bug17135.pl | 2 +-
installer/data/mysql/updatedatabase.pl | 2 +-
.../prog/en/modules/admin/library_groups.tt | 2 +
.../prog/en/modules/serials/subscription-renew.tt | 51 ++++++++++++++--------
.../prog/en/modules/suggestion/suggestion.tt | 6 +--
members/summary-print.pl | 3 +-
misc/cronjobs/fines.pl | 2 +-
misc/cronjobs/overdue_notices.pl | 4 +-
misc/cronjobs/update_totalissues.pl | 3 +-
opac/opac-ics.pl | 2 +-
reports/serials_stats.pl | 3 +-
serials/serials-edit.pl | 8 ++--
serials/subscription-add.pl | 15 +------
serials/subscription-renew.pl | 11 +++--
t/Circulation/AgeRestrictionMarkers.t | 5 ++-
t/db_dependent/DecreaseLoanHighHolds.t | 5 ++-
t/db_dependent/Letters/TemplateToolkit.t | 2 +-
t/db_dependent/OAI/Server.t | 2 +-
t/db_dependent/Passwordrecovery.t | 11 ++---
t/db_dependent/Serials/ReNewSubscription.t | 28 +++++++++++-
t/db_dependent/Sitemapper.t | 3 +-
t/db_dependent/Utils/Datatables_Members.t | 12 ++++-
41 files changed, 190 insertions(+), 112 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list