[koha-commits] main Koha release repository branch 19.05.x updated. v19.05.09-20-gc077e5a806

Git repo owner gitmaster at git.koha-community.org
Thu Apr 9 00:28:15 CEST 2020


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.05.x has been updated
       via  c077e5a80676767cd059ebbfa8c2e8c140cc5d37 (commit)
      from  e2777a0a0d69cb5ee366e77fa82375ccff59e10c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit c077e5a80676767cd059ebbfa8c2e8c140cc5d37
Author: Maryse Simard <maryse.simard at inlibro.com>
Date:   Wed Aug 21 17:20:16 2019 -0400

    Bug 23488: Line wrapping doesn't always respect word order in Patron card creator
    
    When wrapping long lines of text, the line is divided by removing each
    word from the end of the line and putting it in a new one until the line
    is the right width. When the word to be removed appears multiple time
    in the line, it is not the last occurrence that is removed.
    
    This patch changes the regular expression used to remove the part of
    the text that is wrapped to a new line, making sure it removes it at
    the end of the text.
    
    Test plan:
    
    1. Go to Tools > Patron card creator
    
    2. Have a card template and a card batch
        -> If needs be, you can create them by using
           New > Card template or New > Card batch
    
    3. Create a layout and use one text field containing a long text with
        at least one word which is repeated a minimum of 2 times
        (preferably towrdds the end of the text, since it has to be picked
        as one of the words to appear in the new line). You can use this:
    
            one two three one two three one two three one two three
            one two three one two three one two three one two three ...
    
    4. Go to Manage > Card batches and export a batch
    
    5. Choose the layout set up in 3.
    
    6. Click the Export button and open the resulting pdf file
    
    7. Notice all the repeated word have been grouped
        -> For this example : all of the ones appear first, followed by
           all the twos and only then the threes.
    
    8. Apply patch
    
    9. Repeat step 4 through 7
        => this time the order of the words has not changed!
    
    Signed-off-by: Gabriel DeCarufel <gabriel at inlibro.com>
    Signed-off-by: William Frazilien <william.frazilien at inlibro.com>
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
    (cherry picked from commit 5811331a5a07b84c39de7485fd2d21df7d45be34)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Patroncards/Patroncard.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list