[koha-commits] main Koha release repository branch master updated. v19.11.00-1833-gc54654c129
Git repo owner
gitmaster at git.koha-community.org
Mon Apr 20 13:54:58 CEST 2020
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via c54654c12944250ed75bbdd011e6ac6cacf58d3f (commit)
via 3ba823db6ea9c77e74dcdaa4d3a88f424ea7695d (commit)
via 8218653df75cc61676ce40f2feea70bb5671614b (commit)
via 563120a004f03a96c935b179af36cace874f708c (commit)
via d8dd31142c0bfd9b09f9fa8e02fc292cf9deed2c (commit)
from 510ee153c0d0d0bc01ca1abc3cd6aa28a4d0f9ff (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit c54654c12944250ed75bbdd011e6ac6cacf58d3f
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Mon Apr 13 21:45:22 2020 +0000
Bug 13557: Add hint for on-site checkouts to list of current checkouts in OPAC
In the list of checkouts it's currently not possible for the
patront or tell the difference between normal checkouts (item
is at home with them) and on-site checouts (items remained at
the library). This patch adds a hint to the list of checkouts to
allow differentiating these kinds of checkouts.
To test:
- In your patron account, have multiple checkouts, some on-site,
some others, overdue items, etc.
- Go to: OPAC > your summary > Checked out
- Verify that there is no hint for the on-site checkouts
- Apply patch
- Check again, there should now be a note
The note also has a class, so would be easy to be hidden
or formatted differently: class="onsite_checkout".
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 3ba823db6ea9c77e74dcdaa4d3a88f424ea7695d
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Tue Apr 14 13:14:37 2020 +0000
Bug 21211: Add patron toolbar to suggestions, discharges and ill requests tabs
When paging through the patron account in staff, using the tabs on
the right, you notice that some pages are missing the patron toolbar
on top and that the headings, where they exist, vary in size.
This patch adds the patron toolbar to 3 more tabs and changes headings
to h1 to be consistent with older tabs. It has also been suggested on
another tab that this is preferrable for screen readers.
Note: Modification log was left out for now, as this is also used in tools.
To test:
- Activate ILL (ILLModule pref)
- Activate discharges (UseDischarge pref)
- Go to any patron account, tab through the tabs...
- Verify that discharge, purchase suggestions and ill requests are
missing the toolbar
- Apply patch
- Verify that the toolbar now appears on these pages and works
correctly
- Also veriy that the headings are now consistently h1 on all pages
Signed-off-by: David Roberts <david at koha-ptfs.co.uk>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 8218653df75cc61676ce40f2feea70bb5671614b
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Tue Apr 14 16:57:38 2020 +0000
Bug 18680: Add an empty entry by default to sort1/sort2 values in patron account
When using sort1/sort2 with authorised values to create a pull down
list, there will be no empty entry unless one is manually added to
the authorised values list.
This is not a good default behaviour, as it can easily
cause errors on patron creation. Without the empty entry, the first
alphabetic value is pre-selected and will be saved if not explicitly
changed. It also doesn't allow to mark sort1/sort2 as mandatory,
as the value is always 'set', the required message won't be triggered.
This adds an empty parameter to av-build-dropbox.inc to allow selectively
adding this empty entry without causing side-effects in other places
this include is used.
To test:
- Create authorised values for either Bsort1 or Bsort2 authorised
value category
- Create a new patron:
- you should see a pull down list on one and an input field for the other
- for the pull down list, there will be no empty entry and the first
alphabetic value will be preselected
- Make your sort1 and sort2 mandatory using BorrowerMandatoryField
- Verify there is still on empty entry
- Apply patch
- Repeat tests and verify that the behaviour is as expected
- There should now be an empty entry
- When the field is marked mandatory and empty is left, the required
warning will be shown.
Signed-off-by: David Roberts <david at koha-ptfs.co.uk>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 563120a004f03a96c935b179af36cace874f708c
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Mon Apr 13 03:46:25 2020 +0200
Bug 10561: Rephrase DisplayOPACiconsXSLT and DisplayIconsXSLT slightly
As the pref removes the whole 'line' of information, this tries to makes
the behaviour a little clearer by adding a 'and descriptions' to the pref
text. It now reads:
[Show|Don't show] the format, audience, and material type icons and
descriptions in XSLT MARC21 results and detail pages in ...
To test:
- Check both preference descriptions in the staff client
- Verify the text reads correctly and this helps things
Signed-off-by: David Roberts <david at koha-ptfs.co.uk>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit d8dd31142c0bfd9b09f9fa8e02fc292cf9deed2c
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Apr 17 11:22:04 2020 +0200
Bug 13518: Delete patron's modifications along with the patron
The table borrower_modifications has no FK constraint on the borrowernumber
and will remain untouched when the patron is deleted.
If the borrowernumber doesn't exist in the database, the modification entry is no longer visible in Koha.
The problem is that this table is used for the borrower modifications and the self-registration features.
So far borrowernumber is the PK (int(11) NOT NULL DEFAULT '0'), for the self-registration feature we can have borrowernumber that is not defined (0 is used)
Ideally we would like to have borrowernumber a DEFAULT NULL, and use NULL for self-reg, but then we will loose the PK (PK cannot be NULL).
As we cannot keep the correct constraints at DB level anyway, we will need to handle consistency at code-level.
Test plan:
Create a new patron
Do some modification at the OPAC
Delete the patron
Confirm that the modifications as been removed (directly in DB)
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
-----------------------------------------------------------------------
Summary of changes:
Koha/Patron.pm | 5 +++++
koha-tmpl/intranet-tmpl/prog/en/includes/av-build-dropbox.inc | 6 ++++--
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref | 2 +-
.../prog/en/modules/admin/preferences/staff_client.pref | 2 +-
koha-tmpl/intranet-tmpl/prog/en/modules/members/discharge.tt | 6 ++++--
koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt | 2 +-
koha-tmpl/intranet-tmpl/prog/en/modules/members/ill-requests.tt | 5 ++++-
koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt | 4 ++--
.../intranet-tmpl/prog/en/modules/members/purchase-suggestions.tt | 3 ++-
koha-tmpl/intranet-tmpl/prog/en/modules/members/statistics.tt | 2 +-
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt | 1 +
t/db_dependent/Koha/Patrons.t | 5 ++++-
12 files changed, 30 insertions(+), 13 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list