[koha-commits] main Koha release repository branch 18.11.x updated. v18.11.15-26-gdfe1bd600c
Git repo owner
gitmaster at git.koha-community.org
Wed Apr 22 00:17:41 CEST 2020
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 18.11.x has been updated
via dfe1bd600c3155bdc905716c8c745051a3234d06 (commit)
from 3b8c2467e5bde0311f520e286832a52ad0b4a17e (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit dfe1bd600c3155bdc905716c8c745051a3234d06
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Apr 14 13:22:44 2020 +0200
Bug 25142: Fix wrong grep logical test
To test and understand what's going on, you can try that bit of code:
my @a = qw( a b c a);
my @b = qw( b c d );
my @c;
@c = grep { 'a' eq $_ } @a ? 'ok' : ();
say @c;
@c = ( grep { 'a' eq $_ } @a ) ? 'ok' : ();
say @c;
@c = grep { 'a' eq $_ } @a ? ('ok') : (undef);
say @c;
The problem here:
Have patrons in 3 branches CPL, MPL, SPL
Have a non superlibrarian with edit_borrowers permission but
without view_borrower_infos_from_any_libraries, from CPL
Create a library group with CPL, MPL
Use that non superlibrarian to search for patrons
You can search for patrons fro CPL and MPL
BUT, edit the value for CPL, use SPL (edit the DOM)
Search and... oops
Apply this patch, try again
Also use a superlibrarian patron (and/or with view_borrower_infos_from_any_libraries)
and confirm that they can see all patrons
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Tested with edit_borrowers permission but NOT view_borrower_infos_from_any_libraries
Editing the DOM I can search (not edit) from any branch
With patch no entries found :)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Amended test plan slightly (+ without)
Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
(cherry picked from commit c33f598c5cdea829390660419498e15f968f9abe)
Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
-----------------------------------------------------------------------
Summary of changes:
C4/Utils/DataTables/Members.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list