[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-7-gb5062aaf6b

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.11.x has been updated
       via  b5062aaf6b3bb721e56cf3186fda738432f897f4 (commit)
       via  2fd3ac8b52e7ab4f2c8f292afb060078b2894554 (commit)
      from  4f868dc0b802c542a6746a15280e6349b64efa63 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit b5062aaf6b3bb721e56cf3186fda738432f897f4
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Mar 27 16:38:15 2020 -0300

    Bug 25006: Make Koha::Item->as_marc_field skip undefined subfields
    
    This patch makes as_marc_field skip subfields that don't have a value or
    contains an empty string (replicating C4::Items:1021 logic).
    
    To test:
    1. Apply the regression tests patch
    2. Run:
       $ kshell
      k$ prove t/db_dependent/Koha/Item.t
    => FAIL: Tests fail because the generated MARC::Field contains undef
    subfields.
    3. Apply this patch
    4. Repeat 2.
    => SUCCESS: Tests pass! Undefined and empty subfields are skipped!
    5. Sign off :-D
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: David Nind <david at davidnind.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 2fd3ac8b52e7ab4f2c8f292afb060078b2894554
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Mar 27 16:36:25 2020 -0300

    Bug 25006: Regression tests
    
    This patch introduces regression tests for as_marc_field. It makes sure
    there are empty subfields and then uses List::MoreUtils' all to verify
    all generated MARC subfields contain something (i.e. the undef ones are
    skipped).
    
    Signed-off-by: David Nind <david at davidnind.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha/Item.pm               |  3 ++-
 t/db_dependent/Koha/Item.t | 11 ++++++++++-
 2 files changed, 12 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
main Koha release repository