[koha-commits] main Koha release repository branch master updated. v19.11.00-1926-g0bb0b6c7b4
Git repo owner
gitmaster at git.koha-community.org
Wed Apr 29 17:53:10 CEST 2020
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 0bb0b6c7b42428320603896233f45ea5f4af670c (commit)
via b33d69684f24249fd14c668fd2164cea380697db (commit)
via b6d25fbb674ed58c727987b0a952efaadf27a305 (commit)
via 5d36a311fe7dfcd99fd4ac31abca606cc815b280 (commit)
via af60dd912a1a3b732bce359b63cfd88a93217cd5 (commit)
via 665d651e95145ed38e2a5c796c70bf7b43f48042 (commit)
via 9d879dd1eedd99791e9c7e8acb9f5e6dbea81434 (commit)
via fa1d3a5a4858bd30e3e6b1d1ccd169f731aadb45 (commit)
via a6fbb69c96f695df162e15486da568d27b70fa0f (commit)
via 4df3899bc9d09e41138162f7d469221df23dd3bf (commit)
via a357079d66b1038e536de72b916dcb7bdb5bf1f9 (commit)
via 58bec27564ad92a19ce2eed71f49f3630dbd7c98 (commit)
via 1e53d94882bc9abbbfb397b4b980b85aad72e630 (commit)
via 0b72e7d6669ea67b73686d6a57ae014707ca0ba0 (commit)
via c901dfdeaa5350303e8df5bd2bb92d8e925fe20d (commit)
via 971acda4808cda708ec320f997c7f8702e7e2f62 (commit)
via 7fa460486ddd887d1bebe00844d6a8e7eba85cce (commit)
via 1cd34826643ab0443d4bebef4e106e7f03cd6587 (commit)
via d2d53878f6020bff540fc9249b793e5effb3f0dd (commit)
via 21ed06369c83ceaf4a4ed67cd4df424acc8efb85 (commit)
via 02e8368fad7c566ec8956d5dc9ca5c851931fe12 (commit)
from f00a2570eb93f012b13d8cec04375164e6103a84 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 0bb0b6c7b42428320603896233f45ea5f4af670c
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Thu Apr 2 18:40:49 2020 -0300
Bug 25048: Make successful resource deletion return 204
This patch adapts the spec and the controllers so existing routes return
204 and an empty response body when a successful deletion happens.
Right now we have a coding guideline but haven't adapted the existing
routes.
To test:
1. Apply the regression tests patch
2. Run:
$ kshell
k$ prove t/db_dependent/api/v1/*.t
=> FAIL: Some tests fail
3. Apply this patch
4. Repeat 2.
=> SUCCESS: Tests pass!
5. Sign off :-D
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit b33d69684f24249fd14c668fd2164cea380697db
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Thu Apr 2 18:38:33 2020 -0300
Bug 25048: Regression tests
This patch adds regression tests for the response bodies and statuses on
DELETE actions against existing API routes. This is just enforcing the
existing (voted) Coding guidelines for the API (tm).
To test:
1. Apply this patch
2. Run:
$ kshell
k$ prove t/db_dependent/api/v1/*.t
=> FAIL: Several routes have problems
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit b6d25fbb674ed58c727987b0a952efaadf27a305
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Apr 15 11:02:39 2020 +0200
Bug 25032: Add missing utf8 flag in koha-common.postinst
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 5d36a311fe7dfcd99fd4ac31abca606cc815b280
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Apr 14 17:50:58 2020 -0300
Bug 25032: Chomp stringified exception
If we catch a Koha::Exception-derived exception, the log is put in a
single line. If the code 'dies' then a newline character is appended to
the string. This patch chomps it so it displays in a single line.
To test:
1. Tweak Koha::REST::V1::Cities::list in the try block so it dies before
render
2. Restart plack and try the original test plan
=> FAIL: Notice two lines are logged
3. Apply this patch
4. Repeat 2
=> SUCCESS: Only one line in the logs
5. Verify rendering a Koha::Exception works as well:
Koha::Exceptions::Exception->throw("Nada!");
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit af60dd912a1a3b732bce359b63cfd88a93217cd5
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Thu Apr 2 14:43:27 2020 -0300
Bug 25032: Make existing controllers use unhandled_exception
This simple patch removes 'just in case' handling of specific exceptions
and makes the current routes controllers use the unhandled_exception helper.
Most possible exceptions are already catch by our tools (Koha::Object,
etc) and the existing code is not looking for known possible exceptions
but has just been copied and pasted since our beginings.
Anytime a situation in which an unhandled exception is caught, we (the
devs) should report it and specific exception handling discussed and
solved. But this has just been useless scaffolding so far.
To test:
1. Run:
$ kshell
k$ prove t/db_dependent/api/v1/*.t
=> SUCCESS: Tests pass
2. Apply this patch
3. Repeat 1.
=> SUCCESS: Tests still pass
4. Sign off :-D
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 665d651e95145ed38e2a5c796c70bf7b43f48042
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Mar 31 18:43:02 2020 -0300
Bug 25032: Generic unhandled exception handling on API
This patch adds Koha::Logger as the default logger for the API, and
introduces a new helper plugin that takes care of handling the unhandled
exceptions. Basically, with this we would write something like this in
our controller methods:
try {
...
}
catch {
if ( know_exception ) {
handle_known_exception($_);
}
$c->unhandled_exception($_);
}
Without this, we end up adding more and more handling 'just in case'.
To test:
1. Edit the Koha/REST/V1/Cities.pm 'list' method adding
die("Nada"); before the render step.
2. Restart plack and try the endpoint
=> FAIL: A generic error is displayed, and no traces of the original
problem are found on the logs.
3. Apply this patches, make sure your instance's log4perl has the
introduced lines for API with the right path.
4. Repeat 2
=> SUCCESS: The message is still generic, but you see something is
logged in /var/log/koha/kohadev/api-error.log
5. Change die("Nada"); for a real exception like:
use Koha::Exceptions;
Koha::Exceptions::DuplicateObject->throw("Nada");
6. Repeat 2.
=> SUCCESS: The message is generic, but a meaningful text is added to
the logs.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 9d879dd1eedd99791e9c7e8acb9f5e6dbea81434
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Mar 31 18:42:25 2020 -0300
Bug 25032: Add 'api' target to log4perl.conf
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit fa1d3a5a4858bd30e3e6b1d1ccd169f731aadb45
Author: Lucas Gass <lucas at bywatersolutions.com>
Date: Wed Apr 15 21:42:36 2020 +0000
Bug 25072: Fix details.tt print CSS
TO TEST:
-Search for something in the catalog and go to the details page.
-Try to print either for the Print button in Koha or File->Print...
-Notice the large amount of whitespace on the left
-Apply patch
-Reload detaials page and attempt to print again.
-No whitespace on left side
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit a6fbb69c96f695df162e15486da568d27b70fa0f
Author: David Cook <dcook at prosentient.com.au>
Date: Tue Apr 28 11:40:23 2020 +1000
Bug 25299: Show soon to expire patron date
This patch fixes the call to show the patron expiry date
on the Details page when the patron is soon to expire.
Test plan:
0. Do not apply patch yet
1. Create a patron
2. Set patron's date expiry to 3 days from today
3. Go to Details tab
4. Note message "Expiration: Patron's card will expire soon.
Patron's card expires on Renew or Edit details"
5. Apply patch
4. Note message pattern "Expiration: Patron's card will expire soon.
Patron's card expires on XX/XX/XXXX Renew or Edit details"
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 4df3899bc9d09e41138162f7d469221df23dd3bf
Author: David Cook <dcook at prosentient.com.au>
Date: Tue Apr 28 12:00:15 2020 +1000
Bug 25300: Fix typo in "Edit details" for expiring/expired patron
This patch removes a typo in the argument to the "op" parameter
for the "Edit details" link when editing an expiring/expired patron
on the Details page.
Test plan:
0. Do not apply patch yet
1. Create patron
2. Set expiry date to 3 days from now
3. Go to Details tab in patron record
4. Click "Edit details" in "Library use" section
5. Note the form is blank and has no patron data in it
6. Apply the patch
7. Reload the Details page in patron record
8. Click "Edit details" in "Library use" section
9. Note the form now contains your patron data and will
work for editing the details
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit a357079d66b1038e536de72b916dcb7bdb5bf1f9
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue Apr 28 11:25:22 2020 +0000
Bug 25282: (follow-up) More corrections
This patch adds more corrections missed in the first patch:
- Tools -> Patron clubs (in the Clubs table)
- Circulation -> Article requests (removed a couple of divs made
redundant by the re-used BLOCK)
- Tools -> Plugins home
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 58bec27564ad92a19ce2eed71f49f3630dbd7c98
Author: Owen Leonard <oleonard at myacpl.org>
Date: Mon Apr 27 21:41:08 2020 +0000
Bug 25282: Correct Bootstrap dropdown button markup
Incorrect markup surrounding Bootstrap dropdown buttons causes display
problems with the buttons are in a DataTable. Dropdown wrapper <div>s
must have a "btn-group" class.
To reproduce the problem, look at the MARC bibliographic frameworks
page. The "Actions" menu when triggered will not line up with the
button.
In almost all cases, dropdown buttons inside tables should also have the
"dropup" class on their wrapper so that the menu appears above the
button. This prevents the menu from disappearing off the bottom of the
window when the button is positioned low in the viewport.
To test, apply the patch and test the button menus in tables on the
following pages:
- Acquisitions -> Invoices
- Acquisitions -> Add to order -> From external source -> Results
- Acquisitions -> Suggestions
- Administration -> Budgets
- Administration -> Funds
- Administration -> Authority types
- Administration -> Authority types -> MARC structure
- Administration -> MARC bibliographic frameworks
- Administration -> MARC bibliographic frameworks -> MARC structure
- Administration -> OAI sets configuration
- Administration -> Z39.50/SRU servers
- Authorities -> Authority search results
- Authorities -> New from Z39.50/SRU -> Search results
- Cataloging -> Edit items
- Cataloging -> New from Z39.50/SRU -> Search results
- Circulation -> Article requests
- Reports -> Saved reports
- Tools -> Patron lists
- Tools -> Rotating collections
- Serials -> Serials search results
Signed-off-by: Phil Ringnalda <phil at chetcolibrary.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 1e53d94882bc9abbbfb397b4b980b85aad72e630
Author: Didier Gautheron <didier.gautheron at biblibre.com>
Date: Mon Apr 27 14:42:49 2020 +0200
Bug 25291: Escape barcode in ReturnClaims table display
Test Plan:
1) Set ClaimReturnedLostValue
2) Create a checkout
3) Claim a return
4) Change the barcode to something with html inside, </a> will do
Without this patch cgi-bin/koha/members/moremember.pl claim tab barcode link is broken.
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 0b72e7d6669ea67b73686d6a57ae014707ca0ba0
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Fri Mar 6 09:00:08 2020 +0000
Bug 24815: Add additional tests
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit c901dfdeaa5350303e8df5bd2bb92d8e925fe20d
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Thu Mar 5 16:11:33 2020 +0000
Bug 24815: Correct return values of Koha::Cash::Register relations
This patch correct all cases of return undef to instead return an empty
resultset.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 971acda4808cda708ec320f997c7f8702e7e2f62
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Mon Apr 27 11:37:13 2020 +0000
Bug 25229: (follow-up) Move QueryBuilder test to Elasticsearch dir
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 7fa460486ddd887d1bebe00844d6a8e7eba85cce
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Tue Apr 21 13:47:59 2020 +0000
Bug 25229: Return authid of record rather than 001
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 1cd34826643ab0443d4bebef4e106e7f03cd6587
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Mon Apr 27 11:28:51 2020 +0000
Bug 25229: Unit test
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit d2d53878f6020bff540fc9249b793e5effb3f0dd
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Mon Apr 27 07:07:12 2020 -0400
Bug 25227: Display correct message if item is withdrawn and withdrawn returns are allowed
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 21ed06369c83ceaf4a4ed67cd4df424acc8efb85
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Tue Apr 21 07:11:08 2020 -0400
Bug 25227: Display correct message if item is lost and lost returns are allowed
Even if a library allows returns of lost items, the SIP server returns the error message "Item lost, return not allowed" if the checkin was not ok for any reason other than it being withdrawn ( and withdrawn items not being returnable ).
The most clear example of this is that when a lost item is not checked out to a patron and is returned. SIP returns that message even though lost items *can* be returned. The actual problem being that the item was not checked out.
Test Plan:
1) Ensure you can return lost items
2) Mark an item as lost
3) Check it in via SIP
4) Note the message you get back is "Item lost, return not allowed"
5) Apply this patch
6) Restart your SIP server
7) Repeat steps 2 and 3
8) Note you no longer get the incorrect message!
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 02e8368fad7c566ec8956d5dc9ca5c851931fe12
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Mon Apr 27 08:04:07 2020 -0400
Bug 25227: Add unit tests
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
-----------------------------------------------------------------------
Summary of changes:
C4/SIP/ILS.pm | 4 +-
Koha/Cash/Register.pm | 11 +-
Koha/Exceptions/ClubHold.pm | 2 +-
Koha/REST/Plugin/Exceptions.pm | 86 +++++++++++++++
Koha/REST/V1.pm | 3 +
Koha/REST/V1/Acquisitions/Funds.pm | 9 +-
Koha/REST/V1/Acquisitions/Orders.pm | 73 +++----------
Koha/REST/V1/Acquisitions/Vendors.pm | 81 ++++++--------
Koha/REST/V1/Biblios.pm | 18 +---
Koha/REST/V1/Checkouts.pm | 109 ++++++++++---------
Koha/REST/V1/Cities.pm | 62 ++++-------
Koha/REST/V1/Clubs/Holds.pm | 26 +----
Koha/REST/V1/Holds.pm | 116 ++++++++-------------
Koha/REST/V1/Items.pm | 36 ++-----
Koha/REST/V1/Libraries.pm | 76 ++++----------
Koha/REST/V1/Patrons.pm | 72 ++++---------
Koha/REST/V1/Patrons/Account.pm | 59 +++++------
Koha/REST/V1/Patrons/Password.pm | 25 +++--
Koha/REST/V1/ReturnClaims.pm | 47 +--------
Koha/SearchEngine/Elasticsearch/Search.pm | 10 +-
api/v1/swagger/paths/acquisitions_orders.json | 5 +-
api/v1/swagger/paths/acquisitions_vendors.json | 7 +-
api/v1/swagger/paths/cities.json | 7 +-
api/v1/swagger/paths/holds.json | 7 +-
api/v1/swagger/paths/patrons.json | 7 +-
debian/koha-common.postinst | 13 +++
debian/templates/log4perl-site.conf.in | 8 ++
etc/log4perl.conf | 8 ++
koha-tmpl/intranet-tmpl/prog/css/print.css | 5 +
.../intranet-tmpl/prog/en/includes/clubs-table.inc | 2 +-
.../prog/en/modules/acqui/invoices.tt | 2 +-
.../prog/en/modules/acqui/z3950_search.tt | 2 +-
.../prog/en/modules/admin/aqbudgetperiods.tt | 2 +-
.../prog/en/modules/admin/aqbudgets.tt | 2 +-
.../prog/en/modules/admin/auth_tag_structure.tt | 2 +-
.../prog/en/modules/admin/authtypes.tt | 2 +-
.../prog/en/modules/admin/biblio_framework.tt | 4 +-
.../prog/en/modules/admin/marctagstructure.tt | 2 +-
.../prog/en/modules/admin/oai_sets.tt | 2 +-
.../prog/en/modules/admin/z3950servers.tt | 2 +-
.../en/modules/authorities/searchresultlist.tt | 2 +-
.../prog/en/modules/cataloguing/additem.tt | 2 +-
.../en/modules/cataloguing/z3950_auth_search.tt | 2 +-
.../prog/en/modules/cataloguing/z3950_search.tt | 2 +-
.../prog/en/modules/circ/article-requests.tt | 6 +-
.../prog/en/modules/members/moremember.tt | 6 +-
.../prog/en/modules/patron_lists/lists.tt | 2 +-
.../prog/en/modules/plugins/plugins-home.tt | 2 +-
.../en/modules/reports/guided_reports_start.tt | 46 ++++----
.../rotating_collections/rotatingCollections.tt | 2 +-
.../prog/en/modules/serials/serials-search.tt | 2 +-
.../prog/en/modules/suggestion/suggestion.tt | 4 +-
koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 8 +-
.../QueryBuilder.t | 0
t/Koha/SearchEngine/Elasticsearch/Search.t | 65 ++++++++++++
t/db_dependent/Koha/Cash/Register.t | 52 ++++++++-
t/db_dependent/SIP/Transaction.t | 78 +++++++++++++-
t/db_dependent/api/v1/acquisitions_vendors.t | 12 +--
t/db_dependent/api/v1/cities.t | 4 +-
t/db_dependent/api/v1/holds.t | 21 ++--
t/db_dependent/api/v1/patrons.t | 5 +-
61 files changed, 687 insertions(+), 652 deletions(-)
create mode 100644 Koha/REST/Plugin/Exceptions.pm
rename t/Koha/SearchEngine/{ElasticSearch => Elasticsearch}/QueryBuilder.t (100%)
create mode 100644 t/Koha/SearchEngine/Elasticsearch/Search.t
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list