[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.08-44-g493a0f2d54

Wed Aug 5 02:39:00 CEST 2020

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.11.x has been updated
       via  493a0f2d540361ed4fef2157a9b852a1a57e126e (commit)
       via  f6c6a07693f78a586078b50924a2fc2c6522087b (commit)
       via  a2139daaa53acfa90d855a5e0df76b47fb964139 (commit)
       via  f4899bafe35ad8e0c2e9af55068e6ee7f4a7e36e (commit)
      from  58e7d0b44a85712e530b270f737f4de5f2b17ff7 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 493a0f2d540361ed4fef2157a9b852a1a57e126e
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Jul 20 15:16:29 2020 +0200

    Bug 24379: Fix failing tests

    kohadev-koha at kohadevbox:/kohadevbox/koha$ prove t/db_dependent/Koha/Patrons/Import.t
    t/db_dependent/Koha/Patrons/Import.t .. 2/159
     #   Failed test 'No warning raised by import_patrons'
     #   at t/db_dependent/Koha/Patrons/Import.t line 171.
     # found warning: Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018, <$handle_3a> line 2.
     # found warning: Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018, <$handle_3a> line 2.
     # didn't expect to find a warning
    Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018, <$handle_2> line 2.
    Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018, <$handle_2> line 2.
    Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018, <$handle_3> line 2.
    Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018, <$handle_3> line 2.
    Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018, <$handle_4> line 2.
    Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018, <$handle_4> line 2.
    t/db_dependent/Koha/Patrons/Import.t .. 152/159 # Looks like you failed 1 test of 159.
    t/db_dependent/Koha/Patrons/Import.t .. Dubious, test returned 1 (wstat 256, 0x100)
    Failed 1/159 subtests

    Test Summary Report
    -------------------
    t/db_dependent/Koha/Patrons/Import.t (Wstat: 256 Tests: 159 Failed: 1)
      Failed test:  39
      Non-zero exit status: 1
    Files=1, Tests=159,  3 wallclock secs ( 0.04 usr  0.01 sys +  2.11 cusr  0.24 csys =  2.40 CPU)
    Result: FAIL

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit 545e03c173c789241eb21773a939b4ab7dcc6da4)

    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    (cherry picked from commit c0e665aeccbc028f4289e7b1c144f844c05b5198)

    Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

commit f6c6a07693f78a586078b50924a2fc2c6522087b
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date:   Wed Aug 5 12:08:00 2020 +1200

    Bug 24379: DBIC

    Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

commit a2139daaa53acfa90d855a5e0df76b47fb964139
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date:   Wed Aug 5 12:07:40 2020 +1200

    Bug 24379: DBRev 19.11.08.002

    Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

commit f4899bafe35ad8e0c2e9af55068e6ee7f4a7e36e
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed Jan 8 20:59:38 2020 +0000

    Bug 24379: Make login_attempts not nullable

    While the column defaults to 0 in Koha::Object->store we set to NULL if NULLABLE

    When trying to reset a patrons password we check that the account is not administratively locked:
    login_attempts != -1

    This query does not return rows where login_attempts IS NULL. It will return accounts where login_attempts = 0

    Let's default to 0 like we intend

    To test:
    1 - Create a new patron
    2 - Note their login_attempts is NULL
        SELECT login_attempts FROM borrowers ORDER BY borrowernumber DESC LIMIT 1
    3 - Enable  OpacResetPassword
    4 - Attempt to reset password before logging in, you cannot
    5 - Apply patch, updatedatabase, restart_all, update schema
    6 - Create another patron
    7 - Their login attempts should be 0
    8 - Attempt to reset password, it works!

    Bug 24379: Fix the test

    First we create a patron using TestBuilder to get a hashref of valid
    info. Then we delete it and create a new patron using Koha::Patron->new
    Once stored, we should call discard_changes to make the calculated
    values available in the currenct object.

    Bug 24379: Don't drop default of 0 for login attempts

    When moving the column we drop the default, this means that DBs upgraded form earlier versions
    get the wrong values set

    To test:
    1 - Checkout 16.11.x
    2 - Reset all
    3 - Checkout master
    4 - updatedatabase
    5 - SHOW CREATE TABLE borrowers;
    6 - Note the column login_attempts defaults to NULL
    7 - Apply patch(es)
    8 - Repeat
    9 - Now it defaults ot 0 (and has NOT NULL if applied all)

    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit 7bb31cffae27dc398a7b4a4decf3623ec65478ac)

    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    (cherry picked from commit 6d675b61ad2dfd8fa6cfd0f58a9ebb8d534bd358)

    Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha.pm                                |  2 +-
 Koha/Patrons/Import.pm                 |  2 +-
 Koha/Schema/Result/Borrower.pm         |  8 ++++----
 Koha/Schema/Result/Deletedborrower.pm  |  8 ++++----
 installer/data/mysql/kohastructure.sql |  4 ++--
 installer/data/mysql/updatedatabase.pl | 14 ++++++++++++--
 t/db_dependent/Koha/Patron.t           | 21 ++++++++++++++++++++-
 7 files changed, 44 insertions(+), 15 deletions(-)

hooks/post-receive
-- 
main Koha release repository