[koha-commits] main Koha release repository branch master updated. v20.05.00-492-ge4cae99f7e
Git repo owner
gitmaster at git.koha-community.org
Wed Aug 5 18:05:39 CEST 2020
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via e4cae99f7ec76e40a57e4066e088b9b01caed744 (commit)
via d20bc39d759bc9321b1b7accb952f90351a14caa (commit)
via 61e8dc8c7d489329c27aca3b6b10137c289161cb (commit)
via 88ecaa54cdfec5d35091237821097877b0edb4eb (commit)
via 5c190388ae1b69889e28c2dae80e0d9ea9baff1a (commit)
via a51a4f117d13739687f7be47d56cae0352914901 (commit)
via 80a611797bf67b263b6b84a6e931833ea336b6a5 (commit)
via 88506d7bb6958a49969f737a8bc41afa8536c554 (commit)
from c34d222d57c61c60dcfb9babc16be8827bb7e242 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit e4cae99f7ec76e40a57e4066e088b9b01caed744
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Wed Aug 5 12:09:40 2020 -0300
Bug 26143: Make the API handle per_page=-1
This patch introduces handling for per_page=-1 and actually adds a
missing feature to the API: being able to request all resources on a
route.
To test this:
1. Visit the libraries admin page
2. On the table, choose to display 'All' rows
=> FAIL: it doesn't refresh, the browser console displays a 500 error
code and so the logs
3. Apply the tests patches
4. Run:
$ kshell
k$ prove t/Koha/REST/Plugin/Pagination.t \
t/db_dependent/Koha/REST/Plugin/Objects.t
=> FAIL: Tests fail loudly
5. Apply this patch
6. Restart plack
7. Repeat 2
=> SUCCESS: choosing to display all, works
8. Repeat 4
=> SUCCESS: Tests pass now!
9. Sign off :-D
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit d20bc39d759bc9321b1b7accb952f90351a14caa
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Wed Aug 5 12:04:47 2020 -0300
Bug 26143: Regression tests
This patch introduces tests for the per_page=-1 handling use case. From
now on per_page=-1 means 'all resources'.
On writing this I noticed that we always paginate results no matter
what, but there was a weird condition under which on pagination headers
were sent back to the API consumer. This is highlighted in the precedent
patch, which is not the -1 situation this one tries to tackle.
Both pagination and searching are broken with per_page=-1, which is a
standard, and we actually didn't explicitly set a way to request all
resources.
To verify this:
1. Apply the previous tests patch and this one
2. Run:
$ kshell
k$ prove t/Koha/REST/Plugin/Pagination.t \
t/db_dependent/Koha/REST/Plugin/Objects.t
=> FAIL: Things are damn broken
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 61e8dc8c7d489329c27aca3b6b10137c289161cb
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Wed Aug 5 11:55:28 2020 -0300
Bug 26143: The API is always paginated
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 88ecaa54cdfec5d35091237821097877b0edb4eb
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Aug 4 13:55:13 2020 +0200
Bug 26133: Remove GetMarcHosts
We removed the single occurrence of this subroutine in the previous
patch
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 5c190388ae1b69889e28c2dae80e0d9ea9baff1a
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Aug 4 13:54:28 2020 +0200
Bug 26133: Remove GetMarc* calls in detail.pl
There are several calls in catalogue/detail.pl that can be removed:
GetMarcISBN, GetMarcAuthors, GetMarcSubjects, GetMarcSeries, GetMarcUrls and GetMarcHosts
They pass a variable to the template that is never used.
Test plan:
Confirm that this TT variable is never used.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit a51a4f117d13739687f7be47d56cae0352914901
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Aug 5 09:57:56 2020 +0200
Bug 26141: Remove duplicated code from search.pl
commit 417553a9e47bf31f4cb785162e3dced856a2ac2a
Bug 12478: starting to add search to staff client
This commit added code related to the itemtypes to the advanced search, but this code already existed.
The weird bit is:
$template->param(advancedsearchesloop => \@advancedsearchesloop);
my $types = C4::Context->preference("AdvancedSearchTypes") || "itemtypes";
my $advancedsearchesloop = prepare_adv_search_types($types);
$template->param(advancedsearchesloop => $advancedsearchesloop);
We are passing twice advancedsearchesloop to the template.
Test plan (for QA):
Review the changes and confirm that we can safely remove this code
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 80a611797bf67b263b6b84a6e931833ea336b6a5
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Jul 22 14:11:03 2020 +0200
Bug 26043: Fix random failure from Holds.t
# Failed test 'Test ModReserveMinusPriority()'
# at t/db_dependent/Holds.t line 202.
# got: undef
# expected: '1605'
# Looks like you failed 1 test of 66.
It is coming from Koha::Patron->holds that is ordering by reservedate,
so "sometimes" they are ordered in reverse (at least it's my
understanding of the problem).
Test plan:
Run the test file several times (from 20 to 60x), it must never fail
with this patch
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 88506d7bb6958a49969f737a8bc41afa8536c554
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Aug 5 09:30:31 2020 +0200
Bug 26138: Make Koha::Plugins->call return consistent value
It must return an empty array in case the enable_plugins config flag is
disabled
Test plan:
Turn the config off in koha-conf
Start a search at the OPAC
Without this patch you got:
Can't use string ("0") as a HASH ref while "strict refs" in use at /home/vagrant/kohaclone/opac/opac-search.pl line 661
With this patch applied you see the search result
Followed test plan - works as described.
Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
-----------------------------------------------------------------------
Summary of changes:
C4/Biblio.pm | 48 ----------------------
Koha/Plugins.pm | 4 +-
Koha/REST/Plugin/Objects.pm | 22 ++++++----
Koha/REST/Plugin/Pagination.pm | 22 +++++-----
catalogue/detail.pl | 12 ------
catalogue/search.pl | 46 ---------------------
opac/opac-detail.pl | 2 -
t/Biblio.t | 8 +---
t/Koha/REST/Plugin/Pagination.t | 67 +++++++++++++++++++++++++++++--
t/db_dependent/Holds.t | 2 +-
t/db_dependent/Koha/Plugins/Plugins.t | 8 +++-
t/db_dependent/Koha/REST/Plugin/Objects.t | 14 ++++++-
12 files changed, 114 insertions(+), 141 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list