[koha-commits] main Koha release repository branch master updated. v20.05.00-575-g9b342c81a0
Git repo owner
gitmaster at git.koha-community.org
Thu Aug 13 08:25:49 CEST 2020
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 9b342c81a044baeb8220e8a80ad8349adf8ff5b0 (commit)
via cf6d7d18bc68c47fc02038a21e33d7cf816f25ab (commit)
via 2bb09975bc5efc336e77b04e5f5f791aad3d6f76 (commit)
via 488e76ea3a6e0591bc6134947011d990c81190eb (commit)
via 75e25c9d38edc86f7cd545e55b919624f92e2716 (commit)
via 0629d4082fec2474a25c18fca4f134d4b75c3ad3 (commit)
via ca3f7ceb2a5e1dc6d62b4500392ec9ca834c0b48 (commit)
via 3d519c897743d000e445ea97ddf4045e296ea9b6 (commit)
via 948a7c5f74b461b0d7a6438a49d2ea64dcb2428b (commit)
via 510ee8a1a38ee18fc38ff33c6351798aa656d814 (commit)
via d09fbb284b50d12783f76fd58400d093f84ce159 (commit)
via bc882fcb13569a2ef8858bfa41856e7df4992388 (commit)
via e234eb84e103ae8fb29d81bf4702342a0faf5c91 (commit)
via 4de06b1711a3838adb79b6c33f6a5dd8a59e5bae (commit)
via ec630b4b6c9949a51e8491c0c8b3e30d3a43df50 (commit)
via bd29f99a8627d08a6e5c2fdcf3d312dfd7260020 (commit)
via db1587520778bd940da389fab8f46a12c1c11f73 (commit)
via 4cf5ef239f1e1a05c277a91f73b6fcd245eb5ec0 (commit)
via b332e0912d8883928061b10e87d0b8f3e7c9c30d (commit)
via 4dc25f3192e4d32a07b2cbaec653b98dca9618c5 (commit)
via 1ceb44ba2d9ae40d0c0230b009dcd6850bc27d46 (commit)
via 3138c48f69ff19493c7433145144c06a077825be (commit)
via 3d2a988809eddc4cdd3469aa5dc2a8f25252306b (commit)
via ed4fc5889467bde858cfd4ac573cd40a5b4279c5 (commit)
via 81f06881a45d7647481aa8a21354a772f3daff88 (commit)
via 19d9ba176dea6b7816a33b014a5f9e309af53dc0 (commit)
via a2b2426de842ac86048cbf71e3760b6483fc0b3c (commit)
via 1a2d7f1eacc0722ea0723577823ee6a477a46b0a (commit)
from 70ff3bafa05a30944962747953c70bb8dc3c1ab8 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 9b342c81a044baeb8220e8a80ad8349adf8ff5b0
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Aug 12 14:03:00 2020 +0200
Bug 5428: Add searchid to the "Return to the record" button (batch del)
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit cf6d7d18bc68c47fc02038a21e33d7cf816f25ab
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Aug 7 00:43:29 2020 +0000
Bug 5428: (QA follow-up) Add searchid for deleting items in a batch and editing in batch
To test:
0 - Perform a search in the staff client
1 - Click a title to go to the details page for a record
2 - Click the 'Edit' button and select 'Edit items in a batch'
3 - Note the searchid is in the url
4 - Make a change and hit 'Save'
5 - Note the 'Return the the record' link at the top, and the button on the bottom include searchid in URL
6 - Click one and note the brwoser is stil there
7 - Click 'Edit' and select 'Delete items in a batch'
8 - Delete one item
9 - Click return to record
10 - Browser is there
11 - Click 'Delete items in a batch again
12 - Select all and check 'Delete records if no items remain'
13 - Delete them
14 - Note you have a link to 'Go back to the results'
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 2bb09975bc5efc336e77b04e5f5f791aad3d6f76
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Aug 4 14:36:38 2020 +0200
Bug 5428: Jump back to the search result after deleting a record
This patch adds the ability to jump back to the search result after a
record has been deleted.
Also it keeps the "browser" when all items are deleted from a
bibliographic record
Test plan:
- Start a new search
- Select a record with items
- Delete all the items
=> You still see the browser
- Delete the record
=> You are back to the adv search form but we new link "Go back to the
results" is present at the top of the page
Limitation: As we delete the record we do not longer know the offset,
we are back to the first page of the result list
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 488e76ea3a6e0591bc6134947011d990c81190eb
Author: Owen Leonard <oleonard at myacpl.org>
Date: Mon Jul 13 20:09:17 2020 +0000
Bug 20154: Stay in the open tab when editing authority record
This patch adds some JavaScript to the authority record detail page in
the staff interface so that clicking "Edit" will take you to the
authority edit page while keeping the same tab open.
To test, apply the patch and locate an authority record in your catalog.
- Click any of the numbered tabs besides tab 0.
- Choose "Edit record" from the "Edit" dropdown menu.
- When the authorities edit page loads the same tab should be
preselected.
Signed-off-by: Marjorie <marjorie.barry-vila at collecto.ca>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 75e25c9d38edc86f7cd545e55b919624f92e2716
Author: Owen Leonard <oleonard at myacpl.org>
Date: Mon Jul 27 15:57:40 2020 +0000
Bug 21345: Patron records with attached files not obvious from patron details view
This patch adds a section to the patron details page for listing files
which have been attached to the patron record.
To test, apply the patch and enable the EnableBorrowerFiles system
preference.
- If necessary, attach some files to a patron record by viewing a patron
record and choosing "Files" from the sidebar menu.
- View the detail page (moremember.pl) for a patron who has files
attached.
- You should see a new section under "Alternative contact" with the
heading "Files."
- Test the "Manage" button to make sure it takes you to that patron's
files.
- Confirm that all the attached files are listed.
- Confirm that the links to each file work correctly.
Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>
Signed-off-by: Barbara Johnson <barbara.johnson at bedfordtx.gov>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
JD amended patch: replace a html filter with uri
Bug 21345: (follow-up) Hide files information if EnableBorrowerFiles is disabled
This patch wraps the new patron file information in a check for the
EnableBorrowerFiles system preference.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 0629d4082fec2474a25c18fca4f134d4b75c3ad3
Author: Owen Leonard <oleonard at myacpl.org>
Date: Mon Dec 2 16:42:59 2019 +0000
Bug 24134: Add placeholder for 2 digit years to allow autogeneration of dates in 008
This patch modifies the code for parsing MARC framework configurations
so that the placeholder "<<YY>>" translates to a two-year date.
To test, apply the patch and modify a framework to include placeholders.
For example, in MARC21:
- Administration -> MARC structure -> 952 -> Edit subfields -> d
- Expand "Advanced constraints" and add a default value:
<<YYYY>> <<YY>> <<MM>> <<DD>> <<USER>>
- Save your configuration and go to Cataloging.
- Go to the add/edit items page for a record which uses the framework
you edited.
- In the "Add item" form, in the "Date aquired" field, you should see
the correct values. For example: '2019 19 12 03 Leonard'
Perform the same test when adding an item during the Acquisitions
process (depending on your AcqCreateItem setting).
Note that acqui/neworderempty.pl has been modified because the
placeholder-replacement code is repeated there, but I couldn't discover
how to test it (if it is used at all?)
Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit ca3f7ceb2a5e1dc6d62b4500392ec9ca834c0b48
Author: Lucas Gass <lucas at bywatersolutions.com>
Date: Sun Aug 2 16:49:59 2020 +0000
Bug 24176: Add datalastseen column to holdings table
This patch adds the datelastseen column to the holdings table and also makes it column configurable.
To Test:
-Apply patch and have a look at some item records.
-Notice the datalastseen column
-Make sure it wroks and its displaying the datelastseen correctly
-Go to the column configuration tools and make sure you can properly hide this column.
Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 3d519c897743d000e445ea97ddf4045e296ea9b6
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Aug 11 11:45:14 2020 -0300
Bug 24306: (QA follow-up) Fix the XML
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 948a7c5f74b461b0d7a6438a49d2ea64dcb2428b
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Tue Jul 28 12:01:05 2020 +0000
Bug 24306: (follow-up) Add documentation for debug option
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 510ee8a1a38ee18fc38ff33c6351798aa656d814
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Tue Dec 24 13:59:02 2019 +0000
Bug 24306: Add debug switch to koha-indexer
This raises the debug level a lot, it it a bit overwhelming, but may be useful in debugging indexing issues
To test:
1 - Apply patches
2 - sudo koha-indexer --stop instance
3 - sudo debian/scripts/koha-indexer --start --debug instance
4 - tail -f /var/log/koha/instance/indexer-output.log
5 - Note you get a listing that nothign in the queue
6 - Go to staff client and make a change to a record
7 - Note the logs have tons of info
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit d09fbb284b50d12783f76fd58400d093f84ce159
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Wed Jun 3 14:51:42 2020 +0100
Bug 25663: Remove Koha::RefundLostItemFeeRule and uses
This patch replaces all calls to RefundLostItemFeeRules with
Koha::CirculationRules->get_lostreturn_policy and removes the module it
makes redundant.
Test plan
1/ Confirm that there are no longer any uses of RefundLostItemFeeRules
in the codebase
2/ Confirm circulation tests still all pass
3/ Confirm you can still set and unset the lost return rules
4/ Signoff
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit bc882fcb13569a2ef8858bfa41856e7df4992388
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Wed Jun 3 12:59:21 2020 +0100
Bug 25663: Add get_lostreturn_policy method to CirculationRules
This patch adds a new get_lostreturn_policy method to
Koha::CirculationRules which returns a boolean to the caller which
denotes whether a refund should be applied or not on the return of
a lost item.
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit e234eb84e103ae8fb29d81bf4702342a0faf5c91
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Wed Jun 3 14:13:22 2020 +0100
Bug 25663: Add unit tests
This patch adds unit tests for a new get_lostretun_policy method which
is getting added to Koha::CirculationRules.
Test plan:
1/ Read the additions to t/db_dependent/CirculationRules.t code
and compare to the t/db_dependent/RefundLostItemFeeRule.t.
2/ Run the test after applying the patch that adds the new method
3/ If the tests all pass, signoff
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 4de06b1711a3838adb79b6c33f6a5dd8a59e5bae
Author: Owen Leonard <oleonard at myacpl.org>
Date: Sat Aug 8 13:30:35 2020 +0000
Bug 25879: (follow-up) Update overlooked guarantor markup
This patch updates another section of guarantor markup which should have
been updated with the others.
To test, apply the patch and locate an adult patron.
- Click "Add guarantee"
- Confirm that the part of the form for adding a guarantee looks
correct.
- Confirm that the new patron information is saved correctly.
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit ec630b4b6c9949a51e8491c0c8b3e30d3a43df50
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Jun 26 18:51:15 2020 +0000
Bug 25879: Improve display of guarantor information in the patron entry form
This patch makes some changes to the patron entry template to improve
the display of guarantor information.
To test, apply the patch and locate a patron with a "Child" type
category.
- Edit the patron's record
- Under "Guarantor information," click the "Search to add" button.
- Search for and select a patron.
- The guarantor information should be added to the patron edit
form. The information should be correct and well formatted.
- Click the "Remove" link. The guarantor information should be
removed.
- Search for an select a guarantor again and save the record.
- Edit the patron record again. The saved guarantor information should
look correct.
Looks great!
Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit bd29f99a8627d08a6e5c2fdcf3d312dfd7260020
Author: Owen Leonard <oleonard at myacpl.org>
Date: Sat Jul 11 12:09:49 2020 +0000
Bug 25906: Style corrections for OPAC serial pages
This patch makes some CSS changes to the OPAC SCSS and to the OPAC
"full serial issues" page to improve the style.
I've expanded the in-page CSS on the full serial issues page for
readability and added Template Toolkit's "collapse" filter to remove the
whitespace on rendering.
To test, apply the patch and rebuild the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client)
- Locate a serial record in the OPAC.
- Click "More details" to view the issues page.
- Confirm that the "view" tabs look correct, with consistent padding.
- Click the "Full history" tab.
- In the sidebar, the filter should have full-width dropdowns and clear
button.
Signed-off-by: Timothy Alexis Vass <timothy_alexis.vass at ub.lu.se>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit db1587520778bd940da389fab8f46a12c1c11f73
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Jul 17 14:43:39 2020 +0000
Bug 26008: Remove the use of jquery.checkboxes plugin from OPAC cart
This patch removes the use of the jquery.checkboxes plugin from the OPAC
cart and replaces its functionality with "plain" jQuery.
To test, apply the patch and add some items to the Cart in the OPAC.
- Open the Cart window in the OPAC by clicking the "Cart" link in the
header.
- Test that the "Select all" and "Clear all" links work correctly to
check and uncheck all checkboxes.
- Controls like "Remove" and "Place hold" should be enabled or
disabled according to whether there are any checked checkboxes.
- Test that manually checking a checkbox correctly enables or disables
the link options too.
- Test that the "Remove" or "Place hold" controls work correctly,
applying to only the checked checkboxes.
Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Bug 26008: (follow-up) Removed checkboxed class
This patch removes the "checkboxed" class which was previously
associated with the jquery.checkboxes plugin and is now obsolete.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 4cf5ef239f1e1a05c277a91f73b6fcd245eb5ec0
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Jul 17 17:29:15 2020 +0000
Bug 26010: Remove the use of jquery.checkboxes plugin from staff interface cart
This patch removes the use of the jquery.checkboxes plugin from the
staff interface cart and replaces its functionality with "plain" jQuery.
To test, apply the patch and add some items to the Cart in the staff
interface.
- Open the Cart window in the staff interface by clicking the "Cart"
link in the header.
- Test that the "Select all" and "Clear all" links work correctly to
check and uncheck all checkboxes.
- Test that the "Remove" or "Place hold" controls work correctly,
applying to only the checked checkboxes whether they were checked
using "Select all" or by manually checking them.
Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit b332e0912d8883928061b10e87d0b8f3e7c9c30d
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed Jul 29 13:49:16 2020 +0000
Bug 26087: Add table configuration and export options to orders by fund report
This patch adds column configuration to the orders by funds report
results table. The "Basket" column is excluded from being togglable.
To test, apply the patch and clear your browser cache if necessary.
- Go to Reports -> Orders by fund
- Submit parameters which will return multiple results.
- Test that the "Column visibility" button works to show and hide
columns. The "Basket" column should be excluded.
- Test the export options (Excel, CSV, etc)
- Go to Administration -> Columns settings and edit the default
configuration of the orders by fund report. Confirm that these changes
are reflected in the report results.
Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 4dc25f3192e4d32a07b2cbaec653b98dca9618c5
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed Jul 29 16:21:10 2020 +0000
Bug 26091: Add column configuration and export options to catalog statistics report
This patch makes the catalog statistics report output a DataTable with
on-the-fly column configuration and export options.
Because the report can generate results with an arbitrary set of table
headers, the columns set to be passed to DataTables is built on the fly
along with the table. There is no global table setting.
Since the "grand total" cell might reflect a total which includes hidden
columns, the table footer label now indicates "all results."
To test, apply the patch and go to Reports.
- Submit a query to the "catalog" statistics wizard which will return
multiple results.
- On the results page, confirm that the DataTable displays correctly and
that all controls work as expected, including column configuration and
export options.
- Submit other queries which will return a different set of columns in
the result. Confirm that everything continues to work as expected.
Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Bug 26091: (follow-up) Remove unused TablesSettings usage
Since the table column information is built in the template rather than
in the columns_settings YML file we don't need "USE TablesSettings" in
this template.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 1ceb44ba2d9ae40d0c0230b009dcd6850bc27d46
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Thu Aug 6 14:33:32 2020 +0100
Bug 26160: Make POS items table configurable
1) System preference: EnablePointOfSale - set to Enable
2) System preference: UseCashRegisters - set to Use
3) Administration > Accounting > Cash registers - create a new cash register for the library you're logged in as
4) Administration > Accounting > Debit types - create at least one debit type
5) Home > Point of sale - verify that all four columns exist in the Items for purchase table: Code, Description, Cost, Action
6) Administration > Additional parameters > Table settings > Point of sale - change which columns can be hidden and/or toggled
7) Home > Point of sale - verify that your choices have been implemented (columns are hidden, columns can be toggled, columns can't be toggled)
8) Repeat steps 6 and 7 for different combinations, checking that they all work.
Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Added Sally's test plan.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 3138c48f69ff19493c7433145144c06a077825be
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Thu Aug 6 15:22:07 2020 +0100
Bug 26161: Move actions under rhs fieldsets
This patch moves the action buttons div to within the column div that
contains the 'This sale' and 'Collect payment' fieldsets.
Test plan
1/ Apply patch
2/ Navigate to the 'Point of sale' page (having enabled UseCashRegisters
and EnablePointOfSale)
3/ Confirm the 'Confirm' and 'Cancel' button/link now appear on the
correct side.
4/ Signoff
Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 3d2a988809eddc4cdd3469aa5dc2a8f25252306b
Author: Timothy Alexis Vass <timothy_alexis.vass at ub.lu.se>
Date: Fri Aug 7 14:59:16 2020 +0200
Bug 26179: Remove redundant import of Google font
Removed redundant @import of google font
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit ed4fc5889467bde858cfd4ac573cd40a5b4279c5
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Jul 29 16:49:14 2020 +0200
Bug 26012: Correctly format "paid for" info on the item details view
The string is built controller side, which does not let the template
format the info nicely.
We want to display patron's info using patron-title.inc and the date
with the KohaDates plugin
Test plan:
- Make sure there is a replacement cost in the item
- check it out
- Mark it lost
- Pay the lost item fee
- Go to the detail page and look on the items tab for the item
- It will show an entry with "Paid for?" label
The patron's info and date must be correctly formatted
Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 81f06881a45d7647481aa8a21354a772f3daff88
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Aug 7 12:44:28 2020 +0200
Bug 26165: Fix duplication of large saved reports
If the combined character length of a saved report's
title, notes and SQL is too long then pressing the
'duplicate' button will lead to an error:
"Request-URI Too Long
The requested URL's length exceeds the capacity limit
for this server."
Test plan:
1. Create a simple SQL report and add a lot of text
into the notes field (the combined URL lenth must be
>8225 characters)
2. Save the report
3. Press the duplicate the report from the saved reports page
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 19d9ba176dea6b7816a33b014a5f9e309af53dc0
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Mon Jun 29 15:07:10 2020 +0200
Bug 23542: Fix SRU import encoding
When importing records from a SRU server, the diacritics have bad encoding.
I reproduce with BNF server so it may be a UNIMARC issue.
Tests show that difference between Z39.50 server and SRU is that leader contains 'a' at postion 9.
Looking at MARC::Record->encoding() shows that encoding depends on leader even for UNIMARC.
So this patch adds a call to MARC::Record->encoding('UTF-8') in case of a SRU server in C4::Breeding.
Same use exists in Koha::MetadataRecord::Authority::get_from_breeding().
In case of import via Z3950, MarcToUTF8Record() is called,
which calls SetMarcUnicodeFlag(),
which calls MARC::Record->encoding('UTF-8')
Test plan :
1) Use a UNIMARC database
2) Configure a connexion to a UNIMARC SRU, for example BNF,
see https://doc.biblibre.com/koha/autour_de_koha/serveurs_z3950_sru#serveur_de_la_bnf
3) Go to cataloguing module
4) Click on 'New from Z39.50/SRU'
5) Choose only the SRU target
6) Search for ISBN 2266072889
7) Confirm you see good encoding : diacritic on 'a' of title 'Strate-a-gemmes'
8) Click on 'Marc preview'
9) Confirm you see good encoding
10) Click import
11) Confirm you see good encoding
12) Check also Authorities import via SRU
13) Check also SRU imports on a MARC21 database
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Amended: Removed change to new_from_xml call. We should respect syntax.
But the added MARC::Record encoding does the tric! Which is implicit
for Z3950 targets where MarcToUTF8Record does the same.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit a2b2426de842ac86048cbf71e3760b6483fc0b3c
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Jun 26 13:19:47 2020 +0000
Bug 25882: Remove phr indicator from limits when processing
We assume all limits from advanced search to be a phrase and quote them
when doing this we should remove the phrase marker to avoid doulbe quoting
To test:
1 - Have koha using ES
2 - Go to advanced search
3 - Limit by a single itemtype that exists
4 - Get some results
5 - Limit by a different itemtype that exists
6 - Get some results
7 - Limit by both itemtypes
8 - Get only the results for the second itemtype
9 - Enable DumpTemplateVarsIntranet and DumpSearchQueryTemplate
10 - Repeat search
11 - View page source and find 'search_query'
12 - See limit looks like itype:("("BK")" OR "("CR")")
13 - Apply patches
14 - Restart all the things
15 - Repeat search for both itemtypes
16 - Note results now include both types
Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 1a2d7f1eacc0722ea0723577823ee6a477a46b0a
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Jun 26 13:19:32 2020 +0000
Bug 25882: Unit test
Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
-----------------------------------------------------------------------
Summary of changes:
C4/Breeding.pm | 2 +
C4/Circulation.pm | 18 +-
C4/Items.pm | 17 +
Koha/CirculationRules.pm | 30 ++
Koha/RefundLostItemFeeRules.pm | 179 --------
Koha/SearchEngine/Elasticsearch/QueryBuilder.pm | 1 +
acqui/neworderempty.pl | 4 +-
admin/columns_settings.yml | 57 +++
admin/smart-rules.pl | 6 +-
catalogue/moredetail.pl | 6 +-
catalogue/search.pl | 4 +-
cataloguing/addbiblio.pl | 6 +-
cataloguing/additem.pl | 4 +-
debian/docs/koha-indexer.xml | 7 +
debian/scripts/koha-indexer | 5 +-
koha-tmpl/intranet-tmpl/js/browser.js | 10 +
.../prog/en/includes/reports-toolbar.inc | 2 +-
.../prog/en/modules/admin/columns_settings.tt | 6 +
.../prog/en/modules/authorities/detail.tt | 8 +-
.../intranet-tmpl/prog/en/modules/basket/basket.tt | 1 -
.../prog/en/modules/catalogue/advsearch.tt | 10 +
.../prog/en/modules/catalogue/detail.tt | 3 +
.../prog/en/modules/catalogue/moredetail.tt | 2 +-
.../prog/en/modules/members/memberentrygen.tt | 78 ++--
.../prog/en/modules/members/moremember.tt | 26 ++
koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt | 19 +-
.../prog/en/modules/reports/catalogue_stats.tt | 56 ++-
.../en/modules/reports/guided_reports_start.tt | 2 +-
.../prog/en/modules/reports/orders_by_budget.tt | 21 +-
.../prog/en/modules/tools/batchMod-del.tt | 18 +-
.../prog/en/modules/tools/batchMod-edit.tt | 13 +-
koha-tmpl/intranet-tmpl/prog/js/cart.js | 29 +-
koha-tmpl/intranet-tmpl/prog/js/catalog.js | 4 +-
koha-tmpl/intranet-tmpl/prog/js/members.js | 1 +
.../bootstrap/css/bootstrap-theme-oai.css | 7 +-
koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss | 7 +-
.../opac-tmpl/bootstrap/en/modules/opac-basket.tt | 37 +-
.../en/modules/opac-full-serial-issues.tt | 49 ++-
.../bootstrap/en/modules/opac-serial-issues.tt | 9 +-
members/moremember.pl | 2 +
reports/guided_reports.pl | 33 +-
t/db_dependent/Koha/CirculationRules.t | 127 +++++-
.../Koha/SearchEngine/Elasticsearch/QueryBuilder.t | 9 +-
t/db_dependent/RefundLostItemFeeRule.t | 459 ---------------------
t/lib/TestBuilder.pm | 5 +-
tools/batchMod.pl | 3 +-
46 files changed, 577 insertions(+), 825 deletions(-)
delete mode 100644 Koha/RefundLostItemFeeRules.pm
delete mode 100755 t/db_dependent/RefundLostItemFeeRule.t
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list