[koha-commits] main Koha release repository branch master updated. v20.05.00-677-g9708bbe276
Git repo owner
gitmaster at git.koha-community.org
Wed Aug 19 10:05:02 CEST 2020
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 9708bbe276082ddc2fa4402c2e84e195e4a3a68d (commit)
via 392a7e1a1ffb327986a5c0cb6863bbb87e43deaf (commit)
via 12e1b2faccf6396d3c4b5327c881e78f177f135b (commit)
via e24a294f393defeea12fd0bbfba73839c29d14f0 (commit)
via d3f3a55e0b1544ebcd3166d141e126a4324baab1 (commit)
via 94a445d4138eaa0aaa89c49053b6ced8ca1ee0d1 (commit)
via a0b5cefdc88a3671a0310a90490be275bab46860 (commit)
from 331d7c0e50b1b4fa8eed9b27517fe98cb3d2c8e4 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 9708bbe276082ddc2fa4402c2e84e195e4a3a68d
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Thu Aug 13 13:17:59 2020 +0100
Bug 26039: Focus and Scroll to ShelfBrowser on load
When the shelf browser link is clicked we perform a full page reload
which results in a reset in the context. We should immediately focus the
shelf browser and scroll to that region to highlight the change of
content.
Test plan
1/ Enable shelf browser
2/ Search for an item in the open and navigate to the detail page
3/ Click the 'Browse shelf' link
4/ Note that upon page reload the screen scrolls to the 'Browsing...'
location of the screen.
5/ Note that the 'Browsing...' title is 'focused'
6/ Signoff.
Signed-off-by: Stina Hallin <stina.hallin at ub.lu.se>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
JD amended patch: correctly align JS code
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 392a7e1a1ffb327986a5c0cb6863bbb87e43deaf
Author: Didier Gautheron <didier.gautheron at biblibre.com>
Date: Tue May 26 13:31:31 2020 +0200
Bug 25605: Replace NULL values with '' when downloading a report as a tab separated text
Test plan :
1- Create a new report : select * from items;
2- Run it
3- Download the report as a tab separated text
4- There's a lot of 'use of uninitialized value in join or string at ...koha/reports/guided_reports.pl line xxx.'
in plack-error.log
5- Apply patch
6- Restart all
7- Redo 2 and 3
8- No more warning.
9- diff both downloaded files, they must be the same.
Signed-off-by: Marco Abi-Ramia <marco.abi-ramia at inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 12e1b2faccf6396d3c4b5327c881e78f177f135b
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Aug 6 12:50:36 2020 +0200
Bug 26134: (bug 23463 follow-up) Fix add to basket from staged file
There is a ->store call missing when we attempt to create a new item.
Test plan:
- set at least one value in MARCItemFieldsToOrder
- add to a basket via staged file with at least one value matching your MARCItemFields mappings
- set required fields for your order and click Save
=> Without this patch you got:
receive error: "DBIx::Class::Storage::DBI::_dbh_execute(): Column 'itemnumber' cannot be null at /kohadevbox/koha/Koha/Acquisition/Order.pm line 113
at /usr/share/perl5/DBIx/Class/Exception.pm line 77"
=> With this patch applied the order has been created successfully
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit e24a294f393defeea12fd0bbfba73839c29d14f0
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed Aug 5 18:24:08 2020 +0000
Bug 26153: Remove the use of jquery.checkboxes plugin from items lost report
This patch removes the use of the jquery.checkboxes plugin from the
lost items report page and replaces it with custom JS.
To test, apply the patch and go to Reports -> Lost items.
- Run the report with parameters which will return multiple results.
- On the results page Create a CSV export profile if there's none.
- On the results page test the "Select all" and "Clear all"
links at the top of the results. The controls should work correctly.
Signed-off-by: Didier Gautheron <didier.gautheron at biblibre.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit d3f3a55e0b1544ebcd3166d141e126a4324baab1
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Aug 18 09:59:24 2020 +0000
Bug 26234: Teach our KohaTable constructor the specific th classes
We have different classes we can use to set specific behaviours on
table columns: title-string, string-sort, anti-the and NoSort.
We should not need to pass them to the DataTable constructor, we could
teach it that we always want to apply them.
It will avoid bug like bug 26233
The goal is to define them in a centralised place
(columns_settings.inc) then only use the class on the th
Test plan:
Different behaviour and tables must be tested to confirm it works
correctly. Focus must be put on table when aoColumnsDefs is passed from
the template and confirm that this will add more info to aoColumnsDefs
and not remove the existing ones.
Note that this only work when KohaTable is used.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 94a445d4138eaa0aaa89c49053b6ced8ca1ee0d1
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Tue Aug 18 16:41:09 2020 +0000
Bug 26239: Do not format large negative numbers
At several places we got the following error if we use numbers too big
for Number::Format
Template process failed: undef error - round() overflow. Try smaller
precision or use Math::BigFloat at /home/koha/src/Koha/Number/Price.pm line 44
It make the app explodes.
The goal here is to handle these errors gracefully and easily.
We fixed it for positive numbers in bug 15770, but we neglected the case of negative numbers
Test plan:
- Add a manual credit to a patron of 100000000000000
- ISE!
- Apply patch
- Restart all the things
Works perfectly.
Signed-off-by: Amit Gupta <amit.gupta at informaticsglobal.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit a0b5cefdc88a3671a0310a90490be275bab46860
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Aug 19 07:19:09 2020 +0200
Bug 26162: Don't fall into an infinite loop
If something went wrong we do want to stop the script!
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
-----------------------------------------------------------------------
Summary of changes:
Koha/Number/Price.pm | 3 +--
acqui/addorderiso2709.pl | 2 +-
.../prog/en/includes/columns_settings.inc | 15 ++++++++++++++-
.../intranet-tmpl/prog/en/modules/acqui/basket.tt | 6 ------
.../prog/en/modules/acqui/duplicate_orders.tt | 4 ----
.../intranet-tmpl/prog/en/modules/acqui/histsearch.tt | 4 ----
.../intranet-tmpl/prog/en/modules/acqui/lateorders.tt | 5 -----
.../prog/en/modules/admin/authorised_values.tt | 5 +----
.../intranet-tmpl/prog/en/modules/admin/currency.tt | 6 +-----
.../intranet-tmpl/prog/en/modules/admin/itemtypes.tt | 5 +----
.../intranet-tmpl/prog/en/modules/catalogue/detail.tt | 7 -------
.../prog/en/modules/catalogue/issuehistory.tt | 3 ---
.../prog/en/modules/cataloguing/additem.tt | 2 +-
.../prog/en/modules/cataloguing/z3950_search.tt | 1 -
.../intranet-tmpl/prog/en/modules/circ/overdue.tt | 4 ----
.../prog/en/modules/circ/pendingreserves.tt | 5 -----
.../prog/en/modules/circ/view_holdsqueue.tt | 7 ++-----
.../prog/en/modules/circ/waitingreserves.tt | 10 ----------
.../prog/en/modules/course_reserves/course-details.tt | 6 +-----
.../prog/en/modules/members/boraccount.tt | 6 +-----
.../prog/en/modules/members/holdshistory.tt | 4 ----
koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt | 5 -----
.../prog/en/modules/members/readingrec.tt | 4 ----
.../intranet-tmpl/prog/en/modules/patron_lists/list.tt | 10 ++--------
koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt | 7 ++-----
.../prog/en/modules/reports/guided_reports_start.tt | 6 ++----
.../intranet-tmpl/prog/en/modules/reports/itemslost.tt | 9 ++++++---
.../prog/en/modules/reports/orders_by_budget.tt | 4 ----
.../prog/en/modules/serials/subscription-detail.tt | 1 -
.../prog/en/modules/suggestion/suggestion.tt | 4 ----
koha-tmpl/intranet-tmpl/prog/js/cataloging_additem.js | 3 ---
.../opac-tmpl/bootstrap/en/includes/shelfbrowser.inc | 4 ++--
.../bootstrap/en/modules/opac-course-details.tt | 4 ----
.../bootstrap/en/modules/opac-course-reserves.tt | 2 --
.../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 18 +++++++++++-------
reports/guided_reports.pl | 2 +-
t/Number/Price.t | 3 ++-
t/lib/Selenium.pm | 8 +++++++-
38 files changed, 59 insertions(+), 145 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list