[koha-commits] main Koha release repository branch master updated. v20.05.00-709-g112e2788c5
Git repo owner
gitmaster at git.koha-community.org
Thu Aug 20 13:01:45 CEST 2020
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 112e2788c52e8d805735ae9eee7c606755994815 (commit)
via 7e2514ac36e14aceef48d60e57aa97239fcd61b5 (commit)
via 51e70ef88556e1cffff54d6c58d5d529c75d17cf (commit)
via bb0cd3d229dec57bdef0016118417a4e326b12f5 (commit)
via 0a651f9ee7770a24282c51cc8d4073dc01d99cab (commit)
via 9aa5eb713d77b8363eb214e59fbc2c7d6b42ee6e (commit)
via 1971babc6cf1e5b61145905ab392b9f53bcdecd7 (commit)
via 9d807113dc082255ded81279544b53ee3e15168e (commit)
via dd1eec2715b465c74339c9282f97a3be3102cc2b (commit)
via 79da9442463e655016e1c9c8b12083c72e4b93ba (commit)
via 32c26620725ddcb05d0a9f0b742def7bd33d34ff (commit)
via 05a156fe08fb35d9c9076f47b8047c8834af2a2b (commit)
via 6aba6f0dfb333449d974685135eba526b9d5c44f (commit)
via 37d13fb07deda53fddc69368f538f49c01645143 (commit)
via 79848a276ec496d564c8037bee4832d59c9045c4 (commit)
via 87576a0568d9793b0c6f5231b35c0e2864f9bd8a (commit)
via 1bfe4f50aab4f86e5dc39ebe43105f426e345ed7 (commit)
via 480aca366de6e5c9c07570fa41773cd44ec5beeb (commit)
via 7f0bdc97c27b5449fd07bfb00d6200812dd92848 (commit)
via 1d1efa4a04659f303fc7830bcfe7d79ea8325c87 (commit)
via d46fa45dbfda455d76acc8dbda65d6f4b94d28e7 (commit)
via 58edcef03d257da9d4e6f95a4b081a68071bbf82 (commit)
via 9205d4ef450327fb6a9b235747c55b82a8a6ca37 (commit)
via 198bbfa4094da1bfe143eb046d0c36bf68a93ab9 (commit)
via c3680149be734959d8b59223b083efdfb271580d (commit)
via 84cbf0b9379d025d68f381e6dc7ca3772cc7d093 (commit)
via a3a09d09e3b32c0a0f2e9b7acf652abeab694353 (commit)
via b05448311fd6db94410ffaae1de62b76757544f3 (commit)
via 52f91af5bcd3ca4ec82463764dcaace6dcc0b2ae (commit)
via af0929abbb72c9c2469b1f2ccba338f51801ad98 (commit)
via b5a36c20a20721e82820ccaaf139285beadbaaf0 (commit)
via 909755e5f66adea521a5b516c86bfdb5a83f6b0d (commit)
from 9708bbe276082ddc2fa4402c2e84e195e4a3a68d (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 112e2788c52e8d805735ae9eee7c606755994815
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Aug 20 11:49:08 2020 +0200
Bug 18501: Fix QA issues
FAIL Koha/Item.pm
FAIL critic
# Variables::ProhibitConditionalDeclarations: Got 1 violation(s).
FAIL spelling
Retreive ==> Retrieve
appropriatly ==> appropriately
somehwere ==> somewhere
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 7e2514ac36e14aceef48d60e57aa97239fcd61b5
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Fri Aug 14 17:18:12 2020 +0100
Bug 18501: (QA follow-up) Fix regressions highlighted by unit tests
The migration of unit tests in the preceeding patch highlighted a few
regressions which are dealt with here.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 51e70ef88556e1cffff54d6c58d5d529c75d17cf
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Fri Aug 14 17:16:04 2020 +0100
Bug 18501: (QA follow-up) Migrate and update unit tests
This patch moves the _FixAccountForLostAndFound tests from Circulation.t
to Koha/Items.t and updates then to call an item store as aposed to the
now removed _FixAccountForLostAndFound method.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit bb0cd3d229dec57bdef0016118417a4e326b12f5
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Fri Aug 14 11:53:59 2020 +0100
Bug 18501: (QA follow-up) Remove FIXME + Track issue_id
We correct some compilation errors here by updating the transfered
_FixAccountForLostAndFound method to use $self references. We add
issue_id tracking so that future reports can clearly see how a refund
relates to the original charge and finally we remove a FIXME as I agree
that the 'discard_changes' call is not required.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 0a651f9ee7770a24282c51cc8d4073dc01d99cab
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Aug 14 10:51:39 2020 +0200
Bug 18501: Adjust condition for flagging an item found
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 9aa5eb713d77b8363eb214e59fbc2c7d6b42ee6e
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Aug 14 10:48:00 2020 +0200
Bug 18501: set the is_refunded flag as internal var
After discussion with Martin we decided that it could be the correct way
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 1971babc6cf1e5b61145905ab392b9f53bcdecd7
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Aug 14 09:56:41 2020 +0200
Bug 18501: wip - need to know it has been refunded
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 9d807113dc082255ded81279544b53ee3e15168e
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Aug 13 18:42:56 2020 +0200
Bug 18501: but.. what was the meaning of holdingbranch here?
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit dd1eec2715b465c74339c9282f97a3be3102cc2b
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Aug 13 18:42:01 2020 +0200
Bug 18501: Add _set_found_trigger
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 79da9442463e655016e1c9c8b12083c72e4b93ba
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Aug 10 16:51:11 2020 +0200
Bug 18501: Auto refund if mark as found from cataloguing
If an item is marked as found (ie. not itemlost) we need to refund the
patron.
Test plan:
Mark an item as lost to create a fee for the patron
Mark it as found from the cataloguing module and confirm that the patron
is refunded
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 32c26620725ddcb05d0a9f0b742def7bd33d34ff
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Aug 12 15:45:24 2020 +0200
Bug 18501: Remove the borrowernumber parameter
It was not used
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 05a156fe08fb35d9c9076f47b8047c8834af2a2b
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Aug 10 16:39:08 2020 +0200
Bug 18501: Prepare the ground
This code was duplicated and we are going to need it.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 6aba6f0dfb333449d974685135eba526b9d5c44f
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Tue Aug 18 13:26:29 2020 +0100
Bug 18501: (QA follow-up) Add test of *_on functionality
This patch adds a test for the *_on trigger functionality to ensure
matching behaviour before and after the triggers change.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 37d13fb07deda53fddc69368f538f49c01645143
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Aug 20 10:27:33 2020 +0000
Bug 19036: DBRev 20.06.00.026
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 79848a276ec496d564c8037bee4832d59c9045c4
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Wed Aug 19 12:17:32 2020 +0100
Bug 19036: (follow-up) Improve test output
This patch adds proper detail to the test output for the newly
introduced AutoCreditNumber feature and fixes the final test by adding
the 'interface' and 'amount' parameters to the Koha::Account::Line being
created so that we reach the Exception we are trying to catch and don't
die early.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 87576a0568d9793b0c6f5231b35c0e2864f9bd8a
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Aug 18 17:37:45 2020 +0200
Bug 19036: Add missing test
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 1bfe4f50aab4f86e5dc39ebe43105f426e345ed7
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Thu Aug 6 12:28:48 2020 +0100
Bug 19036: (QA follow-up) Add credit_number handling to POS
This patch adds the display of 'credit_number' as a replacement for the
internal 'accountlines_id' as the transaction identifier on the
register summary page when using cash registers.
Test plan
1/ Enable 'UseCashRegisters'
2/ Enable 'EnablePointOfSale'
3/ Enable at least one 'Debit type' to allow 'sale'
4/ Add at least one 'Cash register'
5/ Enable 'AutoCreditNumber'
6/ 'Enable automatic generation of credit number' for the 'Purchase'
credit type
7/ Pay for an item via the Point of Sale page
8/ Navigate to the 'register' page to display the purchase details
9/ Confirm that the 'Transaction' is listed with a number of the form
specified in the 'AutoCreditNumber' preference
10/ Refund an item from this screen
11/ Note that the 'accountlines_id' is used for this refund as we did
not specify the 'Refund' credit type to use the 'AutoCreditNumber'
system
12/ Signoff
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 480aca366de6e5c9c07570fa41773cd44ec5beeb
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Thu Aug 6 11:34:35 2020 +0100
Bug 19036: (QA follow-up) Fix 'out-by-one' error on table
This patch fixes the total row where the column count was out by one.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 7f0bdc97c27b5449fd07bfb00d6200812dd92848
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Fri Jul 10 11:31:33 2020 +0100
Bug 19036: (QA follow-up) Fix test plan
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 1d1efa4a04659f303fc7830bcfe7d79ea8325c87
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Thu Jun 25 10:43:03 2020 +0100
Bug 19036: DBIC Schema Updates
Dumped schema updates + manual addition of boolean flags
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit d46fa45dbfda455d76acc8dbda65d6f4b94d28e7
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Thu Jun 25 10:16:45 2020 +0100
Bug 19036: (QA follow-up) Use Koha::DateUtils
This patch replaced raw DateTime->now calls with dt_from_string from
Koha::DateUtils
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 58edcef03d257da9d4e6f95a4b081a68071bbf82
Author: Julian Maurice <julian.maurice at biblibre.com>
Date: Tue Mar 24 10:14:03 2020 +0100
Bug 19036: Add ability to enable credit number for only some credit types
This feature is disabled by default for all credit types. To enable it
you have to set the syspref AutoCreditNumber to the value of your choice
and then enable the feature for each credit type you want.
System credit types can be modified too (but only this particular field
can be modified)
Also, throw an exception when the feature is enabled and a value for
credit_number has already been set
Updated test plan:
Test plan:
0. Apply patch, run updatedatabase and update_dbix_class_files
1. Go to Admin » Column settings, and uncheck the 'hidden' box for
column credit_number in table account-fines. It will be easier for
testing
2. Create a manual credit for a borrower. Verify in Transactions tab
that this credit has no number generated
3. In Admin » Credit types:
a. edit the FORGIVEN type and enable credit number generation
b. create a new type A, check "can be manually added" and "enable
credit number"
c. create a new type B, check "can be manually added". Do NOT enable
credit number
4. Change syspref 'AutoCreditNumber' to 'incremental'
5. Create more manual credits with types CREDIT and B, and verify that
the numbers are not generated
6. Create more manual credits with types FORGIVEN and A, and verify that
the numbers generated are 1, 2, 3, ...
7. Change syspref 'AutoCreditNumber' to 'annual'
8. Create more manual credits with types CREDIT and B, and verify that
the numbers are not generated
9. Create more manual credits with types FORGIVEN and A, and verify that
the numbers generated are '2020-0001', '2020-0002', ...
10. Change syspref to 'AutoCreditNumber' to 'branchyyyymmincr'
11. Create more manual credits with types CREDIT and B, and verify that
the numbers are not generated
12. Create more manual credits with types FORGIVEN and A, and verify
that the numbers generated are 'BRANCHA2020020001',
'BRANCHA2020020002', ... (assuming you are connected to library
BRANCHA, and it's February 2020)
13. Set library to another one, say BRANCHB
14. Create more manual credits with types FORGIVEN and A, and verify
that the numbers generated are 'BRANCHB2020020001',
'BRANCHB2020020002', ...
15. Edit the letter ACCOUNT_CREDIT, and add [% account.credit_number %]
somewhere. Go back to Transactions tab and click on 'Print' for one
line that has a credit number. Make sure the number is there.
16. prove t/db_dependent/Koha/Account.t
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 9205d4ef450327fb6a9b235747c55b82a8a6ca37
Author: Julian Maurice <julian.maurice at biblibre.com>
Date: Thu Feb 20 10:02:38 2020 +0100
Bug 19036: Add ability to auto generate a number for account credits
In some areas it's required to sequentially number payment slips /
receipts.
This patch adds a database column accountlines.credit_number and a
system preference AutoCreditNumber to control how this number will be
generated. The following options are available:
- Do not automatically generate credit numbers.
This is the current behaviour and the default syspref value.
- Automatically generate credit numbers in the form <year>-0001 (annual)
- Automatically generate credit numbers in the form
<branchcode>yyyymm0001 (branchyyyymmincr)
where <branchcode> is the branch where the user (staff member) is
logged in
- Automatically generate credit numbers in the form 1, 2, 3
(incremental)
It also adds a column (hidden by default) in the table under
Transactions tab to display this number.
Test plan:
0. Apply patch, run updatedatabase and update_dbix_class_files
1. Go to Admin » Column settings, and uncheck the 'hidden' box for
column credit_number in table account-fines. It will be easier for
testing
2. Create a manual credit for a borrower. Verify in Transactions tab
that this credit has no number generated
3. Change syspref 'AutoCreditNumber' to 'incremental'
4. Create more manual credits, and verify that the numbers generated are
1, 2, 3, ...
5. Change syspref 'AutoCreditNumber' to 'annual'
6. Create more manual credits, and verify that the numbers generated are
'2020-0001', '2020-0002', ...
7. Change syspref to 'AutoCreditNumber' to 'branchyyyymmincr'
8. Create more manual credits, and verify that the numbers generated are
'BRANCHA2020020001', 'BRANCHA2020020002', ... (assuming you are
connected to library BRANCHA, and it's February 2020)
9. Set library to another one, say BRANCHB
10. Create more manual credits, and verify that the numbers generated are
'BRANCHB2020020001', 'BRANCHB2020020002', ...
11. Edit the letter ACCOUNT_CREDIT, and add [% account.credit_number %]
somewhere. Go back to Transactions tab and click on 'Print' for one
line that has a credit number. Make sure the number is there.
12. prove t/db_dependent/Koha/Account.t
Signed-off-by: Michal Denar <black23 at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 198bbfa4094da1bfe143eb046d0c36bf68a93ab9
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Aug 20 12:27:05 2020 +0200
Bug 25242: Compiled CSS
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit c3680149be734959d8b59223b083efdfb271580d
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Wed Aug 19 08:36:03 2020 +0100
Bug 25242: (QA follow-up) Remove deprecated break-word
It appears break-word is now deprecated in Firefox and instead all
browsers now support break-all as the definitive.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 84cbf0b9379d025d68f381e6dc7ca3772cc7d093
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Tue Aug 18 10:35:59 2020 +0100
Bug 25242: (QA follow-up) Colwidth on results table
Prior to this patch, the column width on the opac-results table were not
fixed or calculated by a datatable; As such when we introduced the
'table-layout: fixed' property all columns were given equal share of the
table, which resulted in most cases in a three way split between a
checkbox, an empty cell and the actual content.
This patch sets the width for the selectcol to '1ch' for the single
character checkbox and updates the second columns class to 'numcol' as
it is not used for selection but rather result numbering and sets a
fixed width of '4ch' allowing for results upto 3 digits (plus the
period) to display correctly without wrapping.
Test plan
1/ Apply the patches and run the yarn build process to update the .css
2/ Perform a search and varify that the results table looks reasonable
3/ Disable OPACHiddenItems and perform a search again.
4/ Confirm the table looks reasonable still
5/ Signoff
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit a3a09d09e3b32c0a0f2e9b7acf652abeab694353
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Thu Aug 6 13:29:54 2020 +0100
Bug 25242: Improve column wrapping and overflow for tables
This patch attempts to improve the column wrapping and prevent
datatabels from overlapping with other content on high zoom levels/low
width screen sizes.
Test plan
1/ Build the OPAC CSS from the updated SCSS
2/ Navigate to various tables in the OPAC (Holds table is a good one)
and 'play' with various window sizes and zoom levels.
3/ The table should not overlap with right navigation content
4/ Signoff
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit b05448311fd6db94410ffaae1de62b76757544f3
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Aug 18 16:44:34 2020 +0200
Bug 25430: Use label-default for 0
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 52f91af5bcd3ca4ec82463764dcaace6dcc0b2ae
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Fri May 8 13:15:40 2020 -0400
Bug 25430: Improve the styling of the claims returned tab
It has been suggested that it would be useful to add title attributes to the different numbers on the return claims tab in the checkouts and patron details pages. In addition, color coding them ( and removing the slash ) will make the numbers easier to read.
Test Plan:
1) Set up return claims for your system
2) Apply this patch
3) View the claims tab for someone with not claims, and someone with claims
4) Note the resolved claims are green and have a "tooltip" when hovered over
5) Note the unresolved claims are green if 0, and yellow if not 0, and
also have a "tooltip"
Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit af0929abbb72c9c2469b1f2ccba338f51801ad98
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Jun 1 10:19:05 2020 +0200
Bug 25626: Fix untranslatable strings on the 'OPAC problem reports' admin
The 'Sent to' and 'Status' column values were not translatable.
Test plan:
Translate the interface
Report some problems at the OPAC
Go to the admin page and notice that all the columns are now translated
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit b5a36c20a20721e82820ccaaf139285beadbaaf0
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date: Wed Jul 29 13:23:14 2020 +0100
Bug 26082: Call store on new items to update itemnumber
Need to add call to store to Koha::Item->new so that itemnumber
is returned - otherwise is not defined and causes an error
Bug is a side-effect of Bug 23463 as this was implicitly
done in AddItem
Also set biblioitemnumber explicitly for item adds this also
used to be done explicitly but can now cause an FK error
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 909755e5f66adea521a5b516c86bfdb5a83f6b0d
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Wed Aug 19 11:46:16 2020 +0000
Bug 26251: Remove unused routines from svc/split_callnumbers
This is just a copy and paste from svc/localization
Test plan:
Read the code.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
-----------------------------------------------------------------------
Summary of changes:
C4/Circulation.pm | 162 +----
Koha.pm | 2 +-
Koha/Account/Line.pm | 65 ++
Koha/EDI.pm | 9 +-
Koha/Item.pm | 188 +++++-
Koha/Schema/Result/AccountCreditType.pm | 18 +-
Koha/Schema/Result/Accountline.pm | 14 +-
admin/columns_settings.yml | 3 +
admin/credit_types.pl | 12 +-
cataloguing/additem.pl | 5 +-
installer/data/mysql/kohastructure.sql | 2 +
installer/data/mysql/sysprefs.sql | 1 +
installer/data/mysql/updatedatabase.pl | 20 +
.../prog/en/modules/admin/credit_types.tt | 59 +-
.../en/modules/admin/preferences/accounting.pref | 8 +
.../prog/en/modules/circ/circulation.tt | 18 +-
.../prog/en/modules/members/boraccount.tt | 4 +-
.../prog/en/modules/members/moremember.tt | 19 +-
.../intranet-tmpl/prog/en/modules/pos/register.tt | 14 +-
.../prog/en/modules/tools/problem-reports.tt | 18 +-
koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 20 +-
koha-tmpl/opac-tmpl/bootstrap/css/opac.css | 2 +-
koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss | 11 +
.../opac-tmpl/bootstrap/en/modules/opac-results.tt | 2 +-
svc/split_callnumbers | 74 +--
t/db_dependent/Circulation.t | 435 +------------
t/db_dependent/Koha/Account.t | 78 ++-
t/db_dependent/Koha/Items.t | 705 ++++++++++++++++++++-
28 files changed, 1211 insertions(+), 757 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list