[koha-commits] main Koha release repository branch master updated. v20.05.00-862-g092276f53c
Git repo owner
gitmaster at git.koha-community.org
Mon Aug 31 16:48:16 CEST 2020
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 092276f53c0b82c1311afe9425d13d83a528ca12 (commit)
via d6e72c0de288ade8a2d69f101754d51db6162811 (commit)
via 2793e4558082e4ff50315b433d50490036014e28 (commit)
via 0de40dd877defd4190c2ec45676c4f5261fc13f9 (commit)
via fee0b9310e5b58835c7bfabdcee75f956a381a81 (commit)
via c1be2b8817c27c767f9f2ca2939f6b8f3013d7e2 (commit)
via 785265aea0ffed9612bd53b25f36642ed03276a4 (commit)
via 18d42db176d5fd29ddd07b4fc8b93a378087ffc5 (commit)
via cb9c48a6f6ae52d8ba5ec4475758d0faf529ec80 (commit)
via bcf9b259c5fcc1a52772efc82d4c8eec24fcf3c9 (commit)
via 93fdca520943874143c783f68025c7a9d2d0fca3 (commit)
via 34a42570dcf52087b15aeb3605dbb27da9a18a82 (commit)
via 05e5210194c87a2f5378ce314250b8f488391528 (commit)
via 28d826263b16b6df7ff1bccc0e06211c2de7cfaf (commit)
via 9c9dddeaa46bc605dd319db0538e3e6d2e151ff1 (commit)
via 5fd8774c687c6aaf6716485ab9bd72a69a0e2f76 (commit)
via faa4b2aa62a02aca7f986cfc411402b1ce7ae076 (commit)
via f9ab4f0aac8ac3085257dd73d4fc842edbf459f5 (commit)
via d01f5f6e8f1e643ada9801bceab6250e2f3a6aab (commit)
via 5a87514b2e44d64807422b29f719b29b0c9d1ba4 (commit)
via ce161fda9b7d47e3cfcbc73ddb877eed627d6313 (commit)
via c96fabb8c47320dba55372e4b955fb171310adec (commit)
via 224ac84aeca3b8dba87366925d83b01e0f5c1110 (commit)
via e34f95a1f5eb0fce238ab442553bec5233263a9c (commit)
via a4e922ffe8a5ea760f2401aca44b1dd9be97c7ec (commit)
via 9ea7907618a144d03d9e337f79d3dbc26603a919 (commit)
via 5c161c145b7fa2dc2ccf62124cffe1da26b6339e (commit)
via 40393adc0fd80bc5dc129931efce390dea4b42a0 (commit)
via ed066caf580630c476fe4918a00e5d88e8784441 (commit)
via d39d5b20d6dfe22b3a5ed80eb4e2c717ddcc7f5a (commit)
via cf93255428125241745faaaec0a0b1f8455c7526 (commit)
via 8c92eda71933421ceac596bda7c1601314c72841 (commit)
via 671f2b86a9aa5861cd0f7d605afc15118695866f (commit)
via 4b43c886a0ce030e50c894f941665b7c92d50f00 (commit)
via d390b2f7cfe947011a80c9441ca0a8a00e2f38f0 (commit)
via 64340cfa520b0d5ff9289afb628e3b7e7c31df3d (commit)
via 2c143ca4609837932643e6d1564896fe8c6ab229 (commit)
via ee50e8678400696d69f87e8117487efb29256e3b (commit)
via e7910c67403f73ffc247c466d2336a446c4ca092 (commit)
via 5cb1d95b02dcd6f9a38f3cbfd3f2effa14a96f3c (commit)
via 33265c07f49cfaa07a086d45cae4e5d385994f01 (commit)
via b12198a53feff9aad0f08160505477b50d0421b0 (commit)
via 2f1665151f719eaab9c9546facaaaad7882de297 (commit)
from ef3b7eedc0efc726329f2f608c0f676e93fd5566 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 092276f53c0b82c1311afe9425d13d83a528ca12
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Aug 31 14:05:05 2020 +0000
Bug 19889: DBRev 20.06.00.032
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit d6e72c0de288ade8a2d69f101754d51db6162811
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Aug 31 14:44:10 2020 +0200
Bug 19889: Add select2 class to the new dropdown list
This is needed since bug 25727.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 2793e4558082e4ff50315b433d50490036014e28
Author: Agustin Moyano <agustinmoyano at theke.io>
Date: Tue Aug 25 17:10:28 2020 -0300
Bug 19889: (follow-up) Fix text in moredetail.tt
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 0de40dd877defd4190c2ec45676c4f5261fc13f9
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Aug 20 10:36:23 2020 +0000
Bug 19889: (QA follow-up) Check that exclude from local holds priority is set and not a blank string
Signed-off-by: Agustin Moyano <agustinmoyano at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit fee0b9310e5b58835c7bfabdcee75f956a381a81
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Wed Aug 19 12:21:27 2020 +0000
Bug 19889: (QA follow-up) use em over i and update field if unset
em is better for accessibility
We should set the field to 0 when it was previously unset
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit c1be2b8817c27c767f9f2ca2939f6b8f3013d7e2
Author: Agustin Moyano <agustinmoyano at theke.io>
Date: Thu Aug 13 10:04:32 2020 -0300
Bug 19889: (follow-up) Fix few minor things
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
JD amended patch: remove unecessary indentation changes
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 785265aea0ffed9612bd53b25f36642ed03276a4
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Aug 7 11:17:59 2020 +0200
Bug 19889: (follow-up) Add tests
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 18d42db176d5fd29ddd07b4fc8b93a378087ffc5
Author: Agustin Moyano <agustinmoyano at theke.io>
Date: Thu Aug 6 15:54:49 2020 -0300
Bug 19889: (follow-up) Fix overlapping blue box and message in batch item modification
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit cb9c48a6f6ae52d8ba5ec4475758d0faf529ec80
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Wed Jul 22 11:21:39 2020 -0400
Bug 19889: Add feedback when exclusion is updated on moredetail.pl
Signed-off-by: Christopher Brannon <cbrannon at cdalibrary.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit bcf9b259c5fcc1a52772efc82d4c8eec24fcf3c9
Author: Agustin Moyano <agustinmoyano at theke.io>
Date: Wed Jun 10 16:18:01 2020 -0300
Bug 19889: Make it possible to exclude items and categories from local holds priority
This patch adds the ability to exclude patrons (by category) from local
holds, and items, by editing the item itself or by batch item
modification tool.
To test:
1. apply patches
2. updatedatabase
3. Enable LocalHoldsPriority preference, and leave
LocalHoldsPriorityPatronControl in pickup library, and
LocalHoldsPriorityItemControl in holding library.
4. Search for a biblio with one item.
5. Place a hold with a patron (patron1) and set pickup location to a different
library of the item's home library
6. Place another hold with another patron (patron2) and set pickup location to be
the same as the item's home library
7. ./misc/cronjobs/holds/build_holds_queue.pl
8. Go to circulation -> holds queue
9. Search by the item's home library
CHECK => only the hold for patron2 (with the pickup location the same as the
item's home library) appears in the table
10. Go back to the biblio details page and click on "Items" tab
CHECK => There is a new section in the item's details between "Statuses"
and "History" called "Priority"
11. Set exclude to "Yes" and update
12. repeat steps 7 to 9
SUCCESS => only the hold for patron1 now appears, even the other hold had local
hold priority
13. Repeat step 10 and 11 but this time set exclude to "No"
14. repeat steps 7 to 9
CHECK => the hold for patron2 is back
15. Edit patron2's category and set exclude from local holds priority to
"Yes"
16. Repeat steps 7 to 9
SUCCESS => the hold for patron1 is back
17. Go to tools -> Batch item modification and in barcode list place
several (existing) barcodes and press continue
CHECK => There is a new section in the bottom called "Priority"
18. Set exclude to "Yes" and save
SUCCESS => all items in the list now have exclude setted to "Yes"
19. Try to checkout the first item to a patron3
SUCCESS => Alert message appears saying that patron1 has a hold on that
item
20. Click on Yes and then checkin that item
SUCCESS => There is a modal window saying that a hold was found for
patron1
21. prove t/db_dependent/HoldsQueue.t t/db_dependent/Holds/LocalHoldsPriority.t
22. Sign off
Sponsored-by: Cooperative Information Network (CIN)
Signed-off-by: Christopher Brannon <cbrannon at cdalibrary.org>
Signed-off-by: Christopher Brannon <cbrannon at cdalibrary.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 93fdca520943874143c783f68025c7a9d2d0fca3
Author: Agustin Moyano <agustinmoyano at theke.io>
Date: Wed Jun 10 16:15:55 2020 -0300
Bug 19889: Add tests
Sponsored-by: Cooperative Information Network (CIN)
Signed-off-by: Christopher Brannon <cbrannon at cdalibrary.org>
Signed-off-by: Christopher Brannon <cbrannon at cdalibrary.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 34a42570dcf52087b15aeb3605dbb27da9a18a82
Author: Agustin Moyano <agustinmoyano at theke.io>
Date: Wed Jun 10 16:14:41 2020 -0300
Bug 19889: set exclude_from_local_holds_priority columns as boolean in schema
Sponsored-by: Cooperative Information Network (CIN)
Signed-off-by: Christopher Brannon <cbrannon at cdalibrary.org>
Signed-off-by: Christopher Brannon <cbrannon at cdalibrary.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
JD Amended patch: fix md5sum
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 05e5210194c87a2f5378ce314250b8f488391528
Author: Agustin Moyano <agustinmoyano at theke.io>
Date: Wed Jun 10 16:13:35 2020 -0300
Bug 19889: Add exclude_from_local_holds_priority columns to item, deleteditems and categories tables
Sponsored-by: Cooperative Information Network (CIN)
Signed-off-by: Christopher Brannon <cbrannon at cdalibrary.org>
Signed-off-by: Christopher Brannon <cbrannon at cdalibrary.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 28d826263b16b6df7ff1bccc0e06211c2de7cfaf
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Wed Aug 19 13:56:08 2020 +0100
Bug 26250: StockRotationItems.t and StockRotationStages.t
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 9c9dddeaa46bc605dd319db0538e3e6d2e151ff1
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Aug 19 14:03:29 2020 +0200
Bug 26250: Fix tests when SearchEngine=Elastic
Most of the time the tests are failing because the item is not created
correctly (missing biblio and/or biblioitem).
The usual error is:
t/db_dependent/selenium/regressions.t ..... 5/5 Can't call method "leader" on an undefined value at /kohadevbox/koha/Koha/SearchEngine/Elasticsearch.pm line 534.
In this patch we are making sure $builder->build({ source => 'Item' })
is replace with $builder->build_sample_item
Test plan:
Turn on Elastic and confirm that all the tests pass!
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 5fd8774c687c6aaf6716485ab9bd72a69a0e2f76
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Aug 21 16:07:46 2020 +0200
Bug 26069: Pass correct URL to twitter
We don't provide the url of the detail page so the twitter JS code
retrieve the current location, with the search terms.
Test plan:
Do a search
Click on a result
Click on the twitter button and confirm that the link only contain
biblionumber=x in the parameter
Signed-off-by: Amit Gupta <amit.gupta at informaticsglobal.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit faa4b2aa62a02aca7f986cfc411402b1ce7ae076
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Thu Aug 27 11:35:16 2020 -0300
Bug 25504: (QA follow-up) Remove unused include
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit f9ab4f0aac8ac3085257dd73d4fc842edbf459f5
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Aug 27 15:26:05 2020 +0200
Bug 25504: Use Koha::Logger and display the full stacktrace
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit d01f5f6e8f1e643ada9801bceab6250e2f3a6aab
Author: Ere Maijala <ere.maijala at helsinki.fi>
Date: Thu Jun 18 16:43:42 2020 +0300
Bug 25504: Improve REST API spec loading errors
Test plan:
1. Introduce a typo in swagger.json or another spec json file.
2. Restart plack if used or try to access the REST APIs
3. Without the patch, verify that an incomplete error message and potentially lots of stack trace are logged.
4. With the patch, verify that much more meaningful error messages are logged and stack trace is omitted.
5. Fix the problem introduced in step 1 and verify that no messages are logged, or only warning about bundle is logged with Debian Stretch.
6. Repeat with a REST API plugin.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 5a87514b2e44d64807422b29f719b29b0c9d1ba4
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Mon Aug 24 14:24:39 2020 +0000
Bug 25273: (follow-up) Don't die on unknown authtype
We are guessing authtype code and inserting the heading built accorindg to C4::Heading
If we can't identify the auth type, we can format the heading. There is a record in the koha test
data that is missing the heading field so type cannot be idenfitied
This prevents us from dying n a record where we cannot identify the type.
Note: This code will also be triggered for custom authority types, higlighting
that they won't link because of hardcoded mappings in C4::Heading. We must tackle this
on a new bug
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit ce161fda9b7d47e3cfcbc73ddb877eed627d6313
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Tue Apr 28 12:19:56 2020 +0000
Bug 25273: Make match-heading rely on authority type configuration
The match-heading field is a special field used only by the linker, not accessible
to staff or patrons via the interface. This field is used to store the constructed
'search form' used for matching bib headings to authority fields.
In bug 24269 I attempted to use the mappings defined in the inferface and also inject the search term.
This did not work as too many subfields were indexed on their own and leading to false matches.
In this bug we remove the mappings for this field, and create it ourselves during
the indexing process. The C4::Headings module is still used to generate the correct form,
however, the mappings are set based on the authority types in the system. This gives the user
the ability to add new typoes, but prevents mapping changes from breaking linker functionality
To test:
1 - Start form a sample database with ElasticSearch working
2 - Download via Z39.50 2 authorities, one of which is a narrower heading of the other, e.g.:
Waterworks
Waterworks - Costs
3 - Place a heading for the broader term in a record. e.g. Waterworks
In 650$a, without the cataloguing authority plugin. We don't want
the link created now.
You need syspref BiblioAddsAuthorities => allow
4 - Make sure linker is set to default
5 - Attempt to link the records
misc/link_bibs_to_authorities.pl
6 - Linking fails
7 - Apply patch
8 - refresh index settings (if using a custom file, remove 'match-heading')
You can reset mappings in the UI or run this:
misc/search_tools/rebuild_elasticsearch.pl -v -d -r
9 - Reindex ES
10 - Try to link again
11 - It succeeds!
12 - Run the tests
prove t/db_dependent/Koha/SearchEngine/Elasticsearch.t
Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Bug 25273: (follow-up)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit c96fabb8c47320dba55372e4b955fb171310adec
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Aug 31 15:25:05 2020 +0200
Bug 17661: Trivial simplification using += operator
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 224ac84aeca3b8dba87366925d83b01e0f5c1110
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Aug 27 16:27:09 2020 +0000
Bug 17661: (follow-up) Update regex to support Unicode characters
Rather than limiting initials to [A-Z] we should test for a broad
range of uppercase letters.
The ES/Zebra changes are slightly different because of Perl vs Java regex
conventions. POerl may support either, but I found 'Uppercase' to be a bit more explicit
More info here:
https://perldoc.perl.org/perlunicode.html
TO test:
Same plan as before but use Ж. as the ending initial
Confirm the period is preserved and other punctuation removed
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit e34f95a1f5eb0fce238ab442553bec5233263a9c
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Nov 2 16:52:53 2017 +0000
Bug 17661: Ending punctuation causes duplicate facets
The current code for facets doesn't pull strip ending punctuation from facets
This causes duplicate facets for terms that should be combined
Sometimes series can have different punctuation depending on the field they are in
Author initials punctuation should be preserved
To test:
1 - Do search and pull up some records
2 - Edit some of the records to have authors like:
Date, C.J.
Date, C.j.
Date, C.J .
3 - Edit the records to have some series statments like:
830 $aDate, C.J. ;$v5
830 $aDate, C.J. ; $v5
830 $aDate, C.J.; $v5
4 - Add some 490s to the record with first indicator 1 and series like:
You wouldn't want to--
You wouldn't want to
You wouldn't want to..
5 - Search again and note you have 3 facets each for author and series
6 - Apply patch
7 - Repeat
8 - Now you get 2 facets for author, period not removed when following Upper case immediately, is otherwise
9 - Now you should have a single series facet
10 - Switch search engine to ES (index before applying patch)
11 - Note facets are separate again
12 - Reset mappings and reindex
perl misc/search_tools/rebuild_elasticsearch -v -r
13 - Repeat search, facets combined as above
Signed-off-by: Sarah Cornell <sbcornell at cityofportsmouth.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit a4e922ffe8a5ea760f2401aca44b1dd9be97c7ec
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue Aug 25 19:30:00 2020 +0000
Bug 26289: Add missing variable definition to templates
This patch puts definition of the missing "searchid" variable into an
include file to be used by various bibliographic detail pages. The
variable is required by several JavaScript functions.
To test, apply the patch and locate or create a record with no items.
Open the labeled MARC view and choose Edit -> Delete record. Confirm the
deletion. The deletion should complete correctly.
Perform the same test with the detail view, ISBD view, MARC view, and
items view.
Signed-off-by: Amit Gupta <amit.gupta at informaticsglobal.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 9ea7907618a144d03d9e337f79d3dbc26603a919
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Tue Aug 25 12:45:58 2020 +0000
Bug 26281: (QA follow-up) Fix missing filter
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 5c161c145b7fa2dc2ccf62124cffe1da26b6339e
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Mon Aug 24 09:22:24 2020 -0400
Bug 26281: Add cancellation reason to holds history
Bug 25534 adds the ability to store the cancellation reason when a hold
is cancelled and communicate it to the user. It would be great if the
cancellation reason could also be shown on the holds history.
Test Plan:
1) Apply this patch
2) Cancel a hold with a reason
4) Browse to holds history for the holds' patron
5) Note the reason shows in the status column if one was provided
Working ok.
Signed-off-by: Amit Gupta <amit.gupta at informaticsglobal.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 40393adc0fd80bc5dc129931efce390dea4b42a0
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Aug 26 12:58:44 2020 +0200
Bug 26015: Replace 2 missing occurrences
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit ed066caf580630c476fe4918a00e5d88e8784441
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Fri Aug 14 17:09:58 2020 +0000
Bug 26015: Terminology: Fix tons more staff clients to staff interfaces
This takes care of more occurences of staff client and changes it to
staff interface, including in code comments.
To test:
- I think in this case careful code review is what we look for.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit d39d5b20d6dfe22b3a5ed80eb4e2c717ddcc7f5a
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Sat Jul 18 01:17:45 2020 +0200
Bug 26015: Terminology: Use staff interface instead of staff client
We have agreed to use 'staff interface' instead of 'staff client'
and similar terms. This fixes the template files where staff client
appears:
To test:
- Check Administration > Patron categories
- Check the title of the staff interface start page in your
browser tab
- Check the description of hte catalogue permission
- One more: this changes the message shown when someone managed
to log in as the database user - as we no longer allow that, I am
not sure if it can be triggered.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit cf93255428125241745faaaec0a0b1f8455c7526
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Wed Jul 29 10:56:37 2020 +0000
Bug 25639: Add search query strings as global javascript variables
To test:
1 - Search on OPAC for "qwertyuiop"
2 - View the HTML source
3 - Find 'qwertyuiop' in the source, it is not easily accessible via JS
4 - Apply patch
5 - Repeat
6 - Note that now there are global variables with the query strings
7 - Add to OpacUserJs:
console.log( query_desc );
console.log( querystring );
console.log( query_cgi );
8 - Reload page and confirm variables are warned in the JS console (Press F12)
9 - Sign off
Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 8c92eda71933421ceac596bda7c1601314c72841
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Aug 31 14:05:05 2020 +0000
Bug 22789: DBRev 20.06.00.031
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 671f2b86a9aa5861cd0f7d605afc15118695866f
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Wed Aug 26 22:36:09 2020 +0200
Bug 22789: (QA follow-up) Some minor formatting changes
- Remove the unordered list added to the holds list Details column
- Switch div to span to have the hint appear behind the checkbox
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 4b43c886a0ce030e50c894f941665b7c92d50f00
Author: Agustin Moyano <agustinmoyano at theke.io>
Date: Tue Aug 25 14:53:55 2020 -0300
Bug 22789: (follow-up) Fix atomic update, GUI and more than one hold
This patch
* sets one check for reserves and another for old_reserves in
atomic update
* Adds a message below the checkbox and adds detail when a hold is non
priority
* Fixes issue when there are more than one hold, but the first is non
priority
* Adds test case for this last scenario
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit d390b2f7cfe947011a80c9441ca0a8a00e2f38f0
Author: Agustin Moyano <agustinmoyano at theke.io>
Date: Wed Aug 19 18:12:32 2020 -0300
Bug 22789: Add non priority feature to C4 classes and staff interface
This patch implements necesary code to implement non priority feature
To test:
1) Apply all patches.
2) Run updatedatabase.
3) Checkout a specific item for patron1.
4) Place a hold on the same item for patron2 (do not check non priority
hold checkbox).
5) Try to renew the item for patron1.
CHECK => in checkouts table, there is a message that the item could not
be renewed because there was a hold.
6) Cleanup all checkouts and holds.
7) repeat steps 3 to 5, but this time check the non priority checkbox.
SUCCESS => item was renewed
8) prove t/db_dependent/Holds.t
Signed-off-by: Lisette Scheer <lisettes at latahlibrary.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 64340cfa520b0d5ff9289afb628e3b7e7c31df3d
Author: Agustin Moyano <agustinmoyano at theke.io>
Date: Wed Aug 19 17:57:55 2020 -0300
Bug 22789: Set non_priority column as boolean in schema
Signed-off-by: Lisette Scheer <lisettes at latahlibrary.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 2c143ca4609837932643e6d1564896fe8c6ab229
Author: Agustin Moyano <agustinmoyano at theke.io>
Date: Wed Aug 19 16:11:01 2020 -0300
Bug 22789: Add non_priority column to reserves and old_reserves
Signed-off-by: Lisette Scheer <lisettes at latahlibrary.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit ee50e8678400696d69f87e8117487efb29256e3b
Author: Agustin Moyano <agustinmoyano at theke.io>
Date: Wed Aug 19 15:50:22 2020 -0300
Bug 22789: Add tests
Signed-off-by: Lisette Scheer <lisettes at latahlibrary.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit e7910c67403f73ffc247c466d2336a446c4ca092
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Aug 31 14:05:05 2020 +0000
Bug 20057: DBRev 20.06.00.030
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 5cb1d95b02dcd6f9a38f3cbfd3f2effa14a96f3c
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Sat May 23 06:23:37 2020 +0000
Bug 20057: Fix capitalization and rephrase system preference as a sentence
This makes changes to strings involved in this feature:
- Rephrases the system preference description into a sentence
- Rephrases message shown in OPAC on submitting (library has not actively
approved, so just say that the record has been modified)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 33265c07f49cfaa07a086d45cae4e5d385994f01
Author: Liz Rea <liz at catalyst.net.nz>
Date: Tue May 19 12:50:04 2020 +0200
Bug 20057: (follow-up) Add text for auto accepted changes
1. Apply patch.
2. Make sure syspref "AutoApprovePatronProfileSettings" is set to "Disable".
3. Edit patron personal details via opac interface.
4. Expect modifications to require manual approval by staff via link on main page.
-> 4a. Text for patron says that changes are pending acceptance by the library
5. Set syspref "AutoApprovePatronProfileSettings" to "Enable".
6. Edit patron personal details via opac interface again.
7. Expect modifications to have been approved automatically.
-> 7a. Text for patron says that changes have been submitted and accepted by the library.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit b12198a53feff9aad0f08160505477b50d0421b0
Author: David Gustafsson <glasklas at gmail.com>
Date: Tue May 19 12:44:31 2020 +0200
Bug 20057: System preference for auto approval of patron profile changes
Testplan for this patch:
1. Apply patch.
2. Make sure syspref "AutoApprovePatronProfileSettings" is set to "Disable".
3. Edit patron personal details via opac interface.
4. Expect modifications to require manual approval by staff via link on main page.
5. Set syspref "AutoApprovePatronProfileSettings" to "Enable".
6. Edit patron personal details via OPAC interface again.
7. Expect modifications to have been approved automatically.
Signed-off-by: Liz Rea <liz at catalyst.net.nz>
This works, we may want some different text for this situation in the OPAC, it still says the librarian has to approve the change.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 2f1665151f719eaab9c9546facaaaad7882de297
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Aug 31 14:37:27 2020 +0200
Bug 25727: (follow-up) Do not open options on clear
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
-----------------------------------------------------------------------
Summary of changes:
C4/Biblio.pm | 5 +-
C4/Circulation.pm | 9 +
C4/HoldsQueue.pm | 5 +-
C4/Reserves.pm | 35 ++-
C4/Search.pm | 6 +-
Koha.pm | 2 +-
Koha/Filter/MARC/ViewPolicy.pm | 2 +-
Koha/REST/Plugin/PluginRoutes.pm | 6 +-
Koha/REST/V1.pm | 63 ++--
Koha/REST/V1/Holds.pm | 2 +
Koha/Schema/Result/Category.pm | 15 +-
Koha/Schema/Result/Deleteditem.pm | 15 +-
Koha/Schema/Result/Item.pm | 15 +-
Koha/Schema/Result/OldReserve.pm | 15 +-
Koha/Schema/Result/Reserve.pm | 15 +-
Koha/SearchEngine/Elasticsearch.pm | 35 ++-
Koha/SearchEngine/Elasticsearch/QueryBuilder.pm | 6 +-
admin/categories.pl | 3 +
admin/preferences.pl | 2 +-
admin/searchengine/elasticsearch/field_config.yaml | 1 +
admin/searchengine/elasticsearch/index_config.yaml | 6 +
admin/searchengine/elasticsearch/mappings.yaml | 24 --
admin/systempreferences.pl | 2 +-
api/v1/swagger/definitions/hold.json | 4 +
api/v1/swagger/definitions/patron.json | 2 +-
api/v1/swagger/paths/holds.json | 10 +
catalogue/moredetail.pl | 4 +
catalogue/updateitem.pl | 8 +-
debian/docs/koha-create.xml | 2 +-
debian/templates/koha-conf-site.xml.in | 2 +-
installer/data/mysql/kohastructure.sql | 23 +-
installer/data/mysql/sysprefs.sql | 42 +--
installer/data/mysql/updatedatabase.pl | 47 +++
installer/data/mysql/userflags.sql | 2 +-
.../prog/en/includes/catalog-strings.inc | 1 +
.../intranet-tmpl/prog/en/includes/holds_table.inc | 3 +
.../intranet-tmpl/prog/en/includes/permissions.inc | 2 +-
koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 2 +-
.../prog/en/modules/admin/categories.tt | 25 +-
.../prog/en/modules/admin/preferences/patrons.pref | 7 +
.../admin/searchengine/elasticsearch/mappings.tt | 2 +-
.../prog/en/modules/catalogue/detail.tt | 1 -
.../prog/en/modules/catalogue/moredetail.tt | 45 ++-
.../intranet-tmpl/prog/en/modules/intranet-main.tt | 2 +-
.../prog/en/modules/members/holdshistory.tt | 3 +
.../prog/en/modules/reserve/request.tt | 6 +
.../prog/en/modules/tools/batchMod-edit.tt | 22 +-
.../bootstrap/en/includes/opac-bottom.inc | 6 +
.../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 5 +-
.../modules/opac-memberentry-update-submitted.tt | 4 +
.../opac-tmpl/bootstrap/en/modules/opac-results.tt | 2 -
misc/load_testing/benchmark_circulation.pl | 2 +-
misc/load_testing/benchmark_staff.pl | 2 +-
opac/opac-memberentry.pl | 9 +
reserve/placerequest.pl | 4 +
reserve/request.pl | 1 +
t/db_dependent/Accounts.t | 12 +-
t/db_dependent/Acquisition.t | 6 +-
t/db_dependent/ArticleRequests.t | 27 +-
t/db_dependent/Barcodes.t | 28 +-
t/db_dependent/Barcodes_ValueBuilder.t | 28 +-
t/db_dependent/Biblio/ModBiblioMarc.t | 6 +-
t/db_dependent/Budgets.t | 12 +-
t/db_dependent/Circulation.t | 325 ++++++++++-----------
t/db_dependent/Circulation/CalcFine.t | 44 ++-
t/db_dependent/Circulation/MarkIssueReturned.t | 42 +--
.../Circulation/NoIssuesChargeGuarantees.t | 15 +-
t/db_dependent/Circulation/ReturnClaims.t | 26 +-
t/db_dependent/Circulation/Returns.t | 148 +++-------
t/db_dependent/Circulation/StoreLastBorrower.t | 48 ++-
t/db_dependent/Circulation/SwitchOnSiteCheckouts.t | 75 ++---
t/db_dependent/Circulation/dateexpiry.t | 22 +-
t/db_dependent/CourseReserves/CourseItems.t | 25 +-
t/db_dependent/Exporter/Record.t | 47 +--
t/db_dependent/Holds.t | 101 ++++++-
t/db_dependent/Holds/HoldFulfillmentPolicy.t | 2 +-
t/db_dependent/Holds/LocalHoldsPriority.t | 117 +++++++-
t/db_dependent/Holds/WaitingReserves.t | 78 ++---
t/db_dependent/HoldsQueue.t | 214 +++++++++++---
t/db_dependent/ILSDI_Services.t | 156 +++-------
t/db_dependent/ImportBatch.t | 2 +-
t/db_dependent/Items.t | 19 +-
t/db_dependent/Items/GetHostItemsInfo.t | 12 +-
t/db_dependent/Items/GetItemsForInventory.t | 2 +-
t/db_dependent/Items/MoveItemFromBiblio.t | 64 ++--
t/db_dependent/Koha/Account/Line.t | 19 +-
t/db_dependent/Koha/Biblios.t | 14 +-
t/db_dependent/Koha/Checkouts.t | 12 +-
.../Koha/Filter/EmbedItemsAvailability.t | 66 ++---
t/db_dependent/Koha/Item.t | 36 ++-
t/db_dependent/Koha/Item/Transfers.t | 22 +-
t/db_dependent/Koha/Patrons.t | 225 +++++---------
t/db_dependent/Koha/Ratings.t | 4 +-
t/db_dependent/Koha/Reviews.t | 10 +-
.../Koha/SearchEngine/Elasticsearch.t | 70 +----
t/db_dependent/Koha/SharedContent.t | 22 +-
t/db_dependent/Koha/Subscription.t | 23 +-
t/db_dependent/Koha/Suggestions.t | 10 +-
t/db_dependent/Koha/Z3950Responder/Session.t | 34 +--
t/db_dependent/Koha/Z3950Responder/Session2.t | 34 +--
t/db_dependent/Letters/TemplateToolkit.t | 57 ++--
t/db_dependent/Reserves.t | 7 +-
t/db_dependent/Reserves/CancelExpiredReserves.t | 12 +-
t/db_dependent/Reserves/GetReserveFee.t | 75 +++--
t/db_dependent/Reserves/MultiplePerRecord.t | 84 ++----
t/db_dependent/Reserves/ReserveSlip.t | 41 +--
t/db_dependent/SIP/Message.t | 20 +-
t/db_dependent/StockRotationItems.t | 137 +++++++--
t/db_dependent/StockRotationRotas.t | 10 +-
t/db_dependent/StockRotationStages.t | 73 +++--
t/db_dependent/Virtualshelves.t | 71 +++--
t/db_dependent/api/v1/items.t | 6 +-
t/db_dependent/cronjobs/advance_notices_digest.t | 27 +-
t/db_dependent/rollingloans.t | 24 +-
t/db_dependent/selenium/authentication.t | 4 +-
t/db_dependent/selenium/regressions.t | 13 +-
t/db_dependent/www/auth_values_input_www.t | 2 +-
t/db_dependent/www/batch.t | 4 +-
t/db_dependent/www/search_utf8.t | 2 +-
t/lib/TestBuilder.pm | 3 +
tools/batchMod.pl | 53 +++-
121 files changed, 1857 insertions(+), 1763 deletions(-)
rename t/{ => db_dependent}/Koha/SearchEngine/Elasticsearch.t (94%)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list