From gitmaster at git.koha-community.org Sat Feb 1 00:36:51 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Jan 2020 23:36:51 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.02-57-g57d06dbeed Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 57d06dbeeda7fa70c7a1a87dd70eb523808f6a81 (commit) via 1d49b0c839576d7f86a54b6f338edd85a53b11fd (commit) from 48831158430a9ffa624c6f60b2df22cd52c2cb6f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 57d06dbeeda7fa70c7a1a87dd70eb523808f6a81 Author: Jonathan Druart Date: Fri Jan 10 11:10:50 2020 +0100 Bug 24408: Do not compare floats with precision in tests We should not compare floating precision in tests. Test plan: Confirm that the tests still pass after this patch Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 1d49b0c839576d7f86a54b6f338edd85a53b11fd Author: Caroline Cyr La Rose Date: Wed Oct 9 15:34:24 2019 -0400 Bug 23790: fr-CA translation of ACCOUNT_DEBIT and ACCOUNT_CREDIT notices This patch provides the fr-CA translation of the ACCOUNT_DEBIT and ACCOUNT_CREDIT notices. Signed-off-by: Bernardo Gonzalez Kriegel Tested deleting from letter table, then loading the file. File loads without problem, no errors. Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: .../mysql/fr-CA/obligatoire/sample_notices.sql | 28 ++++----- t/Prices.t | 20 +++---- t/db_dependent/Accounts.t | 24 ++++---- t/db_dependent/Circulation.t | 44 +++++++------- t/db_dependent/Circulation/GetHardDueDate.t | 8 +-- .../Circulation/NoIssuesChargeGuarantees.t | 4 +- t/db_dependent/Koha/Account.t | 28 ++++----- t/db_dependent/Koha/ItemTypes.t | 4 +- t/db_dependent/Overdues.t | 68 +++++++++++----------- 9 files changed, 113 insertions(+), 115 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat Feb 1 00:49:43 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Jan 2020 23:49:43 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.02-62-g8d2324b467 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 8d2324b467160e071339c303ac1184899f384dfc (commit) via 1ce12800177a0a32c26d6f5b86d87f7dad366971 (commit) via 4c2f1823685da6797dd8d23ee3c1f24095fa454a (commit) via c086f633adc1e5fcd6a42fcf9e71fc48ef9935ea (commit) via 05c6fec6fe91ba6de12b66d15f58958d76b1e915 (commit) from 57d06dbeeda7fa70c7a1a87dd70eb523808f6a81 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8d2324b467160e071339c303ac1184899f384dfc Author: Marcel de Rooy Date: Thu Jan 16 14:33:39 2020 +0000 Bug 22220: Fix bib Apache rewrite rule for intranet Trivial change. Speaks for itself. Since koha/detail.pl does not exist, we cannot break things ;) Test plan: [1] Copy the change in apache-shared-intranet.conf to your actual apache configuration. Probably in /etc/koha/. [2] Restart Apache. [3] Try a biblionumber say 123 on intranet with [your_staff_client]/bib/123. Does the detail page come up? Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 1ce12800177a0a32c26d6f5b86d87f7dad366971 Author: Nick Clemens Date: Thu Dec 19 13:19:11 2019 +0000 Bug 24275: Apply anti-the to title column in inventory table To test: 1 - Go to Tools->Inventory 2 - Click submit (or add options to get a subset of titles) 3 - Try sorting by title, note that titles with leading articles sort including the articles 4 - Apply patch 5 - Reload the page 6 - Note that leading articles are ignored for sorting Signed-off-by: Deb Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 4c2f1823685da6797dd8d23ee3c1f24095fa454a Author: Jonathan Druart Date: Tue Jan 14 10:34:48 2020 +0100 Bug 20567: Count found holds for holds limit Signed-off-by: Hans Palsson Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit c086f633adc1e5fcd6a42fcf9e71fc48ef9935ea Author: Jonathan Druart Date: Tue Jan 14 10:33:03 2020 +0100 Bug 20567: Add tests Signed-off-by: Hans Palsson Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 05c6fec6fe91ba6de12b66d15f58958d76b1e915 Author: Owen Leonard Date: Thu Jan 9 17:45:47 2020 +0000 Bug 24391: Remove event attributes from patron clubs edit template This patch removes "onclick" attributes from the template for adding and editing patron club templates. To test, apply the patch and go to Tools -> Patron clubs -> New club template. Test the process of adding and deleting both club and enrollment fields. Test during the template add process and when editing an existing template. Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: C4/Reserves.pm | 1 - debian/templates/apache-shared-intranet.conf | 2 +- etc/koha-httpd.conf | 2 +- .../prog/en/modules/clubs/templates-add-modify.tt | 34 +++++++++++++++++++--- .../prog/en/modules/tools/inventory.tt | 3 +- t/db_dependent/Reserves/MultiplePerRecord.t | 7 +++-- 6 files changed, 39 insertions(+), 10 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat Feb 1 01:09:29 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sat, 01 Feb 2020 00:09:29 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.02-67-g31832c35e3 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 31832c35e3bfe71a58dce9359319cba9a6eaa159 (commit) via 5f918d4118e2e617ed32ebdb4732b9d4bbae08b4 (commit) via 53da28d371a260b38a3ebe9fbbf3b38839aeedda (commit) via 0941debbf67eaf95a9550c3a7891be3b34628d27 (commit) via 5ee22b2518374600c0368f3279f43e02d30830f6 (commit) from 8d2324b467160e071339c303ac1184899f384dfc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 31832c35e3bfe71a58dce9359319cba9a6eaa159 Author: Jonathan Druart Date: Wed Dec 18 18:10:15 2019 +0100 Bug 17667: Do not modify quantity of the original standing order when a receipt is cancelled When cancelling a receipt, the quantity of the original order is increased. Test plan: Create a basket, mark is as "standing orders" Create an order receive it cancel the receipt => Without this patch the quantity of the original order is 2 => With this patch applied the quantity it always 1 Signed-off-by: Kelly McElligott Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 5f918d4118e2e617ed32ebdb4732b9d4bbae08b4 Author: Jonathan Druart Date: Wed Dec 18 18:10:07 2019 +0100 Bug 17667: Add tests Signed-off-by: Kelly McElligott Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 53da28d371a260b38a3ebe9fbbf3b38839aeedda Author: Katrin Fischer Date: Sun Jan 12 10:32:17 2020 +0100 Bug 24404: Add missing space on invoices page / remove . from status On the bottom of the invoices page the summary of adjustments and shipping shows as: Adjustments plus shipping:2.00 The patch adds the missing space between text and amount. To test: - 'Receive shipment' from a result in your vendor search - Start a new invoice by entering an invoice number, amount for shipping cost and fund. - Finish receive (you don't need to receive anything) - You should now be on invoice.pl - Verify Status is 'Open.' and in 'Invoice details' we have the amount with the missing space. - Apply patch, reload the page. - Verify the missing space is there and the . is gone. - Close invoice, no . there either. Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 0941debbf67eaf95a9550c3a7891be3b34628d27 Author: Nick Clemens Date: Thu Jan 9 12:48:04 2020 +0000 Bug 24333: Add password class to AutoSelfCheck syspref To test: 1 - Go to Administration 2 - Search sysprefs for AutoSelfCheck 3 - Enter something into AutoSelfCheckPass 4 - Note it is not masked 5 - Apply patch 6 - Reload page 7 - Note password is now masked Signed-off-by: Lucas Gass Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 5ee22b2518374600c0368f3279f43e02d30830f6 Author: Katrin Fischer Date: Tue Jan 14 18:44:01 2020 +0000 Bug 24395: Show initial float using the Price TT plugin on summary page For displaying monetary amounts, we should be using the Price TT plugin everywhere. This adds it to the cash register summary page. To test: - Create a cash register - Check the cash register table for "Initial float" - Verify the amount shows with more than 2 decimals - Edit cash register - verify the same display there - Apply patch - Check again - it should display now with only 2 decimals Signed-off-by: David Nind Signed-off-by: Caroline Cyr La Rose Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: C4/Acquisition.pm | 84 +++++++++++----------- .../intranet-tmpl/prog/en/modules/acqui/invoice.tt | 6 +- .../prog/en/modules/admin/cash_registers.tt | 5 +- .../en/modules/admin/preferences/circulation.pref | 1 + t/db_dependent/Acquisition/StandingOrders.t | 7 +- 5 files changed, 56 insertions(+), 47 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat Feb 1 01:25:18 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sat, 01 Feb 2020 00:25:18 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.02-69-gf01e98801d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via f01e98801daadd71ef9b57e3a0f2411a0bbf6625 (commit) via 1bcff5d39f441c57ffc12fa596976e1a3d099ba1 (commit) from 31832c35e3bfe71a58dce9359319cba9a6eaa159 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f01e98801daadd71ef9b57e3a0f2411a0bbf6625 Author: Jonathan Druart Date: Fri Nov 22 10:16:15 2019 +0100 Bug 24061: Close after timeout if onafterprint no supported Not supported on Chrome < 63 https://www.w3schools.com/tags/ev_onafterprint.asp Signed-off-by: Gabriel DeCarufel Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 1bcff5d39f441c57ffc12fa596976e1a3d099ba1 Author: Jonathan Druart Date: Wed Nov 20 09:19:51 2019 +0100 Bug 24061: Close the window after the page has been printed Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat Feb 1 01:30:58 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sat, 01 Feb 2020 00:30:58 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.02-70-gfa65f81823 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via fa65f818237d4df56deca97bc764b998af7f9bd2 (commit) from f01e98801daadd71ef9b57e3a0f2411a0bbf6625 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit fa65f818237d4df56deca97bc764b998af7f9bd2 Author: Jonathan Druart Date: Wed Dec 11 12:20:54 2019 +0100 Bug 24214: Fix due date formatting when sticky When checking out and sticky due date is selected, on the next screen the due date is displayed iso-formatted, instead of following the dateformat syspref Test plan: 0/ Do not apply the patch 1/ Check an item out, with a selected due date. Tick "Remember for session" 2/ Next screen you see the date like YYYY-MM-DD HH:MM regarless the value of the dateformat syspref 3/ Apply this patch 4/ Reload the page => The date is correctly formatted 5/ Check an item out => Due date is correctly set Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Feb 4 01:12:27 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 04 Feb 2020 00:12:27 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.02-71-gc46c1d1686 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via c46c1d1686346b5087cac2bd0c56d662ca0dab03 (commit) from fa65f818237d4df56deca97bc764b998af7f9bd2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c46c1d1686346b5087cac2bd0c56d662ca0dab03 Author: Joy Nelson Date: Mon Feb 3 23:46:54 2020 +0000 Revert "Bug 24200: Try to fix random failures from Borrower_PrevCheckout.t" This reverts commit 3e93514ac3fbf35691aaad90fa6121d176bdb9b1. Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: t/db_dependent/Patron/Borrower_PrevCheckout.t | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Feb 4 11:34:26 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 04 Feb 2020 10:34:26 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-598-g14fa7c112c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 14fa7c112c9bfd685de7f062c732f8069aebb0ff (commit) via 845c1bae63d595506994dfe0f485d764d12bd48e (commit) via 3e580599f0bc624ce5ed3531feb015144fac7fc2 (commit) via dde8ea09fc187eed1dd23ed4b8bf922d3e8521b0 (commit) via 58e3c8e815956a017325fac2f44fe2eac4b649ce (commit) via 2e9fde1bcd34a23817890178bf31969633fa837a (commit) via 86bc36508f9b4582259f965eff908264db3023ca (commit) via 8fd9ff1730b321dc80ae92a127aced3187b2f43e (commit) via d3d6df99b89b0e888d83391b3e687db59ddbb822 (commit) via b0ccaaf8ef1f59b6c2f9634146bf7170aad39dc9 (commit) via 0401d13d2c2ae8335a95ea3dade63fd719ce8b47 (commit) via 61628c97c245e72c750b61d9df6fa9b9100f3093 (commit) via 0d37a9366127644a06dd909dc91dfed046571937 (commit) via 05cabe7b18a0aef9e7cfd7de432956bad758cae5 (commit) via 1c187a1635f7f24f1f081e054698959edef75257 (commit) via 533fd217dfa941795c146ca8127ab7a7cc2d226e (commit) via 2879fb27f00d8a80e03d2b0c55f4a1fe24de9b0b (commit) via 790ee09c576bc1ee5ca218d327220861620386c1 (commit) via e316de81b6903155fbc5d3f7488f44900d2a78e0 (commit) via 4072c2e3135f5f19722cbd0f6e4d6fb5a8373961 (commit) via 47781d91df6434757a4b39adbd2181cc1b4b28fc (commit) via 25848e5af3ecd77a1a16580aee671c5fb6da7fcb (commit) via e4dfe623d9b4db17beeb4b14ca329e503c99b225 (commit) via 4ec3fe042dd272a7ef251417f1d9a45bd1a9ead8 (commit) via e19c25fbad538716cc8e24e03d0aa0d554826cf4 (commit) via c7536a95692b014bda46409bffb0b20c091cfc6f (commit) via e5daedc4c77b2016520713d52b087d66518c35c7 (commit) via 72442dc8d29120d709710f6c6cba69cd48236766 (commit) via da3f2eff5f7d8b4c725487a3e4d2d906be15d6ef (commit) via 2894ac09c7bc93e61830815ee57ab2d7376b2e8e (commit) via 51e000d6a4ce3ab0691b0e5e3d322d1555548cbe (commit) via 7077bffdd9e8fd340189c9fcb0bae15a57318c95 (commit) via 2c293afea084fca7a95497be0eb48d1c191d5b8d (commit) via c004887e33f760bdb08f72e90aaf8fbe1d8a252a (commit) via f7644cf30725c0a73d0d6f16f22f1aae2ad9cb85 (commit) via a10c961c67961e2d85fcd56c27e8087255e5263c (commit) via f4a9900e4f5a08e1665fdb3cebb7b3e6a592da2f (commit) via 6804451334b32f1ed6797815e59f7f77f1714ee1 (commit) via 1c43a26525730df93a2f0855147e123f5f4476bd (commit) via 5712ec566f46b007d610c0d7cbdc40d43c444d24 (commit) via 14c7a00d4ac56ba9c1a15275963048c2113b5a48 (commit) via f541228579940272ad31974c9122a8bbd982c6d9 (commit) via 18570614c404b662078a81cc0928e4807806bfc6 (commit) via f2dfa17f0e7b3e6e1a035af18a16b0378a1b16f2 (commit) via a957114bd13e3876af2f3f9b5f1ca85aca0d0dfd (commit) via 40d8a72a9d80b1c536acdaf347155a07a2b6f299 (commit) via 58fda20e8541c59d1886c6798063376b1c150c05 (commit) from 65024825c5b1effbbc780a47b8e96f90c8d04250 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 14fa7c112c9bfd685de7f062c732f8069aebb0ff Author: Martin Renvoize Date: Tue Feb 4 10:08:50 2020 +0000 Bug 18936: DBRev 19.12.00.018 Signed-off-by: Martin Renvoize commit 845c1bae63d595506994dfe0f485d764d12bd48e Author: Jonathan Druart Date: Mon Feb 3 16:45:27 2020 +0100 Bug 18936: (QA follow-up) Fix failing test in api/v1/holds.t Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize commit 3e580599f0bc624ce5ed3531feb015144fac7fc2 Author: Joonas Kylmälä Date: Mon Feb 3 15:25:09 2020 +0000 Bug 18936: (QA follow-up) Fix failing test Using categorycode as a scope is not possible for any of these rules so lets remove it. Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize commit dde8ea09fc187eed1dd23ed4b8bf922d3e8521b0 Author: Jonathan Druart Date: Mon Feb 3 12:27:40 2020 +0100 Bug 18936: (QA follow-up) Remove 2 new occurrences of Koha::IssuingRules Fix conflict with bug 13121 Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize commit 58e3c8e815956a017325fac2f44fe2eac4b649ce Author: Joonas Kylmälä Date: Mon Feb 3 10:20:17 2020 +0000 Bug 18936: (QA follow-up) Convert remaining tests to use Koha::CirculationRules These two uses of Koha::IssuingRule were forgotten so this converts them to use the new Koha::CirculationRules object. Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize commit 2e9fde1bcd34a23817890178bf31969633fa837a Author: Jonathan Druart Date: Fri Jan 31 16:45:55 2020 +0100 Bug 18936: (follow-up) More fixes Previous "More fixes" patch added a debugging statement, not needed. Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize commit 86bc36508f9b4582259f965eff908264db3023ca Author: Joonas Kylmälä Date: Fri Jan 31 10:51:36 2020 +0000 Bug 18936: (QA follow-up) Add missing POD Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize commit 8fd9ff1730b321dc80ae92a127aced3187b2f43e Author: Joonas Kylmälä Date: Wed Jan 29 14:06:00 2020 +0000 Bug 18936: (follow-up) Fix checkouts endpoint and its tests - Fixes a bug caused by the refactoring in Koha/REST/V1/Checkouts.pm (run the tests without this patch and you will see the tests fails because 'rule_name' parameter was forgotten). - Changes the tests to use the new Koha::CirculationRule objects instead of directly using issuingrules DB table Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize commit d3d6df99b89b0e888d83391b3e687db59ddbb822 Author: Joonas Kylmälä Date: Wed Jan 29 11:09:17 2020 +0000 Bug 18936: (follow-up) Adjust circ rule related tests so that they pass Bunch of tests broke after moving from issuingrules to circulation_rules. This accomodates the tests for this refactoring and DB change. The itemtype did not exist in the DB. We create it at the beginning of the tests. Ideally we would like to create it filling the form. Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize commit b0ccaaf8ef1f59b6c2f9634146bf7170aad39dc9 Author: Jonathan Druart Date: Tue Jan 28 16:47:39 2020 +0100 Bug 18936: Fix IssuingRules/guess_article_requestable_itemtypes.t Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize commit 0401d13d2c2ae8335a95ea3dade63fd719ce8b47 Author: Joonas Kylmälä Date: Tue Jan 28 15:05:15 2020 +0000 Bug 18936: (follow-up) Make possible to have unlimited value for holds_per_day Without this it is not possible to make for a specific patron category or itemtype a more specific unlimited holds_per_day rule if you have a catch all rule (categorycode = *, itemtype = *) with limited holds_per_day value. Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize commit 61628c97c245e72c750b61d9df6fa9b9100f3093 Author: Joonas Kylmälä Date: Tue Jan 28 13:46:55 2020 +0000 Bug 18936: (follow-up) Add cloning of circulation rules back to Koha The "Clone these rules" feature in admin/smart-rules.pl was dropped. This re-implements the cloning using Koha objects. Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize commit 0d37a9366127644a06dd909dc91dfed046571937 Author: Jonathan Druart Date: Mon Jan 27 10:13:44 2020 +0100 Bug 18936: (QA follow-up) Fix inconsistencies in IssuingRules.t * get_effective_rule should not pass rule_value * indentation fix * add comment to list the rules we have when the test _is_row_match is executed * compare ->rule_name and ->rule_value returns Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize commit 05cabe7b18a0aef9e7cfd7de432956bad758cae5 Author: Joonas Kylmälä Date: Fri Jan 24 16:13:09 2020 +0200 Bug 18936: (follow-up) Add missing import of Koha::CirculationRules Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize commit 1c187a1635f7f24f1f081e054698959edef75257 Author: Joonas Kylmälä Date: Fri Jan 24 12:46:19 2020 +0200 Bug 18936: (follow-up) Fix typo in documentation Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize commit 533fd217dfa941795c146ca8127ab7a7cc2d226e Author: Jonathan Druart Date: Fri Jan 24 14:54:45 2020 +0100 Bug 18936: (follow-up) Add foreign key and scope enhancement to circ rules The previous patch modifies: - categorycode => undef, - itemtype => undef, - branchcode => $branch, + branchcode => undef, But in that condition $branchcode is not '*' and so we should not set it to undef Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize commit 2879fb27f00d8a80e03d2b0c55f4a1fe24de9b0b Author: Jonathan Druart Date: Fri Jan 24 12:19:07 2020 +0100 Bug 18936: (follow-up) Fix the delete rule buttons The itemtype and categorycode were always set to '*' Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize commit 790ee09c576bc1ee5ca218d327220861620386c1 Author: Jonathan Druart Date: Thu Jan 23 16:16:12 2020 +0100 Bug 18936: Replace '*' with undef No test was provided initially so considering out of the scope for this one as well, but that's lacking terribly! Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize commit e316de81b6903155fbc5d3f7488f44900d2a78e0 Author: Jonathan Druart Date: Thu Jan 23 16:01:13 2020 +0100 Bug 18936: Insert default rules during the onboarding tool Those default values have been picked from bug 15522 (Koha::CirculationRules) Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize commit 4072c2e3135f5f19722cbd0f6e4d6fb5a8373961 Author: Jonathan Druart Date: Thu Jan 23 14:45:36 2020 +0100 Bug 18936: (follow-up) Make sure we default to '*' if no rule exist Making sure the code is doing what we expect. Also this patch fix CirculationRules.t Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize commit 47781d91df6434757a4b39adbd2181cc1b4b28fc Author: Joonas Kylmälä Date: Wed Jan 22 19:03:03 2020 +0200 Bug 18936: (follow-up) Add missing circulation rule to fix tests The tests passed before by a chance because the default kohadevbox installation script added a issuing rule that had lengthunit = days. If you use a Koha version before the commits introduced by Bug 18936 you can reproduce the Fees.t tests failing by deleting all the issuing rules from database with > delete issuingrules; and then running $ prove t/db_dependent/Koha/Charges/Fees.t Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize commit 25848e5af3ecd77a1a16580aee671c5fb6da7fcb Author: Jonathan Druart Date: Wed Jan 22 12:27:22 2020 +0100 Bug 18936: Fix some more tests * CanItemBeReserved Prior to "Bug 18936: Convert issuingrules fields to circulation_rules", GetHoldRule returned holds_per_record even if no reservesallowed was defined. This change restores this behavior. FIXME Note: In GetHoldRule we return itemtype only if reservesallowed is set, not sure it is correct. * t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t When setting returnbranch, holdallowed and hold_fulfillment_policy, we should not provide categorycode. * t/db_dependent/Holds.t Prefer to keep the existing rules instead of removing them. It got quite hard to understand what was going on here because of the mixup with the rule reservesallowed that was in issuingrules, and the other rules we used for the tests. Also, categorycode should not be passed to set those 3 rules (holdallowed, hold_fulfillment_policy and returnbranch) * t/db_dependent/Circulation.t Setting lengthunit to 'hours', no need to make sure the rule has been correctly be saved * t/db_dependent/Circulation/CalcDateDue.t It uses hardcoded data that is not in the sample data (categorycode=C). Let use K that exists and postpone a refactore of the whole script (to make it create the data it needs). * t/db_dependent/Circulation/ReturnClaims.t * t/db_dependent/Circulation/IssuingRules/maxsuspensiondays.t Simple replace Koha::IssuingRule with Koha::CirculationRules * t/db_dependent/Koha/Charges/Fees.t => FIXME Still failing, stuck here, need help Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize commit e4dfe623d9b4db17beeb4b14ca329e503c99b225 Author: Joonas Kylmälä Date: Wed Jan 22 10:58:37 2020 +0000 Bug 18936: (follow-up) Don't retrieve unused issuing rule The chargename rule is not used anywhere in the code Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize commit 4ec3fe042dd272a7ef251417f1d9a45bd1a9ead8 Author: Jonathan Druart Date: Wed Jan 22 14:14:41 2020 +0100 Bug 18936: Fix warning about page about wrong lengthunit Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize commit e19c25fbad538716cc8e24e03d0aa0d554826cf4 Author: Jonathan Druart Date: Tue Nov 26 12:00:52 2019 +0100 Bug 18936: fixes from comment #88 - holds per day are not transferred in database update (actually not displayed) - in note column, I can see link "view notes" even if there is no note - No automatic renewal after (hard limit) does not respect dateformat and is shown in iso format Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize commit c7536a95692b014bda46409bffb0b20c091cfc6f Author: Jonathan Druart Date: Sun Aug 4 15:06:00 2019 -0500 Bug 18936: Fix Update DB entry Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize commit e5daedc4c77b2016520713d52b087d66518c35c7 Author: Jonathan Druart Date: Sun Aug 4 14:31:04 2019 -0500 Bug 18936: Add missing filters Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize commit 72442dc8d29120d709710f6c6cba69cd48236766 Author: Jonathan Druart Date: Sun Aug 4 14:09:21 2019 -0500 Bug 18936: More fixes Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize commit da3f2eff5f7d8b4c725487a3e4d2d906be15d6ef Author: Jonathan Druart Date: Wed Mar 6 14:45:03 2019 -0300 Bug 18936: Fix Circulation.t Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize commit 2894ac09c7bc93e61830815ee57ab2d7376b2e8e Author: Jonathan Druart Date: Thu Feb 21 19:06:39 2019 -0300 Bug 18936: Replace an other insert into issuingrules Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize commit 51e000d6a4ce3ab0691b0e5e3d322d1555548cbe Author: Jonathan Druart Date: Thu Feb 21 17:50:29 2019 -0300 Bug 18936: new holds_per_day Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize commit 7077bffdd9e8fd340189c9fcb0bae15a57318c95 Author: Jonathan Druart Date: Thu Feb 21 17:49:21 2019 -0300 Bug 18936: new suspension_chargeperiod Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize commit 2c293afea084fca7a95497be0eb48d1c191d5b8d Author: Jonathan Druart Date: Thu Feb 21 17:46:37 2019 -0300 Bug 18936: chargename removed by bug 21753 Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize commit c004887e33f760bdb08f72e90aaf8fbe1d8a252a Author: Jonathan Druart Date: Fri Dec 7 15:18:20 2018 -0300 Bug 18936: Fix several issues Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize commit f7644cf30725c0a73d0d6f16f22f1aae2ad9cb85 Author: Jonathan Druart Date: Thu Dec 6 16:54:39 2018 -0300 Bug 18936: Fix syntax issue Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize commit a10c961c67961e2d85fcd56c27e8087255e5263c Author: Jonathan Druart Date: Thu Dec 6 16:32:04 2018 -0300 Bug 18936: Remove last bit of Koha::IssuingRule Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize commit f4a9900e4f5a08e1665fdb3cebb7b3e6a592da2f Author: Jonathan Druart Date: Thu Dec 6 16:27:50 2018 -0300 Bug 18936: Move guess_article_requestable_itemtypes method Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize commit 6804451334b32f1ed6797815e59f7f77f1714ee1 Author: Jonathan Druart Date: Thu Dec 6 16:21:06 2018 -0300 Bug 18936: move get_opacitemholds_policy method Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize commit 1c43a26525730df93a2f0855147e123f5f4476bd Author: Jesse Weaver Date: Mon Feb 26 12:17:16 2018 -0700 Bug 18936: (follow-up) Fix tests, replace old get_onshelfholds_policy method Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize commit 5712ec566f46b007d610c0d7cbdc40d43c444d24 Author: Jesse Weaver Date: Mon Jan 29 15:54:40 2018 -0700 Bug 18936: (follow-up) fix tests, null vs. empty behavior for limiting rules Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize commit 14c7a00d4ac56ba9c1a15275963048c2113b5a48 Author: Jesse Weaver Date: Mon Jan 29 13:44:43 2018 -0700 Bug 18936: (follow-up) Remove issuingrules from kohastructure.sql Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize commit f541228579940272ad31974c9122a8bbd982c6d9 Author: Jesse Weaver Date: Tue Oct 17 17:26:31 2017 -0600 Bug 18936: (follow-up) fix rental discount lookup Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize commit 18570614c404b662078a81cc0928e4807806bfc6 Author: Jesse Weaver Date: Fri Oct 6 13:20:01 2017 -0600 Bug 18936: (follow-up) Update REST definition for /.../kinds Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize commit f2dfa17f0e7b3e6e1a035af18a16b0378a1b16f2 Author: Jesse Weaver Date: Thu Sep 14 13:32:26 2017 -0600 Bug 18936: (follow-up) Add foreign key and scope enhancement to circ rules This necessitates moving the circ rules from using '*' to using undef/NULL. Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize commit a957114bd13e3876af2f3f9b5f1ca85aca0d0dfd Author: Tomas Cohen Arazi Date: Mon Jul 17 16:21:56 2017 -0300 Bug 18936: Fix api/v1/holds.t Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize commit 40d8a72a9d80b1c536acdaf347155a07a2b6f299 Author: Tomas Cohen Arazi Date: Mon Jul 17 16:04:51 2017 -0300 Bug 18936: (follow-up) Fix upgrade step Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize commit 58fda20e8541c59d1886c6798063376b1c150c05 Author: Kyle M Hall Date: Thu Jul 13 10:03:54 2017 -0400 Bug 18936: Convert issuingrules fields to circulation_rules Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 367 ++++++----- C4/Overdues.pm | 34 +- C4/Reserves.pm | 75 ++- Koha.pm | 2 +- Koha/Biblio.pm | 14 +- Koha/Charges/Fees.pm | 12 +- Koha/CirculationRule.pm | 15 + Koha/CirculationRules.pm | 337 +++++++++- Koha/IssuingRule.pm | 68 -- Koha/IssuingRules.pm | 202 ------ Koha/Item.pm | 15 +- Koha/ItemType.pm | 4 +- Koha/REST/V1/Checkouts.pm | 6 +- .../V1/CirculationRules.pm} | 32 +- Koha/Schema/Result/Issuingrule.pm | 327 --------- about.pl | 7 +- admin/clone-rules.pl | 51 +- admin/smart-rules.pl | 287 ++++---- api/v1/swagger/definitions.json | 3 + api/v1/swagger/definitions/circ-rule-kind.json | 15 + api/v1/swagger/paths.json | 3 + api/v1/swagger/paths/circulation-rules.json | 35 + installer/data/mysql/kohastructure.sql | 44 -- installer/data/mysql/updatedatabase.pl | 49 ++ installer/onboarding.pl | 67 +- koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 6 +- .../prog/en/modules/admin/smart-rules.tt | 334 +++++----- opac/opac-ISBDdetail.pl | 4 +- opac/opac-MARCdetail.pl | 4 +- opac/opac-detail.pl | 4 +- opac/opac-reserve.pl | 4 +- opac/opac-search.pl | 3 +- opac/opac-shelves.pl | 6 +- opac/opac-tags.pl | 3 +- reserve/request.pl | 4 +- t/db_dependent/ArticleRequests.t | 53 +- t/db_dependent/Circulation.t | 537 +++++++++++---- t/db_dependent/Circulation/Branch.t | 31 +- t/db_dependent/Circulation/CalcDateDue.t | 48 +- t/db_dependent/Circulation/CalcFine.t | 47 +- t/db_dependent/Circulation/GetHardDueDate.t | 317 +++------ .../Circulation/IssuingRules/maxsuspensiondays.t | 55 +- t/db_dependent/Circulation/ReturnClaims.t | 13 +- t/db_dependent/Circulation/Returns.t | 27 +- t/db_dependent/Circulation/SwitchOnSiteCheckouts.t | 26 +- t/db_dependent/Circulation/TooMany.t | 41 +- t/db_dependent/Circulation/issue.t | 33 +- t/db_dependent/DecreaseLoanHighHolds.t | 17 +- t/db_dependent/Fines.t | 35 +- t/db_dependent/Holds.t | 239 ++++--- .../Holds/DisallowHoldIfItemsAvailable.t | 37 +- t/db_dependent/Holds/HoldFulfillmentPolicy.t | 3 - t/db_dependent/Holds/HoldItemtypeLimit.t | 1 - t/db_dependent/HoldsQueue.t | 9 - t/db_dependent/ILSDI_Services.t | 51 +- t/db_dependent/Koha/Biblio.t | 25 +- t/db_dependent/Koha/Charges/Fees.t | 22 +- t/db_dependent/Koha/CirculationRules.t | 16 +- t/db_dependent/Koha/IssuingRules.t | 734 +++++++++++++++------ .../guess_article_requestable_itemtypes.t | 53 +- t/db_dependent/Koha/Item.t | 18 +- t/db_dependent/Koha/Libraries.t | 1 - t/db_dependent/Koha/Objects.t | 9 +- t/db_dependent/RefundLostItemFeeRule.t | 14 + t/db_dependent/Reserves.t | 33 +- t/db_dependent/Reserves/MultiplePerRecord.t | 119 ++-- t/db_dependent/SIP/Transaction.t | 50 +- t/db_dependent/TestBuilder.t | 6 +- t/db_dependent/api/v1/checkouts.t | 18 +- t/db_dependent/api/v1/holds.t | 20 +- t/db_dependent/selenium/administration_tasks.t | 2 +- t/db_dependent/selenium/basic_workflow.t | 13 +- 72 files changed, 2876 insertions(+), 2340 deletions(-) delete mode 100644 Koha/IssuingRule.pm delete mode 100644 Koha/IssuingRules.pm copy Koha/{Acquisition/BasketGroups.pm => REST/V1/CirculationRules.pm} (66%) delete mode 100644 Koha/Schema/Result/Issuingrule.pm create mode 100644 api/v1/swagger/definitions/circ-rule-kind.json create mode 100644 api/v1/swagger/paths/circulation-rules.json hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Feb 4 11:48:10 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 04 Feb 2020 10:48:10 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-612-g87f20fd5fe Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 87f20fd5fe7f4c67963498f42252bf09bf7a317d (commit) via 1bddf5f3bab01ce2151ccefa8982134509e3fac3 (commit) via db148eeff5b6e6fcfa5f7d0f47a3e43d0df5ea4e (commit) via 0f6d55a0a13aa598f9da5543b72aecd40335eb89 (commit) via 35635b98db9a25a8a63af6204bf490ab7b86dca3 (commit) via 6d32f34d515f176738a6784576643580cbac36d2 (commit) via 7c813d044119b055dd20b8ee9f0a68f163ce1c73 (commit) via 4f4405174d9bd1a89433b2598b878ecf9057b2bb (commit) via ffb5fb60ed3e8c5aeb534d60bf81bde80f309484 (commit) via a905fd8a3847ff4f035759aef575d8c6ad77fea2 (commit) via 8829e8d21473486e29b7f4969165d201aa0a3c81 (commit) via a567c990876d8d33a29e0b43c4f45940ddafd8b6 (commit) via c5576eef0c252e8f9813ebc0df1f25e0e92b43b0 (commit) via 17cd229335ec9148a9d5f316e846f4bee01ccb1c (commit) from 14fa7c112c9bfd685de7f062c732f8069aebb0ff (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 87f20fd5fe7f4c67963498f42252bf09bf7a317d Author: Owen Leonard Date: Wed Nov 20 17:00:52 2019 +0000 Bug 9993: On editing basket group delivery place resets to logged in branch This patch modifies basketgroups.pl so that existing data about a basket group's billing and delivery place are correctly preselected in the edit form. These fields shouldn't reset to the logged-in user's home branch just because they have an empty value. To test, apply the patch and go to Acquisitions -> Vendor -> Basket groups. When adding or editing a basket group the pre-selected value for "Billing place" and "Delivery place" should be correct: - When creating a new basket group: The logged-in user's library should be pre-selected. - When editing a basket group which has a library defined for either the billing or delivery places, the correct library should be pre-selected. - When editing a basket group which has no library defined for either the billing or delivery place there should be no library pre-selected (the "--" option should be pre-selected). Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 1bddf5f3bab01ce2151ccefa8982134509e3fac3 Author: Owen Leonard Date: Tue Nov 19 17:02:02 2019 +0000 Bug 10879: OverDrive should check for OverDriveLibraryID before performing search This patch modifies the OPAC search results template to check for three populated system preferences before performing an OverDrive search: OverDriveLibraryID, OverDriveClientKey, and OverDriveClientSecret. Previously OverDriveLibraryID was not checked, but without it the interface reports an error performing the search. To test you must have credentials for the OverDrive API as defined in OverDriveClientKey, OverDriveClientSecret, and OverDriveLibraryID system preferences. - With OverDriveLibraryID defined, the catalog search results page in the OPAC should show a link to results in the library's OverDrive collection. - With no value in the OverDriveLibraryID preference the catalog search page should not show any message about an OverDrive collection. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit db148eeff5b6e6fcfa5f7d0f47a3e43d0df5ea4e Author: Lucas Gass Date: Sat Feb 1 16:42:10 2020 +0000 Bug 24560: Remove No public list text from OPAC On the OPAC, the dropdown for Lists always includes the heading Public Lists, even if no public lists exist. This is sub-optimal for libraries that want VirtualShelves enabled for private lists but don't want to use public lists. TEST PLAN: 1. have no public list and look at the List dropdown on the OPAC. It says No Public Lists. 2. Apply patch 3. It should now not say anything about public lists but still be formatted nice. 4. Add some public lists and confirm that everything looks normal. 5. Sign off Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 0f6d55a0a13aa598f9da5543b72aecd40335eb89 Author: Owen Leonard Date: Tue Dec 10 17:30:41 2019 +0000 Bug 23533: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the interface or functionality. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 35635b98db9a25a8a63af6204bf490ab7b86dca3 Author: Owen Leonard Date: Tue Dec 10 16:34:56 2019 +0000 Bug 23533: Reindent patron entry form (memberentrygen.tt) This patch re-indents the template for patron entry/editing. It makes only whitespace changes. It should have no effect on the behavior of the page. To test, create or edit a patron. Test every aspect of the process. At each step the page should work correctly. Including: - Adult patron - Child patron - Organizational patron - Quick patron add - Duplicate patron - With mandatory fields - With 'BorrowerUnwantedField's defined - With ExtendedPatronAttributes enabled Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 6d32f34d515f176738a6784576643580cbac36d2 Author: David Roberts Date: Mon Jan 27 15:41:32 2020 +0000 Bug 24490: Clarify wording and function of Purchase Items link on POS This patch changes the wording of the links on the POS side menu To test: 1) Apply the patch 2) Check that the links on the left hand side of the screen read "Configure cash registers" and "Configure items for purchase" 3) Click both links to ensure you are taken to the relevant config pages. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 7c813d044119b055dd20b8ee9f0a68f163ce1c73 Author: Jonathan Druart Date: Mon Feb 3 13:36:54 2020 +0100 Bug 24440: Rename current_holds with current_item_level_holds Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 4f4405174d9bd1a89433b2598b878ecf9057b2bb Author: Jonathan Druart Date: Fri Jan 31 15:08:00 2020 +0100 Bug 24440: Adding 2 more tests for ->biblio Not directly related to the other changes but seems good to have them here. Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit ffb5fb60ed3e8c5aeb534d60bf81bde80f309484 Author: Tomas Cohen Arazi Date: Fri Jan 31 00:54:27 2020 -0300 Bug 24440: (follow-up) Make related objects prefetchable This patch creates aliases for the relations used to retrieve the linked objects from other tables. It makes the accessor names match the used relation name, for consistency. This is important for code trying to be smart and guessing what needs to be prefetched, like the API code. To test: 1. Run: $ kshell k$ prove t/db_dependent/Koha/Acquisition/Order.t => SUCCESS: Tests pass 2. Apply this patch 3. Repeat (1) => SUCCESS: Tests pass! No behaviour change 4. Verify the POD changes make sense 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit a905fd8a3847ff4f035759aef575d8c6ad77fea2 Author: Tomas Cohen Arazi Date: Fri Jan 31 00:27:05 2020 -0300 Bug 24440: ->biblio tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 8829e8d21473486e29b7f4969165d201aa0a3c81 Author: Tomas Cohen Arazi Date: Thu Jan 16 15:58:25 2020 -0300 Bug 24440: Add ->current_holds to Koha::Acquisition::Order This patch introduces a method to fetch the current holds associated with the items linked to an order line. It basically implements what's done in parcel.pl, but fully tested and suitable for using on the API. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Acquisition/Order.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit a567c990876d8d33a29e0b43c4f45940ddafd8b6 Author: Tomas Cohen Arazi Date: Thu Jan 16 15:58:15 2020 -0300 Bug 24440: Unit tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit c5576eef0c252e8f9813ebc0df1f25e0e92b43b0 Author: Jonathan Druart Date: Mon Dec 23 14:06:06 2019 +0100 Bug 24171: Check auto_renew if confirmation is needed Test plan: Add some fines Check auto_renew and check an item out, using a title keyword Pick one item You get the confirmation box => Notice that the auto_renew checkbox is checked Signed-off-by: Katrin Fischer Signed-off-by: Bouzid Fergani Signed-off-by: Martin Renvoize commit 17cd229335ec9148a9d5f316e846f4bee01ccb1c Author: Jonathan Druart Date: Tue Dec 17 12:10:28 2019 +0100 Bug 24171: Preserve auto_renew when triggering itemBarcodeFallbackSearch The auto_renew parameter is not sent to the template when the popup triggered by itemBarcodeFallbackSearch is displayed. Test plan: - Turn on itemBarcodeFallbackSearch - Open a patron account - Check the checkboxes for automatic-renewal - Search for a title keyword in the checkout input box - Verify that auto-renewal flag is set Note for QA: The auto_renew flag will be set in any cases. Should we expect regression? Signed-off-by: Katrin Fischer Signed-off-by: Bouzid Fergani Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: Koha/Acquisition/Order.pm | 64 +- Koha/Schema/Result/Aqorder.pm | 57 + acqui/basketgroup.pl | 8 +- circ/circulation.pl | 3 +- .../intranet-tmpl/prog/en/includes/pos-menu.inc | 4 +- .../prog/en/modules/circ/circulation.tt | 13 +- .../prog/en/modules/members/memberentrygen.tt | 2524 +++++++++++--------- .../opac-tmpl/bootstrap/en/includes/masthead.inc | 6 +- .../opac-tmpl/bootstrap/en/modules/opac-results.tt | 2 +- t/db_dependent/Koha/Acquisition/Order.t | 93 +- 10 files changed, 1573 insertions(+), 1201 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Feb 4 15:04:33 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 04 Feb 2020 14:04:33 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-624-gc0f3170c44 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via c0f3170c44897a200cbf00d3e6026df6f152949c (commit) via 88315db11aeb9e567353e755616e169031eaef90 (commit) via 07968fc5f68d7bf7c3ae1674489cebab6bea3817 (commit) via fc7d7eece8c64a20305c6efc935128ce55b31f3a (commit) via 9b5ff17d79a61156426433bdd2e3c248e63d7431 (commit) via ca511ad957e090832dec4c4370180fd92bd331ae (commit) via 9ddb78f0d36910139a6dea4b0375a760f77d65c4 (commit) via eae2dfce063e0b39046f3fffaa460441d2d79060 (commit) via 6ac19e02ed1349f93303a3f24b655f38bf70fa5d (commit) via 127a92d8ab7dfe21fb216ba4dd6fa6be4ff77acf (commit) via 5638a2f731e7d23df696fbb657d8ffdd46de8f49 (commit) via 14d1804652daf9c0b83139c3373f4cdaf46b5863 (commit) from 87f20fd5fe7f4c67963498f42252bf09bf7a317d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c0f3170c44897a200cbf00d3e6026df6f152949c Author: Jonathan Druart Date: Tue Feb 4 12:09:00 2020 +0100 Bug 19008: Replace issues with checkouts in print statement Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 88315db11aeb9e567353e755616e169031eaef90 Author: Magnus Enger Date: Fri Aug 2 13:57:13 2019 +0200 Bug 19008: More database cleanups - QA followup This patch tries to change the POD as suggested in the QA process. Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 07968fc5f68d7bf7c3ae1674489cebab6bea3817 Author: Fridolin Somers Date: Fri Jul 28 16:09:14 2017 +0200 Bug 19008: More database cleanups - item transfers misc/cronjobs/cleanup_database.pl provides some database cleanup. Yet some tables that could need cleanup are not in this script. This patch adds cleanup for branchtransfers table. Test plan : - Count : select count(*),datearrived from branchtransfers group by datearrived; - Run cleanup : misc/cronjobs/cleanup_database.pl -v --transfers 30 - Recount Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit fc7d7eece8c64a20305c6efc935128ce55b31f3a Author: Fridolin Somers Date: Fri Jul 28 16:01:51 2017 +0200 Bug 19008: More database cleanups - old reserves misc/cronjobs/cleanup_database.pl provides some database cleanup. Yet some tables that could need cleanup are not in this script. This patch adds cleanup for old_reserves table. Test plan : - Count : select count(*),date(timestamp) from old_reserves group by date(timestamp); - Run cleanup : misc/cronjobs/cleanup_database.pl -v --old-reserves 30 - Recount Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 9b5ff17d79a61156426433bdd2e3c248e63d7431 Author: Fridolin Somers Date: Fri Jul 28 14:57:33 2017 +0200 Bug 19008: More database cleanups - old issues misc/cronjobs/cleanup_database.pl provides some database cleanup. Yet some tables that could need cleanup are not in this script. This patch adds cleanup for old_issues table. Test plan : - Count : select count(*),date(timestamp) from old_issues group by date(timestamp); - Run cleanup : misc/cronjobs/cleanup_database.pl -v --old-issues 30 - Recount Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit ca511ad957e090832dec4c4370180fd92bd331ae Author: Fridolin Somers Date: Fri Jul 28 14:43:45 2017 +0200 Bug 19008: More database cleanups - deleted patrons misc/cronjobs/cleanup_database.pl provides some database cleanup. Yet some tables that could need cleanup are not in this script. This patch adds cleanup for deletedborrowers table. Test plan : - Count : select count(*),date(updated_on) from deletedborrowers group by date(updated_on); - Run cleanup : misc/cronjobs/cleanup_database.pl -v --deleted-patrons 30 - Recount Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 9ddb78f0d36910139a6dea4b0375a760f77d65c4 Author: Fridolin Somers Date: Fri Jul 28 14:05:03 2017 +0200 Bug 19008: More database cleanups - deleted catalog misc/cronjobs/cleanup_database.pl provides some database cleanup. Yet some tables that could need cleanup are not in this script. This patch adds cleanup for deleted catalog tables. Note that deletedbiblio_metadata is managed by foreign key on biblionumber. Test plan : - Count : select count(*),year(timestamp) from deleteditems group by year(timestamp); select count(*),year(timestamp) from deletedbiblio group by year(timestamp); select count(*),year(timestamp) from deletedbiblioitems group by year(timestamp); - Run cleanup : misc/cronjobs/cleanup_database.pl -v --deleted-catalog 30 - Recount Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit eae2dfce063e0b39046f3fffaa460441d2d79060 Author: Fridolin Somers Date: Fri Jul 28 14:12:22 2017 +0200 Bug 19008: More database cleanups - statistics misc/cronjobs/cleanup_database.pl provides some database cleanup. Yet some tables that could need cleanup are not in this script. This patch adds cleanup for statistics table. Test plan : - Count statistics : select count(*),date(datetime) from statistics group by date(datetime); - Run cleanup : misc/cronjobs/cleanup_database.pl -v --statistics 30 - Recount statistics Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 6ac19e02ed1349f93303a3f24b655f38bf70fa5d Author: Jonathan Druart Date: Tue Feb 4 11:17:11 2020 +0100 Bug 20708: Add Withdrawn status when placing a request in staff Same as bug 22021 for the withdrawn status. 1. Withdraw an item 2. Place an hold on this item Notice the new "withdrawn" status in the information column Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 127a92d8ab7dfe21fb216ba4dd6fa6be4ff77acf Author: Nick Clemens Date: Tue Feb 4 12:36:18 2020 +0000 Bug 24569: (QA follow-up) Fix closing tag Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 5638a2f731e7d23df696fbb657d8ffdd46de8f49 Author: Jonathan Druart Date: Tue Feb 4 10:44:39 2020 +0100 Bug 24569: Fix "add to basket" link (bug 23031 regression) The modal needs to be defined in both cases. Test plan: Repeat test plan from bug 23031 and click on the buttons! Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 14d1804652daf9c0b83139c3373f4cdaf46b5863 Author: Jonathan Druart Date: Wed Jan 29 12:44:57 2020 +0100 Bug 21466: Keep all AVs for a given framework There was a major (and silly) issue in the previous version, only one AV was kept as we erased the hash value at the end of each iteration: $invalid_locations_per_framework->{$framework->frameworkcode } = { items => $items, av_category => $mss->authorised_value, kohafield => $kohafield }; Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/acqui/booksellers.tt | 30 +++--- .../prog/en/modules/reserve/request.tt | 4 + misc/cronjobs/cleanup_database.pl | 114 ++++++++++++++++++++- .../maintenance/search_for_data_inconsistencies.pl | 59 ++++++----- 4 files changed, 167 insertions(+), 40 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Feb 4 16:30:53 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 04 Feb 2020 15:30:53 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-626-g86a0a7d80b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 86a0a7d80b71908582dfc40c981734c5828112fc (commit) via 7a03815138b861a5894816e3c100e3a6daaaffb0 (commit) from c0f3170c44897a200cbf00d3e6026df6f152949c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 86a0a7d80b71908582dfc40c981734c5828112fc Author: Jonathan Druart Date: Tue Feb 4 16:00:21 2020 +0100 Bug 18936: Fix selenium/administration_tasks.t Signed-off-by: Martin Renvoize commit 7a03815138b861a5894816e3c100e3a6daaaffb0 Author: Jonathan Druart Date: Tue Feb 4 15:59:01 2020 +0100 Bug 18936: Display 'Unlimited' for Holds allowed (total) holds_per_day and reservesallowed are set to unlimited in the rules inserted by misc4dev Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt | 8 +++++++- t/db_dependent/selenium/administration_tasks.t | 2 +- 2 files changed, 8 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Feb 4 16:34:31 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 04 Feb 2020 15:34:31 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-627-gc54163940d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via c54163940d9fa1fb173ae236a1e093cc50cadba8 (commit) from 86a0a7d80b71908582dfc40c981734c5828112fc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c54163940d9fa1fb173ae236a1e093cc50cadba8 Author: Jonathan Druart Date: Tue Feb 4 16:05:49 2020 +0100 Bug 23533: Remove spaces after/before the open/close parenthesis t/db_dependent/selenium/patrons_search.t is failing because of this change: # got: 'Koha › Patrons › Modify patron fir's"tname \123 ❤ test_patron_1 ( iOVAoJj )' # expected: 'Koha › Patrons › Modify patron fir's"tname \123 ❤ test_patron_1 (iOVAoJj)' We are adding space after and before the open/close parenthesis of the category code. Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/members/memberentrygen.tt | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 5 14:04:20 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 05 Feb 2020 13:04:20 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-635-g585001c6d3 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 585001c6d3f18b4420f785778aab0889df43357b (commit) via 1069bc240525f72d1e06bb9b78ef55fbec6dad2e (commit) via d88dfbf34e68849e0deed5543817decf6dfb19cb (commit) via 9eaa4d9775fa64549ec9657f333914d671129acf (commit) via 445a97d8d27cb381ba6594bbe3848d35f741958d (commit) via 8854a14fe7299bc9230a856d19f213dcb2308956 (commit) via 724bd2e0550d8a61f7b5e0505b544cab52d655d9 (commit) via 1e2617342a156e58c3b59d6534842984c2f01df4 (commit) from c54163940d9fa1fb173ae236a1e093cc50cadba8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 585001c6d3f18b4420f785778aab0889df43357b Author: Martin Renvoize Date: Wed Jan 29 13:24:34 2020 +0000 Bug 24529: Silence another uninitialised value warning Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 1069bc240525f72d1e06bb9b78ef55fbec6dad2e Author: Martin Renvoize Date: Wed Jan 29 13:18:20 2020 +0000 Bug 24529: Silence warnings for title level holds This patch simply adds a test for itemnumber being defined in the reserve before comparing it to silence the warning. Test plan: 1) Prior to patch, run prove t/db_dependant/Circulation.t and note lots of `Use of uninitialized value in numeric eq (==) at /kohadevbox/koha/C4/Reserves.pm line 790` warnings. 2) Apply the patch, re-run the test and note the tests still pass but the warnings are now gone. Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit d88dfbf34e68849e0deed5543817decf6dfb19cb Author: Jonathan Druart Date: Wed Feb 5 10:36:14 2020 +0100 Bug 24590: Fix Koha/Object.t on MySQL 8 % prove t/db_dependent/Koha/Object.t is failing on MySQL 8 with: kohadev-koha at 9bbf9ac68519:/kohadevbox/koha$ prove t/db_dependent/Koha/Object.t t/db_dependent/Koha/Object.t .. 15/18 # Failed test 'Exception field is correct' # at t/db_dependent/Koha/Object.t line 650. # got: 'api_keys.secret' # expected: 'secret' # Looks like you failed 1 test of 16. t/db_dependent/Koha/Object.t .. 16/18 # Failed test 'store() tests' # at t/db_dependent/Koha/Object.t line 723. MySQL 8 displays the tablename in the error. Signed-off-by: Martin Renvoize commit 9eaa4d9775fa64549ec9657f333914d671129acf Author: Lucas Gass Date: Tue Jan 14 15:40:38 2020 +0000 Bug 24420: Display waiting on hold items in the Cataloging search results Location column To Test: 1. Place a hold on an item and trigger it. 2 Do a cataloging search that would include this record. 3. Notice that the 'Location' column does not account for this onhold item. 4. Apply patch and look at catalog results again. 5. You should see information display about the item being on hold. Signed-off-by: Barbara Johnson Signed-off-by: Bouzid Fergani Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 445a97d8d27cb381ba6594bbe3848d35f741958d Author: Nick Date: Fri Oct 18 18:26:38 2019 +0000 Bug 23844: Check if field defined in framework and specify 'Default' for framework To test: 1 - Go to Cataloguing 2 - New from Z3950 3 - Find an import a record 4 - Check the plack logs: Use of uninitialized value in string ne at /kohadevbox/koha/cataloguing/addbiblio.pl line 565. Use of uninitialized value in string ne at /kohadevbox/koha/cataloguing/addbiblio.pl line 580. Use of uninitialized value $frameworkcode in string eq at /kohadevbox/koha/cataloguing/addbiblio.pl line 711. Use of uninitialized value $frameworkcode in string eq at /kohadevbox/koha/cataloguing/addbiblio.pl line 715. Use of uninitialized value $frameworkcode in string eq at /kohadevbox/koha/cataloguing/addbiblio.pl line 734. 5 - Apply patch 6 - Repeat 7 - No new errors 8 - Confirm selecting 'Default' from 'New from Z3950' dropdown also generates no errors Signed-off-by: Myka Kennedy Stephens Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 8854a14fe7299bc9230a856d19f213dcb2308956 Author: Nick Clemens Date: Tue Feb 4 14:16:26 2020 +0000 Bug 22302: Make ITEMTYPECAT descriptions fallback to lib description if no opac description Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 724bd2e0550d8a61f7b5e0505b544cab52d655d9 Author: Nick Clemens Date: Tue Feb 4 14:15:36 2020 +0000 Bug 22302: Unit tests Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 1e2617342a156e58c3b59d6534842984c2f01df4 Author: Nick Clemens Date: Tue Jan 28 13:57:32 2020 +0000 Bug 24485: Allow hold when some can be overridden The check to see if we can place a hold counts the number that we can override vs the number of items on the record. We cannot override if we already have a hold on an item, however, we don't count these to see if they plus the number of overrides equal the items on the record. To test: 1 - Set max reserves to 2, allow 2 holds per recrod 2 - Place 2 holds for a patron on some records 3 - Find another record with 2 items 4 - Place a hold on the first item, you will be notified about the limit but you can override 5 - Attempt to place hold on second item, cannot be done, button disabled 6 - Apply patch 7 - Repeat 8 - You can place the second hold Signed-off-by: Kelly McElligott Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Koha.pm | 4 ++-- C4/Reserves.pm | 4 +++- cataloguing/addbiblio.pl | 2 +- .../intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt | 5 +++-- reserve/request.pl | 8 ++++++-- t/db_dependent/Koha.t | 12 +++++++++--- t/db_dependent/Koha/Object.t | 6 +++--- 7 files changed, 27 insertions(+), 14 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 5 15:53:44 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 05 Feb 2020 14:53:44 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-643-gea8363559b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via ea8363559b10def137f1f365888d99551d2605de (commit) via 21594689e54abdf9b07669a0b1b35f204eb2bd1e (commit) via 043a36e46a9dbf0c94bd01da1c02241c67d6360d (commit) via 5958836a570f396c16b4bd43072bcd16a2101cb4 (commit) via 5ac7f3690d274e93cd38ee441c480d4d9c597a52 (commit) via 76c0a06728ec73504983f4e1e52b6add0a37a0e1 (commit) via eedb6ce233443c5c2af4d4352c5374f293b88ac3 (commit) via 4668a31dc5a43dc32e8535dac03fd8d8f4bb9010 (commit) from 585001c6d3f18b4420f785778aab0889df43357b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ea8363559b10def137f1f365888d99551d2605de Author: Katrin Fischer Date: Sat Nov 2 06:39:28 2019 +0000 Bug 23784: Show subtitle, number and part in course reserve list of records At the moment only the title will display in the course reserves details, but not the information from other title fields. For series with multiple volumes that can lead to confusing display. The patch makes use of the new include to display 245$abnp. To test: - Add mulitple records to a course reserce course Make sure you have some with different combinations of 245$b$n$p - Look at the course details in the OPAC - Verify only $a displays - Apply patch - Reload - Verify now the full information displays Depending on your installation, you might want ot check that the 245 are correctly mapped and save the record once so the database fields are correctly filled. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 21594689e54abdf9b07669a0b1b35f204eb2bd1e Author: Martin Renvoize Date: Wed Feb 5 14:26:47 2020 +0000 Bug 23673: DBRev 19.12.00.019 Signed-off-by: Martin Renvoize commit 043a36e46a9dbf0c94bd01da1c02241c67d6360d Author: Jonathan Druart Date: Wed Feb 5 09:47:47 2020 +0100 Bug 23673: Set updated_on=time_queued on DB update Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 5958836a570f396c16b4bd43072bcd16a2101cb4 Author: Jonathan Druart Date: Wed Feb 5 09:44:58 2020 +0100 Bug 23673: Avoid sleep in tests Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 5ac7f3690d274e93cd38ee441c480d4d9c597a52 Author: Agustin Moyano Date: Mon Oct 21 19:18:55 2019 -0300 Bug 23673: Add "Updated on" column to patron's notices This patch adds "Updated on" column to patron's notices tab. It also adds logic to C4::Letters to retrieve updated_on column. To test: 1. Apply patches. 2. Restart plack. 3. Choose a patron and add a purchase suggestion. 4. Change suggestion status. 5. Open patron's notifications. CHECK => Messages table has now "Updated on" and "Time created" columns, and "Time" column is gone. SUCCESS => There is a message with status pending, with a "time created" that equals "updated on" 6. Execute in the shell in Koha directory $ ./misc/cronjobs/process_message_queue.pl 7. Open patron's notifications one more time. SUCCESS => The message changed status. Time created remained the same, and now "updated on" has the current timestamp. 8. Resend the message and repeat sep 6. SUCCESS => Every time you change the status, time created remains the same and updated on updates. 9. Run `prove t/db_dependant/Letters.t` 10. Sign off Signed-off-by: Kelly McElligott Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 76c0a06728ec73504983f4e1e52b6add0a37a0e1 Author: Agustin Moyano Date: Mon Oct 21 17:29:44 2019 -0300 Bug 23673: Change DB Structure Signed-off-by: Kelly McElligott Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit eedb6ce233443c5c2af4d4352c5374f293b88ac3 Author: Jonathan Druart Date: Wed Feb 5 14:29:44 2020 +0100 Bug 24595: Silent warnings from Circulation.t Signed-off-by: Martin Renvoize commit 4668a31dc5a43dc32e8535dac03fd8d8f4bb9010 Author: Nick Clemens Date: Fri Jan 17 14:29:42 2020 +0000 Bug 24449: Add too_many_overdue to patron status for SIP To test: 1 - Have sip running and use the cli to get info for a patron example: perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su koha -sp koha -l CPL -m patron_status_request --patron koha 2 - Checkout an item to the patron, backdated so it is overdue 3 - Set syspref 'OverduesBlockCirc' to anything but "Don't Block" 4 - Get the patron status via SIP, note circ blocked flag is set, but too_many_overdue is not 5 - Apply patch 6 - Restart all the things 7 - Get the patron status via SIP 8 - Note the too_many_overdue flag is now triggered and there is a message example: READ: 24Y Y 00120200117 142716AEEdna Acosta|AA23529001000463|BLY|CQN|BV0.25|AFGreetings from Koha. -- Patron has overdues -- Patron owes 0.25|AOCPL| Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 15 ++++++++++++--- C4/Letters.pm | 6 +++--- C4/Overdues.pm | 4 ++-- C4/SIP/ILS/Patron.pm | 4 ++++ Koha.pm | 2 +- Koha/Schema/Result/MessageQueue.pm | 16 ++++++++++++++-- installer/data/mysql/kohastructure.sql | 3 ++- installer/data/mysql/updatedatabase.pl | 14 ++++++++++++++ .../intranet-tmpl/prog/en/modules/members/notices.tt | 6 ++++-- .../bootstrap/en/modules/opac-course-details.tt | 2 +- t/db_dependent/Letters.t | 9 ++++++++- 11 files changed, 65 insertions(+), 16 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 5 22:07:20 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 05 Feb 2020 21:07:20 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.07-11-g8ecc071915 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 8ecc071915c4117a712d6b03cd34f6d20f9a0cb8 (commit) via e13770ad11b4b504413ef020770cd15e8ee55bbc (commit) via 3d73723a9ff618d2d7b5685ce2ac969b27899d31 (commit) from 0bf37bf67a8b04e5f88917a089974b1f2003a7e5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8ecc071915c4117a712d6b03cd34f6d20f9a0cb8 Author: Joonas Kylmälä Date: Tue Dec 17 13:59:55 2019 +0000 Bug 24016: (QA follow-up) Format code to adhere to perltidy format Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 3bfbf2589788474f0d37acc5d6df2d1fc7cc0005) Signed-off-by: Lucas Gass commit e13770ad11b4b504413ef020770cd15e8ee55bbc Author: Lari Taskula Date: Tue Nov 12 12:18:27 2019 +0000 Bug 24016: manager_id in Koha::Patron::Message->store should not depend on userenv alone Koha::Patron::Message->store has this my $userenv = C4::Context->userenv; $self->manager_id( $userenv ? $userenv->{number} : undef); This breaks in REST API when userenv is not set. Let API user pass manager_id without relying on C4::Context->userenv. To test: 1. prove t/db_dependent/Koha/Patron/Messages.t 2. Observe success Sponsored-by: Koha-Suomi Oy Signed-off-by: Maryse Simard Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 49eac22b1f977b439e5d3f8f313dee3164719b60) Signed-off-by: Lucas Gass commit 3d73723a9ff618d2d7b5685ce2ac969b27899d31 Author: Lari Taskula Date: Tue Nov 12 12:24:30 2019 +0000 Bug 24016: Add a failing test for overwrite-able manager_id in Koha::Patron::Message To test: 1. prove t/db_dependent/Koha/Patron/Messages.t 2. Observe failure t/db_dependent/Koha/Patron/Messages.t .. 2/12 Failed test 'Manager id should be overwrite-able even if defined in userenv' at t/db_dependent/Koha/Patron/Messages.t line 90. got: '1100' expected: '1101' Looks like you failed 1 test of 12. t/db_dependent/Koha/Patron/Messages.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/12 subtests Sponsored-by: Koha-Suomi Oy Signed-off-by: Maryse Simard Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit c74820c2273393825c73b90769424544579a1aae) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: Koha/Patron/Message.pm | 6 ++++-- t/db_dependent/Koha/Patron/Messages.t | 26 +++++++++++++++++++------- 2 files changed, 23 insertions(+), 9 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 5 22:22:25 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 05 Feb 2020 21:22:25 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.07-15-gf633d841b2 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via f633d841b249daeedda066fdb96c904fe56f718a (commit) via a1d3ee5fc43412b8d5300066181fc7cb20444b3c (commit) via a258da5ef40dad7c6605de402c863a3b93cfa9b5 (commit) via e1a020da7499da67ad2f3af7cb7c80430396ae9e (commit) from 8ecc071915c4117a712d6b03cd34f6d20f9a0cb8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f633d841b249daeedda066fdb96c904fe56f718a Author: Lucas Gass Date: Wed Feb 5 20:54:14 2020 +0000 Bug 24329: DBRev 19.05.07.002 commit a1d3ee5fc43412b8d5300066181fc7cb20444b3c Author: Jonathan Druart Date: Sun Jan 5 23:08:28 2020 +0100 Bug 24329: Add a test Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 127f11b56dce3b37cf211df524d591ca0dd24dc5) commit a258da5ef40dad7c6605de402c863a3b93cfa9b5 Author: Martin Renvoize Date: Thu Jan 2 13:03:07 2020 +0000 Bug 24329: Prevent update of timestamp on action_logs updates Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit cff5d117316e0b30e27280b7860ff7cdddb73c3f) commit e1a020da7499da67ad2f3af7cb7c80430396ae9e Author: Martin Renvoize Date: Thu Jan 2 12:56:19 2020 +0000 Bug 24329: Correction to updatedatabase Ensure timestamp is not overwriteen during upgrade when applying updates for bug 3820 Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 4ac096c1a5607cc0d3b5bfacfff69e5010fdaba6) ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/kohastructure.sql | 2 +- installer/data/mysql/updatedatabase.pl | 14 +++++++++++--- t/db_dependent/Koha/ActionLogs.t | 9 ++++++++- 4 files changed, 21 insertions(+), 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 5 22:44:10 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 05 Feb 2020 21:44:10 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.07-17-ga273c604db Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via a273c604db5ebad8aef2b1076a0a5870783ba06e (commit) via b57a0462ecf12c1353d8650febf6feab89e4ff60 (commit) from f633d841b249daeedda066fdb96c904fe56f718a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a273c604db5ebad8aef2b1076a0a5870783ba06e Author: Jonathan Druart Date: Mon Dec 23 16:19:47 2019 +0100 Bug 24277: Fix date received editing when receiving an order Bug 8417 added the ability to edit the date received, but a merge conflict was wrongly resolved during a rebase of commit 20d9ed618fbe3cdcb9c04444a1f8a584b0364069 Bug 13321: Rename variables Test plan: Create an order Receive it Set a date (different from today) => The date you picked should have been set in DB for the order Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 028a77abce1aa0c9dc9f1bab8fc3069df811c2a1) Signed-off-by: Lucas Gass commit b57a0462ecf12c1353d8650febf6feab89e4ff60 Author: Tomas Cohen Arazi Date: Wed Jan 8 10:55:40 2020 -0300 Bug 24277: Regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 76f7c46613687b712fa2342049557f2a769db8bf) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/Acquisition.pm | 12 ++++++++++-- acqui/finishreceive.pl | 1 + t/db_dependent/Acquisition.t | 25 +++++++++++++++++++++++-- 3 files changed, 34 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 5 23:01:36 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 05 Feb 2020 22:01:36 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.07-19-g8bcafbe3cf Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 8bcafbe3cfa15974b34c8bb8dc9d10f72205283e (commit) via 3e5eb8aacf39cab5bac519f9b173ba5a6c34abf3 (commit) from a273c604db5ebad8aef2b1076a0a5870783ba06e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8bcafbe3cfa15974b34c8bb8dc9d10f72205283e Author: Jonathan Druart Date: Fri Dec 27 14:55:36 2019 +0100 Bug 24313: Always display XSLT errors in logs From commit 295ae33800a322facfdf56795f4c02b2fd53432b Bug 20272: Replace error numbers by codes in XSLT_Handler """ Make XSLT_Handler a little bit less noisy by defaulting print_warns to false unless $ENV{DEBUG} is set. (See also bug 19018). """ I think we should warn the errors in the logs. They are not debug messages here, we should not rely on DEBUG. If too noisy we should fix the original issues, not hide all the errors (which make the XSLT debugging super hard) Test plan: Break a XSLT, reload the page and confirm that there are useful errors in the Koha log file Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit ec79582374c829049ebac891644fb9f6e30a9614) Signed-off-by: Lucas Gass commit 3e5eb8aacf39cab5bac519f9b173ba5a6c34abf3 Author: Jonathan Druart Date: Tue Dec 10 15:24:36 2019 +0100 Bug 24123: Fix import of UTF-8 encoded MARC21 MARCXML using bulkmarcimport (elastic only) If elastic is used as search engine, the bulkmarcimport.pl will not handle correctly UTF-8 encoded MARCXML Koha::SearchEngine::Search->new uses a require statement to load the correct Search module. This is done l.257 of bulkmarcimport.pl: 257 my $searcher = Koha::SearchEngine::Search->new Koha::SearchEngine::Elasticsearch::Search will `use MARC::File::XML`, and so resets the arguments set before: 216 $MARC::File::XML::_load_args{BinaryEncoding} = 'utf-8'; 220 $MARC::File::XML::_load_args{RecordFormat} = $recordformat; An easy (but dirty) fix could be to move the declaration of my $searcher before in the script. The tricky (but correct) fix would be to remove the long standing "ugly hack follows" comment. This patch is the easy, and dirty, fix Test plan: Use the command line tool to import MARXCML records that contains unicode characters into Koha Something like `misc/migration_tools/bulkmarcimport.pl -biblios -file record.marcxml -m=MARCXML` Without this patch you will notice that unicode characters will not be displayed correctly Signed-off-by: Michal Denar Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit b11946bc377ec2c6474f9dc2192fda8188c86888) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: Koha/XSLT_Handler.pm | 4 +--- misc/migration_tools/bulkmarcimport.pl | 21 +++++++++++---------- 2 files changed, 12 insertions(+), 13 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 5 23:16:18 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 05 Feb 2020 22:16:18 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.07-23-ged9f1fcfad Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via ed9f1fcfad127df6816394e24361030a3a7325c6 (commit) via e0b5464e9ab406bd5c83bd82a4039f18bf2fb913 (commit) via 34024213e08540970f7bdc8bbf37ed0fe5c16fd6 (commit) via 91122f420524b64fcbf7e112e6692963cc4f1f05 (commit) from 8bcafbe3cfa15974b34c8bb8dc9d10f72205283e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ed9f1fcfad127df6816394e24361030a3a7325c6 Author: Nick Clemens Date: Fri Dec 13 17:08:58 2019 +0000 Bug 10352: Get add operations too When an add for biblio or item is recorded there is no space in the info field Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 428fc6fcc1dc029bed3d85acac1570e964c66c9a) Signed-off-by: Lucas Gass commit e0b5464e9ab406bd5c83bd82a4039f18bf2fb913 Author: Nick Clemens Date: Mon Nov 25 12:09:45 2019 +0000 Bug 10352: (follow-up) Show the biblionumber for items in modification logs This patch adds a link to the the biblio that shows the biblionumber of the item. It makes things a little more obvious To test: 1 - Find a biblio with an item where an itemnumber on another biblio is equal to that biblionumber i.e. In the sample data: biblionumber 59 with item with itemnumber 127 item with itemnumber 59 on biblionumber 23 2 - Edit both items however you wish 3 - On biblionumber 59 click the modification log 4 - You should see "Item 127" 5 - Click "Submit" on the form - this searches as itemnumber 6 - You should see "Item 59" 7 - Apply patch 8 - On biblionumber 59 click the modification log 9 - You should see "Item 127 from Biblio 59" 10 - Click "Submit" on the form - this searches as itemnumber 11 - You should see "Item 59 from Biblio 23" Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit ec9e2cbd1e54880d1671e3ce2f9b6e30d4aefbfe) Signed-off-by: Lucas Gass commit 34024213e08540970f7bdc8bbf37ed0fe5c16fd6 Author: Jonathan Druart Date: Mon Nov 25 11:28:40 2019 +0100 Bug 10352: Use a new object_type parameter instead of the module's name To dissociate a search on biblio and item, we pass a new "object_type" parameter to viewlog.pl. If equals 'biblio' we will assume that "object" contains a biblionumber Signed-off-by: Nick Clemens Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 346ff47491d3fe0e8768c7fa334e0d8fe4a55e1f) Signed-off-by: Lucas Gass commit 91122f420524b64fcbf7e112e6692963cc4f1f05 Author: Jonathan Druart Date: Mon May 13 10:36:14 2019 -0500 Bug 10352: Display the correct modification logs for bibliographic records The 'Modification log" link in the cataloguing module returns confusing results. The 'object' parameter is the biblionumber, but the all log from itemnumber=biblionumber will be displayed as well. Since bug 11473 we have the action_logs.info column that is prefixed by 'item ' or 'biblio ' to disociated an item modification from a biblio modif. This patch suggests a quick and dirty approach, use this column to make sure we are searching for the correct logs. /!\ As bug 11473 did not update the existing rows, we will no longer display the logs created prior to this change. Test plan: Make sure you have at least 2 bibliographic records with some items Make sure you have the biblionumbers of those records that match existing itemnumbers Edit them (no matter what you change) Go to the bibliographic detail page (staff) and click "Modification log" You should see the correct changes. Signed-off-by: hc Signed-off-by: Nick Clemens Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 536053d468d87a94544eb013cb7d4d9effae9445) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/includes/biblio-view-menu.inc | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt | 3 ++- tools/viewlog.pl | 16 ++++++++++++++-- 3 files changed, 17 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 5 23:24:30 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 05 Feb 2020 22:24:30 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.07-25-g7ad9807353 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 7ad9807353e43b4295364424c8da1106b370d41f (commit) via 708fd8b4b12a954f80fc4630edef4d6fa1ef5c5e (commit) from ed9f1fcfad127df6816394e24361030a3a7325c6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7ad9807353e43b4295364424c8da1106b370d41f Author: Jonathan Druart Date: Thu Jan 9 16:17:12 2020 +0100 Bug 14759: Add test Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit ad92c140587657a2cb2fb2fbd4c7ebce8dd15eb3) Signed-off-by: Lucas Gass commit 708fd8b4b12a954f80fc4630edef4d6fa1ef5c5e Author: Martin Renvoize Date: Wed Jan 8 09:13:18 2020 +0000 Bug 14759: Replace Text::Unaccent with Unicode::Normalize As shown in the comments on the bug, it appears that Unicode::Normalize is the most reliable way to strip accents from strings for this use case. Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 27de0d61792d46e4fbf8bd8dba2d1d6f0a48c091) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/Installer/PerlDependencies.pm | 5 ----- Koha/Patron.pm | 6 +++--- t/db_dependent/Koha/Patrons.t | 5 +++-- 3 files changed, 6 insertions(+), 10 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 5 23:29:34 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 05 Feb 2020 22:29:34 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.07-27-g14803de78d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 14803de78d5b3c5b7325e9f3f721a0b17ebfbfa0 (commit) via 9f1961d58c5d9785122414fdf014bcf07c06c876 (commit) from 7ad9807353e43b4295364424c8da1106b370d41f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 14803de78d5b3c5b7325e9f3f721a0b17ebfbfa0 Author: Jonathan Druart Date: Fri Jan 10 09:56:12 2020 +0100 Bug 24371: Fix "Show all items" avaibility link (use $raw filter) - intra Same fix for the intranet side Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit ff78c70ccb540dfe5d2b2a263f3701bd8aa52cc3) Signed-off-by: Lucas Gass commit 9f1961d58c5d9785122414fdf014bcf07c06c876 Author: Lucas Gass Date: Tue Jan 7 18:54:49 2020 +0000 Bug 24371: Fix "Show all items" avaibility link (use $raw filter) - opac TO TEST: 1. Make an OPAC search with plenty of results. 2. Use the search facets to limit the search in some way, item type, author, etc. 3. Click on 'Limit to currently available items', everything is still fine. 4. Attempt to return to 'Show all items', there will be no search results. 5. Apply patch 6. Ateempt steps 1-4 again. 7. Should work this time. Signed-off-by: Rhonda Kuiper Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 756a95098d858d63cc0971c950f02278bbe242fe) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 5 23:34:17 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 05 Feb 2020 22:34:17 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.07-28-gdf8a536bbc Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via df8a536bbc40348699552e336d5bf7dc3e7a7203 (commit) from 14803de78d5b3c5b7325e9f3f721a0b17ebfbfa0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit df8a536bbc40348699552e336d5bf7dc3e7a7203 Author: Cori Lynn Arnold Date: Tue Dec 31 17:10:14 2019 +0000 Bug 24323: Advanced editor - Display an error message if the record did not save Invalid 008 with helper silently fails to save. This patch adds a "else if" to fall through if the error message isn't one of the previously defined ones ("syntax" and "invalid") and presents the human with a generic message that "Something went wrong, cannot save." Prior to testing: a/Verify that Advanced Editor is enabled b/Download the errorrecord.mrc from bug To test: 1/Apply patch 2/Go to Cataloging->Advanced Editor 3/Click "Import Record" button and navigate to the record saved from step b/ 4/Add an 003 field (as required by the default cataloging config) 5/Hit "Save to catalog" 6/Verify that a message is passed to the user that the file was unable to be saved Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit ae4c86e87e26a06611519510c386723e3a904371) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc | 2 ++ 1 file changed, 2 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 5 23:39:04 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 05 Feb 2020 22:39:04 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.07-29-g936a69aba7 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 936a69aba75061b3323daa657cbc21c3d27b5403 (commit) from df8a536bbc40348699552e336d5bf7dc3e7a7203 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 936a69aba75061b3323daa657cbc21c3d27b5403 Author: Nick Clemens Date: Tue Nov 26 12:57:17 2019 +0000 Bug 23274: Mock simple_search_compat to cover both search engines Signed-off-by: Michal Denar Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 4c715fa0dbb0a92454b1e3012af8884ad4e12300) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: t/db_dependent/XISBN.t | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Feb 6 14:03:24 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 06 Feb 2020 13:03:24 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-648-gd5e993ed47 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via d5e993ed47400206519bfe74df79e9254f1175fe (commit) via bc94d7e659b1f2cba90633cdb9f725e02db049f3 (commit) via cd99a034401ad2207569efbbeb77aadd635d6c7e (commit) via 0ecf7694eac802f29ea4786502b7bffaaad3a6bf (commit) via 82f7f7f7d3f7c46d9f0c2c703683f5fddd4672ca (commit) from ea8363559b10def137f1f365888d99551d2605de (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d5e993ed47400206519bfe74df79e9254f1175fe Author: Tomas Cohen Arazi Date: Fri Jan 31 09:06:51 2020 -0300 Bug 24554: Only embed relations from Koha::Biblio in to_api This patch simplifies the behaviour of Koha::Biblio->to_api. It was designed with the idea of handling possible methods that would be added to Koha::Biblioitem. But it had a weird fallback behaviour was highlighted by using it with bug 24528. On fixing it it become obvious that it was unnessessarily complex and that it was not worth. That's the reason there wasn't any test for it, as Koha::Biblioitem doesn't implement any extra methods. To test: 1. Run: $ kshell k$ prove t/db_dependent/Koha/Biblio.t => SUCCESS: Tests pass 2. Apply this patch 3. Repeat (1) => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit bc94d7e659b1f2cba90633cdb9f725e02db049f3 Author: Jonathan Druart Date: Mon Jan 13 14:30:35 2020 +0100 Bug 24410: Fix multi holds Bug 19618 replaces the call to placerequest.pl with a REST API /holds That is wrong as it does not support multi holds. Test plan: Confirm that prior to this patch you are not able to place a hold on several records at once, and that this patch fixes it Signed-off-by: Julian Maurice Signed-off-by: Agustin Moyano Signed-off-by: Martin Renvoize commit cd99a034401ad2207569efbbeb77aadd635d6c7e Author: Josef Moravec Date: Wed Feb 5 21:13:22 2020 +0000 Bug 13420: (QA follow-up): Fix typo itemdate -> itemdata Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize commit 0ecf7694eac802f29ea4786502b7bffaaad3a6bf Author: Jonathan Druart Date: Tue Aug 6 08:56:44 2019 -0500 Bug 13420: Fallback to the previous behavior if published date is not used Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize commit 82f7f7f7d3f7c46d9f0c2c703683f5fddd4672ca Author: Jonathan Druart Date: Sun Apr 28 22:53:55 2019 -0400 Bug 13420: Sort "Serial enumeration" by published date So far the sorting on volume information is incorrect. It sorts by the string displayed in the cell, which may not have any logics. A better solution would be to use Kyle's suggestion, see comments 7, 8, but it will need much more work. This patch suggests to use the publication date to sort this column. Note: In the code there is a switch depending on the existence of items.publisheddate, but I do not think it is valid, this valid should always exist if the item is received (did I miss something?) Test plan: You need to have different existing subscription, using different numbering. On the detail page of the bibliographic record you should be able to sort the serials (tab "Holdings") by "Serial enumeration". The sort will now use the publication dates. Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: Koha/Biblio.pm | 10 +--------- catalogue/detail.pl | 3 ++- koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 10 +++++++++- koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 4 ++-- 4 files changed, 14 insertions(+), 13 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Feb 6 16:12:36 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 06 Feb 2020 15:12:36 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.07-31-g8a98bcb05a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 8a98bcb05ade420cb8ca1b7b13b8ff1eb6c3168b (commit) via 528ac9395045044e6204b130e01d9b00e0c6268a (commit) from 936a69aba75061b3323daa657cbc21c3d27b5403 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8a98bcb05ade420cb8ca1b7b13b8ff1eb6c3168b Author: Marcel de Rooy Date: Fri Jan 10 10:49:45 2020 +0000 Bug 23377: (QA follow-up) Use OVERRIDE_SYSPREF SYSPREF_OVERRIDE unfortunately is not supported ;) Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit a8659229be16dc8d8b2beaae370528afd373192e) Signed-off-by: Lucas Gass commit 528ac9395045044e6204b130e01d9b00e0c6268a Author: Ian Walls Date: Wed Jul 31 16:32:23 2019 +0000 Bug 23377: use ENV syspref override instead of complete disable In an attempt to save time, bulkmarcimport temporarily sets CataloguingLog and AuthoritiesLog to 0. It does this by disabling syspref caching and saving the changes to the database (then replacing the original values at completion). Unfortunately, this disables other key sysprefs from being cached, and results in a 50% increase in processing time for the script. This patch instead utilizes the ENV variable override feature of sysprefs, which preempts the cache in C4::Context->preference(). To test: 1. Perform a bulkmarcimport with a reasonable number of biblios (~1000 will do) 2. Note the time taken to complete 3. Apply patch 4. Revert the biblio load performed 5. Perform another bulkmarcimport with the same biblios and commandline options 6. Note the time taken to complete 7. Compare times. The time from step 6 should be about 33% less than the time from step 2 8. Check Cataloguing and Authorities Logs to verify imported records were not logged 9. Profit! Signed-off-by: Michal Denar Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 91befb973d9b646b15c78ba535348fa2cf139639) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: misc/migration_tools/bulkmarcimport.pl | 18 +++++------------- 1 file changed, 5 insertions(+), 13 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Feb 6 16:18:33 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 06 Feb 2020 15:18:33 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.07-35-g17ba977f50 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 17ba977f50d1f711a5b21d25d9387928afb91825 (commit) via 8ba681af362b0450bb75ec728b65ba504b4cdb31 (commit) via 8d37736de97f25f6832093eb475e5b7793591c41 (commit) via 8c488e8aceb798f65b34db35afaf4084331d0ac1 (commit) from 8a98bcb05ade420cb8ca1b7b13b8ff1eb6c3168b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 17ba977f50d1f711a5b21d25d9387928afb91825 Author: Martin Renvoize Date: Mon Jan 13 09:22:20 2020 +0000 Bug 15142: (RM follow-up) Fix tests We removed the su-ut facet from zebra config for UNIMARC as it makes no sense for that case, but we neglected to remove it form the test that checks the config response. Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 76f5ec182122d256b585a3369616f6243178f51f) Signed-off-by: Lucas Gass commit 8ba681af362b0450bb75ec728b65ba504b4cdb31 Author: Katrin Fischer Date: Tue Dec 31 10:30:32 2019 +0100 Bug 15142: (follow-up) Remove facet configuration from .xsl file Removes last remaining bit of configuration for the Titles facet configuration. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 398281e0e486f6473353f36c0c1f2beb00706ae4) Signed-off-by: Lucas Gass commit 8d37736de97f25f6832093eb475e5b7793591c41 Author: Fridolin Somers Date: Tue Nov 26 09:44:08 2019 +0100 Bug 15142: (follow-up) remove from Zebra UNIMARC config files Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit dcc238f05b916b0225e937730f51d780ea18b29e) Signed-off-by: Lucas Gass commit 8c488e8aceb798f65b34db35afaf4084331d0ac1 Author: Fridolin Somers Date: Fri Nov 22 15:16:51 2019 +0100 Bug 15142: Remove titles facet for UNIMARC There is a facet using 500$a, 501$a and 503$a and Subject index. In UNIMARC 500$a, 501$a and 503$a are not indexed as Subject. I propose to remove this facet for UNIMARC, looks like it does not make sens. Test plan: 1) Install UNIMARC database 2) Edit some records to have 500$a 3) Perform a search to find those records 4) Check you dont see the titles facet Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 0c50804f4b2d82329e0bfb591b2add048594691a) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/Koha.pm | 6 ------ .../unimarc/biblios/biblio-koha-indexdefs.xml | 9 --------- .../unimarc/biblios/biblio-zebra-indexdefs.xsl | 21 --------------------- t/db_dependent/Search.t | 3 +-- 4 files changed, 1 insertion(+), 38 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Feb 6 17:01:48 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 06 Feb 2020 16:01:48 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.07-36-g94b2d5405c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 94b2d5405c40c31a4c1d60136a1a64ba10529ea8 (commit) from 17ba977f50d1f711a5b21d25d9387928afb91825 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 94b2d5405c40c31a4c1d60136a1a64ba10529ea8 Author: Joonas Kylmälä Date: Fri Aug 31 15:32:20 2018 +0300 Bug 17885: Koha::SearchEngine::Elasticsearch->reset_elasticsearch_mappings throws DBD::mysql Duplicate entry exceptions When executing Koha::SearchEngine::Elasticsearch->reset_elasticsearch_mappings() against populated search engine mappings tables, one gets this exception: DBD::mysql::st execute failed: Duplicate entry '388-73' for key 'PRIMARY' [for Statement \"INSERT INTO `search_marc_to_field` ( `facet`, `search_field_id`, `search_marc_map_id`, `sort`, `suggestible`) VALUES ( ?, ?, ?, ?, ? )\" with ParamValues: 0='', 1='73', 2='388', 3=undef, 4=''] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1834.\nDBIx::Class::Storage::DBI::_dbh_execute(): Duplicate entry '388-73' for key 'PRIMARY' at /home/koha/Koha/Koha/SearchField.pm line 38" This patch fixes this, by first deleting all entries, then adding the default ones. If a subroutine says reset_elasticsearch_mappings(), I expect it to reset the elasticsearch mappings without errors. When writing tests it is better to call that one subroutine reset_elasticsearch_mappings instead of the bunch of code in admin/searchengine/elasticsearch/mappings.pl?op=reset_confirmed Also this promotes code reuse. TEST PLAN: a. perl -e 'use Koha::SearchEngine::Elasticsearch; Koha::SearchEngine::Elasticsearch->reset_elasticsearch_mappings' b. Run misc/devel/populate_db.pl on an already populated DB and you eventually face this problem. After this patch, step a. works. This patch is adapted from the original patch made by Olli-Antti Kivilahti . Signed-off-by: Johanna Raisa Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 0c68b3a171c07025a0bb9e48245444a44b30d196) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: Koha/SearchEngine/Elasticsearch.pm | 3 +++ admin/searchengine/elasticsearch/mappings.pl | 2 -- 2 files changed, 3 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Feb 6 18:26:06 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 06 Feb 2020 17:26:06 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.07-38-g830a6cda7c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 830a6cda7cf74b38f2abd01faf4e17a4ae6e2556 (commit) via 96a0f83a63dc8a2c8150523aaad88e86d2837853 (commit) from 94b2d5405c40c31a4c1d60136a1a64ba10529ea8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 830a6cda7cf74b38f2abd01faf4e17a4ae6e2556 Author: Nick Clemens Date: Tue Jan 14 16:13:25 2020 +0000 Bug 24421: Check if subfields are valid using the biblio tag To test: 1 - Enable the sysprefs AutoCreateAuthorities BiblioAddsAuthorities CatalogModuleRelink 2 - Open a record with a subject heading with a subdivision and add a new subfield, or add a new unauthroized heading to a record and save it e.g. 650$aChess$xOpenings$vFiction. 3 - Save the record, note the created authority and that field is linked 4 - Save the record again and note the authority number changes 5 - Find and view the authority linked to the record 6 - The record is for 'Chess', not Chess openings' 7 - Search authorities for 'Chess' - note duplicated records 8 - Apply patch, restart all 9 - Save the record, auth number increases again, we shoudl create the correct record this time 10 - Save again, auth number should not change 11 - Search authorities and confirm the generated authority has the correct subfields Signed-off-by: Myka Kennedy Stephens Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 05146daafcb267b312794e572e465692e2107c07) Signed-off-by: Lucas Gass commit 96a0f83a63dc8a2c8150523aaad88e86d2837853 Author: Nick Clemens Date: Fri Jan 24 13:24:45 2020 +0000 Bug 24421: Unit tests Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 92135220a508a2abafede587517cef355e98735e) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/Biblio.pm | 2 +- t/db_dependent/Biblio.t | 39 ++++++++++++++++++++++++++++++++++++++- 2 files changed, 39 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Feb 6 18:38:27 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 06 Feb 2020 17:38:27 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.07-40-g9d22cd6a7e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 9d22cd6a7e9324399d37af0e931743c25b5b00cc (commit) via 9117d40faa59c92dc135a87201e6569dc6e4cbc1 (commit) from 830a6cda7cf74b38f2abd01faf4e17a4ae6e2556 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9d22cd6a7e9324399d37af0e931743c25b5b00cc Author: Fridolin Somers Date: Mon Jun 17 16:09:38 2019 +0200 Bug 22426: Map 'loc' to 'location' when building ES queries A search made on Shelving location tab in advanced search gives 0 result. Test plan : Without patch: - in advanced search, choose a location in shelving location tab and start search (opac-search.pl?idx=kw&op=and&idx=kw&op=and&idx=kw&do=Search&limit=mc-loc) - 0 result - check that location exist by doing a simple search and filtering on the location facet - have some results With patch: - in advanced search, choose a location in shelving location tab and start search (opac-search.pl?idx=kw&op=and&idx=kw&op=and&idx=kw&do=Search&limit=mc-loc) - found results Signed-off-by: Séverine QUEUNE Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 439c73a2ed167f031741a2946bd04ade39d9d581) Signed-off-by: Lucas Gass commit 9117d40faa59c92dc135a87201e6569dc6e4cbc1 Author: Martin Renvoize Date: Mon Jan 13 09:27:35 2020 +0000 Bug 23676: (RM follow-up) Test Correction We altered the query form passed by the ElasticSearch Query Builder but neglected to update the test. Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 4fe82250938072156b2d03027e3d03252e79f679) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: Koha/SearchEngine/Elasticsearch/QueryBuilder.pm | 1 + t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Feb 6 18:46:13 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 06 Feb 2020 17:46:13 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.07-41-g33d60b305e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 33d60b305e94afdd6f2584707f4b10516f513810 (commit) from 9d22cd6a7e9324399d37af0e931743c25b5b00cc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 33d60b305e94afdd6f2584707f4b10516f513810 Author: Nick Clemens Date: Wed Jan 15 15:27:56 2020 +0000 Bug 24423: Add biblionumber to modify items link To test: - Find/create a bib with at least one item - From detail.pl, use the checkboxes in the holdings table to select one or more items - click the "Modify Selected Items" link just above the holdings table to take your item(s) to batch modification - Change something and click save - Observe that the Return to the Record link points to a url without a biblionumber: "/cgi-bin/koha/catalogue/detail.pl?biblionumber=" - Apply patch - Repeat - The link now works! Signed-off-by: Nick Clemens Signed-off-by: David Nind Bug 24423: Fix for deletion - cleanup accidental debug inclusiopm To test: Repeat prior test plan with 'Delete selected' Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit a1479015edfe2ba14c67090dea2c682ef5c3f48f) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 2 ++ tools/batchMod.pl | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Feb 6 18:51:21 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 06 Feb 2020 17:51:21 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.07-42-ga4b63af5dc Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via a4b63af5dc4f1662ed46c6743029d1d33dfbbac0 (commit) from 33d60b305e94afdd6f2584707f4b10516f513810 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a4b63af5dc4f1662ed46c6743029d1d33dfbbac0 Author: David Roberts Date: Thu Jan 23 12:18:17 2020 +0000 Bug 24484: Add explanatory text to batch patron deletion This patch adds a more detailed explanation about what the tool can do. To test: 1) Open up the Batch patron deletion and anonymisation tool 2) Check the help text near the top of the screen 3) Install the patch and repeat steps 1 and 2 4) Check the help text has changed to the new version Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 8b98dfa41d6004e6d6204c682b23043cb314e623) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/tools/cleanborrowers.tt | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Feb 6 19:55:05 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 06 Feb 2020 18:55:05 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.07-43-gd3101975c6 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via d3101975c6ed779dada28a83af66d3aeef12e8b1 (commit) from a4b63af5dc4f1662ed46c6743029d1d33dfbbac0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d3101975c6ed779dada28a83af66d3aeef12e8b1 Author: Lucas Gass Date: Thu Feb 6 18:27:00 2020 +0000 Revert "Bug 23676: (RM follow-up) Test Correction" This reverts commit 9117d40faa59c92dc135a87201e6569dc6e4cbc1. Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Feb 6 21:26:32 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 06 Feb 2020 20:26:32 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.07-45-g4bb7ecc793 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 4bb7ecc7939f7d9f5f951f6302a779b57e0af729 (commit) via 180b20a6b8594b9039f6787400fbc38964f67cff (commit) from d3101975c6ed779dada28a83af66d3aeef12e8b1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4bb7ecc7939f7d9f5f951f6302a779b57e0af729 Author: Nick Clemens Date: Thu Jan 16 13:09:50 2020 +0000 Bug 24377: Unit test Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit cf331e0b3480fdf35947d887843f8bee6cd894e5) Signed-off-by: Lucas Gass commit 180b20a6b8594b9039f6787400fbc38964f67cff Author: Nick Clemens Date: Thu Jan 16 13:09:58 2020 +0000 Bug 24377: Record passed branch if renewing via cron To test: 1 - Checkout an item with auto renewal set and eligible for auto renew 2 - Set no renewal before in the circ rules to 99 (something greater than the checkout period) 3 - perl misc/cronjobs/automatic_renewals.pl 4 - Check the statistics table, note the branch for renewal is null SELECT * FROM statistics WHERE itemnumber={itemnumber} AND type='RENEWAL' 5 - Apply patch 6 - Repeat 1-4 7 - Note the branch is set to the issuing branch Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Ed Veal Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 723c72397f02c168ffe4f7615022ed0d9be7de49) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 7 +++---- t/db_dependent/Circulation.t | 23 +++++++++++++++++------ 2 files changed, 20 insertions(+), 10 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Feb 6 21:36:14 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 06 Feb 2020 20:36:14 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.07-47-gb6baccee51 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via b6baccee51f14b22cc6f2bfb152d811c591207b2 (commit) via 4e750a3a4f371274f0b55671f86c396d53238dfd (commit) from 4bb7ecc7939f7d9f5f951f6302a779b57e0af729 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b6baccee51f14b22cc6f2bfb152d811c591207b2 Author: Jonathan Druart Date: Tue Jan 14 12:39:38 2020 +0100 Bug 23443: Do not checkin an item if checked out to another patron when lost fee is paid Test plan: 0 - Do not apply this patch 1 - Check out an item to a patron 2 - Make sure a fee will be charged when lost 3 - Mark the item lost 4 - Make sure the fee will not be refunded on return of the item 5 - Return the item 6 - Check it out to a new patron 7 - Write off the fine for the original patron => The item is now checked in 8 - Apply this patch and repeat 1 to 7 => The item is still checked out Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit e901fb7842aeddd5ac68f5e8004ad3d186789bab) Signed-off-by: Lucas Gass commit 4e750a3a4f371274f0b55671f86c396d53238dfd Author: Jonathan Druart Date: Tue Jan 14 12:39:36 2020 +0100 Bug 23443: Add tests Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 5a27b1b2a981f9307656ef595f2479828b765465) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 3 +++ t/db_dependent/Koha/Account.t | 45 ++++++++++++++++++++++++++++++++++++++++++- 2 files changed, 47 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Feb 6 21:51:28 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 06 Feb 2020 20:51:28 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.02-72-gd52983cf3d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via d52983cf3d448d18b0b0086968a506522e3cc816 (commit) from c46c1d1686346b5087cac2bd0c56d662ca0dab03 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d52983cf3d448d18b0b0086968a506522e3cc816 Author: Nick Clemens Date: Tue Jan 28 13:57:32 2020 +0000 Bug 24485: Allow hold when some can be overridden The check to see if we can place a hold counts the number that we can override vs the number of items on the record. We cannot override if we already have a hold on an item, however, we don't count these to see if they plus the number of overrides equal the items on the record. To test: 1 - Set max reserves to 2, allow 2 holds per recrod 2 - Place 2 holds for a patron on some records 3 - Find another record with 2 items 4 - Place a hold on the first item, you will be notified about the limit but you can override 5 - Attempt to place hold on second item, cannot be done, button disabled 6 - Apply patch 7 - Repeat 8 - You can place the second hold Signed-off-by: Kelly McElligott Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: reserve/request.pl | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Feb 6 22:41:36 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 06 Feb 2020 21:41:36 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.07-49-g6465c6f968 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 6465c6f9680c138430b31cc71024d545b9f412ca (commit) via 5aed3545f3871cfe0ba94ec6efbe3cb216b7e0a2 (commit) from b6baccee51f14b22cc6f2bfb152d811c591207b2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6465c6f9680c138430b31cc71024d545b9f412ca Author: Tomas Cohen Arazi Date: Thu May 2 15:51:30 2019 -0300 Bug 22834: Add Koha::Plugins::Base->bundle_path This patch adds a 'bundle_path' method that return the base path for assets included in the plugin. The idea is that it will be used for calculation of the absolute path in the filesystem for static content. To test: - Apply the unit tests patch - Run: $ kshell k$ prove t/db_dependent/Plugins.t => FAIL: The method is not implemented - Apply this patch - Run: k$ prove t/db_dependent/Plugins.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Arthur Suzuki Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize (cherry picked from commit 0cca2795cdae643a6a94b95ad7879c363006cfed) Signed-off-by: Lucas Gass commit 5aed3545f3871cfe0ba94ec6efbe3cb216b7e0a2 Author: Tomas Cohen Arazi Date: Thu May 2 15:51:17 2019 -0300 Bug 22834: Add tests for Koha::Plugins::Base->bundle_path Signed-off-by: Arthur Suzuki Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize (cherry picked from commit 4adb1791c66a3577d32f10c417e4953a86f5769f) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: Koha/Plugins/Base.pm | 16 ++++++++++++++++ t/db_dependent/Plugins.t | 22 +++++++++++++++++++++- 2 files changed, 37 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Feb 6 22:46:02 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 06 Feb 2020 21:46:02 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.07-52-ga3cd7581db Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via a3cd7581dbc82f3fd09db9e9eb76ec8e73d10bd6 (commit) via 8e7a9c407d1bb4c6ddb905c4e7f48ca887f638b8 (commit) via 5edcba2f6eab8f08d11d5548b8df3d6617e16a2c (commit) from 6465c6f9680c138430b31cc71024d545b9f412ca (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a3cd7581dbc82f3fd09db9e9eb76ec8e73d10bd6 Author: Agustin Moyano Date: Thu May 16 00:09:38 2019 -0300 Bug 22835: (follow-up) Remove comented code Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize (cherry picked from commit 60ba3e8c639bf4ade1b3d837250468b979da4728) Signed-off-by: Lucas Gass commit 8e7a9c407d1bb4c6ddb905c4e7f48ca887f638b8 Author: Agustin Moyano Date: Fri May 3 00:15:12 2019 -0300 Bug 22835: (follow-up) Remove unwanted warn Signed-off-by: Arthur Suzuki Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize (cherry picked from commit c3cc7c06b39f1a47238dc50175de07668e5c2668) Signed-off-by: Lucas Gass commit 5edcba2f6eab8f08d11d5548b8df3d6617e16a2c Author: Agustin Moyano Date: Thu Apr 25 02:13:37 2019 -0300 Bug 22835: Serve plugin static files through API This patch serves static files declared within plugins. To declare static files the plugin must implement the method 'static_routes' which retrieves the spec of static file routes to add to the API. Once those routes are added to the API, the become available through the /api/v1/contrib//static//// endpoint. To test: 1) Install bug-22835-plugin.kpz 2) Point your browser to /api/v1/contrib/kitchensink/static/static_files/mm.gif CHECK => No file is served 3) Apply this patch 4) restart_all 5) Repeat step 2. SUCCESS => File is served! 6) Sign off Sponsored-by: Theke Solutions Signed-off-by: Arthur Suzuki Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize (cherry picked from commit 688967e6eaab4c1f5670cbef254cb4a7101c4e18) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: Koha/REST/Plugin/PluginRoutes.pm | 42 +++++++++++++------- Koha/REST/V1/Static.pm | 84 ++++++++++++++++++++++++++++++++++++++++ 2 files changed, 113 insertions(+), 13 deletions(-) create mode 100644 Koha/REST/V1/Static.pm hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Feb 6 23:00:02 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 06 Feb 2020 22:00:02 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.02-75-g122945827d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 122945827d6d958e533b913e10f47c13e3c34f65 (commit) via d5f127b215fbfd7205896fb4b5c98b7bbbabed5a (commit) via c7dbe4ca28a6548dccd90500d698fc733638074c (commit) from d52983cf3d448d18b0b0086968a506522e3cc816 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 122945827d6d958e533b913e10f47c13e3c34f65 Author: Joy Nelson Date: Thu Feb 6 21:33:28 2020 +0000 Bug 24338: DBREV 19.11.02.002 Signed-off-by: Joy Nelson commit d5f127b215fbfd7205896fb4b5c98b7bbbabed5a Author: Martin Renvoize Date: Tue Feb 4 13:19:18 2020 +0000 Bug 24338: (QA follow-up) Make update idempotent Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Joy Nelson commit c7dbe4ca28a6548dccd90500d698fc733638074c Author: Martin Renvoize Date: Mon Jan 27 11:06:26 2020 +0000 Bug 24338: Add 'CASH' to default 'PAYMENT_TYPE' AV Bug 23321 adds cash registers to the koha accounts system and as part of that work introduces the 'CASH' payment type as a required option to allow requirment of a 'CASH_REGISTER' when making cash payments. The original patchset, however, forgot to add this new authorised value during installation and upgrade. Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/en/mandatory/auth_values.sql | 1 + installer/data/mysql/updatedatabase.pl | 16 ++++++++++++++++ 3 files changed, 18 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Feb 6 23:34:58 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 06 Feb 2020 22:34:58 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.07-53-g7c25b08e90 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 7c25b08e90f67c4ec51df691344954de11911966 (commit) from a3cd7581dbc82f3fd09db9e9eb76ec8e73d10bd6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7c25b08e90f67c4ec51df691344954de11911966 Author: Lucas Gass Date: Thu Feb 6 22:08:55 2020 +0000 Bug 23443: (follow-up) Fix bad test Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: t/db_dependent/Koha/Account.t | 1 - 1 file changed, 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Feb 7 00:19:28 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 06 Feb 2020 23:19:28 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.02-78-g203d8a194d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 203d8a194d8879db905121c8981bb499f9647c3e (commit) via 6fdc9f035dd7b07cfdfc9023b9f667975964a86b (commit) via c2182118e130ac246b1f5ed790fb1659789e2fe5 (commit) from 122945827d6d958e533b913e10f47c13e3c34f65 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 203d8a194d8879db905121c8981bb499f9647c3e Author: Kyle M Hall Date: Thu Jan 16 14:10:18 2020 -0500 Bug 24441: Error when checking in an item with BranchTansferLimitsType set to itemtype It appears that the transition to using Koha::Item in AddReturn has introduced a bug. Previously $item was a hashref with the key 'itemtype', now that it's an object, it has no itemtype method and so triggers an error with the message "The method Koha::Item->itemtype is not covered by tests!". Test Plan: 1) Enable Branch Transfer Limits via itemtype 2) Check in an item 3) Note the error 4) Apply this patch 5) Restart all the things! 6) Check in an item 7) No error! Signed-off-by: Kyle M Hall Signed-off-by: Maribeth (Turner) Shafer Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 6fdc9f035dd7b07cfdfc9023b9f667975964a86b Author: Jonathan Druart Date: Tue Jan 21 16:08:12 2020 +0100 Bug 24441: Add tests Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit c2182118e130ac246b1f5ed790fb1659789e2fe5 Author: Nick Clemens Date: Fri Dec 13 16:08:16 2019 +0000 Bug 24236: Fix pagination to use query_cgi This is still wrong, we should use page-numbers.inc, but that is a larger refactoring This patch fixes non-QueryParser searches by simple getting an using the escaped query (query_cgi) For QueryParser, we do what the QP code does, just uri escape the query - the way that SimpleSearch does the query parsing instead of the usual buildQuery suggest to me that we should probably switch all of this to use the general Zebra search. The issues with reservoir should be their own bug To test: 1 - Search for cat in cataloging search 2 - Get results and see you can paginate 3 - Search for "cat" 4 - Get results but subsequent pages empty 5 - Apply patch 6 - Repeat search for "cat" 7 - You can paginate 8 - Enable UseQueryParser syspref (don't worry about installing) 9 - Confirm can still search with quotes and paginate Signed-off-by: Nick Clemens Signed-off-by: George Williams Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 2 +- cataloguing/addbooks.pl | 7 +++++-- t/db_dependent/Circulation/Returns.t | 32 +++++++++++++++++++++++++++++++- 3 files changed, 37 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Feb 7 00:28:38 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 06 Feb 2020 23:28:38 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.02-81-gd79888822b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via d79888822bba76c1eab3530f5b792bd7c88bbbde (commit) via 37c07b1b56a8a72d9473249bfa1cb512e08f7df9 (commit) via 7207e57dbe867d6da3f38393b03242cf4c3d1eb5 (commit) from 203d8a194d8879db905121c8981bb499f9647c3e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d79888822bba76c1eab3530f5b792bd7c88bbbde Author: Jonathan Druart Date: Wed Nov 20 12:22:58 2019 +0100 Bug 23064: Use Koha::Subscription in ModSubscription We must use Koha::Subscription instead of raw SQL. It will fix issue with default and integer values. Test plan: Edit a subscription and set number of issues = "f" Save => Without this patch there is a SQL error in the log: Incorrect integer value: 'f' for column 'numberlength' => With this patch the other changes are effective. Note: We also could change the type attribute of the input to "number", to have a client-side check Also, the return value of ModSuggestion is never used, so we are safe with that. Signed-off-by: Hayley Mapley Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 37c07b1b56a8a72d9473249bfa1cb512e08f7df9 Author: Jonathan Druart Date: Fri Jan 10 14:16:56 2020 +0100 Bug 24397: Remove out of sync script populate_db.pl populate_db.pl from koha-misc4dev must be used instead. This script existed before the creation of koha-misc4dev, it does no longer make sense to have it in Koha. Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 7207e57dbe867d6da3f38393b03242cf4c3d1eb5 Author: Nick Clemens Date: Fri Dec 20 13:33:28 2019 +0000 Bug 24286: Escape forward slash in GENRE/FORM (and any authtype) Note that bug 24267 will fix the issue during Z39 searching for new auth, but the duplicate check at saving will still fail To test: 0 - Set SearchEngine to Elasticsearch, QueryRegexEscapeOptions to 'Don't Escape' 1 - Browse to Authorities 2 - Select New->New from Z3950 3 - Search for subject 'Short stories' 4 - Auth search explodes 5 - Apply patch 6 - Repeat and confirm the search results return 7 - Import and save the GENRE/FORM record for Short stories 8 - Repeat the search and import the same record 9 - Confirm that upon save you are notified of duplicate, don't save 10 - set QueryRegexEscapeOptions to 'Escape' and confirm Z39 searching works and importing/save notifies of duplicate 11 - set SearchEngine to Zebra and confirm Z39 searching works and importing/save notifies of duplicate Signed-off-by: Kelly McElligott Signed-off-by: Myka Kennedy Stephens Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: C4/AuthoritiesMarc.pm | 1 + C4/Serials.pm | 74 ++++++++++------- misc/devel/populate_db.pl | 200 ---------------------------------------------- 3 files changed, 46 insertions(+), 229 deletions(-) delete mode 100755 misc/devel/populate_db.pl hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Feb 7 00:49:16 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 06 Feb 2020 23:49:16 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.02-84-g1887f8a715 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 1887f8a715944b80227171441b427d5ccf6177d1 (commit) via f33f46e6cde96b996739cbcce02e98c0bb6a2ca0 (commit) via caba8dafb820448aca877c86682c28ff97953f3b (commit) from d79888822bba76c1eab3530f5b792bd7c88bbbde (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1887f8a715944b80227171441b427d5ccf6177d1 Author: Lucas Gass Date: Wed Jan 22 16:31:10 2020 +0000 Bug 24025: Make CodeMirror content searchable Signed-off-by: Barbara Johnson Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit f33f46e6cde96b996739cbcce02e98c0bb6a2ca0 Author: Owen Leonard Date: Fri Jan 17 15:00:31 2020 +0000 Bug 24452: Advanced editor - show multiple spaces visually This patch updates the JavaScript and CSS for the advanced MARC editor so that multiple consecutive spaces within a line will be detected and highlighted. To test the EnableAdvancedCatalogingEditor system preference should be enabled. Apply the patch and clear your browser cache if necessary. - Go to Cataloging -> Advanced editor. - On any text entry line (e.g. 245), enter some words with one, two, and more spaces in between them. When there are two or more spaces between words the spaces between the words should have a dotted red underline. - Remove the extra spaces and confirm that the dotted line disappears. Signed-off-by: Cori Lynn Arnold Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit caba8dafb820448aca877c86682c28ff97953f3b Author: Liz Rea Date: Mon Nov 25 11:20:51 2019 -0600 Bug 24105: Fix error when running longoverdue.pl with --itemtypes To test: Run Longoverdue.pl as koha-shell with both 1 and several --itemtypes specified notice that it has an error apply this patch run longoverdue.pl as koha-shell with both 1 and several --itemtypes specified notice there isn't an error anymore! Signed-off-by: David Roberts Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/lib/koha/cateditor/marc-mode.js | 4 ++++ koha-tmpl/intranet-tmpl/prog/css/cateditor.css | 4 ++++ koha-tmpl/intranet-tmpl/prog/js/pages/preferences.js | 3 ++- misc/cronjobs/longoverdue.pl | 4 ++-- 4 files changed, 12 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Feb 7 11:26:39 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 07 Feb 2020 10:26:39 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-650-gbd4e4dcd85 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via bd4e4dcd85321637d1f14ed6e8b8a5a59e8a172a (commit) via 31f1a766256b145cd657d826ec3bc6333a938e50 (commit) from d5e993ed47400206519bfe74df79e9254f1175fe (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit bd4e4dcd85321637d1f14ed6e8b8a5a59e8a172a Author: Mason James Date: Fri Feb 7 15:11:05 2020 +1300 Bug 13193: (follow-up) Update debian/control file The dependancy has now been packaged, this patch adds it to the debian control file for package installs. Signed-off-by: Martin Renvoize commit 31f1a766256b145cd657d826ec3bc6333a938e50 Author: Joonas Kylmälä Date: Mon Sep 16 10:26:01 2019 +0000 Bug 13193: Make Memcached usage fork safe When a high enough number of forks try to access for example system preferences with Koha::Cache using memcached as backend the results of different cache requests get mixed up. The problem is fixed by using Cache::Memcached::Fast::Safe that is a fork safe version of Cache::Memcached::Fast. Sponsored-by: The National Library of Finland Signed-off-by: David Cook Works as described, and solves an insidious difficult to debug problem in Koha. Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Installer/PerlDependencies.pm | 7 ++++++- Koha/Cache.pm | 6 +++--- debian/control | 4 ++-- koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 2 +- 4 files changed, 12 insertions(+), 7 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Feb 7 16:00:03 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 07 Feb 2020 15:00:03 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.07-54-g95d398d34b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 95d398d34b32c8b09c365e418ab7a580a14dd765 (commit) from 7c25b08e90f67c4ec51df691344954de11911966 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 95d398d34b32c8b09c365e418ab7a580a14dd765 Author: Owen Leonard Date: Fri Oct 11 14:53:24 2019 +0000 Bug 23528: Show 'log in to add tags' link on all search result entries This patch modifies the OPAC search result template so that each result shows the "Log in to add tags" link instead of just the first. To test, apply the patch and make sure TagsEnabled and TagsInputOnList are both enabled. Perform a search in the OPAC while not logged in. In the list of results, the "Log in to add tags" link should appear with every result. Log in to the OPAC and confirm that the "Add tag" link appears as expected. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit 04cd884d10a4b9b6a889c084d40b44742e3d7279) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Feb 7 16:42:45 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 07 Feb 2020 15:42:45 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.11.00-651-g99e2fbd083 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 99e2fbd0832bee58e84724cd19b74e683d10520f (commit) from bd4e4dcd85321637d1f14ed6e8b8a5a59e8a172a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 99e2fbd0832bee58e84724cd19b74e683d10520f Author: Martin Renvoize Date: Fri Feb 7 14:32:13 2020 +0000 Bug 13193: (RM follow-up) Remove Cache::Memcached::Fast from PerlDependencies We replaced this module with Cache::Memcached::Fast::Safe and so do not need to depend upon it any longer. Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Installer/PerlDependencies.pm | 5 ----- 1 file changed, 5 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Feb 7 21:56:19 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 07 Feb 2020 20:56:19 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.07-55-ga044f6365b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via a044f6365be947f8e97bd10a5ed4c6510f634eab (commit) from 95d398d34b32c8b09c365e418ab7a580a14dd765 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a044f6365be947f8e97bd10a5ed4c6510f634eab Author: Nick Clemens Date: Tue Jan 28 13:57:32 2020 +0000 Bug 24485: Allow hold when some can be overridden The check to see if we can place a hold counts the number that we can override vs the number of items on the record. We cannot override if we already have a hold on an item, however, we don't count these to see if they plus the number of overrides equal the items on the record. To test: 1 - Set max reserves to 2, allow 2 holds per recrod 2 - Place 2 holds for a patron on some records 3 - Find another record with 2 items 4 - Place a hold on the first item, you will be notified about the limit but you can override 5 - Attempt to place hold on second item, cannot be done, button disabled 6 - Apply patch 7 - Repeat 8 - You can place the second hold Signed-off-by: Kelly McElligott Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit d52983cf3d448d18b0b0086968a506522e3cc816) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: reserve/request.pl | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat Feb 8 00:38:46 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 07 Feb 2020 23:38:46 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.02-87-g269bbbf2b6 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 269bbbf2b670f2985febfa14554cd8a6d5b03620 (commit) via d950985d17db7c142e6c99edb41a7dc9c2d906ef (commit) via 8d42c6be904cf1e23c179063500d236fc5789d8f (commit) from 1887f8a715944b80227171441b427d5ccf6177d1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 269bbbf2b670f2985febfa14554cd8a6d5b03620 Author: Joy Nelson Date: Fri Feb 7 23:11:45 2020 +0000 Bug 24289: DBRev 19.11.02.003 Signed-off-by: Joy Nelson commit d950985d17db7c142e6c99edb41a7dc9c2d906ef Author: Jonathan Druart Date: Thu Dec 26 12:06:10 2019 +0100 Bug 24289: Make sure sample_holidays will load after sample_libraries They are inserted depending on their alpha order, and sample_holidays will fail because of missing branchcode. This patch suggests a simple fix: rename sample_holidays to sample_libraries_holidays, to make sure it will be loaded after sample_libraries Test plan: Start a fresh installation and select all sample data Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 8d42c6be904cf1e23c179063500d236fc5789d8f Author: Jonathan Druart Date: Thu Dec 26 11:42:43 2019 +0100 Bug 24289: Add foreign keys on *_holidays.branchcode tables Those are missing foreign keys, it will also clean the holidays tables and automatically remove the holidays when a library is removed. Test plan: 0. Do not apply this patch 1. Create a new library 2. Create special and repeatable holiday for this library 3. Remove the library => Notice that the holidays still exist in DB 4. Apply this patch 5. Execute the update database entry => Notice that the holidays for this library have been removed from the DB 6. Repeat 1-3 => Notice that the holidays have been removed along with the library Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- Koha/Schema/Result/Branch.pm | 34 ++++++++++++++++++++-- Koha/Schema/Result/RepeatableHoliday.pm | 25 +++++++++++++--- Koha/Schema/Result/SpecialHoliday.pm | 25 +++++++++++++--- installer/data/mysql/atomicupdate/bug_24289.perl | 31 ++++++++++++++++++++ ..._holidays.sql => sample_libraries_holidays.sql} | 0 ..._holidays.txt => sample_libraries_holidays.txt} | 0 ..._holidays.sql => sample_libraries_holidays.sql} | 0 ..._holidays.txt => sample_libraries_holidays.txt} | 0 ..._holidays.sql => sample_libraries_holidays.sql} | 0 ..._holidays.txt => sample_libraries_holidays.txt} | 0 ...holidays.sql => sample_librairies_holidays.sql} | 0 ...holidays.txt => sample_librairies_holidays.txt} | 0 ..._holidays.sql => sample_libraries_holidays.sql} | 0 ..._holidays.txt => sample_libraries_holidays.txt} | 0 installer/data/mysql/kohastructure.sql | 10 ++++--- ..._holidays.sql => sample_libraries_holidays.sql} | 0 ..._holidays.txt => sample_libraries_holidays.txt} | 0 ..._holidays.sql => sample_libraries_holidays.sql} | 0 ..._holidays.txt => sample_libraries_holidays.txt} | 0 installer/data/mysql/updatedatabase.pl | 33 +++++++++++++++++++++ 21 files changed, 145 insertions(+), 15 deletions(-) create mode 100644 installer/data/mysql/atomicupdate/bug_24289.perl rename installer/data/mysql/de-DE/optional/{sample_holidays.sql => sample_libraries_holidays.sql} (100%) rename installer/data/mysql/de-DE/optional/{sample_holidays.txt => sample_libraries_holidays.txt} (100%) rename installer/data/mysql/en/optional/{sample_holidays.sql => sample_libraries_holidays.sql} (100%) rename installer/data/mysql/en/optional/{sample_holidays.txt => sample_libraries_holidays.txt} (100%) rename installer/data/mysql/es-ES/optional/{sample_holidays.sql => sample_libraries_holidays.sql} (100%) rename installer/data/mysql/es-ES/optional/{sample_holidays.txt => sample_libraries_holidays.txt} (100%) rename installer/data/mysql/fr-CA/facultatif/{sample_holidays.sql => sample_librairies_holidays.sql} (100%) rename installer/data/mysql/fr-CA/facultatif/{sample_holidays.txt => sample_librairies_holidays.txt} (100%) rename installer/data/mysql/it-IT/optional/{sample_holidays.sql => sample_libraries_holidays.sql} (100%) rename installer/data/mysql/it-IT/optional/{sample_holidays.txt => sample_libraries_holidays.txt} (100%) rename installer/data/mysql/nb-NO/2-Valgfritt/{sample_holidays.sql => sample_libraries_holidays.sql} (100%) rename installer/data/mysql/nb-NO/2-Valgfritt/{sample_holidays.txt => sample_libraries_holidays.txt} (100%) rename installer/data/mysql/pl-PL/optional/{sample_holidays.sql => sample_libraries_holidays.sql} (100%) rename installer/data/mysql/pl-PL/optional/{sample_holidays.txt => sample_libraries_holidays.txt} (100%) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat Feb 8 01:06:27 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sat, 08 Feb 2020 00:06:27 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.02-91-gb86a98dffd Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via b86a98dffd8350df1e34f7b64a21aa018ca27cd0 (commit) via 6ff3be60aef4b13fd93cc833669e8e032035d8e6 (commit) via 475f8b9f62c1893cd0a4bd0eefcd8af9b76c4f04 (commit) via 35af73ae3c18061706d34775f35f0869a29284f2 (commit) from 269bbbf2b670f2985febfa14554cd8a6d5b03620 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b86a98dffd8350df1e34f7b64a21aa018ca27cd0 Author: Martin Renvoize Date: Thu Jan 23 10:20:31 2020 +0000 Bug 22831: (RM follow-up) Code golf Rather than performing a symmetric diff and then splitting the results in a further loop this patch changes to logic to use two asymetric diffs to get the results more directly. Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 6ff3be60aef4b13fd93cc833669e8e032035d8e6 Author: Nick Clemens Date: Thu Nov 7 18:49:12 2019 +0000 Bug 22831: (follow-up) Sort results, group by db Signed-off-by: Bouzid Fergani Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 475f8b9f62c1893cd0a4bd0eefcd8af9b76c4f04 Author: Nick Clemens Date: Wed Nov 6 14:37:01 2019 +0000 Bug 22831: (follow-up) Determine where the record is missing and provide link, show counter Signed-off-by: Ere Maijala Signed-off-by: Bouzid Fergani Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 35af73ae3c18061706d34775f35f0869a29284f2 Author: Nick Clemens Date: Thu May 2 12:24:08 2019 +0000 Bug 22831: Elasticsearch - add a maintenance script for checking DB vs index counts This script uses Array::Utils and adds a dependency To test: 1 - Have Koha with ES running 2 - Delete some records from ES curl -X DELETE "es:9200/koha_kohadev_biblios/data/5" curl -X DELETE "es:9200/koha_kohadev_authorities/data/5" 3 - perl misc/maintenance/compare_es_to_db.pl 4 - Note you are notified of problems in both indexes 5 - perl misc/search_tools/rebuild_elastic_search.pl -a 6 - perl misc/maintenance/compare_es_to_db.pl 7 - Note you are only notified about problems in biblios (assuming you don't have other issues) 8 - perl misc/search_tools/rebuild_elasticsearch.pl -b 9 - perl misc/maintenance/compare_es_to_db.pl 10 - Both counts match, no problems Signed-off-by: Ere Maijala Signed-off-by: Bouzid Fergani Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson ----------------------------------------------------------------------- Summary of changes: C4/Installer/PerlDependencies.pm | 5 ++ misc/maintenance/compare_es_to_db.pl | 114 +++++++++++++++++++++++++++++++++++ 2 files changed, 119 insertions(+) create mode 100644 misc/maintenance/compare_es_to_db.pl hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat Feb 8 01:24:56 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sat, 08 Feb 2020 00:24:56 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.02-92-gddfc3fca69 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via ddfc3fca690ccc4a041089d5813558e79c93f359 (commit) from b86a98dffd8350df1e34f7b64a21aa018ca27cd0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ddfc3fca690ccc4a041089d5813558e79c93f359 Author: Joy Nelson Date: Fri Feb 7 23:59:33 2020 +0000 Bug 24289: dbrev update to remove atomicupdate file ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/atomicupdate/bug_24289.perl | 31 ------------------------ 1 file changed, 31 deletions(-) delete mode 100644 installer/data/mysql/atomicupdate/bug_24289.perl hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat Feb 8 01:38:45 2020 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sat, 08 Feb 2020 00:38:45 +0000 Subject: [koha-commits] main Koha release repository branch 19.11.x updated. v19.11.02-94-g541dfa7dde Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 541dfa7ddeec9fc72dd764165087dcfb601ddf07 (commit) via 6cc2c566ece46e36bd56a728d2208e1c0e865220 (commit) from ddfc3fca690ccc4a041089d5813558e79c93f359 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 541dfa7ddeec9fc72dd764165087dcfb601ddf07 Author: Owen Leonard Date: Wed Nov 20 20:04:10 2019 +0000 Bug 21296: suspend hold ignores system preference on intranet This patch modifies the DataTable configuration for the table of holds which displays under the "Holds" tab on the patron's checkout and details pages. A variable is now defined in the JavaScript with the value of the "SuspendHoldsIntranet" system preference. This variable is passed to the DataTable configuration to determine whether the column is visible or not. One of the changes made in this patch moves a