[koha-commits] main Koha release repository branch master updated. v19.11.00-612-g87f20fd5fe

Git repo owner gitmaster at git.koha-community.org
Tue Feb 4 11:48:10 CET 2020


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  87f20fd5fe7f4c67963498f42252bf09bf7a317d (commit)
       via  1bddf5f3bab01ce2151ccefa8982134509e3fac3 (commit)
       via  db148eeff5b6e6fcfa5f7d0f47a3e43d0df5ea4e (commit)
       via  0f6d55a0a13aa598f9da5543b72aecd40335eb89 (commit)
       via  35635b98db9a25a8a63af6204bf490ab7b86dca3 (commit)
       via  6d32f34d515f176738a6784576643580cbac36d2 (commit)
       via  7c813d044119b055dd20b8ee9f0a68f163ce1c73 (commit)
       via  4f4405174d9bd1a89433b2598b878ecf9057b2bb (commit)
       via  ffb5fb60ed3e8c5aeb534d60bf81bde80f309484 (commit)
       via  a905fd8a3847ff4f035759aef575d8c6ad77fea2 (commit)
       via  8829e8d21473486e29b7f4969165d201aa0a3c81 (commit)
       via  a567c990876d8d33a29e0b43c4f45940ddafd8b6 (commit)
       via  c5576eef0c252e8f9813ebc0df1f25e0e92b43b0 (commit)
       via  17cd229335ec9148a9d5f316e846f4bee01ccb1c (commit)
      from  14fa7c112c9bfd685de7f062c732f8069aebb0ff (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 87f20fd5fe7f4c67963498f42252bf09bf7a317d
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Wed Nov 20 17:00:52 2019 +0000

    Bug 9993: On editing basket group delivery place resets to logged in branch
    
    This patch modifies basketgroups.pl so that existing data about a basket
    group's billing and delivery place are correctly preselected in the edit
    form. These fields shouldn't reset to the logged-in user's home branch
    just because they have an empty value.
    
    To test, apply the patch and go to Acquisitions -> Vendor -> Basket
    groups.
    
    When adding or editing a basket group the pre-selected value for
    "Billing place" and "Delivery place" should be correct:
    
       - When creating a new basket group: The logged-in user's library
         should be pre-selected.
    
       - When editing a basket group which has a library defined for either
         the billing or delivery places, the correct library should be
         pre-selected.
    
       - When editing a basket group which has no library defined for either
         the billing or delivery place there should be no library
         pre-selected (the "--" option should be pre-selected).
    
    Signed-off-by: David Nind <david at davidnind.com>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 1bddf5f3bab01ce2151ccefa8982134509e3fac3
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Tue Nov 19 17:02:02 2019 +0000

    Bug 10879: OverDrive should check for OverDriveLibraryID before performing search
    
    This patch modifies the OPAC search results template to check for three
    populated system preferences before performing an OverDrive search:
    OverDriveLibraryID, OverDriveClientKey, and OverDriveClientSecret.
    Previously OverDriveLibraryID was not checked, but without it the
    interface reports an error performing the search.
    
    To test you must have credentials for the OverDrive API as defined
    in OverDriveClientKey, OverDriveClientSecret, and OverDriveLibraryID
    system preferences.
    
     - With OverDriveLibraryID defined, the catalog search results page in
       the OPAC should show a link to results in the library's OverDrive
       collection.
    
     - With no value in the OverDriveLibraryID preference the catalog
       search page should not show any message about an OverDrive
       collection.
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit db148eeff5b6e6fcfa5f7d0f47a3e43d0df5ea4e
Author: Lucas Gass <lucas at bywatersolutions.com>
Date:   Sat Feb 1 16:42:10 2020 +0000

    Bug 24560: Remove No public list text from OPAC
    
    On the OPAC, the dropdown for Lists always includes
    the heading Public Lists, even if no public lists exist.
    This is sub-optimal for libraries that want VirtualShelves
    enabled for private lists but don't want to use public lists.
    
    TEST PLAN:
    1. have no public list and look at the List dropdown on the OPAC. It says No Public Lists.
    2. Apply patch
    3. It should now not say anything about public lists but still be formatted nice.
    4. Add some public lists and confirm that everything looks normal.
    5. Sign off
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 0f6d55a0a13aa598f9da5543b72aecd40335eb89
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Tue Dec 10 17:30:41 2019 +0000

    Bug 23533: (follow-up) Add markup comments
    
    This patch adds comments to the template to highlight the markup
    structure.
    
    This patch should have no effect on the interface or functionality.
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 35635b98db9a25a8a63af6204bf490ab7b86dca3
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Tue Dec 10 16:34:56 2019 +0000

    Bug 23533: Reindent patron entry form (memberentrygen.tt)
    
    This patch re-indents the template for patron entry/editing. It
    makes only whitespace changes. It should have no effect on the behavior
    of the page.
    
    To test, create or edit a patron.
    
    Test every aspect of the process. At each step the page should work
    correctly. Including:
    
     - Adult patron
     - Child patron
     - Organizational patron
     - Quick patron add
     - Duplicate patron
     - With mandatory fields
     - With 'BorrowerUnwantedField's defined
     - With ExtendedPatronAttributes enabled
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 6d32f34d515f176738a6784576643580cbac36d2
Author: David Roberts <david at koha-ptfs.co.uk>
Date:   Mon Jan 27 15:41:32 2020 +0000

    Bug 24490: Clarify wording and function of Purchase Items link on POS
    
    This patch changes the wording of the links on the POS side menu
    
    To test:
    
    1) Apply the patch
    2) Check that the links on the left hand side of the screen read "Configure cash registers" and "Configure items for purchase"
    3) Click both links to ensure you are taken to the relevant config pages.
    
    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 7c813d044119b055dd20b8ee9f0a68f163ce1c73
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Feb 3 13:36:54 2020 +0100

    Bug 24440: Rename current_holds with current_item_level_holds
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 4f4405174d9bd1a89433b2598b878ecf9057b2bb
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri Jan 31 15:08:00 2020 +0100

    Bug 24440: Adding 2 more tests for ->biblio
    
    Not directly related to the other changes but seems good to have them
    here.
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit ffb5fb60ed3e8c5aeb534d60bf81bde80f309484
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Jan 31 00:54:27 2020 -0300

    Bug 24440: (follow-up) Make related objects prefetchable
    
    This patch creates aliases for the relations used to retrieve the linked
    objects from other tables. It makes the accessor names match the used
    relation name, for consistency.
    
    This is important for code trying to be smart and guessing what needs to
    be prefetched, like the API code.
    
    To test:
    1. Run:
       $ kshell
      k$ prove t/db_dependent/Koha/Acquisition/Order.t
    => SUCCESS: Tests pass
    2. Apply this patch
    3. Repeat (1)
    => SUCCESS: Tests pass! No behaviour change
    4. Verify the POD changes make sense
    5. Sign off :-D
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: David Nind <david at davidnind.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit a905fd8a3847ff4f035759aef575d8c6ad77fea2
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Jan 31 00:27:05 2020 -0300

    Bug 24440: ->biblio tests
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: David Nind <david at davidnind.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 8829e8d21473486e29b7f4969165d201aa0a3c81
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Thu Jan 16 15:58:25 2020 -0300

    Bug 24440: Add ->current_holds to Koha::Acquisition::Order
    
    This patch introduces a method to fetch the current holds associated with the
    items linked to an order line. It basically implements what's done in
    parcel.pl, but fully tested and suitable for using on the API.
    
    To test:
    1. Apply this patches
    2. Run:
       $ kshell
      k$ prove t/db_dependent/Koha/Acquisition/Order.t
    => SUCCESS: Tests pass!
    3. Sign off :-D
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: David Nind <david at davidnind.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit a567c990876d8d33a29e0b43c4f45940ddafd8b6
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Thu Jan 16 15:58:15 2020 -0300

    Bug 24440: Unit tests
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: David Nind <david at davidnind.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit c5576eef0c252e8f9813ebc0df1f25e0e92b43b0
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Dec 23 14:06:06 2019 +0100

    Bug 24171: Check auto_renew if confirmation is needed
    
    Test plan:
    Add some fines
    Check auto_renew and check an item out, using a title keyword
    Pick one item
    You get the confirmation box
    => Notice that the auto_renew checkbox is checked
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 17cd229335ec9148a9d5f316e846f4bee01ccb1c
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Dec 17 12:10:28 2019 +0100

    Bug 24171: Preserve auto_renew when triggering itemBarcodeFallbackSearch
    
    The auto_renew parameter is not sent to the template when the popup
    triggered by itemBarcodeFallbackSearch is displayed.
    
    Test plan:
    - Turn on itemBarcodeFallbackSearch
    - Open a patron account
    - Check the checkboxes for automatic-renewal
    - Search for a title keyword in the checkout input box
    - Verify that auto-renewal flag is set
    
    Note for QA: The auto_renew flag will be set in any cases. Should we
    expect regression?
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha/Acquisition/Order.pm                          |   64 +-
 Koha/Schema/Result/Aqorder.pm                      |   57 +
 acqui/basketgroup.pl                               |    8 +-
 circ/circulation.pl                                |    3 +-
 .../intranet-tmpl/prog/en/includes/pos-menu.inc    |    4 +-
 .../prog/en/modules/circ/circulation.tt            |   13 +-
 .../prog/en/modules/members/memberentrygen.tt      | 2524 +++++++++++---------
 .../opac-tmpl/bootstrap/en/includes/masthead.inc   |    6 +-
 .../opac-tmpl/bootstrap/en/modules/opac-results.tt |    2 +-
 t/db_dependent/Koha/Acquisition/Order.t            |   93 +-
 10 files changed, 1573 insertions(+), 1201 deletions(-)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list