[koha-commits] main Koha release repository branch master updated. v19.11.00-635-g585001c6d3

Wed Feb 5 14:04:20 CET 2020

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  585001c6d3f18b4420f785778aab0889df43357b (commit)
       via  1069bc240525f72d1e06bb9b78ef55fbec6dad2e (commit)
       via  d88dfbf34e68849e0deed5543817decf6dfb19cb (commit)
       via  9eaa4d9775fa64549ec9657f333914d671129acf (commit)
       via  445a97d8d27cb381ba6594bbe3848d35f741958d (commit)
       via  8854a14fe7299bc9230a856d19f213dcb2308956 (commit)
       via  724bd2e0550d8a61f7b5e0505b544cab52d655d9 (commit)
       via  1e2617342a156e58c3b59d6534842984c2f01df4 (commit)
      from  c54163940d9fa1fb173ae236a1e093cc50cadba8 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 585001c6d3f18b4420f785778aab0889df43357b
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Wed Jan 29 13:24:34 2020 +0000

    Bug 24529: Silence another uninitialised value warning

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 1069bc240525f72d1e06bb9b78ef55fbec6dad2e
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Wed Jan 29 13:18:20 2020 +0000

    Bug 24529: Silence warnings for title level holds

    This patch simply adds a test for itemnumber being defined in the
    reserve before comparing it to silence the warning.

    Test plan:
    1) Prior to patch, run prove t/db_dependant/Circulation.t and note lots
       of `Use of uninitialized value in numeric eq (==) at
       /kohadevbox/koha/C4/Reserves.pm line 790` warnings.
    2) Apply the patch, re-run the test and note the tests still pass but
       the warnings are now gone.

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit d88dfbf34e68849e0deed5543817decf6dfb19cb
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Feb 5 10:36:14 2020 +0100

    Bug 24590: Fix Koha/Object.t on MySQL 8

    % prove t/db_dependent/Koha/Object.t
    is failing on MySQL 8 with:

     kohadev-koha at 9bbf9ac68519:/kohadevbox/koha$ prove t/db_dependent/Koha/Object.t
     t/db_dependent/Koha/Object.t .. 15/18
         #   Failed test 'Exception field is correct'
         #   at t/db_dependent/Koha/Object.t line 650.
         #          got: 'api_keys.secret'
         #     expected: 'secret'
         # Looks like you failed 1 test of 16.
     t/db_dependent/Koha/Object.t .. 16/18
     #   Failed test 'store() tests'
     #   at t/db_dependent/Koha/Object.t line 723.

    MySQL 8 displays the tablename in the error.

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 9eaa4d9775fa64549ec9657f333914d671129acf
Author: Lucas Gass <lucas at bywatersolutions.com>
Date:   Tue Jan 14 15:40:38 2020 +0000

    Bug 24420: Display waiting on hold items in the Cataloging search results Location column

    To Test:
    1. Place a hold on an item and trigger it.
    2  Do a cataloging search that would include this record.
    3. Notice that the 'Location' column does not account for this onhold
    item.
    4. Apply patch and look at catalog results again.
    5. You should see information display about the item being on hold.

    Signed-off-by: Barbara Johnson <barbara.johnson at bedfordtx.gov>
    Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 445a97d8d27cb381ba6594bbe3848d35f741958d
Author: Nick <nick at bywatersolutions.com>
Date:   Fri Oct 18 18:26:38 2019 +0000

    Bug 23844: Check if field defined in framework and specify 'Default' for framework

    To test:
    1 - Go to Cataloguing
    2 - New from Z3950
    3 - Find an import a record
    4 - Check the plack logs:
    Use of uninitialized value in string ne at /kohadevbox/koha/cataloguing/addbiblio.pl line 565.
    Use of uninitialized value in string ne at /kohadevbox/koha/cataloguing/addbiblio.pl line 580.
    Use of uninitialized value $frameworkcode in string eq at /kohadevbox/koha/cataloguing/addbiblio.pl line 711.
    Use of uninitialized value $frameworkcode in string eq at /kohadevbox/koha/cataloguing/addbiblio.pl line 715.
    Use of uninitialized value $frameworkcode in string eq at /kohadevbox/koha/cataloguing/addbiblio.pl line 734.
    5 - Apply patch
    6 - Repeat
    7 - No new errors
    8 - Confirm selecting 'Default' from 'New from Z3950' dropdown also generates no errors

    Signed-off-by: Myka Kennedy Stephens <mkstephens at lancasterseminary.edu>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 8854a14fe7299bc9230a856d19f213dcb2308956
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Tue Feb 4 14:16:26 2020 +0000

    Bug 22302: Make ITEMTYPECAT descriptions fallback to lib description if no opac description

    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 724bd2e0550d8a61f7b5e0505b544cab52d655d9
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Tue Feb 4 14:15:36 2020 +0000

    Bug 22302: Unit tests

    Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 1e2617342a156e58c3b59d6534842984c2f01df4
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Tue Jan 28 13:57:32 2020 +0000

    Bug 24485: Allow hold when some can be overridden

    The check to see if we can place a hold counts the number that we can override vs the number of items on the record.

    We cannot override if we already have a hold on an item, however, we don't count these to see if they plus
    the number of overrides equal the items on the record.

    To test:
    1 - Set max reserves to 2, allow 2 holds per recrod
    2 - Place 2 holds for a patron on some records
    3 - Find another record with 2 items
    4 - Place a hold on the first item, you will be notified about the limit but you can override
    5 - Attempt to place hold on second item, cannot be done, button disabled
    6 - Apply patch
    7 - Repeat
    8 - You can place the second hold

    Signed-off-by: Kelly McElligott <kelly at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Koha.pm                                                   |  4 ++--
 C4/Reserves.pm                                               |  4 +++-
 cataloguing/addbiblio.pl                                     |  2 +-
 .../intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt    |  5 +++--
 reserve/request.pl                                           |  8 ++++++--
 t/db_dependent/Koha.t                                        | 12 +++++++++---
 t/db_dependent/Koha/Object.t                                 |  6 +++---
 7 files changed, 27 insertions(+), 14 deletions(-)

hooks/post-receive
-- 
main Koha release repository