[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.02-104-g7222662bf5
Git repo owner
gitmaster at git.koha-community.org
Mon Feb 10 23:25:11 CET 2020
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 19.11.x has been updated
via 7222662bf51cf57f2cf4bfa016935f56d70aff41 (commit)
via 7e7041a85c8dfdabe389f1ac5441dd5dfdc537c7 (commit)
via 9f1b005a15c1839a325429831e7fb9ace3ba4300 (commit)
via 235134e083078d8097fb920bfb0e53aee7860304 (commit)
via 8d28b02891cff69fbe0b2c6c89d48020d9ce61d4 (commit)
via 9a9829d7dd1b2ad6f52528ef810b3dded6298de2 (commit)
via e95ba5b8ddadd6f57391177126d1260ec4a129ee (commit)
via 768cd74241a012d4b24aaad7b188c04fc15f3452 (commit)
via ef3c039e5d964da5da8ba253b52a46fffa66ad66 (commit)
via 2922249d92bad9a1df4ea95b48a7e28fdc68a315 (commit)
from 541dfa7ddeec9fc72dd764165087dcfb601ddf07 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 7222662bf51cf57f2cf4bfa016935f56d70aff41
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Jan 24 11:17:15 2020 +0000
Bug 24305: (QA follow-up) Strip table name in [[table.field|alias]]
When you would use the construct, you wont have batch features unless
we strip the table name. This is consistent with the $sth->{NAME} used
to fill the headers by default.
Test plan:
Use [[items.biblionumber|bibno]] instead of items.biblionumber in a
reporting query.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
commit 7e7041a85c8dfdabe389f1ac5441dd5dfdc537c7
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Jan 24 11:04:05 2020 +0000
Bug 24305: (follow-up) Add small comment for square brackets in get_prepped_report
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
commit 9f1b005a15c1839a325429831e7fb9ace3ba4300
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Jan 13 12:15:33 2020 +0100
Bug 24305: Remove previous declaration of batch_biblionumbers
We should not init batch_biblionumbers before.
Also this patch deals with batch_cardnumbers.
Signed-off-by: Holly Cooper <hc at interleaf.ie>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
commit 235134e083078d8097fb920bfb0e53aee7860304
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Dec 26 11:11:55 2019 +0100
Bug 24305: Fix links to batch tools when report's columns do not contain integers
If report's columns do not only contain integers, we should not point to
batch tools.
For instance, if the value is a link, the batch tools will not work as
they will not retrieve the id (itemnnumber or biblionumber) properly
Test plan:
Create a report like:
SELECT CONCAT('<a href=\"/cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=', biblionumber, '&itemnumber=', itemnumber, '#edititem', '\">', itemnumber, '</a>' ) AS itemnumber
FROM items
LIMIT 10;
Execute it
=> There is not link to the batch tools
Edit the report like:
SELECT itemnumber
FROM items
LIMIT 10;
Execute it
=> There is a link to the batch tools
Edit the report like
SELECT itemnumber, CONCAT('<a href=\"/cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=', biblionumber, '&itemnumber=', itemnumber, '#edititem', '\">', itemnumber, '</a>' ) AS itemnumber
FROM items
LIMIT 10;
Execute it
=> There is link to the batch tools
Try other combinations with biblionumber.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
commit 8d28b02891cff69fbe0b2c6c89d48020d9ce61d4
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Fri Jan 24 09:20:06 2020 +0100
Bug 24503: fix missing use in value builder barcode_manual.pl
Bug 22721 added use C4::Biblio in cataloguing/value_builder/barcode.pl.
This is missing in value builder barcode_manual.pl.
You get the error :
Undefined subroutine &Koha::FrameworkPlugin::GetMarcFromKohaField called at cataloguing/value_builder/barcode_manual.pl line 41.
Test plan :
1) Configure a subfield of item to use value builder barcode_manual.pl
2) Go to a record
3) Try to add a new item
4) Check the value builder is OK
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Tested with autobarcode==year-0001,0002
No internal server error, but generates a barcode now.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
commit 9a9829d7dd1b2ad6f52528ef810b3dded6298de2
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Jan 24 07:22:52 2020 +0000
Bug 23407: (QA follow-up) Same change for UNIMARC XSLT
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
commit e95ba5b8ddadd6f57391177126d1260ec4a129ee
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Jan 24 07:12:31 2020 +0000
Bug 23407: (QA follow-up) Remove some XSLT item leftovers
Test plan:
Check intranet results and detail page.
Check opac detail.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
commit 768cd74241a012d4b24aaad7b188c04fc15f3452
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Wed Jul 31 20:14:34 2019 +0000
Bug 23407: Don't process items for XSLT on details pages
To test:
1 - Add 1000 items to a record
Go to biblio
Edit items
Add multiple copies of this item
Add 1000 and confirm
Wait..
2 - Load the record in staff client and OPAC, note how long it takes
Press F12 in browser to open the console
use the Network tab of the console
note the load time
refresh a few times to see average time
3 - Apply patch
4 - Restart all the things
5 - Reload the record in staff and opac
6 - Note decresed time
7 - Verify nothing on the page has changed
QA can grep the standard XSLT files for details pages for 'item' to note occurences do not use items information
Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
commit ef3c039e5d964da5da8ba253b52a46fffa66ad66
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Fri Jan 17 10:48:50 2020 +0100
Bug 24443: Unit test
Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
commit 2922249d92bad9a1df4ea95b48a7e28fdc68a315
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Fri Jan 17 10:25:19 2020 +0100
Bug 24443: Consider NULL as 0 for issues in items search
In items search, we can filter by items issues count, data coming from items.issues.
Most of the time, for an item with no issues this column contains NULL.
This enhancement proposes to consider NULL as 0 to allow searching items with no issues.
Test plan:
1) Use SQL to count items with items.issues = NULL :
select count(*) from items where issues is null;
2) Go to items search
3) Perform search with filter "Checkout count" = 0
4) Check you get the same number of results as SQL query
Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Items.pm | 3 +++
C4/XSLT.pm | 7 ++++++-
cataloguing/value_builder/barcode_manual.pl | 1 +
.../en/modules/reports/guided_reports_start.tt | 16 +++++++++++-----
.../prog/en/xslt/MARC21slim2intranetDetail.xsl | 3 +--
.../prog/en/xslt/MARC21slim2intranetResults.xsl | 6 +-----
.../prog/en/xslt/UNIMARCslim2intranetDetail.xsl | 3 +--
.../prog/en/xslt/UNIMARCslim2intranetResults.xsl | 5 +----
.../bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 3 +--
.../bootstrap/en/xslt/UNIMARCslim2OPACDetail.xsl | 3 +--
reports/guided_reports.pl | 4 ++++
t/db_dependent/Items.t | 22 +++++++++++++++++++++-
12 files changed, 52 insertions(+), 24 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list