[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.02-117-gc267954997
Git repo owner
gitmaster at git.koha-community.org
Tue Feb 11 00:40:29 CET 2020
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 19.11.x has been updated
via c26795499754fd62448210faeab62c4c8b9ca4da (commit)
via 462db680242b4a6cbfb82b3469ebec8912e69af3 (commit)
from a401f219481b3fc2a69c2ea5006e6e497d66b37b (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit c26795499754fd62448210faeab62c4c8b9ca4da
Author: Joy Nelson <joy at bywatersolutions.com>
Date: Mon Feb 10 23:14:11 2020 +0000
Bug 22868: DBRev 19.11.02.004
Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
commit 462db680242b4a6cbfb82b3469ebec8912e69af3
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Jan 14 10:02:11 2020 +0100
Bug 22868: Move suggestions_manage subperm out of acquisition perm
Bug 11911 replaced the permission of suggestions.pl (create a purchase
suggestion) from catalogue => 1 to acquisition => 'suggestions_manage'.
However we have a lot of acquisition scripts that have lax permissions
(acquisition => '*' which means any sub permissions of acquisition is
enough).
That causes problem when a circulation staff can create purchase
suggestions but not access acquisition information.
One solution is to move the suggestions_manage subpermission out of the
acquisition permission and create a new suggestion permission.
Test plan:
0. Setup
* Create a patron with several permission (and full acquisition
permission)
* Create another patron with several permission, and suggestions_manage
permission
* Create another patron without the suggestions_manage permission
1. Apply the patch and execute the update database entry
2. Note that the third patron you create still does not have
suggestions_manage
3. Confirm that you can create a purchase suggestion if you have
suggestions_manage, but cannot access acquisition pages if you do not
have any subpermissions of the acquisition permission
Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
-----------------------------------------------------------------------
Summary of changes:
Koha.pm | 2 +-
installer/data/mysql/updatedatabase.pl | 19 +++++++++++++++++++
installer/data/mysql/userflags.sql | 3 ++-
installer/data/mysql/userpermissions.sql | 2 +-
.../prog/en/includes/acquisitions-menu.inc | 2 +-
.../intranet-tmpl/prog/en/includes/circ-menu.inc | 2 +-
.../intranet-tmpl/prog/en/includes/permissions.inc | 5 ++++-
.../intranet-tmpl/prog/en/modules/acqui/acqui-home.tt | 2 +-
.../intranet-tmpl/prog/en/modules/intranet-main.tt | 2 +-
members/purchase-suggestions.pl | 2 +-
suggestion/suggestion.pl | 2 +-
11 files changed, 33 insertions(+), 10 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list