[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.02-122-g91980f27a3

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.11.x has been updated
       via  91980f27a30b2f57c59ea0da955b697ed6a98528 (commit)
       via  265f0c4041de9a109b0535d7fab3d95fdfcb34a8 (commit)
      from  b078794fcb1705769dd78e5b156b3def35d7e195 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 91980f27a30b2f57c59ea0da955b697ed6a98528
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Thu Jan 2 10:30:54 2020 -0500

    Bug 24330: When importing patrons from CSV, automatically strip BOM from file if it exists
    
    We have a partner that exports UTF-8 CSV files, and is experiencing the same thing as the author of this article: https://www.freecodecamp.org/news/a-quick-tale-about-feff-the-invisible-character-cd25cd4630e7/
    
    In short, Excel is inserting an invisible UTF-8 character at the start of the file, so that the column name "cardnumber" is actually named "\x{feff}cardnumber", causing "cardnumber" to be blank.
    
    A simple solution is provided here: https://stackoverflow.com/questions/24390034/remove-bom-from-string-with-perl
    
    Test Plan:
    1) Download the example.csv file
    2) Attempt to import it using the patron import tool
    3) Note the invalid column name error
    4) Apply this patch, restart all the things!
    5) Attempt the import again
    6) Assuming you have a branchcode MPL and a cataegory code S, the patron should import!
    
    Signed-off-by: David Nind <david at davidnind.com>
    Signed-off-by: Maggie Wong <maggie.wong at yccece.edu.hk>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 265f0c4041de9a109b0535d7fab3d95fdfcb34a8
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Jan 30 11:51:25 2020 +0100

    Bug 24543: Fix wrong test in api/v1/checkouts.t
    
    In t/db_dependent/api/v1/checkouts.t we define a circulation rule with renewalperiod=7.
    But then the expected due date is today+14 days.
    However, at the beginning of the script, the due_date of the issue is today+14 days.
    
    That highlight that the renewal period is not taken into account.
    
    The circulation rule is created with renewalperiod and renewalsallowed,
    however GetLoanLength check the existence of issuelength to return the rule.
    GetLoanLength finally return the default rule, with renewalperiod=0
    
    Note that this has been found working on bug 18936, code will be cleaned on that patchset.
    
    Test plan:
     % prove t/db_dependent/api/v1/checkouts.t
    must return green before and after this patch
    
    Signed-off-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha/Patrons/Import.pm            |  1 +
 t/db_dependent/api/v1/checkouts.t | 16 ++++++++--------
 2 files changed, 9 insertions(+), 8 deletions(-)


hooks/post-receive
-- 
main Koha release repository