[koha-commits] main Koha release repository branch master updated. v19.11.00-693-g794c18b8e6
Git repo owner
gitmaster at git.koha-community.org
Wed Feb 12 17:58:18 CET 2020
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 794c18b8e6918ca93c5cf6c5ca12a957f80d3093 (commit)
via 6d817b8e66c59b109b73c17266ce223cbbed94aa (commit)
via 357078b0aba74ad2bb1a99d6a2241f5fa9b20cd5 (commit)
via cc595325d6dc7f5bbf398357cacaf490e40794f8 (commit)
via faa89f406d524b65accf0e101746f87ca53ad63e (commit)
via a34d086a24b1e4519f8b31331d4c42b87b8e4a83 (commit)
from f9dd77cfab2c02ce7644a454612b40ec3b5627aa (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 794c18b8e6918ca93c5cf6c5ca12a957f80d3093
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Wed Feb 12 16:29:11 2020 +0000
Bug 19735: Remove C4::Installer::PerlDependancies
This patch does the actual removal of the PerlDependancies module.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 6d817b8e66c59b109b73c17266ce223cbbed94aa
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Wed Feb 12 16:28:15 2020 +0000
Bug 19735: (RM follow-up) Final update of cpanfile at push
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 357078b0aba74ad2bb1a99d6a2241f5fa9b20cd5
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Feb 12 12:46:34 2020 +0100
Bug 19735: Update cpanfile
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit cc595325d6dc7f5bbf398357cacaf490e40794f8
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Fri Feb 7 16:51:33 2020 +0000
Bug 19735: Add support for max_ver
This patchset adds support for extracting 'max_ver' from the cpanfile so
we can use version ranges properly and report errors if we have modules
installed that do not fit within that version range.
Test plan:
1) Manually modify the module version of a required module in the cpanfile
to have a max version greater than the version you have installed.
2) Run through the install proceedure and note the new warning that a
module needs upgrade for the module in question.
3) The module should also be reported in the about page
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit faa89f406d524b65accf0e101746f87ca53ad63e
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Fri Feb 7 16:59:44 2020 +0000
Bug 19735: (QA follow-up) Drop references to 'usage'
The 'usage' key was dropped as part of this migration to cpanfile but
it was still refered to by the installed. This patch simply removes
references to it. After considering how we might add it back in I
decided that as it stands it wasn't a well maintained list and should be
re-implimented in the future in a more consistent form if we miss it.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit a34d086a24b1e4519f8b31331d4c42b87b8e4a83
Author: Julian Maurice <julian.maurice at biblibre.com>
Date: Thu Oct 26 16:28:02 2017 +0000
Bug 19735: Move Perl deps definitions into a cpanfile
cpanfile is a format for describing CPAN dependencies for Perl
applications.
It is more concise - thus easier to read and maintain - than
C4::Installer::PerlDependencies, and allows to describe requirements
more accurately (using version ranges or features for instance)
Additionally it can be read by tools such as cpanm or carton for an
easy way to install dependencies on non-Debian-based systems.
For more information on cpanfile, see
http://search.cpan.org/~miyagawa/Module-CPANfile-1.1002/lib/cpanfile.pod
This patch replace C4::Installer::PerlDependencies by an equivalent
cpanfile and update all scripts/modules that were using PerlDependencies
It also removes dead code from C4::Installer::PerlModules (some
subroutines were not used at all, except in unit tests)
Added dependencies:
- Module::CPANfile
- CPAN::Meta (dependency of Module::CPANfile, but we need a more recent
version than the one Module::CPANfile requires)
Test plan:
1. Go to About page, tab Perl modules and keep this browser tab open
2. Apply patch
3. Install Module::CPANfile and CPAN::Meta
a. On Debian-based systems:
# will install libcpan-meta-perl as a dependency
sudo apt install libmodule-cpanfile-perl
b. Others:
# will install CPAN::Meta as a dependency
sudo cpanm Module::CPANfile
4. In a new browser tab, go to About page, tab Perl modules and compare
the table with the one in the previous browser tab
They should be identical, except for newly added dependencies
(Module::CPANfile and CPAN::Meta)
5. Do a 'standard' install
a. perl Makefile.PL (select 'standard')
b. make
c. sudo make install
d. Configure your database, web server, ... and go through the web
install process
6. Verify that the cpanfile got copied into PERL_MODULE_DIR (which
should be /usr/share/koha/lib)
7. Go to the about page of this fresh install and compare it with your
dev install
8. Verify that debian/list-deps still works
This takes a lot of time and it may not be necessary to wait until
the end. If you see some Debian package names that correspond to
modules in cpanfile, it means it still works
(you need apt-file for this script to work)
9. Verify that koha_perl_deps.pl still works
10. prove t/Installer_pm.t t/Installer_PerlModules.t
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Installer.pm | 1 -
C4/Installer/PerlDependencies.pm | 970 ---------------------
C4/Installer/PerlModules.pm | 191 ++--
Makefile.PL | 3 +-
about.pl | 3 +-
cpanfile | 183 ++++
debian/list-deps | 112 +--
installer/install.pl | 38 +-
koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 2 +-
.../prog/en/modules/installer/step1.tt | 17 +-
t/Installer_PerlDependencies.t | 14 -
t/Installer_PerlModules.t | 42 +-
t/Installer_pm.t | 12 +-
13 files changed, 358 insertions(+), 1230 deletions(-)
delete mode 100644 C4/Installer/PerlDependencies.pm
create mode 100644 cpanfile
delete mode 100755 t/Installer_PerlDependencies.t
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list