[koha-commits] main Koha release repository branch 19.05.x updated. v19.05.07-76-g4c0fc622a5

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.05.x has been updated
       via  4c0fc622a5ca6029e6c0b1dee42ac50a090ed32c (commit)
      from  afab0af590c320a1d57e4ea1305a4ff83f988851 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 4c0fc622a5ca6029e6c0b1dee42ac50a090ed32c
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Nov 20 12:22:58 2019 +0100

    Bug 23064: Use Koha::Subscription in ModSubscription
    
    We must use Koha::Subscription instead of raw SQL.
    It will fix issue with default and integer values.
    
    Test plan:
    Edit a subscription and set number of issues = "f"
    Save
    => Without this patch there is a SQL error in the log:
      Incorrect integer value: 'f' for column 'numberlength'
    => With this patch the other changes are effective.
    
    Note: We also could change the type attribute of the input to "number",
    to have a client-side check
    
    Also, the return value of ModSuggestion is never used, so we are safe
    with that.
    
    Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
    (cherry picked from commit d79888822bba76c1eab3530f5b792bd7c88bbbde)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Serials.pm | 74 ++++++++++++++++++++++++++++++++++++-----------------------
 1 file changed, 45 insertions(+), 29 deletions(-)


hooks/post-receive
-- 
main Koha release repository