[koha-commits] main Koha release repository branch 19.05.x updated. v19.05.07-104-gdea0fd686b

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.05.x has been updated
       via  dea0fd686bde78d836e8b164fa62c70968c156f4 (commit)
      from  87eb710ad024da8a2018eba6442ed37d76a8bf98 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit dea0fd686bde78d836e8b164fa62c70968c156f4
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Jan 30 11:51:25 2020 +0100

    Bug 24543: Fix wrong test in api/v1/checkouts.t
    
    In t/db_dependent/api/v1/checkouts.t we define a circulation rule with renewalperiod=7.
    But then the expected due date is today+14 days.
    However, at the beginning of the script, the due_date of the issue is today+14 days.
    
    That highlight that the renewal period is not taken into account.
    
    The circulation rule is created with renewalperiod and renewalsallowed,
    however GetLoanLength check the existence of issuelength to return the rule.
    GetLoanLength finally return the default rule, with renewalperiod=0
    
    Note that this has been found working on bug 18936, code will be cleaned on that patchset.
    
    Test plan:
     % prove t/db_dependent/api/v1/checkouts.t
    must return green before and after this patch
    
    Signed-off-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
    (cherry picked from commit 265f0c4041de9a109b0535d7fab3d95fdfcb34a8)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 t/db_dependent/api/v1/checkouts.t | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)


hooks/post-receive
-- 
main Koha release repository