[koha-commits] main Koha release repository branch 18.11.x updated. v18.11.13-21-gd08c330b5c

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.11.x has been updated
       via  d08c330b5cf44012a6f05bdeca42e2b36154e931 (commit)
      from  7de90623889013b8b14a9074bf0a923fc8519d8e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit d08c330b5cf44012a6f05bdeca42e2b36154e931
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Thu Jan 2 10:30:54 2020 -0500

    Bug 24330: When importing patrons from CSV, automatically strip BOM from file if it exists
    
    We have a partner that exports UTF-8 CSV files, and is experiencing the same thing as the author of this article: https://www.freecodecamp.org/news/a-quick-tale-about-feff-the-invisible-character-cd25cd4630e7/
    
    In short, Excel is inserting an invisible UTF-8 character at the start of the file, so that the column name "cardnumber" is actually named "\x{feff}cardnumber", causing "cardnumber" to be blank.
    
    A simple solution is provided here: https://stackoverflow.com/questions/24390034/remove-bom-from-string-with-perl
    
    Test Plan:
    1) Download the example.csv file
    2) Attempt to import it using the patron import tool
    3) Note the invalid column name error
    4) Apply this patch, restart all the things!
    5) Attempt the import again
    6) Assuming you have a branchcode MPL and a cataegory code S, the patron should import!
    
    Signed-off-by: David Nind <david at davidnind.com>
    Signed-off-by: Maggie Wong <maggie.wong at yccece.edu.hk>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
    (cherry picked from commit 91980f27a30b2f57c59ea0da955b697ed6a98528)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    (cherry picked from commit 40ae65e32655e555e30bafec874c7724638a64a0)
    
    Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>

-----------------------------------------------------------------------

Summary of changes:
 Koha/Patrons/Import.pm | 1 +
 1 file changed, 1 insertion(+)


hooks/post-receive
-- 
main Koha release repository